[GitHub] spark pull request #22458: [SPARK-25459][SQL] Add viewOriginalText back to C...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/22458


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22458: [SPARK-25459][SQL] Add viewOriginalText back to C...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/22458#discussion_r221096819
  
--- Diff: 
sql/core/src/test/resources/sql-tests/results/higher-order-functions.sql.out ---
@@ -201,6 +201,7 @@ struct<>
 -- !query 20 output
 
 
+
--- End diff --

This one seems to be GitHub issue. When I check this PR, this file is the 
same with master branch.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22458: [SPARK-25459][SQL] Add viewOriginalText back to C...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/22458#discussion_r221089188
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
 ---
@@ -331,6 +332,7 @@ case class CatalogTable(
 comment.foreach(map.put("Comment", _))
 if (tableType == CatalogTableType.VIEW) {
   viewText.foreach(map.put("View Text", _))
+  viewOriginalText.foreach(map.put("View Original Text:", _))
--- End diff --

+1 for @MaxGekk 's comment. 
@zheyuan28 .  Please review and merge, 
https://github.com/zheyuan28/spark-1/pull/2 .


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org