[GitHub] spark pull request #22564: [SPARK-25282][K8s][DOC] Improved docs to avoid ru...
Github user ScrapCodes closed the pull request at: https://github.com/apache/spark/pull/22564 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22564: [SPARK-25282][K8s][DOC] Improved docs to avoid ru...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22564#discussion_r223188473 --- Diff: docs/running-on-kubernetes.md --- @@ -123,6 +123,20 @@ Starting with Spark 2.4.0, it is possible to run Spark applications on Kubernete runs in client mode, the driver can run inside a pod or on a physical host. When running an application in client mode, it is recommended to account for the following factors: +### Make a distribution + +In the case you are working with latest code directly from the git code base of Apache Spark, by building from the source. --- End diff -- This and the sentence below aren't quite grammatical. This also kind of duplicates the docs on how to build a release. Why not just say something like: When testing against a custom build of Spark, from the latest source code or custom modifications, it's necessary to create a release and deploy images to a Docker repository. See the [Docker images] section, and [docs on releasing]. Example: ... example command ``` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22564: [SPARK-25282][K8s][DOC] Improved docs to avoid ru...
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22564#discussion_r223074005 --- Diff: docs/running-on-kubernetes.md --- @@ -123,6 +123,20 @@ Starting with Spark 2.4.0, it is possible to run Spark applications on Kubernete runs in client mode, the driver can run inside a pod or on a physical host. When running an application in client mode, it is recommended to account for the following factors: +### Make a distribution + +In the case you are working with latest code directly from the git code base of Apache Spark, by building from the source. --- End diff -- Nit: `the latest code` and `a docker repository` below. Also please use `Spark` with a capital `S` consistently. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22564: [SPARK-25282][K8s][DOC] Improved docs to avoid ru...
GitHub user ScrapCodes opened a pull request: https://github.com/apache/spark/pull/22564 [SPARK-25282][K8s][DOC] Improved docs to avoid running into InvalidClassException. ## What changes were proposed in this pull request? Documentation changes, on client mode. A user needs to make a distribution before he can use client mode. ## How was this patch tested? Doc improvement comments are based on running locally. The patch itself is a document patch, so may not need testing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ScrapCodes/spark SPARK-25282/docs-k8s-client-mode Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22564.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22564 commit 0a4cd605b5b872148fb4649f9b3e167125f4f653 Author: Prashant Sharma Date: 2018-09-27T06:52:25Z [SPARK-25282][K8s][DOC] Improved docs to avoid running into InvalidClassException. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
