[GitHub] spark pull request #22681: [SPARK-25682][k8s] Package example jars in same t...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22681 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22681: [SPARK-25682][k8s] Package example jars in same t...
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22681#discussion_r226289881 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile --- @@ -18,6 +18,7 @@ FROM openjdk:8-alpine ARG spark_jars=jars +ARG example_jars=examples/jars --- End diff -- Also the K8S integration tests currently assume that the examples JAR is present since they rely upon running code from the examples --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22681: [SPARK-25682][k8s] Package example jars in same t...
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22681#discussion_r225259793 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile --- @@ -18,6 +18,7 @@ FROM openjdk:8-alpine ARG spark_jars=jars +ARG example_jars=examples/jars --- End diff -- Different change? ATM the existing code does not make this optional. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22681: [SPARK-25682][k8s] Package example jars in same t...
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22681#discussion_r224314585 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile --- @@ -18,6 +18,7 @@ FROM openjdk:8-alpine ARG spark_jars=jars +ARG example_jars=examples/jars --- End diff -- could we make this optional? if someone wants to build a smaller image without example --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22681: [SPARK-25682][k8s] Package example jars in same t...
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/22681 [SPARK-25682][k8s] Package example jars in same target for dev and distro images. This way the image generated from both environments has the same layout, with just a difference in contents that should not affect functionality. Also added some minor error checking to the image script. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark SPARK-25682 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22681.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22681 commit 97e0fe2b847e96518f8aeb4cdf6ab7efcdd08dba Author: Marcelo Vanzin Date: 2018-10-09T23:40:45Z [SPARK-25682][k8s] Package example jars in same target for dev and distro images. This way the image generated from both environments has the same layout, with just a difference in contents that should not affect functionality. Also added some minor error checking to the image script. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
