[GitHub] spark pull request #22929: [SPARK-25927][SQL] Fix number of partitions retur...

2018-11-10 Thread MaxGekk
Github user MaxGekk closed the pull request at:

https://github.com/apache/spark/pull/22929


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #22929: [SPARK-25927][SQL] Fix number of partitions retur...

2018-11-02 Thread MaxGekk
GitHub user MaxGekk opened a pull request:

https://github.com/apache/spark/pull/22929

[SPARK-25927][SQL] Fix number of partitions returned by outputPartitioning

## What changes were proposed in this pull request?

In the PR, I propose to make the `outputPartitioning()` method abstract and 
implement it in child nodes to return actual number of partitions. Currently 
the method returns 0 partitions by default which is wrong in most cases.

## How was this patch tested?

It was tested by SqlQueryTestSuite.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MaxGekk/spark-1 output-partitioning

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/22929.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22929


commit c1291848d9443c6ea0dd009a0d107473a30da1a0
Author: Maxim Gekk 
Date:   2018-11-02T08:41:09Z

Fix number partitions returned by outputPartitioning

commit 25f57f92bfcf28b1b29d75dde75fc2dd358488cb
Author: Maxim Gekk 
Date:   2018-11-02T09:59:54Z

Fix number of partitions for union

commit 4484b242af756b0afd7f0e947512e72069e175ee
Author: Maxim Gekk 
Date:   2018-11-02T10:14:37Z

Replacing def by lazy val




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org