GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/23144
[SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML
## What changes were proposed in this pull request?
1, methods `lowerCaseInArray` and `upperCaseInArray` are created in
`ParamValidators` to check case-insensitivity;
2, methods `$$(param: Param[String])` and `%%(param: Param[String])` are
created in trait Params to lower/upper the param value conveniently;
3, in `SharedParamsCodeGen`, `handleInvalid` and `distanceMeasure` are
updated to use `lowerCaseInArray`;
4, make string params (except colnames) in ml case-insensitive
## How was this patch tested?
updated suites
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhengruifeng/spark case_insensitive_params
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/23144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23144
----
commit 85a5fcb5d7d20b3adc97c59b726c941ef071d5a6
Author: zhengruifeng <ruifengz@...>
Date: 2018-11-05T10:33:34Z
init
commit e8f0cb40a822c124d7bba03765064bba8725315b
Author: zhengruifeng <ruifengz@...>
Date: 2018-11-22T10:20:13Z
fix conflict
commit 8be289ebb5e0118669514e3e2c531623ed698b4e
Author: zhengruifeng <ruifengz@...>
Date: 2018-11-23T03:19:22Z
use 2418 as lowercase
commit 810d8556beef0a27bd39723c2e5733da1d546621
Author: zhengruifeng <ruifengz@...>
Date: 2018-11-23T03:28:32Z
update CodeGen
commit e55244afa41e959f99c02f1afbe916fc7d1ffec3
Author: zhengruifeng <ruifengz@...>
Date: 2018-11-26T09:17:18Z
update suites
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
