GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/23229
[MINOR][CORE] Modify some field name because it may be cause confusion
## What changes were proposed in this pull request?
There is different field name style for tracking allocated data pages,
such as class BytesToBytesMap use field name dataPages for allocated data
pages,
class UnsafeExternalSorter and ShuffleExternalSorter use field name
allocatedPages for allocated data pages
They are all belong to memory consumer, so I think it is best to use
unified name;
and class TaskMemoryManager filed name allocatedPages is modified to
pagesBitSetï¼used to indicate the function of bitmap ;
## How was this patch tested?
Existing tests
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangjiaochun/spark memory_consumer_name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/23229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23229
commit 00fa455a6e145350a2bc5750df54cd0a9d1f0cdc
Author: 10087686
Date: 2018-12-05T08:48:08Z
modify field name in MemoryConsumer
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
