Re: [PR] [SPARK-37932][SQL]Wait to resolve missing attributes before applying DeduplicateRelations [spark]

2024-03-07 Thread via GitHub


peter-toth commented on PR #35684:
URL: https://github.com/apache/spark/pull/35684#issuecomment-1984107426

   @martinf-moodys, 
[SPARK-47319](https://issues.apache.org/jira/browse/SPARK-47319) / 
https://github.com/apache/spark/pull/45424 might help, especially if you have 
many `Union` nodes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-37932][SQL]Wait to resolve missing attributes before applying DeduplicateRelations [spark]

2024-02-29 Thread via GitHub


martinf-moodys commented on PR #35684:
URL: https://github.com/apache/spark/pull/35684#issuecomment-1970792026

   Hi @cloud-fan, @chenzhx,
   Checking for missing references is very costly on my workflow, due to the 
call to `missingInput`. Do you think it could be optimized, either by doing 
this check faster or changing when `DeduplicateRelations` is called so that 
this check is no longer necessary?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org