Re: [PR] [SPARK-48002][PYTHON][SS][TESTS] Adds sleep before event testing after query termination [spark]

2024-04-29 Thread via GitHub


HyukjinKwon closed pull request #46275: [SPARK-48002][PYTHON][SS][TESTS] Adds 
sleep before event testing after query termination
URL: https://github.com/apache/spark/pull/46275


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48002][PYTHON][SS][TESTS] Adds sleep before event testing after query termination [spark]

2024-04-29 Thread via GitHub


HyukjinKwon commented on PR #46275:
URL: https://github.com/apache/spark/pull/46275#issuecomment-2082058695

   Merged to master.
   
   I will revert this if that persists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48002][PYTHON][SS][TESTS] Adds sleep before event testing after query termination [spark]

2024-04-29 Thread via GitHub


HyukjinKwon commented on PR #46275:
URL: https://github.com/apache/spark/pull/46275#issuecomment-208168

   cc @WweiL 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[PR] [SPARK-48002][PYTHON][SS][TESTS] Adds sleep before event testing after query termination [spark]

2024-04-29 Thread via GitHub


HyukjinKwon opened a new pull request, #46275:
URL: https://github.com/apache/spark/pull/46275

   ### What changes were proposed in this pull request?
   
   This PR is a followup of https://github.com/apache/spark/pull/46237 that 
makes to wait 5 secs after the query termination to make sure the events arrive.
   
   ### Why are the changes needed?
   
   To deflake the test. It's flaky 
(https://github.com/apache/spark/actions/runs/8873809388/job/24360221027)
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, test-only.
   
   ### How was this patch tested?
   
   Manually.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org