Re: [PR] [SPARK-44170][BUILD][FOLLOWUP] Align JUnit5 dependency's version and clean up exclusions [spark]
dongjoon-hyun commented on PR #46160: URL: https://github.com/apache/spark/pull/46160#issuecomment-2071442761 Merged to master. Thank you, @pan3793 and all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44170][BUILD][FOLLOWUP] Align JUnit5 dependency's version and clean up exclusions [spark]
dongjoon-hyun closed pull request #46160: [SPARK-44170][BUILD][FOLLOWUP] Align JUnit5 dependency's version and clean up exclusions URL: https://github.com/apache/spark/pull/46160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44170][BUILD][FOLLOWUP] Align JUnit5 dependency's version and clean up exclusions [spark]
pan3793 commented on code in PR #46160: URL: https://github.com/apache/spark/pull/46160#discussion_r1575535040 ## pom.xml: ## @@ -220,6 +220,9 @@ 4.1.109.Final 2.0.65.Final 72.1 +5.9.1 Review Comment: @dongjoon-hyun sorry, that's a typo, corrected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44170][BUILD][FOLLOWUP] Align JUnit5 dependency's version and clean up exclusions [spark]
pan3793 commented on code in PR #46160: URL: https://github.com/apache/spark/pull/46160#discussion_r1575534643 ## pom.xml: ## @@ -220,6 +220,9 @@ 4.1.109.Final 2.0.65.Final 72.1 +5.9.1 Review Comment: ```suggestion 5.9.3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44170][BUILD][FOLLOWUP] Align JUnit5 dependency's version and clean up exclusions [spark]
dongjoon-hyun commented on code in PR #46160: URL: https://github.com/apache/spark/pull/46160#discussion_r1575402128 ## pom.xml: ## @@ -220,6 +220,9 @@ 4.1.109.Final 2.0.65.Final 72.1 +5.9.1 Review Comment: May I ask why we downgrade this, @pan3793 ? Previously, we have `5.9.3`. https://github.com/apache/spark/blob/ac9a12ef6e062ae07e878e202521b22de9979a17/pom.xml#L1239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44170][BUILD][FOLLOWUP] Align JUnit5 dependency's version and clean up exclusions [spark]
pan3793 commented on code in PR #46160:
URL: https://github.com/apache/spark/pull/46160#discussion_r1574586567
##
pom.xml:
##
@@ -1236,13 +1220,49 @@
org.junit.jupiter
junit-jupiter
-5.9.3
+${junit-jupiter.version}
Review Comment:
I suppose so, at least the single `junit-jupiter` does not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44170][BUILD][FOLLOWUP] Align JUnit5 dependency's version and clean up exclusions [spark]
LuciferYang commented on code in PR #46160:
URL: https://github.com/apache/spark/pull/46160#discussion_r1574537815
##
pom.xml:
##
@@ -1236,13 +1220,49 @@
org.junit.jupiter
junit-jupiter
-5.9.3
+${junit-jupiter.version}
Review Comment:
need all of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44170][BUILD][FOLLOWUP] Align JUnit5 dependency's version and clean up exclusions [spark]
LuciferYang commented on PR #46160: URL: https://github.com/apache/spark/pull/46160#issuecomment-2069074161 > run `mvn clean install -pl core -am -Dtest.exclude.tags=org.apache.spark.tags.ExtendedLevelDBTest` > > ``` > [ERROR] java.lang.NoClassDefFoundError: org/junit/platform/commons/util/ClassNamePatternFilterUtils > [INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 > ``` > > Seems we can't delete the exclusion directly, perhaps the TODO comments need to be changed. This issue no longer exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44170][BUILD][FOLLOWUP] Align JUnit5 dependency's version and clean up exclusions [spark]
pan3793 commented on code in PR #46160:
URL: https://github.com/apache/spark/pull/46160#discussion_r1574508952
##
pom.xml:
##
@@ -1236,13 +1220,49 @@
org.junit.jupiter
junit-jupiter
-5.9.3
+${junit-jupiter.version}
+test
+
+
+org.junit.jupiter
+junit-jupiter-api
+${junit-jupiter.version}
+test
+
+
+org.junit.jupiter
+junit-jupiter-engine
+${junit-jupiter.version}
+test
+
+
+org.junit.jupiter
+junit-jupiter-params
+${junit-jupiter.version}
+test
+
+
+org.junit.platform
+junit-platform-commons
+${junit-platform.version}
+test
+
+
+org.junit.platform
+junit-platform-engine
+${junit-platform.version}
+test
+
+
+org.junit.platform
+junit-platform-launcher
+${junit-platform.version}
test
net.aichler
jupiter-interface
-0.11.1
+${sbt-jupiter-interface.version}
Review Comment:
The project name is
[sbt-jupiter-interface](https://github.com/sbt/sbt-jupiter-interface) and it
does is used to make SBT supports jupiter tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
