LuciferYang commented on PR #46000:
URL: https://github.com/apache/spark/pull/46000#issuecomment-2049409756
> Wait, I found other classes with similar issues. Let me handle them all at
once. https://private-user-images.githubusercontent.com/15246973/321598819-68ef7569-b9ed-4a3c-8eb9-543cbeae16e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI4MzIxNDIsIm5iZiI6MTcxMjgzMTg0MiwicGF0aCI6Ii8xNTI0Njk3My8zMjE1OTg4MTktNjhlZjc1NjktYjllZC00YTNjLThlYjktNTQzY2JlYWUxNmUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDExVDEwMzcyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTllODFiNjllMzUyMzhjNjBkODhkMDEwOWM1Mjg0ZGY3Mjc4ZjRlODQ4ZGQ4ZWM5ZTE0MGE2ZDBjMzUzOWJmZTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-CpVWVyA7ZW27ejGo5IpmLQILqg-SS0RzilbCrr1AeQ;>
There are some classes that are just called `**Test`, they may not
necessarily be suitable for placement in the `test` directory, such as
`ANOVATest`, `ChiSquareTest` and `FValueTest`, in fact, they are used by
`UnivariateFeatureSelector`.
also cc @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
