Re: [PR] [SPARK-48021][ML][BUILD][FOLLOWUP] add `--add-modules=jdk.incubator.vector` to maven compile args [spark]

2024-04-28 Thread via GitHub 


LuciferYang commented on PR #46259:
URL: https://github.com/apache/spark/pull/46259#issuecomment-2081389478

   Merged into master for Spark 4.0. Thanks @panbingkun and @yaooqinn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-48021][ML][BUILD][FOLLOWUP] add `--add-modules=jdk.incubator.vector` to maven compile args [spark]

2024-04-28 Thread via GitHub 


LuciferYang closed pull request #46259: [SPARK-48021][ML][BUILD][FOLLOWUP] add 
`--add-modules=jdk.incubator.vector` to maven compile args
URL: https://github.com/apache/spark/pull/46259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-48021][ML][BUILD][FOLLOWUP] add `--add-modules=jdk.incubator.vector` to maven compile args [spark]

2024-04-27 Thread via GitHub 


panbingkun commented on PR #46259:
URL: https://github.com/apache/spark/pull/46259#issuecomment-2081311526

   > We can manually verify it through Maven test `build/mvn test -pl 
mllib-local`:
   > 
   > Before
   > 
   > 
![image](https://private-user-images.githubusercontent.com/1475305/326227170-1c002f85-175e-4554-a5a5-b05eab244f9c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQyNzU2NzQsIm5iZiI6MTcxNDI3NTM3NCwicGF0aCI6Ii8xNDc1MzA1LzMyNjIyNzE3MC0xYzAwMmY4NS0xNzVlLTQ1NTQtYTVhNS1iMDVlYWIyNDRmOWMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDQyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA0MjhUMDMzNjE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTlhOGI1MTJjMWU0MjE3M2Y3MmNjNGVhNGIwYmQyODc3MzJmN2MzZDVmYTJkZDM4NjNlMDViMzFmZTBkY2FmOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ._Ae8O1t1Ofi7WlGtxQmaA_UWJxjm2XvAIiv65vMSfgs)
   > 
   > there is a WARNING message: `警告: Failed to load implementation 
from:dev.ludovic.netlib.blas.VectorBLAS`
   > 
   > After
   > 
   > 
![image](https://private-user-images.githubusercontent.com/1475305/326227204-a83b89c0-944d-45ce-9b96-572448d5d97e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQyNzU2NzQsIm5iZiI6MTcxNDI3NTM3NCwicGF0aCI6Ii8xNDc1MzA1LzMyNjIyNzIwNC1hODNiODljMC05NDRkLTQ1Y2UtOWI5Ni01NzI0NDhkNWQ5N2UucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDQyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA0MjhUMDMzNjE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDAyMWRmZDc1YzQwZmVlYzNkZmFlMjY1NGZkZGQ3YjMxM2IwZGZlODk0YTI0MTFhYTg1NDFiOTZlMDgzYzZjOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.HjdC3RXp4IUCcRFBr5Oo_viTQzeQTxo4ceNqZHCMaqs)
   > 
   > no WARNING message related to `VectorBLAS`
   
   Yeah


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-48021][ML][BUILD][FOLLOWUP] add `--add-modules=jdk.incubator.vector` to maven compile args [spark]

2024-04-27 Thread via GitHub 


LuciferYang commented on PR #46259:
URL: https://github.com/apache/spark/pull/46259#issuecomment-2081310548

   We can manually verify it through Maven test:
   
   Before
   
   
![image](https://github.com/apache/spark/assets/1475305/1c002f85-175e-4554-a5a5-b05eab244f9c)
   
   there is a WARNING message: `警告: Failed to load implementation 
from:dev.ludovic.netlib.blas.VectorBLAS`
   
   After
   
   
   
![image](https://github.com/apache/spark/assets/1475305/a83b89c0-944d-45ce-9b96-572448d5d97e)
   
   no WARNING message related  to `VectorBLAS`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-48021][ML][BUILD][FOLLOWUP] add `--add-modules=jdk.incubator.vector` to maven compile args [spark]

2024-04-27 Thread via GitHub 


LuciferYang commented on PR #46259:
URL: https://github.com/apache/spark/pull/46259#issuecomment-2081303527

   Yes, we should keep `JavaModuleOptions`, `extraTestJavaArgs` in 
`SparkBuild.scala`, and `extraTestJavaArgs` in `pom.xml` consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-48021][ML][BUILD][FOLLOWUP] add `--add-modules=jdk.incubator.vector` to maven compile args [spark]

2024-04-27 Thread via GitHub 


panbingkun commented on PR #46259:
URL: https://github.com/apache/spark/pull/46259#issuecomment-2081303045

   cc @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org