Re: [PR] [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` [spark]
panbingkun commented on PR #46246: URL: https://github.com/apache/spark/pull/46246#issuecomment-2081300766 > @panbingkun we should add `--add-modules=jdk.incubator.vector` to `extraJavaTestArgs ` in `pom.xml` too > > https://github.com/apache/spark/blob/64d321926bbcede05d1c145405d503b3431f185b/pom.xml#L305-L323 Okay, let me do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` [spark]
LuciferYang commented on PR #46246: URL: https://github.com/apache/spark/pull/46246#issuecomment-2081298219 @panbingkun we should add `--add-modules=jdk.incubator.vector` to `pom.xml` too https://github.com/apache/spark/blob/64d321926bbcede05d1c145405d503b3431f185b/pom.xml#L305-L323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` [spark]
dongjoon-hyun commented on PR #46246: URL: https://github.com/apache/spark/pull/46246#issuecomment-2081266374 Merged to master. Thank you, @panbingkun and all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` [spark]
dongjoon-hyun closed pull request #46246: [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` URL: https://github.com/apache/spark/pull/46246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` [spark]
zhengruifeng commented on PR #46246: URL: https://github.com/apache/spark/pull/46246#issuecomment-2081262259 also cc @WeichenXu123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` [spark]
panbingkun commented on PR #46246: URL: https://github.com/apache/spark/pull/46246#issuecomment-2080865185 > Thank you for looking into that! Let me know what I should do to update dev.ludovic.netlib further for the needs of Spark Thank all for writing in such `detail` in the previous PR process. Because of this, I can easily analyze and trace the details of history. ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` [spark]
luhenry commented on PR #46246: URL: https://github.com/apache/spark/pull/46246#issuecomment-2080831209 Thank you for looking into that! Let me know what I should do to update dev.ludovic.netlib further for the needs of Spark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` [spark]
panbingkun commented on PR #46246: URL: https://github.com/apache/spark/pull/46246#issuecomment-2080813720 > Before this flag was gated on Java 21 - it's OK to set this on earlier versions? OK if so Yes, the JDK version of the above manual test environment (local) is `17`. https://github.com/apache/spark/assets/15246973/dba0297a-e51e-49a2-bdf6-f4268cb51c34;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` [spark]
srowen commented on PR #46246: URL: https://github.com/apache/spark/pull/46246#issuecomment-2080797254 Before this flag was gated on Java 21 - it's OK to set this on earlier versions? OK if so -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48021][ML][BUILD] Add `--add-modules=jdk.incubator.vector` to `JavaModuleOptions` [spark]
panbingkun commented on PR #46246: URL: https://github.com/apache/spark/pull/46246#issuecomment-2080762133 cc @luhenry @srowen @zhengruifeng @dongjoon-hyun @LuciferYang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
