[GitHub] [spark] SparkQA commented on issue #26705: [SPARK-30072][SQL] Create dedicated planner for subqueries
SparkQA commented on issue #26705: [SPARK-30072][SQL] Create dedicated planner for subqueries URL: https://github.com/apache/spark/pull/26705#issuecomment-560153133 **[Test build #114685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114685/testReport)** for PR 26705 at commit [`ec4cd23`](https://github.com/apache/spark/commit/ec4cd2351f5e933829eb162135b0e9a34898b6c0). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26705: [SPARK-30072][SQL] Create dedicated planner for subqueries
AmplabJenkins commented on issue #26705: [SPARK-30072][SQL] Create dedicated planner for subqueries URL: https://github.com/apache/spark/pull/26705#issuecomment-560153276 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19507/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26705: [SPARK-30072][SQL] Create dedicated planner for subqueries
AmplabJenkins commented on issue #26705: [SPARK-30072][SQL] Create dedicated planner for subqueries URL: https://github.com/apache/spark/pull/26705#issuecomment-560153273 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
huaxingao commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-560072601 @srowen @dilipbiswal I have the following changes: 1. use the same ```table_identifier``` syntax for all the commands that use ```table_identifier``` 2. use the same ```view_identifier``` syntax for all the commands that use ```view_identifier``` 3. use the same ```partition_spec``` syntax for all the commands that use ```partition_spec``` 4. some of the commands have a space in between of the braces and text. Some of them don't. I make it consistent to have a space 5. remove ; from the end of the sql syntax There may be other inconsistencies. If I find more later, I will open a separate PR to fix the problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11
SparkQA removed a comment on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-560071356 **[Test build #114677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114677/testReport)** for PR 26594 at commit [`476d60e`](https://github.com/apache/spark/commit/476d60e469c213951e4a2ce16572328b62cb85ba). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11
SparkQA commented on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-560075473 **[Test build #114677 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114677/testReport)** for PR 26594 at commit [`476d60e`](https://github.com/apache/spark/commit/476d60e469c213951e4a2ce16572328b62cb85ba). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11
AmplabJenkins commented on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-560075547 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11
AmplabJenkins commented on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-560075550 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114677/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11
AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-560075547 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11
AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-560075550 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114677/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26724: return tightest common type when inferring schema
HyukjinKwon commented on a change in pull request #26724: return tightest
common type when inferring schema
URL: https://github.com/apache/spark/pull/26724#discussion_r352332088
##
File path: python/pyspark/sql/types.py
##
@@ -1095,8 +1095,7 @@ def _merge_type(a, b, name=None):
elif isinstance(b, NullType):
return a
elif type(a) is not type(b):
-# TODO: type cast (such as int -> long)
-raise TypeError(new_msg("Can not merge type %s and %s" % (type(a),
type(b
Review comment:
I'm not sure about this for two reasons:
1. We should make a copy of
[TypeCoercion.scala](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala)
and duplicate logics here in Python and Scala. I am not sure if this is really
what we want.
2. Even if we find a common wide type, it might not work due to Pyrolite
type mapping between JVM and Python (see
[EvaluatePython.scala#L89-L202](https://github.com/apache/spark/blob/5264164a67df498b73facae207eda12ee133be7d/sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala#L89-L202))
Are you able to make a minimised rule per
[EvaluatePython.scala#L89-L202](https://github.com/apache/spark/blob/5264164a67df498b73facae207eda12ee133be7d/sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala#L89-L202)
and add a test for such combinations? Otherwise, I would like just close.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26724: return tightest common type when inferring schema
HyukjinKwon commented on issue #26724: return tightest common type when inferring schema URL: https://github.com/apache/spark/pull/26724#issuecomment-560083684 Also, please file a JIRA and follow the PR template format (https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon opened a new pull request #26725: [DO_NOT_MERGE] Health Checking in PR Builder
HyukjinKwon opened a new pull request #26725: [DO_NOT_MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725 ### What changes were proposed in this pull request? Do not merge. I would like to see flaky tests in the PR builder. ### Why are the changes needed? ### Does this PR introduce any user-facing change? ### How was this patch tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560084782 **[Test build #114678 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114678/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
HyukjinKwon commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560084806 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560084881 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19501/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
HyukjinKwon commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560084877 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560084889 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19500/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560084879 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560084886 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560084881 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19501/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560084879 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560084889 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19500/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560084886 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
SparkQA commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560085615 **[Test build #114680 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114680/testReport)** for PR 26697 at commit [`23bef9c`](https://github.com/apache/spark/commit/23bef9cb752cc9a83eccd8e69a49eb57bdbd91fa). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560085613 **[Test build #114679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114679/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560085790 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560085793 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19502/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560085793 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19502/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560085790 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] WangGuangxin opened a new pull request #26726: [SPARK-30088][SQL]Adaptive execution should convert SortMergeJoin to BroadcastJoin when plan generates empty result
WangGuangxin opened a new pull request #26726: [SPARK-30088][SQL]Adaptive
execution should convert SortMergeJoin to BroadcastJoin when plan generates
empty result
URL: https://github.com/apache/spark/pull/26726
### What changes were proposed in this pull request?
Adaptive execution should convert `SortMergeJoin` to `BroadcastJoin` if the
subquery generates empty result.
### Why are the changes needed?
Adaptive execution try to convert `SortMergeJoin` to `BroadcastJoin` by
checking the `dataSize` metrics of spark plan. However, if the spark plan
generates empty result, the `dataSize` metrics is empty due to
`org.apache.spark.sql.execution.metric.SQLMetrics`'s initial value is -1, which
could lead to the following check return `false`
```
private def canBroadcast(plan: LogicalPlan): Boolean = {
plan.stats.sizeInBytes >= 0 && plan.stats.sizeInBytes <=
conf.autoBroadcastJoinThreshold
}
```
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Adding a test case in `AdaptiveQueryExecSuite`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26726: [SPARK-30088][SQL]Adaptive execution should convert SortMergeJoin to BroadcastJoin when plan generates empty result
AmplabJenkins commented on issue #26726: [SPARK-30088][SQL]Adaptive execution should convert SortMergeJoin to BroadcastJoin when plan generates empty result URL: https://github.com/apache/spark/pull/26726#issuecomment-560086540 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26726: [SPARK-30088][SQL]Adaptive execution should convert SortMergeJoin to BroadcastJoin when plan generates empty result
AmplabJenkins commented on issue #26726: [SPARK-30088][SQL]Adaptive execution should convert SortMergeJoin to BroadcastJoin when plan generates empty result URL: https://github.com/apache/spark/pull/26726#issuecomment-56008 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26726: [SPARK-30088][SQL]Adaptive execution should convert SortMergeJoin to BroadcastJoin when plan generates empty result
AmplabJenkins removed a comment on issue #26726: [SPARK-30088][SQL]Adaptive execution should convert SortMergeJoin to BroadcastJoin when plan generates empty result URL: https://github.com/apache/spark/pull/26726#issuecomment-560086540 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] WangGuangxin commented on issue #26726: [SPARK-30088][SQL]Adaptive execution should convert SortMergeJoin to BroadcastJoin when plan generates empty result
WangGuangxin commented on issue #26726: [SPARK-30088][SQL]Adaptive execution should convert SortMergeJoin to BroadcastJoin when plan generates empty result URL: https://github.com/apache/spark/pull/26726#issuecomment-560086709 @maryannxue @cloud-fan Could you please help review this ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
SparkQA commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560090385 **[Test build #114681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114681/testReport)** for PR 26644 at commit [`f28e0cf`](https://github.com/apache/spark/commit/f28e0cf32cab0945ec93bb884def497282517de5). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560090502 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560090504 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19503/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560090502 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560090504 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19503/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
HyukjinKwon commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095126 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095503 **[Test build #114682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114682/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095638 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095642 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19504/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095642 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19504/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095638 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095782 **[Test build #114678 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114678/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560084782 **[Test build #114678 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114678/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095874 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095879 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114678/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095874 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095879 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114678/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560085613 **[Test build #114679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114679/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560101888 **[Test build #114679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114679/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560102212 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114679/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560102210 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560102210 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560102212 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114679/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] javierivanov commented on issue #26698: [SPARK-29685][SQL] Adds format to the spark-sql output like its implemented by Dataset showString
javierivanov commented on issue #26698: [SPARK-29685][SQL] Adds format to the spark-sql output like its implemented by Dataset showString URL: https://github.com/apache/spark/pull/26698#issuecomment-560106053 Yeah, sure. The idea is to have a pure Scala implementation ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
HyukjinKwon commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560108359 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560108878 **[Test build #114683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114683/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560109014 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19505/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560109010 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560109010 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560109014 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19505/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560095503 **[Test build #114682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114682/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560110025 **[Test build #114682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114682/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560110232 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560110234 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114682/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560110234 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114682/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560110232 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
SparkQA commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560111439 **[Test build #114681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114681/testReport)** for PR 26644 at commit [`f28e0cf`](https://github.com/apache/spark/commit/f28e0cf32cab0945ec93bb884def497282517de5). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
SparkQA removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560090385 **[Test build #114681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114681/testReport)** for PR 26644 at commit [`f28e0cf`](https://github.com/apache/spark/commit/f28e0cf32cab0945ec93bb884def497282517de5). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560111534 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560111537 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114681/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560111534 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-560111537 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114681/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
SparkQA commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560111978 **[Test build #114680 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114680/testReport)** for PR 26697 at commit [`23bef9c`](https://github.com/apache/spark/commit/23bef9cb752cc9a83eccd8e69a49eb57bdbd91fa). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
SparkQA removed a comment on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560085615 **[Test build #114680 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114680/testReport)** for PR 26697 at commit [`23bef9c`](https://github.com/apache/spark/commit/23bef9cb752cc9a83eccd8e69a49eb57bdbd91fa). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560112163 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560112164 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114680/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins commented on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560112164 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114680/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-560112163 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560108878 **[Test build #114683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114683/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
SparkQA commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560124517 **[Test build #114683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114683/testReport)** for PR 26725 at commit [`62e2ef0`](https://github.com/apache/spark/commit/62e2ef019983b74c4b26fad240d21190fe890579). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560124753 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114683/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560124753 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114683/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins removed a comment on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560124752 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder
AmplabJenkins commented on issue #26725: [DO-NOT-MERGE] Health Checking in PR Builder URL: https://github.com/apache/spark/pull/26725#issuecomment-560124752 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
srowen commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-560125533 BTW what are the exponents on these figures -- can you print more? or print their magnitude? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls
AmplabJenkins commented on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls URL: https://github.com/apache/spark/pull/26727#issuecomment-560125649 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] XuQianJin-Stars opened a new pull request #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls
XuQianJin-Stars opened a new pull request #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls URL: https://github.com/apache/spark/pull/26727 ### What changes were proposed in this pull request? Enhanced implementation of JmxSink on RMI remote calls. E.g: service: jmx:rmi://127.0.0.1:1986/jndi/rmi://127.0.0.1:1986/jmxrmi to connect ### Why are the changes needed? JMX supports RMI remote which can be more suitable for production use. ### Does this PR introduce any user-facing change? Added JMX RMI remote port connection method. ### How was this patch tested? `JmxSinkSuite.scala` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26693: [MINOR][SS] Note that writer should not be closed in RateStreamMicroBatchStream.serialize
SparkQA commented on issue #26693: [MINOR][SS] Note that writer should not be closed in RateStreamMicroBatchStream.serialize URL: https://github.com/apache/spark/pull/26693#issuecomment-560125958 **[Test build #4955 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4955/testReport)** for PR 26693 at commit [`430bd5d`](https://github.com/apache/spark/commit/430bd5d7d0ba208b9fbfd73b0deb2c3192b0d60b). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls
AmplabJenkins commented on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls URL: https://github.com/apache/spark/pull/26727#issuecomment-560126407 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls
AmplabJenkins removed a comment on issue #26727: [SPARK-30087][CORE] Enhanced implementation of JmxSink on RMI remote calls URL: https://github.com/apache/spark/pull/26727#issuecomment-560125649 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dilipbiswal commented on a change in pull request #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
dilipbiswal commented on a change in pull request #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#discussion_r352360804 ## File path: docs/sql-ref-syntax-aux-cache-cache-table.md ## @@ -35,8 +35,14 @@ CACHE [ LAZY ] TABLE table_name - table_name - The name of the table to be cached. + table_identifier + +Specifies a table name, which may be optionally qualified with a database name. Review comment: @huaxingao Here, can we try and retain the original description ? How about : ``` Specifies the table name to be cached. A table name may be optionally qualified with a database name. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dilipbiswal commented on a change in pull request #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
dilipbiswal commented on a change in pull request #26721:
[SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
URL: https://github.com/apache/spark/pull/26721#discussion_r352360849
##
File path: docs/sql-ref-syntax-aux-cache-uncache-table.md
##
@@ -24,12 +24,18 @@ license: |
underlying entries should already have been brought to cache by previous
`CACHE TABLE` operation. `UNCACHE TABLE` on a non-existent table throws
Exception if `IF EXISTS` is not specified.
### Syntax
{% highlight sql %}
-UNCACHE TABLE [ IF EXISTS ] table_name
+UNCACHE TABLE [ IF EXISTS ] table_identifier
{% endhighlight %}
### Parameters
- table_name
- The name of the table or view to be uncached.
+ table_identifier
+
+Specifies a table name, which may be optionally qualified with a database
name.
Review comment:
@huaxingao Same comment as above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dilipbiswal commented on a change in pull request #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
dilipbiswal commented on a change in pull request #26721:
[SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
URL: https://github.com/apache/spark/pull/26721#discussion_r352361030
##
File path: docs/sql-ref-syntax-aux-refresh-table.md
##
@@ -26,17 +26,17 @@ lazy manner when the cached table or the query associated
with it is executed ag
### Syntax
{% highlight sql %}
-REFRESH [TABLE] tableIdentifier
+REFRESH [TABLE] table_identifier
{% endhighlight %}
### Parameters
- tableIdentifier
+ table_identifier
-Specifies a table name, which is either a qualified or unqualified name
that designates a table/view. If no database identifier is provided, it refers
to a temporary view or a table/view in the current database.
+Specifies a table name, which may be optionally qualified with a database
name.
Review comment:
@huaxingao ditto as above..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dilipbiswal commented on a change in pull request #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
dilipbiswal commented on a change in pull request #26721:
[SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
URL: https://github.com/apache/spark/pull/26721#discussion_r352361104
##
File path: docs/sql-ref-syntax-aux-show-partitions.md
##
@@ -26,19 +26,30 @@ partition spec.
### Syntax
{% highlight sql %}
-SHOW PARTITIONS table_name
-[ PARTITION ( partition_col_name [ = partition_col_val ] [ , ... ] ) ]
+SHOW PARTITIONS table_identifier [ partition_spec ]
{% endhighlight %}
### Parameters
- table_name
- The name of an existing table.
+ table_identifier
+
+Specifies a table name, which may be optionally qualified with a database
name.
+Syntax:
+
+[ database_name. ] table_name
+
+
- PARTITION ( partition_col_name [ = partition_col_val ] [ , ...
] )
- An optional parameter that specifies a comma separated list of key and
value pairs for
- partitions. When specified, the partitions that match the partition spec
are returned.
+ partition_spec
+
+An optional parameter that specifies a comma separated list of key and
value pairs
Review comment:
@huaxingao ditto as above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen opened a new pull request #26728: [SPARK-30012][CORE][SQL] Change classes extending scala collection classes to work with 2.13
srowen opened a new pull request #26728: [SPARK-30012][CORE][SQL] Change classes extending scala collection classes to work with 2.13 URL: https://github.com/apache/spark/pull/26728 Move some classes extending Scala collections into parallel source trees, to support 2.13; other minor collection-related modifications. ### What changes were proposed in this pull request? Modify some classes extending Scala collections to work with 2.13 as well as 2.12. In many cases, this means introducing parallel source trees, as the type hierarchy changed in ways that one class can't support both. ### Why are the changes needed? To support building for Scala 2.13 in the future. ### Does this PR introduce any user-facing change? There should be no behavior change. ### How was this patch tested? Existing tests. Note that the 2.13 changes are not tested by the PR builder, of course. They compile in 2.13 but can't even be tested locally. Later, once the project can be compiled for 2.13, thus tested, it's possible the 2.13 implementations will need updates. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
