[Citadel Development] Re: Subject lines
Awesome! > Sun Nov 22 2020 10:26:32 PM EST from IGnatius T Foobar @ Uncensored >Subject: Re: Subject lines > > >>2020-11-22 00:42 from rss >>Subject: buntu 20.04 >>In this article, we’ll discuss how to install Flask on Ubuntu >>20.04 inside a Python virtual environment. >> >>https://linuxize.com/post/how-to-install-flask-on-ubuntu-20-04/ >> >> > > >See that? The subject is cut way off. I've been seeing these forever. It >works properly in the new code. > > > >
[Citadel Development] Re: Subject lines
> 2020-11-22 00:42 from rss >Subject: buntu 20.04 >In this article, weâll discuss how to install Flask on Ubuntu >20.04 inside a Python virtual environment. > > https://linuxize.com/post/how-to-install-flask-on-ubuntu-20-04/ > See that? The subject is cut way off. I've been seeing these forever. It works properly in the new code.
[Citadel Development] Re: Subject lines
>I don't have it up here in front of me, but there is the section that if one >is empty, the other is populated. That may have dredged up things we never >knew existed. Right. I believe I have fixed that. Somewhere along the line, another developer made struct CtdlMessage a bit more opaque, and added methods to set/clear/read fields and keep track of the length of each field. In the RSS parser I was manipulating those fields directly with functions like striplt() which messed up the buffer sizes, among other things. While adding proper RFC2047 encoding, I fixed that problem too. So it's worth testing again. You just can't put the fix into production yet because the build is broken in other places while I finish the new inbox rules system.
[Citadel Development] Re: Subject lines
No, it's nothing to do with the latest commit. I probably fell behind in that conversation .. what I'm saying is.. Based on my testing of various popular Russian/International RSS feeds, it is possible there can be any kind of junk in not only the Subject Line, but also Author/Creator fields. I've seen, at minimum, plenty of html showing up in the From: header through room messages created by rss. It is not always complete, usually with the opening tag, and some additional text (probably up to the closing tag.) I don't have it up here in front of me, but there is the section that if one is empty, the other is populated. That may have dredged up things we never knew existed. The other comment was likely cryptic as well. I was offering the opinion that It makes no difference to me if Author/Creator is filled out. It could and maybe should be hard-coded as simply "rss" since it's technically not a deliverable address anyway, and it's unlikely someone would reply directly to it as though to contact the author, without looking at the content, or visiting the link first. No big deal, just my .02.. But, one small request of mine is, while you're in there .. can you add a log line so we can see why some feeds silently fail? I had started working on that, but was not that familiar with how to bubble it up from expat. If not, I'll get to it eventually. Thanks, and sorry for any misunderstanding. :) > Thu Nov 19 2020 11:01:12 PM EST from IGnatius T Foobar @ Uncensored >Subject: Re: Subject lines > > >>There is all kinds of junk in those subject lines.. even CDATA. Also > >Are you making this observation from an audit and/or test of the latest >commit, or from what is on Uncensored? I'm not *running* the fixed code yet >because there is another part of the build that is broken. When I finish the >new inbox rule parser I'll publish it all at once. > > > >
[Citadel Development] Re: Subject lines
>There is all kinds of junk in those subject lines.. even CDATA. Also >"Author/Creator". I think the Author/Creator code should be revisited... Are you making this observation from an audit and/or test of the latest commit, or from what is on Uncensored? I'm not *running* the fixed code yet because there is another part of the build that is broken. When I finish the new inbox rule parser I'll publish it all at once.
