Re: [Rosegarden-user] Segment Parameters Box
On 6/26/19 8:29 PM, Ted Felix wrote: I'll play around a bit and see if I can't give the whole thing a few pixels of breathing room. This looks pretty good: I agree. That works fine. -- D. Michael McIntyre ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Segment Parameters Box
On Wed, 26 Jun 2019 20:29:05 -0400 Ted Felix wrote: >On 6/26/19 8:17 PM, Ted Felix wrote: >> On 6/26/19 4:05 PM, D. Michael McIntyre wrote: >>> That did the trick. My only quibble now is that the label seems a few >>> pixels short. >> I'll play around a bit and see if I can't give the whole thing a few >> pixels of breathing room. > > This looks pretty good: > > m_label->setContentsMargins(4, 3, 4, 3); > > I'll go ahead and add that. > >Ted. Very pleased to see these details being looked at. Appearance is sometimes thought of as unimportant, but consistency not only looks better, but makes the UI easier to use. -- Will J Godfrey http://www.musically.me.uk Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Segment Parameters Box
On 6/26/19 8:17 PM, Ted Felix wrote: On 6/26/19 4:05 PM, D. Michael McIntyre wrote: That did the trick. My only quibble now is that the label seems a few pixels short. I'll play around a bit and see if I can't give the whole thing a few pixels of breathing room. This looks pretty good: m_label->setContentsMargins(4, 3, 4, 3); I'll go ahead and add that. Ted. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Segment Parameters Box
On 6/26/19 4:05 PM, D. Michael McIntyre wrote: That did the trick. My only quibble now is that the label seems a few pixels short. I noticed that as well. It looks like the "Edit" button was expanding that row in the layout quite a bit vertically. Now it's exactly the size that the text needs which feels rather claustrophobic. I'll play around a bit and see if I can't give the whole thing a few pixels of breathing room. Ted. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Segment Parameters Box
On 6/26/19 8:03 AM, Ted Felix wrote: the control. Now the layout is in control. The label simply expands to fill the layout horizontally. That did the trick. My only quibble now is that the label seems a few pixels short. I didn't save yesterday's build for comparison. Compared to my reference build, I'd say it's about 4 px shorter now. If that was a opening salvo on a campaign to tighten things up, it will probably be fine once everything else is balanced. As it sits today, that one label sticks out slightly. I didn't notice this yesterday, but I might have been focusing on the more obvious quibble. -- D. Michael McIntyre ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Segment Parameters Box
On 6/25/19 3:49 PM, D. Michael McIntyre wrote: What seems questionable is that this label text no longer seems to be constrained, I took one more crack at this in [r15606] and I think this approach is best. Essentially, the text no longer dictates the size (hint) of the control. Now the layout is in control. The label simply expands to fill the layout horizontally. That's what I wanted originally. Hopefully it will work properly now. give it a whirl. Thanks. Ted. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Segment Parameters Box
On 6/25/19 3:49 PM, D. Michael McIntyre wrote: What seems questionable is that this label text no longer seems to be constrained, Should be fixed in [r15604]. Ted. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Segment Parameters Box
On 6/25/19 3:49 PM, D. Michael McIntyre wrote: What seems questionable is that this label text no longer seems to be constrained, so if I click around and activate a segment with a stupidly long label, the entire parameter area side panel thing expands to accommodate this wide text. I'm thinking that was an oversight rather than a design choice. Definitely. Good catch. I'll have a look. Ted. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
[Rosegarden-user] Segment Parameters Box
Review and rewrite of the Segment Parameters box in the upper left is complete. Please grab the latest svn and give it a good brutal testing for me. Thanks. Ted. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
