Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)
@jlebon commented on this pull request. > @@ -0,0 +1,25 @@ +'\" t +.TH "RPM-DBUS-ANNOUNCE" "8" "03 Jun 2020" "Red Hat, Inc." +.SH NAME +rpm-plugin-dbus-announce \- DBus plugin for the RPM Package Manager + +.SH Description + +The plugin writes basic information about rpm transactions to the +system dbus - like packages installed or removed. Other programms can programs -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1255#pullrequestreview-426510237___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)
@cgwalters commented on this pull request.
> +state->logging = 1;
+
+/* ...don't log test transactions */
+if (rpmtsFlags(ts) & (RPMTRANS_FLAG_TEST|RPMTRANS_FLAG_BUILD_PROBS))
+ state->logging = 0;
+
+/* ...don't log chroot transactions */
+if (!rstreq(rpmtsRootDir(ts), "/"))
+ state->logging = 0;
+
+/* Don't open */
+if (!state->logging || state->bus)
+ return RPMRC_OK;
+
+if (lstat("/run/systemd/system/", ) == 0) {
+if (S_ISDIR(st.st_mode)) {
DBus the protocol doesn't need systemd (it predates it) but lately integrates
with it well. The reason I think we do this check is it's a proxy for "is this
system booted".
For example, there's no dbus running in a default podman/docker style container
(neither is there systemd, or in fact usually there isn't any other processes
at all except e.g. yum/zypper running). So there's no reason to try announcing.
Related discussion and code: https://github.com/systemd/systemd/pull/7631
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#discussion_r436890836___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)
Is there any coordination between this and the work to add dbus to libdnf in https://github.com/rpm-software-management/libdnf/pull/941 for example? For rpm-ostree we are already a DBus daemon, and having multiple other libraries in the stack also going out and talking to DBus is going to be a bit problematic. Binding this to the systemd-inhibit plugin makes sense because we already turn that off for rpm-ostree (because it's transactional, there's no reason to inhibit). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-640780302___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)
@mlschroe commented on this pull request.
> +state->logging = 1;
+
+/* ...don't log test transactions */
+if (rpmtsFlags(ts) & (RPMTRANS_FLAG_TEST|RPMTRANS_FLAG_BUILD_PROBS))
+ state->logging = 0;
+
+/* ...don't log chroot transactions */
+if (!rstreq(rpmtsRootDir(ts), "/"))
+ state->logging = 0;
+
+/* Don't open */
+if (!state->logging || state->bus)
+ return RPMRC_OK;
+
+if (lstat("/run/systemd/system/", ) == 0) {
+if (S_ISDIR(st.st_mode)) {
Pardon my ignorance, but why is this depending on some systemd directory? Does
dbus need systemd?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#pullrequestreview-426476154___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add support for dependency generators for RPMTAG_ORDERNAME (#1262)
aka OrderWithRequires. Use __find_order in the attribute files Resolves: #1257 Please test! You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1262 -- Commit Summary -- * Add support for dependency generators for RPMTAG_ORDERNAME -- File Changes -- M build/rpmfc.c (9) M build/rpmfc.h (7) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1262.patch https://github.com/rpm-software-management/rpm/pull/1262.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1262 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)
> But why? If a package contains a config is /usr/lib/sysusers.d/, why not to > ensure that it is installed after systemd-sysusers binary is present and so > the scriptlet which creates users can be executed? Yes, in that case the dependency is warranted. > If there is just a scriptlet which calls `systemctl preset` Each distribution can do this as they see fit, but at least in Fedora systemd.rpm calls `preset-all` upon installation, so the effect is the same no matter if packages with units are installed before or after. > In most cases, I agree, it is not needed, but seems to be not harmful. The reason to minimize dependencies is avoidance of circular dependencies. When there's a circular dependency, dnf will have to break the loop by ignoring some dependency, which can break some other script where the dependency is actually valid. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1257#issuecomment-640532705___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] %transfiletriggerin does not work on Fedora 33 (#1260)
Just to record my findings so far: - *some* %transfiletriggerin scripts do run, but not all - on erasure, the triggers on the very same conditions that miss on install do run, eg ``` $ rpm -q --filetriggers hicolor-icon-theme transfiletriggerin scriptlet (using /bin/sh) -- /usr/share/icons/hicolor gtk-update-icon-cache --force /usr/share/icons/hicolor &>/dev/null || : transfiletriggerpostun scriptlet (using /bin/sh) -- /usr/share/icons/hicolor gtk-update-icon-cache --force /usr/share/icons/hicolor &>/dev/null || : ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1260#issuecomment-640518161___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)
> I think this should set _with_check unless _without_check is defined already. > Basically to have `%bcond_without check` by default without having to put it > in all spec files. But still need to make sure that somebody defines > `%bcond_without check`, this code won't override it. That would be absolutely perfect, if there's a way to do it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1256#issuecomment-640515842___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)
I would like to avoid `nocheck`, because the common way to conditinalize would
be `%if %{without nocheck}` and that's just confusing to read.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1256#issuecomment-640514577___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] error: Couldn't exec metainfo(): No such file or directory (#1261)
Backported to rawhide & fixed in master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1261#issuecomment-640492804___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] error: Couldn't exec metainfo(): No such file or directory (#1261)
Closed #1261. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1261#event-3419175160___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)
Most tools rpm interacts with don't *have* their own configuration, that's mostly limited to SCMs. It might well be sufficient set HOME to some temporary build directory during build scriptlets, or something like that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#issuecomment-640433767___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] metainfo.attr: Fix execution of the generator (#1259)
Thanks for the patch though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1259#issuecomment-640429529___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] metainfo.attr: Fix execution of the generator (#1259)
Doh... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1259#issuecomment-640429423___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] metainfo.attr: Fix execution of the generator (#1259)
Merged #1259 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1259#event-3418629316___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] error: Couldn't exec metainfo(): No such file or directory (#1261)
Thanks @ignatenkobrain I tested that patch, worked fine :+1: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1261#issuecomment-640427891___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)
Did a PR for this on Friday. Comments on #1256 are welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/316#issuecomment-640425280___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)
May be the macro should be renamed to not collide with the with/without mechanism. The bcond mechnism assumes that the actual value is not set as a macro but only on the command line and is basically read only within the spec. If you set the macro itself having two of them can lead to the awkward situation where but are set to one or both are set to zero. So I would prefere to only have one macro. May be _nocheck is a better name and closer resembling the cli param. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1256#issuecomment-640421215___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] %transfiletriggerin does not work on Fedora 33 (#1260)
Okay, quite easily reproduced. Looks like our first reported bug in sqlite :beetle: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1260#issuecomment-640420247___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] error: Couldn't exec metainfo(): No such file or directory (#1261)
Sent patch yesterday https://github.com/rpm-software-management/rpm/pull/1259 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1261#issuecomment-640417518___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] error: Couldn't exec metainfo(): No such file or directory (#1261)
Any package Fedora 33/rawhide build that involved installing metainfo files has started giving error in build.log e.g. See this scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=45537932 which shows line ```error: Couldn't exec metainfo(): No such file or directory``` rpm-build-4.16.0-0.beta1.2.fc33.1 redhat-rpm-config-160-1.fc33 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1261___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
