Re: [Rpm-maint] [rpm-software-management/rpm] Make use of %apply_patch easier (#1357)

2020-09-17 Thread Panu Matilainen
If you don't use %autosetup then why not just call 'git' directly?

%apply_patch was never supposed to be called by anybody directly, but I realize 
now that it looks that way because it lacks underscore-prefixes. I guess I'll 
submit a PR to change that... (for those using %autosetup, you can pass a range 
to %autopatch for finer control)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1357#issuecomment-694657905___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add API for clone rpmps iterator (func rpmpsiClone) (#1359)

2020-09-17 Thread Panu Matilainen
That looks like such a hideously ineffective way of incrementing that people 
are better off not having it, IMO.
Real world use-cases outside the syntactic sugar category might be easier to 
sell.

Furthermore, there are some key iterators where this can't be implemented at 
all as the iterator is part of the structure itself (at least rpmds and rpmtd, 
the latter isn't even reference counted, and there might be others that I don't 
recall).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1359#issuecomment-694653660___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Add API for clone rpmps iterator (func rpmpsiClone) (#1359)

2020-09-17 Thread Jaroslav Rohel
There are missing API for cloning iterators in rpm library. PR adds function 
for cloning rpm problem set iterator.

The same is needed for others iterators. Eg. for creating post-increment 
`operator++(int)` in C++ wrapper.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1359

-- Commit Summary --

  * Add API for clone rpmps iterator (func rpmpsiClone)

-- File Changes --

M lib/rpmps.c (11)
M lib/rpmps.h (7)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1359.patch
https://github.com/rpm-software-management/rpm/pull/1359.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1359
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint