Re: [Rpm-maint] [rpm-software-management/rpm] Don't use _nl_msg_cat_cntr if __GLIC__ is not defined (PR #2856)
Thanks for the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2856#issuecomment-1905777264 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't use _nl_msg_cat_cntr if __GLIC__ is not defined (PR #2856)
Merged #2856 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2856#event-11568363991 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add "local_generator" (PR #2734)
`__override_file_attrs`, which would give higher prominence to the regular installed attrs and discouraged use of this feature. But that brings me back to the `__extra_file_attrs`, which I have read after I was thinking about `__override_file_attrs` ;) IOW `__extra_file_attrs` sounds good to me. `__additional_file_attrs` could also be option. It sounds mundane, but maybe that makes it the better choice. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2734#issuecomment-1905700754 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't use _nl_msg_cat_cntr if __GLIC__ is not defined (PR #2856)
@pastalian commented on this pull request. > @@ -532,7 +532,7 @@ static int filerequireTag(Header h, rpmtd td, > headerGetFlags hgflags) /* I18N look aside diversions */ -#if defined(ENABLE_NLS) +#if defined(ENABLE_NLS) && (defined(__GLIBC__) || !defined(__linux__)) like this? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2856#discussion_r1462984881 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't use _nl_msg_cat_cntr if __GLIC__ is not defined (PR #2856)
@pastalian pushed 1 commit. 68eefae75e63fb2a8f3b4a9253e73b6423ccd904 Don't use _nl_msg_cat_cntr if it's not available -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2856/files/da222f0d82721d17e57d491d2749a4bc44754b9d..68eefae75e63fb2a8f3b4a9253e73b6423ccd904 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Update format documentation in the manual (PR #2835)
I'm not actually finished with this, but I do have a local backup anyway, closing is okay. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2835#issuecomment-1905561075 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't use _nl_msg_cat_cntr if __GLIC__ is not defined (PR #2856)
@pmatilai commented on this pull request. > @@ -532,7 +532,7 @@ static int filerequireTag(Header h, rpmtd td, > headerGetFlags hgflags) /* I18N look aside diversions */ -#if defined(ENABLE_NLS) +#if defined(ENABLE_NLS) && (defined(__GLIBC__) || !defined(__linux__)) AFAICS this isn't specific to Linux in any way, just GNU gettext/glibc. In any case, it'd be better to just test for the symbol directly (in cmake). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2856#pullrequestreview-1838157664 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Pass arg1 to file trigger scripts (PR #2871)
I'm glad this ended up on your plate, I never found the patience to sort this out :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2871#issuecomment-1905533378 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Pass arg1 to file trigger scripts (PR #2871)
Merged #2871 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2871#event-11566516191 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add "local_generator" (PR #2734)
I find `packaged` quite misleading, because the case is to allow for attributes and generators that are local to the *build*. Those attributes *may also* be packaged, but that's not relevant for this feature. I see two separate main cases for this: - build a package with the generator it ships to avoid having to build twice - build a package with a generator that is only relevant for that package Back to bike-shedding. `__build_file_attrs` is closer maybe but then it suggests those are the *only* attrs for the build. `__extra_file_attrs` would seem accurate because no matter where they come from they are extra to the regular attrs. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2734#issuecomment-1905503860 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
