Re: [Rpm-maint] [rpm-software-management/rpm] Document %setup and %patch, officially deprecating %patchN (PR #2352)
Just note for someone including me who wants to know what RPM versions have this change. I can see the backported commit is on the rpm-4.18.x branch. And the RPM version 4.18.1 includes the commit. https://github.com/rpm-software-management/rpm/commit/c90144e2f899e4a5e053ecf899b1c4036be3e35c ``` $ git tag --contains c90144e2f899e4a5e053ecf899b1c4036be3e35c rpm-4.18.1-release ``` -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2352#issuecomment-1609764803 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Drop support for buggy and problematic alternative Python build method (PR #2231)
@junaruga commented on this pull request. > @@ -0,0 +1,11 @@ +Metadata-Version: 1.0 +Name: @PROJECT_NAME@ +Version: @PROJECT_VERSION@ +Summary: Python bindings for rpm +Home-page: @PROJECT_HOMEPAGE_URL@ +Author: Rpm community +Author-email: rpm-maint@lists.rpm.org +License: GNU General Public License v2 +Description: Python bindings for rpm +Platform: UNKNOWN + This blank line is intentional? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2231#pullrequestreview-1145878463 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Drop support for buggy and problematic alternative Python build method (PR #2231)
OK. Is there a way to create a PIP package from the `*.egg-info` file (`python/rpm.egg-info.in`)? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2231#issuecomment-1282324947 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Drop support for buggy and problematic alternative Python build method (PR #2231)
I am using the `setup.py.in` in the `rpm-py-installer` pip package that installs the RPM Python binding pip package, and enables people to use the RPM python binding on some Python environments. https://github.com/junaruga/rpm-py-installer -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2231#issuecomment-1282307661 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "%{?load:foo}" does not work with RPM 4.16.90 (#1669)
Yes, the bug in the rpmlint was fixed. For now the `%{load:foo}` is used in
`ruby.spec` on the Fedora rawhide (development version) branch instead of
`%{?load:foo}`.
We are asking here to understand more about the details and context.
* "If I am not mistaken, at that time, the question mark allowed to build at
least SRPM via older RPM." Did you remember it? Why did you drop it as
undocumented feature? I think It's more about a communication between us.
* "The question mark was useful for backward compatibility."
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-841352926___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "%{?load:foo}" does not work with RPM 4.16.90 (#1669)
Panu, is it possible to reopen this ticket until we find a fix of a friction between us? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-839130828___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "%{?load:foo}" does not work with RPM 4.16.90 (#1669)
> I'd love to hear real explanation first, because I think that the report you
> have made was misunderstood
@voxik for your above comment on our chat about my report here, I think it's
better to explain it here. Dees the real explanation mean @pmatilai 's answer
about why the RPM project dropped `{?load:foo}`, right? What was misunderstand
by people in RPM project here?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-839075139___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "load" does not work with RPM 4.16.90 (#1669)
> Sorry could you tell me what's wrong in the following code?
I was able to implement the own exists macro like this. I expect `rpmlint`
skips the load. But `rpmlint` still checks the load macro printing parsing
error. Now what we need to fix is rpmlint.
```
%global exists_file %{lua: posix.access(rpm.expand("%{1}"))}
%if %exists_file "%{SOURCE4}"
%{echo:loading %{SOURCE4}}
%{load:%{SOURCE4}}
%endif
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-833612235___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "load" does not work with RPM 4.16.90 (#1669)
@pmatilai I am seeing `doc/manual/lua.md` and https://rpm.org/user_doc/lua.html
. Sorry could you tell me what's wrong in the following code?
```
%load_if_exists(path) %{lua:
if posix.access(arg.path, "r") then
print("Loading " .. arg.path .. "..")
load(arg.path)
end
}
%load_if_exists %{SOURCE4}
```
```
$ fedpkg --release rawhide srpm
error: lua script failed: [string ""]:2: attempt to index a nil value
(global 'arg')
error: query of specfile /home/jaruga/git/pkg/fed/ruby/ruby.spec failed, can't
parse
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-833497556___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "load" does not work with RPM 4.16.90 (#1669)
@pmatilai ok thanks I will try it! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-833461866___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "load" does not work with RPM 4.16.90 (#1669)
Reopened #1669. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1669#event-4689242420___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "load" does not work with RPM 4.16.90 (#1669)
@pmatilai when using `%{load:...}`, the rpmlint failed to part the spec file.
https://github.com/rpm-software-management/rpmlint/issues/632 . The rpmlint can
not detect the loaded file's existence.
I see the `%{exists...}` is still new in RPM 4.17.
http://rpm.org/user_doc/macros.html
Is there a way to avoid the rpmlnt error?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-832699304___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "load" does not work with RPM 4.16.90 (#1669)
Closed #1669. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1669#event-4688478118___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "load" does not work with RPM 4.16.90 (#1669)
Thanks! I confirmed it works with `%{load: ...}`. I would close this ticket.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-832622783___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "load" does not work with RPM 4.16.90 (#1669)
Thanks for the info! Let me check it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-832605314___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] "load" does not work with RPM 4.16.90 (#1669)
I can try to create a minimal reproducer if you want. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-830852900___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] "load" does not work (#1669)
This issue might be same with #1663 .
* OS: Fedora 35 (rawhide) Linux
* RPM version: 4.16.90-0.git15395.2
I see the following error started to happen when building ruby on Koji. It
seems that the error is related to `load`.
```
DEBUG util.py:444: error: line 116: Unknown tag:
/chroot_tmpdir/srpm_unpacked/SOURCES/macros.ruby
```
https://src.fedoraproject.org/rpms/ruby/blob/rawhide/f/ruby.spec#_116
ruby.spec
```
...
Source4: macros.ruby
...
%{?load:%{SOURCE4}} # <= The error happens on this line 116.
...
```
Here is the dependencies of the ruby.spec. The error did not happen with RPM
4.16.1.3-1.fc35.
https://koschei.fedoraproject.org/build/10236312
Could you tell me how to fix? Is there a temporary workaround to build?
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Question: the way to check if "load" macro is built-in in a spec file (#1104)
Many thanks! As I could fixed the issue by the following way, I would close
this ticket.
```
# Call load builtin macro if it is defined, otherwise call own load macro
# to avoid an error by creating SRPM in RPM 4.15+
%if "%{load:/dev/null}" == ""
%{?load:%{SOURCE4}}
%{?load:%{SOURCE5}}
%else
%include %{SOURCE100}
%{load %{SOURCE4}}
%{load %{SOURCE5}}
%endif
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1104#issuecomment-616500829___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Question: the way to check if "load" macro is built-in in a spec file (#1104)
Guys, thanks for your info! It's useful.
For the hacks, it looks working.
With the RPM 4.15.1.
```
$ rpm --version
RPM version 4.15.1
$ rpm -E '%{load:/dev/null}'
<= empty
```
With the RPM 4.11.3.
```
sh-4.2# rpm --version
RPM version 4.11.3
sh-4.2# rpm -E '%{load:/dev/null}'
%{load:/dev/null}
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1104#issuecomment-616433593___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Question: the way to check if "load" macro is built-in in a spec file (#1104)
I tried following code in the `ruby.spec`.
But is there a way to check if the `load` builtin macro exists?
The part `%{defined load}` in the following code fails with `error:
/home/jaruga/git/rh-packages/scl/rh-ruby27/ruby/ruby.spec: line 99: failed to
load macro file 0`.
```
if %{defined load}
%{?load:%{SOURCE4}}
%{?load:%{SOURCE5}}
%else
%include %{SOURCE100}
%{load %{SOURCE4}}
%{load %{SOURCE5}}
%endif
```
Or is there a macro to check the used rpm version is >= 4.12.0 or not?
https://rpm.org/user_doc/macros.html
> %{load:...} load a macro file (in >= 4.12.0)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1104#issuecomment-615336072___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Question: the way to check if "load" macro is built-in in a spec file (#1104)
Possibly here is a part of the logic causing the error. https://github.com/rpm-software-management/rpm/blob/10127cdb2364de2c1408950a25b730920e665689/rpmio/macro.c#L638-L641 Here is the testing code to test the logic. https://github.com/rpm-software-management/rpm/blob/10127cdb2364de2c1408950a25b730920e665689/tests/rpmmacro.at#L28-L40 The change causing the error comes from the commit: https://github.com/rpm-software-management/rpm/commit/d86c0c28ab74686c59c81a38d04210f70456ce63 for the logic, and the commit: https://github.com/rpm-software-management/rpm/commit/9343ecd94cd873e6dc1c06428975163cbb9cf9af for testing code. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1104#issuecomment-609706113___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Question: the way to check if "load" macro is built-in in a spec file (#1104)
Sorry for my multiple post about this topic. Yesterday I posted below email to rpm-list mailing list, could you comment for this? http://lists.rpm.org/pipermail/rpm-list/2020-March/002013.html Feel free to close this GitHub issue page, if you like. Thanks for your help. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1104___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] %define macro value is not evaluated on rpm 4.11.3 (#1013)
Yeah, it's more readable. Thanks for sharing the tip. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1013#issuecomment-576670607___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] %define macro value is not evaluated on rpm 4.11.3 (#1013)
@pmatilai Thanks for your info!
After changing the spec file to use `%if` like this, `%release_string` macro
value was set.
```
diff --git a/foo.spec b/foo.spec
index 47a0596..b19233b 100644
--- a/foo.spec
+++ b/foo.spec
@@ -1,5 +1,7 @@
%global release 2
-%{!?release_string:%define release_string %{release}%{?dist}}
+%if ! 0%{?release_string}
+%define release_string %{release}%{?dist}
+%endif
```
```
+ find /root/rpmbuild/ -type f
/root/rpmbuild/SRPMS/foo-2.7.0-2.el7.src.rpm
/root/rpmbuild/RPMS/x86_64/foo-2.7.0-2.el7.x86_64.rpm
/root/rpmbuild/BUILD/foo
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1013#issuecomment-576610823___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] %define macro value is not evaluated on rpm 4.11.3 (#1013)
## How to reproduce this issue on your environment 1. Fork the repository: https://github.com/junaruga/report-rpm-macro-define 2. Enable Travis CI for the repository. 3. Check the Travis CI result modifying the `foo.spec` file. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1013#issuecomment-576319148___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] %define macro value is not evaluated on rpm 4.11.3 (#1013)
## Sumamry
`%define` macro is not evaluated, the value is not set when building a RPM spec
file with rpm-4.11.3-40 and `%bcond_without git` is executed.
## Context
I was trying to build a `ruby.spec` file on RHEL7, that is based on the Fedora
rawhide current latest `ruby.spec`
[URL](https://src.fedoraproject.org/rpms/ruby/blob/345ce0e5b8a3a6d9c962807da12e80bdaee9fb90/f/ruby.spec#_25).
But the built RPM was `ruby-2.7.0-%{release_string}.x86_64.rpm`. The
`%{release_string}` value was not set. On Fedora rawhide, the value was set.
The `ruby.spec` code is like this.
```
...
%global release 126
%{!?release_string:%define release_string
%{?development_release:0.}%{release}%{?development_release:.%{development_release}}%{?dist}}
...
%bcond_without git
...
Release: %{release_string}
...
```
So, I prepared the simple example to reproduce this issue, with GitHub and
Travis CI.
Here is [the reproducing
example](https://github.com/junaruga/report-rpm-macro-define), and the [Travis
CI
result](https://travis-ci.org/junaruga/report-rpm-macro-define/builds/639514301).
Using very simple RPM spec file
[foo.spec](https://github.com/junaruga/report-rpm-macro-define/blob/master/foo.spec),
and building it by `rpmbuild -ba foo.spec`.
Here is the result. See above Travis CI result.
1. fedora:rawhide / rpm-4.15.1-2.fc32.x86_64 : OK
2. fedora:31 / rpm-4.15.1-1.fc31.x86_64 : OK
3. centos:8.1 / rpm-4.14.2-25.el8.x86_64 : OK
4. centos:7.7 / rpm-4.11.3-40.el7.x86_64 : NG
5. centos:7.7 / rpm-4.11.3-40.el7.x86_64 does not execute `%bcond_without git`:
interestingly this case is OK
## Result
### OK case
https://travis-ci.org/junaruga/report-rpm-macro-define/jobs/639514306#L510
```
+ echo 'release_string: 2.el7.el7'
release_string: 2.el7.el7
+ echo 'bbb: 2'
bbb: 2
+ echo 'ddd: 2'
ddd: 2
+ echo 'fff: 2'
fff: 2
```
https://travis-ci.org/junaruga/report-rpm-macro-define/jobs/639514306#L556
```
+ find /root/rpmbuild/ -type f
/root/rpmbuild/SRPMS/foo-2.7.0-2.el7.src.rpm
/root/rpmbuild/RPMS/x86_64/foo-2.7.0-2.el7.x86_64.rpm
/root/rpmbuild/BUILD/foo
```
### NG case
https://travis-ci.org/junaruga/report-rpm-macro-define/jobs/639514305#L506
```
+ echo 'release_string: %{release_string}'
release_string: %{release_string}
+ echo 'bbb: %{bbb}'
bbb: %{bbb}
+ echo 'ddd: 2'
ddd: 2
+ echo 'fff: %{fff}'
fff: %{fff}
```
https://travis-ci.org/junaruga/report-rpm-macro-define/jobs/639514305#L552
```
+ find /root/rpmbuild/ -type f
/root/rpmbuild/SRPMS/foo-2.7.0-%{release_string}.src.rpm
/root/rpmbuild/RPMS/x86_64/foo-2.7.0-%{release_string}.x86_64.rpm
/root/rpmbuild/BUILD/foo
```
## Questions
1. Why this issue happens on rpm 4.11.3 when only `%bcond_without git` is
executed?
2. When Fedora's `ruby.spec` has to consider backward ccompatibility on
CentOS7, what is the best pracitce dealing with `%define` macro? We should not
use `%define` macro?
Thank you.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1013___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Supporting %patch -T option (#788)
Thanks for the info. I understand it. I simply like the behavior like `cp -p` just to preserve the timestamp. Because it always update the file as fixed date. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/788#issuecomment-511121609___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Supporting %patch -T option (#788)
I tested `patch -Z` on my local using this repository's README file. I created below 2 files based on a result of `diff -u`. I expected the patched file is updated as fixed value. But actually on below cases, it is updated as system date even when using `patch -Z`. Just implementing `patch -Z` option is not enough. Because I always want to see the patched file is updated as fixed date when using the option. ``` $ rpm -q patch patch-2.7.6-9.fc30.x86_64 $ patch -v | head -1 GNU patch 2.7.6 ``` ## diff file with date header ``` $ cat readme.diff --- a/README2019-07-11 16:33:14.340372704 +0200 +++ b/README2019-07-12 16:00:00.684469239 +0200 @@ -1,3 +1,4 @@ +aaa This is RPM, the RPM Package Manager. The latest releases are always available at: ``` ``` $ touch -d 20190101 README $ ls -l README -rw-rw-r-- 1 jaruga jaruga 603 Jan 1 2019 README $ patch -p1 -Z < readme.diff patching file README Not setting time of file README (time mismatch) $ ls -l README -rw-rw-r-- 1 jaruga jaruga 607 Jul 12 16:58 README ``` `README` is updated as system date (Jul 12 16:58). "Not setting time of file README (time mismatch)" message is here. https://github.com/mirror/patch/blob/v2.7.6/src/patch.c#L581-L583 ## diff file without date header ``` $ cat readme2.diff --- a/README +++ b/README @@ -1,3 +1,4 @@ +aaa This is RPM, the RPM Package Manager. The latest releases are always available at: ``` ``` $ touch -d 20190101 README $ ls -l README -rw-rw-r-- 1 jaruga jaruga 603 Jan 1 2019 README $ patch -p1 -Z < readme2.diff patching file README $ ls -l README -rw-rw-r-- 1 jaruga jaruga 607 Jul 12 17:03 README ``` `README` is updated as system date (Jul 12 17:03). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/788#issuecomment-510922742___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Supporting %patch -T option (#788)
> The other question is whether this should be added to _default_patch_flags in > the long run. This is the best solution for me if we can add it to the _default_patch_flags. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/788#issuecomment-510819552___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Supporting %patch -T option (#788)
It seems `-Z` is better than `-T`. ``` $ man patch ... -T or --set-time Set the modification and access times of patched files from time stamps given in context diff headers. Unless specified in the time stamps, assume that the con‐ text diff headers use local time. Use of this option with time stamps that do not include time zones is not recom‐ mended, because patches using local time cannot easily be used by people in other time zones, and because local time stamps are ambiguous when local clocks move backwards during daylight-saving time adjustments. Make sure that time stamps include time zones, or generate patches with UTC and use the -Z or --set-utc option instead. ... ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/788#issuecomment-510513663___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Supporting %patch -T option (#788)
Or I want an option for %patch to preserve the timestamp of the patched file like `cp -p`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/788#issuecomment-510405111___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Supporting %patch -T option (#788)
I wanted to use `patch -T` option for %patch macro, to set fixed timestamp for
a patched file.
Because It is related to reproductive build. The timestamp is used as a gz
file's metadata modified date in a program.
Is it possible to support the option?
ruby.spec
```
-%patch20 -p1
+%patch20 -p1 -T
```
```
$ rhpkg srpm
error: unknown option: -T: %patch20 -p1 -T
error: unknown option: -T: %patch20 -p1 -T
Could not execute srpm: Failed to execute command.
```
https://github.com/rpm-software-management/rpm/blob/master/build/parsePrep.c#L403-L413
```
static rpmRC doPatchMacro(rpmSpec spec, const char *line)
{
...
struct poptOption const patchOpts[] = {
{ NULL, 'P', POPT_ARG_STRING, _P, 'P', NULL, NULL },
{ NULL, 'p', POPT_ARG_INT, _p, 'p', NULL, NULL },
{ NULL, 'R', POPT_ARG_NONE, _R, 'R', NULL, NULL },
{ NULL, 'E', POPT_ARG_NONE, _E, 'E', NULL, NULL },
{ NULL, 'b', POPT_ARG_STRING, _b, 'b', NULL, NULL },
{ NULL, 'z', POPT_ARG_STRING, _b, 'z', NULL, NULL },
{ NULL, 'F', POPT_ARG_INT, _F, 'F', NULL, NULL },
{ NULL, 'd', POPT_ARG_STRING, _d, 'd', NULL, NULL },
{ NULL, 'o', POPT_ARG_STRING, _o, 'o', NULL, NULL },
{ NULL, 0, 0, NULL, 0, NULL, NULL }
};
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/788___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] Using https://ftp.rpm.org
https://github.com/rpm-software-management/rpm/releases/tag/rpm-4.14.0-release > RPM releases are tracked at http://rpm.org/timeline > Official RPM source releases are available at http://ftp.rpm.org/releases/, > do not use GitHub provided tarballs. Is it no problem and better to use https://ftp.rpm.org/releases/ rather than http://ftp.rpm.org/releases/ ? I got a error message on my Firefox browser. And seeing the web site adding the exception to the browser. ``` The owner of ftp.rpm.org has configured their website improperly. To protect your information from being stolen, Firefox has not connected to this website. ftp.rpm.org uses an invalid security certificate. The certificate is only valid for the following names: osuosl.org, *.osuosl.org Error code: SSL_ERROR_BAD_CERT_DOMAIN ``` I want the secure connection HTTPS from my program [1]. But considering if it is okay because of the error message. [1] https://github.com/junaruga/rpm-py-installer/issues/112 Jun ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: macro for checking endianess (#365)
@ignatenkobrain I agree with you.
I think showing the little or big endian information by rpm helps the debugging.
I did debug writing below code in a source directly.
I want to check it more casually.
```
+ /*
+ int n = 1;
+ if(*(char *) == 1) {
+printf("debug the system is little endian.\n");
+ } else {
+printf("debug the system is big endian.\n");
+ }
+ */
```
```
$ lscpu | grep "Byte Order"
Byte Order: Little Endian
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/365#issuecomment-350011080___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add runtime_library_dirs for custom prefix. (#348)
> Is RPATH being removed on installation? Where is `RPATH` on installation? At least on latest current master branch, `import rpm` becomes the error without `LD_LIBRARY_PATH`. ``` $ python3 -c 'import rpm; print(rpm.__version__)' Traceback (most recent call last): File "", line 1, in File "/usr/local/python-3.6.2/lib/python3.6/site-packages/rpm/__init__.py", line 38, in from rpm._rpm import * ImportError: librpm.so.8: cannot open shared object file: No such file or directory $ LD_LIBRARY_PATH=$HOME/git/rpm/dest/lib python3 -c 'import rpm; print(rpm.__version__)' 4.14.90 ``` I also do not see `-rpath` in `$ python3 setup.py build`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/348#issuecomment-342130107___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add runtime_library_dirs for custom prefix. (#348)
Previously we needed to set `LD_LIBRARY_PATH` to run the Python bindings for custom prefix. ``` $ LD_LIBRARY_PATH=$HOME/git/rpm/dest/lib python3 -c 'import rpm; print(rpm.__version__)' 4.14.90 ``` This PR to do "import rpm" without LD_LIBRARY_PATH. Below is the way to reproduce and test it. This PR is related to https://github.com/rpm-software-management/rpm/pull/327 and https://github.com/rpm-software-management/rpm/issues/130 . ``` $ pwd /home/jaruga/git/rpm $ ./autogen.sh --noconfigure $ ./configure --prefix="$(pwd)/dest" $ make $ make install $ dest/bin/rpm --version RPM version 4.14.90 $ cd python/ $ which python3 /usr/local/python-3.6.2/bin/python3 $ python3 -m pip list | grep rpm $ python3 setup.py build $ sudo /usr/local/python-3.6.2/bin/python3 setup.py install $ python3 -m pip list | grep rpm rpm 4.14.90 $ cd .. $ python3 -c 'import rpm; print(rpm.__version__)' 4.14.90 ``` Ref. https://docs.python.org/3/distutils/apiref.html https://docs.python.org/2/distutils/apiref.html > runtime_library_dirs | list of directories to search for C/C++ libraries at > run time (for shared extensions, this is when the extension is loaded) You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/348 -- Commit Summary -- * Add runtime_library_dirs for custom prefix. -- File Changes -- M python/setup.py.in (3) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/348.patch https://github.com/rpm-software-management/rpm/pull/348.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/348 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)
@pmatilai thanks for your checking! > but I don't see this helping #130 at least in the general case. OK, perhaps, I may need to send additional PR for that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/327#issuecomment-341691588___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)
Hi maintainers of the RPM! Why this PR has not been merged yet? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/327#issuecomment-339370535___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)
OK.
By the way, we can do "import rpm" without `LD_LIBRARY_PATH` for custom prefix
by adding `runtime_library_dirs = pkgconfig('--libs-only-L')` to each
`Extension` class
Do you want to add this in this PR?
I thought an another PR was better after merging this PR, because we may need
more discussion for that.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/327#issuecomment-332791606___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)
Why don't you merge? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/327#issuecomment-332135262___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)
This fixes the Python bindings ModuleNotFoundError for custom prefix. http://lists.rpm.org/pipermail/rpm-maint/2017-September/006568.html The reason is the Extension class libraries attribute does not accept library file or directory path. According to https://docs.python.org/3/distutils/apiref.html https://docs.python.org/2/distutils/apiref.html > libraries list of library names (not filenames or paths) to link against We may close below ticket by this PR. https://github.com/rpm-software-management/rpm/issues/130 Below is the work flow to check the bug is fixed. ``` $ pwd /home/jaruga/git/rpm $ ./autogen.sh --noconfigure $ ./configure --prefix="$(pwd)/dest" $ make $ make install $ dest/bin/rpm --version RPM version 4.14.90 $ cd python/ $ which python3 /usr/local/python-3.6.2/bin/python3 $ python3 -m pip list PackageVersion -- --- pip9.0.1 setuptools 28.8.0 wheel 0.30.0 $ python3 setup.py build $ sudo /usr/local/python-3.6.2/bin/python3 setup.py install $ python3 -m pip list PackageVersion -- --- pip9.0.1 rpm4.14.90 setuptools 28.8.0 wheel 0.30.0 ``` The there was a trap I faced for below command. `cd ..` is needed to change directory from `rpm/python`. We should not run below `python3 -c 'import rpm'` in the `rpm/python` directory. Because the command wrongly check `rpm/python/rpm/__init__.py` to do `import rpm`, it is not installed rpm python bindings' directory. Thanks @pmatilai . I found it by `strace` command that you recommended me. Then ``` $ cd .. $ LD_LIBRARY_PATH=$HOME/git/rpm/dest/lib python3 -c 'import rpm; print(rpm.__version__)' 4.14.90 ``` Correctly the library is loaded. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/327 -- Commit Summary -- * Fix Python bindings library path for custom prefix. -- File Changes -- M python/setup.py.in (9) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/327.patch https://github.com/rpm-software-management/rpm/pull/327.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/327 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] Python bindings: ModuleNotFoundError on custom prefix
Hi Panu, Thanks for the answer. Um, "import rpm"? > If that doesn't work then either it's not in your runtime environment > paths, or there's something wrong with the build. > Yes, "import rpm". > $ cd python/ >> >> $ python3 -m venv ./venv >> > > No idea what this does so hard to say. > It is the command to create Python's virtual environment (kind of another clean python environment). But sorry I missed to show the command to enable the virtual environment "source venv/bin/activate" in the steps. $ cd python/ $ python3 -m venv ./venv $ source venv/bin/activate <= This. (venv) $ Maybe it can't find the libraries of the newer rpm? strace is your friend, > see what it's actually trying to do. > > There's also https://github.com/rpm-software-management/rpm/issues/130 > which might affect things but not sure that would manifest in this way. > OK, I will try on the way you introduced me. Just in case, I would show the steps without virtual environment. $ pwd /home/jaruga/git/rpm $ dest/bin/rpm --version RPM version 4.14.90 $ cd python/ $ which python3 /usr/local/python-3.6.1/bin/python3 $ python3 setup.py build $ sudo /usr/local/python-3.6.1/bin/python3 setup.py install $ python3 -m pip list | grep '^rpm ' rpm 4.14.90 $ python3 -c 'import rpm' Traceback (most recent call last): File "", line 1, in File "/home/jaruga/git/rpm/python/rpm/__init__.py", line 38, in from rpm._rpm import * ModuleNotFoundError: No module named 'rpm._rpm' $ python3 -c 'import sys; print(sys.path)' ['', '/usr/local/python-3.6.1/lib/python36.zip', '/usr/local/python-3.6.1/lib/python3.6', '/usr/local/python-3.6.1/lib/python3.6/lib-dynload', '/usr/local/python-3.6.1/lib/python3.6/site-packages', '/home/jaruga/git/rebase-helper'] $ ls /usr/local/python-3.6.1/lib/python3.6/site-packages/rpm | sort __pycache__/ _rpm.cpython-36m-x86_64-linux-gnu.so* _rpmb.cpython-36m-x86_64-linux-gnu.so* _rpms.cpython-36m-x86_64-linux-gnu.so* Thanks. Jun ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] Python bindings: ModuleNotFoundError on custom prefix
Hello, Though it might be basic thing, when I built latest master branch's source with ./configure --prefix, then I did import the Python bindings, I got ModuleNotFoundError. Could you tell me how to import it? Thanks. Below steps are what I did. $ pwd /home/jaruga/git/rpm $ ./autogen.sh --noconfigure $ ./configure --prefix="$(pwd)/dest" $ make $ make install $ ls dest/ bin/ include/ lib/ share/ var/ $ cd python/ $ python3 -m venv ./venv (venv) $ python setup.py build (venv) $ python setup.py install (venv) $ pip list PackageVersion -- --- pip9.0.1 rpm4.14.90 setuptools 28.8.0 (venv) $ python -c 'import rpm' Traceback (most recent call last): File "", line 1, in File "/home/jaruga/git/rpm/python/rpm/__init__.py", line 38, in from rpm._rpm import * ModuleNotFoundError: No module named 'rpm._rpm' (venv) $ python -c 'import sys; print(sys.path)' ['', '/usr/local/python-3.6.1/lib/python36.zip', '/usr/local/python-3.6.1/lib/python3.6', '/usr/local/python-3.6.1/lib/python3.6/lib-dynload', '/home/jaruga/git/rpm/python/venv/lib/python3.6/site-packages'] (venv) $ ls venv/lib/python3.6/site-packages/rpm/ | sort __pycache__/ _rpm.cpython-36m-x86_64-linux-gnu.so* _rpmb.cpython-36m-x86_64-linux-gnu.so* _rpms.cpython-36m-x86_64-linux-gnu.so* __init__.py transaction.py -- Jun ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] RPM 4.14.0 release candidate 1 released!
Hi Panu, Shall we update rpm-4.14.0-rc1 for below document too such as rpm-4.12.0-rc1 in the page? rpm-4.14.0-rc1 https://github.com/rpm-software-management/rpm/releases Jun On Wed, Sep 6, 2017 at 5:36 PM, Panu Matilainen <pmati...@redhat.com> wrote: > > "... but what happened to the beta?", I hear you ask. > > Well, we skipped it. > > To cut to the chase, the highlights since the alpha include: > - Support for 'unless' rich dependencies > - Ensure header is present in callback events > - Macro argument quoting changed to be much more compatible > - Experimental LMDB backend > - Misc bugfixes and minor enhancements > > More details etc yadda yadda at the usual place: > > http://rpm.org/wiki/Releases/4.14.0 > > Being into RC territory also means we're feature frozen for 4.14.0 now. > Really. > > OTOH flood gates at git master are open again. We're seeing an entirely > unprecedented amount of contributions these days, so much so we tend to get > a bit overwhelmed by it all. Try to bear with us, and thanks. > > On behalf of the rpm-team, > > - Panu - > ___ > Rpm-maint mailing list > Rpm-maint@lists.rpm.org > http://lists.rpm.org/mailman/listinfo/rpm-maint > -- Jun Aruga jar...@redhat.com IRC: jaruga, Office: TPB(Technology Park Brno) Building C 1F, Brno, Czech Republic ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use setuptools to prevent deprecation message when uninstalling. (#323)
OK. That makes sense. Feel free to close this ticket. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/323#issuecomment-328188537___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use setuptools to prevent deprecation message when uninstalling. (#323)
Sorry this modification becomes error on Python 2.7.
```
(venv2) $ pip list
PackageVersion
-- ---
pip9.0.1
rpm4.14.90
setuptools 36.4.0
wheel 0.29.0
(venv2) $ pip uninstall rpm
Uninstalling rpm-4.14.90:
/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/rpm-4.14.90-py2.7-linux-x86_64.egg
Proceed (y/n)? y
Successfully uninstalled rpm-4.14.90
Traceback (most recent call last):
File "/home/jaruga/git/rpm/python/venv2/bin/pip", line 11, in
sys.exit(main())
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/__init__.py",
line 233, in main
return command.main(cmd_args)
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/basecommand.py",
line 252, in main
pip_version_check(session)
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/utils/outdated.py",
line 102, in pip_version_check
installed_version = get_installed_version("pip")
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/utils/__init__.py",
line 838, in get_installed_version
working_set = pkg_resources.WorkingSet()
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py",
line 644, in __init__
self.add_entry(entry)
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py",
line 700, in add_entry
for dist in find_distributions(entry, True):
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py",
line 1949, in find_eggs_in_zip
if metadata.has_metadata('PKG-INFO'):
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py",
line 1463, in has_metadata
return self.egg_info and self._has(self._fn(self.egg_info, name))
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py",
line 1823, in _has
return zip_path in self.zipinfo or zip_path in self._index()
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py",
line 1703, in zipinfo
return self._zip_manifests.load(self.loader.archive)
File
"/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py",
line 1643, in load
mtime = os.stat(path).st_mtime
OSError: [Errno 2] No such file or directory:
'/home/jaruga/git/rpm/python/venv2/lib/python2.7/site-packages/rpm-4.14.90-py2.7-linux-x86_64.egg'
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/323#issuecomment-328153901___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Install rpm-python from PyPI (#273)
Let me announce. I developed a installer to install `rpm-python` or `rpm` (same version with system RPM) on non-system Python. People can install `rpm-python` by installing `rpm-py-installer` from PyPI. https://pypi.python.org/pypi/rpm-py-installer https://github.com/junaruga/rpm-py-installer ``` $ pip install rpm-py-installer ``` Or add `rpm-py-installer` to `setup.py` `install_requires`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/273#issuecomment-328100601___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: give some freshness to brp scripts (#308)
What is brp script's "brp"? Though it may be basic knowledge. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/308#issuecomment-324009038___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Static code analysis task for make (#306)
Is there the coding rule for this project (for C)? It looks K style. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/306#issuecomment-323548276___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Static code analysis task for make (#306)
> I usually find that "static analysis" on scripts is just too much work. Well, if you do not like static analysis for scripts, I do not promote the tools for the script files (*.sh, *.py) in this project. Focusing to interest topics, not quoting and globing and etc. That makes sense. I can understand it. I may run the analysis tool for python scripts on my local personally, and send pull-request for that. That's good enough for me. Actually the number of the script files is very few. ``` $ find . -name "*.[ch]" | wc -l 243 $ find . -name "*.sh" | wc -l 12 $ find . -name "*.py" | wc -l 2 ``` > The make target I use looks like this: Thanks for the sample code. How about a style format check for C files? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/306#issuecomment-323547884___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Static code analysis task for make (#306)
> My previous comment was wrto adding static analysis instrumentation to > rpmbuild for other packages. Yeah, I knew that after reading your comment. `rpmbuild` and `rpmlint` are doing the analysis. My proposal is about for static analysis on RPM itself, as you mentioned. > For static analysis on RPM itself by adding make targets, then LCOV/GCOV > coverage targets and adding test cases is usually more useful than static > analysis warnings. I agree with you. Adding coverage test target is also useful for maintainability. If "we do run static analyser from time to time locally.", I want to know the content as a make target. I think we do not have to run those static analysis targets in CI as a first step. Knowing the used analysis tools and the rules by configuration file makes us to contribute easily. > Note that I have years of experience with static analysis tools applied to > RPM sources ;-) OK, let's promote it :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/306#issuecomment-323544604___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Static code analysis task for make (#306)
I want to add `make style-check` task for static code analysis as a dependency task of `make check` in `Makefile`. Because it helps to maintain, keeping the code clean. Candidate tools - C file: I do not know which tool is good. - Python file: `flake8` [1]. - Shell (bash) file: `sh -n`, `bashate` [2], `shellcheck` [3] I have used the tool [1], [2], [3]. and I think those are helpful. [1] https://pypi.python.org/pypi/flake8 [2] https://pypi.python.org/pypi/bashate [3] https://www.shellcheck.net/ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/306___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] [Proposal] Adding style and pytest environment on tox for rpm python bindings module. (#303)
I would close this PR to change the approach. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/303#issuecomment-323445795___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] [Proposal] Adding style and pytest environment on tox for rpm python bindings module. (#303)
Closed #303. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/303#event-1212471133___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Thank you for that. But it seems that the CI test is not run for this PR.. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-323131071___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] [Proposal] Adding style and pytest environment on tox for rpm python bindings module. (#303)
This PR includes several factors. Sorry for that. What I want to know is 1. Do we like starting style check? 1.1. Use `flake8`? 2. Do we like starting a unit test by `pytest`? 3. Do we use `tox`? (`tox` is a little bit magic.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/303#issuecomment-323084959___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] [Proposal] Adding style and pytest environment on tox for rpm python bindings module. (#303)
## Motivation I want to add style (static code analysis) test and pytest for the python code. When I did debug the python code for the issue related to library path: https://github.com/rpm-software-management/rpm/issues/130 , I thought adding those was useful. ## Detail We have tests/rpmpython.at for the rpm python binding. However I think that using pytest is also good to maintain and customize the detail of the test easily. The style check for python code is one of the merit to keep the python code clean. - Style check by `flake8`. - I used `flake8` because `flake8` is better than pylint simple style check. and it is also used in `rpmlint` project. - I used `python/.flake8` as a compromise to warnings from "import *". In the future, we can do below style removing the `.flake8` file. > http://docs.python-guide.org/en/latest/writing/structure/#modules > import modu > [...] > x = modu.sqrt(4) # sqrt is visibly part of modu's namespace - Test for python binding by pytest. The test is here `python/tests/test_rpm.py`. Right now only 1 test case as a proposal. - python/setup.py.in In the tox test, `pytyhon setup.py build` is run under `/tmp/pip-l2s21mdp-build`. So, previous logic to check parent directory's `Makefile.am` file does not work in this case. In the case of that there is no parent directory for build directory, users can build with specifying include and library direcotory. ``` RPM_NO_SEARCH_BUILD_DIR=1 python3 setup.py build \ --include-dirs=/path/to/include/ --library-dirs=/path/to/libs/ ``` - ci/Dockerfile Added the logic to run the pytest and the style test. ## Workflow example ### Build ``` $ ./autogen.sh --noconfigure $ ./configure --prefix="$(pwd)/dest" $ make ``` ### Tox test and build for the python module. ``` $ cd python $ tox $ python setup.py build $ python3 setup.py build $ cd .. ``` ### Install ``` $ make install ``` ### Check linked libraries. ``` $ LD_LIBRARY_PATH="$(pwd)/dest/lib" \ ldd python/build/lib.*/rpm/*.so python/build/lib.linux-x86_64-2.7/rpm/_rpmb.so: linux-vdso.so.1 (0x7ffdd5e68000) librpm.so.8 => /home/jaruga/git/rpm/dest/lib/librpm.so.8 (0x7f6681393000) librpmio.so.8 => /home/jaruga/git/rpm/dest/lib/librpmio.so.8 (0x7f6681164000) librpmbuild.so.8 => /home/jaruga/git/rpm/dest/lib/librpmbuild.so.8 (0x7f6680f3a000) ... ``` See https://gist.github.com/junaruga/789866509a21afb32e3c1ab40b48120a to check full result of the `ldd` command. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/303 -- Commit Summary -- * Add pytest and style environment for rpm python bindings module. -- File Changes -- M ci/Dockerfile (14) A python/.flake8 (5) M python/.gitignore (1) M python/rpm/__init__.py (4) M python/setup.py.in (76) A python/test-requirements.txt (2) A python/tests/test_rpm.py (6) A python/tox.ini (19) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/303.patch https://github.com/rpm-software-management/rpm/pull/303.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/303 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] generic rpminterp plugin interface for interpreters (#190)
Hello, @proyvind I am not a maintainer of this project. However this project started to use CI recently. So, it might be good to rebase your branch for PR on top of master branch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/190#issuecomment-322180192___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Install rpm-python from PyPI (#273)
I would share a case I want you to upload the the rpm Python bindings to PyPI. A python package `rebase-helper` [1] depends on the rpm Python bindings. For this reason, `rebase-helper` can not add `install_requires` to `setup.py` file. If we want to install `rebase-helper` from source, I am happy if we can install it by only ``` $ pip install rebase-helper ``` [1] https://github.com/rebase-helper/rebase-helper -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/273#issuecomment-317409606___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Update dnf options in Dockerfire for readability. (#272)
Here document does not work ;) At least, it can be supported from Docker 2.0. Ref: `https://github.com/moby/moby/issues/1554#issuecomment-196544146` ``` RUN cat <> /etc/dnf/dnf.conf deltarpm=0 install_weak_deps=0 tsflags=nodocs EOF ``` Brackets also does not work ;) ``` RUN ( echo deltarpm=0 echo install_weak_deps=0 echo tsflags=nodocs ) >> /etc/dnf/dnf.conf ``` Sadly, finally only escape long line. ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/272#issuecomment-317176352___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Update dnf options in Dockerfire for readability. (#272)
Humm, just moment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/272#issuecomment-317174918___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Update dnf options in Dockerfire for readability. (#272)
It looks better, isn't it? You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/272 -- Commit Summary -- * Update dnf options in Dockerfire for readability. -- File Changes -- M ci/Dockerfile (6) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/272.patch https://github.com/rpm-software-management/rpm/pull/272.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/272 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
@ignatenkobrain congratulations. Where is the RPM's URL in https://semaphoreci.com ? https://semaphoreci.com/rpm-software-management/rpm is 404 not found. Does Semaphoreci have the configuration file such as `.travis.yml` or `.circleci/config.yml`? I want to see the logic to test `rpm` on 4 containers (Fedora 24, 25, 26, rawhide). Shall we change current `README` to `README.md` or something to see build status easily? like a Cockpit https://github.com/cockpit-project/cockpit/blob/master/README.md -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#issuecomment-317007720___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
junaruga commented on this pull request. > +readline-devel \ +redhat-rpm-config \ +rpm-build \ +which \ +xz-devel \ +zlib-devel + +RUN dnf clean all + +RUN useradd -u $TEST_USER_ID tester + +WORKDIR /builddir + +COPY . . + +RUN chown -R 1000 . Ah sorry 1000 is hard coded. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-51092701___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
Rebased! https://travis-ci.org/junaruga/rpm/builds/255401154 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316498582___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
junaruga commented on this pull request. > @@ -0,0 +1,49 @@ +FROM fedora + +ENV TEST_USER_ID 1000 + +RUN dnf -y install \ > Also I would add dnf update as previous step OK, just moment. I am going to add it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#discussion_r128346324___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
@Conan-Kudo it seems that "Semaphore CI" is not for free to use 4 containers. https://semaphoreci.com/pricing Also it seems that the setting can be only edited from GUI operation. But it is good to manage the settings by configuration file, isn't it? Cockpit project does not use docker for test? I am not sure. https://github.com/cockpit-project/cockpit -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316478872___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
@junaruga pushed 1 commit. 40f61d9 Update -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/261/files/1a8b8dcd811f2f18c2ed1187e4a3de8788ac7799..40f61d9c21077c0d36ec0eac9e5d0fe91dd968f5 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
> @junaruga What about Semaphore CI? I believe the Cockpit guys are already > using it with some good success. OK, I am fine for that. I have never used the CI, so let me check it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316471531___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
@ignatenkobrain Updated! How? https://travis-ci.org/junaruga/rpm/builds/255363668 My concern is if `language` is not specified, it looks running as `language: ruby`. If we will set `language: generic`, it is displayed as "no language set" instead of "Ruby". But I do not know that it is right way. I did set `CONTAINER_IMAGE=registry.fedoraproject.org/fedora:24` with full path. Because this is good to add CentOS container image as CI test in the future, if we need. If you are fine for my modification, I can do squash from 2 commits to 1 commit before merging. Or you can do it by yourself. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316470510___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
@junaruga pushed 1 commit. a4a00b4 Update -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/261/files/f31ce2eefb58c19b9519d421535ae8cb7b978893..a4a00b418cd74163409ceed2a16524f50e464558 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
@junaruga pushed 1 commit. c674791 Update -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/261/files/89f8f9ac75cdfced0c633b35c782cf610c2030fe..c6747912009a7f0c298635cb7307fb400ca56be9 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
@junaruga pushed 1 commit. 89f8f9a Update -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/261/files/378113d64863b5eaf39f835cd7cb855c9966c5d7..89f8f9ac75cdfced0c633b35c782cf610c2030fe ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
@junaruga pushed 1 commit. 378113d Update -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/261/files/6f7d088740018557c2adce877d134113e7dd2b05..378113d64863b5eaf39f835cd7cb855c9966c5d7 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
@junaruga pushed 2 commits. 914080c Fix for review. 6f7d088 Update -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/261/files/25a8ba12d33f1d0bc521f2f7ebb5b01ef0a454d7..6f7d088740018557c2adce877d134113e7dd2b05 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
junaruga commented on this pull request. > @@ -0,0 +1,49 @@ +FROM fedora + +ENV TEST_USER_ID 1000 + +RUN dnf -y install \ OK. I will add the options. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#discussion_r128289878___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
junaruga commented on this pull request.
> +sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:
+ - |
+docker build \
+-t rpm \
+.
+before_script:
+ - sudo chown -R 1000 .
+script:
+ - |
+DIR=$(pwd)
+docker run \
+-v "${DIR}:${DIR}" \
+-w "${DIR}" \
+-i \
Ah sorry obviously it is my mistake. I remove the `-i` option.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128289790___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
junaruga commented on this pull request.
> + - |
+if [ "${CONTAINER_IMAGE}" != '' ]; then
+sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:
+ - |
+docker build \
+-t rpm \
+.
+before_script:
+ - sudo chown -R 1000 .
+script:
+ - |
+DIR=$(pwd)
+docker run \
+-v "${DIR}:${DIR}" \
OK. let me try the way.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128289331___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
junaruga commented on this pull request. > @@ -0,0 +1,49 @@ +FROM fedora + +ENV TEST_USER_ID 1000 Because I wanted to use variable `TEST_USER_ID` in below lines in `Dockerfile`. How do you think? ``` RUN useradd -u $TEST_USER_ID tester ... USER $TEST_USER_ID ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#discussion_r128289057___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
junaruga commented on this pull request.
> +dist: trusty
+services:
+ - docker
+env:
+# Fedora
+# https://hub.docker.com/r/_/fedora/
+- CONTAINER_IMAGE=fedora:24
+- CONTAINER_IMAGE=fedora:25
+- CONTAINER_IMAGE=fedora:26
+- CONTAINER_IMAGE=fedora:rawhide
+before_install:
+ - |
+if [ "${CONTAINER_IMAGE}" != '' ]; then
+sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:
OK. I will move the logic in `install` to `before_install`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128288441___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
junaruga commented on this pull request. > @@ -0,0 +1,32 @@ +language: c OK. I will remove this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#discussion_r128288263___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
junaruga commented on this pull request.
> +language: c
+sudo: required
+dist: trusty
+services:
+ - docker
+env:
+# Fedora
+# https://hub.docker.com/r/_/fedora/
+- CONTAINER_IMAGE=fedora:24
+- CONTAINER_IMAGE=fedora:25
+- CONTAINER_IMAGE=fedora:26
+- CONTAINER_IMAGE=fedora:rawhide
+before_install:
+ - |
+if [ "${CONTAINER_IMAGE}" != '' ]; then
+sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
Ah. Okay. I agree with you.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128287593___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
@ignatenkobrain in my understanding, on CircleCI (latest version 2.0 too), we can not use for free to use 4 containers (Feodra 24, 25, 26, rawhide). > I still don't think it is useful to build container every time. Why do you think so? The Travis running time is "3 min 20 sec". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316427958___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)
I think that using CI environment is useful for contributors to send pull-request. So, I prepared the environment for test `rpm` on Fedora 24, 25, 26 and rawhide container environment. You can check the CI test for my repository. https://travis-ci.org/junaruga/rpm If you need to activate to start Travis CI for this repository. https://travis-ci.org/rpm/rpm How do you think? Note: I removed `fstab` part in `tests/Makefile.am` to fix test failure. `/etc/fstab` file does not exist in fedora container environment. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/261 -- Commit Summary -- * Add Travis CI testing environment. -- File Changes -- M .gitignore (1) A .travis.yml (32) A Dockerfile (49) M README (2) A scripts/build.sh (53) M tests/Makefile.am (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/261.patch https://github.com/rpm-software-management/rpm/pull/261.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/261 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Print exit code with rpm -vv (from @n3npq, #195) (#252)
junaruga commented on this pull request. > @@ -354,5 +354,7 @@ int main(int argc, char *argv[]) rpmcliFini(optCon); +rpmlog(RPMLOG_DEBUG, "exit code: %d\n", ec); "Exit status" is better isn't it? ``` $ man ls ... Exit status: 0 if OK, 1 if minor problems (e.g., cannot access subdirectory), 2 if serious trouble (e.g., cannot access command-line argument). ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/252#pullrequestreview-50380621___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] How to run unit tests (#243)
Close this ticket, as I found how to run unit test. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/243#issuecomment-313711499___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Return error exit status when make check is failed. (#248)
Right now `make check` returns success exit status: 0 when the tests are failed. ``` $ make check ... ## - ## ## Test results. ## ## - ## ERROR: All 358 tests were run, 21 failed (2 expected failures). ## - ## ## rpmtests.log was created. ## ## - ## ... ``` ``` $ echo $? 0 ``` Because the logic to succeed forcely is added below commit. But I think that it is not good. Because we can not detect failed tests for example in `rpm.spec` check section. https://github.com/rpm-software-management/rpm/commit/52bc67436f5bc28d2bd08a9fd3498cf16d5817bb After this modification, `make check` returns error exit status. ``` $ make check ... ## - ## ## Test results. ## ## - ## ERROR: All 358 tests were run, 21 failed (2 expected failures). ## - ## ## rpmtests.log was created. ## ## - ## ... ``` ``` $ echo $? 2 ``` You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/248 -- Commit Summary -- * Return error exit status when make check is failed. -- File Changes -- M tests/Makefile.am (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/248.patch https://github.com/rpm-software-management/rpm/pull/248.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/248 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Fix fakechroot wrong URL. (#247)
Rename old `fakechrrot` URL in `INSTALL`. This closes https://github.com/rpm-software-management/rpm/issues/243 http://pkgs.fedoraproject.org/cgit/rpms/fakechroot.git/tree/fakechroot.spec > URL:https://github.com/dex4er/fakechroot You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/247 -- Commit Summary -- * Fix fakechroot wrong URL. -- File Changes -- M INSTALL (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/247.patch https://github.com/rpm-software-management/rpm/pull/247.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/247 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] How to install rpm-python package from git to source compiled Python's pip (#244)
Sorry I will take care of not using here as the support forum. Thanks for the information! I will take a look of the fedora packaging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/244#issuecomment-312450313___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] How to run unit tests (#243)
I want to run unit tests under `tests/` directory. I tried below way seeing `INSTALL` document https://github.com/rpm-software-management/rpm/blob/master/INSTALL#L181-L186 ``` $ make check make check-recursive make[1]: Entering directory '/home/jaruga/git/rpm' Making check in po make[2]: Entering directory '/home/jaruga/git/rpm/po' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/jaruga/git/rpm/po' Making check in misc make[2]: Entering directory '/home/jaruga/git/rpm/misc' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/jaruga/git/rpm/misc' Making check in luaext make[2]: Entering directory '/home/jaruga/git/rpm/luaext' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/jaruga/git/rpm/luaext' Making check in rpmio make[2]: Entering directory '/home/jaruga/git/rpm/rpmio' make make[3]: Entering directory '/home/jaruga/git/rpm/rpmio' make[3]: Nothing to be done for 'all'. make[3]: Leaving directory '/home/jaruga/git/rpm/rpmio' make[2]: Leaving directory '/home/jaruga/git/rpm/rpmio' Making check in lib make[2]: Entering directory '/home/jaruga/git/rpm/lib' make check-am make[3]: Entering directory '/home/jaruga/git/rpm/lib' make make[4]: Entering directory '/home/jaruga/git/rpm/lib' make all-am make[5]: Entering directory '/home/jaruga/git/rpm/lib' make[5]: Nothing to be done for 'all-am'. make[5]: Leaving directory '/home/jaruga/git/rpm/lib' make[4]: Leaving directory '/home/jaruga/git/rpm/lib' make[3]: Leaving directory '/home/jaruga/git/rpm/lib' make[2]: Leaving directory '/home/jaruga/git/rpm/lib' Making check in sign make[2]: Entering directory '/home/jaruga/git/rpm/sign' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/jaruga/git/rpm/sign' Making check in build make[2]: Entering directory '/home/jaruga/git/rpm/build' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/jaruga/git/rpm/build' Making check in scripts make[2]: Entering directory '/home/jaruga/git/rpm/scripts' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/jaruga/git/rpm/scripts' Making check in fileattrs make[2]: Entering directory '/home/jaruga/git/rpm/fileattrs' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/jaruga/git/rpm/fileattrs' Making check in doc make[2]: Entering directory '/home/jaruga/git/rpm/doc' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/jaruga/git/rpm/doc' Making check in . make[2]: Entering directory '/home/jaruga/git/rpm' make[2]: Leaving directory '/home/jaruga/git/rpm' Making check in plugins make[2]: Entering directory '/home/jaruga/git/rpm/plugins' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/jaruga/git/rpm/plugins' make[1]: Leaving directory '/home/jaruga/git/rpm' ``` I expected below kind of result. My way is correct? https://github.com/rpm-software-management/rpm/issues/170#issue-211735874 Also the `fakechroot` URL https://github.com/fakechroot in the document is correct? The URL is just a user's page. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/243___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] How to build rpm from source
Hi Florian Thank you. I could build the source code on github by your script. I missed to read "To compile RPM:" section in INSTALL file. I did not run autogen.sh before configure script. Kind regards, Jun Aruga - Original Message - > From: "Florian Festi" <ffe...@redhat.com> > To: rpm-maint@lists.rpm.org > Sent: Friday, August 5, 2016 3:21:40 PM > Subject: Re: [Rpm-maint] How to build rpm from source > > Hi! > > I use the attached script to build the sources. > > Florian > > On 08/03/2016 01:25 PM, Jun Aruga wrote: > > Hello, > > > > I tried to build rpm on latest master branch and failed with an error. > > Could you tell me how to build it? > > > > Is there the document for basic build? > > I have checked below files. but could not find it. > > > > README > > INSTALL > > > > ``` > > $ rpm -q gcc > > gcc-5.3.1-6.fc23.x86_64 > > > > $ rpm -q autoconf > > autoconf-2.69-21.fc23.noarch > > > > $ git remote -v > > originhttps://github.com/rpm-software-management/rpm.git (fetch) > > originhttps://github.com/rpm-software-management/rpm.git (push) > > > > $ git log --pretty=oneline | head -1 > > 45bfecbf7dd4249abc197a5fc908e4efcc3108ad Add option to have unique debug > > file names across version/release/arch. > > > > $ autoconf > > configure.ac:8: error: possibly undefined macro: AM_INIT_AUTOMAKE > > If this token and others are legitimate, please use m4_pattern_allow. > > See the Autoconf documentation. > > > > $ ./configure --prefix=/usr/local/rpm-dev > > ./configure: line 2375: syntax error near unexpected token `1.10' > > ./configure: line 2375: `AM_INIT_AUTOMAKE(1.10 foreign tar-ustar dist-bzip2 > > subdir-objects nostdinc) > > ``` > > > > Kind regards, > > Jun Aruga > > ___ > > Rpm-maint mailing list > > Rpm-maint@lists.rpm.org > > http://lists.rpm.org/mailman/listinfo/rpm-maint > > > > > -- > > Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, > Commercial register: Amtsgericht Muenchen, HRB 153243, > Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, > Michael O'Neill > > ___ > Rpm-maint mailing list > Rpm-maint@lists.rpm.org > http://lists.rpm.org/mailman/listinfo/rpm-maint > ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] dnf repoquery --tree-requires ?
Hi, I would like to ask you whether there is a command like a "repoquery --tree-requires" to see the dependency tree on DNF command. Where I would request new feature, is here right? If there is better place to dot it, could you tell me? ``` $ rpm -qf /usr/bin/repoquery yum-utils-1.1.31-508.fc23.noarch $ repoquery --tree-requires rubygem-delayed_job ... Yum-utils package has been deprecated, use dnf instead. rubygem-delayed_job-0:4.0.6-2.fc23.noarch [cmd line] \_ rubygem-activesupport-1:4.2.3-3.fc23.noarch [2: rubygem(activesupport) < 5.0, rubygem(activesupport) >= 3.0] ... ``` If it has not been yet, I would like you to request it as the new feature for DNF, as I have checked a manual document about "dnf repoquery", I could not find it. https://rpm-software-management.github.io/dnf-plugins-core/repoquery.html Below option looks good. ``` $ dnf repoquery --tree-requires package_name ``` Thanks. Best regards, Jun Aruga ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] How to build rpm from source
Hi Florian Thank you very much!! I am going to try to use the script for build! Jun Aruga - Original Message - > From: "Florian Festi" <ffe...@redhat.com> > To: rpm-maint@lists.rpm.org > Sent: Friday, August 5, 2016 3:21:40 PM > Subject: Re: [Rpm-maint] How to build rpm from source > > Hi! > > I use the attached script to build the sources. > > Florian > > On 08/03/2016 01:25 PM, Jun Aruga wrote: > > Hello, > > > > I tried to build rpm on latest master branch and failed with an error. > > Could you tell me how to build it? > > > > Is there the document for basic build? > > I have checked below files. but could not find it. > > > > README > > INSTALL > > > > ``` > > $ rpm -q gcc > > gcc-5.3.1-6.fc23.x86_64 > > > > $ rpm -q autoconf > > autoconf-2.69-21.fc23.noarch > > > > $ git remote -v > > originhttps://github.com/rpm-software-management/rpm.git (fetch) > > originhttps://github.com/rpm-software-management/rpm.git (push) > > > > $ git log --pretty=oneline | head -1 > > 45bfecbf7dd4249abc197a5fc908e4efcc3108ad Add option to have unique debug > > file names across version/release/arch. > > > > $ autoconf > > configure.ac:8: error: possibly undefined macro: AM_INIT_AUTOMAKE > > If this token and others are legitimate, please use m4_pattern_allow. > > See the Autoconf documentation. > > > > $ ./configure --prefix=/usr/local/rpm-dev > > ./configure: line 2375: syntax error near unexpected token `1.10' > > ./configure: line 2375: `AM_INIT_AUTOMAKE(1.10 foreign tar-ustar dist-bzip2 > > subdir-objects nostdinc) > > ``` > > > > Kind regards, > > Jun Aruga > > ___ > > Rpm-maint mailing list > > Rpm-maint@lists.rpm.org > > http://lists.rpm.org/mailman/listinfo/rpm-maint > > > > > -- > > Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, > Commercial register: Amtsgericht Muenchen, HRB 153243, > Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, > Michael O'Neill > > ___ > Rpm-maint mailing list > Rpm-maint@lists.rpm.org > http://lists.rpm.org/mailman/listinfo/rpm-maint > ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] How to build rpm from source
Hello, I tried to build rpm on latest master branch and failed with an error. Could you tell me how to build it? Is there the document for basic build? I have checked below files. but could not find it. README INSTALL ``` $ rpm -q gcc gcc-5.3.1-6.fc23.x86_64 $ rpm -q autoconf autoconf-2.69-21.fc23.noarch $ git remote -v originhttps://github.com/rpm-software-management/rpm.git (fetch) originhttps://github.com/rpm-software-management/rpm.git (push) $ git log --pretty=oneline | head -1 45bfecbf7dd4249abc197a5fc908e4efcc3108ad Add option to have unique debug file names across version/release/arch. $ autoconf configure.ac:8: error: possibly undefined macro: AM_INIT_AUTOMAKE If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. $ ./configure --prefix=/usr/local/rpm-dev ./configure: line 2375: syntax error near unexpected token `1.10' ./configure: line 2375: `AM_INIT_AUTOMAKE(1.10 foreign tar-ustar dist-bzip2 subdir-objects nostdinc) ``` Kind regards, Jun Aruga ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
