Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)
No problem. Thanks for your time and inputs. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3072#issuecomment-2095342827 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)
Closed #3072. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3072#event-12710658133 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)
Sorry but I agree with @nwalfield , this is just strange churn for churn's sake. Like advertising use of goto but then still using return for the cases that *could* use a central clean-up point. Even the changes that I could use because I suggested them are mixed with unrelated other changes, moving stuff around needlessly etc. Even the change to "rpm coding style" is anything but, the code is almost 100% that already. A 118 line simple program that only ever executes as a part of the test-suite does not need much in the way of cleanup, really. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3072#issuecomment-2095296257 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)
@nwalfield Thanks for reviewing. > and some are weird, like having #define LEN 102400 // 100 * 1024 It would help me understand things better if you explain a bit on why it is weird. My intent behind the change is, why calculate something on every run which can be used directly? I'm completely okay if this doesn't get merged, people spent time to review my change and gave suggestions and I should respect that so I spent time on this and tried to do it right. It's upto the maintainers now, I have done my part. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3072#issuecomment-2091106326 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)
I've taken a look at this MR, and it's basically churn. Some of the changes are coding style, and some are opinionated, and some are weird, like having `#define LEN 102400 // 100 * 1024`. If I have a vote, this is a nack from me. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3072#issuecomment-2090793228 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)
@sshedi pushed 8 commits. e2938095b9f376e58397acceb8d3c5185928c58c rpmpgppubkeyfingerprint.c: use rpmGetCwd 3577dc5c43c912d613fff3ac9df21a41ca0c746c rpmpgppubkeyfingerprint.c: use static buffer instead of malloc a034d6c8d31caf1bf6b47ca3aa5d1d48f67341e2 rpmpgppubkeyfingerprint.c: move variable declarations to top f5f28a0ece6a3fc59c59a55c3fe48c8a55ad44db rpmpgppubkeyfingerprint.c: use macro for printing to stderr 2aa31906cb0a980b2b89a822b172e4d35d64b05d rpmpgppubkeyfingerprint.c: use macro for getting array size b23a3f5e6a7979a0035abfc55f0c14239223ae4b rpmpgppubkeyfingerprint.c: omit usage of rt variable 7dab6e73712252fbecb7c9856dda6d43ee912da3 rpmpgppubkeyfingerprint.c: move cleanups to end f7e31f107bb67270ee65ec6d90ff04e425ac0f62 rpmpgppubkeyfingerprint.c: format to rpm coding style -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3072/files/d6c4345f952daac06c956a90e0fb305e6c973617..f7e31f107bb67270ee65ec6d90ff04e425ac0f62 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)
@pmatilai thanks for all the inputs. I have tried addressing all of them. Please let me know if I have missed anything. @ffesti thank you for reviewing my earlier PR. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3072#issuecomment-2090762300 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
