Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
Replaced by #914. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-545846866___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
Closed #878. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#event-2740154684___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
> Whether SRPM uses DynamicBuildRequires feature This is can not be answered, though, by looking at the SRPM. It depends on what system the srpm is built on. It is similar to conditional BuildRequires, etc. > Whether SRPM has DynamicBuildRequires inserted into it You mean whether RPM has some dynamic buildrequires inserted in, right? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-541849779___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
Oh, we can't design rpm features based on what's available via the flawed repodata format. Really. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-540508364___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
Ok, so finally I have some free time. So the requerements were that you should be able to easily (by having just rpm metadata, aka primary.xml) do following: * Whether SRPM uses DynamicBuildRequires feature * Whether SRPM has DynamicBuildRequires inserted into it -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-540507375___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
(rebased to fix the conflict) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-539978167___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
@pmatilai pushed 0 commits. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/878/files/f09c493d8cd62634984aae163c6555c2d21c60df..f21466f6babe093382294b0f30be395000b15218 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
> These problems have no solution on SRPM level. Unless the spec file is > preprocessed by rpm, no-one knows whether the package will depend on dynamic > buildrequires feature or not. Yes, like I said this is no different from any other data in an src.rpm - it is only valid for the particular environment it was built in. That doesn't mean the data there is at all *useless* (our whole buildsystem bases its operation around it!), one just needs to be careful about interpreting it. Again the issue here is build versus install. Just like there can be arch-specific buildrequires in the src.rpm headers that still don't prevent the src.rpm to be rebuilt on another arch, it'd be equally correct to have a recorded dependency on rpm *build* capability in the src.rpm. It's just that rpmlib() dependencies are not appropriate for this task as they track installability (for example, if the source rpm used a strange compression in the payload you could not install/unpack the source rpm *at all*), not buildability. t would be perfectly fine for an src.rpm to carry a dependency indicating that in the environment it was built in, it requires an rpm that can handle dynamic buildrequires, -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538355914___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
BuildRecommends is semantically wrong, if it happens to be needed then it is needed (not recommended). These problems have no solution on SRPM level. Unless the spec file is preprocessed by rpm, no-one knows whether the package will depend on dynamic buildrequires feature or not. If anything, "rpmlib(MayDependOnDynamicBuildrequires)" tag can be added, but I doubt it would help anyone. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538350437___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
/me -monologue continues... The minimal change solution to the contains-issue would probably be moving the existing rpmlib() dependency to a weak dependency tag. We don't have BuildRecommends: in specs but nothing stops us from inserting such dependencies into src.rpm headers, and nothing stops anybody from querying them from there. I don't like that option because the rpmlib() dependency is wrong to begin with, but to enumerate our options... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538344379___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
One solution would be introducing a new rpmbuild() dependency namespace that is for build what rpmlib() is for install. It just seems as an awfully heavy solution to the problem at hand. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538341910___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
The second commit solves the identifiability of generated dependencies in a way that's actually in line with other such things in rpm. Now we just need an acceptable solution to the "contains" half. Any information in the src.rpm is only valid in the very environment it was created in because of spec conditionals, and this case is no different. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538339640___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
I'm afraid we'll have to do a brown paperbag release for 4.15 that replaces the rpmlib() tracking with something else, and do so ASAP before this spreads any further. And break existing users at that :( -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538283130___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
Ehm. From commit 58dcfddc376a7c97de1432f0082be0d5f01adbcd: > Source packages contain Requires: rpmlib(DynamicBuildRequires) <= 4.15.0-1 if the spec contains a %generate_buildrequires section and Provide: rpmlib(DynamicBuildRequires) = 4.15.0-1 No package can provide rpmlib() dependencies, ever. I don't know how I missed this in review, sigh. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538279441___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
Ack, I can understand the need for that, but rpmlib() dependency is not the right solution. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538277114___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
It was requirement from FESCo to be able to see if package uses/has dynamic BRs. I'll expand on this later today. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538264778___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
No, it was only in src.rpms, but it still prevents installing (ie unpacking) the src.rpm, which is equally wrong. I assume the idea here was to track ability to *build* such a package, but we lack such a facility and rpmlib() dependencies track ability to *install*, which is entirely different. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538249805___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
@pmatilai Wait, I thought that rpmlib dependency was only inserted for srpms. It was in binary RPMs too?! That stinks... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-538054596___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)
Test-suite adjusted as per the change. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/878#issuecomment-537927429___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
