[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 CC||domi...@greysector.net

--- Comment #3 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Vasiliy Glazov from comment #1)
[...]
> 5. In %files section use %{_bindir}/* instead of one string for each file.

Sorry, but I don't agree with using wildcards unless there are many files
there. You won't notice any new files there easily unless you run rpmdiff on
the final package or check manually. You don't have to save every single byte
of the spec file. It's better to be a little verbose and a lot more legible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #2 from Andrew Bauer  ---
Thank you for the feedback. I have made all five suggested changes.

I noticed that my centos 6 environment did not have the %make_build macro so I
defined it at the top of the specfile should it not exist at build time.

The latest specfile can be found here:
https://gist.github.com/knnniggett/cf2e4e2169ed8d4147b6367d6a60a843

Unless otherwise requested, I will wait for additional feedback before
uploading a new RPM/SRPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

Newcomer seeking sponsorship

[Andrew Bauer]

Greetings,
My real name is Andy, and I just went through the RPMFusion crash course for 
submitting my first package, zoneminder.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

I am part of the upstream zoneminder development team, and currently manage 
zmrepo.zoneminder.com. At the moment, zmrepo is the only third party repo with 
all of zoneminder's dependencies found in one place. If permitted, I would 
eventually like to move the zoneminder package to RPMFusion.

Additionally, I've got to find new homes for several of zoneminder's 
dependencies as well. I listed these in the bug report above. I don't expect 
this to be a fast process.

Some of you may know that zoneminder currently exists in the Fedora 25 repo. I 
have been in discussion with the Fedora packaging team to have it removed, 
moving forward. Because the surveillance industry has adopted h264 as the 
defacto streaming standard, zoneminder does not belong in the Fedora repo. 
Today, zoneminder will build w/o ffmpeg/h264 support but that makes it 
incompatible with nearly all modern ip cameras.

In any case, I'm getting help from Fedora, but I also need someone from 
RPMFusion to sponsor. Anyone willing?

___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Vasiliy Glazov  changed:

   What|Removed |Added

 CC||vasc...@gmail.com

--- Comment #1 from Vasiliy Glazov  ---
1. You should change %setup -q to %autosetup

2. make %{?_smp_mflags} to %make_build

3. export DESTDIR=%{buildroot}
make install
to %make_install

4. Remove 
%defattr(-,root,root,-)

5. In %files section use %{_bindir}/* instead of one string for each file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=30

Andrew Bauer  changed:

   What|Removed |Added

 Depends on||4393


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393
[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool
-- 
You are receiving this mail because:
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] New: Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Bug ID: 4393
   Summary: Review Request: zoneminder - A camera monitoring and
analysis tool
   Product: Package Reviews
   Version: Current
  Hardware: x86_64
OS: GNU/Linux
Status: NEW
  Severity: enhancement
  Priority: P1
 Component: Review Request
  Assignee: rpmfusion-package-rev...@rpmfusion.org
  Reporter: zonexpertconsult...@outlook.com
CC: rpmfusion-package-rev...@rpmfusion.org
Blocks: 2, 30

%description
ZoneMinder is a set of applications which is intended to provide a complete
solution allowing you to capture, analyze, record and monitor any cameras you
have attached to a Linux based machine. It is designed to run on kernels which
support the Video For Linux (V4L) interface and has been tested with cameras
attached to BTTV cards, various USB cameras and IP network cameras. It is
designed to support as many cameras as you can attach to your computer without
too much degradation of performance.

A little background. Zoneminder currently lives in the Fedora 25 repo and the
repo at zmrepo.zoneminder.com, which I am the maintainer of. In conversation
with the Fedora team, we agree that, due to zoneminder's ffmpeg dependencies,
it will be removed from the Fedora repo moving forward. In my opinion, the best
place for the zoneminder package to live is at RPMFusion, because some of
zoneminder's dependencies already exist here.

This is my first RPMFusion package. Note that I am also part of the upstream
zoneminder development team, and I do have a member of the Fedora packaging
team willing to support/sponsor me. It does look like I still need an RPMFusion
sponsor though.

Please note that zoneminder will currently build against the RPMFusion repo,
but it will not install, due to several missing dependencies. I am in the
process of learning how to get the following dependencies into Fedora and EPEL,
or failing that, RPMFusion:
cambozola
perl-Class-Std-Fast
perl-IO-Socket-Multicast
perl-SOAP-WSDL
perl-X10-ActiveHome
perl-Astro-SunTime

All of these packages currently exist in zmrepo.

zoneminder rpm specfile:
https://gist.github.com/knnniggett/cf2e4e2169ed8d4147b6367d6a60a843

The following SRPM will build on EL6 (i386, x86_64), EL7 (x86_64), and Fedora
(i386,x86_64,armhfp):
https://zmrepo.zoneminder.com/f/testing/25/SRPMS/zoneminder-1.30.1-1.fc25.src.rpm

Here is a complete rpmlint output:
https://gist.github.com/knnniggett/e944c47a5cfdfe71cf68d3ac2366afe2

What follows is a line-by-line response to what rpmlint found:

invalid-url Source0: ZoneMinder-1.30.1.tar.gz
Because zoneminder uses git submodules, the easiest thing for me to do is
create the tarball from my own local git repo. Fedora packaging guidelines
state this method is acceptable. However, please advise if a different method
would be preferred.

non-readable /etc/zm/zm.conf 640
This config file contains the mysql database login credentials. Hence the
reason for the 640 permissions. This is by design.

dangling-relative-symlink /usr/share/zoneminder/www/cambozola.jar
../../java/cambozola.jar
Zoneminder expects the cambozola.jar file to exist within zoneminder's web
root. Hence the purpose of the symlink.

explicit-lib-dependency libcurl
libcurl is one of the methods zoneminder uses to receive a stream from a
camera. If memory serves, rpmbuild does not autodetect this.

explicit-lib-dependency libjpeg-turbo
This is to ensure we have the turbo jpeg library rather than the legacy jpeg
library. Older el6 distros can have both so we want to make sure the turbo
library is installed.

no-manual-page-for-binary zmX.xx
These entries are incorrect. Zoneminder uses pod2man to dynamically create man
pages for its executables.

all the rest items under zoneminder's api folder
Zoneminder uses cakephp 2.8 and these entries are all part of that framework. I
am hesitant to do anything about these entries because they are from a
different project. Please advise.


Whew! Lots of information here, but I still feel like I am forgetting
something.


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
https://bugzilla.rpmfusion.org/show_bug.cgi?id=30
[Bug 30] Tracker : Sponsorship Request
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org