DO NOT REPLY [Bug 4870] --link-dest results in errors for some paths containing spaces
https://bugzilla.samba.org/show_bug.cgi?id=4870 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Comment #5 from [EMAIL PROTECTED] 2007-10-16 05:55 CST --- I'm the original bug reporter. You guys seem to have misunderstood the problem. The issue is not that there are spaces in the paths specified on the command line. It's that there are spaces in the subdirectories. i.e. My command line specified rsync://[EMAIL PROTECTED]/Backups/coppit/0 and rsync gives an error for /coppit/0/Palm/Users/David Coppit/SplashPhoto/E75FFB6FBF98B52F/DCIM. You say, Spaces in names read from directories don't make any difference to rsync. Do you have any hypothesis as to why spaces seem to result in the errors I am seeing? Perhaps there is some interaction with some other aspect of the system? Let me know if I can do anything to help debug this. -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
lchmod for osx (was: Symlinks in OS X (10.4.1))
Amazing no one else has written this... Someone with an intel mac
should test this to check the uint32_t works there too (I have a
powerpc).
#include stdio.h
#include stdlib.h
#include string.h
#include sys/attr.h /* !!! */
#include sys/stat.h
#include unistd.h
int my_lchmod(const char *path, mode_t mode) {
struct attrlist attrList;
uint32_t m;
/* manpage is wrong! not mode_t, but uint32_t is required */
memset(attrList, 0, sizeof(attrList));
attrList.bitmapcount = ATTR_BIT_MAP_COUNT;
attrList.commonattr = ATTR_CMN_ACCESSMASK;
m = mode;
return setattrlist(path, attrList, m, sizeof(m),
FSOPT_NOFOLLOW);
}
int main(int argc, const char **argv) {
struct stat st;
const char *file;
int perms;
file = argv[1];
perms = strtol(argv[2], 0, 0);
if (lstat(file, st) != 0) {
perror(stat);
return 1;
}
st.st_mode = (st.st_mode ~0777) | perms;
if (my_lchmod(file, st.st_mode) != 0) {
perror(lchmod);
return 1;
}
return 0;
}
--
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: lchmod for osx (was: Symlinks in OS X (10.4.1))
Here's a patch that makes link permissions work when applied to rsync CVS. I am also trying to make an lutimes alternative, but for whatever reason setattrlist silently drops my changes. lchmod-osx.patch Description: Binary data -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Symlinks in OS X (10.4.1)
On Mon, 2007-10-15 at 22:21 -0400, Matt McCutchen wrote: On 10/15/07, Wayne Davison [EMAIL PROTECTED] wrote: Is there a system call that allows their permissions to be changed after they've been created? (Since lchmod is lacking.) I don't think so, but as Wesley hinted, one can effectively change a symlink's permissions by deleting it, setting the umask appropriately, and recreating it. I think this behavior is useful enough to be provided by a distributed patch. It does break hard links; are there any other caveats? Deleting the symlink, means the link is not present for an undetermined period, doesn't seem a really clean way to just change permissions. Simo. -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: lchmod for osx (was: Symlinks in OS X (10.4.1))
I've noticed the same thing...trying to change any of the timestamps on a symlink via setattrlist does nothing at all (not even complain). On Oct 16, 2007, at 8:56 AM, Wesley W. Terpstra wrote: Here's a patch that makes link permissions work when applied to rsync CVS. I am also trying to make an lutimes alternative, but for whatever reason setattrlist silently drops my changes. lchmod-osx.patch -- To unsubscribe or change options: https://lists.samba.org/mailman/ listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart- questions.html -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: lchmod for osx (was: Symlinks in OS X (10.4.1))
On Tue, Oct 16, 2007 at 12:38:19PM +0200, Wesley W. Terpstra wrote: Someone with an intel mac should test this to check the uint32_t works there too (I have a powerpc). It worked fine for a simple test. The latest CVS code now has your lchmod() alternative if setattrlist() is around. Thanks! Now we'll see if any unexpected systems are affected by this change (I'm not expecting any, though). ..wayne.. -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: To inc_recurse or not to inc_recurse? [Re: 3.0.0pre2: bookend breakage (2 different errors)]
On Tue, Oct 16, 2007 at 12:30:34AM -0400, Matt McCutchen wrote: In this situation, automatically disabling incremental recursion would be better than exiting with an error that really isn't the user's fault. Yeah. I hadn't wanted to add an extra round-trip delay that would be required by a direct exchange of bytes. After some more contemplation I've come up with a good way to convey the inc_recurse decision back and forth between the two sides without slowing things down. And the latest code does let the affected side make the determination of which options are not support in incremental recursive mode. ..wayne.. -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: PATCH: preserve osx creation-date (was: Using pre2 for backing up a mac)
On Oct 15, 2007, at 1:55 AM, Wayne Davison wrote:
On Sun, Oct 14, 2007 at 08:14:57PM +0200, Wesley W. Terpstra wrote:
I've attached a patch which does this. Currently resource forks
and finder
info get placed into an extended attribute transparently by osx
(com.apple.{ResourceFork/FinderInfo}). This patch makes another
extended
attribute called com.apple.CreationDate.
Thanks! I've twiddled your patch a bit and checked it in as a file in
the patches dir (for now, at least): osx-create-time.diff
Found another bug: Some filesystems don't have creation dates
(*shock*). If you tried to read it on these filesystems, it will
fail, so one needs to check if the attribute exists first.
Revised patch attached.
check-first.patch
Description: Binary data
--
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
CVS update: rsync
Date: Tue Oct 16 15:10:02 2007 Author: wayned Update of /data/cvs/rsync In directory dp.samba.org:/tmp/cvs-serv8244 Modified Files: proto.h Log Message: Regenerated. Revisions: proto.h 1.357 = 1.358 http://www.samba.org/cgi-bin/cvsweb/rsync/proto.h?r1=1.357r2=1.358 ___ rsync-cvs mailing list rsync-cvs@lists.samba.org https://lists.samba.org/mailman/listinfo/rsync-cvs
CVS update: rsync
Date: Tue Oct 16 15:10:05 2007 Author: wayned Update of /data/cvs/rsync In directory dp.samba.org:/tmp/cvs-serv9262 Modified Files: rsync.h Log Message: Incremented the SUBPROTOCOL_VERSION. Revisions: rsync.h 1.371 = 1.372 http://www.samba.org/cgi-bin/cvsweb/rsync/rsync.h?r1=1.371r2=1.372 ___ rsync-cvs mailing list rsync-cvs@lists.samba.org https://lists.samba.org/mailman/listinfo/rsync-cvs
CVS update: rsync
Date: Tue Oct 16 15:10:12 2007 Author: wayned Update of /data/cvs/rsync In directory dp.samba.org:/tmp/cvs-serv11145 Modified Files: options.c Log Message: - Send an 'i' in the -e arg to the server if we can support inc_recurse. - Got rid of some unneeded blocking_io value twiddling. - Send --use-qsort to the server if it was specified. Revisions: options.c 1.414 = 1.415 http://www.samba.org/cgi-bin/cvsweb/rsync/options.c?r1=1.414r2=1.415 ___ rsync-cvs mailing list rsync-cvs@lists.samba.org https://lists.samba.org/mailman/listinfo/rsync-cvs
CVS update: rsync
Date: Tue Oct 16 15:10:17 2007 Author: wayned Update of /data/cvs/rsync In directory dp.samba.org:/tmp/cvs-serv11268 Modified Files: main.c Log Message: Call set_allow_inc_recurse() for situations that don't call server_options(). Revisions: main.c 1.351 = 1.352 http://www.samba.org/cgi-bin/cvsweb/rsync/main.c?r1=1.351r2=1.352 ___ rsync-cvs mailing list rsync-cvs@lists.samba.org https://lists.samba.org/mailman/listinfo/rsync-cvs
CVS update: rsync/patches
Date: Tue Oct 16 15:14:30 2007 Author: wayned Update of /data/cvs/rsync/patches In directory dp.samba.org:/tmp/cvs-serv12623 Modified Files: detect-renamed.diff Log Message: Fixed a failing hunk, tweaked option sending. Revisions: detect-renamed.diff 1.36 = 1.37 http://www.samba.org/cgi-bin/cvsweb/rsync/patches/detect-renamed.diff?r1=1.36r2=1.37 ___ rsync-cvs mailing list rsync-cvs@lists.samba.org https://lists.samba.org/mailman/listinfo/rsync-cvs
CVS update: rsync
Date: Tue Oct 16 16:00:41 2007 Author: wayned Update of /data/cvs/rsync In directory dp.samba.org:/tmp/cvs-serv25522 Modified Files: syscall.c Log Message: Adding Wesley Terpstra's lchmod()-equivalent that uses setattrlist(). Revisions: syscall.c 1.55 = 1.56 http://www.samba.org/cgi-bin/cvsweb/rsync/syscall.c?r1=1.55r2=1.56 ___ rsync-cvs mailing list rsync-cvs@lists.samba.org https://lists.samba.org/mailman/listinfo/rsync-cvs
CVS update: rsync
Date: Tue Oct 16 16:19:40 2007 Author: wayned Update of /data/cvs/rsync In directory dp.samba.org:/tmp/cvs-serv9037 Modified Files: rsync.yo rsync.1 Log Message: The start of some updated thanks. Revisions: rsync.yo1.434 = 1.435 http://www.samba.org/cgi-bin/cvsweb/rsync/rsync.yo?r1=1.434r2=1.435 rsync.1 1.448 = 1.449 http://www.samba.org/cgi-bin/cvsweb/rsync/rsync.1?r1=1.448r2=1.449 ___ rsync-cvs mailing list rsync-cvs@lists.samba.org https://lists.samba.org/mailman/listinfo/rsync-cvs
CVS update: rsync
Date: Tue Oct 16 18:33:47 2007 Author: wayned Update of /data/cvs/rsync In directory dp.samba.org:/tmp/cvs-serv5560 Modified Files: compat.c Log Message: Tweaked set_allow_inc_recurse() a bit more. Revisions: compat.c1.67 = 1.68 http://www.samba.org/cgi-bin/cvsweb/rsync/compat.c?r1=1.67r2=1.68 ___ rsync-cvs mailing list rsync-cvs@lists.samba.org https://lists.samba.org/mailman/listinfo/rsync-cvs
