[Bug 11382] New: elapsed time calculation does not account for time function possibly returning -1
https://bugzilla.samba.org/show_bug.cgi?id=11382 Bug ID: 11382 Summary: elapsed time calculation does not account for time function possibly returning -1 Product: rsync Version: 3.1.1 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: core Assignee: way...@samba.org Reporter: br...@gurganus.name QA Contact: rsync...@samba.org starttime currently initialized on line 1529 of main.c and endtime currently initialized on line 222 of main.c, both of which are used on line 344 are used in a manner that does not handle that time(NULL) can return -1. Out of curiosity, I did try reading through the glibc source code for that function to find it currently does return -1, and at the glibc level, that's all that the time function does unless appropriate bridging to a kernel is implemented. I did not take the time to try looking at other libc implementations or to see under what conditions the linux kernel might return -1. As I only see one usage on line 344, if one of those two values comes back as -1 for some reason, perhaps that information line should be ommitted or replaced since the statistic trying to be printed would not be a valid statistic if one of the two time() calls returned -1. Glibc documents the -1 possibility at http://www.gnu.org/software/libc/manual/html_node/Simple-Calendar-Time.html#Simple-Calendar-Time Microsoft documents the -1 possibility for their libc implementations as well at https://msdn.microsoft.com/en-us/library/1f4c8f33.aspx?f=255MSPPError=-2147217396 -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
[Bug 11369] obsoleted autoconf macros
https://bugzilla.samba.org/show_bug.cgi?id=11369 --- Comment #1 from Brant Gurganus br...@gurganus.name --- Created attachment 11232 -- https://bugzilla.samba.org/attachment.cgi?id=11232action=edit patch consisting of autoupdate changes that do not involve evaluating code compatibility impact I've created a patch consisting of the autoupdate changes. -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: cut-off time for rsync ?
Ken Chase rsync-list-m...@sizone.org wrote: You have NO IDEA how long it takes to scan 100M files on a 7200 rpm disk. Actually I do have some idea ! Additionally, I dont know if linux (or freebsd or any unix) can be told to cache metadata more aggressively than data That had gone through my mind - how much RAM do you have in the backup system ? Also what other options do you use - I've found some of them (especially hard-links) can have a significant impact on performance. Otherwise, have you looked at StoreBackup ? It's probably somewhat more than you are after, *but* it does have a mode specifically for efficient transfer of backups from one system to another. I've been using it for a few years for my backups (keeping multiple backups etc) but haven't used the remote transfer bit yet. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
