Re: [sage-devel] Re: Disputed Pull Requests / Role Sage-Abuse and the Code of Conduct

2024-02-23 Thread David Roe
On Thu, Feb 22, 2024 at 9:11 PM Matthias Koeppe 
wrote:

> On Wednesday, January 10, 2024 at 6:50:10 AM UTC-8 William Stein wrote:
>
> the main act of censure that the sage-abuse committee will be
> taking going forward will be to delete comments (on github and mailing
> lists) that violate the code of conduct.
>
>
> William, Volker, I've already shared privately in great detail why this is
> insufficient.
>
> But even this decidedly narrow scope -- is anyone taking care of it at all?
> Is https://groups.google.com/g/sage-abuse attended?
>

I can confirm that the google group list does receive messages.


> And if so, may we know who's on the committee?
>
> Asking on behalf of the community.
>

The members of the committee are:

* William Stein
* Vincent Delecroix
* David Joyner
* Harald Schilly
* John Palmieri
* David Roe

The membership of the committee has been unchanged for years, and some of
us are no longer very involved in Sage development.  We are meeting early
next week in order to discuss some of the recent issues, and I welcome
comments or suggestions, which you can send publicly or to me in private.
David


>
> Matthias
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/89d80d9a-e991-4a0f-91d7-cfe5bc2b914en%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAChs6_k3A8zhEx2MKzY3edVh6kGdo0L3%3D7Ap1n8C4hEgre9OGg%40mail.gmail.com.


[sage-devel] Re: Policy for disputed PRs: discussion

2024-02-23 Thread Kwankyu Lee
Hi,

Another "disputed" PR is piled on the heap: 
https://github.com/sagemath/sage/pull/36999

Behind a disputed PR, there is a lot of time and energy wasted from the 
author, the reviewers, and the audience. The disputed PRs discourage 
everyone in the community.

I am aware that one policy about the disputed PRs is in action: the release 
manager took the editor role and has made decisions on some disputed PRs.

But I feel that disputed PRs are to be piled up, and the editor policy is 
not efficient enough. We need some permanent and fast policy. So I suggest 
the following

1. A PR is a "disputed PR" if there are both approving and disapproving 
reviewers. 
2. It is the author's right to add "disputed" label to his/her disputed PR 
(to prevent another dispute on adding the label).
3. The release manager is the lifelong editor for disputed PRs. 
4. We adopt the "automatic poll" policy:
(a) A disputed PR gets "Approve" or "Request changes" decisions from 
reviewers.
(b) If the number of "Approve" decisions is more than or equal to the 
twice of the number of "Request changes" decisions, then "positive review" 
label is added to the PR.
(c) There is no voting period. It is up to the author whether to close 
the PR or to keep waiting.

If David has no time, then I will post a voting on sage-devel after hearing 
some comments.

Thanks for attention.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/103433a3-a9c1-4440-9d8d-f6c44bb92b87n%40googlegroups.com.


[sage-devel] Re: Policy for disputed PRs: discussion

2024-02-23 Thread Kwankyu Lee
Hi,

Another "disputed" PR is piled on the 
heap: https://github.com/sagemath/sage/pull/36999

Behind a disputed PR, there is a lot of time and energy wasted from the 
author, the reviewers, and the audience. The disputed PRs discourage 
everyone in the community.

I am aware that one policy about the disputed PRs is in action: the release 
manager took the editor role and has made decisions on some disputed PRs.

But I feel that disputed PRs are to be piled up, and the editor policy is 
not efficient enough. We need some permanent and fast policy. So I suggest 
the following

1. A PR is a "disputed PR" if there are both approving and disapproving 
reviewers. 
2. It is the author's right to add "disputed" label to his/her disputed PR 
(to prevent another dispute on adding the label).
2. The release manager is the lifelong editor for disputed PRs. 
3. We adopt the "automatic poll" policy:
(a) A disputed PR gets "Approve" or "Request changes" decisions from 
reviewers.
(b) If the number of "Approve" decisions is more than or equal to the 
twice of the number of "Request changes" decisions, then "positive review" 
label is added to the PR.
(c) There is no voting period. It is up to the author whether to close 
the PR or to keep waiting.

If David has no time, then I will post a voting on sage-devel after hearing 
some comments.







  






On Sunday, December 31, 2023 at 2:13:18 PM UTC+9 Kwankyu Lee wrote:

> Wish you a happy new year!
>
> A year ago, we successfully escaped from a sinking issue management system.
>
> Hopefully, the new year will save us from the current spiral that's 
> drowning us.
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/9009b342-9d27-4cc8-9b22-3c7abfadbf8bn%40googlegroups.com.


Re: [sage-devel] No MathJax display in Sage 10.3.beta notebooks when offline

2024-02-23 Thread Dima Pasechnik
My experiments with a pure upstream jupyterlab show that this is not 
reproducible there.
Namely:
1) clean up cache of your browser
2) create a fresh venv and pip install jupyterlab there, and the 
corresponding mathjax package:

$ python3 -m venv foo
$. foo/bin/activate
(foo) $ pip install jupyterlab
(foo) $ pip install jupyterlab-mathjax3

3) Disconnect the internet. Launch notebook

(foo) $ jupyterlab textest.ipynb # attached

4) Try evaluating cells (they all show nice mathjax - probably from a 
system package, but certainly not from a CDN)

-

IMHO it's yet another reason for stopping to vendor Jupyter(lab), and just 
using what's readily provided by the pure upstream!

Dima


On Friday, February 16, 2024 at 9:50:46 AM UTC Eric Gourgoulhon wrote:

> Hi Nils,
>
> Le vendredi 16 février 2024 à 04:37:28 UTC+1, Nils Bruin a écrit :
>
> On Thursday 15 February 2024 at 17:02:14 UTC-8 Dima Pasechnik wrote:
>
> but that's sphinx (Python), not jupyter.
>
> I see. The page I linked to is from Jupyter{book} which is, despite the 
> similarity in name, not the jupyter notebook server. 
>
>
> You are not alone: I did exactly the same thing ;-) After a google-search 
> for "jupyter custom mathjax", I ended up on the same page and for a second 
> I thought it contains the solution, before realizing that this page is 
> dedicated to the Sphinx generation of a book about Jupyter, not to Jupyter 
> itself. 
>
> Eric. 
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/9a7e74af-57a7-48a5-abc8-ff1f37dca69en%40googlegroups.com.


textst.ipynb
Description: application/ipynb


[sage-devel] Re: Help with coercion / action for tensor product

2024-02-23 Thread 'Martin R' via sage-devel
I just prepared a very long answer.  Doing so I had to check something in 
my code.  This in turn lead me to discover a bug, which might slightly 
change things.  I am too tired right now to fix the bug (it might not be 
easy), so please give me a night.

This might reduce the problem to nothing, but I don't know yet.

I'm sorry!

Martin

On Friday 23 February 2024 at 21:07:19 UTC+1 Nils Bruin wrote:

> On Friday 23 February 2024 at 06:44:39 UTC-8 Martin R wrote:
>
> Dear all!
>
> I badly need help to make the following work. Let M be a module over a 
> ring Q, and let R be a ring with a coercion from Q to R.  Then I want to be 
> able to multiply elements in R with elements in tensor products of M.
>
>
> It looks to me you should first base extend M to M_R, a module over R, 
> using the coercion map Q->R.  So I don't think R acts on M. It acts on M_R.
>
> Do you want the coercion system to be smart enough to construct that base 
> extension for you? I'm not sure I'd expect the system to do that or even be 
> in favour of the system doing that on its own.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/3dac6bcb-2353-4e4a-b793-b3d50832a9ccn%40googlegroups.com.


[sage-devel] Re: Help with coercion / action for tensor product

2024-02-23 Thread Nils Bruin
On Friday 23 February 2024 at 06:44:39 UTC-8 Martin R wrote:

Dear all!

I badly need help to make the following work. Let M be a module over a ring 
Q, and let R be a ring with a coercion from Q to R.  Then I want to be able 
to multiply elements in R with elements in tensor products of M.


It looks to me you should first base extend M to M_R, a module over R, 
using the coercion map Q->R.  So I don't think R acts on M. It acts on M_R.

Do you want the coercion system to be smart enough to construct that base 
extension for you? I'm not sure I'd expect the system to do that or even be 
in favour of the system doing that on its own.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/27a09e05-f454-4f7b-b955-b888f01ab48cn%40googlegroups.com.


[sage-devel] Help with coercion / action for tensor product

2024-02-23 Thread 'Martin R' via sage-devel
Dear all!

I badly need help to make the following work. Let M be a module over a ring 
Q, and let R be a ring with a coercion from Q to R.  Then I want to be able 
to multiply elements in R with elements in tensor products of M.  This is 
https://github.com/sagemath/sage/pull/37413, and is (hopefully) the final 
stumbling block for https://github.com/sagemath/sage/pull/37033.

Multiplying elements in R with elements in M works.

Here is an example:

sage: M = CombinatorialFreeModule(QQ, [1,2,3])
sage: m = M.an_element(); m
2*B[1] + 2*B[2] + 3*B[3]

sage: R. = QQ[]
sage: r = x + 1

sage: r * m
(2*x+2)*B[1] + (2*x+2)*B[2] + (3*x+3)*B[3]

sage: T = M.tensor(M)
sage: t = T.an_element(); t
2*B[1] # B[1] + 2*B[1] # B[2] + 3*B[1] # B[3]

sage: r * t
TypeError

Help is greatly appreciated.  There is already some info at the ticket, but 
I don't know how to proceed.

Best wishes,

Martin

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/89ad4608-6c9e-4e04-bfda-6c7572f423c8n%40googlegroups.com.


[sage-devel] Re: Bug in integration on a Riemann surface

2024-02-23 Thread Linden Disney
As a note, I have now raised an 
issue https://github.com/sagemath/sage/issues/37438 about this on github. 

On Monday, January 22, 2024 at 5:57:50 PM UTC Nils Bruin wrote:

> More importantly, the error also doesn't occur with
>
> S = Curve(f).riemann_surface(integration_method="heuristic")
>
> so it's indeed in the newer code. The fact that swapping x,z makes the 
> error disappear is also unsurprising: entirely different path integrals are 
> executed.
>
> As an indication for what is likely happening, on line 2211:
>
> delta_z and rho_z seem to be indistinguishable, forcing Delta and M to be 
> +infinity. Path splitting should definitely happen here. I think delta_z 
> should have been smaller than rho_z when you reach this point, so I think 
> the code should have bailed before.
> On Monday 22 January 2024 at 03:03:20 UTC-8 Linden Disney wrote:
>
>> In Sage 9.8 I ran the following code:
>>
>> R. = QQ[]
>> f = x*(1^5+z^5) + (x*1*z)^2 - x^4*1*z - 2*1^3*z^3
>> S = Curve(f).riemann_surface()
>> S.riemann_matrix()
>>
>> and got a ValueError occurring inside rigorous_line_integral. This error 
>> doesn't occur if instead for the first line I used "R. = QQ[]" 
>> (swapping the order of x and z). Can anyone replicate the error? If so 
>> please let me know and I will open a ticket about this and have a look, as 
>> I wrote the rigorous_line_integral code. 
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/31d5369b-839c-456e-a14b-af7c6f80bc27n%40googlegroups.com.