[Samba] RH7.3 compatibility with SRPMS
I just rebuilt the Redhat SRPMS using 7.3 - I am noticed in the SPEC file some RH8/9 specific shell scripts. So far it seems to be working fine - just wondering if there is any conflicts with this..thanks in advance. # Don't depend on Net::LDAP # one filter for RH 8 and one for 9 Source998: filter-requires-samba_rh8.sh Source999: filter-requires-samba_rh9.sh # Working around perl dependency problem from docs # Only RH 8.0 seems to care here echo rpm_version == %{rpm_version} if [ %{rpm_version} == 42 ]; then %define __perl_requires %{SOURCE999} echo %{__perl_requires} elif [ %{rpm_version} == 41 ]; then %define __find_requires %{SOURCE998} echo %{__find_requires} fi -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] Re: Charset Problem
Wang.Hua wrote: EmailI have serverl mounted point having different iocharset But samba 3.x seems just having one global unix charset option Is there a way to set charset on a directory basis No, but you can use the convmv software to convert all filenames to a single character set -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
Re: [Samba] roaming profiles ok, but what about the printers?
On Sat, 2004-09-04 at 21:20, Andreas Paulick wrote: I've got some inspirations from the archive of lists.samba.org and I'm writing a little shell-wrapper around the print-command. Because I have'nt access to the server right now I write this from memory: I've got a similar setup, using CUPS and %m included smb.conf files. All printers in the lpr-command must be exist. The clients only sees the 3 Printer LASER, LASER2 and COLOR and use them with generic postscript-driver. At the samba server runs also a printserver and it cares via ghostscript about the translation to the the printer. New Printers will be installed only at the linux-server, the name will written in the script.sh and 'done'. No changes necessary at the Clients. So easy can also substituted a printer :) I have to optimise and test this etc. then should it running. B.t.w.: which generic windows-printerdriver would you suggest? Maybe 'Apple Laserwriter 600 PS' or 'HP Laserjet PS' ? Or use you the vendor windows-printerdriver and print at rawdriver on linux-side? I ended up back with the Adobe PS drivers, after trying (and failing with) the CUPS drivers. I had problems with using 'HP Laserjet PS' drivers, because of the PCL escape on the header, which confused CUPS. Likewise, the Apple Laserwriter had some issue, I can't recall what exactly. I'm looking forward to the new CUPS drivers (based on a newer DDK), when they come out. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Authentication Developer, Samba Teamhttp://samba.org Student Network Administrator, Hawker College [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] Segfault in Samba
Hi! My Samba setup broke after upgrading Samba from 3.0.5-1 to 3.0.6-3 using Debian apt-get upgrade. It seems to me, that the problems lies within winbind. Any help would be appreciated! -- Pirkka The Samba 'panic action' script, /usr/share/samba/panic-action, was called for pid 8012 (/usr/sbin/smbd). Below is a backtrace for this process generated with gdb, which shows the state of the program at the time the error occured. You are encouraged to submit this information as a bug report to Debian. For information about the procedure for submitting bug reports , please see http://www.debian.org/Bugs/Reporting or the reportbug(1) manpage. (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...0x402346f8 in waitpid () from /lib/libc.so.6 #0 0x402346f8 in waitpid () from /lib/libc.so.6 #1 0x402bc550 in sys_sigabbrev () from /lib/libc.so.6 #2 0x081d2d71 in smb_panic2 () #3 0x081d2cfa in smb_panic () #4 0x081c0878 in dbgtext () #5 0x401b6658 in __libc_sigaction () from /lib/libc.so.6 #6 0x401b79e8 in abort () from /lib/libc.so.6 #7 0x401afb3f in __assert_fail () from /lib/libc.so.6 #8 0x40465081 in winbindd_fd () from /lib/libnss_ldap.so.2 #9 0x40464f0c in winbindd_fd () from /lib/libnss_ldap.so.2 #10 0x40464c03 in winbindd_fd () from /lib/libnss_ldap.so.2 #11 0x40468365 in _nss_ldap_getservent_r () from /lib/libnss_ldap.so.2 #12 0x40462bfa in winbindd_fd () from /lib/libnss_ldap.so.2 #13 0x40463fca in winbindd_fd () from /lib/libnss_ldap.so.2 #14 0x40464525 in winbindd_fd () from /lib/libnss_ldap.so.2 #15 0x40465649 in _nss_ldap_getpwnam_r () from /lib/libnss_ldap.so.2 #16 0x40233e76 in getpwnam_r () from /lib/libc.so.6 #17 0x4023396f in getpwnam () from /lib/libc.so.6 #18 0x081c72b1 in getpwnam_alloc () #19 0x081c57b4 in map_username () #20 0x081c5a4a in Get_Pwnam () #21 0x0820fa55 in smb_getpwnam () #22 0x0820f838 in make_server_info_guest () #23 0x0820fc10 in make_server_info_info3 () #24 0x0820cdd8 in auth_server_init () #25 0x0820d108 in auth_server_init () #26 0x0820b4a5 in auth_unix_init () #27 0x0820822f in smb_register_auth () #28 0x08211349 in password_ok () #29 0x08100591 in ntlmssp_end () #30 0x080ffb2b in ntlmssp_update () #31 0x0821166d in auth_ntlmssp_update () #32 0x080acd91 in reply_getattrE () #33 0x080ad064 in reply_getattrE () #34 0x080ae05b in reply_sesssetup_and_X () #35 0x080d0496 in respond_to_all_remaining_local_messages () #36 0x080d0720 in respond_to_all_remaining_local_messages () #37 0x080d092c in process_smb () #38 0x080d1648 in smbd_process () #39 0x08244a5d in main () #40 0x401a2dc6 in __libc_start_main () from /lib/libc.so.6 -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] Printing Problem
Hi there. I have the following Problem (configuration follows): I have configured Samba with 3 printers, 2 of them with direct connection over TCP, because they are connected directly to the internal network. When I try to print on one of them, the printing application on a Windows XP Professional client freezes and a Windows 2000 client reports an error message, that there is a problem with the printer. The other printers work fine on both machines. Two days ago, it worked without problems. The printer is a Minolta Fiery X3e and on the web interface the status is up and running. Printing directly over the printer's Web Interface works. Here is my configuration: Red Hat Linux release 9 (Shrike), Samba 3.0.2 Printing with Cups smb.conf: [global] workgroup = OLYMP server string = MARS hosts allow = 192.168.0. 127. printcap name = /etc/printcap load printers = yes print command = lp -c -d%p -oraw %s rm %s echo Der Druckauftrag von %m wird bearbeitet. | smbclient -M %m -U %p log file = /var/log/samba/log.%m max log size = 50 security = user encrypt passwords = yes smb passwd file = /etc/samba/smbpasswd username map = /etc/samba/smbusers add user script = /usr/sbin/useradd -m %u delete user script = /usr/sbin/userdel -r %u add group script = /usr/sbin/groupadd %g delete group script = /usr/sbin/groupdel %g add user to group script = /usr/sbin/usermod -G %g %u add machine script = /usr/sbin/useradd -s /bin/false \ -d /dev/null %u socket options = TCP_NODELAY SO_RCVBUF=8192 SO_SNDBUF=8192 interfaces = 192.168.0.1/24 os level = 100 domain master = yes preferred master = yes domain logons = yes name resolve order = wins lmhosts bcast wins support = yes [homes] comment = Home Directories browseable = no valid users= %S writable = yes force group=brenner path=/dataraid/homes/%S [netlogon] comment = Network Logon Service path = /usr/local/samba/lib/netlogon admin users=root,wolfgang guest ok = yes writable = no share modes = no [Profiles] path = /usr/local/samba/profiles browseable = no guest ok = yes [printers] comment = All Printers path = /var/spool/samba browseable = yes guest ok = yes writable = no printable = yes [artdirectory] comment = Alle Dateien hier hinein! path = /dataraid/global_data browseable = yes guest ok = no writable = no write list = @ntadmins force group = ntadmins create mask = 777 directory mask = 777 [backup] comment = Backup path = /backup/dvdbackup browseable = yes guest ok = no writeable = no __-- cups printers.conf: # Printer configuration file for CUPS v1.1.17 # Written by cupsd on Son 05 Sep 2004 08:27:14 GMT DefaultPrinter designjet Info Created by redhat-config-printer 0.6.x DeviceURI socket://192.168.0.11:9100 State Idle Accepting Yes JobSheets none none QuotaPeriod 0 PageLimit 0 KLimit 0 /Printer Printer fiery Info Created by redhat-config-printer 0.6.x DeviceURI socket://192.168.0.10:9100 State Idle Accepting Yes JobSheets none none QuotaPeriod 0 PageLimit 0 KLimit 0 /Printer Printer HPLaserjet Info Created by redhat-config-printer 0.6.x DeviceURI parallel:/dev/lp0 State Idle Accepting Yes JobSheets none none QuotaPeriod 0 PageLimit 0 KLimit 0 /Printer -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] Re: Printing Problem
Hi again. I have solved the problem, but I don't know, why it works now. I just restarted the samba daemon. Sometimes, I also have the problem that the printer shares just disappear. I recognized that, when I tried to reinstall a printer on a client machine and the computer didn't find any printers on my server. This is a very strange behaviour and I hope it won't happen again. Greetings, Richard On Sun, 5 Sep 2004 11:51:09 +0200, Richard Brenner [EMAIL PROTECTED] wrote: Hi there. I have the following Problem (configuration follows): I have configured Samba with 3 printers, 2 of them with direct connection over TCP, because they are connected directly to the internal network. When I try to print on one of them, the printing application on a Windows XP Professional client freezes and a Windows 2000 client reports an error message, that there is a problem with the printer. The other printers work fine on both machines. Two days ago, it worked without problems. The printer is a Minolta Fiery X3e and on the web interface the status is up and running. Printing directly over the printer's Web Interface works. Here is my configuration: Red Hat Linux release 9 (Shrike), Samba 3.0.2 Printing with Cups smb.conf: [global] workgroup = OLYMP server string = MARS hosts allow = 192.168.0. 127. printcap name = /etc/printcap load printers = yes print command = lp -c -d%p -oraw %s rm %s echo Der Druckauftrag von %m wird bearbeitet. | smbclient -M %m -U %p log file = /var/log/samba/log.%m max log size = 50 security = user encrypt passwords = yes smb passwd file = /etc/samba/smbpasswd username map = /etc/samba/smbusers add user script = /usr/sbin/useradd -m %u delete user script = /usr/sbin/userdel -r %u add group script = /usr/sbin/groupadd %g delete group script = /usr/sbin/groupdel %g add user to group script = /usr/sbin/usermod -G %g %u add machine script = /usr/sbin/useradd -s /bin/false \ -d /dev/null %u socket options = TCP_NODELAY SO_RCVBUF=8192 SO_SNDBUF=8192 interfaces = 192.168.0.1/24 os level = 100 domain master = yes preferred master = yes domain logons = yes name resolve order = wins lmhosts bcast wins support = yes [homes] comment = Home Directories browseable = no valid users= %S writable = yes force group=brenner path=/dataraid/homes/%S [netlogon] comment = Network Logon Service path = /usr/local/samba/lib/netlogon admin users=root,wolfgang guest ok = yes writable = no share modes = no [Profiles] path = /usr/local/samba/profiles browseable = no guest ok = yes [printers] comment = All Printers path = /var/spool/samba browseable = yes guest ok = yes writable = no printable = yes [artdirectory] comment = Alle Dateien hier hinein! path = /dataraid/global_data browseable = yes guest ok = no writable = no write list = @ntadmins force group = ntadmins create mask = 777 directory mask = 777 [backup] comment = Backup path = /backup/dvdbackup browseable = yes guest ok = no writeable = no __-- cups printers.conf: # Printer configuration file for CUPS v1.1.17 # Written by cupsd on Son 05 Sep 2004 08:27:14 GMT DefaultPrinter designjet Info Created by redhat-config-printer 0.6.x DeviceURI socket://192.168.0.11:9100 State Idle Accepting Yes JobSheets none none QuotaPeriod 0 PageLimit 0 KLimit 0 /Printer Printer fiery Info Created by redhat-config-printer 0.6.x DeviceURI socket://192.168.0.10:9100 State Idle Accepting Yes JobSheets none none QuotaPeriod 0 PageLimit 0 KLimit 0 /Printer Printer HPLaserjet Info Created by redhat-config-printer 0.6.x DeviceURI parallel:/dev/lp0 State Idle Accepting Yes JobSheets none none QuotaPeriod 0 PageLimit 0 KLimit 0 /Printer -- ___ Richard Brenner Hetzendorferstraße 24/1/4 1120 Wien Cell: 0650-BRENNER -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
Re: [Samba] RH7.3 compatibility with SRPMS
On Sun, 2004-09-05 at 16:10, Chris McKeever wrote: I just rebuilt the Redhat SRPMS using 7.3 - I am noticed in the SPEC file some RH8/9 specific shell scripts. So far it seems to be working fine - just wondering if there is any conflicts with this..thanks in advance. RH 7.3 is getting quite old now, and I doubt it's being tested. In any case, these scripts are not required if the rebuild works, they just remove Net::LDAP from the 'requires' statement of the binary RPM. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Authentication Developer, Samba Teamhttp://samba.org Student Network Administrator, Hawker College [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] older packages?
Hi, Where can I download older Debian packages to downgrade e.g. my Samba (3.0.6-3 = 3.0.5-2)? -- Pirkka -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
Re: [Samba] RH7.3 compatibility with SRPMS
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Bartlett wrote: | On Sun, 2004-09-05 at 16:10, Chris McKeever wrote: | |I just rebuilt the Redhat SRPMS using 7.3 - I am noticed in the SPEC |file some RH8/9 specific shell scripts. So far it seems to be working |fine - just wondering if there is any conflicts with this..thanks in |advance. | | | RH 7.3 is getting quite old now, and I doubt it's | being tested. In any case, these scripts are not required | if the rebuild works, they just remove Net::LDAP from | the 'requires' statement of the binary RPM. Actually, ths SRPMS is built on RedHat 7.3 for just this reason. So that people can rebuild it. I don't release the 7.3 RPM since the demand is pretty low these days. But the SRPMS should be fine. cheer,s jerry - - Alleviating the pain of Windows(tm) --- http://www.samba.org GnuPG Key- http://www.plainjoe.org/gpg_public.asc If we're adding to the noise, turn off this song--Switchfoot (2003) -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFBOwMjIR7qMdg1EfYRAq8PAJ9j7WDkJcARmaWfNXL/suUIxT9pHACghAiT ua9Ba5TSjE2EFHwdOKZCXR4= =IkoI -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
Re: [Samba] smbclient: support for long share names..?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dabney, Nathan T. wrote: | I am running smbclient: Version 3.0.6-SUSE (SLES 8.0) | | I am still unable to see any printer shares with | names longer than 12 characters. Does anyone have an idea | how to resolve this? I think this is smbd not returning long share names via the NetSahreEnum RAP call. I've got some information from Buchan (mandrake pkg maintainer) to work on this. But I think this might the correct behavior and it was previously a bug that we returned long names. But I'm still working on it. cheers, jerry - - Alleviating the pain of Windows(tm) --- http://www.samba.org GnuPG Key- http://www.plainjoe.org/gpg_public.asc If we're adding to the noise, turn off this song--Switchfoot (2003) -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFBOwTtIR7qMdg1EfYRAs91AJ938ZCrsq81r6hDQC5p9txiy4lBvwCg7qlI /NLEkcrSmPKb8opTn2r/118= =RhB4 -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Segfault in Samba
Jerry! My Samba stopped panicing, but refuses to authenticate. With default log level all I get is: [2004/09/05 15:37:17, 0] auth/auth_util.c:make_server_info_info3(1122) make_server_info_info3: pdb_init_sam failed! I found your reply from linuxforum.com about some winbind patch, but don't know what to do with it. http://www.linuxforum.com/forums/index.php?s=5e6137b33f8acfb431f5e97a5aaad590showtopic=98934st=0#entry430085 I see all users with getent passwd / group and it has worked fine before... any ideas? -- Pirkka Hi! My Samba setup broke after upgrading Samba from 3.0.5-1 to 3.0.6-3 using Debian apt-get upgrade. It seems to me, that the problems lies within winbind. Any help would be appreciated! -- Pirkka The Samba 'panic action' script, /usr/share/samba/panic-action, was called for pid 8012 (/usr/sbin/smbd). Below is a backtrace for this process generated with gdb, which shows the state of the program at the time the error occured. You are encouraged to submit this information as a bug report to Debian. For information about the procedure for submitting bug reports , please see http://www.debian.org/Bugs/Reporting or the reportbug(1) manpage. (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...0x402346f8 in waitpid () from /lib/libc.so.6 #0 0x402346f8 in waitpid () from /lib/libc.so.6 #1 0x402bc550 in sys_sigabbrev () from /lib/libc.so.6 #2 0x081d2d71 in smb_panic2 () #3 0x081d2cfa in smb_panic () #4 0x081c0878 in dbgtext () #5 0x401b6658 in __libc_sigaction () from /lib/libc.so.6 #6 0x401b79e8 in abort () from /lib/libc.so.6 #7 0x401afb3f in __assert_fail () from /lib/libc.so.6 #8 0x40465081 in winbindd_fd () from /lib/libnss_ldap.so.2 #9 0x40464f0c in winbindd_fd () from /lib/libnss_ldap.so.2 #10 0x40464c03 in winbindd_fd () from /lib/libnss_ldap.so.2 #11 0x40468365 in _nss_ldap_getservent_r () from /lib/libnss_ldap.so.2 #12 0x40462bfa in winbindd_fd () from /lib/libnss_ldap.so.2 #13 0x40463fca in winbindd_fd () from /lib/libnss_ldap.so.2 #14 0x40464525 in winbindd_fd () from /lib/libnss_ldap.so.2 #15 0x40465649 in _nss_ldap_getpwnam_r () from /lib/libnss_ldap.so.2 #16 0x40233e76 in getpwnam_r () from /lib/libc.so.6 #17 0x4023396f in getpwnam () from /lib/libc.so.6 #18 0x081c72b1 in getpwnam_alloc () #19 0x081c57b4 in map_username () #20 0x081c5a4a in Get_Pwnam () #21 0x0820fa55 in smb_getpwnam () #22 0x0820f838 in make_server_info_guest () #23 0x0820fc10 in make_server_info_info3 () #24 0x0820cdd8 in auth_server_init () #25 0x0820d108 in auth_server_init () #26 0x0820b4a5 in auth_unix_init () #27 0x0820822f in smb_register_auth () #28 0x08211349 in password_ok () #29 0x08100591 in ntlmssp_end () #30 0x080ffb2b in ntlmssp_update () #31 0x0821166d in auth_ntlmssp_update () #32 0x080acd91 in reply_getattrE () #33 0x080ad064 in reply_getattrE () #34 0x080ae05b in reply_sesssetup_and_X () #35 0x080d0496 in respond_to_all_remaining_local_messages () #36 0x080d0720 in respond_to_all_remaining_local_messages () #37 0x080d092c in process_smb () #38 0x080d1648 in smbd_process () #39 0x08244a5d in main () #40 0x401a2dc6 in __libc_start_main () from /lib/libc.so.6 -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] Samba SOHO
Hi What is the best way to setup a Samba server as a file server in a small SOHO. I have to connect 2 windows XP machine and one XP home notebook to a small SOHO network. I want to use a Samba server. I have got it working except I cannot get XP to write to the Samba server. I can read but not write. From the Samba server I can read and write the XP machines. I have set the Samba server up in user mode. I am at a loss of what to do now. Who can help me? Thanks Rod -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] Getting postscript code from windows
Hello: I have a machine running Fedora Core 2 with an HP Color LaserJet 2550L printer connected via a USB cable. Local printing from the fedora machine is just fine. It uses CUPS. I am trying to set this printer up using Samba, but I keep getting postscript code when I try to print from Windows. Here is my smb.conf file: [global] log file = /var/log/samba/%m.log load printers = yes idmap gid = 16777216-33554431 socket options = TCP_NODELAY SO_RCVBUF=8192 SO_SNDBUF=8192 encrypt passwords = yes winbind use default domain = no template shell = /bin/false dns proxy = no netbios name = dsl printing = cups server string = Samba Server idmap uid = 16777216-33554431 os level = 20 printcap name = /etc/printcap security = user max log size = 50 [HP] postscript = yes printer = HP printable = yes path = /var/spool/samba comment = HP Color LaserJet 2550L valid users = @samba I created an account for myself in the samba group on the server. I went to my windows machine (running XP Pro). I added a network printer with the address \\192.168.1.1\HP and it seemed to go fine. When it asked for the driver, I pointed it to the HP 2550 postscript drivers I downloaded from HP's site. Any ideas why this is not working? Thanks, Neil -- Neil Aggarwal, JAMM Consulting, (972)612-6056, www.JAMMConsulting.com FREE! Valuable info on how your business can reduce operating costs by 17% or more in 6 months or less! http://newsletter.JAMMConsulting.com -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] Modifying Domain field of pdbedit dump
I have Debian server with NetBios name SERVER and domain NEOVISION. The created user accounts in the tdbsam backed shows (when listed by pdbedit -Lv) that the domain is SERVER, not NEOVISION. Newly added users however, has domain specified correctly as NEOVISION. I have a suspection that it is because the installation script which created the accounts based on old smbpasswd file was using unfinished smb.conf file (the SERVER was not yet set as PDC). 1) How to change the listed domain of the existing user/machine? 2) What is the role of the Domain field in pdbedit dump? Thanks for help Radek Svoboda Neovision s.r.o., Prague [EMAIL PROTECTED] http://www.neovision.cz -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Samba SOHO
Rod Ladwig wrote: What is the best way to setup a Samba server as a file server in a small SOHO. I have to connect 2 windows XP machine and one XP home notebook to a small SOHO network. I want to use a Samba server. I have got it working except I cannot get XP to write to the Samba server. I can read but not write. From the Samba server I can read and write the XP machines. I have set the Samba server up in user mode. I am at a loss of what to do now. Who can help me? Hey Rod, Perhaps you have user accounts that don't have permission to write in the folders in question. Check their owners and permissions, and also ensure read only = no in the smb.conf ;) Without a touch more info, it would be hard to know exactly. Good luck! Henry Baxter -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] 'point-and-print' general questions
I have gotten 'point-and-print' working, but there are a couple small issues/questions I am trying to get my grasp around: - rpcclient print-1201 -U root%secret -c 'enumdrivers' this lists the drivers twice (I saw one other post about this, without any followup) - When adding drivers via the Windows APW, after uploading the drivers and the APW closing - are you supposed to CANCEL out of the printers property window? If not, the printer on the server get renamed with how the driver wants to name it - When the above happens, I have only found the ability to delete the printer from windows, I have'n't found a rpcclient (or similar) to delete the printer (ie addprinter opposite) - Lastly, what happens _if_ two separate print drivers have a same file name? Everything gets tucked into the same directory?? Thank You - Chris -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] Re: 'point-and-print' general questions
On Sun, 5 Sep 2004 15:07:59 -0500, Chris McKeever [EMAIL PROTECTED] wrote: I have gotten 'point-and-print' working, but there are a couple small issues/questions I am trying to get my grasp around: - rpcclient print-1201 -U root%secret -c 'enumdrivers' this lists the drivers twice (I saw one other post about this, without any followup) - When adding drivers via the Windows APW, after uploading the drivers and the APW closing - are you supposed to CANCEL out of the printers property window? If not, the printer on the server get renamed with how the driver wants to name it I have figured out that if you dont apply, only the drivers are uploadined, but they are not associated with the printer - however, when I do hit OK or apply - the printer property window hangs (it does however do the association) - but it also changes the name of the printer to that of the driver in both enumprinters and \\sambaserver\printers -- but not as what it is shared as in \\sambaserver\original-sharename Is this hanging window preventable? - When the above happens, I have only found the ability to delete the printer from windows, I have'n't found a rpcclient (or similar) to delete the printer (ie addprinter opposite) - Lastly, what happens _if_ two separate print drivers have a same file name? Everything gets tucked into the same directory?? Thank You - Chris -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] Upgrade 3.0.5 to 3.0.6 causes client hang on file access
Hi, Chris Mills opened already a very similar thread: http://lists.samba.org/archive/samba/2004-September/091704.html The reason why I open a new thread is, because it happened at upgrading from 3.0.5 to 3.0.6. For the time being I downgraded to keep the system working but I have to find another solution soon ... It happend to me at two computer, both using Debian, one 2.4.18 the other 2.4.20 (this one self compiled). It's working with 3.0.5-1 and errors with 3.0.6-3. Error description: At the client (WinXP) I can browse but as soon as I want to access a file, the explorer hangs. I would really appreciate your help. Thanks Florian. /var/log/samba/log.smbd -- ... [2004/09/05 20:14:42, 0] lib/util_sock.c:read_socket_data(384) read_socket_data: recv failure for 4. Error = Connection reset by peer [2004/09/05 20:14:42, 1] smbd/service.c:close_cnum(837) lapio (192.168.4.241) closed connection to service heike ... --- smb.conf --- [global] workgroup = ARBEITSGRUPPE interfaces = 192.168.4.1/255.255.255.0 guest account = nobody keepalive = 30 os level = 2 security = user debug level = 1 # log file = /var/log/smb.log encrypt passwords = true smb passwd file = /etc/samba/smbpasswd socket options = TCP_NODELAY # oplocks = yes write raw = yes read raw = yes # printing = bsd printing = LPRNG printcap name = /etc/printcap load printers = yes allow hosts = 192.168.4. # print command = lpr -h -l -P %p -r %s # log level = 3 [homes] writeable = Yes create mask = 0666 browseable = yes [printers] comment = All Printers # path = /var/tmp path = /var/spool/samba browseable = no printable = yes # public = no read only = yes create mask = 0777 -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Upgrade 3.0.5 to 3.0.6 causes client hang on file access
On Sun, Sep 05, 2004 at 11:36:25PM +0200, Florian Sukup wrote: Hi, Chris Mills opened already a very similar thread: http://lists.samba.org/archive/samba/2004-September/091704.html The reason why I open a new thread is, because it happened at upgrading from 3.0.5 to 3.0.6. For the time being I downgraded to keep the system working but I have to find another solution soon ... It happend to me at two computer, both using Debian, one 2.4.18 the other 2.4.20 (this one self compiled). It's working with 3.0.5-1 and errors with 3.0.6-3. Error description: At the client (WinXP) I can browse but as soon as I want to access a file, the explorer hangs. I would really appreciate your help. Try setting use sendfile = no in your smb.conf. Might be a bug in Kernel 2.4.x sendfile. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] [HELP!!!]: Fail to mount with NULL password in samba 3.0.6
Can anybody answer me?! Thanks in advance!!! I have patch 3.0.6 with all patchs in http://samba.org/~jerry/patches/post-3.0.6/ , and set null passwords = yes in smb.conf. It works well to mount samba share in linux box when user alpha have non-empty password. But when set alpha's passwork as NULL, I get the follow messages: # mount -t smbfs -o username=alpha,password= //192.168.3.101/pub /mnt Anonymous login successful 24968: tree connect failed: ERRDOS - ERRnoaccess SMB connection failed And what samba log say: [2004/08/24 16:30:08, 2] auth/auth.c:check_ntlm_password(312) check_ntlm_password: Authentication for user [alpha] - [alpha] FAILED with error NT_STATUS_WRONG_PASSWORD Best Regards! Jacky Kim . -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] A few odd problems after server migration
Hey guys... I've been beating my brains out trying to determine the cause of this problem, read tons of stuff online but have not been able to make any headway. My RH9 server bit the dust and I had to completely rebuild it. Built it as a Fedora Core 2 server running Samba version 3.0.3-5 and re-imported my old smb.conf file, smbpasswd file and such. Re-created my share and gave it 777 permissions (root is the owner). I can log in to the server from my XP workstation and my share appears to work, however, as soon as I try to do certain things I have problems. For example, when I try to run the MS utility Robocopy to synchronize the contents of my Samba share to the external hard drive on my workstation I get an error from Robocopy complaining Accessing the source directory (my Samba share) is denied... there is also a precurser message claiming; 2004/09/05 21:27:13 ERROR 5 (0x0005) Getting File System Type of Source q:\ Access is denied. Is there any way to turn on a debug or log level to figure out what is causing this request to fail? The only messages I see that indicate problems are a message in nmbd.log [2004/09/05 21:29:28, 0] nmbd/nmbd_browsesync.c:find_domain_master_name_query_fail(350) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name SHADOW1b for the workgroup SHADOW. Unable to sync browse lists in this workgroup. and I am getting a nightly email to rootwith the following error messages; **Unmatched Entries** nmbd/nmbd_browsesync.c:find_domain_master_name_query_fail(350) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name SHADOW1b for the workgroup SHADOW. Unable to sync browse lists in this workgroup. : 96 Time(s) Here's the output of my smb.conf file; #=== Global Settings = [global] # workgroup = NT-Domain-Name or Workgroup-Name workgroup = shadow netbios name = Jabberwocky # server string is the equivalent of the NT Description field server string = Jason's Server # This option is important for security. It allows you to restrict # connections to machines which are on your local network. The # following example restricts access to two C class networks and # the loopback interface. For more examples of the syntax see # the smb.conf man page ; hosts allow = 192.168.1. 192.168.2. 127. # if you want to automatically load your printer list rather # than setting them up individually then you'll need this ; printcap name = /etc/printcap ; load printers = yes # It should not be necessary to spell out the print system type unless # yours is non-standard. Currently supported print systems include: # bsd, sysv, plp, lprng, aix, hpux, qnx ; printing = bsd # Uncomment this if you want a guest account, you must add this to /etc/passwd # otherwise the user nobody is used ; guest account = pcguest # this tells Samba to use a separate log file for each machine # that connects log file = /var/log/samba/%m.log # all log information in one file # log file = /var/log/samba/smbd.log # Put a capping on the size of the log files (in Kb). max log size = 500 # Security mode. Most people will want user level security. See # security_level.txt for details. # Use password server option only with security = server ; password server = NT-Server-Name # Password Level allows matching of _n_ characters of the password for # all combinations of upper and lower case. ; password level = 8 ; username level = 8 # You may wish to use password encryption. Please read # ENCRYPTION.txt, Win95.txt and WinNT.txt in the Samba documentation. # Do not enable this option unless you have read those documents ; encrypt passwords = yes ; smb passwd file = /etc/samba/smbpasswd # The following are needed to allow password changing from Windows to # update the Linux system password also. # NOTE: Use these with 'encrypt passwords' and 'smb passwd file' above. # NOTE2: You do NOT need these to allow workstations to change only #the encrypted SMB passwords. They allow the Unix password #to be kept in sync with the SMB password. ; unix password sync = Yes ; passwd program = /usr/bin/passwd %u ; passwd chat = *New*UNIX*password* %n\n *ReType*new*UNIX*password* %n\n *passwd:*all*authentication*tokens*updated*successfully* # Unix users can map to different SMB User names ; username map = /etc/samba/smbusers # Using the following line enables you to customise your configuration # on a per machine basis. The %m gets replaced with the netbios name # of the machine that is connecting ; include = /etc/samba/smb.conf.%m # Most people will find that this option gives better performance. # See speed.txt and the manual pages for details socket options = TCP_NODELAY SO_RCVBUF=8192 SO_SNDBUF=8192 # Configure Samba to use multiple interfaces # If you have multiple network interfaces then you must list them # here. See the
Re: [Samba] Upgrade 3.0.5 to 3.0.6 causes client hang on file access
On Mon, 2004-09-06 at 09:43, Jeremy Allison wrote: On Sun, Sep 05, 2004 at 11:36:25PM +0200, Florian Sukup wrote: Hi, Chris Mills opened already a very similar thread: http://lists.samba.org/archive/samba/2004-September/091704.html Try setting use sendfile = no in your smb.conf. Might be a bug in Kernel 2.4.x sendfile. It appears from bugs on the debian BTS that this is the case. The kernel 2.4.20 in particular has been mentioned. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Authentication Developer, Samba Teamhttp://samba.org Student Network Administrator, Hawker College [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] [Fwd: Bug#267766: samba: incredible slow reads - may be a sendfile problem?]
Forwarding this to the main samba list, as this is coming up there. -Forwarded Message- From: Steve Langasek [EMAIL PROTECTED] To: Joern Heusipp [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: Bug#267766: samba: incredible slow reads - may be a sendfile problem? Date: Fri, 03 Sep 2004 16:28:41 -0700 severity 267766 important thanks I am downgrading this bug because so far it seems to have only been reported with 2.4.20 kernels, which are not supported in either sarge *or* woody. The kernels provided in woody are 2.4.18+security fixes, and the kernels shipped with sarge will be either 2.4.26 or 2.4.27. Using 2.4.20 is strongly discouraged regardless of samba's behavior, as this kernel contains various known security bugs. What are your reasons for not being able to upgrade the kernel on the affected machine, if I may ask? I don't think that working around buggy sendfile implementations in kernels not shipping with sarge should be release-critical for sarge, in any case; kernels are a rather special case of allows partial upgrades, because it can't be addressed with versioned dependencies. -- Andrew Bartlett [EMAIL PROTECTED] Authentication Developer, Samba Teamhttp://samba.org Student Network Administrator, Hawker College [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
[Samba] Re: A few odd problems after server migration
nevermind folks, I got it figured out. I found out about the bug in the version of Samba I was running... updating it to 3.0.6 fixed it. Additionally I modified some master browser information that seems to have corrected the complaint I was getting in the nmbd.log file. Thanks anyhow, everyone back to their labor day weekends. :) On Sun, 5 Sep 2004 21:43:54 -0600, Jason Page [EMAIL PROTECTED] wrote: Hey guys... I've been beating my brains out trying to determine the cause of this problem, read tons of stuff online but have not been able to make any headway. My RH9 server bit the dust and I had to completely rebuild it. Built it as a Fedora Core 2 server running Samba version 3.0.3-5 and re-imported my old smb.conf file, smbpasswd file and such. Re-created my share and gave it 777 permissions (root is the owner). I can log in to the server from my XP workstation and my share appears to work, however, as soon as I try to do certain things I have problems. For example, when I try to run the MS utility Robocopy to synchronize the contents of my Samba share to the external hard drive on my workstation I get an error from Robocopy complaining Accessing the source directory (my Samba share) is denied... there is also a precurser message claiming; 2004/09/05 21:27:13 ERROR 5 (0x0005) Getting File System Type of Source q:\ Access is denied. Is there any way to turn on a debug or log level to figure out what is causing this request to fail? The only messages I see that indicate problems are a message in nmbd.log [2004/09/05 21:29:28, 0] nmbd/nmbd_browsesync.c:find_domain_master_name_query_fail(350) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name SHADOW1b for the workgroup SHADOW. Unable to sync browse lists in this workgroup. and I am getting a nightly email to rootwith the following error messages; **Unmatched Entries** nmbd/nmbd_browsesync.c:find_domain_master_name_query_fail(350) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name SHADOW1b for the workgroup SHADOW. Unable to sync browse lists in this workgroup. : 96 Time(s) Here's the output of my smb.conf file; #=== Global Settings = [global] # workgroup = NT-Domain-Name or Workgroup-Name workgroup = shadow netbios name = Jabberwocky # server string is the equivalent of the NT Description field server string = Jason's Server # This option is important for security. It allows you to restrict # connections to machines which are on your local network. The # following example restricts access to two C class networks and # the loopback interface. For more examples of the syntax see # the smb.conf man page ; hosts allow = 192.168.1. 192.168.2. 127. # if you want to automatically load your printer list rather # than setting them up individually then you'll need this ; printcap name = /etc/printcap ; load printers = yes # It should not be necessary to spell out the print system type unless # yours is non-standard. Currently supported print systems include: # bsd, sysv, plp, lprng, aix, hpux, qnx ; printing = bsd # Uncomment this if you want a guest account, you must add this to /etc/passwd # otherwise the user nobody is used ; guest account = pcguest # this tells Samba to use a separate log file for each machine # that connects log file = /var/log/samba/%m.log # all log information in one file # log file = /var/log/samba/smbd.log # Put a capping on the size of the log files (in Kb). max log size = 500 # Security mode. Most people will want user level security. See # security_level.txt for details. # Use password server option only with security = server ; password server = NT-Server-Name # Password Level allows matching of _n_ characters of the password for # all combinations of upper and lower case. ; password level = 8 ; username level = 8 # You may wish to use password encryption. Please read # ENCRYPTION.txt, Win95.txt and WinNT.txt in the Samba documentation. # Do not enable this option unless you have read those documents ; encrypt passwords = yes ; smb passwd file = /etc/samba/smbpasswd # The following are needed to allow password changing from Windows to # update the Linux system password also. # NOTE: Use these with 'encrypt passwords' and 'smb passwd file' above. # NOTE2: You do NOT need these to allow workstations to change only #the encrypted SMB passwords. They allow the Unix password #to be kept in sync with the SMB password. ; unix password sync = Yes ; passwd program = /usr/bin/passwd %u ; passwd chat = *New*UNIX*password* %n\n *ReType*new*UNIX*password* %n\n *passwd:*all*authentication*tokens*updated*successfully* # Unix users can map to different SMB User names ; username map = /etc/samba/smbusers # Using
[Samba] netbios aliases ?
hi all I have a samba server acting as a domain member server providing file/print services to our SME As i want to provide users with a list of available printers for installation, i need to give them a win32 shortcut to \\samba-server\ so they can see the available printers and install as required BUT... doing so will also show them all of the available shares... not a major issue but would rather just list the printers (i am using browseable = no to hide all shares) but am now running into another problem. I'm using a web interface to smbclient to allow staff to access the file server from home. Making all shares inviable effectively makes the use of the web smbclient pointless Is it possible to use a netbiios alias and force the printers to list under the alias ? Any other suggestion welcome -- To unsubscribe from this list go to the following URL and read the instructions: http://lists.samba.org/mailman/listinfo/samba
svn commit: lorikeet r42 - in trunk/heimdal: . admin appl appl/afsutil appl/dceutils appl/ftp appl/ftp/common appl/ftp/ftp appl/ftp/ftpd appl/kf appl/kx appl/login appl/otp appl/popper appl/push appl/rcp appl/rsh appl/su appl/telnet appl/telnet/libtelnet appl/telnet/telnet appl/telnet/telnetd appl/test appl/xnlock cf doc doc/standardisation include include/kadm5 kadmin kdc kpasswd kuser lib lib/45 lib/asn1 lib/auth lib/auth/afskauthlib lib/auth/pam lib/auth/sia lib/com_err lib/des lib/editline lib/gssapi lib/hdb lib/kadm5 lib/kafs lib/kdfs lib/krb5 lib/otp lib/roken lib/sl lib/vers tools
Author: abartlet Date: 2004-09-05 10:26:25 + (Sun, 05 Sep 2004) New Revision: 42 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=lorikeetpath=/trunk/heimdalrev=42nolog=1 Log: Update Heimdal to snapshot 20040905. Remove most autogenerated files from subversion (need to add ignore stuff, when I figure out how it works). Next step is allowing the unicodePwd to work. Andrew Bartlett Added: trunk/heimdal/doc/standardisation/draft-ietf-cat-kerberos-pk-init-20.txt trunk/heimdal/doc/standardisation/draft-ietf-krb-wg-kerberos-referrals-04.txt trunk/heimdal/doc/standardisation/draft-ietf-krb-wg-kerberos-set-passwd-02.txt trunk/heimdal/doc/standardisation/draft-ietf-krb-wg-ocsp-for-pkinit-00.txt trunk/heimdal/doc/standardisation/draft-ietf-krb-wg-preauth-framework-01.txt trunk/heimdal/doc/standardisation/draft-raeburn-krb-rijndael-krb-07.txt trunk/heimdal/lib/krb5/acache.c trunk/heimdal/lib/krb5/krb5_eai_to_heim_errno.3 trunk/heimdal/lib/krb5/krb5_eai_to_heim_errno.cat3 trunk/heimdal/lib/krb5/krb5_get_credentials.3 trunk/heimdal/lib/krb5/krb5_get_credentials.cat3 trunk/heimdal/lib/krb5/krb5_get_forwarded_creds.3 trunk/heimdal/lib/krb5/krb5_get_forwarded_creds.cat3 trunk/heimdal/lib/krb5/krb5_getportbyname.3 trunk/heimdal/lib/krb5/krb5_getportbyname.cat3 trunk/heimdal/lib/krb5/krb5_rd_error.3 trunk/heimdal/lib/krb5/krb5_rd_error.cat3 Removed: trunk/heimdal/Makefile.in trunk/heimdal/admin/Makefile.in trunk/heimdal/appl/Makefile.in trunk/heimdal/appl/afsutil/Makefile.in trunk/heimdal/appl/dceutils/Makefile.in trunk/heimdal/appl/ftp/Makefile.in trunk/heimdal/appl/ftp/common/Makefile.in trunk/heimdal/appl/ftp/ftp/Makefile.in trunk/heimdal/appl/ftp/ftpd/Makefile.in trunk/heimdal/appl/kf/Makefile.in trunk/heimdal/appl/kx/Makefile.in trunk/heimdal/appl/login/Makefile.in trunk/heimdal/appl/otp/Makefile.in trunk/heimdal/appl/popper/Makefile.in trunk/heimdal/appl/push/Makefile.in trunk/heimdal/appl/rcp/Makefile.in trunk/heimdal/appl/rsh/Makefile.in trunk/heimdal/appl/su/Makefile.in trunk/heimdal/appl/telnet/Makefile.in trunk/heimdal/appl/telnet/libtelnet/Makefile.in trunk/heimdal/appl/telnet/telnet/Makefile.in trunk/heimdal/appl/telnet/telnetd/Makefile.in trunk/heimdal/appl/test/Makefile.in trunk/heimdal/appl/xnlock/Makefile.in trunk/heimdal/cf/check-declaration.m4 trunk/heimdal/configure trunk/heimdal/doc/Makefile.in trunk/heimdal/include/Makefile.in trunk/heimdal/include/config.h.in trunk/heimdal/include/kadm5/Makefile.in trunk/heimdal/kadmin/Makefile.in trunk/heimdal/kdc/Makefile.in trunk/heimdal/kpasswd/Makefile.in trunk/heimdal/kuser/Makefile.in trunk/heimdal/lib/45/Makefile.in trunk/heimdal/lib/Makefile.in trunk/heimdal/lib/asn1/Makefile.in trunk/heimdal/lib/auth/Makefile.in trunk/heimdal/lib/auth/afskauthlib/Makefile.in trunk/heimdal/lib/auth/pam/Makefile.in trunk/heimdal/lib/auth/sia/Makefile.in trunk/heimdal/lib/com_err/Makefile.in trunk/heimdal/lib/des/Makefile.in trunk/heimdal/lib/editline/Makefile.in trunk/heimdal/lib/gssapi/Makefile.in trunk/heimdal/lib/hdb/Makefile.in trunk/heimdal/lib/kadm5/Makefile.in trunk/heimdal/lib/kafs/Makefile.in trunk/heimdal/lib/kdfs/Makefile.in trunk/heimdal/lib/krb5/Makefile.in trunk/heimdal/lib/otp/Makefile.in trunk/heimdal/lib/roken/Makefile.in trunk/heimdal/lib/sl/Makefile.in trunk/heimdal/lib/vers/Makefile.in trunk/heimdal/tools/Makefile.in Modified: trunk/heimdal/ChangeLog trunk/heimdal/aclocal.m4 trunk/heimdal/admin/Makefile.am trunk/heimdal/appl/afsutil/ChangeLog trunk/heimdal/appl/afsutil/Makefile.am trunk/heimdal/appl/afsutil/afslog.c trunk/heimdal/appl/afsutil/pagsh.c trunk/heimdal/appl/ftp/ChangeLog trunk/heimdal/appl/ftp/common/Makefile.am trunk/heimdal/appl/ftp/ftp/Makefile.am trunk/heimdal/appl/ftp/ftp/ftp.c trunk/heimdal/appl/ftp/ftp/main.c trunk/heimdal/appl/ftp/ftpd/Makefile.am trunk/heimdal/appl/ftp/ftpd/extern.h trunk/heimdal/appl/ftp/ftpd/ftpcmd.y trunk/heimdal/appl/ftp/ftpd/ftpd.8 trunk/heimdal/appl/ftp/ftpd/ftpd.c trunk/heimdal/appl/ftp/ftpd/ftpd.cat8 trunk/heimdal/appl/ftp/ftpd/ftpd_locl.h trunk/heimdal/appl/kx/Makefile.am trunk/heimdal/appl/login/Makefile.am trunk/heimdal/appl/login/login_protos.h trunk/heimdal/appl/otp/Makefile.am trunk/heimdal/appl/popper/ChangeLog trunk/heimdal/appl/popper/Makefile.am trunk/heimdal/appl/popper/popper.c trunk/heimdal/appl/push/Makefile.am trunk/heimdal/appl/rcp/Makefile.am trunk/heimdal/appl/rsh/Makefile.am trunk/heimdal/appl/su/Makefile.am trunk/heimdal/appl/telnet/libtelnet/Makefile.am trunk/heimdal/appl/telnet/telnet/Makefile.am trunk/heimdal/appl/telnet/telnet/telnet.c trunk/heimdal/appl/telnet/telnetd/Makefile.am trunk/heimdal/appl/telnet/telnetd/sys_term.c trunk/heimdal/appl/xnlock
svn commit: samba-docs r213 - in trunk: . Samba-Guide/images Samba-HOWTO-Collection/images scripts
Author: jelmer Date: 2004-09-05 12:36:21 + (Sun, 05 Sep 2004) New Revision: 213 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba-docspath=/trunkrev=213nolog=1 Log: Use dia to generate png images out of dia files Added: trunk/Samba-HOWTO-Collection/images/browsing1.dia Removed: trunk/Samba-Guide/images/AccountingNetwork.png trunk/Samba-Guide/images/Charity-Network.png trunk/Samba-Guide/images/UNIX-Samba-and-LDAP.png trunk/Samba-Guide/images/acct2net.png trunk/Samba-Guide/images/ch7-dual-additive-LDAP-Ok.png trunk/Samba-Guide/images/ch7-dual-additive-LDAP.png trunk/Samba-Guide/images/ch7-fail-overLDAP.png trunk/Samba-Guide/images/ch7-singleLDAP.png trunk/Samba-Guide/images/ch8-migration.png trunk/Samba-Guide/images/chap4-net.png trunk/Samba-Guide/images/chap5-net.png trunk/Samba-Guide/images/chap6-net.png trunk/Samba-Guide/images/chap7-idresol.png trunk/Samba-Guide/images/chap7-net-A.png trunk/Samba-Guide/images/chap7-net.png trunk/Samba-Guide/images/chap7-net2-B.png trunk/Samba-Guide/images/chap7-net2.png trunk/Samba-Guide/images/chap9-ADSDC.png trunk/Samba-Guide/images/chap9-SambaDC.png trunk/Samba-HOWTO-Collection/images/access1.png trunk/Samba-HOWTO-Collection/images/browsing1 trunk/Samba-HOWTO-Collection/images/browsing1.png trunk/Samba-HOWTO-Collection/images/cups1.png trunk/Samba-HOWTO-Collection/images/cups2.png trunk/Samba-HOWTO-Collection/images/domain.png trunk/Samba-HOWTO-Collection/images/idmap-gid2sid.png trunk/Samba-HOWTO-Collection/images/idmap-groups.png trunk/Samba-HOWTO-Collection/images/idmap-sid2gid.png trunk/Samba-HOWTO-Collection/images/idmap-sid2uid.png trunk/Samba-HOWTO-Collection/images/idmap-store-gid2sid.png trunk/Samba-HOWTO-Collection/images/idmap-uid2sid.png trunk/Samba-HOWTO-Collection/images/idmap.png trunk/Samba-HOWTO-Collection/images/pdftoepsonusb.png trunk/Samba-HOWTO-Collection/images/pdftosocket.png trunk/Samba-HOWTO-Collection/images/trusts1.png Modified: trunk/Makefile.in trunk/configure.in trunk/scripts/copy-images.sh Changeset: Modified: trunk/Makefile.in === --- trunk/Makefile.in 2004-09-04 14:47:12 UTC (rev 212) +++ trunk/Makefile.in 2004-09-05 12:36:21 UTC (rev 213) @@ -12,6 +12,7 @@ PNGTOPNM = @PNGTOPNM@ EPSTOPNM = @EPSTOPNM@ PNMTOPNG = @PNMTOPNG@ +DIA = @DIA@ PNMTOPS = @PNMTOPS@ HTML2TEXT = @HTML2TEXT@ PLUCKERBUILD = @PLUCKERBUILD@ @@ -166,6 +167,7 @@ # Adobe PDF files %.pdf: %.tex %.ind latexfigures + $(MAKE) $(shell $(XSLTPROC) --stringparam prepend --stringparam append .png --stringparam role latex xslt/find-image-dependencies.xsl $(DOCBOOKDIR)/$*.xml) -$(PDFLATEX) $ $(THUMBPDF) $*.pdf -$(PDFLATEX) $ @@ -178,10 +180,10 @@ %.dvi: %.tex %.idx $(MAKE) $(shell $(XSLTPROC) --stringparam prepend --stringparam append .eps --stringparam role latex xslt/find-image-dependencies.xsl $(DOCBOOKDIR)/$*.xml) -$(LATEX) $ - -$(LATEX) $ - $(MAKEINDEX) $*.idx - -$(LATEX) $ +%.png: %.dia + $(DIA) -e $@ $ + %.eps: %.png $(PNGTOPNM) $ | $(PNMTOPS) $@ Deleted: trunk/Samba-Guide/images/AccountingNetwork.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/Charity-Network.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/UNIX-Samba-and-LDAP.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/acct2net.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/ch7-dual-additive-LDAP-Ok.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/ch7-dual-additive-LDAP.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/ch7-fail-overLDAP.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/ch7-singleLDAP.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/ch8-migration.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/chap4-net.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/chap5-net.png === (Binary files differ) Deleted: trunk/Samba-Guide/images/chap6-net.png === (Binary files differ) Deleted:
svn commit: lorikeet r43 - in trunk/heimdal/lib: hdb kadm5
Author: abartlet Date: 2004-09-05 13:09:03 + (Sun, 05 Sep 2004) New Revision: 43 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=lorikeetpath=/trunk/heimdal/librev=43nolog=1 Log: We now have unicodePwd working for the lorikeet-heimdal intergration. This makes it much easier to setup, as we don't need to worry about the NT hash, we can just ldbedit and put in an ascii password... (now to see what lha thinks of my chainsaw effort ;-) Andrew Bartlett Added: trunk/heimdal/lib/hdb/keys.c Modified: trunk/heimdal/lib/hdb/Makefile.am trunk/heimdal/lib/hdb/hdb-ldb.c trunk/heimdal/lib/hdb/hdb-protos.h trunk/heimdal/lib/kadm5/keys.c trunk/heimdal/lib/kadm5/set_keys.c Changeset: Sorry, the patch is too large (834 lines) to include; please use WebSVN to see it! WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=lorikeetpath=/trunk/heimdal/librev=43nolog=1
svn commit: samba-docs r214 - in trunk: .
Author: jelmer Date: 2004-09-05 13:26:10 + (Sun, 05 Sep 2004) New Revision: 214 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba-docspath=/trunkrev=214nolog=1 Log: Complain when when dia version is 0.93 and $DISPLAY is not set Modified: trunk/configure.in Changeset: Modified: trunk/configure.in === --- trunk/configure.in 2004-09-05 12:36:21 UTC (rev 213) +++ trunk/configure.in 2004-09-05 13:26:10 UTC (rev 214) @@ -41,6 +41,20 @@ DOCS_TARGET_REQUIRE_PROGRAM(XSLTPROC, xsltproc, ALL) DOCS_TARGET_REQUIRE_PROGRAM(RM, rm, ALL) DOCS_TARGET_REQUIRE_PROGRAM(DIA, dia, ALL) + +# Check dia version number +[ DIA_VERSION=`dia -v | egrep -o '([0-9]+)\.([0-9]+)'`] +DIA_MAJ_VERSION=`echo $DIA_VERSION | cut -d . -f 1` +DIA_MIN_VERSION=`echo $DIA_VERSION | cut -d . -f 2` + +if test $DIA_MAJ_VERSION -le 0 +then + if test $DIA_MIN_VERSION -le 92 test -z $DISPLAY + then + AC_MSG_ERROR([Dia below 0.93 requires an X environment. Set \$DISPLAY or install Dia 0.93 or higher]) + fi +fi + DOCS_TARGET_REQUIRE_PROGRAM(MAKEINDEX, makeindex, LATEX) DOCS_TARGET_REQUIRE_PROGRAM(PDFLATEX, pdflatex, PDF) DOCS_TARGET_REQUIRE_PROGRAM(EPSTOPDF, epstopdf, PDF)
svn commit: samba-docs r215 - in trunk: Samba-HOWTO-Collection xslt
Author: jelmer Date: 2004-09-05 14:46:49 + (Sun, 05 Sep 2004) New Revision: 215 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba-docspath=/trunkrev=215nolog=1 Log: Better conformance to DocBook standards Modified: trunk/Samba-HOWTO-Collection/Compiling.xml trunk/Samba-HOWTO-Collection/DomainMember.xml trunk/Samba-HOWTO-Collection/NetworkBrowsing.xml trunk/Samba-HOWTO-Collection/PDC.xml trunk/Samba-HOWTO-Collection/Passdb.xml trunk/Samba-HOWTO-Collection/PolicyMgmt.xml trunk/Samba-HOWTO-Collection/ServerType.xml trunk/xslt/generate-attributions.xsl Changeset: Sorry, the patch is too large (288 lines) to include; please use WebSVN to see it! WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba-docspath=/trunkrev=215nolog=1
svn commit: samba-docs r216 - in trunk: Samba-HOWTO-Collection xslt
Author: jelmer Date: 2004-09-05 16:14:06 + (Sun, 05 Sep 2004) New Revision: 216 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba-docspath=/trunkrev=216nolog=1 Log: - Respect the scale= attribute. - Better conformance to the DocBook specs Modified: trunk/Samba-HOWTO-Collection/CUPS-printing.xml trunk/Samba-HOWTO-Collection/NetworkBrowsing.xml trunk/Samba-HOWTO-Collection/Passdb.xml trunk/Samba-HOWTO-Collection/upgrading-to-3.0.xml trunk/xslt/expand-sambadoc.xsl Changeset: Modified: trunk/Samba-HOWTO-Collection/CUPS-printing.xml === --- trunk/Samba-HOWTO-Collection/CUPS-printing.xml 2004-09-05 14:46:49 UTC (rev 215) +++ trunk/Samba-HOWTO-Collection/CUPS-printing.xml 2004-09-05 16:14:06 UTC (rev 216) @@ -1717,7 +1717,7 @@ titlePPDs shipped with CUPS/title tgroup cols=2 align=left colspec align=left/ - colspec align=justify width=1*/ + colspec align=justify colwidth=1*/ theadrowentryPPD file/entryentryPrinter type/entry/row/thead tbody rowentrydeskjet.ppd/entryentryolder HP inkjet printers and compatible/entry/row @@ -2585,9 +2585,9 @@ para itemizedlist - listitemcups.hlp/listitem - listitemcupsdrvr.dll/listitem - listitemcupsui.dll/listitem + listitemparacups.hlp/para/listitem + listitemparacupsdrvr.dll/para/listitem + listitemparacupsui.dll/para/listitem /itemizedlist /para @@ -2601,12 +2601,12 @@ para itemizedlist - listitemADFONTS.MFM/listitem - listitemADOBEPS4.DRV/listitem - listitemADOBEPS4.HLP/listitem - listitemDEFPRTR2.PPD/listitem - listitemICONLIB.DLL/listitem - listitemPSMON.DLL/listitem + listitemparaADFONTS.MFM/para/listitem + listitemparaADOBEPS4.DRV/para/listitem + listitemparaADOBEPS4.HLP/para/listitem + listitemparaDEFPRTR2.PPD/para/listitem + listitemparaICONLIB.DLL/para/listitem + listitemparaPSMON.DLL/para/listitem /itemizedlist /para @@ -2614,9 +2614,9 @@ para itemizedlist - listitemADOBEPS5.DLL/listitem - listitemADOBEPSU.DLL/listitem - listitemADOBEPSU.HLP/listitem + listitemparaADOBEPS5.DLL/para/listitem + listitemparaADOBEPSU.DLL/para/listitem + listitemparaADOBEPSU.HLP/para/listitem /itemizedlist /para Modified: trunk/Samba-HOWTO-Collection/NetworkBrowsing.xml === --- trunk/Samba-HOWTO-Collection/NetworkBrowsing.xml2004-09-05 14:46:49 UTC (rev 215) +++ trunk/Samba-HOWTO-Collection/NetworkBrowsing.xml2004-09-05 16:14:06 UTC (rev 216) @@ -1559,7 +1559,7 @@ tgroup cols=3 align=left colspec align=left/ colspec align=left/ - colspec align=justify width=1*/ + colspec align=justify colwidth=1*/ thead rowentrySubnet/entryentryBrowse Master/entryentryList/entry/row Modified: trunk/Samba-HOWTO-Collection/Passdb.xml === --- trunk/Samba-HOWTO-Collection/Passdb.xml 2004-09-05 14:46:49 UTC (rev 215) +++ trunk/Samba-HOWTO-Collection/Passdb.xml 2004-09-05 16:14:06 UTC (rev 216) @@ -1413,8 +1413,8 @@ table iframe=all id=ldappwsync titlePossible emphasisldap passwd sync/emphasis values/title tgroup cols=2 - colspec align=left width=1*/ - colspec align=justify width=4*/ + colspec align=left colwidth=1*/ + colspec align=justify colwidth=4*/ thead rowentry align=leftValue/entryentry align=centerDescription/entry/row /thead Modified: trunk/Samba-HOWTO-Collection/upgrading-to-3.0.xml === --- trunk/Samba-HOWTO-Collection/upgrading-to-3.0.xml 2004-09-05 14:46:49 UTC (rev 215) +++ trunk/Samba-HOWTO-Collection/upgrading-to-3.0.xml 2004-09-05 16:14:06 UTC (rev 216) @@ -332,7 +332,7 @@ table frame='all' id=tdbfiledesctitleTDB File Descriptions/title tgroup cols='3' colspec align=left/ - colspec align=justify width=1*/ + colspec align=justify colwidth=1*/ colspec align=left/ thead row Modified: trunk/xslt/expand-sambadoc.xsl === --- trunk/xslt/expand-sambadoc.xsl 2004-09-05 14:46:49 UTC (rev 215) +++ trunk/xslt/expand-sambadoc.xsl 2004-09-05 16:14:06 UTC (rev 216) @@ -249,6 +249,10 @@
svn commit: samba r2231 - in branches/SAMBA_3_0/source/lib: .
Author: paulg Date: 2004-09-06 00:24:28 + (Mon, 06 Sep 2004) New Revision: 2231 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=sambapath=/branches/SAMBA_3_0/source/librev=2231nolog=1 Log: Fix iconv.c to use the Samba-supplied uint8 type not the uint8_t type, which does not exist on all platforms. Modified: branches/SAMBA_3_0/source/lib/iconv.c Changeset: Modified: branches/SAMBA_3_0/source/lib/iconv.c === --- branches/SAMBA_3_0/source/lib/iconv.c 2004-09-05 04:05:45 UTC (rev 2230) +++ branches/SAMBA_3_0/source/lib/iconv.c 2004-09-06 00:24:28 UTC (rev 2231) @@ -541,8 +541,8 @@ char **outbuf, size_t *outbytesleft) { size_t in_left=*inbytesleft, out_left=*outbytesleft; - const uint8_t *c = (const uint8_t *)*inbuf; - uint8_t *uc = (uint8_t *)*outbuf; + const uint8 *c = (const uint8 *)*inbuf; + uint8 *uc = (uint8 *)*outbuf; while (in_left = 1 out_left = 2) { if ((c[0] 0x80) == 0) { @@ -658,8 +658,8 @@ char **outbuf, size_t *outbytesleft) { size_t in_left=*inbytesleft, out_left=*outbytesleft; - uint8_t *c = (uint8_t *)*outbuf; - const uint8_t *uc = (const uint8_t *)*inbuf; + uint8 *c = (uint8 *)*outbuf; + const uint8 *uc = (const uint8 *)*inbuf; while (in_left = 2 out_left = 1) { unsigned int codepoint;
svn commit: lorikeet r45 - in trunk/heimdal/lib/des: .
Author: abartlet Date: 2004-09-06 02:53:38 + (Mon, 06 Sep 2004) New Revision: 45 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=lorikeetpath=/trunk/heimdal/lib/desrev=45nolog=1 Log: Read /dev/urandom first, as this will not block and will always return bytes. Don't read /dev/mem - that idea just gives me the willies... Andrew Bartlett Modified: trunk/heimdal/lib/des/rnd_keys.c Changeset: Modified: trunk/heimdal/lib/des/rnd_keys.c === --- trunk/heimdal/lib/des/rnd_keys.c2004-09-06 02:45:23 UTC (rev 44) +++ trunk/heimdal/lib/des/rnd_keys.c2004-09-06 02:53:38 UTC (rev 45) @@ -249,10 +249,10 @@ RETSIGTYPE (*ochld)(int); pid_t pid; #endif -char *rnd_devices[] = {/dev/random, +char *rnd_devices[] = {/dev/urandom, /dev/srandom, - /dev/urandom, /dev/arandom, + /dev/random, NULL}; char **p; @@ -266,10 +266,6 @@ close(fd); } -/* Paranoia? Initialize data from /dev/mem if we can read it. */ -if (size = 8) - sumFile(/dev/mem, (1024*1024*2), data); - gdata = data; gsize = size; igdata = 0;
svn commit: lorikeet r46 - in trunk/heimdal/lib/krb5: .
Author: abartlet Date: 2004-09-06 02:55:06 + (Mon, 06 Sep 2004) New Revision: 46 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=lorikeetpath=/trunk/heimdal/lib/krb5rev=46nolog=1 Log: Adding uninitialised memory into the entorpy pool is a sure-fire way to get valgrind errors. (This didn't fix all of them - OpenSSL is still a problem - but it's a start). Andrew Bartlett Modified: trunk/heimdal/lib/krb5/crypto.c Changeset: Modified: trunk/heimdal/lib/krb5/crypto.c === --- trunk/heimdal/lib/krb5/crypto.c 2004-09-06 02:53:38 UTC (rev 45) +++ trunk/heimdal/lib/krb5/crypto.c 2004-09-06 02:55:06 UTC (rev 46) @@ -3724,6 +3724,7 @@ seed_something(void) { int fd = -1; +size_t bytes; char buf[1024], seedfile[256]; /* If there is a seed file, load it. But such a file cannot be trusted, @@ -3731,9 +3732,13 @@ if (RAND_file_name(seedfile, sizeof(seedfile))) { fd = open(seedfile, O_RDONLY); if (fd = 0) { - read(fd, buf, sizeof(buf)); - /* Use the full buffer anyway */ - RAND_add(buf, sizeof(buf), 0.0); + bytes = read(fd, buf, sizeof(buf)); + if (bytes 0) { + RAND_add(buf, bytes, 0.0); + } else { + seedfile[0] = '\0'; + } + close(fd); } else seedfile[0] = '\0'; } else
svn commit: lorikeet r47 - in trunk/heimdal: .
Author: abartlet Date: 2004-09-06 02:55:59 + (Mon, 06 Sep 2004) New Revision: 47 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=lorikeetpath=/trunk/heimdalrev=47nolog=1 Log: If we don't link with OpenSSL, we need to bring -ldl in ourselves. Andrew Bartlett Modified: trunk/heimdal/configure.in Changeset: Modified: trunk/heimdal/configure.in === --- trunk/heimdal/configure.in 2004-09-06 02:55:06 UTC (rev 46) +++ trunk/heimdal/configure.in 2004-09-06 02:55:59 UTC (rev 47) @@ -51,6 +51,9 @@ rk_WFLAGS(-Wall -Wmissing-prototypes -Wpointer-arith -Wbad-function-cast -Wmissing-declarations -Wnested-externs) +# we need dlopen +AC_SEARCH_LIBS(dlopen, [dl]) + rk_TEST_PACKAGE(openldap, [#include lber.h #include ldap.h],
svn commit: lorikeet r48 - in trunk/heimdal/lib/hdb: .
Author: abartlet Date: 2004-09-06 02:56:49 + (Mon, 06 Sep 2004) New Revision: 48 WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=lorikeetpath=/trunk/heimdal/lib/hdbrev=48nolog=1 Log: Fix valgrind errors by simply allocating the enctypes[] array. Andrew Bartlett Modified: trunk/heimdal/lib/hdb/keys.c Changeset: Modified: trunk/heimdal/lib/hdb/keys.c === --- trunk/heimdal/lib/hdb/keys.c2004-09-06 02:55:59 UTC (rev 47) +++ trunk/heimdal/lib/hdb/keys.c2004-09-06 02:56:49 UTC (rev 48) @@ -78,7 +78,6 @@ char buf[3][256]; int num_buf = 0; int i; -static krb5_enctype e; /* XXX */ krb5_error_code ret; /* the 3 DES types must be first */ @@ -112,18 +111,21 @@ /* XXX there should be a string_to_etypes handling special cases like `des' and `all' */ if(strcmp(buf[i], des) == 0) { - *enctypes = all_etypes; + *enctypes = malloc(sizeof(all_etypes[0])*3); + memcpy(*enctypes, all_etypes, sizeof(all_etypes[0])*3); *num_enctypes = 3; continue; } else if(strcmp(buf[i], des3) == 0) { - e = ETYPE_DES3_CBC_SHA1; - *enctypes = e; + *enctypes = malloc(sizeof(**enctypes)); + *enctypes[0] = ETYPE_DES3_CBC_SHA1; *num_enctypes = 1; continue; } else { + krb5_enctype e; ret = krb5_string_to_enctype(context, buf[i], e); if (ret == 0) { - *enctypes = e; + *enctypes = malloc(sizeof(**enctypes)); + *enctypes[0] = e; *num_enctypes = 1; continue; } @@ -137,13 +139,15 @@ interface sucks */ if(strcmp(buf[i], pw-salt) == 0) { if(*enctypes == NULL) { - *enctypes = all_etypes; + *enctypes = malloc(sizeof(all_etypes)); + memcpy(*enctypes, all_etypes, sizeof(all_etypes)); *num_enctypes = sizeof(all_etypes)/sizeof(all_etypes[0]); } salt-salttype = KRB5_PW_SALT; } else if(strcmp(buf[i], afs3-salt) == 0) { if(*enctypes == NULL) { - *enctypes = all_etypes; + *enctypes = malloc(sizeof(all_etypes[0])*3); + memcpy(*enctypes, all_etypes, sizeof(all_etypes[0])*3); *num_enctypes = 3; } salt-salttype = KRB5_AFS3_SALT; @@ -172,6 +176,7 @@ if(salt-saltvalue.data == NULL) { krb5_set_error_string(context, out of memory while parsing salt specifiers); + free(*enctypes); return ENOMEM; } strlwr(salt-saltvalue.data); @@ -313,10 +318,13 @@ if (j == *nkeyset) { ret = add_enctype_to_key_set(key_set, nkeyset, enctypes[i], no_salt ? NULL : salt); - if (ret) - goto out; + if (ret) { + free(enctypes); + goto out; + } } } + free(enctypes); } out: