[Samba] Password expired
I installed samba-3.0.28-0 I set maximum password age. pierluigim password has expired and so he would like to change it from XP prof client, but he receives this message: Lacking permission to change the password. The global configuration of my smb.conf is: --- [global] name resolve order = wins bcast hosts ldap ssl = No passwd chat = *New*Password* %n\n *Re-enter*new*password*%n\n*Password*changed* show add printer wizard = no time server = yes passwd program = /usr/bin/passwd %u printing = cups workgroup = DMN-MAGIM server signing = Auto os level = 35 printcap name = /etc/printcap add machine script = /usr/sbin/useradd -s /bin/false -d /var/lib/nobody'%u' delete user script = /usr/sbin/userdel -r '%u' max log size = 100 restrict anonymous = no smb ports = 139 add group script = /usr/sbin/groupadd '%g' delete group script = /usr/sbin/groupdel '%g' add user to group script = /usr/sbin/usermod -G '%g' '%u' logon drive = R: username map = /etc/samba/smbusers domain master = yes encrypt passwords = yes passdb backend = tdbsam wins support = Yes max protocol = NT path = /data unix password sync = yes acl compatibility = winnt logon path = add user script = /usr/sbin/useradd -m '%u' set primary group script = /usr/sbin/groupadd '%g' syslog = 0 preferred master = yes domain logons = yes pam password change = yes --- and in my log.smb file I have: -- [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_chauthtok(691) PAM: UNKNOWN PAM ERROR (19) for User: pierluigim [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_passchange(847) smb_pam_passchange: PAM: Password Change Failed for user pierluigim! [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_chauthtok(691) PAM: UNKNOWN PAM ERROR (19) for User: pierluigim [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_passchange(847) smb_pam_passchange: PAM: Password Change Failed for user pierluigim! [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_chauthtok(691) PAM: UNKNOWN PAM ERROR (19) for User: pierluigim [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_passchange(847) smb_pam_passchange: PAM: Password Change Failed for user pierluigim! [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_chauthtok(691) PAM: UNKNOWN PAM ERROR (19) for User: pierluigim [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_passchange(847) smb_pam_passchange: PAM: Password Change Failed for user pierluigim! -- Can you help me? Thanks Andrea -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Re: IDMAP RID problems and documentation
Plant, Dean [EMAIL PROTECTED] schreef in bericht news:[EMAIL PROTECTED] Charles Marcus wrote: Plant, Dean, on 12/19/2007 8:58 AM, said the following: John wrote: Hello List, After upgrading to 3.0.25b (Also tried 3.0.28) I tried to make use of the new syntax for IDMAP. But I failed, Also there is a lack on documentation how to us it. (Yes there is a man, but it contains limited explanation and examples). What do I want? What (I think a lot of people wants) I have two samba domain members and a Windows 2003 DC without R2 / SFU shema extension. So I want make use of the RID facility. Same GID/ UID mappings on all samba servers in the domain, with support of BUILTIN groups, and without installing schema extensions on the DC. I assume that RID was designed for this scenario Can anyone assist me and everyone on list struggling with the same problems, how to proper configure SAMBA for this scenario? Old syntax works, but lack support for BUILT-IN groups, and gives following complaints in syslog Module '/usr/lib/samba/idmap/rid.so' initialization failed: NT_STATUS_OBJECT_NAME_COLLISION and: lib/util_str.c:safe_strcpy_fn(659) Dec 19 13:12:47 s-0009 winbindd[5454]: ERROR: string overflow by 1 (256 - 255) in safe_strcpy [ERROR: string overflow by 1 (256 - 255) in safe_strcpy [Added timed event async_request_timeout: 8843878 I have just fixed one of our Samba servers this morning after an the upgrade from CentOS 5 - 5.1 broke winbind resolution. The below winbind config worked for me. I'm curious - what exactly CHANGED (or, what did you have to change)? We had been running with these idmap settings for an AD integrated file server. idmap uid = 16777216-33554431 idmap gid = 16777216-33554431 idmap backend = rid:US=16777216-33554431 After the upgrade to CentOS 5.1 our winbind mappings were lost and group permissions were no longer working. Reading the Samba release notes and trawling the net I found the below settings, although as it has been pointed out the idmap alloc config is not required. With these settings all winbind mappings were restored and everything seems to be working as normal. idmap domains = US idmap config US: default = yes idmap config US: backend = rid idmap config US: range = 16777216-33554431 idmap alloc config: range = 16777216-33554431 Dean Thank you for you're reply, but mentioned configuration breaks getent passwd in our setup. Getent group works, and wbinfo -u also works. Have anybody an idea what else can cause samba winbind on CentOS4.6 to fail? -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Vista performance (uggh)
Apparently, there is known issues with Vista copying files around the network and also on to CD's etc.. See http://www.theregister.co.uk/2007/03/26/vista_copying_bug/ Mark On Tue, Oct 30, 2007 at 09:37:46AM -0500, [EMAIL PROTECTED] wrote: On 10/26/2007 8:28 AM, Doug Tucker wrote: I didn't see anyone answer this. We noticed a tremendous slowdown of our samba server the minute we put our first Vista client on it due to IO. Turns out that by default, Vista has an indexing feature turned on that sits there and loops continually indexing every file it can find. So if you have mapped drives, and they have a lot of content...this user had about 2gb in their home directory, it just murdered our samba server. I'm no vista expert, but why you don't see a noticeable performance hit when it indexes the local drive of the pc, I have no idea, but when it was sitting on that mapped drive, it slowed the samba server down for everyone. We turned that feature off on the Vista machine, and the problem went away. This theory would apply if I was seeing lots of disk I/O even while the vista client wasn't actively transferring files. That isn't the case. I only see increased I/O during a file copy from the samba server to the vista client. Speaking of vista issues. You may want to considering disabling Offline Files which also keeps an eye of what files are new/changed on the fileshare and copies them locally. This kicks in automatically if you set any of your special folders (Documents and Pictures is what I had done) to be on the samba server rather than local). On Thu, 2007-10-18 at 09:57 -0500, [EMAIL PROTECTED] wrote: Issue: Vista reads slowly from a samba server. This appears to pop up periodically here and elsewhere. My samba.conf file has: [homes] ... vfs objects = readahead As suggested elsewhere. Writes are approximately 17-18MB/s which is acceptable. Reads are in the 8MB/s range which is appalingly slow. Using linux smbclient and windows XP clients I can read at 25+MB/s. I've enabled vfs objects = readahead to get better performance in vista. The biggest difference I notice between vista and other clients is that the %iowait is MUCH higher than with the other clients. Logs show the readahead module being loaded but I have no idea if it is actually doing anything. [2007/10/18 08:24:48, 2] lib/module.c:do_smb_load_module(64) Module '/usr/lib/samba/vfs/readahead.so' loaded Server Config: CPU: Amd Athlon 2600+ Ram: 1G Disk: software raid5 across 5 250G ide drives each on dedicated channels Kernel: Linux shakti 2.6.22 #1 SMP Wed Oct 17 15:32:01 CDT 2007 i686 GNU/Linux Distro: debian etch Network: Gigabit (though cheapo) Any suggestions on where to go from here? iostat 5 output for the physical devices below: Using a new quad core running Vista client on gigabit - Reads at 8MB/s avg-cpu: %user %nice %system %iowait %steal %idle 2.810.009.62 73.950.00 13.63 Device:tps Blk_read/s Blk_wrtn/s Blk_read Blk_wrtn hda 51.10 3033.2720.84 15136104 hde 53.91 3028.4616.03 15112 80 hdg 49.90 2993.1919.24 14936 96 hdi 47.49 3036.47 6.41 15152 32 hdk 49.30 2993.1914.43 14936 72 Using a midrange Laptop running Windows XP on gigabit - Reads at 20MB/s avg-cpu: %user %nice %system %iowait %steal %idle 3.800.00 23.80 14.200.00 58.20 Device:tps Blk_read/s Blk_wrtn/s Blk_read Blk_wrtn hda 199.80 8366.4025.60 41832128 hde 187.20 8380.80 8.00 41904 40 hdg 190.80 8377.60 9.60 41888 48 hdi 178.20 8376.0016.00 41880 80 hdk 188.80 8377.6020.80 41888104 Using same host, smbclient, writing to a firewire drive - Reads at 26MB/s avg-cpu: %user %nice %system %iowait %steal %idle 7.580.00 38.92 30.740.00 22.75 Device:tps Blk_read/s Blk_wrtn/s Blk_read Blk_wrtn hda 224.75 8693.0120.76 43552104 hde 214.37 8713.7712.77 43656 64 hdg 212.97 8657.8819.16 43376 96 hdi 195.61 8629.1423.95 43232120 hdk 197.01 8688.2222.36 43528112 Using dd to firewire drive - Reads at 27MB/s avg-cpu: %user %nice %system %iowait %steal %idle 6.400.00 59.40 34.200.000.00 Device:
[Samba] Congratulations
I'm sure I speak for the entire community when I offer my heartiest congratulations to the Protocol Freedom Information Foundation and the Samba team for new agreement with Microsoft giving them, and other FOSS programs, access to data on how the Windows operating system works! The Samba team has gutted it through over the past several years to provide an essential tool for our work. Now, their jobs will hopefully be a bit easier, and will allow for the creation of an even better Samba. Once again, kudos, and the very best of the holiday season. Dimitri -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Using include for shares between servers
I have 2 servers setup in as high availability running multiple applications. Each application can run on either server and has their own file system that is shared. I read that I can use the include statement in the global section to call separate smb-XXX.conf files and have this working fine. My question is how, or if, I can start/stop the smb-XXX.conf files separately so that as an application moves between the HA servers so does the share. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Copy file from Vista to samba share
Hello, I believe this is a Vista issue, rather than samba. See here http://www.theregister.co.uk/2007/03/26/vista_copying_bug/ Mark On Thu, Nov 29, 2007 at 10:47:41AM +0100, Elmar Haneke wrote: Hi, my Vista box does hang if I try to copy an File on an Samba share. - Hanging does happen on both, explorer and CMD. In Explorer it shows up to calculate how long it might take. In CMD nothing happend. - Afterwards Vista refuses to shut down. - Creating an File on the Share and saving it from within notepad does not cause any trouble. - Limiting protocol to lanman2 seems to help regarding the hangup. But it is raising other problems (Long Filenames on Win98 clients, Domain Login). - The problem did occur on two 32Bit Athlon machines. On another Machine equipped with Athlon 64 (running 64 Bit Linux) the hanging seems not to reproduce. With identical smb.conf hanging does reproduce on 32Bit host. - I'm using Debian Linux (Lenny / SID) with Samba 3.0.26a/3.0.27a. I did move to 3.1-pre1 and 4.0-alpha1 but both did not help - I did run with several 32Bit Linux-Kernels: 2.6.22-3-k7 (binary from Debian) 2.6.14 (from source) 2.6.19.7 (from source) What can be done ho resolve this problem? Elmar -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] SLow cups printing, lots of get-printer-attributes
On Fri, Dec 14, 2007 at 03:59:02PM +0100, Emmanuel Lacour wrote: Hi all, I encounter a problem here on a samba PDC with 97 cups printers. When on a windows client, I click right on a printer, then select properties, it tooks about 12 secondes to open. When from a spreadsheet such as M$ Excel I click on print, then try to select an imprimante from my pdc, it tooks about 30 seconds. I did some debugging, and with an strace on the smb process, found that for my first test (printer properties), samba ask cups 25 times per printers for printer attributes (I also found in cups a lot of Get-printer-attributes successful-ok). below an exemple of this call from strace. is there someone who know why samba test each printer 25 times ? is there someone who knwo why samba ask for informations on other printers when I select a defined printer ? Except this give me really slow printing management, printing itself is working fine ... just slow. Thanks for any hint/help :) I did some tests and found that it results from a change between 3.0.24 and 3.0.25 and it's stil there in 3.0.28. The strace for 3.0.24 is really shorter than newer versions as it just open the right printer and does not try to access all informations of all printers. Ther is a lot of changes on the printing code between 3.0.24 and 3.0.25, but I will try to study it a little bit :/ -- Emmanuel Lacour -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Using include for shares between servers
Roach, Duane writes: My question is how, or if, I can start/stop the smb-XXX.conf files separately so that as an application moves between the HA servers so does the share. You can include the smb-XXX.conf and just change the content through your HA monitoring application. We use a static smb.conf and a separate part that is managed via a web frontend. Whenever the included part changes, samba's config is updated automatically. You could also move the smb-XXX.conf in or out of place, or rename them, based on whether or not that particular server is active. The included file does not *need* to be present, it is only used if it is there. However, no matter your setup, IMHO the trigger for the changes should come from your HA setup. Regards, roel -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
RE: [Samba] Congratulations
Hi! +1 ! /aTan I'm sure I speak for the entire community when I offer my heartiest congratulations to the Protocol Freedom Information Foundation and the Samba team for new agreement with Microsoft giving them, and other FOSS programs, access to data on how the Windows operating system works! The Samba team has gutted it through over the past several years to provide an essential tool for our work. Now, their jobs will hopefully be a bit easier, and will allow for the creation of an even better Samba. Once again, kudos, and the very best of the holiday season. Dimitri -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Problem with date created attribute
I assume that this is also true for Linux version? I use debian, and also see this behaviour. Regards, Mark On Wed, Dec 19, 2007 at 03:55:02PM -0800, Jeremy Allison wrote: On Wed, Dec 19, 2007 at 03:48:24PM -0800, David Lee wrote: Thanks for the reply. After a bit of digging I found that FreeBSD does support a 'created' timestamp field for a file, but it seems (and I could be mistaken) that Samba doesn't take advantage of it. We've got the internal infrastructure to use this, but the code isn't filled in yet. If you can point me at the relevent man pages I'll try and get this done for 3.2 official. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Simple Samba PDC - tdbsam limitations?
Hi, I'm setting up a new Samba server, and am debating between LDAP (complex, and I'm not that familiar with it) and tdbsam for the password backend... I understand the physical limitations (single PDC, no replication, etc), which is fine, since this is a small office - about 50 workstations, possibly growing to as many as 75, but no more than that. What are the limitations of the tdbsam backend, with respect to performance and the number of workstations/users it can reasonably be expected to support? The box itself is a Tyan MB/dual opteron 280 with 2GB of RAM (can add more RAM if needed)... Thanks! -- Best regards, Charles -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Congratulations
Dimitri Yioulos, on 12/21/2007 8:07 AM, said the following: I'm sure I speak for the entire community when I offer my heartiest congratulations to the Protocol Freedom Information Foundation and the Samba team for new agreement with Microsoft giving them, and other FOSS programs, access to data on how the Windows operating system works! The Samba team has gutted it through over the past several years to provide an essential tool for our work. Now, their jobs will hopefully be a bit easier, and will allow for the creation of an even better Samba. Wow!! What a great Christmas present for the Samba Team! Can't wait to see the benefits start to make themselves evident... the biggest of which I imagine is no more guessing on the protocols, so no more time wasted on sifting through tcp dumps, meaning more time available to code... Great News! -- Best regards, Charles -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Failing to compile Samba with native ldap support (Solaris/AIX/..) and active directory support
If I use native ldap libraries which don't have ldap_initialize the build fails for Solaris and AIX, but looking into configure.in exception have been put in for HPUX to use ldap_init. Why isn't the same possible for Solaris and AIX ? Markus # HPUX only has ldap_init; ok, we take care of this in smbldap.c case $host_os in *hpux*) AC_CHECK_FUNC_EXT(ldap_init,$LDAP_LIBS) if test x$ac_cv_func_ext_ldap_init != xyes; then if test x$with_ads_support = xyes; then AC_MSG_ERROR(Active Directory support on HPUX requires ldap_init) elif test x$with_ads_support = xauto; then AC_MSG_WARN(Disabling Active Directory support (requires ldap_init on HPUX)) with_ads_support=no fi fi ;; *) AC_CHECK_FUNC_EXT(ldap_initialize,$LDAP_LIBS) if test x$ac_cv_func_ext_ldap_initialize != xyes; then if test x$with_ads_support = xyes; then AC_MSG_ERROR(Active Directory support requires ldap_initialize) elif test x$with_ads_support = xauto; then AC_MSG_WARN(Disabling Active Directory support (requires ldap_initialize)) with_ads_support=no fi fi ;; esac -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
There is no writable option in Swat that I can see even with Advance mode. The shares work fine otherwise, just not to our dropbox folders that have the permissions of 2733. Get access denied error when you try and copy a file or drag and drop a file onto the dropbox folder. Alex Harrington wrote: But now have upgraded to Samba 3.0.28 and they are no longer working. Try adding writable = yes to the share definition? Cheers Alex -- C. J. Keist Email: [EMAIL PROTECTED] UNIX/Network ManagerPhone: 970-491-0630 Engineering Network ServicesFax: 970-491-5569 College of Engineering, CSU Ft. Collins, CO 80523-1301 All I want is a chance to prove 'Money can't buy happiness' -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
no longer working is you can no longer move or copy files into the dropbox folder from Windows 2000, XP, Vista or even MacOSX. You get access denied error. Ryan Novosielski wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 CJ Keist wrote: All, I searched archives and found one related to our problem, with subject samba 3.0.26a and dropboxes, but there was no solution. So posting this again for hopes of a fix. We have dropboxes where users can drop files in someone else's dropbox folder. You have write permissions but not read for the folder. In UNIX the dropbox permision is set as 2733. This all worked fine with Samba 3.0.6a. But now have upgraded to Samba 3.0.28 and they are no longer working. My settings for the share is: [ens] comment = ENS Groups path = /top/admin/ENS valid users = +admin force group = admin read only = No create mask = 0770 directory mask = 02770 inherit permissions = Yes inherit acls = Yes inherit owner = Yes dos filemode = Yes This is on Solaris 9 UFS filesystem with quotas enabled. You do realize how vague no longer working is, right? - -- _ _ _ _ ___ _ _ _ |Y#| | | |\/| | \ |\ | | |Ryan Novosielski - Systems Programmer II |$| |__| | | |__/ | \| _| |[EMAIL PROTECTED] - 973/972.0922 (2-0922) \__/ Univ. of Med. and Dent.|IST/AST - NJMS Medical Science Bldg - C630 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHa1Bomb+gadEcsb4RAl7JAKCqVRj97RmjGPSiLXUTF0r7oOuLmACg0CzY TfOFCrrKmDM2OcqJD4+pzCY= =pWNy -END PGP SIGNATURE- -- C. J. Keist Email: [EMAIL PROTECTED] UNIX/Network ManagerPhone: 970-491-0630 Engineering Network ServicesFax: 970-491-5569 College of Engineering, CSU Ft. Collins, CO 80523-1301 All I want is a chance to prove 'Money can't buy happiness' -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Simple Samba PDC - tdbsam limitations?
Charles Marcus, on 12/21/2007 8:06 AM, said the following: What are the limitations of the tdbsam backend, with respect to performance and the number of workstations/users it can reasonably be expected to support? Never mind - of course this is well documented in the most excellent 'The Official SAMBA-3 HOWTO and Reference Guide'... For anyone curious - it is not generally recommended to use the tdbsam backend for sites with 250+ users, but this is only because these sites likely will be spread out and require BDCs and multiple servers... They specifically mention one site using the tdbsam backend with 4,500+ users with no performance problems whatsoever... Sorry for the noise. -- Best regards, Charles -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
On 12/21/2007, CJ Keist ([EMAIL PROTECTED]) wrote: There is no writable option in Swat that I can see even with Advance mode. Ever heard of the command line? -- Best regards, Charles -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
On Friday 21 December 2007, CJ Keist wrote: There is no writable option ... man smb.conf The shares work fine otherwise, just not to our dropbox folders that have the permissions of 2733. Have you read the release notes from 3.0.28 to 3.0.26a? Maybe a fix (possibly that mentioned for BUG 4978) requires some changes in your setup. -- Chris -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
On Dec 21, 2007 10:12 AM, CJ Keist [EMAIL PROTECTED] wrote: no longer working is you can no longer move or copy files into the dropbox folder from Windows 2000, XP, Vista or even MacOSX. You get access denied error. Have you verified that that unix permissions allow writing for the admin group? John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
If Option Read Only is NO. Doesn't that imply writing is allowed?? No; it just specifies the permissions of the share. Underlying file system permissions still apply. Anyway, put in the writeable Option and set to Yes and still getting access denied error when try to copy or drag and drop file on the dropbox folder. And I do restart the samba services every time I edit the smb.conf file. No, just wait a moment. If you don't have anything constructive to say don't bother replying to my posts. -- Adam Tauno Williams, Network Systems Administrator Consultant - http://www.whitemiceconsulting.com Developer - http://www.opengroupware.org -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Password expired
On Tue, 2008-01-01 at 09:33 +0100, Andrea Bencini wrote: I installed samba-3.0.28-0 I set maximum password age. pierluigim password has expired and so he would like to change it from XP prof client, but he receives this message: Lacking permission to change the password. and in my log.smb file I have: -- [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_chauthtok(691) PAM: UNKNOWN PAM ERROR (19) for User: pierluigim [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_passchange(847) smb_pam_passchange: PAM: Password Change Failed for user pierluigim! [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_chauthtok(691) PAM: UNKNOWN PAM ERROR (19) for User: pierluigim [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_passchange(847) smb_pam_passchange: PAM: Password Change Failed for user pierluigim! [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_chauthtok(691) PAM: UNKNOWN PAM ERROR (19) for User: pierluigim [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_passchange(847) smb_pam_passchange: PAM: Password Change Failed for user pierluigim! [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_chauthtok(691) PAM: UNKNOWN PAM ERROR (19) for User: pierluigim [2007/12/20 19:02:10, 0] auth/pampass.c:smb_pam_passchange(847) smb_pam_passchange: PAM: Password Change Failed for user pierluigim! -- Can you help me? Looks like an issue with your PAM configuration. Can the user change their password via passwd? Or perhaps you only want to change the Samba SAM and not hit PAM? -- Adam Tauno Williams, Network Systems Administrator Consultant - http://www.whitemiceconsulting.com Developer - http://www.opengroupware.org -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
RE: [Samba] samba 3.0.28 and dropboxes
C. J. Keist wrote: There is no writable option in Swat that I can see even with Advance mode. In smb.conf writable is a synonym for writeable, which is an inverted synonym for read only. See http://us3.samba.org/samba/docs/man/manpages-3/smb.conf.5.html Kevin -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
What is command line, don't see that key on my keyboard anywhere! If Option Read Only is NO. Doesn't that imply writing is allowed?? Anyway, put in the writeable Option and set to Yes and still getting access denied error when try to copy or drag and drop file on the dropbox folder. [global] workgroup = MY_DOMAIN server string = Samba Server security = DOMAIN password server = server1,server2 passwd program = /usr/local/bin/passwd username map = /etc/smbusers password level = 8 client NTLMv2 auth = Yes client lanman auth = No client plaintext auth = No log level = 1 log file = /var/log/samba/logs/log.%m max log size = 50 name resolve order = lmhosts host wins bcast deadtime = 10 socket options = TCP_NODELAY IPTOS_LOWDELAY load printers = No dns proxy = No kernel oplocks = No ldap ssl = no remote announce = 169.168.0.34 winbind cache time = 15 oplocks = No strict locking = No dos filemode = Yes [ens] comment = ENS Groups path = /top/admin/ENS valid users = +admin force group = admin read only = No writeable = Yes create mask = 0770 directory mask = 02770 inherit permissions = Yes inherit acls = Yes inherit owner = Yes And I do restart the samba services every time I edit the smb.conf file. If you don't have anything constructive to say don't bother replying to my posts. Charles Marcus wrote: On 12/21/2007, CJ Keist ([EMAIL PROTECTED]) wrote: There is no writable option in Swat that I can see even with Advance mode. Ever heard of the command line? -- C. J. Keist Email: [EMAIL PROTECTED] UNIX/Network ManagerPhone: 970-491-0630 Engineering Network ServicesFax: 970-491-5569 College of Engineering, CSU Ft. Collins, CO 80523-1301 All I want is a chance to prove 'Money can't buy happiness' -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
Yes, UNIX permissions are all set correctly, 2733. Full access for the user that owns the dropbox folder, and just write and execute for group and other. With set gid enabled. User accounts in UNIX and Windows domains are the same. Everything else with the share works fine. Just not to these dropbox folders with 2733 permissions. If set to 2773, giving group read/write then everyone in the group can copy files into the dropbox. But that is not the function we want. We only want the owner of the dropbox having read access. Again this all worked great in samba-3.0.6a, so looking like I'm going to have to revert to the older version as dropbox folder functionality is imperative for us. New options I have enabled for the share to try and make this work are: inherit permission = yes inherit owner = yes dos filemode = yes John Drescher wrote: On Dec 21, 2007 10:12 AM, CJ Keist [EMAIL PROTECTED] wrote: no longer working is you can no longer move or copy files into the dropbox folder from Windows 2000, XP, Vista or even MacOSX. You get access denied error. Have you verified that that unix permissions allow writing for the admin group? John -- C. J. Keist Email: [EMAIL PROTECTED] UNIX/Network ManagerPhone: 970-491-0630 Engineering Network ServicesFax: 970-491-5569 College of Engineering, CSU Ft. Collins, CO 80523-1301 All I want is a chance to prove 'Money can't buy happiness' -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
Hallo, CJ, Du (cj.keist) meintest am 21.12.07: UNIX permissions are all set correctly, 2733. Full access for the user that owns the dropbox folder, and just write and execute for group and other. execute is a UNIX right - it has no meaning for the Windows side. And the files are not readable - that may be an error. By the way: on the UNIX side the x flag has different meanings for files and for directories; on directories it should be set. Viele Gruesse! Helmut -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 AFAIK, read only and writable are commands that effectively do the same thing. They don't both need to be there. I would recommend elevating your log level for some clients to see if you can't track down why access is denied. CJ Keist wrote: What is command line, don't see that key on my keyboard anywhere! If Option Read Only is NO. Doesn't that imply writing is allowed?? Anyway, put in the writeable Option and set to Yes and still getting access denied error when try to copy or drag and drop file on the dropbox folder. [global] workgroup = MY_DOMAIN server string = Samba Server security = DOMAIN password server = server1,server2 passwd program = /usr/local/bin/passwd username map = /etc/smbusers password level = 8 client NTLMv2 auth = Yes client lanman auth = No client plaintext auth = No log level = 1 log file = /var/log/samba/logs/log.%m max log size = 50 name resolve order = lmhosts host wins bcast deadtime = 10 socket options = TCP_NODELAY IPTOS_LOWDELAY load printers = No dns proxy = No kernel oplocks = No ldap ssl = no remote announce = 169.168.0.34 winbind cache time = 15 oplocks = No strict locking = No dos filemode = Yes [ens] comment = ENS Groups path = /top/admin/ENS valid users = +admin force group = admin read only = No writeable = Yes create mask = 0770 directory mask = 02770 inherit permissions = Yes inherit acls = Yes inherit owner = Yes And I do restart the samba services every time I edit the smb.conf file. If you don't have anything constructive to say don't bother replying to my posts. Charles Marcus wrote: On 12/21/2007, CJ Keist ([EMAIL PROTECTED]) wrote: There is no writable option in Swat that I can see even with Advance mode. Ever heard of the command line? - -- _ _ _ _ ___ _ _ _ |Y#| | | |\/| | \ |\ | | |Ryan Novosielski - Systems Programmer II |$| |__| | | |__/ | \| _| |[EMAIL PROTECTED] - 973/972.0922 (2-0922) \__/ Univ. of Med. and Dent.|IST/AST - NJMS Medical Science Bldg - C630 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHa/IImb+gadEcsb4RArdnAJwKCyEerf7rSAib5snGK9bI0+n+hwCeOq/1 OaX+v7yw+9YawpwVyWO9ec4= =jLoq -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Problem with date created attribute
On Fri, Dec 21, 2007 at 12:48:52PM +, Mark Adams wrote: I assume that this is also true for Linux version? I use debian, and also see this behaviour. Linux doesn't have the birthtime stamp yet I think. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
On 20/12/2007, CJ Keist [EMAIL PROTECTED] wrote: All, I searched archives and found one related to our problem, with subject samba 3.0.26a and dropboxes, but there was no solution. So posting this again for hopes of a fix. We have dropboxes where users can drop files in someone else's dropbox folder. You have write permissions but not read for the folder. In UNIX the dropbox permision is set as 2733. This all worked fine with Samba 3.0.6a. But now have upgraded to Samba 3.0.28 and they are no longer working. I think that's a Samba bug, There was a change in the directory handling code that started requiring the ability to read the directory. I have a patch for this somewhere - I'll try to dig it up in the new year. -- James Peach | [EMAIL PROTECTED] -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] samba 3.0.28 and dropboxes
James, That would be great if you can find the patch. For, now I will drop back to 3.0.6a samba. Happy Holidays and Happy New Year. James Peach wrote: On 20/12/2007, CJ Keist [EMAIL PROTECTED] wrote: All, I searched archives and found one related to our problem, with subject samba 3.0.26a and dropboxes, but there was no solution. So posting this again for hopes of a fix. We have dropboxes where users can drop files in someone else's dropbox folder. You have write permissions but not read for the folder. In UNIX the dropbox permision is set as 2733. This all worked fine with Samba 3.0.6a. But now have upgraded to Samba 3.0.28 and they are no longer working. I think that's a Samba bug, There was a change in the directory handling code that started requiring the ability to read the directory. I have a patch for this somewhere - I'll try to dig it up in the new year. -- C. J. Keist Email: [EMAIL PROTECTED] UNIX/Network ManagerPhone: 970-491-0630 Engineering Network ServicesFax: 970-491-5569 College of Engineering, CSU Ft. Collins, CO 80523-1301 All I want is a chance to prove 'Money can't buy happiness' -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] IDMAP, WINBIND and NIS
I have posted on this subject before but am still running into problems. The main question is whether I need to use Windbind in a single samba domain when each samba server also uses NIS for centralized unix level authentication. And if, in fact, I need windbind do I need it on all the samba servers? And do I need a central IDMAP respositoryor other mechanism to maintain consident SIDs? My interpretation of the Samba How To documentation is that Windbind is not needed in a single samba domain, with multiple samba servers, if the samba servers are using NIS or LDAP for unix accounts. - The Samba How To chapter on Identity Mapping has the following (paraphrased) entry Domain Member Server or Domain Member Client - Winbind is not used; users and groups resolved via NSS - user and group accounts are treated as if they are local accounts, accounts are stored in a shared repository (NIS or LDAP.) This configuration may be used with domain member servers (NT4 or ADS) or PDC - My PDC is Samba 3.026a on Solaris. I have member servers that are a mix of Samba 3.026a on Solaris and Samba 3.024a on Linux. All machines are using NIS for unix authentication. Some groups are explicitly mapped between unix and windows, some aren't.I am not (usually) running winbind on either PDC or member server. I have not configured nsswitch.conf to use winbind for unix-level authentication. On a member server (from a Windows client), file or folder permissions are assigned to unix\someuser. However, permissions still work as I expect.From the Windows perspective, this seems to be a standalone workgroup machine that happen to have the same user id and password. Since the file permissions work this is OK most of the time.However, if I try to add or modify permssions under Windows I run into problems (symptoms depend on if and when winbind has been started.) 1. If winbind is not running, I can browser users or groups from the domain but the permissions don't hold. Presumably Samba doesn't match up mydomain\someuser with unix\someuser. So it looks like I would need winbind. 2. If, after I have already connected to a share, and then start winbind on the member , the file permissions will show the domain component, and I can set permissions 3. However, if I start winbind before I connect to the share, I just get prompted for a user name and password- and I am unable to connect. If winbind is running on the memeber server wbinfo -u will list the domain accounts in DOMAINNAME\user format. Member server smb.conf includes idmap uid = 1-2 idmap gid = 1-2 template shell = /bin/bash winbind use default domain = no winbind trusted domains only = no winbind enum users = Yes winbind enum groups = Yes name resolve order = host wins bcast workgroup = mydomain security = domain password server = mypdc The PDC smb.conf does not include the idmap entries. If I run 'wbinfo -i mydomain/someuser ' on each machine (assuming winbind is running) it shows a user ID for that user. On the member server, the user id's are in the 1 range.On the PDC, the user ID matches the unix user id.But I am not sure if this is relevant, or it idmap is only required in a multi-domain environment. Even if I were to assign an idmap uid range on the PDC, there is no guarantee they would be assigned in the same order. Thanks -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Inconsistent behavior with XP pro clients
I'm seeing inconsistent behavior with XP pro clients on a Samba PDC. In one case, (a virtual machine) it appears to log in and everything looks great. In another ( a slower PC ), the PC rejects the user login ( even with the registry hack ), and in a third, the PC takes a long time to synchronize not just the user that logged in that time, but all users that have logged in since rebooting. I know this is Windows that I'm talking about, but are there settings to toggle for more consistent, reasonable behavior? -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] difficulty setting up Samba PDC.. please help... out of ideas
Eventually, that was the plan. However... I was trying to get one thing working at a time, and got stuck at that point. Thanks for the suggestion, though. ( You make it sound easy =P ) John Drescher wrote: On Dec 20, 2007 10:32 PM, John Drescher [EMAIL PROTECTED] wrote: On Dec 20, 2007 7:56 PM, J [EMAIL PROTECTED] wrote: The answer, to my biggest problem, was that the user needed the same smbpasswd on both Samba servers. (d'oh!) Take a look at using ldap. That way you can have a central password server and not have that problem. John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] difficulty setting up Samba PDC.. please help... out of ideas
On Dec 21, 2007 2:13 PM, J [EMAIL PROTECTED] wrote: Eventually, that was the plan. However... I was trying to get one thing working at a time, and got stuck at that point. Thanks for the suggestion, though. ( You make it sound easy =P ) Once everything is migrated the openldap administration is pretty easy. We are using one main ldap server and several other read only replicas using syncprov. I am not sure about the migration part though as a coworker did that part. John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Simple Samba PDC - tdbsam limitations?
On Fri, 2007-12-21 at 13:48 -0500, Ryan Novosielski wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Charles Marcus wrote: Charles Marcus, on 12/21/2007 8:06 AM, said the following: What are the limitations of the tdbsam backend, with respect to performance and the number of workstations/users it can reasonably be expected to support? Never mind - of course this is well documented in the most excellent 'The Official SAMBA-3 HOWTO and Reference Guide'... For anyone curious - it is not generally recommended to use the tdbsam backend for sites with 250+ users, but this is only because these sites likely will be spread out and require BDCs and multiple servers... They specifically mention one site using the tdbsam backend with 4,500+ users with no performance problems whatsoever... Sorry for the noise. This is extremely timely for me, since I was looking into this subject just this morning. I have about 11,500 users on an smbpasswd file! :-o This does not work very well, and we recently reached a breaking point. I looked into tdbsam, figuring that that might be the easy way to go (I do not need replication, as this backend is running a computer lab, not 11,500 concurrent users). The fact that my setup is two orders of magnitude larger than the recommendation for tdbsam gives me pause. Can anyone comment on this? I'm sorta in an emergency situation, not a design situation... I'm almost looking at MySQL because that is something that I could reasonably deploy in the next 48 hours. LDAP would require at least some substantial reading for me, I'd think. Maybe not. If you do not need to replicate user information elsewhere tdbsam is the fastest backend you can get. The recommendation about 250+ users has more to do with network topologies usually implemented when you get around these numbers, and has nothing to do with the scalability of the backend itself. Simo. -- Simo Sorce Samba Team GPL Compliance Officer [EMAIL PROTECTED] Senior Software Engineer at Red Hat Inc. [EMAIL PROTECTED] -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Single Sign On, authentication, and Windows XP Home
Hello, I have a small (medium?) sized network of about 30 XP machines. About 2/3 of these machines are running Home Ed. while the other 1/3 are running Professional Ed. I currently have two samba shares, and I'm using 'user' security. I want to implement single sign on, some way, somehow. I've considered: NIS and LDAP, but I can't get the NIS pGina plugin to work with my NIS server, and LDAP seems like a beast to setup, though I'm willing to go for it if it means that I'll be able to get SSO working. Does any one have any suggestions / recommendations? Thanks, Matt -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Simple Samba PDC - tdbsam limitations?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Charles Marcus wrote: Charles Marcus, on 12/21/2007 8:06 AM, said the following: What are the limitations of the tdbsam backend, with respect to performance and the number of workstations/users it can reasonably be expected to support? Never mind - of course this is well documented in the most excellent 'The Official SAMBA-3 HOWTO and Reference Guide'... For anyone curious - it is not generally recommended to use the tdbsam backend for sites with 250+ users, but this is only because these sites likely will be spread out and require BDCs and multiple servers... They specifically mention one site using the tdbsam backend with 4,500+ users with no performance problems whatsoever... Sorry for the noise. This is extremely timely for me, since I was looking into this subject just this morning. I have about 11,500 users on an smbpasswd file! :-o This does not work very well, and we recently reached a breaking point. I looked into tdbsam, figuring that that might be the easy way to go (I do not need replication, as this backend is running a computer lab, not 11,500 concurrent users). The fact that my setup is two orders of magnitude larger than the recommendation for tdbsam gives me pause. Can anyone comment on this? I'm sorta in an emergency situation, not a design situation... I'm almost looking at MySQL because that is something that I could reasonably deploy in the next 48 hours. LDAP would require at least some substantial reading for me, I'd think. Maybe not. =R - -- _ _ _ _ ___ _ _ _ |Y#| | | |\/| | \ |\ | | |Ryan Novosielski - Systems Programmer II |$| |__| | | |__/ | \| _| |[EMAIL PROTECTED] - 973/972.0922 (2-0922) \__/ Univ. of Med. and Dent.|IST/AST - NJMS Medical Science Bldg - C630 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHbAp0mb+gadEcsb4RAvpjAKChomcxXbQYo1CoFlxTlc2idTBNBACdE/VD QyN68wBsW23xU+AKBVoPj7g= =Lbkx -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] notepad: LocalizedResourceName=
I have notepad popping up for every user with a long message that starts out: [.ShellClassInfo] [EMAIL PROTECTED],-21787 I found an explanation here: http://www.hostingforum.ca/131016-samba-notepad-selfstart-login.html: What is happening is that the desktop.ini file that is normally hidden is having those attributes stripped off, possibly because your config does not allow the windows hidden attribute to be mapped. The change happens when the user's roaming profile is copied up to the server on logout and then copied back with the new unhidden attributes. Now that the file is visible, it is being 'run' since it is in the startup folder, and the default app to run an ini file is notepad. You can either delete the file or figure out what config options you need to change to allow it to remain 'hidden'. You will probably have to remove it on all profiles already showing the behavior since it won't get set back to hidden. I know I can set up Samba to ignore all . files, or even this one, in particular, but I don't know what the ramification is to doing that. What is the best way to stop this behavior? -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Single Sign On, authentication, and Windows XP Home
Matt Lozier skrev: Hello, I have a small (medium?) sized network of about 30 XP machines. About 2/3 of these machines are running Home Ed. while the other 1/3 are running Professional Ed. I currently have two samba shares, and I'm using 'user' security. I want to implement single sign on, some way, somehow. I've considered: NIS and LDAP, but I can't get the NIS pGina plugin to work with my NIS server, and LDAP seems like a beast to setup, though I'm willing to go for it if it means that I'll be able to get SSO working. Does any one have any suggestions / recommendations? Thanks, Matt What applications do you want sso for? You might be interested in Mandriva directory server http://mds.mandriva.org/wiki/Documentation -- Rune Tønnesen Bedste Hilsner/Best Regards -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Automatic printers don't quite work...
I have a new Centos 5.1 system whicn reports samba version samba 3.0.25b-1.el5_1.4 - and have just added a physical printer. Linux doesn't know the printer (Samsung CLP510) so it is installed as raw - no driver. When I use a windows box to browse the network - the printer is visible on the C5 server (without me explicitly creating a share)- and I can connect it - and install the printer on the windows machine (using a windows driver which is already on the windows box). The printer then shows up on the windows box Printers and Faxes screen as Ready. If I get its properties and print a test page - I get the error: The page failed to print After quite a bit of messing about - I tried explicitly creating a printer share in the smb.conf - and this share works fine. I would prefer that automatically generated printers work because otherwise the windos boxes see the automatically generated printer - and have to be told not to try to use it. Here are the relevant bits of smb.conf: --- [global] dns proxy = no log file = /var/log/samba/%m.log ; netbios name = C5 cups options = raw ; load printers = yes server string = Centos 5 Linux ; writeable = yes ; write list = richard workgroup = aardvarkwg ; os level = 20 valid users = richard ; security = user max log size = 50 username map = /etc/samba/smbusers ; encrypt passwords = yes ; guest ok = no guest account = richard # workgroup = NT-Domain-Name or Workgroup-Name, eg: MIDEARTH [homes] comment = Home Directories browseable = no writeable = yes # NOTE: If you have a BSD-style print system there is no need to # specifically define each individual printer [printers] comment = All Printers path = /usr/spool/samba browseable = yes # Set public = yes to allow user 'guest account' to print # 21/12/2007 added the below lines: public = yes guest ok = yes writeable = yes printable = yes # added 21/12/2007 to get around access denied when browsing with windows: use client driver = yes #This seems to work: [CLP510Monochrome] printer = CLP510 printable = yes path = /var/spool/samba use client driver = yes Can anyone suggest why the automatically generated printer isn't working properly? Thanks. Richard. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Why do my samba shares (using ZFS) not immediately refresh when I make a change to them via CIFS?
Using my Windows XP machine, I browse to the samba/zfs share and create a directory but it doesn't show up unless I hit F5 to refresh. However, my other samba shares (not using ZFS) immediately show all changes. Has anybody experienced this problem? It's kind-of annoying and is fairly dangerous because you can delete directories (or files) and they will still appear to be there unless you refresh the directory... Thanks for any help... -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Simple Samba PDC - tdbsam limitations?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 simo wrote: On Fri, 2007-12-21 at 13:48 -0500, Ryan Novosielski wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Charles Marcus wrote: Charles Marcus, on 12/21/2007 8:06 AM, said the following: What are the limitations of the tdbsam backend, with respect to performance and the number of workstations/users it can reasonably be expected to support? Never mind - of course this is well documented in the most excellent 'The Official SAMBA-3 HOWTO and Reference Guide'... For anyone curious - it is not generally recommended to use the tdbsam backend for sites with 250+ users, but this is only because these sites likely will be spread out and require BDCs and multiple servers... They specifically mention one site using the tdbsam backend with 4,500+ users with no performance problems whatsoever... Sorry for the noise. This is extremely timely for me, since I was looking into this subject just this morning. I have about 11,500 users on an smbpasswd file! :-o This does not work very well, and we recently reached a breaking point. I looked into tdbsam, figuring that that might be the easy way to go (I do not need replication, as this backend is running a computer lab, not 11,500 concurrent users). The fact that my setup is two orders of magnitude larger than the recommendation for tdbsam gives me pause. Can anyone comment on this? I'm sorta in an emergency situation, not a design situation... I'm almost looking at MySQL because that is something that I could reasonably deploy in the next 48 hours. LDAP would require at least some substantial reading for me, I'd think. Maybe not. If you do not need to replicate user information elsewhere tdbsam is the fastest backend you can get. The recommendation about 250+ users has more to do with network topologies usually implemented when you get around these numbers, and has nothing to do with the scalability of the backend itself. The unfortunate thing is that I'm running CIFS/9000 (HP's version of Samba). Their support is very good, but they're willing to let me run smbpasswd (which has finally melted down), but they say that tdbsam is not recommended for over 250 users. Something tells me the Samba team should actually change their tune on this and say what the backend should support, not at what point I'd want replication. There are easily situations where a place could have very few concurrent users and very many users in their password file, meaning that smbpasswd is a terrible idea, but replication is not actually necessary. I would say that tdbsam is definitely FAR more scalable than smbpasswd, is that right? - -- _ _ _ _ ___ _ _ _ |Y#| | | |\/| | \ |\ | | |Ryan Novosielski - Systems Programmer II |$| |__| | | |__/ | \| _| |[EMAIL PROTECTED] - 973/972.0922 (2-0922) \__/ Univ. of Med. and Dent.|IST/AST - NJMS Medical Science Bldg - C630 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHbLowmb+gadEcsb4RAg/FAJ0YDzsTgEjWRM9tdt9lCg+PC+inawCguNGn aPs1dTtPL7yccYyZoY22sSs= =rFl0 -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Simple Samba PDC - tdbsam limitations?
On Sat, Dec 22, 2007 at 02:18:09AM -0500, Ryan Novosielski wrote: I would say that tdbsam is definitely FAR more scalable than smbpasswd, is that right? Yes, definately. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-768-g5c392c4
The branch, v3-2-test has been updated via 5c392c4c6e277a24d0d477902dc7856b2b46ee53 (commit) via 5ab82d4f574f2a2e2761e9e414c66a70aeffb05d (commit) via c31c7e3e24875ce75bc18f0ad7529320eab8e50a (commit) via 7e1d9b561f6df233b8c7eaec83d1e4207b5a2fb0 (commit) via 93e5de23e7109432f554745b18c6d630a39f9c2b (commit) via 7e193c68b2a7eb16afc12379a4ceed41053d1eeb (commit) via c19363eb77fcc3e1bf3341e6373d38f1e91fc08f (commit) via 4b06c68482247d859ec30b8b1920706e43358989 (commit) via 86d9412611fd99c21e15c71d30a3f95e35d8535b (commit) via 032c5589fe7f9f2fcb0f336e72517a81a720b6ce (commit) via ea0e5ad9a15c848904dee8cb2d3e392b6a894705 (commit) via c131d0dc52ec09c9227eff3d68877369c37aaed5 (commit) from e18fab269c7370a6670c56eeab60fd90feecf0b2 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit 5c392c4c6e277a24d0d477902dc7856b2b46ee53 Author: Volker Lendecke [EMAIL PROTECTED] Date: Thu Dec 20 22:27:01 2007 +0100 Some C++ fixes commit 5ab82d4f574f2a2e2761e9e414c66a70aeffb05d Author: Volker Lendecke [EMAIL PROTECTED] Date: Thu Dec 20 22:17:16 2007 +0100 Some C++ warnings commit c31c7e3e24875ce75bc18f0ad7529320eab8e50a Author: Volker Lendecke [EMAIL PROTECTED] Date: Thu Dec 20 21:25:00 2007 +0100 Fix a C++ warning commit 7e1d9b561f6df233b8c7eaec83d1e4207b5a2fb0 Author: Volker Lendecke [EMAIL PROTECTED] Date: Thu Dec 20 20:59:44 2007 +0100 Fix a C++ warning commit 93e5de23e7109432f554745b18c6d630a39f9c2b Author: Volker Lendecke [EMAIL PROTECTED] Date: Thu Dec 20 20:59:27 2007 +0100 Fix a missing prototype warning commit 7e193c68b2a7eb16afc12379a4ceed41053d1eeb Author: Volker Lendecke [EMAIL PROTECTED] Date: Sun Dec 9 18:25:34 2007 +0100 Remove some statics from md4.c commit c19363eb77fcc3e1bf3341e6373d38f1e91fc08f Author: Volker Lendecke [EMAIL PROTECTED] Date: Thu Dec 20 16:05:57 2007 +0100 Add a singleton cache First user is yp_default_domain commit 4b06c68482247d859ec30b8b1920706e43358989 Author: Volker Lendecke [EMAIL PROTECTED] Date: Thu Dec 20 15:16:25 2007 +0100 Make data_blob_string_const return null terminated strings ... nobody was using it, so we're free to change it now :-) commit 86d9412611fd99c21e15c71d30a3f95e35d8535b Author: Volker Lendecke [EMAIL PROTECTED] Date: Wed Dec 19 21:59:28 2007 +0100 Remove next_token_nr_talloc and its associated global Only client.c and clitar.c used this, I think they should carry the static themselves. Also move the a bit funny routine toktocliplist to clitar.c, the only place where it is used. commit 032c5589fe7f9f2fcb0f336e72517a81a720b6ce Author: Volker Lendecke [EMAIL PROTECTED] Date: Thu Dec 20 14:54:33 2007 +0100 Convert the pwnam cache to memcache commit ea0e5ad9a15c848904dee8cb2d3e392b6a894705 Author: Volker Lendecke [EMAIL PROTECTED] Date: Thu Dec 20 14:41:58 2007 +0100 Add memcache_add_talloc The first memcache API only had blobs, but we have quite a few objects that are more complex talloc'ed structues. The current one I'm looking at is the getpwnam cache, but there are others around. commit c131d0dc52ec09c9227eff3d68877369c37aaed5 Author: Volker Lendecke [EMAIL PROTECTED] Date: Thu Dec 20 10:55:45 2007 +0100 Add a global cache It hurts, but I think this global variable is necessary for transition, and it has the potential to remove quite a few other global variables without messing with APIs too much. --- Summary of changes: source/client/client.c | 139 ++-- source/client/clitar.c | 60 +++- source/include/memcache.h | 13 ++- source/lib/access.c| 20 - source/lib/data_blob.c |2 +- source/lib/md4.c | 20 +++-- source/lib/memcache.c | 88 ++ source/lib/netapi/joindomain.c |1 + source/lib/secace.c|5 +- source/lib/secacl.c|3 +- source/lib/secdesc.c | 12 ++- source/lib/sharesec.c | 10 ++- source/lib/socket_wrapper/socket_wrapper.c |4 +- source/lib/time.c |4 +- source/lib/util_pw.c | 68 +++--- source/lib/util_seaccess.c |4 +- source/lib/util_str.c | 77 --- source/libsmb/clientgen.c |4 +- source/param/loadparm.c|2 +- source/rpc_server/srv_dfs_nt.c |2 +- source/rpc_server/srv_lsa_nt.c |4 +-
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-769-g5f5e52b
The branch, v3-2-test has been updated
via 5f5e52ba7b3862dc72a16d84e07503e98ccbbf8a (commit)
from 5c392c4c6e277a24d0d477902dc7856b2b46ee53 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit 5f5e52ba7b3862dc72a16d84e07503e98ccbbf8a
Author: Volker Lendecke [EMAIL PROTECTED]
Date: Fri Dec 21 12:53:12 2007 +0100
Fix the build on Solaris
---
Summary of changes:
source/lib/memcache.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/lib/memcache.c b/source/lib/memcache.c
index 448b8b2..457586b 100644
--- a/source/lib/memcache.c
+++ b/source/lib/memcache.c
@@ -332,7 +332,7 @@ void memcache_add(struct memcache *cache, enum
memcache_number n,
void memcache_add_talloc(struct memcache *cache, enum memcache_number n,
DATA_BLOB key, void *ptr)
{
- return memcache_add(cache, n, key, data_blob_const(ptr, sizeof(ptr)));
+ memcache_add(cache, n, key, data_blob_const(ptr, sizeof(ptr)));
}
void memcache_flush(struct memcache *cache, enum memcache_number n)
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-770-g763e133
The branch, v3-2-test has been updated
via 763e13315fc71237b14a186810bc201e725648f5 (commit)
from 5f5e52ba7b3862dc72a16d84e07503e98ccbbf8a (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit 763e13315fc71237b14a186810bc201e725648f5
Author: Günther Deschner [EMAIL PROTECTED]
Date: Fri Dec 21 13:40:11 2007 +0100
Use ADS_IGNORE_PRINCIPAL define.
Guenther
---
Summary of changes:
source/libsmb/cliconnect.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/libsmb/cliconnect.c b/source/libsmb/cliconnect.c
index d370808..33110c8 100644
--- a/source/libsmb/cliconnect.c
+++ b/source/libsmb/cliconnect.c
@@ -863,8 +863,7 @@ ADS_STATUS cli_session_setup_spnego(struct cli_state *cli,
const char *user,
/* If we get a bad principal, try to guess it if
we have a valid host NetBIOS name.
*/
- if (strequal(principal,
- [EMAIL PROTECTED])) {
+ if (strequal(principal, ADS_IGNORE_PRINCIPAL)) {
SAFE_FREE(principal);
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-772-gb1ad3de
The branch, v3-2-test has been updated
via b1ad3def98911c91ed55a3b7aec7d0894b2dd8fd (commit)
from b7383818168863a7ba43c2456f8c44e96e76707a (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit b1ad3def98911c91ed55a3b7aec7d0894b2dd8fd
Author: Günther Deschner [EMAIL PROTECTED]
Date: Fri Dec 21 15:28:01 2007 +0100
Add get_friendly_werror_msg().
Guenther
---
Summary of changes:
source/libsmb/doserr.c | 52 +--
1 files changed, 45 insertions(+), 7 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/libsmb/doserr.c b/source/libsmb/doserr.c
index 5bdd85d..dd556bb 100644
--- a/source/libsmb/doserr.c
+++ b/source/libsmb/doserr.c
@@ -1,18 +1,18 @@
-/*
+/*
* Unix SMB/CIFS implementation.
* DOS error routines
* Copyright (C) Tim Potter 2002.
- *
+ *
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
- *
+ *
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
- *
+ *
* You should have received a copy of the GNU General Public License
* along with this program; if not, see http://www.gnu.org/licenses/.
*/
@@ -21,12 +21,16 @@
#include includes.h
-typedef const struct
-{
+typedef const struct {
const char *dos_errstr;
WERROR werror;
} werror_code_struct;
+typedef const struct {
+ WERROR werror;
+ const char *friendly_errstr;
+} werror_str_struct;
+
werror_code_struct dos_errs[] =
{
{ WERR_OK, WERR_OK },
@@ -92,6 +96,22 @@ werror_code_struct dos_errs[] =
{ NULL, W_ERROR(0) }
};
+werror_str_struct dos_err_strs[] = {
+ { WERR_OK, Success },
+ { WERR_ACCESS_DENIED, Access is denied },
+ { WERR_INVALID_PARAM, Invalid parameter },
+ { WERR_NOT_SUPPORTED, Not supported },
+ { WERR_BAD_PASSWORD, A bad password was supplied },
+ { WERR_NOMEM, Out of memory },
+ { WERR_NO_LOGON_SERVERS, No logon servers found },
+ { WERR_NO_SUCH_LOGON_SESSION, No such logon session },
+ { WERR_DOMAIN_CONTROLLER_NOT_FOUND, A domain controller could not be
found },
+ { WERR_SETUP_NOT_JOINED, Join failed },
+ { WERR_SETUP_ALREADY_JOINED, Machine is already joined },
+ { WERR_SETUP_DOMAIN_CONTROLLER, Machine is a Domain Controller },
+ { WERR_LOGON_FAILURE, Invalid logon credentials },
+};
+
/*
Returns a DOS error message. not amazingly helpful, but better than a number.
*/
@@ -102,7 +122,7 @@ const char *dos_errstr(WERROR werror)
int idx = 0;
while (dos_errs[idx].dos_errstr != NULL) {
- if (W_ERROR_V(dos_errs[idx].werror) ==
+ if (W_ERROR_V(dos_errs[idx].werror) ==
W_ERROR_V(werror))
return dos_errs[idx].dos_errstr;
idx++;
@@ -114,6 +134,24 @@ const char *dos_errstr(WERROR werror)
return result;
}
+/*
+ Get friendly error string for WERRORs
+ */
+
+const char *get_friendly_werror_msg(WERROR werror)
+{
+ int i = 0;
+
+ for (i = 0; i ARRAY_SIZE(dos_err_strs); i++) {
+ if (W_ERROR_V(dos_err_strs[i].werror) ==
+W_ERROR_V(werror)) {
+ return dos_err_strs[i].friendly_errstr;
+ }
+ }
+
+ return dos_errstr(werror);
+}
+
/* compat function for samba4 */
const char *win_errstr(WERROR werror)
{
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-771-gb738381
The branch, v3-2-test has been updated
via b7383818168863a7ba43c2456f8c44e96e76707a (commit)
from 763e13315fc71237b14a186810bc201e725648f5 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit b7383818168863a7ba43c2456f8c44e96e76707a
Author: Günther Deschner [EMAIL PROTECTED]
Date: Fri Dec 21 15:12:40 2007 +0100
Kill fstring in getdcname getanydcname return.
Guenther
---
Summary of changes:
source/rpc_client/cli_netlogon.c | 14 --
source/rpcclient/cmd_netlogon.c |8
source/winbindd/winbindd_cm.c|4 ++--
source/winbindd/winbindd_misc.c |6 +++---
4 files changed, 17 insertions(+), 15 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/rpc_client/cli_netlogon.c b/source/rpc_client/cli_netlogon.c
index 3cb5827..26d2124 100644
--- a/source/rpc_client/cli_netlogon.c
+++ b/source/rpc_client/cli_netlogon.c
@@ -383,7 +383,7 @@ NTSTATUS rpccli_netlogon_logon_ctrl2(struct rpc_pipe_client
*cli, TALLOC_CTX *me
WERROR rpccli_netlogon_getanydcname(struct rpc_pipe_client *cli,
TALLOC_CTX *mem_ctx, const char *mydcname,
- const char *domainname, fstring newdcname)
+ const char *domainname, char **newdcname)
{
prs_struct qbuf, rbuf;
NET_Q_GETANYDCNAME q;
@@ -410,8 +410,9 @@ WERROR rpccli_netlogon_getanydcname(struct rpc_pipe_client
*cli,
result = r.status;
- if (W_ERROR_IS_OK(result)) {
- rpcstr_pull_unistr2_fstring(newdcname, r.uni_dcname);
+ if (W_ERROR_IS_OK(result) newdcname) {
+ *newdcname = rpcstr_pull_unistr2_talloc(mem_ctx, r.uni_dcname);
+ W_ERROR_HAVE_NO_MEMORY(*newdcname);
}
return result;
@@ -421,7 +422,7 @@ WERROR rpccli_netlogon_getanydcname(struct rpc_pipe_client
*cli,
WERROR rpccli_netlogon_getdcname(struct rpc_pipe_client *cli,
TALLOC_CTX *mem_ctx, const char *mydcname,
-const char *domainname, fstring newdcname)
+const char *domainname, char **newdcname)
{
prs_struct qbuf, rbuf;
NET_Q_GETDCNAME q;
@@ -448,8 +449,9 @@ WERROR rpccli_netlogon_getdcname(struct rpc_pipe_client
*cli,
result = r.status;
- if (W_ERROR_IS_OK(result)) {
- rpcstr_pull_unistr2_fstring(newdcname, r.uni_dcname);
+ if (W_ERROR_IS_OK(result) newdcname) {
+ *newdcname = rpcstr_pull_unistr2_talloc(mem_ctx, r.uni_dcname);
+ W_ERROR_HAVE_NO_MEMORY(*newdcname);
}
return result;
diff --git a/source/rpcclient/cmd_netlogon.c b/source/rpcclient/cmd_netlogon.c
index e997bb5..2c1f7e0 100644
--- a/source/rpcclient/cmd_netlogon.c
+++ b/source/rpcclient/cmd_netlogon.c
@@ -48,7 +48,7 @@ static WERROR cmd_netlogon_getanydcname(struct
rpc_pipe_client *cli,
TALLOC_CTX *mem_ctx, int argc,
const char **argv)
{
- fstring dcname;
+ char *dcname = NULL;
WERROR result = WERR_GENERAL_FAILURE;
int old_timeout;
@@ -60,7 +60,7 @@ static WERROR cmd_netlogon_getanydcname(struct
rpc_pipe_client *cli,
/* Make sure to wait for our DC's reply */
old_timeout = cli_set_timeout(cli-cli, MAX(cli-cli-timeout,3));
/* 30 seconds. */
- result = rpccli_netlogon_getanydcname(cli, mem_ctx, cli-cli-desthost,
argv[1], dcname);
+ result = rpccli_netlogon_getanydcname(cli, mem_ctx, cli-cli-desthost,
argv[1], dcname);
cli_set_timeout(cli-cli, old_timeout);
@@ -79,7 +79,7 @@ static WERROR cmd_netlogon_getdcname(struct rpc_pipe_client
*cli,
TALLOC_CTX *mem_ctx, int argc,
const char **argv)
{
- fstring dcname;
+ char *dcname = NULL;
WERROR result = WERR_GENERAL_FAILURE;
int old_timeout;
@@ -91,7 +91,7 @@ static WERROR cmd_netlogon_getdcname(struct rpc_pipe_client
*cli,
/* Make sure to wait for our DC's reply */
old_timeout = cli_set_timeout(cli-cli, MAX(cli-cli-timeout,3));
/* 30 seconds. */
- result = rpccli_netlogon_getdcname(cli, mem_ctx, cli-cli-desthost,
argv[1], dcname);
+ result = rpccli_netlogon_getdcname(cli, mem_ctx, cli-cli-desthost,
argv[1], dcname);
cli_set_timeout(cli-cli, old_timeout);
diff --git a/source/winbindd/winbindd_cm.c b/source/winbindd/winbindd_cm.c
index 8ea8155..7fb42a6 100644
--- a/source/winbindd/winbindd_cm.c
+++ b/source/winbindd/winbindd_cm.c
@@ -570,7 +570,7 @@ static bool get_dc_name_via_netlogon(const struct
winbindd_domain *domain,
WERROR werr;
TALLOC_CTX
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-819-g0c3de6f
The branch, v3-2-test has been updated via 0c3de6f3458419e57daaa71f1dad679897388f5a (commit) via 1e090654320ba3ce94d8114acaf931dbb2557a0c (commit) via 1489870f05695a929902264eb9b95eab886bdaa6 (commit) via cf57ade5ec4a808eccb19a7723d753742fb71ca9 (commit) via c502686f09713a7cf3786c254be6515a7aa23555 (commit) via c527a28c47f42617853cd28772ef46e5e6b058b6 (commit) via faedc78fc78527ee3bf05e1177ea43653aea67b2 (commit) via 5bc49546a32abb4524133b9f2916cdd51d4eb462 (commit) via e46aa35d432e930835206b9ce7583f46933015d8 (commit) via 4df868e3c366958c64ed8445489c8d1e8a28e50b (commit) via acc5d8e784b706001457ceeeb9bd4961a13d57d2 (commit) via b95801db595109e8eade7cf7c344f281c8684249 (commit) via c255654c68923aca3e258906e49be82d719d5ccd (commit) via a2c5beda2ec98dea8951fb3a37774f5f325410ef (commit) via 15c2bc15f20a677c3c94895150e396275de6ac9b (commit) via 1cad549f54563c3a9787624ba7a56b54107ebd57 (commit) via d1e4f9dd5cde79f915e3e0f652621d966aa850e8 (commit) via 465e61a3599a277366ada6ecda3a1e6ddb1f2490 (commit) via 74048fe7cfbd05994d533bea4a477d6ca93449d9 (commit) via 89e8abb1163984eed358a4da9be4699a8e3a43f9 (commit) via 96ebdca45b998da7e6137973dea717bf3ac76328 (commit) via 24605c9175fb313c9c888783817da755cd8ce594 (commit) via fbc60c1648ff8b1fa0ae33c09237e41232f9769c (commit) via 11e90dcbf5dd1a91118e6a5cee53735d72767c93 (commit) via f0e8d744c92d2602722e04be6266196941362d63 (commit) via 91b884989891881b8abea70e11b87c16c574daaa (commit) via e640c3a4a7695613e9e619516befbaf3d44ecb10 (commit) via 65d50f518766ab0a8115c2599d190e642eb00754 (commit) via 97449ea341539a709953a57869570cf13be0f44e (commit) via 78d8f0e41aa3db0060596a7b345c2f04261986e0 (commit) via 7c38f706b5dc17f15708ac932c84d863a0cc713e (commit) via 086c55005976b3173e915e465108214876aa5bd6 (commit) via a42850926a26a4065a6126affc3754d291a2e178 (commit) via c10481dba01a084b0f9c4265f3408a0ec9a8b646 (commit) via c818f5505a124a6f0bb9274a1ba4a6147d2f17b3 (commit) via 1d47247283f7bc75291007be3fde72b1d3d95b99 (commit) via 46db8754511f915c296771e08e822ba810f804d5 (commit) via 9f129c069f9feb357cbe1185058cfe3390609c09 (commit) via 07d33557b95106ac57fdef8c767ab86192930a6d (commit) via 9b0423e7d918b7b3837ca4ebf997edd80d4da6de (commit) via 4896f22bb50ea9ae0c4807ed9b2dd4283c254364 (commit) via fb6315b68b16d64625457881302fd191f90defa0 (commit) via 13c46b1407117c93b8f0275cc16ea5aa49596750 (commit) via d2f21ce6727ec9e4df67989db07b48470d0790a4 (commit) via 2b41ac926de76804a50681bd246b3a20e112853b (commit) via 8cbc6bdede9e8fc423488c7632546c548234cc0c (commit) via d341d251d6e22e9cc1c4596038fd5fe5c7c6c174 (commit) from b1ad3def98911c91ed55a3b7aec7d0894b2dd8fd (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit 0c3de6f3458419e57daaa71f1dad679897388f5a Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Dec 21 17:05:55 2007 +0100 Move libnetapi examples into subdirs. Guenther commit 1e090654320ba3ce94d8114acaf931dbb2557a0c Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Dec 21 16:49:33 2007 +0100 Gitignore some generated files. Guenther commit 1489870f05695a929902264eb9b95eab886bdaa6 Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Dec 21 16:44:52 2007 +0100 Deactive remote join code server side until some last issues are resolved. Guenther commit cf57ade5ec4a808eccb19a7723d753742fb71ca9 Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Dec 21 16:36:06 2007 +0100 Add netdomjoin-gui (my first gui application), another libnetapi user. Guenther commit c502686f09713a7cf3786c254be6515a7aa23555 Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Dec 21 16:08:13 2007 +0100 Add netdomjoin cmd line tool (another libnetapi example). Guenther commit c527a28c47f42617853cd28772ef46e5e6b058b6 Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Dec 21 16:03:12 2007 +0100 Make sure libnetapi has getdcname support. Guenther commit faedc78fc78527ee3bf05e1177ea43653aea67b2 Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Dec 21 16:02:35 2007 +0100 Add getdc.c, a libnetapi example (incl. Makefile). Guenther commit 5bc49546a32abb4524133b9f2916cdd51d4eb462 Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Dec 21 15:51:00 2007 +0100 Add basic remote NetGetDCName and NetGetAnyDCName versions to libnetapi. Guenther commit e46aa35d432e930835206b9ce7583f46933015d8 Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Dec 21 15:30:29 2007 +0100 Make libnetapi_errstr use our
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-820-g740a2b0
The branch, v3-2-test has been updated
via 740a2b080db56d504c4edd58bf41d72edb3d32ee (commit)
from 0c3de6f3458419e57daaa71f1dad679897388f5a (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit 740a2b080db56d504c4edd58bf41d72edb3d32ee
Author: Günther Deschner [EMAIL PROTECTED]
Date: Fri Dec 21 17:29:15 2007 +0100
Move gtk app to the correct location. Thanks obnox!
Guenther
---
Summary of changes:
.../netdomjoin-gui.c |0
1 files changed, 0 insertions(+), 0 deletions(-)
rename source/lib/netapi/examples/{netdomjoin =
netdomjoin-gui}/netdomjoin-gui.c (100%)
Changeset truncated at 500 lines:
diff --git a/source/lib/netapi/examples/netdomjoin/netdomjoin-gui.c
b/source/lib/netapi/examples/netdomjoin-gui/netdomjoin-gui.c
similarity index 100%
rename from source/lib/netapi/examples/netdomjoin/netdomjoin-gui.c
rename to source/lib/netapi/examples/netdomjoin-gui/netdomjoin-gui.c
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-821-gd6703f6
The branch, v3-2-test has been updated via d6703f6d4e6a5256980188f6a840e6aaf07bc607 (commit) from 740a2b080db56d504c4edd58bf41d72edb3d32ee (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit d6703f6d4e6a5256980188f6a840e6aaf07bc607 Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Dec 21 21:25:39 2007 +0100 Make sure libnet/libnet_proto.h exists. Guenther --- Summary of changes: source/Makefile.in |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/Makefile.in b/source/Makefile.in index f2b0bc6..b0b5c7c 100644 --- a/source/Makefile.in +++ b/source/Makefile.in @@ -1951,7 +1951,8 @@ clean: delheaders # afterwards. proto_exists: include/proto.h include/build_env.h \ winbindd/winbindd_proto.h web/swat_proto.h \ - client/client_proto.h utils/net_proto.h utils/ntlm_auth_proto.h smbd/build_options.c + client/client_proto.h utils/net_proto.h utils/ntlm_auth_proto.h smbd/build_options.c \ + libnet/libnet_proto.h @touch proto_exists delheaders: -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-833-g11acca7
The branch, v3-2-test has been updated via 11acca7d3884731491709dd09b7de2edc8bb5811 (commit) via c855de0c05e2e271e2610de67a6d7e3aba52390f (commit) via 351df194a927371600824f4c03d8a24b95fbef64 (commit) via b8310f427277640c7b2526d0c5cd84deecfd3e99 (commit) via 5159f897ddaad1878fff629cc074dd71b2b3f4ab (commit) via 832c093830cb3978641be3d87670fa900105da25 (commit) via 35a450b59501c6545083efc9f913cb626188f329 (commit) via 481cc9ab6a6608e13710c93783ea4e62363e78be (commit) via 290ab64e9e5fb2a28e14a5f344f22119d5304563 (commit) via 42787bccff4fcffafc7aae6a678e792604ecaaa5 (commit) via 83d274b46078a9ace77edb822a0e336c79dcf40e (commit) from ad87786c91709d62ee2cbd02c87e59b855e050cc (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit 11acca7d3884731491709dd09b7de2edc8bb5811 Merge: c855de0c05e2e271e2610de67a6d7e3aba52390f ad87786c91709d62ee2cbd02c87e59b855e050cc Author: Jeremy Allison [EMAIL PROTECTED] Date: Fri Dec 21 13:14:59 2007 -0800 Merge branch 'v3-2-test' of ssh://[EMAIL PROTECTED]/data/git/samba into v3-2-test Conflicts: source/library-versions.in commit c855de0c05e2e271e2610de67a6d7e3aba52390f Author: Jeremy Allison [EMAIL PROTECTED] Date: Fri Dec 21 12:50:39 2007 -0800 Actually fix the merge. Jeremy. commit 351df194a927371600824f4c03d8a24b95fbef64 Merge: b8310f427277640c7b2526d0c5cd84deecfd3e99 d6703f6d4e6a5256980188f6a840e6aaf07bc607 Author: Jeremy Allison [EMAIL PROTECTED] Date: Fri Dec 21 12:44:31 2007 -0800 Merge branch 'v3-2-test' of ssh://[EMAIL PROTECTED]/data/git/samba into v3-2-test Conflicts: source/Makefile.in commit b8310f427277640c7b2526d0c5cd84deecfd3e99 Author: Jeremy Allison [EMAIL PROTECTED] Date: Fri Dec 21 12:18:35 2007 -0800 Fix build failure if symlink already exists. Jeremy. commit 5159f897ddaad1878fff629cc074dd71b2b3f4ab Author: Jeremy Allison [EMAIL PROTECTED] Date: Fri Dec 21 12:18:17 2007 -0800 Fix const warning. Jeremy. commit 832c093830cb3978641be3d87670fa900105da25 Author: Jeremy Allison [EMAIL PROTECTED] Date: Fri Dec 21 12:11:23 2007 -0800 Fix initialization warnings. Jeremy. commit 35a450b59501c6545083efc9f913cb626188f329 Author: Jeremy Allison [EMAIL PROTECTED] Date: Fri Dec 21 12:06:37 2007 -0800 Fix making the new proto file after a distclean. Jeremy. commit 481cc9ab6a6608e13710c93783ea4e62363e78be Author: Gerald (Jerry) Carter [EMAIL PROTECTED] Date: Fri Dec 21 13:50:13 2007 -0600 Fix make test using the LD_LIBRARY_PATH for selftest script so smbd can locate the libwbclient library (if neccessary). commit 290ab64e9e5fb2a28e14a5f344f22119d5304563 Author: Gerald (Jerry) Carter [EMAIL PROTECTED] Date: Fri Dec 21 13:47:45 2007 -0600 Compile fix: Correct use of wbcDomainInfo() after function signature change. Also fixes a doxygen warngin about an undocumented parameter in the same function. commit 42787bccff4fcffafc7aae6a678e792604ecaaa5 Author: Gerald (Jerry) Carter [EMAIL PROTECTED] Date: Fri Dec 21 11:59:56 2007 -0600 De-couple smbd from staticly linking against winbindd client files. Implements a wrapper layer in winbind_util.c which are just stubs if compiled --without-winbind. When building with winbindd, it is now required to build the libwbclient DSO first (in the Makefile) and then either set LD_LIBRARY_PATH or /etc/ld.so.conf to pick up the library PATH. commit 83d274b46078a9ace77edb822a0e336c79dcf40e Author: Gerald (Jerry) Carter [EMAIL PROTECTED] Date: Fri Dec 21 11:57:34 2007 -0600 Add files for new LGPL libwbclient DSO implementing the Winbind client API (based on the winbind_struct_protocol.h). The API in incomplete, but sufficient to merge. See wbclienbt.h for the i interface functions. --- Summary of changes: source/Makefile.in | 174 ++-- source/auth/auth_util.c |6 +- source/configure.in | 22 +- source/exports/libwbclient.syms |4 + source/include/includes.h |1 + source/lib/socket_wrapper/socket_wrapper.c |2 +- source/lib/winbind_util.c | 324 ++ source/library-versions.in |1 + source/nsswitch/libwbclient/Doxyfile| 1297 +++ source/nsswitch/libwbclient/libwbclient.h | 46 + source/nsswitch/libwbclient/wbc_err.h | 51 + source/nsswitch/libwbclient/wbc_err_internal.h | 44 + source/nsswitch/libwbclient/wbc_idmap.c | 272 + source/nsswitch/libwbclient/wbc_pam.c | 65 ++ source/nsswitch/libwbclient/wbc_pwd.c
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-822-gad87786
The branch, v3-2-test has been updated
via ad87786c91709d62ee2cbd02c87e59b855e050cc (commit)
from d6703f6d4e6a5256980188f6a840e6aaf07bc607 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit ad87786c91709d62ee2cbd02c87e59b855e050cc
Author: Günther Deschner [EMAIL PROTECTED]
Date: Fri Dec 21 22:05:17 2007 +0100
Generate pkgconfig files for at least lib{smbclient,smbsharemodes,netapi}.
Guenther
---
Summary of changes:
source/configure.in |1 +
source/library-versions.in |3 +--
source/pkgconfig/netapi.pc.in| 14 ++
source/pkgconfig/smbclient.pc.in | 14 ++
source/pkgconfig/smbsharemodes.pc.in | 14 ++
5 files changed, 44 insertions(+), 2 deletions(-)
create mode 100644 source/pkgconfig/netapi.pc.in
create mode 100644 source/pkgconfig/smbclient.pc.in
create mode 100644 source/pkgconfig/smbsharemodes.pc.in
Changeset truncated at 500 lines:
diff --git a/source/configure.in b/source/configure.in
index a9053d9..04891ae 100644
--- a/source/configure.in
+++ b/source/configure.in
@@ -6606,6 +6606,7 @@ AC_SUBST(SMBD_LIBS)
AC_OUTPUT(Makefile library-versions
script/findsmb smbadduser script/gen-8bit-gap.sh script/installbin.sh
script/uninstallbin.sh
lib/netapi/examples/Makefile
+ pkgconfig/smbclient.pc pkgconfig/netapi.pc pkgconfig/smbsharemodes.pc
)
#
diff --git a/source/library-versions.in b/source/library-versions.in
index cd4d621..9c10da5 100644
--- a/source/library-versions.in
+++ b/source/library-versions.in
@@ -5,5 +5,4 @@
bin/[EMAIL PROTECTED]@:0:1
bin/[EMAIL PROTECTED]@:0:2
bin/[EMAIL PROTECTED]@:0:1
-bin/[EMAIL PROTECTED]@:0:1
-
+bin/[EMAIL PROTECTED]@:0:1
diff --git a/source/pkgconfig/netapi.pc.in b/source/pkgconfig/netapi.pc.in
new file mode 100644
index 000..b1f60b2
--- /dev/null
+++ b/source/pkgconfig/netapi.pc.in
@@ -0,0 +1,14 @@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
+
+Name: Samba libnetapi
+Description: A library to control CIFS servers
+Version: 0
+URL: http://www.samba.org/
+#Libs: [EMAIL PROTECTED]@ -lnetapi
+Libs: -lnetapi
+Libs.private: -lnetapi @KRB5_LIBS@ @LDAP_LIBS@ @LIBS@
+Cflags: [EMAIL PROTECTED]@
+
diff --git a/source/pkgconfig/smbclient.pc.in b/source/pkgconfig/smbclient.pc.in
new file mode 100644
index 000..969abbe
--- /dev/null
+++ b/source/pkgconfig/smbclient.pc.in
@@ -0,0 +1,14 @@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
+
+Name: Samba libsmbclient
+Description: A library to access CIFS servers
+Version: 0
+URL: http://www.samba.org/
+#Libs: [EMAIL PROTECTED]@ -lsmbclient
+Libs: -lsmbclient
+Libs.private: -lsmbclient @KRB5_LIBS@ @LDAP_LIBS@ @LIBS@
+Cflags: [EMAIL PROTECTED]@
+
diff --git a/source/pkgconfig/smbsharemodes.pc.in
b/source/pkgconfig/smbsharemodes.pc.in
new file mode 100644
index 000..dcb0d2e
--- /dev/null
+++ b/source/pkgconfig/smbsharemodes.pc.in
@@ -0,0 +1,14 @@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
+
+Name: Samba libsmbsharemodes
+Description: A library
+Version: 0
+URL: http://www.samba.org/
+#Libs: [EMAIL PROTECTED]@ -lsmbsharemodes
+Libs: -lsmbsharemodes
+Libs.private: -lsmbsharemodes @KRB5_LIBS@ @LDAP_LIBS@ @LIBS@
+Cflags: [EMAIL PROTECTED]@
+
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-834-gabba671
The branch, v3-2-test has been updated via abba6717b5da709ae9cf3097042228ddbe630cca (commit) from 11acca7d3884731491709dd09b7de2edc8bb5811 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit abba6717b5da709ae9cf3097042228ddbe630cca Author: Jeremy Allison [EMAIL PROTECTED] Date: Fri Dec 21 13:42:47 2007 -0800 Fix make test by adding winbind libs to vlp. Jeremy. --- Summary of changes: source/Makefile.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/Makefile.in b/source/Makefile.in index e1f516f..74bae89 100644 --- a/source/Makefile.in +++ b/source/Makefile.in @@ -1534,7 +1534,7 @@ bin/[EMAIL PROTECTED]@: $(BINARY_PREREQS) $(WINBINDD_OBJ) @BUILD_POPT@ @LIBWBCLIEN bin/[EMAIL PROTECTED]@: $(BINARY_PREREQS) $(VLP_OBJ) @echo Linking $@ @$(CC) $(FLAGS) -o $@ $(VLP_OBJ) $(LDFLAGS) $(DYNEXP) $(TERMLDFLAGS) $(TERMLIBS) $(LIBS) @POPTLIBS@ \ - $(KRB5LIBS) $(LDAP_LIBS) $(NSCD_LIBS) + $(KRB5LIBS) $(LDAP_LIBS) $(NSCD_LIBS) @LIBWBCLIENT_SHARED@ @WINBIND_NSS@: $(BINARY_PREREQS) $(WINBIND_NSS_OBJ) @echo Linking $@ -- Samba Shared Repository
svn commit: samba r26557 - in branches/SAMBA_4_0: .
Author: abartlet Date: 2007-12-21 22:55:02 + (Fri, 21 Dec 2007) New Revision: 26557 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26557 Log: sync WHATSNEW with release branch of Samba4 Modified: branches/SAMBA_4_0/WHATSNEW.txt Changeset: Modified: branches/SAMBA_4_0/WHATSNEW.txt === --- branches/SAMBA_4_0/WHATSNEW.txt 2007-12-21 02:33:43 UTC (rev 26556) +++ branches/SAMBA_4_0/WHATSNEW.txt 2007-12-21 22:55:02 UTC (rev 26557) @@ -1,4 +1,4 @@ -What's new in Samba 4 alpha1 +What's new in Samba 4 alpha2 Samba 4 is the ambitious next version of the Samba suite that is being @@ -10,17 +10,14 @@ production environments. Note the WARNINGS below, and the STATUS file, which aims to document what should and should not work. -Samba4 alpha1 is the culmination of 4.5 years of development under our -belt since Tridge first proposed a new Virtual File System (VFS) layer -for Samba3 (a project which eventually lead to our Active Directory -efforts), and 1.5 years since we first released a Technology Preview, -we wish to allow users, managers and developers to see how we have -progressed, and to invite feedback and support. +Samba4 alpha2 follows on from our first alpha release, made in +September, and the Technology Preview series we have offered for some +time now. WARNINGS -Samba4 alpha1 is not a final Samba release. That is more a reference +Samba4 alpha2 is not a final Samba release. That is more a reference to Samba4's lack of the features we expect you will need than a statement of code quality, but clearly it hasn't seen a broad deployment yet. If you were to upgrade Samba3 (or indeed Windows) to @@ -58,7 +55,7 @@ VFS is backed with an extensive automated test suite. A new scripting interface has been added to Samba 4, allowing -JavaScript programs to interface to Samba's internals. +Python programs to interface to Samba's internals. The Samba 4 architecture is based around an LDAP-like database that can use a range of modular backends. One of the backends supports @@ -67,27 +64,27 @@ We are aiming for Samba 4 to be powerful frontend to large directories. -CHANGES SINCE TP5 -= +CHANGES SINCE Alpha 1 += -In the time since TP5 was released in June 2007, Samba has +In the time since Samba4 Alpha1 was released in September 2007, Samba has continued to evolve, but you may particularly notice these areas: - Group Policy Support: Basic group policies may be defined, and are - enforced by Windows clients - MMC Support: The Active Directory Users and Computers console now - works, supporting most operations. + handles group membership correctly. - Winbind: Kai Blin has been working hard on his Google Summer of - Code project, creating a winbind implementation for Samba4. + member/memberOf: These and other linked attributes are now kept in + sync - Heimdal update: A Heimdal 1.0 snapshot is now included as the - internal Kerberos library in Samba4. + subtree renames: Renaming a subtree of LDAP objects is now possible, + with all linked attributes being kept consistant. - In the past few weeks, many small but significant bugs have been - fixed, particularly thanks to Matthias Dieter Wallnöfer [EMAIL PROTECTED] + Python Bindings: Bindings for a future move to Python as the + internal scripting language have been created. + Shared library use: In support of projects such as OpenChange, + which depend on Samba4, more of Samba4 is built as shared libraries. + These are just some of the highlights of the work done in the past few months. More details can be found in our SVN history. @@ -106,12 +103,6 @@ - There is no printing support in the current release. -- Support for managing groups is currently poor (as the - memberOf/member linked attributes are not kept in sync). - -- Renaming and deleting subtrees (containers) in the the LDB tree will - have unexpected results. - - The Samba4 port of the CTDB clustering support is not yet complete - Clock Synchronisation is critical. Many 'wrong password' errors are
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-836-g035fada
The branch, v3-2-test has been updated
via 035fadaa596e893b7eeac09bc587ad3b73f77d0b (commit)
from bf3ffbb5d2e8588e0041f0b890b590c58f8fcecf (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit 035fadaa596e893b7eeac09bc587ad3b73f77d0b
Author: Jeremy Allison [EMAIL PROTECTED]
Date: Fri Dec 21 14:38:52 2007 -0800
Fix install - it was trying to install libnetapi.h whereas
the actual file is netapi.h. Guenther please check which
name this should be !
Jeremy.
---
Summary of changes:
source/Makefile.in |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/Makefile.in b/source/Makefile.in
index 74bae89..3f7c857 100644
--- a/source/Makefile.in
+++ b/source/Makefile.in
@@ -1888,7 +1888,7 @@ installlibnetapi: installdirs libnetapi
@$(SHELL) $(srcdir)/script/installdirs.sh $(INSTALLPERMS_BIN)
$(DESTDIR) $(LIBDIR)
-$(INSTALLLIBCMD_SH) bin/[EMAIL PROTECTED]@ $(DESTDIR)$(LIBDIR)
-$(INSTALLLIBCMD_A) bin/libnetapi.a $(DESTDIR)$(LIBDIR)
- -$(INSTALLCMD) -m $(INSTALLPERMS_DATA) $(srcdir)/lib/netapi/libnetapi.h
$(DESTDIR)${prefix}/include
+ -$(INSTALLCMD) -m $(INSTALLPERMS_DATA) $(srcdir)/lib/netapi/netapi.h
$(DESTDIR)${prefix}/include
installpammodules: $(PAM_MODULES)
@$(SHELL) $(srcdir)/script/installdirs.sh $(INSTALLPERMS_BIN)
$(DESTDIR) $(PAMMODULESDIR)
@@ -1977,7 +1977,7 @@ uninstalllibaddns:
uninstalllibnetapi:
-$(UNINSTALLLIBCMD_SH) $(DESTDIR)$(LIBDIR)/[EMAIL PROTECTED]@
-$(UNINSTALLLIBCMD_A) $(DESTDIR)$(LIBDIR)/libnetapi.a
- -rm -f $(DESTDIR)${prefix}/include/libnetapi.h
+ -rm -f $(DESTDIR)${prefix}/include/netapi.h
uninstallpammodules:
@for module in $(PAM_MODULES); do \
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-835-gbf3ffbb
The branch, v3-2-test has been updated
via bf3ffbb5d2e8588e0041f0b890b590c58f8fcecf (commit)
from abba6717b5da709ae9cf3097042228ddbe630cca (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit bf3ffbb5d2e8588e0041f0b890b590c58f8fcecf
Author: Günther Deschner [EMAIL PROTECTED]
Date: Fri Dec 21 23:04:26 2007 +0100
Until we better understand the WKSSVC_JOIN_FLAGS_JOIN_DC_ACCOUNT make sure
we are
not joining as a DC.
Guenther
---
Summary of changes:
source/libnet/libnet_join.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/libnet/libnet_join.c b/source/libnet/libnet_join.c
index b1ebed3..c1ff8bb 100644
--- a/source/libnet/libnet_join.c
+++ b/source/libnet/libnet_join.c
@@ -530,6 +530,10 @@ WERROR libnet_Join(TALLOC_CTX *mem_ctx,
return WERR_NOT_SUPPORTED;
}
+ if (IS_DC) {
+ return WERR_SETUP_DOMAIN_CONTROLLER;
+ }
+
if (r-in.join_flags WKSSVC_JOIN_FLAGS_JOIN_TYPE) {
status = do_DomainJoin(mem_ctx, r);
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-838-gc890ebc
The branch, v3-2-test has been updated
via c890ebc3cad7222007e62227ec1f28d978310cbf (commit)
from f192737ec8140aa6570bfb49a165b31890d63b16 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit c890ebc3cad7222007e62227ec1f28d978310cbf
Author: Günther Deschner [EMAIL PROTECTED]
Date: Sat Dec 22 00:12:59 2007 +0100
Fix uninitialized error code in do_unjoin_modify_vals_config().
Guenther
---
Summary of changes:
source/libnet/libnet_join.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/libnet/libnet_join.c b/source/libnet/libnet_join.c
index c1ff8bb..2994c3f 100644
--- a/source/libnet/libnet_join.c
+++ b/source/libnet/libnet_join.c
@@ -390,7 +390,7 @@ static WERROR do_unjoin_modify_vals_config(TALLOC_CTX
*mem_ctx,
struct libnet_UnjoinCtx *r,
struct registry_key *key)
{
- WERROR werr;
+ WERROR werr = WERR_OK;
if (r-in.unjoin_flags WKSSVC_JOIN_FLAGS_JOIN_TYPE) {
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-837-gf192737
The branch, v3-2-test has been updated
via f192737ec8140aa6570bfb49a165b31890d63b16 (commit)
from 035fadaa596e893b7eeac09bc587ad3b73f77d0b (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit f192737ec8140aa6570bfb49a165b31890d63b16
Author: Günther Deschner [EMAIL PROTECTED]
Date: Sat Dec 22 00:02:45 2007 +0100
Correct netapi header filename. Thanks Jeremy.
Guenther
---
Summary of changes:
source/lib/netapi/examples/getdc/getdc.c |2 +-
.../examples/netdomjoin-gui/netdomjoin-gui.c |2 +-
source/lib/netapi/examples/netdomjoin/netdomjoin.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/lib/netapi/examples/getdc/getdc.c
b/source/lib/netapi/examples/getdc/getdc.c
index ed6a8bd..4f5c533 100644
--- a/source/lib/netapi/examples/getdc/getdc.c
+++ b/source/lib/netapi/examples/getdc/getdc.c
@@ -23,7 +23,7 @@
#include stdlib.h
#include string.h
-#include libnetapi.h
+#include netapi.h
int main(int argc, char **argv)
{
diff --git a/source/lib/netapi/examples/netdomjoin-gui/netdomjoin-gui.c
b/source/lib/netapi/examples/netdomjoin-gui/netdomjoin-gui.c
index 8ca6897..beb12be 100644
--- a/source/lib/netapi/examples/netdomjoin-gui/netdomjoin-gui.c
+++ b/source/lib/netapi/examples/netdomjoin-gui/netdomjoin-gui.c
@@ -28,7 +28,7 @@
#include gtk/gtk.h
#include glib/gprintf.h
-#include libnetapi.h
+#include netapi.h
#define MAX_CRED_LEN 256
#define MAX_NETBIOS_NAME_LEN 15
diff --git a/source/lib/netapi/examples/netdomjoin/netdomjoin.c
b/source/lib/netapi/examples/netdomjoin/netdomjoin.c
index a2bb700..e8b5299 100644
--- a/source/lib/netapi/examples/netdomjoin/netdomjoin.c
+++ b/source/lib/netapi/examples/netdomjoin/netdomjoin.c
@@ -23,7 +23,7 @@
#include stdlib.h
#include string.h
-#include libnetapi.h
+#include netapi.h
char *get_string_param(const char *param)
{
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-839-g6dd17e4
The branch, v3-2-test has been updated
via 6dd17e4840ee6c4bf0df3c3f76f9b232b3674d55 (commit)
from c890ebc3cad7222007e62227ec1f28d978310cbf (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit 6dd17e4840ee6c4bf0df3c3f76f9b232b3674d55
Author: Günther Deschner [EMAIL PROTECTED]
Date: Sat Dec 22 00:34:30 2007 +0100
Fix net_dom_join net_dom_unjoin.
Guenther
---
Summary of changes:
source/utils/net_dom.c | 57
1 files changed, 38 insertions(+), 19 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/utils/net_dom.c b/source/utils/net_dom.c
index 7b5f562..3a8338e 100644
--- a/source/utils/net_dom.c
+++ b/source/utils/net_dom.c
@@ -43,6 +43,7 @@ int net_help_dom(int argc, const char **argv)
static int net_dom_unjoin(int argc, const char **argv)
{
+ struct libnetapi_ctx *ctx = NULL;
const char *server_name = NULL;
const char *account = NULL;
const char *password = NULL;
@@ -50,8 +51,8 @@ static int net_dom_unjoin(int argc, const char **argv)
WKSSVC_JOIN_FLAGS_JOIN_TYPE;
struct cli_state *cli = NULL;
bool reboot = false;
- NTSTATUS status;
- NET_API_STATUS werr;
+ NTSTATUS ntstatus;
+ NET_API_STATUS status;
int ret = -1;
int i;
@@ -82,17 +83,25 @@ static int net_dom_unjoin(int argc, const char **argv)
}
if (reboot) {
- status = net_make_ipc_connection_ex(opt_workgroup, server_name,
- NULL, 0, cli);
- if (!NT_STATUS_IS_OK(status)) {
+ ntstatus = net_make_ipc_connection_ex(opt_workgroup,
server_name,
+ NULL, 0, cli);
+ if (!NT_STATUS_IS_OK(ntstatus)) {
return -1;
}
}
- werr = NetUnjoinDomain(server_name, account, password, unjoin_flags);
- if (werr != 0) {
+ status = libnetapi_init(ctx);
+ if (status != 0) {
+ return -1;
+ }
+
+ libnetapi_set_username(ctx, opt_user_name);
+ libnetapi_set_password(ctx, opt_password);
+
+ status = NetUnjoinDomain(server_name, account, password, unjoin_flags);
+ if (status != 0) {
printf(Failed to unjoin domain: %s\n,
-
get_friendly_nt_error_msg(werror_to_ntstatus(W_ERROR(werr;
+ libnetapi_errstr(ctx, status));
goto done;
}
@@ -121,11 +130,13 @@ static int net_dom_unjoin(int argc, const char **argv)
cli_shutdown(cli);
}
+ /* libnetapi_free(ctx); */
return ret;
}
static int net_dom_join(int argc, const char **argv)
{
+ struct libnetapi_ctx *ctx = NULL;
const char *server_name = NULL;
const char *domain_name = NULL;
const char *account_ou = NULL;
@@ -135,8 +146,8 @@ static int net_dom_join(int argc, const char **argv)
WKSSVC_JOIN_FLAGS_JOIN_TYPE;
struct cli_state *cli = NULL;
bool reboot = false;
- NTSTATUS status;
- NET_API_STATUS werr;
+ NTSTATUS ntstatus;
+ NET_API_STATUS status;
int ret = -1;
int i;
@@ -183,21 +194,28 @@ static int net_dom_join(int argc, const char **argv)
}
if (reboot) {
- status = net_make_ipc_connection_ex(opt_workgroup, server_name,
- NULL, 0, cli);
- if (!NT_STATUS_IS_OK(status)) {
+ ntstatus = net_make_ipc_connection_ex(opt_workgroup,
server_name,
+ NULL, 0, cli);
+ if (!NT_STATUS_IS_OK(ntstatus)) {
return -1;
}
}
/* check if domain is a domain or a workgroup */
- werr = NetJoinDomain(server_name, domain_name, account_ou,
-Account, password, join_flags);
- if (werr != 0) {
- printf(Failed to join domain: %s (WERROR: %s)\n,
-
get_friendly_nt_error_msg(werror_to_ntstatus(W_ERROR(werr))),
- dos_errstr(W_ERROR(werr)));
+ status = libnetapi_init(ctx);
+ if (status != 0) {
+ return -1;
+ }
+
+ libnetapi_set_username(ctx, opt_user_name);
+ libnetapi_set_password(ctx, opt_password);
+
+ status = NetJoinDomain(server_name, domain_name, account_ou,
+ Account, password, join_flags);
+ if (status != 0) {
+ printf(Failed to join domain: %s\n,
+ libnetapi_errstr(ctx, status));
goto done;
Build status as of Sat Dec 22 00:00:02 2007
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2007-12-21 00:00:46.0 + +++ /home/build/master/cache/broken_results.txt 2007-12-22 00:00:58.0 + @@ -1,4 +1,4 @@ -Build status as of Fri Dec 21 00:00:02 2007 +Build status as of Sat Dec 22 00:00:02 2007 Build counts: Tree Total Broken Panic @@ -8,7 +8,7 @@ ctdb 0 0 0 distcc 1 0 0 ldb 29 14 0 -libreplace 28 15 0 +libreplace 28 14 0 lorikeet-heimdal 25 15 0 pidl 18 5 0 ppp 10 8 0 @@ -16,10 +16,10 @@ rsync29 11 0 samba-docs 0 0 0 samba-gtk4 4 0 -samba4 26 19 3 +samba4 26 22 2 samba_3_21 0 0 -samba_3_2_test 27 16 0 +samba_3_2_test 27 25 0 smb-build27 26 0 talloc 29 12 0 -tdb 29 6 0 +tdb 29 5 0
svn commit: samba r26558 - in branches/SAMBA_4_0/source: librpc/idl rpc_server/netlogon
Author: gd
Date: 2007-12-21 23:52:14 + (Fri, 21 Dec 2007)
New Revision: 26558
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26558
Log:
Add IDL for netr_GetForestTrustInformation().
Guenther
Modified:
branches/SAMBA_4_0/source/librpc/idl/netlogon.idl
branches/SAMBA_4_0/source/rpc_server/netlogon/dcerpc_netlogon.c
Changeset:
Modified: branches/SAMBA_4_0/source/librpc/idl/netlogon.idl
===
--- branches/SAMBA_4_0/source/librpc/idl/netlogon.idl 2007-12-21 22:55:02 UTC
(rev 26557)
+++ branches/SAMBA_4_0/source/librpc/idl/netlogon.idl 2007-12-21 23:52:14 UTC
(rev 26558)
@@ -1294,7 +1294,14 @@
//
/* Function 0x2c */
- WERROR netr_NETRGETFORESTTRUSTINFORMATION();
+ WERROR netr_GetForestTrustInformation(
+ [in] [string,charset(UTF16)] uint16 *server_name,
+ [in,ref] [string,charset(UTF16)] uint16 *trusted_domain_name,
+ [in,ref] netr_Authenticator *credential,
+ [out,ref] netr_Authenticator *return_authenticator,
+ [in] uint32 flags,
+ [out,ref] lsa_ForestTrustInformation **forest_trust_info
+ );
//
/* Function 0x2d */
Modified: branches/SAMBA_4_0/source/rpc_server/netlogon/dcerpc_netlogon.c
===
--- branches/SAMBA_4_0/source/rpc_server/netlogon/dcerpc_netlogon.c
2007-12-21 22:55:02 UTC (rev 26557)
+++ branches/SAMBA_4_0/source/rpc_server/netlogon/dcerpc_netlogon.c
2007-12-21 23:52:14 UTC (rev 26558)
@@ -1237,11 +1237,11 @@
}
-/*
- netr_NETRGETFORESTTRUSTINFORMATION
+/*
+ netr_GetForestTrustInformation
*/
-static WERROR dcesrv_netr_NETRGETFORESTTRUSTINFORMATION(struct
dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
- struct netr_NETRGETFORESTTRUSTINFORMATION *r)
+static WERROR dcesrv_netr_GetForestTrustInformation(struct dcesrv_call_state
*dce_call, TALLOC_CTX *mem_ctx,
+ struct netr_GetForestTrustInformation *r)
{
DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
}
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-840-gb4a4a2b
The branch, v3-2-test has been updated via b4a4a2b2933d693876b67231f747e1e232936054 (commit) from 6dd17e4840ee6c4bf0df3c3f76f9b232b3674d55 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit b4a4a2b2933d693876b67231f747e1e232936054 Author: Günther Deschner [EMAIL PROTECTED] Date: Sat Dec 22 01:13:53 2007 +0100 Fix the build of cifs.spnego. Guenther --- Summary of changes: source/Makefile.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/Makefile.in b/source/Makefile.in index 3f7c857..d3b990e 100644 --- a/source/Makefile.in +++ b/source/Makefile.in @@ -1236,7 +1236,7 @@ bin/[EMAIL PROTECTED]@: $(BINARY_PREREQS) $(CIFS_UMOUNT_OBJ) @BUILD_POPT@ bin/[EMAIL PROTECTED]@: $(BINARY_PREREQS) $(CIFS_SPNEGO_OBJ) $(LIBSMBCLIENT_OBJ) @BUILD_POPT@ @echo Linking $@ @$(CC) $(FLAGS) -o $@ $(CIFS_SPNEGO_OBJ) $(DYNEXP) $(LDFLAGS) -lkeyutils $(LIBS) \ - $(LIBSMBCLIENT_OBJ) $(KRB5LIBS) $(LDAP_LIBS) @POPTLIBS@ + $(LIBSMBCLIENT_OBJ) $(KRB5LIBS) $(LDAP_LIBS) @POPTLIBS@ @LIBWBCLIENT_SHARED@ bin/[EMAIL PROTECTED]@: $(BINARY_PREREQS) $(TESTPARM_OBJ) @BUILD_POPT@ @echo Linking $@ -- Samba Shared Repository
svn commit: samba r26561 - in branches/SAMBA_4_0: . source/script source/selftest
Author: jelmer
Date: 2007-12-22 00:47:48 + (Sat, 22 Dec 2007)
New Revision: 26561
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26561
Log:
Fix make gdbtest, valgrindtest and testenv for shared libs.
Added:
branches/SAMBA_4_0/source/selftest/test_subunit.pl
Modified:
branches/SAMBA_4_0/
branches/SAMBA_4_0/source/script/gdb_run
branches/SAMBA_4_0/source/script/valgrind_run
branches/SAMBA_4_0/source/selftest/config.mk
branches/SAMBA_4_0/source/selftest/selftest.pl
Changeset:
Property changes on: branches/SAMBA_4_0
___
Name: bzr:revision-info
...skipped...
Name: bzr:file-ids
...skipped...
Name: bzr:revision-id:v3-trunk0
...skipped...
Modified: branches/SAMBA_4_0/source/script/gdb_run
===
--- branches/SAMBA_4_0/source/script/gdb_run2007-12-22 00:47:44 UTC (rev
26560)
+++ branches/SAMBA_4_0/source/script/gdb_run2007-12-22 00:47:48 UTC (rev
26561)
@@ -1,5 +1,9 @@
#!/bin/sh
+ENV=$1
+
+shift 1
+
if test -z $TMPDIR; then
TMPDIR=/tmp
fi
@@ -13,4 +17,4 @@
trap /bin/rm -f $TMPFILE EXIT
CMD=gdb -x $TMPFILE --args $@
echo $CMD
-eval $CMD
+eval $ENV $CMD
Modified: branches/SAMBA_4_0/source/script/valgrind_run
===
--- branches/SAMBA_4_0/source/script/valgrind_run 2007-12-22 00:47:44 UTC
(rev 26560)
+++ branches/SAMBA_4_0/source/script/valgrind_run 2007-12-22 00:47:48 UTC
(rev 26561)
@@ -1,2 +1,7 @@
#!/bin/sh
-valgrind -q --db-attach=yes --num-callers=30 $@
+
+ENV=$1
+
+shift 1
+
+$ENV valgrind -q --db-attach=yes --num-callers=30 $@
Modified: branches/SAMBA_4_0/source/selftest/config.mk
===
--- branches/SAMBA_4_0/source/selftest/config.mk2007-12-22 00:47:44 UTC
(rev 26560)
+++ branches/SAMBA_4_0/source/selftest/config.mk2007-12-22 00:47:48 UTC
(rev 26561)
@@ -37,32 +37,32 @@
valgrindtest: valgrindtest-all
valgrindtest-quick: all
- SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/valgrind_run \
+ SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/valgrind_run
$(LD_LIBPATH_OVERRIDE) \
VALGRIND=valgrind -q --num-callers=30
--log-file=${selftest_prefix}/valgrind.log \
$(SELFTEST) --quick --immediate --socket-wrapper $(TESTS)
valgrindtest-all: everything
- SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/valgrind_run \
+ SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/valgrind_run
$(LD_LIBPATH_OVERRIDE) \
VALGRIND=valgrind -q --num-callers=30
--log-file=${selftest_prefix}/valgrind.log \
$(SELFTEST) --immediate --socket-wrapper $(TESTS)
valgrindtest-env: everything
- SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/valgrind_run \
+ SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/valgrind_run
$(LD_LIBPATH_OVERRIDE) \
VALGRIND=valgrind -q --num-callers=30
--log-file=${selftest_prefix}/valgrind.log \
$(SELFTEST) --socket-wrapper --testenv
gdbtest: gdbtest-all
gdbtest-quick: all
- SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/gdb_run \
+ SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/gdb_run
$(LD_LIBPATH_OVERRIDE) \
$(SELFTEST) --immediate --quick --socket-wrapper $(TESTS)
gdbtest-all: everything
- SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/gdb_run \
+ SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/gdb_run
$(LD_LIBPATH_OVERRIDE) \
$(SELFTEST) --immediate --socket-wrapper $(TESTS)
gdbtest-env: everything
- SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/gdb_run \
+ SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/gdb_run
$(LD_LIBPATH_OVERRIDE) \
$(SELFTEST) --socket-wrapper --testenv
wintest: all
Modified: branches/SAMBA_4_0/source/selftest/selftest.pl
===
--- branches/SAMBA_4_0/source/selftest/selftest.pl 2007-12-22 00:47:44 UTC
(rev 26560)
+++ branches/SAMBA_4_0/source/selftest/selftest.pl 2007-12-22 00:47:48 UTC
(rev 26561)
@@ -539,7 +539,6 @@
close(CF);
}
-
my @torture_options = ();
push (@torture_options, --configfile=$conffile);
# ensure any one smbtorture call doesn't run too long
@@ -769,7 +768,7 @@
CONFIGURATION=\$CONFIGURATION
$envvarstr
-\ bash');
+\ LD_LIBRARY_PATH=$ENV{LD_LIBRARY_PATH} bash');
teardown_env($testenv_name);
} else {
foreach (@todo) {
Added: branches/SAMBA_4_0/source/selftest/test_subunit.pl
===
--- branches/SAMBA_4_0/source/selftest/test_subunit.pl 2007-12-22 00:47:44 UTC
(rev 26560)
+++ branches/SAMBA_4_0/source/selftest/test_subunit.pl 2007-12-22 00:47:48 UTC
(rev 26561)
@@ -0,0 +1,7 @@
+#!/usr/bin/perl
+
+use Test::More tests = 0;
+use FindBin qw($RealBin);
+use lib $RealBin;
svn commit: samba r26560 - in branches/SAMBA_4_0: . source source/script source/selftest
Author: jelmer
Date: 2007-12-22 00:47:44 + (Sat, 22 Dec 2007)
New Revision: 26560
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26560
Log:
Add script for running in valgrind.
Added:
branches/SAMBA_4_0/source/script/valgrind_run
Modified:
branches/SAMBA_4_0/
branches/SAMBA_4_0/source/main.mk
branches/SAMBA_4_0/source/selftest/config.mk
Changeset:
Property changes on: branches/SAMBA_4_0
___
Name: bzr:revision-info
...skipped...
Name: bzr:file-ids
...skipped...
Name: bzr:revision-id:v3-trunk0
...skipped...
Modified: branches/SAMBA_4_0/source/main.mk
===
--- branches/SAMBA_4_0/source/main.mk 2007-12-22 00:47:36 UTC (rev 26559)
+++ branches/SAMBA_4_0/source/main.mk 2007-12-22 00:47:44 UTC (rev 26560)
@@ -43,6 +43,8 @@
all: showflags $(ALL_PREDEP) bin/asn1_compile bin/compile_et binaries modules
pythonmods
everything: all libraries headers
+LD_LIBPATH_OVERRIDE = $(LIB_PATH_VAR)=$(builddir)/bin/shared
+
# 'make testsuite' creates all binaries which are
# needed by samba3's 'make test' and the build-farm
# scripts use that it as fallback in case
Added: branches/SAMBA_4_0/source/script/valgrind_run
===
--- branches/SAMBA_4_0/source/script/valgrind_run 2007-12-22 00:47:36 UTC
(rev 26559)
+++ branches/SAMBA_4_0/source/script/valgrind_run 2007-12-22 00:47:44 UTC
(rev 26560)
@@ -0,0 +1,2 @@
+#!/bin/sh
+valgrind -q --db-attach=yes --num-callers=30 $@
Modified: branches/SAMBA_4_0/source/selftest/config.mk
===
--- branches/SAMBA_4_0/source/selftest/config.mk2007-12-22 00:47:36 UTC
(rev 26559)
+++ branches/SAMBA_4_0/source/selftest/config.mk2007-12-22 00:47:44 UTC
(rev 26560)
@@ -1,6 +1,6 @@
TEST_FORMAT = plain
-SELFTEST = $(LIB_PATH_VAR)=$(builddir)/bin/shared $(PERL)
$(srcdir)/selftest/selftest.pl --prefix=${selftest_prefix} \
+SELFTEST = $(LD_LIBPATH_OVERRIDE) $(PERL) $(srcdir)/selftest/selftest.pl
--prefix=${selftest_prefix} \
--builddir=$(builddir) --srcdir=$(srcdir) \
--expected-failures=$(srcdir)/samba4-knownfail \
--format=$(TEST_FORMAT) \
@@ -37,17 +37,17 @@
valgrindtest: valgrindtest-all
valgrindtest-quick: all
- SMBD_VALGRIND=xterm -n smbd -e valgrind -q --db-attach=yes
--num-callers=30 \
+ SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/valgrind_run \
VALGRIND=valgrind -q --num-callers=30
--log-file=${selftest_prefix}/valgrind.log \
$(SELFTEST) --quick --immediate --socket-wrapper $(TESTS)
valgrindtest-all: everything
- SMBD_VALGRIND=xterm -n smbd -e valgrind -q --db-attach=yes
--num-callers=30 \
+ SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/valgrind_run \
VALGRIND=valgrind -q --num-callers=30
--log-file=${selftest_prefix}/valgrind.log \
$(SELFTEST) --immediate --socket-wrapper $(TESTS)
valgrindtest-env: everything
- SMBD_VALGRIND=xterm -n smbd -e valgrind -q --db-attach=yes
--num-callers=30 \
+ SMBD_VALGRIND=xterm -n smbd -e $(srcdir)/script/valgrind_run \
VALGRIND=valgrind -q --num-callers=30
--log-file=${selftest_prefix}/valgrind.log \
$(SELFTEST) --socket-wrapper --testenv
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-841-ga1482b0
The branch, v3-2-test has been updated
via a1482b09150f4d292965c77bc73d47fb14f5eb85 (commit)
from b4a4a2b2933d693876b67231f747e1e232936054 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit a1482b09150f4d292965c77bc73d47fb14f5eb85
Author: Jeremy Allison [EMAIL PROTECTED]
Date: Fri Dec 21 16:43:02 2007 -0800
Add NT error to debug to try and track this down.
Jermey.
---
Summary of changes:
source/winbindd/winbindd_group.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/winbindd/winbindd_group.c b/source/winbindd/winbindd_group.c
index 140943c..fbd2fee 100644
--- a/source/winbindd/winbindd_group.c
+++ b/source/winbindd/winbindd_group.c
@@ -1045,7 +1045,10 @@ static bool get_sam_group_entries(struct getent_state
*ent)
status = domain-methods-enum_local_groups(domain, mem_ctx,
num_entries, sam_grp_entries);
if ( !NT_STATUS_IS_OK(status) ) {
- DEBUG(3,(get_sam_group_entries: Failed to enumerate
domain local groups!\n));
+ DEBUG(3,(get_sam_group_entries:
+ Failed to enumerate
+ domain local groups with error %s!\n,
+ nt_errstr(status)));
num_entries = 0;
}
else
--
Samba Shared Repository
svn commit: samba r26559 - in branches/SAMBA_4_0: . source/scripting/python/samba
Author: jelmer
Date: 2007-12-22 00:47:36 + (Sat, 22 Dec 2007)
New Revision: 26559
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26559
Log:
Make the provision function a bit smaller.
Modified:
branches/SAMBA_4_0/
branches/SAMBA_4_0/source/scripting/python/samba/provision.py
Changeset:
Property changes on: branches/SAMBA_4_0
___
Name: bzr:revision-info
...skipped...
Name: bzr:revision-id:v3-trunk0
...skipped...
Modified: branches/SAMBA_4_0/source/scripting/python/samba/provision.py
===
--- branches/SAMBA_4_0/source/scripting/python/samba/provision.py
2007-12-21 23:52:14 UTC (rev 26558)
+++ branches/SAMBA_4_0/source/scripting/python/samba/provision.py
2007-12-22 00:47:36 UTC (rev 26559)
@@ -354,150 +354,21 @@
})
-
-def provision(lp, setup_dir, message, blank, paths, session_info,
- credentials, ldapbackend, realm=None, domain=None,
hostname=None,
- hostip=None, domainsid=None, hostguid=None, adminpass=None,
- krbtgtpass=None, domainguid=None, policyguid=None,
- invocationid=None, machinepass=None, dnspass=None, root=None,
- nobody=None, nogroup=None, users=None, wheel=None, backup=None,
- aci=None, serverrole=None):
-Provision samba4
-
-:note: caution, this wipes all existing data!
-
-
-def setup_path(file):
-return os.path.join(setup_dir, file)
-
-erase = False
-
-if domainsid is None:
-domainsid = security.random_sid()
-if policyguid is None:
-policyguid = uuid.random()
-if invocationid is None:
-invocationid = uuid.random()
-if adminpass is None:
-adminpass = misc.random_password(12)
-if krbtgtpass is None:
-krbtgtpass = misc.random_password(12)
-if machinepass is None:
-machinepass = misc.random_password(12)
-if dnspass is None:
-dnspass = misc.random_password(12)
-if root is None:
-root = findnss(pwd.getpwnam, root)[4]
-if nobody is None:
-nobody = findnss(pwd.getpwnam, nobody)[4]
-if nogroup is None:
-nogroup = findnss(grp.getgrnam, nogroup, nobody)[2]
-if users is None:
-users = findnss(grp.getgrnam, users, guest, other, unknown,
usr)[2]
-if wheel is None:
-wheel = findnss(grp.getgrnam, wheel, root, staff, adm)[2]
-if backup is None:
-backup = findnss(grp.getgrnam, backup, wheel, root, staff)[2]
-if aci is None:
-aci = # no aci for local ldb
-if serverrole is None:
-serverrole = lp.get(server role)
-
-if realm is None:
-realm = lp.get(realm)
-else:
-if lp.get(realm).upper() != realm.upper():
-raise Error(realm '%s' in smb.conf must match chosen realm
'%s'\n %
-(lp.get(realm), realm))
-
-assert realm is not None
-realm = realm.upper()
-
-if domain is None:
-domain = lp.get(workgroup)
-else:
-if lp.get(workgroup).upper() != domain.upper():
-raise Error(workgroup '%s' in smb.conf must match chosen domain
'%s'\n,
-lp.get(workgroup), domain)
-
-assert domain is not None
-domain = domain.upper()
-if not valid_netbios_name(domain):
-raise InvalidNetbiosName(domain)
-
-if hostname is None:
-hostname = gethostname().split(.)[0].lower()
-
-if hostip is None:
-hostip = gethostbyname(hostname)
-
-netbiosname = hostname.upper()
-if not valid_netbios_name(netbiosname):
-raise InvalidNetbiosName(netbiosname)
-
-dnsdomain= realm.lower()
-domaindn = DC= + dnsdomain.replace(., ,DC=)
-rootdn = domaindn
-configdn = CN=Configuration, + rootdn
-schemadn = CN=Schema, + configdn
-
-rdn_dc = domaindn.split(,)[0][len(DC=):]
-
-message(set DOMAIN SID: %s % str(domainsid))
-message(Provisioning for %s in realm %s % (domain, realm))
-message(Using administrator password: %s % adminpass)
-
-assert paths.smbconf is not None
-
-# only install a new smb.conf if there isn't one there already
-if not os.path.exists(paths.smbconf):
-message(Setting up smb.conf)
-if serverrole == domain controller:
-smbconfsuffix = dc
-elif serverrole == member:
-smbconfsuffix = member
-else:
-assert Invalid server role setting: %s % serverrole
-setup_file(setup_path(provision.smb.conf.%s % smbconfsuffix),
paths.smbconf, {
-HOSTNAME: hostname,
-DOMAIN_CONF: domain,
-REALM_CONF: realm,
-SERVERROLE: serverrole,
-NETLOGONPATH: paths.netlogon,
-SYSVOLPATH: paths.sysvol,
-})
-lp.reload()
-
-# only install a new shares config db if there is none
-if not
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-844-gcebaa48
The branch, v3-2-test has been updated
via cebaa483e62910ac3f87cd135b2aff18dc880416 (commit)
via 3611cc8561cf837adea83fc7c16ca7535f188466 (commit)
via f3365b74ac016eaee1e82eef769dd618af5df201 (commit)
from a1482b09150f4d292965c77bc73d47fb14f5eb85 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit cebaa483e62910ac3f87cd135b2aff18dc880416
Author: Michael Adam [EMAIL PROTECTED]
Date: Sat Dec 22 02:13:02 2007 +0100
Remove redundant connection_struct from check_magic() parameter list.
Michael
commit 3611cc8561cf837adea83fc7c16ca7535f188466
Author: Michael Adam [EMAIL PROTECTED]
Date: Sat Dec 22 02:01:26 2007 +0100
Remove redundant connection_struct from fd_close() parameter list.
Michael
commit f3365b74ac016eaee1e82eef769dd618af5df201
Author: Michael Adam [EMAIL PROTECTED]
Date: Sat Dec 22 01:49:29 2007 +0100
Remove redundant connection_struct from fd_close_posix() parameter list.
Michael
---
Summary of changes:
source/locking/posix.c |4 ++--
source/smbd/close.c|7 ---
source/smbd/open.c | 24
3 files changed, 18 insertions(+), 17 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/locking/posix.c b/source/locking/posix.c
index aef5c17..207ee57 100644
--- a/source/locking/posix.c
+++ b/source/locking/posix.c
@@ -607,14 +607,14 @@ static size_t get_posix_pending_close_entries(TALLOC_CTX
*mem_ctx,
to delete all locks on this fsp before this function is called.
/
-NTSTATUS fd_close_posix(struct connection_struct *conn, files_struct *fsp)
+NTSTATUS fd_close_posix(struct files_struct *fsp)
{
int saved_errno = 0;
int ret;
int *fd_array = NULL;
size_t count, i;
- if (!lp_locking(fsp-conn-params) || !lp_posix_locking(conn-params)) {
+ if (!lp_locking(fsp-conn-params) ||
!lp_posix_locking(fsp-conn-params)) {
/*
* No locking or POSIX to worry about or we want POSIX semantics
* which will lose all locks on all fd's open on this dev/inode,
diff --git a/source/smbd/close.c b/source/smbd/close.c
index eb610f7..5d30e46 100644
--- a/source/smbd/close.c
+++ b/source/smbd/close.c
@@ -27,7 +27,7 @@ extern struct current_user current_user;
Run a file if it is a magic script.
/
-static void check_magic(files_struct *fsp,connection_struct *conn)
+static void check_magic(struct files_struct *fsp)
{
int ret;
const char *magic_output = NULL;
@@ -35,6 +35,7 @@ static void check_magic(files_struct *fsp,connection_struct
*conn)
int tmp_fd, outfd;
TALLOC_CTX *ctx = NULL;
const char *p;
+ struct connection_struct *conn = fsp-conn;
if (!*lp_magicscript(SNUM(conn))) {
return;
@@ -389,11 +390,11 @@ static NTSTATUS close_normal_file(files_struct *fsp, enum
file_close_type close_
locking_close_file(smbd_messaging_context(), fsp);
- status = fd_close(conn, fsp);
+ status = fd_close(fsp);
/* check for magic scripts */
if (close_type == NORMAL_CLOSE) {
- check_magic(fsp,conn);
+ check_magic(fsp);
}
/*
diff --git a/source/smbd/open.c b/source/smbd/open.c
index b83d684..9428b47 100644
--- a/source/smbd/open.c
+++ b/source/smbd/open.c
@@ -70,7 +70,7 @@ static NTSTATUS fd_open(struct connection_struct *conn,
Close the file associated with a fsp.
/
-NTSTATUS fd_close(struct connection_struct *conn, files_struct *fsp)
+NTSTATUS fd_close(files_struct *fsp)
{
if (fsp-fh-fd == -1) {
return NT_STATUS_OK; /* What we used to call a stat open. */
@@ -78,7 +78,7 @@ NTSTATUS fd_close(struct connection_struct *conn,
files_struct *fsp)
if (fsp-fh-ref_count 1) {
return NT_STATUS_OK; /* Shared handle. Only close last
reference. */
}
- return fd_close_posix(conn, fsp);
+ return fd_close_posix(fsp);
}
/
@@ -353,7 +353,7 @@ static NTSTATUS open_file(files_struct *fsp,
/* For a non-io open, this stat failing means file not found.
JRA */
if (ret == -1) {
status = map_nt_error_from_unix(errno);
- fd_close(conn, fsp);
+ fd_close(fsp);
return status;
}
}
@@ -365,7 +365,7 @@ static NTSTATUS open_file(files_struct *fsp,
*/
if(S_ISDIR(psbuf-st_mode)) {
-
svn commit: samba r26562 - in branches/SAMBA_4_0: . source/scripting/python/samba source/setup
Author: jelmer
Date: 2007-12-22 02:26:38 + (Sat, 22 Dec 2007)
New Revision: 26562
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26562
Log:
Fix provisioning using Python.
Modified:
branches/SAMBA_4_0/
branches/SAMBA_4_0/source/scripting/python/samba/provision.py
branches/SAMBA_4_0/source/setup/provision.py
Changeset:
Property changes on: branches/SAMBA_4_0
___
Name: bzr:revision-info
...skipped...
Name: bzr:file-ids
...skipped...
Name: bzr:revision-id:v3-trunk0
...skipped...
Modified: branches/SAMBA_4_0/source/scripting/python/samba/provision.py
===
--- branches/SAMBA_4_0/source/scripting/python/samba/provision.py
2007-12-22 00:47:48 UTC (rev 26561)
+++ branches/SAMBA_4_0/source/scripting/python/samba/provision.py
2007-12-22 02:26:38 UTC (rev 26562)
@@ -354,6 +354,36 @@
})
+def setup_self_join(samdb, configdn, schemadn, domaindn,
+netbiosname, hostname, dnsdomain, machinepass, dnspass,
+realm, domainname, domainsid, invocationid, setup_path,
+policyguid, hostguid=None):
+if hostguid is not None:
+hostguid_add = objectGUID: %s % hostguid
+else:
+hostguid_add =
+
+setup_add_ldif(samdb, setup_path(provision_self_join.ldif), {
+ CONFIGDN: configdn,
+ SCHEMADN: schemadn,
+ DOMAINDN: domaindn,
+ INVOCATIONID: invocationid,
+ NETBIOSNAME: netbiosname,
+ DEFAULTSITE: DEFAULTSITE,
+ DNSNAME: %s.%s % (hostname, dnsdomain),
+ MACHINEPASS_B64: b64encode(machinepass),
+ DNSPASS_B64: b64encode(dnspass),
+ REALM: realm,
+ DOMAIN: domainname,
+ HOSTGUID_ADD: hostguid_add,
+ DNSDOMAIN: dnsdomain})
+setup_add_ldif(samdb, setup_path(provision_group_policy.ldif), {
+ POLICYGUID: policyguid,
+ DNSDOMAIN: dnsdomain,
+ DOMAINSID: str(domainsid),
+ DOMAINDN: domaindn})
+
+
def setup_samdb(path, setup_path, session_info, credentials, lp,
schemadn, configdn, domaindn, dnsdomain, realm,
netbiosname, message, hostname, rootdn, erase,
@@ -506,31 +536,12 @@
if lp.get(server role) == domain controller:
message(Setting up self join)
-if hostguid is not None:
-hostguid_add = objectGUID: %s % hostguid
-else:
-hostguid_add =
+setup_self_join(samdb, configdn=configdn, schemadn=schemadn,
domaindn=domaindn,
+invocationid=invocationid, dnspass=dnspass,
netbiosname=netbiosname,
+dnsdomain=dnsdomain, realm=realm,
machinepass=machinepass,
+domainname=domainname, domainsid=domainsid,
policyguid=policyguid,
+hostname=hostname, hostguid=hostguid,
setup_path=setup_path)
-setup_add_ldif(samdb, setup_path(provision_self_join.ldif),
{
- CONFIGDN: configdn,
- SCHEMADN: schemadn,
- DOMAINDN: domaindn,
- INVOCATIONID: invocationid,
- NETBIOSNAME: netbiosname,
- DEFAULTSITE: DEFAULTSITE,
- DNSNAME: %s.%s % (hostname, dnsdomain),
- MACHINEPASS_B64: b64encode(machinepass),
- DNSPASS_B64: b64encode(dnspass),
- REALM: realm,
- DOMAIN: domainname,
- HOSTGUID_ADD: hostguid_add,
- DNSDOMAIN: dnsdomain})
-setup_add_ldif(samdb,
setup_path(provision_group_policy.ldif), {
- POLICYGUID: policyguid,
- DNSDOMAIN: dnsdomain,
- DOMAINSID: str(domainsid),
- DOMAINDN: domaindn})
-
message(Setting up sam.ldb index)
samdb.load_ldif_file_add(setup_path(provision_index.ldif))
@@ -693,6 +704,7 @@
os.makedirs(os.path.join(paths.sysvol, dnsdomain, Policies, { +
policyguid + }, User), 0755)
if not os.path.isdir(paths.netlogon):
os.makedirs(paths.netlogon, 0755)
+secrets_ldb = Ldb(paths.secrets, session_info=session_info,
credentials=credentials, lp=lp)
setup_ldb(secrets_ldb, setup_path(secrets_dc.ldif), {
MACHINEPASS_B64: b64encode(machinepass),
DOMAIN: domain,
@@ -728,12 +740,13 @@
scope=SCOPE_SUBTREE)
assert isinstance(hostguid, str)
-message(Setting up DNS zone: %s % dnsdomain)
-
svn commit: samba r26563 - in branches/SAMBA_4_0: . source/lib/registry source/lib/registry/tools
Author: jelmer
Date: 2007-12-22 05:02:48 + (Sat, 22 Dec 2007)
New Revision: 26563
WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26563
Log:
Fix reg_diff_apply argument order.
Modified:
branches/SAMBA_4_0/
branches/SAMBA_4_0/source/lib/registry/patchfile.c
branches/SAMBA_4_0/source/lib/registry/patchfile.h
branches/SAMBA_4_0/source/lib/registry/registry.i
branches/SAMBA_4_0/source/lib/registry/tools/regpatch.c
Changeset:
Property changes on: branches/SAMBA_4_0
___
Name: bzr:revision-info
...skipped...
Name: bzr:revision-id:v3-trunk0
...skipped...
Modified: branches/SAMBA_4_0/source/lib/registry/patchfile.c
===
--- branches/SAMBA_4_0/source/lib/registry/patchfile.c 2007-12-22 02:26:38 UTC
(rev 26562)
+++ branches/SAMBA_4_0/source/lib/registry/patchfile.c 2007-12-22 05:02:48 UTC
(rev 26563)
@@ -432,8 +432,7 @@
/**
* Apply diff to a registry context
*/
-_PUBLIC_ WERROR reg_diff_apply(const char *filename,
- struct registry_context *ctx)
+_PUBLIC_ WERROR reg_diff_apply(struct registry_context *ctx, const char
*filename)
{
struct reg_diff_callbacks callbacks;
Modified: branches/SAMBA_4_0/source/lib/registry/patchfile.h
===
--- branches/SAMBA_4_0/source/lib/registry/patchfile.h 2007-12-22 02:26:38 UTC
(rev 26562)
+++ branches/SAMBA_4_0/source/lib/registry/patchfile.h 2007-12-22 05:02:48 UTC
(rev 26563)
@@ -36,8 +36,7 @@
WERROR (*done) (void *callback_data);
};
-WERROR reg_diff_apply (const char *filename,
- struct registry_context *ctx);
+WERROR reg_diff_apply(struct registry_context *ctx, const char *filename);
WERROR reg_generate_diff(struct registry_context *ctx1,
struct registry_context *ctx2,
Modified: branches/SAMBA_4_0/source/lib/registry/registry.i
===
--- branches/SAMBA_4_0/source/lib/registry/registry.i 2007-12-22 02:26:38 UTC
(rev 26562)
+++ branches/SAMBA_4_0/source/lib/registry/registry.i 2007-12-22 05:02:48 UTC
(rev 26563)
@@ -97,11 +97,7 @@
struct registry_key **key);
WERROR get_predefined_key(uint32_t hkey_id, struct registry_key **key);
-WERROR apply_patchfile(const char *filename)
-{
-return reg_diff_apply(filename, $self);
-}
-
+WERROR apply_patchfile(const char *filename);
WERROR mount_hive(struct hive_key *hive_key, uint32_t hkey_id,
const char **elements=NULL);
Modified: branches/SAMBA_4_0/source/lib/registry/tools/regpatch.c
===
--- branches/SAMBA_4_0/source/lib/registry/tools/regpatch.c 2007-12-22
02:26:38 UTC (rev 26562)
+++ branches/SAMBA_4_0/source/lib/registry/tools/regpatch.c 2007-12-22
05:02:48 UTC (rev 26563)
@@ -65,7 +65,7 @@
poptFreeContext(pc);
- reg_diff_apply(patch, h);
+ reg_diff_apply(h, patch);
return 0;
}
svn commit: samba r26564 - in branches/SAMBA_4_0: . source/lib/registry source/lib/registry/tests source/scripting/python/samba
Author: jelmer Date: 2007-12-22 05:02:57 + (Sat, 22 Dec 2007) New Revision: 26564 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26564 Log: More python bindings for registry code. Modified: branches/SAMBA_4_0/ branches/SAMBA_4_0/source/lib/registry/hive.c branches/SAMBA_4_0/source/lib/registry/hive.h branches/SAMBA_4_0/source/lib/registry/local.c branches/SAMBA_4_0/source/lib/registry/registry.i branches/SAMBA_4_0/source/lib/registry/registry.py branches/SAMBA_4_0/source/lib/registry/registry_wrap.c branches/SAMBA_4_0/source/lib/registry/tests/hive.c branches/SAMBA_4_0/source/scripting/python/samba/provision.py Changeset: Sorry, the patch is too large (646 lines) to include; please use WebSVN to see it! WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26564
svn commit: samba r26566 - in branches/SAMBA_4_0: . source/scripting/python/samba
Author: jelmer Date: 2007-12-22 05:11:21 + (Sat, 22 Dec 2007) New Revision: 26566 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26566 Log: Fix member provision when using python. Modified: branches/SAMBA_4_0/ branches/SAMBA_4_0/source/scripting/python/samba/provision.py Changeset: Property changes on: branches/SAMBA_4_0 ___ Name: bzr:revision-info ...skipped... Name: bzr:revision-id:v3-trunk0 ...skipped... Modified: branches/SAMBA_4_0/source/scripting/python/samba/provision.py === --- branches/SAMBA_4_0/source/scripting/python/samba/provision.py 2007-12-22 05:03:02 UTC (rev 26565) +++ branches/SAMBA_4_0/source/scripting/python/samba/provision.py 2007-12-22 05:11:21 UTC (rev 26566) @@ -729,17 +729,17 @@ message(Please install the phpLDAPadmin configuration located at %s into /etc/phpldapadmin/config.php % paths.phpldapadminconfig) -samdb = SamDB(paths.samdb, session_info=session_info, - credentials=credentials, lp=lp) +if lp.get(server role) == domain controller: +samdb = SamDB(paths.samdb, session_info=session_info, + credentials=credentials, lp=lp) -domainguid = samdb.searchone(Dn(samdb, domaindn), objectGUID) -assert isinstance(domainguid, str) -hostguid = samdb.searchone(Dn(samdb, domaindn), objectGUID, -expression=((objectClass=computer)(cn=%s)) % hostname, -scope=SCOPE_SUBTREE) -assert isinstance(hostguid, str) +domainguid = samdb.searchone(Dn(samdb, domaindn), objectGUID) +assert isinstance(domainguid, str) +hostguid = samdb.searchone(Dn(samdb, domaindn), objectGUID, +expression=((objectClass=computer)(cn=%s)) % hostname, +scope=SCOPE_SUBTREE) +assert isinstance(hostguid, str) -if lp.get(server role) == domain controller: message(Setting up DNS zone: %s % dnsdomain) create_zone_file(paths.dns, setup_path, samdb, hostname=hostname, hostip=hostip, dnsdomain=dnsdomain,
