[Samba] [Announce] Samba 3.4.10 Available for Download
== Each day provides its own gifts. Marcus Aurelius == Release Announcements = This is the latest stable release of Samba 3.4. Major enhancements in Samba 3.4.10 include: o Fix smbd coredump (bug #7617). o Fix Winbind internal error (bug #7636). o Fix flaky Winbind against w2k8 (bug #7881). Changes since 3.4.9 --- o Michael Adam ob...@samba.org * BUG 7507: init_sam_from_ldap stores group in sid2uid cache. o Jeremy Allison j...@samba.org * BUG 7577: Fix SPNEGO auth when contacting Win7 system using Microsoft Live Sign-in Assistant. * BUG 7590: Fix offline login in Winbind. * BUG 7617: Fix smbd coredump. * BUG 7636: Fix Winbind internal error. * BUG 7892: Fix stale lock in open_file_fchmod(). o Andrew Bartlett abart...@samba.org * BUG 7356: Fix 'net ads dns register' in Win 2008 R2 domains. o Björn Baumbach b...@sernet.de * BUG 7875: Fix 'nmbd --port'. * BUG 7880: Make 'rpcclient deldriver' delete drivers for all architectures. o Günther Deschner g...@samba.org * BUG 7341: Fix Winbind over IPv6. * BUG 7417: Fix 'net rpc user password' command. * BUG 7418: Fix 'net rpc printer list' command. * BUG 7500: Fix 'not a string literal' warning in netdomjoin-gui. * BUG 7541: Fix smbd crash caused by %D in printer admin option. * BUG 7568: Make sure cm_connect_lsa_tcp does not reset the secure channel. o Olaf Flebbe o.fle...@science-computing.de * BUG 7421: Fix build on AIX 6.1. o Björn Jacke b...@sernet.de * BUG 7821: Set Tru64 cc's PIC switch right. o Volker Lendecke v...@samba.org * BUG 7066: Fix Your Password expires today message for users from trusted domains. * BUG 7262: Fix EnumDomainAliases when no aliases are in LDAP. * BUG 7336: Enable idmap_passdb module build as shared. * BUG 7715: Stop using the write cache after an oplock break: Stop using the write cache after an oplock break. * BUG 7800: Make winbind recover from a signing error. * BUG 7881: Fix flaky Winbind against w2k8. o Jim McDonough j...@samba.org * BUG 7280: Fix loading of auto printers with registry config. o Stefan Metzmacher me...@samba.org * BUG 7607: Fix buffer over-read in pidl generated client code. * BUG 7896: Fix 'net rpc user rename'. o Andreas Schneider a...@samba.org * BUG 7423: Add EN ISO 216, A0 and A1 to builtin forms. * BUG 7538: Backport fixes for GUID_from_data_blob. o Andrew Tridgell tri...@samba.org * BUG 7538: Backport fixes for GUID_from_data_blob. Download Details The uncompressed tarballs and patch files have been signed using GnuPG (ID 6568B7EA). The source code can be downloaded from: http://download.samba.org/samba/ftp/stable The release notes are available online at: http://www.samba.org/samba/history/samba-3.4.10.html Binary packages will be made available on a volunteer basis from http://download.samba.org/samba/ftp/Binary_Packages/ Our Code, Our Bugs, Our Responsibility. (https://bugzilla.samba.org/) --Enjoy The Samba Team -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Question on how to get Samba to use larger pread/write calls.
Thx James Peach sent something similar to me too.. darn vfs objects :) Thx james :) I remember now on irix we had to do some stuff with these. I do not see the cacheprime vfs object on FC13 but I do see readahead so I guess I will start with that... I also heard that there are some other I/O tuning that I can do in the Linux/FC kernel to maybe increase the read/write sizes... The kicker here is that I am using an Areca 1880-ix-16 as well as an ATTO R680 card in my boxes and they do not work very well with small I/Os. They are both 6Gbit technology and I have 16 X 2TB fast Hitachi drives in the connected raid... No one has issues with reading/writing one fileit is where one wants to read or write say 20-40 files simultaneously it all goes to heck with small I/Os to/from the raid cards on Linux. I use fio as a test vehicle. It runs over 10Gbit port from a client to a 10Gbe port on my FC13 system.using samba or netatalksimulating 20-40 video users to see home many read/pread's I can get under 38ms/1MByte.. It is a requirement we have for Video editing..I have tuned Mac OS using the ATTO R680 card and it has no problems with low latency for 20-30 sessions/users..The most I can get out of FC13 is maybe 8-10. So it looks like I have homework to do to get Linux/FC13 so it handles I/O's bigger :) Thx chris On 1/18/11 12:34 AM, Volker Lendecke wrote: On Mon, Jan 17, 2011 at 10:14:04AM -0600, Chris Duffy wrote: We are testing Samba 3 (and 4) on Fedora Core 13, 10Gbit connection with a Mac OS 10.6.4 system as the client. We will be adding some Windows machines sooner or later with 10Gbit interfaces. We are seeing 100-150MBytes/sec read or write performance between the Mac and the FC13 system over 10Gbit interface but it should be capable of 400-500MBytes/sec. We have a local raid on the FC13 system that runs 1GByte/sec locally using an Areca 1880-ix-16 raid card (6Gbit version). It has 16 fast Hitachi disks in a Raid5 format using xfs filesystem. The problem here is that samba is poking the Areca at 128KByte I/O's on preads and writes, i.e. shown to us using strace on the smbd daemons that are running. Using vmstat/iostat/sar utilities, we see 100% utilization of the Areca card because the average wait time is real high and the average queue length to it is also high..too many small I/O's. This is not the case if I run fio or dd locally to/from the Areca's raid using 1-4MByte I/O's. I see fast I/O... I do not see any way to increase the size of Samba's pread/write's in the smb.conf documentation. I am sure it may be just a matter of getting the source code and making some changes to allow larger sized IO's butand of course I suppose Windows clients may complain but I remember that back in the old Irix days with the group of engineers in Australia I worked with, we had Samba screaming fast but not sure if they tweaked the version of Samba on Irix to do this. Can you guys come up with a way for us to allow the reads/writes to/from the disks to be tunable up to say 4MB in size? You might want to play with write cache size. This will only tune writes though. And it will only work for oplocked files. I'm not 100% sure that OS/X plays nicely wrt oplocks. For reads, we need to take a much closer look at your real workload and see if we need to use some kind of preopen, prefetch or so module. We need to closely work with the kernel buffer cache and potential readahead kernel algorithms. With best regards, Volker Lendecke -- Chris Duffy Technical Support Small Tree www.small-tree.com http://www.small-tree.com Direct 651-209-6509 X305 Mobil 651-303-9613 Yahoo:chris_duffy6288 AIM:chris.j.du...@comcast.net -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Samba hangs the boot on Gentoo.
Hello, Today I came across with the problem with booting my Gentoo system. Yesterday I installed samba and when I turned on my notebook today it stops booting at starting up the samba daemon. It goes until: * samba - start: smbd ... ... and then freezes ... Maybe the problem is somehow related to my Wi-Fi connection on notebook and Samba is looking for Internet connection and waiting for it to be established? Maybe you can give any advice on how to boot to my system without loading samba and uninstalling it? Looking forward to hearing from you and any help would be very appreciated, Thank You in advance, Aleksandr. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] ADS OS fields with samba 3.3.2
Thank you so much. Now it seems so simpler, was exactly what we were looking for. どうもありがとう Atentamente Jacobo José Peña Peña Analista Operaciones TI GGTO - GOC Gerencia Operaciones TI Centralizadas Coordinación Operaciones de Hosting – Hosting Windows Telfs.: 0212-500-1408 Para atención de solicitudes por favor contactar al Centro de Interacción Corporativo (0212-5008745) o generar caso a través de la herramienta de Gestión Remedy. Para mayor información: instructivo INS-0800 “Solicitud de Servicios a la Gerencia Operaciones TI Centralizadas” ubicado en http://cired.cantv.com.ve/docs/ Por favor emitir Agradecimientos, Sugerencias o Quejas por http://escritorio.cantv.net/Reportes/opinion.pl -Mensaje original- De: TAKAHASHI Motonobu [mailto:mo...@monyo.com] Enviado el: Jueves, 20 de Enero de 2011 01:19 p.m. Para: Pena Pena Jacobo Jose CC: samba@lists.samba.org; canaima-cantv Asunto: Re: [Samba] ADS OS fields with samba 3.3.2 2011/1/19 Pena Pena Jacobo Jose jpena...@cantv.com.ve: Hi everybody, I am using samba 3.3.2 provided by Debian and I am looking for a way to populate this fields[1] during domain join against w2k3 sp3. I was reading the mailing list and I found a thread[2] from 3 years ago that speak about the problem but I can not get the solution. There is anybody who knows how to do it? Use osName and osVersion options with net ads join. They are available from Samba 3.0.25. --- TAKAHASHI Motonobu mo...@samba.gr.jp -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Mac/Windows compatability problem
Hello! I have a brand new *iMac 27 with a PC partition* on it. The PC side runs on *Windows 7 Enterprise*. My husband has a PC with *Windows XP* on it. The brand new *Mac Mini Server* works fine for our macs, but the PCs have been unable to connect. How do I get the PCs to see and connect to the Mini Mac Server? We have got to the point where it works for my husband's Windows XP computer, but not for my Windows 7 Enterprise. We have tried all sorts of things, and right now we are at the point where my Windows 7 PC tries to communicate with the Mac Mini Server, but the password is not accepted. It is the correct password, so any idea what the problem could be? Bente Mc Bente Michelsen www.livlaga.com http://213740.myvideostudio.com -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba hangs the boot on Gentoo.
On Thu, Jan 20, 2011 at 9:30 AM, Aleksandr Poteriachin insp1re2...@gmail.com wrote: Maybe you can give any advice on how to boot to my system without loading samba and uninstalling it? Aleksandr, If you are starting samba daemon the usual gentoo way - rc-update add samba default - I suggest using a gentoo install disc to chroot into your environment to temporarily disable samba so you can provide the list with your smb.conf, or results of smbclient -L,U,I,M, etc. Boot from gentoo-minimal-install-disc and at ~# mount /dev/sdx# /mnt/gentoo ((x=whatever letter your hard drive is; # = whatever partition number designates /)) mkdir /mnt/gentoo/boot mount /dev/sdx# /mnt/gentoo/boot ((x=whatever letter your hard drive is; # = whatever partition number designates /boot)) cd /mnt/gentoo mount -t proc proc /mnt/gentoo/proc mount -o bind /dev /mnt/gentoo/dev chroot /mnt/gentoo /bin/bash env-update source /etc/profile Now you have access to your operating system. Type command: rc-update del samba default Now you can reboot and the computer should start up normally since the samba daemon has been removed from the default startup process. HTH, Mike Looking forward to hearing from you and any help would be very appreciated, Thank You in advance, Aleksandr. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba hangs the boot on Gentoo.
Today I came across with the problem with booting my Gentoo system. Yesterday I installed samba and when I turned on my notebook today it stops booting at starting up the samba daemon. It goes until: * samba - start: smbd ... ... and then freezes ... Maybe the problem is somehow related to my Wi-Fi connection on notebook and Samba is looking for Internet connection and waiting for it to be established? Maybe you can give any advice on how to boot to my system without loading samba and uninstalling it? Looking forward to hearing from you and any help would be very appreciated, As a gentoo user who has used samba for 7 years now at home and at work (samba / ldap department domain) I have never seen this behavior. Although my samba servers are all wired usually gigabit. John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba hangs the boot on Gentoo.
On Thu, Jan 20, 2011 at 9:30 AM, Aleksandr Poteriachin insp1re2...@gmail.com wrote: Hello, Today I came across with the problem with booting my Gentoo system. Yesterday I installed samba and when I turned on my notebook today it stops booting at starting up the samba daemon. It goes until: * samba - start: smbd ... ... and then freezes ... Maybe the problem is somehow related to my Wi-Fi connection on notebook and Samba is looking for Internet connection and waiting for it to be established? Maybe you can give any advice on how to boot to my system without loading samba and uninstalling it? Do an interactive boot. Press I when it asks you to do in the boot process. Then do not start the samba daemon. John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba hangs the boot on Gentoo.
Hello, Today I came across with the problem with booting my Gentoo system. Yesterday I installed samba and when I turned on my notebook today it stops booting at starting up the samba daemon. It goes until: * samba - start: smbd ... I had some difficulties a few years back with Samba/LDAP nssldap, pam_ldap and pam. The system would hang for some 10 minutes at startup. The problem was that nssldap defaults to bind_policy hard, and as nssldap fired before the ldap server started (from the nssldap conf file): # Reconnect policy: hard (default) will retry connecting to # the software with exponential backoff, soft will fail # immediately. changing the value to bind_policy soft rectified the situation. ... and then freezes ... Maybe the problem is somehow related to my Wi-Fi connection on notebook and Samba is looking for Internet connection and waiting for it to be established? Maybe you can give any advice on how to boot to my system without loading samba and uninstalling it? Do an interactive boot. Press I when it asks you to do in the boot process. Then do not start the samba daemon. John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba hangs the boot on Gentoo.
On Sat, Jan 22, 2011 at 7:50 AM, t...@tms3.com wrote: Hello, Today I came across with the problem with booting my Gentoo system. Yesterday I installed samba and when I turned on my notebook today it stops booting at starting up the samba daemon. It goes until: * samba - start: smbd ... I had some difficulties a few years back with Samba/LDAP nssldap, pam_ldap and pam. The system would hang for some 10 minutes at startup. The problem was that nssldap defaults to bind_policy hard, and as nssldap fired before the ldap server started (from the nssldap conf file): # Reconnect policy: hard (default) will retry connecting to # the software with exponential backoff, soft will fail # immediately. changing the value to bind_policy soft rectified the situation. ... and then freezes ... Maybe the problem is somehow related to my Wi-Fi connection on notebook and Samba is looking for Internet connection and waiting for it to be established? Maybe you can give any advice on how to boot to my system without loading samba and uninstalling it? Do an interactive boot. Press I when it asks you to do in the boot process. Then do not start the samba daemon. John I would also run: etc-update To see if /etc/init.d/samba has any newer changes to be applied to the startup script. --Brian -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Trouble installing SWAT on a Samba 4 Alpha 13 build on Ubuntu Server
Hello all,
I have setup a complete domain using Samba 4 on my Ubuntu server 32 bit
machine. I am using the Alpha 13 build (it was actually in the Ubuntu
Repos). I am trying to setup swat to make it easier to manage shares. I
have followed the instructions at https://github.com/rvelhote/GSoC-SWAT but
I am having a few problems.
When I run ./run I get the following errors:
jenfab@dc:~/GSoC-SWAT$ sudo ./run
Starting subprocess with file monitor
Traceback (most recent call last):
File /usr/local/bin/paster, line 9, in module
load_entry_point('PasteScript==1.7.3', 'console_scripts', 'paster')()
File /usr/lib/pymodules/python2.6/paste/script/command.py, line 84, in
run
invoke(command, command_name, options, args[1:])
File /usr/lib/pymodules/python2.6/paste/script/command.py, line 123, in
invoke
exit_code = runner.run(args)
File /usr/lib/pymodules/python2.6/paste/script/command.py, line 218, in
run
result = self.command()
File /usr/lib/pymodules/python2.6/paste/script/serve.py, line 276, in
command
relative_to=base, global_conf=vars)
File /usr/lib/pymodules/python2.6/paste/script/serve.py, line 313, in
loadapp
**kw)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 204, in
loadapp
return loadobj(APP, uri, name=name, **kw)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 224, in
loadobj
global_conf=global_conf)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 248, in
loadcontext
global_conf=global_conf)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 278, in
_loadconfig
return loader.get_context(object_type, name, global_conf)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 409, in
get_context
section)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 431, in
_context_from_use
object_type, name=use, global_conf=global_conf)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 361, in
get_context
global_conf=global_conf)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 248, in
loadcontext
global_conf=global_conf)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 285, in
_loadegg
return loader.get_context(object_type, name, global_conf)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 561, in
get_context
object_type, name=name)
File /usr/lib/pymodules/python2.6/paste/deploy/loadwsgi.py, line 587, in
find_egg_entry_point
possible.append((entry.load(), protocol, entry.name))
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1954, in
load
entry = __import__(self.module_name, globals(),globals(), ['__name__'])
ImportError: No module named swat.config.middleware
Any suggestions as to where to go from here?
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/options/samba
[Announce] Samba 3.4.10 Available for Download
== Each day provides its own gifts. Marcus Aurelius == Release Announcements = This is the latest stable release of Samba 3.4. Major enhancements in Samba 3.4.10 include: o Fix smbd coredump (bug #7617). o Fix Winbind internal error (bug #7636). o Fix flaky Winbind against w2k8 (bug #7881). Changes since 3.4.9 --- o Michael Adam ob...@samba.org * BUG 7507: init_sam_from_ldap stores group in sid2uid cache. o Jeremy Allison j...@samba.org * BUG 7577: Fix SPNEGO auth when contacting Win7 system using Microsoft Live Sign-in Assistant. * BUG 7590: Fix offline login in Winbind. * BUG 7617: Fix smbd coredump. * BUG 7636: Fix Winbind internal error. * BUG 7892: Fix stale lock in open_file_fchmod(). o Andrew Bartlett abart...@samba.org * BUG 7356: Fix 'net ads dns register' in Win 2008 R2 domains. o Björn Baumbach b...@sernet.de * BUG 7875: Fix 'nmbd --port'. * BUG 7880: Make 'rpcclient deldriver' delete drivers for all architectures. o Günther Deschner g...@samba.org * BUG 7341: Fix Winbind over IPv6. * BUG 7417: Fix 'net rpc user password' command. * BUG 7418: Fix 'net rpc printer list' command. * BUG 7500: Fix 'not a string literal' warning in netdomjoin-gui. * BUG 7541: Fix smbd crash caused by %D in printer admin option. * BUG 7568: Make sure cm_connect_lsa_tcp does not reset the secure channel. o Olaf Flebbe o.fle...@science-computing.de * BUG 7421: Fix build on AIX 6.1. o Björn Jacke b...@sernet.de * BUG 7821: Set Tru64 cc's PIC switch right. o Volker Lendecke v...@samba.org * BUG 7066: Fix Your Password expires today message for users from trusted domains. * BUG 7262: Fix EnumDomainAliases when no aliases are in LDAP. * BUG 7336: Enable idmap_passdb module build as shared. * BUG 7715: Stop using the write cache after an oplock break: Stop using the write cache after an oplock break. * BUG 7800: Make winbind recover from a signing error. * BUG 7881: Fix flaky Winbind against w2k8. o Jim McDonough j...@samba.org * BUG 7280: Fix loading of auto printers with registry config. o Stefan Metzmacher me...@samba.org * BUG 7607: Fix buffer over-read in pidl generated client code. * BUG 7896: Fix 'net rpc user rename'. o Andreas Schneider a...@samba.org * BUG 7423: Add EN ISO 216, A0 and A1 to builtin forms. * BUG 7538: Backport fixes for GUID_from_data_blob. o Andrew Tridgell tri...@samba.org * BUG 7538: Backport fixes for GUID_from_data_blob. Download Details The uncompressed tarballs and patch files have been signed using GnuPG (ID 6568B7EA). The source code can be downloaded from: http://download.samba.org/samba/ftp/stable The release notes are available online at: http://www.samba.org/samba/history/samba-3.4.10.html Binary packages will be made available on a volunteer basis from http://download.samba.org/samba/ftp/Binary_Packages/ Our Code, Our Bugs, Our Responsibility. (https://bugzilla.samba.org/) --Enjoy The Samba Team
[SCM] Samba Shared Repository - branch v3-4-stable updated
The branch, v3-4-stable has been updated via 247949c WHATSNEW: Add major enhancements. via 2cda481 WHATSNEW: Update changes since 3.4.9. via 18412f6 WHATSNEW: Start to add changes since 3.4.9. via efb89c2 s3-rpcclient: Fix bug #7880: cmd_spoolss_deletedriver() returned without checking all architectures. via 0e1aec4 s3-dns Don't use DELEG_FLAG in DNS update, Windows 2008R2 does not like it (cherry picked from commit 280caa6b3bb1199939f9349ea5a436a491c81791) via aaf6e34 s3-dns Don't use SEQUENCE_FLAG in DNS update, Windows 2008R2 does not like it via 94fd3a5 WHATSNEW: Start release notes for Samba 3.4.10. via 4717c6f VERSION: Bump version number. via 5702565 s3-nmbd: Fix bug #7875 via 0b3aaa3 s3:lib/netapi: don't set SAMR_FIELD_FULL_NAME if we just want to set the account name (bug #7896) via b73822f s3: Fix bug 7066 -- wbcAuthenticateEx gives unix times via 8096bb2 Ñ3/configue: set Tru64 cc's PIC switch right (none) via 4559441 Fix bug #7892 - open_file_fchmod() leaves a stale lock. (cherry picked from commit 023aa6f4aae29ba22b3d42c815027ba6a66f8ee2) via 133b474 s3: Use smbsock_any_connect in winbind via efa34c0 s3: Retry *SMBSERVER in nb_connect (cherry picked from commit ee2534c18b5afa609ff17d9da7ea10bcf7654fc6) via 03e02ad s3: Add smbsock_any_connect (cherry picked from commit 198b6d673787ee40c0ac389ece99cee1844dd585) via 607c00d s3: Add an async smbsock_connect via 14e272c v3-4-test: Pull in tevent_req_poll_ntstatus from master (cherry picked from commit 9b79de1553cfa57d24d1ac0316b814933ef3d33d) via 88ce2c7 s3: Add async cli_session_request via b2a1f5a v3-4-test: Pull in read_smb_send from master (cherry picked from commit 02c4649674d3bd0f54e71910f11d6aff2cdb6c9d) via f338111 s3: Add some const to name_mangle() (cherry picked from commit 56c760ab41b9b4cb9680d873b8f9955be21434f4) via 7943955 s3: Make winbind recover from a signing error via fc80176 s3: Stop using the write cache after an oplock break via e3e35fa Fix bug 7636 - winbind internal error, backtrace. via 8863dce s3-printing: fix BUG 7280 - auto printers not loading with registry config (cherry picked from commit 9c3537b6d8b2ea36265d3a69f7e90278cb86dbfb) via bd20f12 Fix bug 7590 - offline login fails because winbind deletes cache on every startup. via 97f779d rerun: make samba3-idl via 00c0580 pidl: Samba3/ClientNDR - Correctly copy arrays, if r.out.size r.in.size. via 6dc20e5 Fix bug #7617 - smbd coredump due to uninitialized variables in the performance counter code. via 4447ae9 s3-winbind: Fix Bug #7568: Make sure cm_connect_lsa_tcp does not reset the secure channel. via 0c10994 s3-libsmb: Fix bug #7577. via 2a1568f librpc: split out a separate GUID_from_ndr_blob() function via d3a6a07 s3: Fix bug 7336: Enable idmap_passdb module build as shared (cherry picked from commit 8c0fbc410798512b7a4b7db73bcb24cde6fa7849) (cherry picked from commit b4803af11525823ea508d0ca4e58402d55901194) (cherry picked from commit 1b22e942aa869d51dc9e50b74c44ece004c30947) via a5fff72 s3-librpc: Fixed GUID_from_data_blob() with length of 32. via f280494 s3-printing: Fix Bug #7541, %D in printer admin causing smbd crash. via bf6dbcc s3-docs: Add missing whitespace. via 4297ef9 s3-docs: Fix some of ntlm_auth ntlm-server-1 protocol documentation. via 1fc9f14 s3: Fix EnumDomainAliases when no aliases are in LDAP via 3633fad s3:pdb_ldap: fix bug 7507 - init_sam_from_ldap stores group in sid2uid cache (cherry picked from commit ba809ecb8ab217e4376bf75d2300e146b62b88eb) (cherry picked from commit cc740fb5eb56a0875703753d4a116d2fe33ec186) (cherry picked from commit b206d75ca5ba04a866a22dfca5b7441fb49078d8) via da6259b s3-netdomjoin-gui: Fix Bug #7500. Fix 'not a string literal' warning in netdomjoin-gui. via 81f4c22 s3-kerberos: temporary fix for ipv6 in print_kdc_line(). via 80ad2c9 s3-kerberos: pass down kdc_name to create_local_private_krb5_conf_for_domain(). via 1f3cea4 s3-winbind: make the getpeername() checks in cm_prepare_connection IPv6 aware. via 4d084a8 s3-spoolss: Added EN ISO 216, A0 and A1 to builtin forms. via 450c5be s3-docs: Move -D option to the right paragraph in man winbindd. via 5c2b44d work around AIX6.1 name space pollution rename mod_name to module_name via 10d8bc3 s3-spoolss: Fix _spoolss_EnumPrinters servername handling. via 6022a74 s3-spoolss: in spoolss_EnumPrinters r-in.server is a *unique* pointer! via 3fc63a6 s3-net: Fix Bug #7417. 'net rpc user password' can set the wrong password. from bfe7b2c WHATSNEW: Update release date. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-stable - Log
[SCM] Samba Shared Repository - annotated tag release-3-4-10 created
The annotated tag, release-3-4-10 has been created at ee2c28bc2c5ea3fff624634703ecf243fc6e272a (tag) tagging 247949c1706d3a5723fb54363d0670dda277afcb (commit) replaces release-3-4-9 tagged by Karolin Seeger on Fri Jan 21 21:44:57 2011 +0100 - Log - tag release-3-4-10 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.12 (GNU/Linux) iD8DBQBNOfCbbzORW2Vot+oRAmCAAKDHCYpoqyVI4ynqnZD9YhbFXH92RQCghHdd w+2QVhwuCp7eMdwkOoWP26Y= =x2wk -END PGP SIGNATURE- Andreas Schneider (2): s3-spoolss: Added EN ISO 216, A0 and A1 to builtin forms. s3-librpc: Fixed GUID_from_data_blob() with length of 32. Andrew Bartlett (2): s3-dns Don't use SEQUENCE_FLAG in DNS update, Windows 2008R2 does not like it s3-dns Don't use DELEG_FLAG in DNS update, Windows 2008R2 does not like it (cherry picked from commit 280caa6b3bb1199939f9349ea5a436a491c81791) Andrew Tridgell (1): librpc: split out a separate GUID_from_ndr_blob() function Björn Baumbach (2): s3-nmbd: Fix bug #7875 s3-rpcclient: Fix bug #7880: cmd_spoolss_deletedriver() returned without checking all architectures. Björn Jacke (1): Ñ3/configue: set Tru64 cc's PIC switch right (none) Günther Deschner (10): s3-net: Fix Bug #7417. 'net rpc user password' can set the wrong password. s3-spoolss: in spoolss_EnumPrinters r-in.server is a *unique* pointer! s3-spoolss: Fix _spoolss_EnumPrinters servername handling. s3-winbind: make the getpeername() checks in cm_prepare_connection IPv6 aware. s3-kerberos: pass down kdc_name to create_local_private_krb5_conf_for_domain(). s3-kerberos: temporary fix for ipv6 in print_kdc_line(). s3-netdomjoin-gui: Fix Bug #7500. Fix 'not a string literal' warning in netdomjoin-gui. s3-docs: Fix some of ntlm_auth ntlm-server-1 protocol documentation. s3-printing: Fix Bug #7541, %D in printer admin causing smbd crash. s3-winbind: Fix Bug #7568: Make sure cm_connect_lsa_tcp does not reset the secure channel. Jeremy Allison (5): s3-libsmb: Fix bug #7577. Fix bug #7617 - smbd coredump due to uninitialized variables in the performance counter code. Fix bug 7590 - offline login fails because winbind deletes cache on every startup. Fix bug 7636 - winbind internal error, backtrace. Fix bug #7892 - open_file_fchmod() leaves a stale lock. Jim McDonough (1): s3-printing: fix BUG 7280 - auto printers not loading with registry config Karolin Seeger (7): s3-docs: Move -D option to the right paragraph in man winbindd. s3-docs: Add missing whitespace. VERSION: Bump version number. WHATSNEW: Start release notes for Samba 3.4.10. WHATSNEW: Start to add changes since 3.4.9. WHATSNEW: Update changes since 3.4.9. WHATSNEW: Add major enhancements. Michael Adam (1): s3:pdb_ldap: fix bug 7507 - init_sam_from_ldap stores group in sid2uid cache Olaf Flebbe (1): work around AIX6.1 name space pollution rename mod_name to module_name Stefan Metzmacher (3): pidl: Samba3/ClientNDR - Correctly copy arrays, if r.out.size r.in.size. rerun: make samba3-idl s3:lib/netapi: don't set SAMR_FIELD_FULL_NAME if we just want to set the account name (bug #7896) Volker Lendecke (13): s3: Fix EnumDomainAliases when no aliases are in LDAP s3: Fix bug 7336: Enable idmap_passdb module build as shared s3: Stop using the write cache after an oplock break s3: Make winbind recover from a signing error s3: Add some const to name_mangle() v3-4-test: Pull in read_smb_send from master s3: Add async cli_session_request v3-4-test: Pull in tevent_req_poll_ntstatus from master s3: Add an async smbsock_connect s3: Add smbsock_any_connect s3: Retry *SMBSERVER in nb_connect s3: Use smbsock_any_connect in winbind s3: Fix bug 7066 -- wbcAuthenticateEx gives unix times --- -- Samba Shared Repository
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via 9767b71 Announce Samba 3.4.10. from e9bafa2 Add Google Checkout and prefer it due to lower fees. http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit 9767b714d0069281e63ff6e95db11d0b08a84ac7 Author: Karolin Seeger ksee...@samba.org Date: Sat Jan 22 11:37:16 2011 +0100 Announce Samba 3.4.10. Karolin --- Summary of changes: history/header_history.html |1 + history/samba-3.4.10.html | 103 +++ 2 files changed, 104 insertions(+), 0 deletions(-) create mode 100755 history/samba-3.4.10.html Changeset truncated at 500 lines: diff --git a/history/header_history.html b/history/header_history.html index 8bf9073..06d2a5c 100755 --- a/history/header_history.html +++ b/history/header_history.html @@ -16,6 +16,7 @@ lia href=samba-3.5.2.htmlsamba-3.5.2/a/li lia href=samba-3.5.1.htmlsamba-3.5.1/a/li lia href=samba-3.5.0.htmlsamba-3.5.0/a/li + lia href=samba-3.4.10.htmlsamba-3.4.10/a/li lia href=samba-3.4.9.htmlsamba-3.4.9/a/li lia href=samba-3.4.8.htmlsamba-3.4.8/a/li lia href=samba-3.4.7.htmlsamba-3.4.7/a/li diff --git a/history/samba-3.4.10.html b/history/samba-3.4.10.html new file mode 100755 index 000..ded7347 --- /dev/null +++ b/history/samba-3.4.10.html @@ -0,0 +1,103 @@ +!DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 Transitional//EN +http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd; +html xmlns=http://www.w3.org/1999/xhtml; + +head +titleSamba - Release Notes Archive/title +/head + +body + + H2Samba 3.4.10 Available for Download/H2 + +p +pre + == + Release Notes for Samba 3.4.10 + January 22, 2011 + == + + +This is the latest stable release of Samba 3.4. + +Major enhancements in Samba 3.4.10 include: + + o Fix smbd coredump (bug #7617). + o Fix Winbind internal error (bug #7636). + o Fix flaky Winbind against w2k8 (bug #7881). + + +Changes since 3.4.9 +--- + +o Michael Adam lt;ob...@samba.orggt; +* BUG 7507: init_sam_from_ldap stores group in sid2uid cache. + + +o Jeremy Allison lt;j...@samba.orggt; +* BUG 7577: Fix SPNEGO auth when contacting Win7 system using Microsoft Live + Sign-in Assistant. +* BUG 7590: Fix offline login in Winbind. +* BUG 7617: Fix smbd coredump. +* BUG 7636: Fix Winbind internal error. +* BUG 7892: Fix stale lock in open_file_fchmod(). + + +o Andrew Bartlett lt;abart...@samba.orggt; +* BUG 7356: Fix 'net ads dns register' in Win 2008 R2 domains. + + +o Bjouml;rn Baumbach lt;b...@sernet.degt; +* BUG 7875: Fix 'nmbd --port'. +* BUG 7880: Make 'rpcclient deldriver' delete drivers for all architectures. + + +o Guuml;nther Deschner lt;g...@samba.orggt; +* BUG 7341: Fix Winbind over IPv6. +* BUG 7417: Fix 'net rpc user password' command. +* BUG 7418: Fix 'net rpc printer list' command. +* BUG 7500: Fix 'not a string literal' warning in netdomjoin-gui. +* BUG 7541: Fix smbd crash caused by %D in printer admin option. +* BUG 7568: Make sure cm_connect_lsa_tcp does not reset the secure channel. + + +o Olaf Flebbe lt;o.fle...@science-computing.degt; +* BUG 7421: Fix build on AIX 6.1. + + +o Bjouml;rn Jacke lt;b...@sernet.degt; +* BUG 7821: Set Tru64 cc's PIC switch right. + + +o Volker Lendecke lt;v...@samba.orggt; +* BUG 7066: Fix Your Password expires today message for users from trusted + domains. +* BUG 7262: Fix EnumDomainAliases when no aliases are in LDAP. +* BUG 7336: Enable idmap_passdb module build as shared. +* BUG 7715: Stop using the write cache after an oplock break: Stop using the + write cache after an oplock break. +* BUG 7800: Make winbind recover from a signing error. +* BUG 7881: Fix flaky Winbind against w2k8. + + +o Jim McDonough lt;j...@samba.orggt; +* BUG 7280: Fix loading of auto printers with registry config. + + +o Stefan Metzmacher lt;me...@samba.orggt; +* BUG 7607: Fix buffer over-read in pidl generated client code. +* BUG 7896: Fix 'net rpc user rename'. + + +o Andreas Schneider lt;a...@samba.orggt; +* BUG 7423: Add EN ISO 216, A0 and A1 to builtin forms. +* BUG 7538: Backport fixes for GUID_from_data_blob. + + +o Andrew Tridgell lt;tri...@samba.orggt; +* BUG 7538: Backport fixes for GUID_from_data_blob. +/pre +/p + +/body +/html -- Samba Website Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 585e9a0 s4-repl_meta_data: replmd_update_is_newer() should not
return true if metadata stamps are equal
via 0ce93ad s4-repl_meta_data: Print out what is wrong when we fail to
modify object
via 0aa118f s4-repl_meta_data: We should not use USNs in metadata
comparisons
from 6ee39a2 s3-torture: fix uninitialized status code.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 585e9a0ab0e0673f1222a4e26d94c90fb6e88331
Author: Kamen Mazdrashki kame...@samba.org
Date: Fri Jan 21 22:51:05 2011 +0200
s4-repl_meta_data: replmd_update_is_newer() should not return true if
metadata stamps are equal
Autobuild-User: Kamen Mazdrashki kame...@samba.org
Autobuild-Date: Sat Jan 22 12:22:30 CET 2011 on sn-devel-104
commit 0ce93ad2bc91fd7cbe2f71d00a323a827b9457b1
Author: Kamen Mazdrashki kame...@samba.org
Date: Fri Jan 21 02:39:23 2011 +0200
s4-repl_meta_data: Print out what is wrong when we fail to modify object
commit 0aa118f22bb2e810e5c530c743c48dcb7bde92cc
Author: Kamen Mazdrashki kame...@samba.org
Date: Fri Jan 21 02:38:25 2011 +0200
s4-repl_meta_data: We should not use USNs in metadata comparisons
If object is changed by same DC, then version should be incremented
---
Summary of changes:
source4/dsdb/samdb/ldb_modules/repl_meta_data.c | 18 --
1 files changed, 4 insertions(+), 14 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index 2cc52b9..87327e5 100644
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -372,6 +372,7 @@ static int replmd_op_callback(struct ldb_request *req,
struct ldb_reply *ares)
controls = ldb_controls_except_specified(ares-controls, ares,
partition_ctrl);
if (ares-error != LDB_SUCCESS) {
+ DEBUG(0,(%s failure. Error is: %s\n, __FUNCTION__,
ldb_strerror(ares-error)));
return ldb_module_done(ac-req, controls,
ares-response, ares-error);
}
@@ -2946,23 +2947,16 @@ static bool replmd_update_is_newer(const struct GUID
*current_invocation_id,
const struct GUID *update_invocation_id,
uint32_t current_version,
uint32_t update_version,
- uint32_t current_usn,
- uint32_t update_usn,
NTTIME current_change_time,
NTTIME update_change_time)
{
- if (GUID_compare(update_invocation_id, current_invocation_id) == 0) {
- if (update_usn != current_usn) {
- return update_usn = current_usn;
- }
- }
if (update_version != current_version) {
- return update_version = current_version;
+ return update_version current_version;
}
if (update_change_time != current_change_time) {
- return update_change_time = current_change_time;
+ return update_change_time current_change_time;
}
- return GUID_compare(update_invocation_id, current_invocation_id) = 0;
+ return GUID_compare(update_invocation_id, current_invocation_id) 0;
}
static bool replmd_replPropertyMetaData1_is_newer(struct replPropertyMetaData1
*cur_m,
@@ -2972,8 +2966,6 @@ static bool replmd_replPropertyMetaData1_is_newer(struct
replPropertyMetaData1 *
new_m-originating_invocation_id,
cur_m-version,
new_m-version,
- cur_m-originating_usn,
- new_m-originating_usn,
cur_m-originating_change_time,
new_m-originating_change_time);
}
@@ -4004,8 +3996,6 @@ linked_attributes[0]:
la-meta_data.originating_invocation_id,
version,
la-meta_data.version,
- originating_usn,
- la-meta_data.originating_usn,
change_time,
la-meta_data.originating_change_time)) {
DEBUG(3,(Discarding older DRS linked attribute update
to %s on %s from %s\n,
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 058de59 s3: Fix connecting to port-139 only servers
from 585e9a0 s4-repl_meta_data: replmd_update_is_newer() should not
return true if metadata stamps are equal
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 058de59a8e197f6bd9de95dd5de709f018cce6d1
Author: Volker Lendecke v...@samba.org
Date: Sat Jan 22 16:22:42 2011 +0100
s3: Fix connecting to port-139 only servers
When the TCP RST came before the 5 msecs timeout kicked in, we
viewed this as final, as state-req_139 was not set yet.
Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Sat Jan 22 17:42:41 CET 2011 on sn-devel-104
---
Summary of changes:
source3/libsmb/smbsock_connect.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/libsmb/smbsock_connect.c b/source3/libsmb/smbsock_connect.c
index 174d2aa..352de85 100644
--- a/source3/libsmb/smbsock_connect.c
+++ b/source3/libsmb/smbsock_connect.c
@@ -253,12 +253,14 @@ struct tevent_req *smbsock_connect_send(TALLOC_CTX
*mem_ctx,
/*
* After 5 msecs, fire the 139 request
*/
- subreq = tevent_wakeup_send(state, ev, timeval_current_ofs(0, 5000));
- if (tevent_req_nomem(subreq, req)) {
+ state-req_139 = tevent_wakeup_send(
+ state, ev, timeval_current_ofs(0, 5000));
+ if (tevent_req_nomem(state-req_139, req)) {
TALLOC_FREE(state-req_445);
return tevent_req_post(req, ev);
}
- tevent_req_set_callback(subreq, smbsock_connect_do_139, req);
+ tevent_req_set_callback(state-req_139, smbsock_connect_do_139,
+ req);
return req;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-4-test updated
The branch, v3-4-test has been updated via 716426b WHATSNEW: Start release notes for Samba 3.4.11. via fa8af88 VERSION: Raise version number up to 3.4.11. from 0d069e7 WHATSNEW: Add major enhancements. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test - Log - commit 716426b31f24923e94099e99580ae7750eb5e498 Author: Karolin Seeger ksee...@samba.org Date: Sat Jan 22 19:43:40 2011 +0100 WHATSNEW: Start release notes for Samba 3.4.11. Karolin commit fa8af888f7c701ec95febdb90c57aee1e418ad2e Author: Karolin Seeger ksee...@samba.org Date: Sat Jan 22 19:41:28 2011 +0100 VERSION: Raise version number up to 3.4.11. Karolin --- Summary of changes: WHATSNEW.txt| 44 ++-- source3/VERSION |2 +- 2 files changed, 43 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 6023e8c..49753a5 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,4 +1,44 @@ == + Release Notes for Samba 3.4.11 + January , 2011 + == + + +This is the latest stable release of Samba 3.4. + +Major enhancements in Samba 3.4.11 include: + + o + +Changes since 3.4.10 + + + + +## +Reporting bugs Development Discussion +### + +Please discuss this release on the samba-technical mailing list or by +joining the #samba-technical IRC channel on irc.freenode.net. + +If you do report problems then please try to send high quality +feedback. If you don't provide vital information to help us track down +the problem then you will probably be ignored. All bug reports should +be filed under the Samba 3.4 product in the project's Bugzilla +database (https://bugzilla.samba.org/). + + +== +== Our Code, Our Bugs, Our Responsibility. +== The Samba Team +== + + +Release notes for older versions follow: + + + == Release Notes for Samba 3.4.10 January 22, 2011 == @@ -104,8 +144,8 @@ database (https://bugzilla.samba.org/). == -Release notes for older versions follow: - +-- + = Release Notes for Samba 3.4.9 diff --git a/source3/VERSION b/source3/VERSION index fbb3734..5978c99 100644 --- a/source3/VERSION +++ b/source3/VERSION @@ -25,7 +25,7 @@ SAMBA_VERSION_MAJOR=3 SAMBA_VERSION_MINOR=4 -SAMBA_VERSION_RELEASE=10 +SAMBA_VERSION_RELEASE=11 # Bug fix releases use a letter for the patch revision # -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-4-stable updated
The branch, v3-4-stable has been updated via 8dde27b WHATSNEW: Start release notes for Samba 3.4.11. via 6ebc313 VERSION: Raise version number up to 3.4.11. from 247949c WHATSNEW: Add major enhancements. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-stable - Log - commit 8dde27b777293a820b23843b2b363c3585349e98 Author: Karolin Seeger ksee...@samba.org Date: Sat Jan 22 19:43:40 2011 +0100 WHATSNEW: Start release notes for Samba 3.4.11. Karolin (cherry picked from commit 716426b31f24923e94099e99580ae7750eb5e498) commit 6ebc31365acbbcfe0f4aa7d5963517042b23154e Author: Karolin Seeger ksee...@samba.org Date: Sat Jan 22 19:41:28 2011 +0100 VERSION: Raise version number up to 3.4.11. Karolin (cherry picked from commit fa8af888f7c701ec95febdb90c57aee1e418ad2e) --- Summary of changes: WHATSNEW.txt| 44 ++-- source3/VERSION |2 +- 2 files changed, 43 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 6023e8c..49753a5 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,4 +1,44 @@ == + Release Notes for Samba 3.4.11 + January , 2011 + == + + +This is the latest stable release of Samba 3.4. + +Major enhancements in Samba 3.4.11 include: + + o + +Changes since 3.4.10 + + + + +## +Reporting bugs Development Discussion +### + +Please discuss this release on the samba-technical mailing list or by +joining the #samba-technical IRC channel on irc.freenode.net. + +If you do report problems then please try to send high quality +feedback. If you don't provide vital information to help us track down +the problem then you will probably be ignored. All bug reports should +be filed under the Samba 3.4 product in the project's Bugzilla +database (https://bugzilla.samba.org/). + + +== +== Our Code, Our Bugs, Our Responsibility. +== The Samba Team +== + + +Release notes for older versions follow: + + + == Release Notes for Samba 3.4.10 January 22, 2011 == @@ -104,8 +144,8 @@ database (https://bugzilla.samba.org/). == -Release notes for older versions follow: - +-- + = Release Notes for Samba 3.4.9 diff --git a/source3/VERSION b/source3/VERSION index ad6e361..2f5fdf3 100644 --- a/source3/VERSION +++ b/source3/VERSION @@ -25,7 +25,7 @@ SAMBA_VERSION_MAJOR=3 SAMBA_VERSION_MINOR=4 -SAMBA_VERSION_RELEASE=10 +SAMBA_VERSION_RELEASE=11 # Bug fix releases use a letter for the patch revision # -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via 60ceb0b s3: Fix connecting to port-139 only servers
from 1007dd3 s3-torture: fix uninitialized status code.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit 60ceb0bdc79427d29c1076a0094d9250d36e42c0
Author: Volker Lendecke v...@samba.org
Date: Sat Jan 22 16:22:42 2011 +0100
s3: Fix connecting to port-139 only servers
When the TCP RST came before the 5 msecs timeout kicked in, we
viewed this as final, as state-req_139 was not set yet.
Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Sat Jan 22 17:42:41 CET 2011 on sn-devel-104
---
Summary of changes:
source3/libsmb/smbsock_connect.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/libsmb/smbsock_connect.c b/source3/libsmb/smbsock_connect.c
index 174d2aa..352de85 100644
--- a/source3/libsmb/smbsock_connect.c
+++ b/source3/libsmb/smbsock_connect.c
@@ -253,12 +253,14 @@ struct tevent_req *smbsock_connect_send(TALLOC_CTX
*mem_ctx,
/*
* After 5 msecs, fire the 139 request
*/
- subreq = tevent_wakeup_send(state, ev, timeval_current_ofs(0, 5000));
- if (tevent_req_nomem(subreq, req)) {
+ state-req_139 = tevent_wakeup_send(
+ state, ev, timeval_current_ofs(0, 5000));
+ if (tevent_req_nomem(state-req_139, req)) {
TALLOC_FREE(state-req_445);
return tevent_req_post(req, ev);
}
- tevent_req_set_callback(subreq, smbsock_connect_do_139, req);
+ tevent_req_set_callback(state-req_139, smbsock_connect_do_139,
+ req);
return req;
}
--
Samba Shared Repository
