[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 04c0e5212d5 ctdb/build: fix ctdb_mutex_ceph_rados_helper builds
from ae9fb93393b s4 lib socket: Ensure address string owned by parent
struct
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 04c0e5212d53e8018f631927bd7d07edd724b77c
Author: David Disseldorp
Date: Thu Apr 18 20:14:31 2019 +0200
ctdb/build: fix ctdb_mutex_ceph_rados_helper builds
2b5dbb352553699afce62dca4964eb0bd64477f8 fixed builds with an explicit
--with-libcephfs but broke builds against system Ceph libraries. This
change handles both cases.
Signed-off-by: David Disseldorp
Reviewed-by: Martin Schwenke
Autobuild-User(master): Martin Schwenke
Autobuild-Date(master): Thu May 9 04:24:56 UTC 2019 on sn-devel-184
---
Summary of changes:
ctdb/wscript | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/ctdb/wscript b/ctdb/wscript
index eccc5e76f48..614e042bd70 100644
--- a/ctdb/wscript
+++ b/ctdb/wscript
@@ -680,10 +680,13 @@ def build(bld):
destname='README')
if bld.env.HAVE_LIBRADOS:
+rados_inc = ' include'
+if bld.CONFIG_GET('CPPPATH_RADOS') is not None:
+rados_inc = bld.CONFIG_GET('CPPPATH_RADOS') + rados_inc
bld.SAMBA_BINARY('ctdb_mutex_ceph_rados_helper',
source='utils/ceph/ctdb_mutex_ceph_rados_helper.c',
deps='talloc tevent rados ceph-common',
-includes=bld.CONFIG_GET('CPPPATH_RADOS'),
+includes=rados_inc,
install_path='${CTDB_HELPER_BINDIR}')
sed_expr1 = 's|/usr/local/var/lib/ctdb|%s|g' % (bld.env.CTDB_VARDIR)
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via ae9fb93393b s4 lib socket: Ensure address string owned by parent
struct
from b93ae77a6f4 g_lock: Fix a typo
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit ae9fb93393bcadbc71328335e481e4381ecb65bf
Author: Gary Lockyer
Date: Tue May 7 16:30:22 2019 +1200
s4 lib socket: Ensure address string owned by parent struct
The local address string was not owned by it's parent structure, which
caused a use after free error in
continue_ip_open_socket source4/librpc/rpc/dcerpc_sock.c:267
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13929
Signed-off-by: Gary Lockyer
Reviewed-by: Andrew Bartlett
Autobuild-User(master): Andrew Bartlett
Autobuild-Date(master): Wed May 8 20:03:42 UTC 2019 on sn-devel-184
---
Summary of changes:
source4/lib/socket/socket_ip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source4/lib/socket/socket_ip.c b/source4/lib/socket/socket_ip.c
index fd109a3eacd..2aba491e06c 100644
--- a/source4/lib/socket/socket_ip.c
+++ b/source4/lib/socket/socket_ip.c
@@ -999,7 +999,7 @@ static struct socket_address *ipv6_tcp_get_my_addr(struct
socket_context *sock,
return NULL;
}
- local->addr = talloc_strdup(mem_ctx, addrstring);
+ local->addr = talloc_strdup(local, addrstring);
if (!local->addr) {
talloc_free(local);
return NULL;
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via b93ae77a6f4 g_lock: Fix a typo via 8992cf4aec4 g_lock: Apply some const via 08a31c9092b dbwrap: Adapt tdb_data_buf's overflow handling to modern conventions via 30abea88151 dbwrap: Fix tdb_data_buf() via 2b957bde5a2 s3:utils: If share is NULL in smbcacls, don't print it via 3653dc70135 s3:utils: If share is NULL in smbcquotas, don't print it via e333425e0ff s3:winbindd: Do not free db_path in idmap_tdb2 before we printed it via 830cb7e6756 ctdb:common: Do not print NULL if we don't get a sockpath via 46f036d3231 s4:torture: Do not free full_name before we printed it via a8f773e326d lib:torture: Fix string comparison macros where we directly pass NULL via be72dfbc8ed s4:torture: Do not print NULL strings we just checked before via 6da032df545 s4:ntvfs: Do not free eadb before we printed an error via 790d7e34cbe s3:rpc_server: Do not free the tdbname before we printed it via bd29f3fcc02 s4:auth: Fix debug statement in gensec_gssapi from 93061fb822d CID 1363286: Resource leak by failing to free tmp_ctx https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit b93ae77a6f44a9eb43aae8ed8abfc4149d7b8fef Author: Volker Lendecke Date: Mon May 6 16:34:15 2019 +0200 g_lock: Fix a typo Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed May 8 17:47:39 UTC 2019 on sn-devel-184 commit 8992cf4aec4750afa9b6a632d26fabf333801525 Author: Volker Lendecke Date: Mon May 6 16:19:22 2019 +0200 g_lock: Apply some const Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 08a31c9092b808a49ecdf92e8cc0ae9132ba6645 Author: Volker Lendecke Date: Fri May 3 15:43:35 2019 +0200 dbwrap: Adapt tdb_data_buf's overflow handling to modern conventions This is the way we do it right now, avoid confusion why "tmp" might be needed Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 30abea8815113045b7ee075352c415fe176a48fe Author: Volker Lendecke Date: Fri May 3 15:42:42 2019 +0200 dbwrap: Fix tdb_data_buf() IIRC there are platforms that don't like memcpy() with len=0. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 2b957bde5a2f0f670ee0c8acde6edae1f4aaf253 Author: Andreas Schneider Date: Wed May 8 17:12:12 2019 +0200 s3:utils: If share is NULL in smbcacls, don't print it Found by GCC 9. Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison commit 3653dc7013518d90e6deb08a1f21d7472dc86675 Author: Andreas Schneider Date: Wed May 8 17:11:13 2019 +0200 s3:utils: If share is NULL in smbcquotas, don't print it Found by GCC 9. Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison commit e333425e0ff6be5691b74a920610b508e7d26892 Author: Andreas Schneider Date: Wed May 8 17:05:58 2019 +0200 s3:winbindd: Do not free db_path in idmap_tdb2 before we printed it Found by GCC 9. Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison commit 830cb7e67568de5f3ce359cb6af3be8ab545c824 Author: Andreas Schneider Date: Wed May 8 17:03:54 2019 +0200 ctdb:common: Do not print NULL if we don't get a sockpath sock_socket_start_recv() might not fill sockpath if we return early. Found by GCC 9. Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison commit 46f036d3231bc99cf37c7cabf82757d3c28c5cff Author: Andreas Schneider Date: Wed May 8 16:58:07 2019 +0200 s4:torture: Do not free full_name before we printed it Found by GCC 9. Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison commit a8f773e326d6bdfc1c9eb87a74c00108f6620c56 Author: Andreas Schneider Date: Wed May 8 16:54:30 2019 +0200 lib:torture: Fix string comparison macros where we directly pass NULL See e.g. lib/util/tests/strlist.c +177 Found by GCC 9. Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison commit be72dfbc8edc53ed191dc01668a53cafb5cd785d Author: Andreas Schneider Date: Wed May 8 16:51:20 2019 +0200 s4:torture: Do not print NULL strings we just checked before Found by GCC 9. Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison commit 6da032df5450ef72f8608a19b3b5cc6e9185cd6e Author: Andreas Schneider Date: Wed May 8 16:32:45 2019 +0200 s4:ntvfs: Do not free eadb before we printed an error Found by GCC 9. Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison commit 790d7e34cbe4e190d6acdd24696efe53944cd4a6 Author: Andreas Schneider Date: Wed May 8 16:31:10 2019 +0200 s3:rpc_server: Do
autobuild[sn-devel-184]: intermittent test failure detected
The autobuild test system (on sn-devel-184) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-05-08-1107/flakey.log The failure seems to be in the "samba-nt4" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-05-08-1107/samba-nt4.stderr https://git.samba.org/autobuild.flakey.sn-devel-184/2019-05-08-1107/samba-nt4.stdout The top commit at the time of the failure was: commit 93061fb822d5af5c29f223e9fe1ce91b7264f082 Author: Garming Sam Date: Tue May 7 13:28:49 2019 +1200 CID 1363286: Resource leak by failing to free tmp_ctx There are a few oddities in this function, including a duplicated NULL check, a talloc_free of a context which is passed in and a number of missing frees before a return. Signed-off-by: Garming Sam Reviewed-by: Gary Lockyer Autobuild-User(master): Gary Lockyer Autobuild-Date(master): Wed May 8 00:36:14 UTC 2019 on sn-devel-184 and the last 50 lines of the stdout log were: [545(2507)/589 at 37m23s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_dc:local) [546(2508)/589 at 37m23s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_dc:local) [547(2509)/589 at 37m23s] samba.wbinfo_simple.change-secret.domain=$DOMAIN(nt4_dc:local) [548(2510)/589 at 37m23s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_dc:local) [549(2511)/589 at 37m23s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_dc:local) [550(2512)/589 at 37m24s] samba.wbinfo_simple.domain-users(nt4_dc:local) [551(2513)/589 at 37m24s] samba.wbinfo_simple.domain-groups(nt4_dc:local) [552(2514)/589 at 37m24s] samba.wbinfo_simple.name-to-sid=$DC_USERNAME(nt4_dc:local) [553(2515)/589 at 37m24s] samba.wbinfo_simple.name-to-sid=$DOMAIN/$DC_USERNAME(nt4_dc:local) [554(2516)/589 at 37m24s] samba.wbinfo_simple.user-info=$DOMAIN/$DC_USERNAME(nt4_dc:local) [555(2517)/589 at 37m24s] samba.wbinfo_simple.user-groups=$DOMAIN/$DC_USERNAME(nt4_dc:local) [556(2518)/589 at 37m24s] samba.wbinfo_simple.authenticate=$DOMAIN/$DC_USERNAME%$DC_PASSWORD(nt4_dc:local) [557(2519)/589 at 37m25s] samba.wbinfo_simple.allocate-uid(nt4_dc:local) [558(2520)/589 at 37m25s] samba.wbinfo_simple.allocate-gid(nt4_dc:local) [559(2521)/589 at 37m25s] samba.wbinfo_sids2xids.(nt4_dc:local)(nt4_dc:local) [560(2522)/589 at 37m33s] samba.tests.ntlm_auth(nt4_dc:local) [561(2535)/589 at 37m35s] samba.wbinfo_simple.ping(nt4_member:local) [562(2536)/589 at 37m35s] samba.wbinfo_simple.separator(nt4_member:local) [563(2537)/589 at 37m35s] samba.wbinfo_simple.own-domain(nt4_member:local) [564(2538)/589 at 37m35s] samba.wbinfo_simple.all-domains(nt4_member:local) [565(2539)/589 at 37m36s] samba.wbinfo_simple.trusted-domains(nt4_member:local) [566(2540)/589 at 37m36s] samba.wbinfo_simple.domain-info=BUILTIN(nt4_member:local) [567(2541)/589 at 37m36s] samba.wbinfo_simple.domain-info=$DOMAIN(nt4_member:local) [568(2542)/589 at 37m36s] samba.wbinfo_simple.online-status(nt4_member:local) [569(2543)/589 at 37m36s] samba.wbinfo_simple.online-status.domain=BUILTIN(nt4_member:local) [570(2544)/589 at 37m36s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_member:local) [571(2545)/589 at 37m36s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_member:local) UNEXPECTED(failure): samba.wbinfo_simple.check-secret.domain=SAMBA-TEST.wbinfo(nt4_member:local) REASON: Exception: Exception: wbcCheckTrustCredentials(SAMBA-TEST): error code was NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND (0xc233) failed to call wbcCheckTrustCredentials: WBC_ERR_AUTH_ERROR Could not check secret checking the trust secret for domain SAMBA-TEST via RPC calls failed FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba3.smb2.lease(nt4_dc) -> 159 samba3.blackbox.net.rpc.conf(nt4_dc) -> 146 samba3.raw.notify(nt4_dc) -> 107 samba3.smb2.oplock(nt4_dc) -> 103 samba3.blackbox.net.local.conf(nt4_dc:local) -> 95 samba3.smb2.notify(nt4_dc) -> 81 samba3.rpc.samr.passwords.lockout(nt4_dc) -> 61 samba4.rpc.echo on ncacn_np with object(nt4_dc) -> 60 samba3.raw.search(nt4_dc) -> 55 samba3.smb2.compound_find(nt4_dc) -> 53 ERROR: test failed with exit code 1 Makefile:16: recipe for target 'test' failed
