[Scons-dev] Found and fixed bug regarding variant_dir on cygwin
Hello, At this moment variant_dir option does not work on Cygwin due to the fact that it does not copy headers (I reported this on scons-users a few days ago). After some digging into the source code I found that for headers it makes the path upper case for source dir listing, but not for the file to be copied that is checked versus the dir listing. The problem cand be fixed with a simple modification in FS.py on line 1844 (function entry_exists_on_disk) by extending the condition to also include cygwin: if sys.platform == 'win32' or sys.platform == 'cygwin': Hoping this will get included in the next version :) Regards, Bogdan Tenea Senior Software Engineer II Ixia RO Stack Manager Dev ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] Found and fixed bug regarding variant_dir on cygwin
Do you have a small test case to demonstrate the issue? -Bill On Sun, Sep 29, 2013 at 6:34 AM, Bogdan Tenea bte...@ixiacom.com wrote: Hello, ** ** At this moment variant_dir option does not work on Cygwin due to the fact that it does not copy headers (I reported this on scons-users a few days ago). After some digging into the source code I found that for headers it makes the path upper case for source dir listing, but not for the file to be copied that is checked versus the dir listing. The problem cand be fixed with a simple modification in FS.py on line 1844 (function entry_exists_on_disk) by extending the condition to also include cygwin: if sys.platform == 'win32' or sys.platform == 'cygwin':*** * ** ** Hoping this will get included in the next version J ** ** Regards, ** ** Bogdan Tenea Senior Software Engineer II Ixia RO Stack Manager Dev ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
[Scons-dev] mercurial vs. git
Now that we've all been living with hg for a while, what are people's opinions on hg vs. git for SCons? I'll admit I'm much deeper into git these days and I think overall it's a better system. But I'm interested in what you all think. We could switch pretty easily if there was enough interest, or we could just stay with hg and get on with life. :-) -- Gary ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] mercurial vs. git
+1 git (I only use hg for scons, I use git for everything else. So not a technical reason, but a brain caching reason) On Sun, Sep 29, 2013 at 11:07 AM, Gary Oberbrunner ga...@oberbrunner.comwrote: Now that we've all been living with hg for a while, what are people's opinions on hg vs. git for SCons? I'll admit I'm much deeper into git these days and I think overall it's a better system. But I'm interested in what you all think. We could switch pretty easily if there was enough interest, or we could just stay with hg and get on with life. :-) -- Gary ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] mercurial vs. git
On 29.09.2013 20:07, Gary Oberbrunner wrote: Now that we've all been living with hg for a while, what are people's opinions on hg vs. git for SCons? I'll admit I'm much deeper into git these days and I think overall it's a better system. But I'm interested in what you all think. We could switch pretty easily if there was enough interest, or we could just stay with hg and get on with life. :-) At the moment I see no compelling reason to change our VCS again. Our current workflows are fine and documented (a bit). Since SCons switched to hg, I'm now using it for all my private work as well and am quite happy with it. So, my bias leans more towards hg. -1 from me, but I wouldn't run away from the project if I had to use git in the future. Regards, Dirk ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] SCons speedup and profiling results...
On 26.09.2013 02:08, Gary Oberbrunner wrote: [...] I think this is excellent work! Solid analysis. I know there's been some thought given to caching subst() before; it's trickier than one might think but in many cases it should work, and it definitely speeds things up. I'm also impressed by a 30% memory reduction -- interested to hear how that comes out. I continued my work on reducing the overall memory consumption in SCons. By combining my old branch (where I switched the core to using slots) with some additional patches, I am now able to save up to 50% memory...depending on the project. Please find some results attached (a comparison between the current default tip and my experimental branch), the code can be cloned from: hg clone http://bitbucket.org/dirkbaechle/scons_experimental -r reduced_memory_updated I also achieved up to 20% speed improvements on updates, by a first version of a caching for the env.subst() method. Best regards, Dirk Title: Comparing default to lowmem wonderbuild Times Runrun [s]update [s]update_implicit [s] Previous1172.325.619.4 Current1131.622.015.5 Factor0.970.860.80 Memory Runrun [MByte]update [MByte] Previous451.4424.2 Current251.5197.8 Factor0.560.47 sconsbld Times Runrun [s]update [s]update_implicit [s] Previous440.335.026.1 Current343.828.719.8 Factor0.780.820.76 Memory Runrun [MByte]update [MByte] Previous538.6554.4 Current231.6238.7 Factor0.430.43 questfperf Times Runrun [s]update [s]update_implicit [s] Previous1022.424.216.9 Current984.820.412.9 Factor0.960.840.77 Memory Runrun [MByte]update [MByte] Previous378.9391.1 Current210.9196.3 Factor0.560.50 mapnik Times Runrun [s]update [s]update_implicit [s] Previous867.212.54.7 Current867.59.44.1 Factor1.000.750.87 Memory Runrun [MByte]update [MByte] Previous151.5144.1 Current110.9110.7 Factor0.730.77 ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] mercurial vs. git
Anatoly, On Sep 29, 2013, at 12:19 PM, anatoly techtonik techto...@gmail.com wrote: On Sun, Sep 29, 2013 at 9:07 PM, Gary Oberbrunner ga...@oberbrunner.com wrote: Now that we've all been living with hg for a while, what are people's opinions on hg vs. git for SCons? I'll admit I'm much deeper into git these days and I think overall it's a better system. But I'm interested in what you all think. We could switch pretty easily if there was enough interest, or we could just stay with hg and get on with life. :-) My choice is mostly dictated by language. If I used Git, I probably used CMake or premake. The only advantage of Git I see is GitHub. Otherwise both are on par. Git has logical feature branches and dumb repeated add/commit commands. Mercurial screws feature branches concept, but MQs are awesome. So -1, as will require migrating to GitHub and we still haven't done anything awesome since last migration. =/ Switching to git would not require switching to github. Bitbucket.org has supported git for quite some time. -Bill ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] SCons speedup and profiling results...
Dirk, That's awesome!! Very impressive work. Brady On Sep 29, 2013 9:06 PM, Dirk Bächle tshor...@gmx.de wrote: On 26.09.2013 02:08, Gary Oberbrunner wrote: [...] I think this is excellent work! Solid analysis. I know there's been some thought given to caching subst() before; it's trickier than one might think but in many cases it should work, and it definitely speeds things up. I'm also impressed by a 30% memory reduction -- interested to hear how that comes out. I continued my work on reducing the overall memory consumption in SCons. By combining my old branch (where I switched the core to using slots) with some additional patches, I am now able to save up to 50% memory...depending on the project. Please find some results attached (a comparison between the current default tip and my experimental branch), the code can be cloned from: hg clone http://bitbucket.org/**dirkbaechle/scons_experimentalhttp://bitbucket.org/dirkbaechle/scons_experimental-r reduced_memory_updated I also achieved up to 20% speed improvements on updates, by a first version of a caching for the env.subst() method. Best regards, Dirk ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] Found and fixed bug regarding variant_dir on cygwin
I integrated this. Thanks, Bogdan. (Test case would be ideal but since it only happens on cygwin and the fix is obvious, I just put it in.) On Sun, Sep 29, 2013 at 9:34 AM, Bogdan Tenea bte...@ixiacom.com wrote: Hello, ** ** At this moment variant_dir option does not work on Cygwin due to the fact that it does not copy headers (I reported this on scons-users a few days ago). After some digging into the source code I found that for headers it makes the path upper case for source dir listing, but not for the file to be copied that is checked versus the dir listing. The problem cand be fixed with a simple modification in FS.py on line 1844 (function entry_exists_on_disk) by extending the condition to also include cygwin: if sys.platform == 'win32' or sys.platform == 'cygwin':*** * ** ** Hoping this will get included in the next version J ** ** Regards, ** ** Bogdan Tenea Senior Software Engineer II Ixia RO Stack Manager Dev ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev -- Gary ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
