Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t… [v2]
On Tue, 8 Dec 2020 18:42:22 GMT, Xue-Lei Andrew Fan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated with implSpec tag > > Marked as reviewed by xuelei (Reviewer). This will also require a CSR since you are making some specification changes. I'm not sure if you were trying to get this into 16, but it is probably too late to make JDK 16 since RDP is a couple of days away. You can push to 17/latest once 16 forks and CSR is approved. - PR: https://git.openjdk.java.net/jdk/pull/1701
Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t… [v2]
On Tue, 8 Dec 2020 18:36:15 GMT, Hai-May Chao wrote: >> This is a spec change with noreg-doc label. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Updated with implSpec tag Marked as reviewed by xuelei (Reviewer). src/java.base/share/classes/java/security/KeyStoreSpi.java line 322: > 320: * @throwsCertificateException if any of the certificates > included in > 321: * the keystore data could not be stored > 322: * @throws UnsupportedOperationException if the implementation Please add an extra white space after the "throws" tag so that this line align with the lines above. - PR: https://git.openjdk.java.net/jdk/pull/1701
Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t… [v2]
On Tue, 8 Dec 2020 18:08:38 GMT, Xue-Lei Andrew Fan wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated with implSpec tag
>
> src/java.base/share/classes/java/security/KeyStoreSpi.java line 319:
>
>> 317: * @throwsCertificateException if any of the certificates
>> included in
>> 318: * the keystore data could not be stored
>> 319: * @throwsUnsupportedOperationException if this method is not
>> supported
>
> We might be able to get it more clear about the behavior. For example,
> adding an implSpec tag, like:
> * @implSpec The default implementation throws
> * an {@link UnsupportedOperationException}.
> ...
> * @throws UnsupportedOperationException if the implementation
> * has not overridden this method
tag implSpec added. Thanks for the review.
-
PR: https://git.openjdk.java.net/jdk/pull/1701
Re: RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch t… [v2]
> This is a spec change with noreg-doc label. Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision: Updated with implSpec tag - Changes: - all: https://git.openjdk.java.net/jdk/pull/1701/files - new: https://git.openjdk.java.net/jdk/pull/1701/files/496360a7..a153f4f3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1701=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1701=00-01 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1701.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1701/head:pull/1701 PR: https://git.openjdk.java.net/jdk/pull/1701
