Re: RFR 8174909: Doc error in SecureRandom

2017-02-14 Thread Sean Mullan

Looks good.

--Sean

On 2/14/17 5:55 AM, Wang Weijun wrote:

Please review this doc bug

diff --git
a/src/java.base/share/classes/java/security/DrbgParameters.java
b/src/java.base/share/classes/java/security/DrbgParameters.java
--- a/src/java.base/share/classes/java/security/DrbgParameters.java
+++ b/src/java.base/share/classes/java/security/DrbgParameters.java
@@ -53,8 +53,8 @@
  * for CTR_DRBG. Please note that it is not the algorithm used in
  * {@link SecureRandom#getInstance}, which we will call a
  * SecureRandom algorithm below),
- *  optionally features, including prediction resistance
- * and reseeding supports.
+ *  optional features, including prediction resistance
+ * and reseeding supports,
  *  highest security strength.
  * 
  * 
diff --git a/src/java.base/share/classes/java/security/SecureRandom.java
b/src/java.base/share/classes/java/security/SecureRandom.java
--- a/src/java.base/share/classes/java/security/SecureRandom.java
+++ b/src/java.base/share/classes/java/security/SecureRandom.java
@@ -64,8 +64,8 @@
  * 
  * SecureRandom r1 = new SecureRandom();
  * SecureRandom r2 = SecureRandom.getInstance("NativePRNG");
- * SecureRandom r3 = SecureRandom("DRBG",
- * DrbgParameters.Instantiation(128, RESEED_ONLY, null));
+ * SecureRandom r3 = SecureRandom.getInstance("DRBG",
+ * DrbgParameters.instantiation(128, RESEED_ONLY, null));
  * 
  *
  *  The third statement above returns a {@code SecureRandom} object
of the

Thanks
Max


RFR 8174909: Doc error in SecureRandom

2017-02-14 Thread Wang Weijun

Please review this doc bug

diff --git 
a/src/java.base/share/classes/java/security/DrbgParameters.java 
b/src/java.base/share/classes/java/security/DrbgParameters.java

--- a/src/java.base/share/classes/java/security/DrbgParameters.java
+++ b/src/java.base/share/classes/java/security/DrbgParameters.java
@@ -53,8 +53,8 @@
  * for CTR_DRBG. Please note that it is not the algorithm used in
  * {@link SecureRandom#getInstance}, which we will call a
  * SecureRandom algorithm below),
- *  optionally features, including prediction resistance
- * and reseeding supports.
+ *  optional features, including prediction resistance
+ * and reseeding supports,
  *  highest security strength.
  * 
  * 
diff --git a/src/java.base/share/classes/java/security/SecureRandom.java 
b/src/java.base/share/classes/java/security/SecureRandom.java

--- a/src/java.base/share/classes/java/security/SecureRandom.java
+++ b/src/java.base/share/classes/java/security/SecureRandom.java
@@ -64,8 +64,8 @@
  * 
  * SecureRandom r1 = new SecureRandom();
  * SecureRandom r2 = SecureRandom.getInstance("NativePRNG");
- * SecureRandom r3 = SecureRandom("DRBG",
- * DrbgParameters.Instantiation(128, RESEED_ONLY, null));
+ * SecureRandom r3 = SecureRandom.getInstance("DRBG",
+ * DrbgParameters.instantiation(128, RESEED_ONLY, null));
  * 
  *
  *  The third statement above returns a {@code SecureRandom} object 
of the


Thanks
Max