Re: RFR JDK-8219989 : Retire the com.sun.net.ssl.internal.ssl.Provider name
Good to have a CSR. Please review: CSR: https://bugs.openjdk.java.net/browse/JDK-8240974 Thanks, Xuelei On 3/12/2020 2:29 PM, Sean Mullan wrote: The fix looks good, although I think you should also file a CSR since this provider name was at one time documented and supported and you mentioned that it was still supported in the previous CSR when the com.sun.net.ssl package was removed [1]. Thanks, Sean [1] https://bugs.openjdk.java.net/browse/JDK-8218932 On 3/12/20 1:39 PM, Xuelei Fan wrote: Hi, Could I get the following update reviewed? Bug#: https://bugs.openjdk.java.net/browse/JDK-8219989 Webrev: http://cr.openjdk.java.net/~xuelei/8219989/webrev.00/ Release note task: https://bugs.openjdk.java.net/browse/JDK-8240967 This is a request to remove the legacy SunJSSE provider name, "com.sun.net.ssl.internal.ssl.Provider". The "SunJSSE" should be used instead (for example, "SSLContext.getInstance("TLS", "SunJSSE")"). The use of the legacy provider name should be rare now. But please let me know if you have concerns before March 19, 2019. Thanks, Xuelei
Re: RFR JDK-8219989 : Retire the com.sun.net.ssl.internal.ssl.Provider name
The fix looks good, although I think you should also file a CSR since this provider name was at one time documented and supported and you mentioned that it was still supported in the previous CSR when the com.sun.net.ssl package was removed [1]. Thanks, Sean [1] https://bugs.openjdk.java.net/browse/JDK-8218932 On 3/12/20 1:39 PM, Xuelei Fan wrote: Hi, Could I get the following update reviewed? Bug#: https://bugs.openjdk.java.net/browse/JDK-8219989 Webrev: http://cr.openjdk.java.net/~xuelei/8219989/webrev.00/ Release note task: https://bugs.openjdk.java.net/browse/JDK-8240967 This is a request to remove the legacy SunJSSE provider name, "com.sun.net.ssl.internal.ssl.Provider". The "SunJSSE" should be used instead (for example, "SSLContext.getInstance("TLS", "SunJSSE")"). The use of the legacy provider name should be rare now. But please let me know if you have concerns before March 19, 2019. Thanks, Xuelei
Re: RFR JDK-8219989 : Retire the com.sun.net.ssl.internal.ssl.Provider name
Hi Xuelei, Looks good to me. Hai-May > On Mar 12, 2020, at 10:39 AM, Xuelei Fan wrote: > > Hi, > > Could I get the following update reviewed? > > Bug#: https://bugs.openjdk.java.net/browse/JDK-8219989 > Webrev: http://cr.openjdk.java.net/~xuelei/8219989/webrev.00/ > Release note task: https://bugs.openjdk.java.net/browse/JDK-8240967 > > This is a request to remove the legacy SunJSSE provider name, > "com.sun.net.ssl.internal.ssl.Provider". The "SunJSSE" should be used > instead (for example, "SSLContext.getInstance("TLS", "SunJSSE")"). > > The use of the legacy provider name should be rare now. But please let me > know if you have concerns before March 19, 2019. > > Thanks, > Xuelei
RFR JDK-8219989 : Retire the com.sun.net.ssl.internal.ssl.Provider name
Hi, Could I get the following update reviewed? Bug#: https://bugs.openjdk.java.net/browse/JDK-8219989 Webrev: http://cr.openjdk.java.net/~xuelei/8219989/webrev.00/ Release note task: https://bugs.openjdk.java.net/browse/JDK-8240967 This is a request to remove the legacy SunJSSE provider name, "com.sun.net.ssl.internal.ssl.Provider". The "SunJSSE" should be used instead (for example, "SSLContext.getInstance("TLS", "SunJSSE")"). The use of the legacy provider name should be rare now. But please let me know if you have concerns before March 19, 2019. Thanks, Xuelei