[jira] [Created] (JAMES-2090) Configure Cassandra constant
Tellier Benoit created JAMES-2090: - Summary: Configure Cassandra constant Key: JAMES-2090 URL: https://issues.apache.org/jira/browse/JAMES-2090 Project: James Server Issue Type: Improvement Components: cassandra Reporter: Tellier Benoit Cassandra code embed many constants, controlling the number of retries, the size of reads, prefetching, notably. We want to be able to re-configure these value without having to re-commit code, thus we should expose it to the configuration. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2089) Provided spring configuration should work "out of the box"
[ https://issues.apache.org/jira/browse/JAMES-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074197#comment-16074197 ] Tellier Benoit commented on JAMES-2089: --- https://github.com/linagora/james-project/pull/879 for review > Provided spring configuration should work "out of the box" > -- > > Key: JAMES-2089 > URL: https://issues.apache.org/jira/browse/JAMES-2089 > Project: James Server > Issue Type: Bug > Components: Spring Container >Reporter: Tellier Benoit > > Currently, Spring packaging expects the user to rename template files. > We should remove this step as it is error prone and the source of many > questions. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2088) Some READMEs are outdate
[ https://issues.apache.org/jira/browse/JAMES-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074196#comment-16074196 ] Tellier Benoit commented on JAMES-2088: --- https://github.com/linagora/james-project/pull/879 putted this in review > Some READMEs are outdate > > > Key: JAMES-2088 > URL: https://issues.apache.org/jira/browse/JAMES-2088 > Project: James Server > Issue Type: Improvement > Components: Documentation >Affects Versions: master >Reporter: Tellier Benoit > Fix For: master > > > Some readmes are clearly oudated. I would advocate deleting them. > https://github.com/apache/james-project/blob/master/server/Overview.md Is a > duplicate from website content. > https://github.com/apache/james-project/blob/master/server/README.txt Also > https://github.com/apache/james-project/blob/master/server/NOTICE is a > duplicate for LICENSE > https://github.com/apache/james-project/blob/master/server/BUILD.txt do not > seem useful. It is less detailed than > https://github.com/apache/james-project/blob/master/README.adoc > We should take time to review project structure and remove what is not > appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Updated] (JAMES-2089) Provided spring configuration should work "out of the box"
[ https://issues.apache.org/jira/browse/JAMES-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tellier Benoit updated JAMES-2089: -- Component/s: Spring Container > Provided spring configuration should work "out of the box" > -- > > Key: JAMES-2089 > URL: https://issues.apache.org/jira/browse/JAMES-2089 > Project: James Server > Issue Type: Bug > Components: Spring Container >Reporter: Tellier Benoit > > Currently, Spring packaging expects the user to rename template files. > We should remove this step as it is error prone and the source of many > questions. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (JAMES-2089) Provided spring configuration should work "out of the box"
Tellier Benoit created JAMES-2089: - Summary: Provided spring configuration should work "out of the box" Key: JAMES-2089 URL: https://issues.apache.org/jira/browse/JAMES-2089 Project: James Server Issue Type: Bug Reporter: Tellier Benoit Currently, Spring packaging expects the user to rename template files. We should remove this step as it is error prone and the source of many questions. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Release james-server into 3.0.0
Tests and readme are OK to me. The conf folder is only populated with -template.xml - IMHO we should provide upon the template a full set of default configuration xml files so that the server starts out-of-the-box. On 04/07/17 14:03, Benoit Tellier wrote: Hi Eric, My answers inlined. Cheers, Benoit Le 04/07/2017 à 17:41, Eric Charles a écrit : I have successfully built with skipTests With tests enabled, it failed two times (one at es module, the other at the web integration module) to finally succeed after relaunch. This can be considered and flaky tests and is good to me. We got a green build: https://james.open-paas.org/ However, when I launch the binary distribution without any change, I get and exception [1], which is a blocker to me. You are missing a configuration file: Caused by: org.apache.commons.configuration.ConfigurationException: Unable to load configuration for component indexer Please have a look to the docker sample configuration : https://github.com/apache/james-project/tree/master/dockerfiles/run/spring/destination/conf Moreover, these files are included in sample configuration: https://github.com/apache/james-project/tree/master/server/app/src/main/resources So it is in my opinion not a blocker. Thus it do not require any fix. Can we fix this, I will try again, and then relaunch a vote? Also, there are 3 README is the top folder of the distribution tarball: README README.crypto README.txt README.crypto is fine, but content of the 2 other don't help a new-comer to start (no information on how to start the server, read the logs...) - Ideally we should just have a README.md. The base repository exposed on the website does only have one readme: https://github.com/apache/james-project/ Concerning the READMEs you points (which needs code navigation from james-project), they are clearly oudated. I would advocate deleting them. https://github.com/apache/james-project/blob/master/server/Overview.md Is a duplicate from website content. https://github.com/apache/james-project/blob/master/server/README.txt Also https://github.com/apache/james-project/blob/master/server/NOTICE is a duplicate for LICENSE https://github.com/apache/james-project/blob/master/server/BUILD.txt do not seem useful. It is less detailed than https://github.com/apache/james-project/blob/master/README.adoc However, should we really delay the release for issues not related to the issue? (and thus not bundled with it?) This can be fixed on the master branch, which is the first one seen when reaching github, even if handled after 3.0. See the related JIRA https://issues.apache.org/jira/browse/JAMES-2088 . Thx, Eric INFO 12:35:07,284 | org.apache.james.container.spring.context.JamesServerApplicationContext | Refreshing org.apache.james.container.spring.context.JamesServerApplicationContext@60c5aa8d: startup date [Tue Jul 04 12:35:07 CEST 2017]; root of context hierarchy WARN 12:35:08,626 | org.apache.james.container.spring.context.JamesServerApplicationContext | Exception encountered during context initialization - cancelling refresh attempt org.springframework.beans.FatalBeanException: Unable to config the indexer; nested exception is org.apache.commons.configuration.ConfigurationException: Unable to load configuration for component indexer at org.apache.james.container.spring.bean.factorypostprocessor.IndexerConfigurationBeanFactoryPostProcessor.postProcessBeanFactory(IndexerConfigurationBeanFactoryPostProcessor.java:70) at org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:696) at org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:686) at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:461) at org.springframework.context.support.ClassPathXmlApplicationContext.(ClassPathXmlApplicationContext.java:139) at org.springframework.context.support.ClassPathXmlApplicationContext.(ClassPathXmlApplicationContext.java:93) at org.apache.james.container.spring.context.JamesServerApplicationContext.(JamesServerApplicationContext.java:40) at org.apache.james.app.spring.JamesAppSpringMain.init(JamesAppSpringMain.java:61) at org.apache.james.app.spring.JamesAppSpringMain.main(JamesAppSpringMain.java:42) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.tanukisoftware.wrapper.WrapperSimpleApp.run(WrapperSimpleApp.java:240) at java.lang.Thread.run(Thread.java:745) Caused by: org.apache.commons.configuration.ConfigurationException: Unable to load configuration for component indexer at
Re: Release james-server into 3.0.0
Hi Eric, My answers inlined. Cheers, Benoit Le 04/07/2017 à 17:41, Eric Charles a écrit : > I have successfully built with skipTests > > With tests enabled, it failed two times (one at es module, the other > at the web integration module) to finally succeed after relaunch. This > can be considered and flaky tests and is good to me. We got a green build: https://james.open-paas.org/ > > However, when I launch the binary distribution without any change, I > get and exception [1], which is a blocker to me. You are missing a configuration file: Caused by: org.apache.commons.configuration.ConfigurationException: Unable to load configuration for component indexer Please have a look to the docker sample configuration : https://github.com/apache/james-project/tree/master/dockerfiles/run/spring/destination/conf Moreover, these files are included in sample configuration: https://github.com/apache/james-project/tree/master/server/app/src/main/resources So it is in my opinion not a blocker. Thus it do not require any fix. > > Can we fix this, I will try again, and then relaunch a vote? > > Also, there are 3 README is the top folder of the distribution tarball: > README > README.crypto > README.txt > > README.crypto is fine, but content of the 2 other don't help a > new-comer to start (no information on how to start the server, read > the logs...) - Ideally we should just have a README.md. The base repository exposed on the website does only have one readme: https://github.com/apache/james-project/ Concerning the READMEs you points (which needs code navigation from james-project), they are clearly oudated. I would advocate deleting them. https://github.com/apache/james-project/blob/master/server/Overview.md Is a duplicate from website content. https://github.com/apache/james-project/blob/master/server/README.txt Also https://github.com/apache/james-project/blob/master/server/NOTICE is a duplicate for LICENSE https://github.com/apache/james-project/blob/master/server/BUILD.txt do not seem useful. It is less detailed than https://github.com/apache/james-project/blob/master/README.adoc However, should we really delay the release for issues not related to the issue? (and thus not bundled with it?) This can be fixed on the master branch, which is the first one seen when reaching github, even if handled after 3.0. See the related JIRA https://issues.apache.org/jira/browse/JAMES-2088 . > > Thx, Eric > > > INFO 12:35:07,284 | > org.apache.james.container.spring.context.JamesServerApplicationContext > | Refreshing > org.apache.james.container.spring.context.JamesServerApplicationContext@60c5aa8d: > startup date [Tue Jul 04 12:35:07 CEST 2017]; root of context hierarchy > WARN 12:35:08,626 | > org.apache.james.container.spring.context.JamesServerApplicationContext > | Exception encountered during context initialization - cancelling > refresh attempt > org.springframework.beans.FatalBeanException: Unable to config the > indexer; nested exception is > org.apache.commons.configuration.ConfigurationException: Unable to > load configuration for component indexer > at > org.apache.james.container.spring.bean.factorypostprocessor.IndexerConfigurationBeanFactoryPostProcessor.postProcessBeanFactory(IndexerConfigurationBeanFactoryPostProcessor.java:70) > at > org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:696) > at > org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:686) > at > org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:461) > at > org.springframework.context.support.ClassPathXmlApplicationContext.(ClassPathXmlApplicationContext.java:139) > at > org.springframework.context.support.ClassPathXmlApplicationContext.(ClassPathXmlApplicationContext.java:93) > at > org.apache.james.container.spring.context.JamesServerApplicationContext.(JamesServerApplicationContext.java:40) > at > org.apache.james.app.spring.JamesAppSpringMain.init(JamesAppSpringMain.java:61) > at > org.apache.james.app.spring.JamesAppSpringMain.main(JamesAppSpringMain.java:42) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.tanukisoftware.wrapper.WrapperSimpleApp.run(WrapperSimpleApp.java:240) > at java.lang.Thread.run(Thread.java:745) > Caused by: org.apache.commons.configuration.ConfigurationException: > Unable to load configuration for component indexer > at > org.apache.james.container.spring.lifecycle.ConfigurationProviderImpl.getConfiguration(ConfigurationProviderImpl.java:135) > at >
[jira] [Created] (JAMES-2088) Some READMEs are outdate
Tellier Benoit created JAMES-2088: - Summary: Some READMEs are outdate Key: JAMES-2088 URL: https://issues.apache.org/jira/browse/JAMES-2088 Project: James Server Issue Type: Improvement Components: Documentation Affects Versions: master Reporter: Tellier Benoit Fix For: master Some readmes are clearly oudated. I would advocate deleting them. https://github.com/apache/james-project/blob/master/server/Overview.md Is a duplicate from website content. https://github.com/apache/james-project/blob/master/server/README.txt Also https://github.com/apache/james-project/blob/master/server/NOTICE is a duplicate for LICENSE https://github.com/apache/james-project/blob/master/server/BUILD.txt do not seem useful. It is less detailed than https://github.com/apache/james-project/blob/master/README.adoc We should take time to review project structure and remove what is not appropriate. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[2/2] james-project git commit: Merge remote-tracking branch 'btellier/JAMES-2087'
Merge remote-tracking branch 'btellier/JAMES-2087' Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/01c3bd1a Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/01c3bd1a Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/01c3bd1a Branch: refs/heads/master Commit: 01c3bd1a380f06535de025142ef4cdc6cf852f32 Parents: 63d7c10 a1158fe Author: Antoine DupratAuthored: Tue Jul 4 13:56:21 2017 +0200 Committer: Antoine Duprat Committed: Tue Jul 4 13:56:21 2017 +0200 -- .../java/org/apache/james/backends/es/ElasticSearchIndexer.java| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[1/2] james-project git commit: JAMES-2087 Do not format expensive log in ElasticSearchIndexer
Repository: james-project Updated Branches: refs/heads/master 63d7c108c -> 01c3bd1a3 JAMES-2087 Do not format expensive log in ElasticSearchIndexer Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/a1158fe9 Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/a1158fe9 Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/a1158fe9 Branch: refs/heads/master Commit: a1158fe996cf1438852185c260a270d353792cec Parents: 02d86a4 Author: benwaAuthored: Tue Jul 4 16:41:38 2017 +0700 Committer: benwa Committed: Tue Jul 4 16:58:54 2017 +0700 -- .../java/org/apache/james/backends/es/ElasticSearchIndexer.java| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/james-project/blob/a1158fe9/backends-common/elasticsearch/src/main/java/org/apache/james/backends/es/ElasticSearchIndexer.java -- diff --git a/backends-common/elasticsearch/src/main/java/org/apache/james/backends/es/ElasticSearchIndexer.java b/backends-common/elasticsearch/src/main/java/org/apache/james/backends/es/ElasticSearchIndexer.java index 658484b..d637be6 100644 --- a/backends-common/elasticsearch/src/main/java/org/apache/james/backends/es/ElasticSearchIndexer.java +++ b/backends-common/elasticsearch/src/main/java/org/apache/james/backends/es/ElasticSearchIndexer.java @@ -99,7 +99,7 @@ public class ElasticSearchIndexer { public IndexResponse indexMessage(String id, String content) { checkArgument(content); -LOGGER.debug(String.format("Indexing %s: %s", id, content)); +LOGGER.debug("Indexing {}: {}", id, content); return client.prepareIndex(indexName.getValue(), typeName.getValue(), id) .setSource(content) .get(); - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Release james-server into 3.0.0
I have successfully built with skipTests With tests enabled, it failed two times (one at es module, the other at the web integration module) to finally succeed after relaunch. This can be considered and flaky tests and is good to me. However, when I launch the binary distribution without any change, I get and exception [1], which is a blocker to me. Can we fix this, I will try again, and then relaunch a vote? Also, there are 3 README is the top folder of the distribution tarball: README README.crypto README.txt README.crypto is fine, but content of the 2 other don't help a new-comer to start (no information on how to start the server, read the logs...) - Ideally we should just have a README.md. Thx, Eric INFO 12:35:07,284 | org.apache.james.container.spring.context.JamesServerApplicationContext | Refreshing org.apache.james.container.spring.context.JamesServerApplicationContext@60c5aa8d: startup date [Tue Jul 04 12:35:07 CEST 2017]; root of context hierarchy WARN 12:35:08,626 | org.apache.james.container.spring.context.JamesServerApplicationContext | Exception encountered during context initialization - cancelling refresh attempt org.springframework.beans.FatalBeanException: Unable to config the indexer; nested exception is org.apache.commons.configuration.ConfigurationException: Unable to load configuration for component indexer at org.apache.james.container.spring.bean.factorypostprocessor.IndexerConfigurationBeanFactoryPostProcessor.postProcessBeanFactory(IndexerConfigurationBeanFactoryPostProcessor.java:70) at org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:696) at org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:686) at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:461) at org.springframework.context.support.ClassPathXmlApplicationContext.(ClassPathXmlApplicationContext.java:139) at org.springframework.context.support.ClassPathXmlApplicationContext.(ClassPathXmlApplicationContext.java:93) at org.apache.james.container.spring.context.JamesServerApplicationContext.(JamesServerApplicationContext.java:40) at org.apache.james.app.spring.JamesAppSpringMain.init(JamesAppSpringMain.java:61) at org.apache.james.app.spring.JamesAppSpringMain.main(JamesAppSpringMain.java:42) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.tanukisoftware.wrapper.WrapperSimpleApp.run(WrapperSimpleApp.java:240) at java.lang.Thread.run(Thread.java:745) Caused by: org.apache.commons.configuration.ConfigurationException: Unable to load configuration for component indexer at org.apache.james.container.spring.lifecycle.ConfigurationProviderImpl.getConfiguration(ConfigurationProviderImpl.java:135) at org.apache.james.container.spring.bean.factorypostprocessor.IndexerConfigurationBeanFactoryPostProcessor.postProcessBeanFactory(IndexerConfigurationBeanFactoryPostProcessor.java:47) ... 14 more On 30/06/17 09:22, aduprat wrote: Hello every one, I'm very very very happy to announce the vote for the upcoming 3.0.0 version of our beloved james server. You can access sources on github https://github.com/apache/james-project/releases Nexus artifact to be released can be found here : https://repository.apache.org/#stagingRepositories It is number #1017 Moreover I uploaded compiled zip, along with md5 and sha1 sums, all signed. http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip.sig http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip.md5 http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip.md5.sig http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip.sha1 http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip.sha1.sig According to Release policy, we need a majority vote : - At least 3 PMC - A majority of voters - This release can't be vetoed Followhttp://www.apache.org/dev/release.html for more details. To vote, you can reply to this email with +1 If you accept the release -1 If you reject the release Votes will close on Monday 7th July 2017, 9am CET. Regards, Antoine Duprat - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (JAMES-2087) Do not format expensive log if not strictly needed
Tellier Benoit created JAMES-2087: - Summary: Do not format expensive log if not strictly needed Key: JAMES-2087 URL: https://issues.apache.org/jira/browse/JAMES-2087 Project: James Server Issue Type: Improvement Components: elasticsearch Affects Versions: master Reporter: Tellier Benoit Fix For: master ElasticSearch formats a debug log with the potentially several kb indexed document. This log can take up to 400KB of the heap, even when logging level is info or higher. We should ensure formatting this log only if it is strictly needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: What type of authentication?
Hi, Which protocol would you like to use? For now James supports on top of IMAP Auth=PLAIN or SASL-IR. Additional authentication mechanism can be implemented. It also supports LOGIN command. Recently on https://gitter.im/apache/james-project @justjanne discussed OAuth2 supports RFC-7628 Of course, we are very interested getting contributions on authentication mechanisms. In that case we can provide the pointers to the right part of the code. Cheers, Benoit Tellier Le 04/07/2017 à 12:09, Baburaj KR a écrit : > Hi Team, > > > > What type of user authentication is James using. > > PLAIN SASL? > > DIGEST-MD5 SASL? > > > > Or any other? > > > > Thanks, > > Babu Raj K.R > > > > - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Closed] (JAMES-2084) JMX metric reporter is no started with Spring
[ https://issues.apache.org/jira/browse/JAMES-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tellier Benoit closed JAMES-2084. - > JMX metric reporter is no started with Spring > - > > Key: JAMES-2084 > URL: https://issues.apache.org/jira/browse/JAMES-2084 > Project: James Server > Issue Type: Bug > Components: JMX, Metrics >Reporter: Tellier Benoit > > As https://github.com/IgorTsapyak reported, JMX metric reporter is no started > with Spring > We miss a @PostConstruct annotation on DropWizardMetricFactory start method > (which is called by Guice injections). Hence the method is never called. > Please ensure the reporter is well started. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Resolved] (JAMES-2084) JMX metric reporter is no started with Spring
[ https://issues.apache.org/jira/browse/JAMES-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tellier Benoit resolved JAMES-2084. --- Resolution: Fixed https://github.com/linagora/james-project/pull/875 solved the issue > JMX metric reporter is no started with Spring > - > > Key: JAMES-2084 > URL: https://issues.apache.org/jira/browse/JAMES-2084 > Project: James Server > Issue Type: Bug > Components: JMX, Metrics >Reporter: Tellier Benoit > > As https://github.com/IgorTsapyak reported, JMX metric reporter is no started > with Spring > We miss a @PostConstruct annotation on DropWizardMetricFactory start method > (which is called by Guice injections). Hence the method is never called. > Please ensure the reporter is well started. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
james-project git commit: JAMES-2084 Start JMX reporter on Spring
Repository: james-project Updated Branches: refs/heads/master 02d86a469 -> 63d7c108c JAMES-2084 Start JMX reporter on Spring Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/63d7c108 Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/63d7c108 Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/63d7c108 Branch: refs/heads/master Commit: 63d7c108c428f7eb061f9fc7eae8df212bde20a4 Parents: 02d86a4 Author: benwaAuthored: Mon Jul 3 19:02:21 2017 +0700 Committer: benwa Committed: Mon Jul 3 19:02:21 2017 +0700 -- .../apache/james/metrics/dropwizard/DropWizardMetricFactory.java | 2 ++ 1 file changed, 2 insertions(+) -- http://git-wip-us.apache.org/repos/asf/james-project/blob/63d7c108/metrics/metrics-dropwizard/src/main/java/org/apache/james/metrics/dropwizard/DropWizardMetricFactory.java -- diff --git a/metrics/metrics-dropwizard/src/main/java/org/apache/james/metrics/dropwizard/DropWizardMetricFactory.java b/metrics/metrics-dropwizard/src/main/java/org/apache/james/metrics/dropwizard/DropWizardMetricFactory.java index ad9015f..55da0dc 100644 --- a/metrics/metrics-dropwizard/src/main/java/org/apache/james/metrics/dropwizard/DropWizardMetricFactory.java +++ b/metrics/metrics-dropwizard/src/main/java/org/apache/james/metrics/dropwizard/DropWizardMetricFactory.java @@ -19,6 +19,7 @@ package org.apache.james.metrics.dropwizard; +import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.inject.Inject; @@ -52,6 +53,7 @@ public class DropWizardMetricFactory implements MetricFactory { return new DropWizardTimeMetric(name, metricRegistry.timer(name).time()); } +@PostConstruct public void start() throws ConfigurationException { jmxReporter.start(); } - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org