date:20151104

[jira] [Commented] (JAMES-1635) Can not run unit tests

2015-11-04 Thread Tellier Benoit (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989388#comment-14989388
 ] 

Tellier Benoit commented on JAMES-1635:
---

https://github.com/jsevellec/cassandra-unit/issues/128

> Can not run unit tests
> --
>
> Key: JAMES-1635
> URL: https://issues.apache.org/jira/browse/JAMES-1635
> Project: James Server
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Tellier Benoit
> Fix For: Trunk
>
>
> I got this exception, either in cassandra mailbox and Cassandra backend ; 
> For example :
> initializeTypesShouldCreateTheTypes(org.apache.james.backends.cassandra.init.CassandraTypeProviderTest)
>   Time elapsed: 14.353 sec  <<< FAILURE!
> java.lang.AssertionError: Cassandra daemon did not start within timeout
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:130)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:85)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:64)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:56)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:52)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.(CassandraCluster.java:57)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.create(CassandraCluster.java:51)
>   at 
> org.apache.james.backends.cassandra.init.CassandraTypeProviderTest.setUp(CassandraTypeProviderTest.java:66)
> I increased the max retry count of the Cassandra cluster but it does not 
> solve my problem.
> It really slow down my worlflow...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...

2015-11-04 Thread chibenwa

GitHub user chibenwa opened a pull request:

https://github.com/apache/james-project/pull/17

JAMES-1635 Increase embedded Cassandra startup timeout

Increase embedded Cassandra startup timeout to the value configured in 
CassandraCluster used for unit tests.

This will avoid tests to fail on less effective computers.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chibenwa/james-project JAMES-1635

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/james-project/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit 6dee03a010ccc37441089dc62394577a18f7ad3c
Author: benwa 
Date:   2015-11-04T11:39:15Z

JAMES-1635 Increase embedded Cassandra startup timeout




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1635) Can not run unit tests

2015-11-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989541#comment-14989541
 ] 

ASF GitHub Bot commented on JAMES-1635:
---

GitHub user chibenwa opened a pull request:

https://github.com/apache/james-project/pull/17

JAMES-1635 Increase embedded Cassandra startup timeout

Increase embedded Cassandra startup timeout to the value configured in 
CassandraCluster used for unit tests.

This will avoid tests to fail on less effective computers.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chibenwa/james-project JAMES-1635

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/james-project/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit 6dee03a010ccc37441089dc62394577a18f7ad3c
Author: benwa 
Date:   2015-11-04T11:39:15Z

JAMES-1635 Increase embedded Cassandra startup timeout




> Can not run unit tests
> --
>
> Key: JAMES-1635
> URL: https://issues.apache.org/jira/browse/JAMES-1635
> Project: James Server
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Tellier Benoit
> Fix For: Trunk
>
>
> I got this exception, either in cassandra mailbox and Cassandra backend ; 
> For example :
> initializeTypesShouldCreateTheTypes(org.apache.james.backends.cassandra.init.CassandraTypeProviderTest)
>   Time elapsed: 14.353 sec  <<< FAILURE!
> java.lang.AssertionError: Cassandra daemon did not start within timeout
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:130)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:85)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:64)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:56)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:52)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.(CassandraCluster.java:57)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.create(CassandraCluster.java:51)
>   at 
> org.apache.james.backends.cassandra.init.CassandraTypeProviderTest.setUp(CassandraTypeProviderTest.java:66)
> I increased the max retry count of the Cassandra cluster but it does not 
> solve my problem.
> It really slow down my worlflow...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Created] (JAMES-1637) I want to resume compilation using docker

2015-11-04 Thread Tellier Benoit (JIRA)

Tellier Benoit created JAMES-1637:
-

 Summary: I want to resume compilation using docker
 Key: JAMES-1637
 URL: https://issues.apache.org/jira/browse/JAMES-1637
 Project: James Server
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Tellier Benoit
 Fix For: Trunk


If compilation fails, lets say after Cassandra Mailbox tests, I need to re-run 
all unit tests, which are long.

Maybe we should add a compile.sh script option so that we can specify a -rf 
option.

I will be particulary fan of this feature as this will speed up my developpment 
cycles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Created] (JAMES-1636) test failure on org.apache.james.user.cassandra.CassandraUsersRepositoryTest

2015-11-04 Thread Matthieu Baechler (JIRA)

Matthieu Baechler created JAMES-1636:


 Summary: test failure on 
org.apache.james.user.cassandra.CassandraUsersRepositoryTest
 Key: JAMES-1636
 URL: https://issues.apache.org/jira/browse/JAMES-1636
 Project: James Server
  Issue Type: Bug
  Components: UsersStore & UsersRepository
Reporter: Matthieu Baechler


There's an issue on trunk with CassandraUsersRepositoryTest tests.
{code}

testUserAddRemoveCycle(org.apache.james.user.cassandra.CassandraUsersRepositoryTest)
  Time elapsed: 3.597 sec  <<< ERROR!
org.apache.james.user.api.UsersRepositoryException: Given Username needs to 
contain a @domainpart
{code}

The testsuite doesn't check if virtualdomain is true or false.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1636) test failure on org.apache.james.user.cassandra.CassandraUsersRepositoryTest

2015-11-04 Thread Matthieu Baechler (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989516#comment-14989516
 ] 

Matthieu Baechler commented on JAMES-1636:
--

I'll fix that

> test failure on org.apache.james.user.cassandra.CassandraUsersRepositoryTest
> 
>
> Key: JAMES-1636
> URL: https://issues.apache.org/jira/browse/JAMES-1636
> Project: James Server
>  Issue Type: Bug
>  Components: UsersStore & UsersRepository
>Reporter: Matthieu Baechler
>
> There's an issue on trunk with CassandraUsersRepositoryTest tests.
> {code}
> testUserAddRemoveCycle(org.apache.james.user.cassandra.CassandraUsersRepositoryTest)
>   Time elapsed: 3.597 sec  <<< ERROR!
> org.apache.james.user.api.UsersRepositoryException: Given Username needs to 
> contain a @domainpart
> {code}
> The testsuite doesn't check if virtualdomain is true or false.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...

2015-11-04 Thread aduprat

Github user aduprat commented on a diff in the pull request:

https://github.com/apache/james-project/pull/17#discussion_r43881372
  
--- Diff: 
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
 ---
@@ -42,10 +42,12 @@
 
 private static final long SLEEP_BEFORE_RETRY = 200;
 private static final int MAX_RETRY = 200;
+private static final long EMBEDDED_CASSANDRA_TIMEOUT = MAX_RETRY * 
SLEEP_BEFORE_RETRY;
--- End diff --

I would prefer an independent value, as the MAX_RETRY & SLEEP_BEFORE_RETRY 
don't make sense for this, IMHO.
You may also add the unit in the constant name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1635) Can not run unit tests

2015-11-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989546#comment-14989546
 ] 

ASF GitHub Bot commented on JAMES-1635:
---

Github user aduprat commented on a diff in the pull request:

https://github.com/apache/james-project/pull/17#discussion_r43881372
  
--- Diff: 
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
 ---
@@ -42,10 +42,12 @@
 
 private static final long SLEEP_BEFORE_RETRY = 200;
 private static final int MAX_RETRY = 200;
+private static final long EMBEDDED_CASSANDRA_TIMEOUT = MAX_RETRY * 
SLEEP_BEFORE_RETRY;
--- End diff --

I would prefer an independent value, as the MAX_RETRY & SLEEP_BEFORE_RETRY 
don't make sense for this, IMHO.
You may also add the unit in the constant name.


> Can not run unit tests
> --
>
> Key: JAMES-1635
> URL: https://issues.apache.org/jira/browse/JAMES-1635
> Project: James Server
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Tellier Benoit
> Fix For: Trunk
>
>
> I got this exception, either in cassandra mailbox and Cassandra backend ; 
> For example :
> initializeTypesShouldCreateTheTypes(org.apache.james.backends.cassandra.init.CassandraTypeProviderTest)
>   Time elapsed: 14.353 sec  <<< FAILURE!
> java.lang.AssertionError: Cassandra daemon did not start within timeout
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:130)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:85)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:64)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:56)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:52)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.(CassandraCluster.java:57)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.create(CassandraCluster.java:51)
>   at 
> org.apache.james.backends.cassandra.init.CassandraTypeProviderTest.setUp(CassandraTypeProviderTest.java:66)
> I increased the max retry count of the Cassandra cluster but it does not 
> solve my problem.
> It really slow down my worlflow...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1635) Can not run unit tests

2015-11-04 Thread Tellier Benoit (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989580#comment-14989580
 ] 

Tellier Benoit commented on JAMES-1635:
---

It make sense because cassandra startup is asynchronous by the way ;-)

> Can not run unit tests
> --
>
> Key: JAMES-1635
> URL: https://issues.apache.org/jira/browse/JAMES-1635
> Project: James Server
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Tellier Benoit
> Fix For: Trunk
>
>
> I got this exception, either in cassandra mailbox and Cassandra backend ; 
> For example :
> initializeTypesShouldCreateTheTypes(org.apache.james.backends.cassandra.init.CassandraTypeProviderTest)
>   Time elapsed: 14.353 sec  <<< FAILURE!
> java.lang.AssertionError: Cassandra daemon did not start within timeout
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:130)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:85)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:64)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:56)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:52)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.(CassandraCluster.java:57)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.create(CassandraCluster.java:51)
>   at 
> org.apache.james.backends.cassandra.init.CassandraTypeProviderTest.setUp(CassandraTypeProviderTest.java:66)
> I increased the max retry count of the Cassandra cluster but it does not 
> solve my problem.
> It really slow down my worlflow...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Created] (JAMES-1635) Can not run unit tests

2015-11-04 Thread Tellier Benoit (JIRA)

Tellier Benoit created JAMES-1635:
-

 Summary: Can not run unit tests
 Key: JAMES-1635
 URL: https://issues.apache.org/jira/browse/JAMES-1635
 Project: James Server
  Issue Type: Bug
Affects Versions: Trunk
Reporter: Tellier Benoit
 Fix For: Trunk


I got this exception, either in cassandra mailbox and Cassandra backend ; 

For example :

initializeTypesShouldCreateTheTypes(org.apache.james.backends.cassandra.init.CassandraTypeProviderTest)
  Time elapsed: 14.353 sec  <<< FAILURE!
java.lang.AssertionError: Cassandra daemon did not start within timeout
at 
org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:130)
at 
org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:85)
at 
org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:64)
at 
org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:56)
at 
org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:52)
at 
org.apache.james.backends.cassandra.CassandraCluster.(CassandraCluster.java:57)
at 
org.apache.james.backends.cassandra.CassandraCluster.create(CassandraCluster.java:51)
at 
org.apache.james.backends.cassandra.init.CassandraTypeProviderTest.setUp(CassandraTypeProviderTest.java:66)


I increased the max retry count of the Cassandra cluster but it does not solve 
my problem.

It really slow down my worlflow...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[GitHub] james-project pull request: Mailbox 211 : distributed event system...

2015-11-04 Thread chibenwa

Github user chibenwa commented on the pull request:

https://github.com/apache/james-project/pull/12#issuecomment-153723146
  
I updated the PR after Matthieu comments.

It still needs to be unit test validated ( will take ~ an hour ).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1635) Can not run unit tests

2015-11-04 Thread Tellier Benoit (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989579#comment-14989579
 ] 

Tellier Benoit commented on JAMES-1635:
---

Github is really slow (/unavailable) si I'll answer you here...

Ok for the unit.

I do not agree with you for the timeout independent value. I do not want 
Cassandra unit to throw before the expected timeout value expressed by the 
retry loop. I'm OK with it throwing after that. For me it make perfect sense.

In fact SLEEP_BEFORE_RETRY should also indicate its value ;-)

> Can not run unit tests
> --
>
> Key: JAMES-1635
> URL: https://issues.apache.org/jira/browse/JAMES-1635
> Project: James Server
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Tellier Benoit
> Fix For: Trunk
>
>
> I got this exception, either in cassandra mailbox and Cassandra backend ; 
> For example :
> initializeTypesShouldCreateTheTypes(org.apache.james.backends.cassandra.init.CassandraTypeProviderTest)
>   Time elapsed: 14.353 sec  <<< FAILURE!
> java.lang.AssertionError: Cassandra daemon did not start within timeout
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:130)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:85)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:64)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:56)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:52)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.(CassandraCluster.java:57)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.create(CassandraCluster.java:51)
>   at 
> org.apache.james.backends.cassandra.init.CassandraTypeProviderTest.setUp(CassandraTypeProviderTest.java:66)
> I increased the max retry count of the Cassandra cluster but it does not 
> solve my problem.
> It really slow down my worlflow...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1635) Can not run unit tests

2015-11-04 Thread Tellier Benoit (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989384#comment-14989384
 ] 

Tellier Benoit commented on JAMES-1635:
---

Ah yes, I used the provided java-8 compilation docker :

docker run -v $PWD/.m2:/root/.m2 -v $PWD:/origin -v 
$PWD/dockerfiles/run/spring/destination:/destination -t james/project 
MAILBOX-211

> Can not run unit tests
> --
>
> Key: JAMES-1635
> URL: https://issues.apache.org/jira/browse/JAMES-1635
> Project: James Server
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Tellier Benoit
> Fix For: Trunk
>
>
> I got this exception, either in cassandra mailbox and Cassandra backend ; 
> For example :
> initializeTypesShouldCreateTheTypes(org.apache.james.backends.cassandra.init.CassandraTypeProviderTest)
>   Time elapsed: 14.353 sec  <<< FAILURE!
> java.lang.AssertionError: Cassandra daemon did not start within timeout
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:130)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:85)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:64)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:56)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:52)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.(CassandraCluster.java:57)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.create(CassandraCluster.java:51)
>   at 
> org.apache.james.backends.cassandra.init.CassandraTypeProviderTest.setUp(CassandraTypeProviderTest.java:66)
> I increased the max retry count of the Cassandra cluster but it does not 
> solve my problem.
> It really slow down my worlflow...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1635) Can not run unit tests

2015-11-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989765#comment-14989765
 ] 

ASF GitHub Bot commented on JAMES-1635:
---

Github user chibenwa commented on a diff in the pull request:

https://github.com/apache/james-project/pull/17#discussion_r43896960
  
--- Diff: 
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
 ---
@@ -42,10 +42,12 @@
 
 private static final long SLEEP_BEFORE_RETRY = 200;
 private static final int MAX_RETRY = 200;
+private static final long EMBEDDED_CASSANDRA_TIMEOUT = MAX_RETRY * 
SLEEP_BEFORE_RETRY;
--- End diff --

Ok for the unit.

I do not agree with you for the timeout independent value. I do not want 
Cassandra unit to throw before the expected timeout value expressed by the 
retry loop. I'm OK with it throwing after that. For me it make perfect sense.

In fact SLEEP_BEFORE_RETRY should also indicate its value 


> Can not run unit tests
> --
>
> Key: JAMES-1635
> URL: https://issues.apache.org/jira/browse/JAMES-1635
> Project: James Server
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Tellier Benoit
> Fix For: Trunk
>
>
> I got this exception, either in cassandra mailbox and Cassandra backend ; 
> For example :
> initializeTypesShouldCreateTheTypes(org.apache.james.backends.cassandra.init.CassandraTypeProviderTest)
>   Time elapsed: 14.353 sec  <<< FAILURE!
> java.lang.AssertionError: Cassandra daemon did not start within timeout
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:130)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:85)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:64)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:56)
>   at 
> org.cassandraunit.utils.EmbeddedCassandraServerHelper.startEmbeddedCassandra(EmbeddedCassandraServerHelper.java:52)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.(CassandraCluster.java:57)
>   at 
> org.apache.james.backends.cassandra.CassandraCluster.create(CassandraCluster.java:51)
>   at 
> org.apache.james.backends.cassandra.init.CassandraTypeProviderTest.setUp(CassandraTypeProviderTest.java:66)
> I increased the max retry count of the Cassandra cluster but it does not 
> solve my problem.
> It really slow down my worlflow...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...

2015-11-04 Thread chibenwa

Github user chibenwa commented on a diff in the pull request:

https://github.com/apache/james-project/pull/17#discussion_r43896960
  
--- Diff: 
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
 ---
@@ -42,10 +42,12 @@
 
 private static final long SLEEP_BEFORE_RETRY = 200;
 private static final int MAX_RETRY = 200;
+private static final long EMBEDDED_CASSANDRA_TIMEOUT = MAX_RETRY * 
SLEEP_BEFORE_RETRY;
--- End diff --

Ok for the unit.

I do not agree with you for the timeout independent value. I do not want 
Cassandra unit to throw before the expected timeout value expressed by the 
retry loop. I'm OK with it throwing after that. For me it make perfect sense.

In fact SLEEP_BEFORE_RETRY should also indicate its value 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

svn commit: r1712585 - in /james/project/trunk/server/data: data-api/src/test/ data-cassandra/src/test/java/org/apache/james/user/cassandra/ data-file/src/test/java/org/apache/james/user/file/ data-hb

2015-11-04 Thread matthieu

Author: matthieu
Date: Wed Nov  4 16:37:29 2015
New Revision: 1712585

URL: http://svn.apache.org/viewvc?rev=1712585=rev
Log:
JAMES-1636 take supportVirtualHosting into account in UserRepository testsuite

Added:

james/project/trunk/server/data/data-library/src/test/java/org/apache/james/domainlist/api/

james/project/trunk/server/data/data-library/src/test/java/org/apache/james/domainlist/api/mock/

james/project/trunk/server/data/data-library/src/test/java/org/apache/james/domainlist/api/mock/SimpleDomainList.java
Removed:
james/project/trunk/server/data/data-api/src/test/
Modified:

james/project/trunk/server/data/data-cassandra/src/test/java/org/apache/james/user/cassandra/CassandraUsersRepositoryTest.java

james/project/trunk/server/data/data-file/src/test/java/org/apache/james/user/file/UsersFileRepositoryTest.java

james/project/trunk/server/data/data-hbase/src/test/java/org/apache/james/user/hbase/HBaseUsersRepositoryTest.java

james/project/trunk/server/data/data-jcr/src/test/java/org/apache/james/user/jcr/JcrUserRepositoryTest.java

james/project/trunk/server/data/data-jdbc/src/test/java/org/apache/james/user/jdbc/DefaultUsersJdbcRepositoryTest.java

james/project/trunk/server/data/data-jdbc/src/test/java/org/apache/james/user/jdbc/JamesUsersJdbcRepositoryTest.java

james/project/trunk/server/data/data-jpa/src/test/java/org/apache/james/user/jpa/JpaUsersRepositoryTest.java

james/project/trunk/server/data/data-library/src/test/java/org/apache/james/user/lib/AbstractUsersRepositoryTest.java

Modified: 
james/project/trunk/server/data/data-cassandra/src/test/java/org/apache/james/user/cassandra/CassandraUsersRepositoryTest.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/server/data/data-cassandra/src/test/java/org/apache/james/user/cassandra/CassandraUsersRepositoryTest.java?rev=1712585=1712584=1712585=diff
==
--- 
james/project/trunk/server/data/data-cassandra/src/test/java/org/apache/james/user/cassandra/CassandraUsersRepositoryTest.java
 (original)
+++ 
james/project/trunk/server/data/data-cassandra/src/test/java/org/apache/james/user/cassandra/CassandraUsersRepositoryTest.java
 Wed Nov  4 16:37:29 2015
@@ -20,7 +20,7 @@
 package org.apache.james.user.cassandra;
 
 import org.apache.james.backends.cassandra.CassandraCluster;
-import org.apache.james.user.api.UsersRepository;
+import org.apache.james.user.lib.AbstractUsersRepository;
 import org.apache.james.user.lib.AbstractUsersRepositoryTest;
 import org.junit.After;
 
@@ -34,7 +34,7 @@ public class CassandraUsersRepositoryTes
 }
 
 @Override
-protected UsersRepository getUsersRepository() throws Exception {
+protected AbstractUsersRepository getUsersRepository() throws Exception {
 cassandra = CassandraCluster.create(new 
CassandraUsersRepositoryModule());
 CassandraUsersRepository cassandraUsersRepository = new 
CassandraUsersRepository();
 cassandraUsersRepository.setSession(cassandra.getConf());

Modified: 
james/project/trunk/server/data/data-file/src/test/java/org/apache/james/user/file/UsersFileRepositoryTest.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/server/data/data-file/src/test/java/org/apache/james/user/file/UsersFileRepositoryTest.java?rev=1712585=1712584=1712585=diff
==
--- 
james/project/trunk/server/data/data-file/src/test/java/org/apache/james/user/file/UsersFileRepositoryTest.java
 (original)
+++ 
james/project/trunk/server/data/data-file/src/test/java/org/apache/james/user/file/UsersFileRepositoryTest.java
 Wed Nov  4 16:37:29 2015
@@ -30,8 +30,8 @@ import org.apache.commons.configuration.
 import org.apache.commons.io.FileUtils;
 import org.apache.james.filesystem.api.FileSystem;
 import org.apache.james.lifecycle.api.LifecycleUtil;
-import org.apache.james.user.api.UsersRepository;
 import org.apache.james.user.api.UsersRepositoryException;
+import org.apache.james.user.lib.AbstractUsersRepository;
 import org.apache.james.user.lib.AbstractUsersRepositoryTest;
 import org.junit.After;
 import org.junit.Before;
@@ -68,7 +68,7 @@ public class UsersFileRepositoryTest ext
  * @throws Exception
  */
 @Override
-protected UsersRepository getUsersRepository() throws Exception {
+protected AbstractUsersRepository getUsersRepository() throws Exception {
 FileSystem fs = new FileSystem() {
 
 @Override

Modified: 
james/project/trunk/server/data/data-hbase/src/test/java/org/apache/james/user/hbase/HBaseUsersRepositoryTest.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/server/data/data-hbase/src/test/java/org/apache/james/user/hbase/HBaseUsersRepositoryTest.java?rev=1712585=1712584=1712585=diff
==
---

[jira] [Closed] (JAMES-1636) test failure on org.apache.james.user.cassandra.CassandraUsersRepositoryTest

2015-11-04 Thread Matthieu Baechler (JIRA)


 [ 
https://issues.apache.org/jira/browse/JAMES-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthieu Baechler closed JAMES-1636.

Resolution: Fixed

merged

> test failure on org.apache.james.user.cassandra.CassandraUsersRepositoryTest
> 
>
> Key: JAMES-1636
> URL: https://issues.apache.org/jira/browse/JAMES-1636
> Project: James Server
>  Issue Type: Bug
>  Components: UsersStore & UsersRepository
>Reporter: Matthieu Baechler
>
> There's an issue on trunk with CassandraUsersRepositoryTest tests.
> {code}
> testUserAddRemoveCycle(org.apache.james.user.cassandra.CassandraUsersRepositoryTest)
>   Time elapsed: 3.597 sec  <<< ERROR!
> org.apache.james.user.api.UsersRepositoryException: Given Username needs to 
> contain a @domainpart
> {code}
> The testsuite doesn't check if virtualdomain is true or false.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1634) Slow Cassandra tests

2015-11-04 Thread Matthieu Baechler (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989133#comment-14989133
 ] 

Matthieu Baechler commented on JAMES-1634:
--

Hi Benoit,
That would be great ... but it actually doesn't give us the expected speedup 
(almost same execution times)
I just tried to have some figures about "how much" before talking about "how 
to". It's definitively not worth it.
[~aduprat] you should make this ticket more specific and close it.

> Slow Cassandra tests
> 
>
> Key: JAMES-1634
> URL: https://issues.apache.org/jira/browse/JAMES-1634
> Project: James Server
>  Issue Type: Bug
>Reporter: Antoine Duprat
>
> Cassandra tests are slow, tables creation takes approximatively 25 seconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

svn commit: r1712518 - /james/project/trunk/pom.xml

2015-11-04 Thread aduprat

Author: aduprat
Date: Wed Nov  4 09:27:09 2015
New Revision: 1712518

URL: http://svn.apache.org/viewvc?rev=1712518=rev
Log:
Upgrade maven-site-plugin version. Contributed by Duprat 

Modified:
james/project/trunk/pom.xml

Modified: james/project/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/james/project/trunk/pom.xml?rev=1712518=1712517=1712518=diff
==
--- james/project/trunk/pom.xml (original)
+++ james/project/trunk/pom.xml Wed Nov  4 09:27:09 2015
@@ -765,7 +765,7 @@
 
 org.apache.maven.plugins
 maven-site-plugin
-3.2
+3.3
 
 
 attach-descriptor



-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

svn commit: r1712519 - in /james/project/trunk/src/site/xdoc: index.xml newsarchive.xml

2015-11-04 Thread aduprat

Author: aduprat
Date: Wed Nov  4 09:27:15 2015
New Revision: 1712519

URL: http://svn.apache.org/viewvc?rev=1712519=rev
Log:
News about Guice Cassandra project. Contributed by Duprat 

Modified:
james/project/trunk/src/site/xdoc/index.xml
james/project/trunk/src/site/xdoc/newsarchive.xml

Modified: james/project/trunk/src/site/xdoc/index.xml
URL: 
http://svn.apache.org/viewvc/james/project/trunk/src/site/xdoc/index.xml?rev=1712519=1712518=1712519=diff
==
--- james/project/trunk/src/site/xdoc/index.xml (original)
+++ james/project/trunk/src/site/xdoc/index.xml Wed Nov  4 09:27:15 2015
@@ -389,6 +389,10 @@
 
   
 
+  Oct/2015 - 
+  Guice injection for 
Cassandra backend Guice injection is now available in a new Java 
project.
+  
+  
   Sep/2015 - 
   Apache James Server 
2.3.2.1 fixes a security issue - Please upgrade!!!
   

Modified: james/project/trunk/src/site/xdoc/newsarchive.xml
URL: 
http://svn.apache.org/viewvc/james/project/trunk/src/site/xdoc/newsarchive.xml?rev=1712519=1712518=1712519=diff
==
--- james/project/trunk/src/site/xdoc/newsarchive.xml (original)
+++ james/project/trunk/src/site/xdoc/newsarchive.xml Wed Nov  4 09:27:15 2015
@@ -36,6 +36,9 @@
 

 
+ Oct 2015 - Guice injection for Cassandra 
backend
+ Guice injection is now available in a new https://github.com/apache/james-project/tree/trunk/server/container/cassandra-guice/;>Java
 project. Feel free to try it!
+
  Sep 2015 - Apache James Server 2.3.2.1 
released
  This release fixes a security vulnerability - Users are invited to 
upgrade (read https://blogs.apache.org/james/entry/apache_james_server_2_3;>annouce on 
the Apache James blog).
 



-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

svn commit: r1712506 - /james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java

2015-11-04 Thread aduprat

Author: aduprat
Date: Wed Nov  4 08:43:40 2015
New Revision: 1712506

URL: http://svn.apache.org/viewvc?rev=1712506=rev
Log:
JAMES-1634 Faster Cassandra tests. Contributed by Duprat 

Modified:

james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java

Modified: 
james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java?rev=1712506=1712505=1712506=diff
==
--- 
james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
 (original)
+++ 
james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
 Wed Nov  4 08:43:40 2015
@@ -88,7 +88,7 @@ public final class CassandraCluster {
 }
 
 public Cluster getCluster() {
-return 
ClusterFactory.createClusterForSingleServerWithoutPassWord(CLUSTER_IP, 
CLUSTER_PORT_TEST);
+return ClusterFactory.createTestingCluster(CLUSTER_IP, 
CLUSTER_PORT_TEST);
 }
 
 private void sleep(long sleepMs) {
@@ -102,4 +102,4 @@ public final class CassandraCluster {
 public CassandraTypesProvider getTypesProvider() {
 return typesProvider;
 }
-}
\ No newline at end of file
+}



-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Updated] (JAMES-1634) Slow Cassandra tests when creating tables

2015-11-04 Thread Antoine Duprat (JIRA)


 [ 
https://issues.apache.org/jira/browse/JAMES-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antoine Duprat updated JAMES-1634:
--
Description: 
Cassandra tests are slow, tables creation takes approximatively 25 seconds.

The aim of this ticket is only to reduce the tables creation time.

  was:Cassandra tests are slow, tables creation takes approximatively 25 
seconds.


> Slow Cassandra tests when creating tables
> -
>
> Key: JAMES-1634
> URL: https://issues.apache.org/jira/browse/JAMES-1634
> Project: James Server
>  Issue Type: Bug
>Reporter: Antoine Duprat
>
> Cassandra tests are slow, tables creation takes approximatively 25 seconds.
> The aim of this ticket is only to reduce the tables creation time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Updated] (JAMES-1634) Slow Cassandra tests when creating tables

2015-11-04 Thread Antoine Duprat (JIRA)


 [ 
https://issues.apache.org/jira/browse/JAMES-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antoine Duprat updated JAMES-1634:
--
Summary: Slow Cassandra tests when creating tables  (was: Slow Cassandra 
tests)

> Slow Cassandra tests when creating tables
> -
>
> Key: JAMES-1634
> URL: https://issues.apache.org/jira/browse/JAMES-1634
> Project: James Server
>  Issue Type: Bug
>Reporter: Antoine Duprat
>
> Cassandra tests are slow, tables creation takes approximatively 25 seconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Closed] (JAMES-1634) Slow Cassandra tests when creating tables

2015-11-04 Thread Antoine Duprat (JIRA)


 [ 
https://issues.apache.org/jira/browse/JAMES-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antoine Duprat closed JAMES-1634.
-
Resolution: Fixed

merged

> Slow Cassandra tests when creating tables
> -
>
> Key: JAMES-1634
> URL: https://issues.apache.org/jira/browse/JAMES-1634
> Project: James Server
>  Issue Type: Bug
>Reporter: Antoine Duprat
>
> Cassandra tests are slow, tables creation takes approximatively 25 seconds.
> The aim of this ticket is only to reduce the tables creation time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

svn commit: r1712513 - in /james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver: AuthRequiredToRelayRcptHook.java SenderAuthIdentifyVerificationRcptHook.java

2015-11-04 Thread aduprat

Author: aduprat
Date: Wed Nov  4 08:58:55 2015
New Revision: 1712513

URL: http://svn.apache.org/viewvc?rev=1712513=rev
Log:
JAMES-1626 All ProtocolHandler should be lifeCycle aware

   If fixes a longstanding error in SMTPServerTest that
   return code 554 on DNS blacklist test

git-svn-id: https://svn.apache.org/repos/asf/james/project/trunk@1712325 
13f79535-47bb-0310-9956-ffa450edef68. Contributed by Baechler 


Modified:

james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java

james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java

Modified: 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java?rev=1712513=1712512=1712513=diff
==
--- 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java
 (original)
+++ 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java
 Wed Nov  4 08:58:55 2015
@@ -45,6 +45,16 @@ public class AuthRequiredToRelayRcptHook
 
 }
 
+@Override
+public void init(Configuration config) throws ConfigurationException {
+
+}
+
+@Override
+public void destroy() {
+
+}
+
 /**
  * @see 
org.apache.james.protocols.smtp.core.AbstractAuthRequiredToRelayRcptHook#isLocalDomain(java.lang.String)
  */

Modified: 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java?rev=1712513=1712512=1712513=diff
==
--- 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java
 (original)
+++ 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java
 Wed Nov  4 08:58:55 2015
@@ -61,6 +61,16 @@ public class SenderAuthIdentifyVerificat
 }
 
 @Override
+public void init(Configuration config) throws ConfigurationException {
+
+}
+
+@Override
+public void destroy() {
+
+}
+
+@Override
 public HookResult doRcpt(SMTPSession session, MailAddress sender, 
MailAddress rcpt) {
 ExtendedSMTPSession nSession = (ExtendedSMTPSession) session;
 if (nSession.verifyIdentity()) {



-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

James & Guice

2015-11-04 Thread Antoine DUPRAT


Hi all,

Integrating Guice injection inside James is an old requested feature.
https://issues.apache.org/jira/browse/JAMES-1479

We are glad to provide you a new java project inside James (james-project).
As you may know, here is a list of the main advantages of Guice between 
Spring:

- you only bring what you need in Guice (no extra jars)
- starting the application is faster with Guice
- you are able to launch James in your favorite IDE (faster debugging 
session)


To achieve that, we have to chose the backends that will be deployed 
when binding the interfaces.
Our choices go to Cassandra for the mailbox backend and ElasticSeach for 
the search backend.


This job is done in Guice modules, each responsible for a simple 
category, for example:

- CassandraMailboxModule
- IMAPServerModule
- SMTPServerModule
- ...

By this way, new backend modules can easily be developped, and you may 
reuse some common modules.


If you wish to try it, you just have to use the following commands 
inside james-project:

/$ //JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 mvn clean install//
//$ /usr/lib/jvm/java-8-openjdk-amd64/bin/java -jar 
-Dworking.directory=WORKING_DIRECTORY/ 
server/container/cassandra-guice/target/mes-server-cassandra-guice-3.0.0-beta5-SNAPSHOT.jar//

/
Where WORKING_DIRECTORY folder contains the classical folders:
- conf/
- users/
- var/

For the ease of the test, i attach to this email the Cassandra and 
ElasticSearch configuration files, then you will have to change the IPs in:

- conf/cassandra.properties
- conf/elasticsearch.properties

You may want to run Cassandra & ElasticSearch in docker, here are the 
commands to start them and retrieve their IPs:

/$ docker run -d --name=cassandra cassandra//
//$ docker inspect cassandra | grep IPAddress//
//$ docker run -d --name=elasticsearch elasticsearch:1.5.2//
//$ docker inspect elasticsearch | grep IPAddress//
/

Greetings,
--
Antoine
# Configuration file for cassandra mailbox

cassandra.ip=172.17.0.1
cassandra.port=9042
cassandra.keyspace=apache_james
cassandra.replication.factor=1
# Configuration file for ElasticSearch

elasticsearch.masterHost=172.17.0.2
elasticsearch.port=9300
elasticsearch.nb.shards=1
elasticsearch.nb.replica=1

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

svn commit: r1712516 - in /james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver: AuthRequiredToRelayRcptHook.java SenderAuthIdentifyVerificationRcptHook.java

2015-11-04 Thread aduprat

Author: aduprat
Date: Wed Nov  4 09:24:06 2015
New Revision: 1712516

URL: http://svn.apache.org/viewvc?rev=1712516=rev
Log:
Revert r1712513: JAMES-1626 All ProtocolHandler should be lifeCycle aware 
(already applied)

Modified:

james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java

james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java

Modified: 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java?rev=1712516=1712515=1712516=diff
==
--- 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java
 (original)
+++ 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java
 Wed Nov  4 09:24:06 2015
@@ -45,16 +45,6 @@ public class AuthRequiredToRelayRcptHook
 
 }
 
-@Override
-public void init(Configuration config) throws ConfigurationException {
-
-}
-
-@Override
-public void destroy() {
-
-}
-
 /**
  * @see 
org.apache.james.protocols.smtp.core.AbstractAuthRequiredToRelayRcptHook#isLocalDomain(java.lang.String)
  */

Modified: 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java?rev=1712516=1712515=1712516=diff
==
--- 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java
 (original)
+++ 
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java
 Wed Nov  4 09:24:06 2015
@@ -61,16 +61,6 @@ public class SenderAuthIdentifyVerificat
 }
 
 @Override
-public void init(Configuration config) throws ConfigurationException {
-
-}
-
-@Override
-public void destroy() {
-
-}
-
-@Override
 public HookResult doRcpt(SMTPSession session, MailAddress sender, 
MailAddress rcpt) {
 ExtendedSMTPSession nSession = (ExtendedSMTPSession) session;
 if (nSession.verifyIdentity()) {



-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1477) Replace @Resource with @Inject where it can

2015-11-04 Thread Matthieu Baechler (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989092#comment-14989092
 ] 

Matthieu Baechler commented on JAMES-1477:
--

Ok, it's now commited, I think you can close this ticket.

> Replace @Resource with @Inject where it can
> ---
>
> Key: JAMES-1477
> URL: https://issues.apache.org/jira/browse/JAMES-1477
> Project: James Server
>  Issue Type: Sub-task
>Reporter: Eric Charles
>Assignee: Eric Charles
>
> This will allow also allow to work with different dependency injection 
> frameworks (spring, guice...).
> See also JAMES-1237.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

svn commit: r1712498 - in /james/project/trunk: mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryCurrentQuotaManager.java pom.xml

2015-11-04 Thread aduprat

Author: aduprat
Date: Wed Nov  4 08:28:55 2015
New Revision: 1712498

URL: http://svn.apache.org/viewvc?rev=1712498=rev
Log:
JAMES-1633 Fails when tests are locked. Contributed by Duprat 


Modified:

james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryCurrentQuotaManager.java
james/project/trunk/pom.xml

Modified: 
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryCurrentQuotaManager.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryCurrentQuotaManager.java?rev=1712498=1712497=1712498=diff
==
--- 
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryCurrentQuotaManager.java
 (original)
+++ 
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryCurrentQuotaManager.java
 Wed Nov  4 08:28:55 2015
@@ -19,10 +19,12 @@
 
 package org.apache.james.mailbox.inmemory.quota;
 
-import com.google.common.base.Preconditions;
-import com.google.common.cache.CacheBuilder;
-import com.google.common.cache.CacheLoader;
-import com.google.common.cache.LoadingCache;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.atomic.AtomicLong;
+
+import javax.inject.Inject;
+import javax.inject.Singleton;
+
 import org.apache.james.mailbox.MailboxManager;
 import org.apache.james.mailbox.exception.MailboxException;
 import org.apache.james.mailbox.model.QuotaRoot;
@@ -31,10 +33,10 @@ import org.apache.james.mailbox.store.qu
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import javax.inject.Inject;
-import javax.inject.Singleton;
-import java.util.concurrent.ExecutionException;
-import java.util.concurrent.atomic.AtomicLong;
+import com.google.common.base.Preconditions;
+import com.google.common.cache.CacheBuilder;
+import com.google.common.cache.CacheLoader;
+import com.google.common.cache.LoadingCache;
 
 @Singleton
 public class InMemoryCurrentQuotaManager implements StoreCurrentQuotaManager {

Modified: james/project/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/james/project/trunk/pom.xml?rev=1712498=1712497=1712498=diff
==
--- james/project/trunk/pom.xml (original)
+++ james/project/trunk/pom.xml Wed Nov  4 08:28:55 2015
@@ -789,6 +789,8 @@
 
 -Xms256m -Xmx512m
 always
+
+
1800
 
 
 



-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

svn commit: r1712501 - in /james/project/trunk/backends-common/cassandra/src: main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java test/java/org/apache/james/backends/cassandra/Cassa

2015-11-04 Thread aduprat

Author: aduprat
Date: Wed Nov  4 08:30:22 2015
New Revision: 1712501

URL: http://svn.apache.org/viewvc?rev=1712501=rev
Log:
JAMES-1634 Faster Cassandra tests. Contributed by Duprat 

Modified:

james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java

james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java

Modified: 
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java?rev=1712501=1712500=1712501=diff
==
--- 
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java
 (original)
+++ 
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java
 Wed Nov  4 08:30:22 2015
@@ -20,8 +20,10 @@
 package org.apache.james.backends.cassandra.init;
 
 import java.util.List;
+import java.util.Optional;
 
 import com.datastax.driver.core.Cluster;
+import com.datastax.driver.core.QueryOptions;
 import com.google.common.base.Strings;
 import com.google.common.collect.ImmutableList;
 
@@ -40,7 +42,9 @@ public class ClusterFactory {
 private final static String DEFAULT_CLUSTER_IP = "localhost";
 private final static int DEFAULT_CLUSTER_PORT = 9042;
 
-public static Cluster 
createClusterForClusterWithPassWord(List servers, String 
userName, String password) {
+public static Cluster 
createClusterForClusterWithPassWord(List servers, String 
userName, String password, 
+Optional refreshSchemaIntervalMillis) {
+
 Cluster.Builder clusterBuilder = Cluster.builder();
 servers.forEach(
 (server) -> 
clusterBuilder.addContactPoint(server.ip).withPort(server.port)
@@ -48,22 +52,29 @@ public class ClusterFactory {
 if(!Strings.isNullOrEmpty(userName) && 
!Strings.isNullOrEmpty(password)) {
 clusterBuilder.withCredentials(userName, password);
 }
+if (refreshSchemaIntervalMillis.isPresent()) {
+clusterBuilder.withQueryOptions(new 
QueryOptions().setRefreshSchemaIntervalMillis(refreshSchemaIntervalMillis.get()));
+}
 return clusterBuilder.build();
 }
 
 public static Cluster 
createClusterForClusterWithoutPassWord(List servers) {
-return createClusterForClusterWithPassWord(servers, null, null);
+return createClusterForClusterWithPassWord(servers, null, null, 
Optional.empty());
 }
 
 public static Cluster createClusterForSingleServerWithPassWord(String ip, 
int port, String userName, String password) {
-return createClusterForClusterWithPassWord(ImmutableList.of(new 
CassandraServer(ip, port)), userName, password);
+return createClusterForClusterWithPassWord(ImmutableList.of(new 
CassandraServer(ip, port)), userName, password, Optional.empty());
 }
 
 public static Cluster createClusterForSingleServerWithoutPassWord(String 
ip, int port) {
-return createClusterForClusterWithPassWord(ImmutableList.of(new 
CassandraServer(ip, port)), null, null);
+return createClusterForClusterWithPassWord(ImmutableList.of(new 
CassandraServer(ip, port)), null, null, Optional.empty());
+}
+
+public static Cluster createTestingCluster(String ip, int port) {
+return createClusterForClusterWithPassWord(ImmutableList.of(new 
CassandraServer(ip, port)), null, null, Optional.of(0));
 }
 
- public static Cluster createDefaultSession() {
+public static Cluster createDefaultSession() {
 return createClusterForSingleServerWithoutPassWord(DEFAULT_CLUSTER_IP, 
DEFAULT_CLUSTER_PORT);
 }
 }

Modified: 
james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java?rev=1712501=1712500=1712501=diff
==
--- 
james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
 (original)
+++ 
james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
 Wed Nov  4 08:30:22 2015
@@ -55,6 +55,7 @@ public final class CassandraCluster {
 this.module = module;
 try {
 EmbeddedCassandraServerHelper.startEmbeddedCassandra();
+
 session = new FunctionRunnerWithRetry(MAX_RETRY)

[jira] [Closed] (JAMES-1633) Tests on SMTPServer are randomly locked

2015-11-04 Thread Antoine Duprat (JIRA)


 [ 
https://issues.apache.org/jira/browse/JAMES-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antoine Duprat closed JAMES-1633.
-
Resolution: Fixed

merged

> Tests on SMTPServer are randomly locked
> ---
>
> Key: JAMES-1633
> URL: https://issues.apache.org/jira/browse/JAMES-1633
> Project: James Server
>  Issue Type: Bug
>Reporter: Antoine Duprat
>
> Tests on SMTPServer are randomly locked, then the build never reach the end.
> Adding a timeout in surefire configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1635) Can not run unit tests

[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...

[jira] [Commented] (JAMES-1635) Can not run unit tests

[jira] [Created] (JAMES-1637) I want to resume compilation using docker

[jira] [Created] (JAMES-1636) test failure on org.apache.james.user.cassandra.CassandraUsersRepositoryTest

[jira] [Commented] (JAMES-1636) test failure on org.apache.james.user.cassandra.CassandraUsersRepositoryTest

[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...

[jira] [Commented] (JAMES-1635) Can not run unit tests

[jira] [Commented] (JAMES-1635) Can not run unit tests

[jira] [Created] (JAMES-1635) Can not run unit tests

[GitHub] james-project pull request: Mailbox 211 : distributed event system...

[jira] [Commented] (JAMES-1635) Can not run unit tests

[jira] [Commented] (JAMES-1635) Can not run unit tests

[jira] [Commented] (JAMES-1635) Can not run unit tests

[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...

svn commit: r1712585 - in /james/project/trunk/server/data: data-api/src/test/ data-cassandra/src/test/java/org/apache/james/user/cassandra/ data-file/src/test/java/org/apache/james/user/file/ data-hb

[jira] [Closed] (JAMES-1636) test failure on org.apache.james.user.cassandra.CassandraUsersRepositoryTest

[jira] [Commented] (JAMES-1634) Slow Cassandra tests

svn commit: r1712518 - /james/project/trunk/pom.xml

svn commit: r1712519 - in /james/project/trunk/src/site/xdoc: index.xml newsarchive.xml

svn commit: r1712506 - /james/project/trunk/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java

[jira] [Updated] (JAMES-1634) Slow Cassandra tests when creating tables

[jira] [Updated] (JAMES-1634) Slow Cassandra tests when creating tables

[jira] [Closed] (JAMES-1634) Slow Cassandra tests when creating tables

svn commit: r1712513 - in /james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver: AuthRequiredToRelayRcptHook.java SenderAuthIdentifyVerificationRcptHook.java

James & Guice

svn commit: r1712516 - in /james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver: AuthRequiredToRelayRcptHook.java SenderAuthIdentifyVerificationRcptHook.java

[jira] [Commented] (JAMES-1477) Replace @Resource with @Inject where it can

svn commit: r1712498 - in /james/project/trunk: mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryCurrentQuotaManager.java pom.xml

svn commit: r1712501 - in /james/project/trunk/backends-common/cassandra/src: main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java test/java/org/apache/james/backends/cassandra/Cassa

[jira] [Closed] (JAMES-1633) Tests on SMTPServer are randomly locked

31 matches

Site Navigation

Mail list logo

Footer information