Re: 8206074: nsk/jdi/EventRequestManager/createStepRequest/crstepreq001/TestDescription.java is timing out
Thank you, Gary and Chris, for reviewing this change. Best regards, --Daniil On 6/6/19, 7:46 AM, "Gary Adams" wrote: This fix looks good to me. We've plugged a number of edge cases in the tests where the timing of debuggee and debugger processes was not guaranteed during shutdown of the test. The only improvement we could add here is to test if the vm is suspended, but an extra resume does no harm to ensure the debuggee is running to receive the quit message. On 6/5/19, 10:36 PM, Daniil Titov wrote: > Please review a change that fixes the intermittent failure of the test. > > The problem here that there is a chance that a single step event had been posted after the step request was created and before it was deleted. > > The fix solves this by ensuring that vm.resume() is called at the end of the test. > > Webrev: http://cr.openjdk.java.net/~dtitov/8206074/webrev.01 > Bug: https://bugs.openjdk.java.net/browse/JDK-8206074 > > Thanks! > --Daniil > > >
RFR(S): 8225388: Running jcmd Compiler.CodeHeap_Analytics all 0 cause crash.
Hi Could you please review following fix which verify parameter for Compiler.CodeHeap_Analytics command. So jcmd just exits instead of crashing target VM. Regression test was added, hs-tier1/2 passed. webrev: http://cr.openjdk.java.net/~lmesnik/8225388/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8225388 Leonid
Re: RFR: 8206074: nsk/jdi/EventRequestManager/createStepRequest/crstepreq001/TestDescription.java is timing out
This fix looks good to me. We've plugged a number of edge cases in the tests where the timing of debuggee and debugger processes was not guaranteed during shutdown of the test. The only improvement we could add here is to test if the vm is suspended, but an extra resume does no harm to ensure the debuggee is running to receive the quit message. On 6/5/19, 10:36 PM, Daniil Titov wrote: Please review a change that fixes the intermittent failure of the test. The problem here that there is a chance that a single step event had been posted after the step request was created and before it was deleted. The fix solves this by ensuring that vm.resume() is called at the end of the test. Webrev: http://cr.openjdk.java.net/~dtitov/8206074/webrev.01 Bug: https://bugs.openjdk.java.net/browse/JDK-8206074 Thanks! --Daniil
