Re: CVS commit: src/sys/dev/pci
On Fri, 22 Jul 2022, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Fri Jul 22 05:23:50 UTC 2022 Modified Files: src/sys/dev/pci: if_wm.c if_wmreg.h Log Message: Add more statistics countes. - Add many statics counters that the chip has. Shouldn't you say which "the chip" you're talking about since wm seems to handle so many? I suppose this isn't git so you can't fix this easily. - Attach event counters only if available. To generate a diff of this commit: cvs rdiff -u -r1.745 -r1.746 src/sys/dev/pci/if_wm.c cvs rdiff -u -r1.126 -r1.127 src/sys/dev/pci/if_wmreg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
Re: CVS commit: src/sys/netinet6
On Wed, 28 Aug 2019, Roy Marples wrote: On 27/08/2019 22:17, Hisashi T Fujinaka wrote: Is this necessary for -9 too? Pretty much every BSD with IPv6. I'll submit a PR for -9 in day or so. I need to work this and a few other recent changes for -8 and maybe -7 also. Cool. Thanks for all the effort! -- Hisashi T Fujinaka - ht...@twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
Re: CVS commit: src/sys/netinet6
Is this necessary for -9 too? On Tue, 27 Aug 2019, Roy Marples wrote: Module Name:src Committed By: roy Date: Tue Aug 27 21:11:26 UTC 2019 Modified Files: src/sys/netinet6: nd6.c Log Message: inet6: nd6_free assumes all routers are processed by kernel RA This hasn't been the case for a long time if you're a dhcpcd user with a default config. As such, it's possible for the default IPv6 router as set by dhcpcd could be erroneously gc'ed by nd6_free. This reduces the scope of the ND6_WLOCK taken as well as fixing an issue where we write to ln->ln_state without a lock being held. To generate a diff of this commit: cvs rdiff -u -r1.259 -r1.260 src/sys/netinet6/nd6.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
Re: CVS commit: src/sys/kern
On Thu, 27 Jun 2019, Maxime Villard wrote: Le 27/06/2019 ? 20:56, Christos Zoulas a ?crit : On Jun 27, 8:30pm, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/kern | Le 27/06/2019 ? 19:07, Christos Zoulas a ??crit? : | > Module Name: src | > Committed By:christos | > Date:Thu Jun 27 17:07:51 UTC 2019 | > | > Modified Files: | > src/sys/kern: kern_exec.c | > | > Log Message: | > Return an error if the path was too long. Pointed out by maxv | > | > | > To generate a diff of this commit: | > cvs rdiff -u -r1.474 -r1.475 src/sys/kern/kern_exec.c | > | > Please note that diffs are not public domain; they are subject to the | > copyright notices on the relevant files. | | Did you just introduce an even bigger bug? I don't know, is this the most efficient way to communicate it if I did? This got to be a fucking joke. I find you to be rude and boorish. If you're so smart, why can't you help people with the problems instead of insulting them? -- Hisashi T Fujinaka - ht...@twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
Re: CVS commit: [netbsd-8] src/sys/compat
Yeah, I told Martin already, but he had to go to bed. Stupid global project. :) On Wed, 2 Jan 2019, Tom Spindler (moof) wrote: This breaks the netbsd-8 build: dependall ===> lib/libc # compile libc/compat___msgctl13.o /usr/obj/8tools/bin/x86_64--netbsd-gcc -O2 -std=gnu99-Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wsystem-headers -Wno-traditional -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare -Wold-style-definition -Wsign-compare -Wformat=2 -Wno-format-zero-length -Werror -fPIE -fstack-protector -Wstack-protector --param ssp-buffer-size=1 --sysroot=/usr/obj/8dd -D_LIBC -DLIBC_SCCS -DSYSLIBC_SCCS -D_REENTRANT -DHESIOD -DINET6 -DNLS -DYP -I/src/nb8src/lib/libc/include -I/src/nb8src/lib/libc -I/src/nb8src/sys -I/src/nb8src/lib/libc/compat/../locale -I/src/nb8src/lib/libc/compat/stdlib -I/src/nb8src/lib/libc/compat/../stdlib -D__BUILD_LEGACY -I/src/nb8src/lib/libc/../../common/lib/libc/quad -I/src/nb8src/lib/libc/../../common/lib/libc/string -I/src/nb8src/lib/libc/../../common/lib/libc/arch/x86_64/string -D__DBINTERFACE_PRIVATE -I/src/nb8src/libexec/ld.elf_so -I/ src/nb8src/lib/libc/dlfcn -I/src/nb8src/lib/libc/gdtoa -I/src/nb8src/lib/libc/locale -DNO_FENV_H -I/src/nb8src/lib/libc/arch/x86_64/gdtoa -DWITH_RUNE -I/src/nb8src/lib/libc -DPOSIX_MISTAKE -DCOMPAT__RES -DUSE_POLL -DPORTMAP -DWIDE_DOUBLE -DALL_STATE -DUSG_COMPAT -D_FORTIFY_SOURCE=2 -c /src/nb8src/lib/libc/compat/sys/compat___msgctl13.c -o compat___msgctl13.o In file included from /src/nb8src/lib/libc/compat/sys/compat___msgctl13.c:48:0: /src/nb8src/sys/compat/sys/msg.h: In function '__native_to_msqid_ds13': /src/nb8src/sys/compat/sys/msg.h:111:2: error: implicit declaration of function 'memset' [-Werror=implicit-function-declaration] memset(omsqbuf, 0, sizeof(*omsqbuf)); ^ /src/nb8src/sys/compat/sys/msg.h:111:2: error: incompatible implicit declaration of built-in function 'memset' [-Werror] /src/nb8src/sys/compat/sys/msg.h:111:2: note: include '' or provide a declaration of 'memset' /src/nb8src/sys/compat/sys/msg.h: In function '__native_to_msqid_ds14': /src/nb8src/sys/compat/sys/msg.h:153:2: error: incompatible implicit declaration of built-in function 'memset' [-Werror] memset(omsqbuf, 0, sizeof(*omsqbuf)); ^ /src/nb8src/sys/compat/sys/msg.h:153:2: note: include '' or provide a declaration of 'memset' On Wed, Jan 02, 2019 at 03:51:31PM +, Martin Husemann wrote: Module Name: src Committed By: martin Date: Wed Jan 2 15:51:31 UTC 2019 Modified Files: src/sys/compat/netbsd32 [netbsd-8]: netbsd32_compat_14.c netbsd32_conv.h src/sys/compat/sys [netbsd-8]: msg.h Log Message: Pull up following revision(s) (requested by maxv in ticket #1151): sys/compat/netbsd32/netbsd32_conv.h: revision 1.37 sys/compat/netbsd32/netbsd32_compat_14.c: revision 1.27 sys/compat/sys/msg.h: revision 1.5 Fix kernel info leaks. + Possible info leak: [len=80, leaked=10] | #0 0x80bad7a7 in kleak_copyout | #1 0x8048e71b in netbsd32___msgctl50 | #2 0x8022fb5b in netbsd32_syscall | #3 0x802096dd in handle_syscall To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.26.10.1 src/sys/compat/netbsd32/netbsd32_compat_14.c cvs rdiff -u -r1.31.8.1 -r1.31.8.2 src/sys/compat/netbsd32/netbsd32_conv.h cvs rdiff -u -r1.4 -r1.4.58.1 src/sys/compat/sys/msg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
Re: CVS commit: [netbsd-8] src/sys/net
I think you forgot something: Index: sys/net/if_vlan.c === RCS file: /cvsroot/src/sys/net/if_vlan.c,v retrieving revision 1.97.2.15 diff -u -r1.97.2.15 if_vlan.c --- sys/net/if_vlan.c 21 Oct 2018 11:55:54 - 1.97.2.15 +++ sys/net/if_vlan.c 21 Oct 2018 18:36:20 - @@ -161,6 +161,7 @@ * instead of direct dereference */ kmutex_t ifv_lock; /* writer lock for ifv_mib */ + pserialize_t ifv_psz; LIST_HEAD(__vlan_mchead, vlan_mc_entry) ifv_mc_listhead; LIST_ENTRY(ifvlan) ifv_list; -- Hisashi T Fujinaka - ht...@twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
Re: CVS commit: src/games/wtf
On Thu, 16 Aug 2018, Joerg Sonnenberger wrote: On Thu, Aug 16, 2018 at 02:18:37PM +, m...@netbsd.org wrote: On Thu, Aug 16, 2018 at 03:41:59PM +0200, Joerg Sonnenberger wrote: On Thu, Aug 16, 2018 at 01:31:04PM +, Maya Rashish wrote: Module Name:src Committed By: maya Date: Thu Aug 16 13:31:04 UTC 2018 Modified Files: src/games/wtf: wtf Log Message: Try freebsd's pkg-info as well From John Hein, via Nikolai Lifanov. PR misc/52684 Why? What next, asking rpm or dpkg if someone installed them? It's not premature-portability like you're implying. It's coming from someone who has been sending countless of patches and uses it on FreeBSD for real. It's also like 5 lines of diff. This is a *base system* program. Yeah. I think that functionality should be in pkgsrc, which is funny because then you'd need pkgsrc to get info on pkg-info. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
Re: CVS commit: src/lib/libc/time
No commit message? On Wed, 8 Jul 2015, Brian Ginsbach wrote: Module Name:src Committed By: ginsbach Date: Wed Jul 8 18:44:09 UTC 2015 Modified Files: src/lib/libc/time: strptime.c To generate a diff of this commit: cvs rdiff -u -r1.40 -r1.41 src/lib/libc/time/strptime.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
Re: CVS commit: [netbsd-7] src/distrib/sets/lists/debug
Whoops. Wrong tree. Let me revert and submit a pullup request. On Thu, 11 Dec 2014, Hisashi T Fujinaka wrote: Module Name:src Committed By: htodd Date: Thu Dec 11 23:44:13 UTC 2014 Modified Files: src/distrib/sets/lists/debug [netbsd-7]: shl.mi Log Message: Fix debug build. To generate a diff of this commit: cvs rdiff -u -r1.71.2.2 -r1.71.2.3 src/distrib/sets/lists/debug/shl.mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
Re: CVS commit: src/distrib/sets/lists/debug
On Wed, 2 Jul 2014, Alexander Nasonov wrote: Hisashi T Fujinaka wrote: Module Name:src Committed By: htodd Date: Wed Jul 2 05:23:20 UTC 2014 Modified Files: src/distrib/sets/lists/debug: md.amd64 md.i386 mi Log Message: Move t_bpfjit.debug to md lists. Why did you make this change? It worked for libbpfjit for quite a while. I thought that marking entries with sljit was enough. Alex It broke my builds. Did you build earm with debug turned on? -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/tests/ipf
On Tue, 1 Jul 2014, Darren Reed wrote: On 1/07/2014 12:34 AM, Martin Husemann wrote: On Sun, Jun 29, 2014 at 09:25:31AM +, Darren Reed wrote: Module Name:src Committed By: darrenr Date: Sun Jun 29 09:25:31 UTC 2014 Added Files: src/tests/ipf/expected: in100_6 in101_6 in102_6 in1_6 in2_6 in3_6 in4_6 in5_6 in6_6 in8_6 src/tests/ipf/regress: in100_6 in101_6 in102_6 in1_6 in2_6 in3_6 in4_6 in5_6 in6_6 in8_6 Log Message: Add in test cases for testing ipnat's parsing of IPv6 NAT rules Do they work for you? They fail in our test runs. They were missing from Makefile's. This should now be resolved. Now you need to fix the setlists. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/sys/arch/arm/arm32
On Wed, 2 Apr 2014, Matt Thomas wrote: Module Name:src Committed By: matt Date: Wed Apr 2 14:05:54 UTC 2014 Modified Files: src/sys/arch/arm/arm32: pmap.c Log Message: Init the page_lock to IPL_VM iff VIPT arm_cache_prefer_mask != 0 otherwise use IPL_NONE. Don't bother with page_lock for KMPAGEs. To generate a diff of this commit: cvs rdiff -u -r1.277 -r1.278 src/sys/arch/arm/arm32/pmap.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. This won't build without DIAGNOSITC defined. In map_kremove_pg() you use omd without defining it otherwise. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/bin/ls
On Sat, 22 Feb 2014, David Holland wrote: On Fri, Feb 21, 2014 at 06:23:43PM +, Christos Zoulas wrote: Log Message: Add -O (only leaf files) and -P (print full path), from tls@ Do any other ls implementations have such options? I like the idea of being able to run ls -ROP1 . instead of find . type f -print, but I'd like the options to be compatible with other operating systems. No. And the -O and -P letters are unused by linux, solaris, aix, hp/ux. hurry and take it to posix! This broke my build, btw. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/distrib/sets/lists/comp
On Sun, 27 Oct 2013, Marc Balmer wrote: Am 27.10.13 09:33, schrieb Marc Balmer: Am 27.10.13 03:39, schrieb Hisashi T Fujinaka: Module Name:src Committed By: htodd Date: Sun Oct 27 02:39:21 UTC 2013 Modified Files: src/distrib/sets/lists/comp: mi Log Message: Revert mi because the added line refers to an imaginary file. A better solution would have been to contact me, as obviously a file was missed in a commit. Just silently backing out others changes is considered rude... Actually the file was apparently there, but entered to the Makefile. It should all be in order now. (doing a full release build again to verify) You were probably asleep because I'm sure you're in Europe, and it was obvious what you did. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/usr.sbin/rtsold
On Sat, 25 May 2013, Robert Elz wrote: Date:Fri, 24 May 2013 16:47:08 + From:David Holland dholland-sourcechan...@netbsd.org Message-ID: 20130524164708.ga...@netbsd.org | : -The default interval for router advertisements, which is on the order of 10 | : +The default interval for router advertisements, which is in the order of 10 | | ...it should be on Actually, I think it should be of. in when it relates to orders would be used for the kind of order where a follows b follows c - those are in the order of ... on when it relates to orders would refer to something that is written, and there may be a note, on the order, that X should be added, or ... of when it relates to orders comes to comparisons, and is the variant that is meant here, it means approximately 10 minutes, or of the order of 10 minutes. In US English, it would be on the order of which means around or about. In fact, can't we just replace it with one of those? -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/distrib/utils/embedded
On Mon, 8 Apr 2013, Jared McNeill wrote: On Fri, 5 Apr 2013, Hisashi T Fujinaka wrote: On Sat, 6 Apr 2013, Izumi Tsutsui wrote: If the problem is overflow of the image, shouldn't the extra variable in each config file be bumped instead of changing a unit? Sorry for the messy commit. I just changed the -b line the way I did because I'm not sure where extra comes from and version 1.37 broke every img that I tried to build. In such case, asking comitter (or filing PR) would be better. I did, and heard no objections to my change. As author of 1.37, just so it's clear that I didn't approve this commit, I don't recall being asked about it at all. I asked you directly several times on IRC and you didn't reply, though you were replying to others. I figured you didn't care. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/distrib/utils/embedded
On Mon, 8 Apr 2013, Valery Ushakov wrote: On Mon, Apr 08, 2013 at 06:35:03 -0700, Hisashi T Fujinaka wrote: On Mon, 8 Apr 2013, Jared McNeill wrote: As author of 1.37, just so it's clear that I didn't approve this commit, I don't recall being asked about it at all. I asked you directly several times on IRC and you didn't reply, though you were replying to others. I figured you didn't care. IRC is not an official or reliable communication channel, it's a bad idea to assume that lack of reaction on IRC means anything. Seeing as how I didn't revert someone else's commit and I fixed a build break after reading the man pages and thought I wasn't actually committing any egregious errors, why are we still talking about this? I did fix my commit message to something more descriptive later. Sorry for that. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/distrib/utils/embedded
On Sat, 6 Apr 2013, Izumi Tsutsui wrote:
Module Name:src
Committed By: htodd
Date: Wed Apr 3 19:37:43 UTC 2013
Modified Files:
src/distrib/utils/embedded: mkimage
Log Message:
Fix build.
What build problem did you try to fix?
--- mkimage 28 Mar 2013 00:20:02 - 1.37
+++ mkimage 3 Apr 2013 19:37:43 - 1.38
@@ -156,8 +156,8 @@ if [ -z $bootonly ]; then
echo ${bar} Populating ffs filesystem ${bar}
${MAKEFS} -N ${release}/etc -t ffs -rx \
-O $(((${init} + ${boot} + ${swap}) / 2))m \
- -b $((${extra} / 2))m \
- -o d=4096 \
+ -o d=4096 \
+ -b $((${extra}))m \
-F $tmp/selected_sets ${image} ${release} ${mnt}
fi
---
If the problem is overflow of the image, shouldn't the extra variable
in each config file be bumped instead of changing a unit?
Sorry for the messy commit. I just changed the -b line the way I did
because I'm not sure where extra comes from and version 1.37 broke every
img that I tried to build.
If you think there's a better way to fix it, please do.
--
Hisashi T Fujinaka - ht...@twofifty.com
BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/distrib/utils/embedded
On Sat, 6 Apr 2013, Izumi Tsutsui wrote: If the problem is overflow of the image, shouldn't the extra variable in each config file be bumped instead of changing a unit? Sorry for the messy commit. I just changed the -b line the way I did because I'm not sure where extra comes from and version 1.37 broke every img that I tried to build. In such case, asking comitter (or filing PR) would be better. I did, and heard no objections to my change. extra is defined in config files in src/distrib/utils/embedded/conf and probably it's required because ffs size calculation in makefs(8) is not so accurate. http://nxr.netbsd.org/xref/src/usr.sbin/makefs/ffs.c#590 I'm still not sure that the end-result (even though I didn't know where EXTRA came from) was wrong. As I said before, you can change it if you think it's wrong. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/sys
On Tue, 31 Jul 2012, Jonathan A. Kollasch wrote: On Tue, Jul 31, 2012 at 03:50:39PM +, Manuel Bouyer wrote: Apply back changes that were reverted on Jul 24 and Jul 26 (general ata/wdc cleanup and SATA PMP support), now that I'm back to fix the fallouts. What about the fallout (that on inspection of the code I'm fairly sure exists) that won't be immediately detected? The drive_type change is far too significant to be applied with other unrelated changes as well. Did you fix the problem with drives disappearing in amd64? -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/lib/libpam/modules/pam_ssh
On Mon, 22 Nov 2010, Christos Zoulas wrote: In article 20101121204136.cbed017...@cvs.netbsd.org, Adam Ciarcinski source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name:src Committed By: adam Date: Sun Nov 21 20:41:36 UTC 2010 Modified Files: src/lib/libpam/modules/pam_ssh: pam_ssh.c Log Message: Use ssh_add_identity_constrained() instead of ssh_add_identity() Just for this example you need to bump the major of libssh! I'm having all sorts of troubles with casting for prints, etc. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
Re: CVS commit: src/sys/uvm
On Fri, 5 Feb 2010, Masao Uebayashi wrote: I guess you're not on current-users. We've been talking about it since 12 hours before Geoff told you about it. When I woke up I read my inbox from new ones. Sorry for incovenience. No problems. It seems to be fixed now. -- Hisashi T Fujinaka - ht...@twofifty.com BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
