Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Paweł Hajdan , Jr .]

If you have some time for that, I'd appreciate patching at least fts2. This
will make it possible for Chromium to drop another custom patch for SQLite.

On Wed, Aug 18, 2010 at 13:49, Richard Hipp  wrote:

> I'm thinking that you shouldn't be using FTS1 and FTS2 in the first place.
> They are untested and unsupported.  We'll get around to patching them, if
> you insist, but right now we are busy trying to 3.7.1 out the door.
>
> On Wed, Aug 18, 2010 at 4:41 PM, Paweł Hajdan, Jr.
> wrote:
>
> > On Tue, Aug 10, 2010 at 13:16, Paweł Hajdan, Jr. <
> phajdan...@chromium.org
> > >wrote:
> >
> > > Now, how about fts1 and fts2? The original chromium patch is at
> > > http://codereview.chromium.org/174387 . Could you take a look and
> > suggest
> > > a way to upstream those fixes to SQLite?
> > >
> >
> > Ping about the above. Or have the fixes already been made and we just
> need
> > to upgrade to new sqlite?
> > ___
> > sqlite-users mailing list
> > sqlite-users@sqlite.org
> > http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
> >
>
>
>
> --
> D. Richard Hipp
> d...@sqlite.org
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Scott Hess]

I'm not sure Chromium has any fts1 databases, I think the original
patch was applied there for completeness.

The change from fts2 to fts3 has been made in the history system, but
it only applies to new data, and hasn't yet rolled out to stable.  So
we wouldn't be able to even start to cease using it for awhile.
Furthermore, for performance reasons we segment and finalize the
history data by month, so older data will continue to use fts2.  We
could add new code to upgrade that older data, though there would be
some risk of that causing new problems (some of the data has been idle
for a long time, so no doubt we'll flush out undetected corruptions,
etc), and the straight-forward migration strategy would require fts2
to stay linked until we had some confidence that most of the users had
launched their browsers for long enough that the migration had
completed.  So it wouldn't really be the preferred solution, given
that the current code is fairly well-tested (for our case).

I suppose we could pull in the time window by using internals
knowledge to upgrade fts2 tables manually.  Either we could steal the
document table and load it into an fts3 table, or we could edit the
sqlite_master table directly to convert it to an fts3 table.  Hmm.  Or
it's possible we could have fts3.c register as handling fts2 tables,
which I think would work alright in the read-only case, though it's
mis-leading at best.

It is also possible that there are web-developer-controlled tables in
the wild using fts2 (I mean like WHATWG Web SQL Database).  I lobbied
to include fts3 for that because I didn't think we should encourage
fts2, but I don't know whether I caught it soon enough.  I also don't
know the status of this WRT Gears, though for purposes of Chromium
upstreaming things I don't think that matters.

-scott



On Wed, Aug 18, 2010 at 1:49 PM, Richard Hipp  wrote:
> I'm thinking that you shouldn't be using FTS1 and FTS2 in the first place.
> They are untested and unsupported.  We'll get around to patching them, if
> you insist, but right now we are busy trying to 3.7.1 out the door.
>
> On Wed, Aug 18, 2010 at 4:41 PM, Paweł Hajdan, Jr.
> wrote:
>
>> On Tue, Aug 10, 2010 at 13:16, Paweł Hajdan, Jr. > >wrote:
>>
>> > Now, how about fts1 and fts2? The original chromium patch is at
>> > http://codereview.chromium.org/174387 . Could you take a look and
>> suggest
>> > a way to upstream those fixes to SQLite?
>> >
>>
>> Ping about the above. Or have the fixes already been made and we just need
>> to upgrade to new sqlite?
>> ___
>> sqlite-users mailing list
>> sqlite-users@sqlite.org
>> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>>
>
>
>
> --
> D. Richard Hipp
> d...@sqlite.org
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Richard Hipp]

I'm thinking that you shouldn't be using FTS1 and FTS2 in the first place.
They are untested and unsupported.  We'll get around to patching them, if
you insist, but right now we are busy trying to 3.7.1 out the door.

On Wed, Aug 18, 2010 at 4:41 PM, Paweł Hajdan, Jr.
wrote:

> On Tue, Aug 10, 2010 at 13:16, Paweł Hajdan, Jr.  >wrote:
>
> > Now, how about fts1 and fts2? The original chromium patch is at
> > http://codereview.chromium.org/174387 . Could you take a look and
> suggest
> > a way to upstream those fixes to SQLite?
> >
>
> Ping about the above. Or have the fixes already been made and we just need
> to upgrade to new sqlite?
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>



-- 
D. Richard Hipp
d...@sqlite.org
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Paweł Hajdan , Jr .]

On Tue, Aug 10, 2010 at 13:16, Paweł Hajdan, Jr. wrote:

> Now, how about fts1 and fts2? The original chromium patch is at
> http://codereview.chromium.org/174387 . Could you take a look and suggest
> a way to upstream those fixes to SQLite?
>

Ping about the above. Or have the fixes already been made and we just need
to upgrade to new sqlite?
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Paweł Hajdan , Jr .]

Thank you, I have backported it to chromium as
http://src.chromium.org/viewvc/chrome?view=rev=55504

Now, how about fts1 and fts2? The original chromium patch is at
http://codereview.chromium.org/174387 . Could you take a look and suggest a
way to upstream those fixes to SQLite?

On Fri, Aug 6, 2010 at 12:10, Richard Hipp  wrote:

> FTS3 updated here:  http://www.sqlite.org/src/ci/b8b465ed2c
>
> On Fri, Aug 6, 2010 at 2:24 PM, Scott Hess  wrote:
>
> > This bug comment describes the problem:
> >   http://code.google.com/p/chromium/issues/detail?id=15261#c20
> >
> > excerpt:
> > > Apparently the problem is caused by tolower(), whose behavior is
> affected
> > by current
> > > locale. Under locale tr_TR.UTF-8, tolower('I') returns 'I' rather than
> > 'i', because
> > > lower case of 'I' defined in tr_TR is 'ı' (U+0131).
> >
> > I think at the time the bug was being diagnosed, sqlite3_strnicmp()
> > wasn't being exposed.  I think that does the right thing because it
> > uses the internal UpperToLower table.
> >
> > -scott
> >
> >
> > On Fri, Aug 6, 2010 at 11:11 AM, Richard Hipp  wrote:
> > > If "ch" is an unsigned char then how is the following unsafe:
> > >
> > > ch = (ch<0x80) ? tolower(ch) : ch
> > >
> > > And why does it need to be changed to
> > >
> > >ch = (ch>='A' && ch<='Z') ? ch - 'A' + 'a' : ch;
> > >
> > > There is only one such instance of code remaining in FTS3 (at
> > > fts3_tokenizer1.c:196) but I want to understand what the issue is
> before
> > I
> > > change it.
> > >
> > > On Fri, Aug 6, 2010 at 1:30 PM, Paweł Hajdan, Jr.
> > > wrote:
> > >
> > >> On Wed, Aug 4, 2010 at 15:23, Paweł Hajdan, Jr. <
> > phajdan...@chromium.org
> > >> >wrote:
> > >>
> > >> > I'm attaching a suggested patch to fix locale-unsafe usage of
> tolower
> > in
> > >> > FTS code. The goal is to make Chromium closer to the upstream, so if
> > you
> > >> > have a better solution, that's great.
> > >>
> > >>
> > >> Oh, I have just noticed that the mailing list removes all attachments.
> > What
> > >> is the best way to send patches then?
> > >>
> > >> By the way, any suggestions about the Chromium patch I linked to (
> > >>
> > >>
> >
> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/safe-tolower.patch?view=markup
> > >> )?
> > >> It seems that it has somehow been fixed in fts3 code. I'm not yet very
> > >> familiar with the SQLite codebase though, so could you point me to the
> > >> fixes?
> > >> ___
> > >> sqlite-users mailing list
> > >> sqlite-users@sqlite.org
> > >> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
> > >>
> > >
> > >
> > >
> > > --
> > > -
> > > D. Richard Hipp
> > > d...@sqlite.org
> > > ___
> > > sqlite-users mailing list
> > > sqlite-users@sqlite.org
> > > http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
> > >
> > ___
> > sqlite-users mailing list
> > sqlite-users@sqlite.org
> > http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
> >
>
>
>
> --
> -
> D. Richard Hipp
> d...@sqlite.org
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Scott Hess]

Yes.  Pawel is wondering if he could patch fts1 and fts2.  I don't
think Chromium cares about fts1 (our version was patched for
completeness), but I believe there are still places where fts2 is
present because older databases might be using it.

-scott


On Fri, Aug 6, 2010 at 12:10 PM, Richard Hipp  wrote:
> FTS3 updated here:  http://www.sqlite.org/src/ci/b8b465ed2c
>
> On Fri, Aug 6, 2010 at 2:24 PM, Scott Hess  wrote:
>
>> This bug comment describes the problem:
>>   http://code.google.com/p/chromium/issues/detail?id=15261#c20
>>
>> excerpt:
>> > Apparently the problem is caused by tolower(), whose behavior is affected
>> by current
>> > locale. Under locale tr_TR.UTF-8, tolower('I') returns 'I' rather than
>> 'i', because
>> > lower case of 'I' defined in tr_TR is 'ı' (U+0131).
>>
>> I think at the time the bug was being diagnosed, sqlite3_strnicmp()
>> wasn't being exposed.  I think that does the right thing because it
>> uses the internal UpperToLower table.
>>
>> -scott
>>
>>
>> On Fri, Aug 6, 2010 at 11:11 AM, Richard Hipp  wrote:
>> > If "ch" is an unsigned char then how is the following unsafe:
>> >
>> >     ch = (ch<0x80) ? tolower(ch) : ch
>> >
>> > And why does it need to be changed to
>> >
>> >    ch = (ch>='A' && ch<='Z') ? ch - 'A' + 'a' : ch;
>> >
>> > There is only one such instance of code remaining in FTS3 (at
>> > fts3_tokenizer1.c:196) but I want to understand what the issue is before
>> I
>> > change it.
>> >
>> > On Fri, Aug 6, 2010 at 1:30 PM, Paweł Hajdan, Jr.
>> > wrote:
>> >
>> >> On Wed, Aug 4, 2010 at 15:23, Paweł Hajdan, Jr. <
>> phajdan...@chromium.org
>> >> >wrote:
>> >>
>> >> > I'm attaching a suggested patch to fix locale-unsafe usage of tolower
>> in
>> >> > FTS code. The goal is to make Chromium closer to the upstream, so if
>> you
>> >> > have a better solution, that's great.
>> >>
>> >>
>> >> Oh, I have just noticed that the mailing list removes all attachments.
>> What
>> >> is the best way to send patches then?
>> >>
>> >> By the way, any suggestions about the Chromium patch I linked to (
>> >>
>> >>
>> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/safe-tolower.patch?view=markup
>> >> )?
>> >> It seems that it has somehow been fixed in fts3 code. I'm not yet very
>> >> familiar with the SQLite codebase though, so could you point me to the
>> >> fixes?
>> >> ___
>> >> sqlite-users mailing list
>> >> sqlite-users@sqlite.org
>> >> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>> >>
>> >
>> >
>> >
>> > --
>> > -
>> > D. Richard Hipp
>> > d...@sqlite.org
>> > ___
>> > sqlite-users mailing list
>> > sqlite-users@sqlite.org
>> > http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>> >
>> ___
>> sqlite-users mailing list
>> sqlite-users@sqlite.org
>> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>>
>
>
>
> --
> -
> D. Richard Hipp
> d...@sqlite.org
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Nicolas Williams]

On Fri, Aug 06, 2010 at 02:11:33PM -0400, Richard Hipp wrote:
> If "ch" is an unsigned char then how is the following unsafe:
> 
>  ch = (ch<0x80) ? tolower(ch) : ch
> 
> And why does it need to be changed to
> 
> ch = (ch>='A' && ch<='Z') ? ch - 'A' + 'a' : ch;
> 
> There is only one such instance of code remaining in FTS3 (at
> fts3_tokenizer1.c:196) but I want to understand what the issue is before I
> change it.

The problem is that libc's tolower() is locale-aware.
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Richard Hipp]

FTS3 updated here:  http://www.sqlite.org/src/ci/b8b465ed2c

On Fri, Aug 6, 2010 at 2:24 PM, Scott Hess  wrote:

> This bug comment describes the problem:
>   http://code.google.com/p/chromium/issues/detail?id=15261#c20
>
> excerpt:
> > Apparently the problem is caused by tolower(), whose behavior is affected
> by current
> > locale. Under locale tr_TR.UTF-8, tolower('I') returns 'I' rather than
> 'i', because
> > lower case of 'I' defined in tr_TR is 'ı' (U+0131).
>
> I think at the time the bug was being diagnosed, sqlite3_strnicmp()
> wasn't being exposed.  I think that does the right thing because it
> uses the internal UpperToLower table.
>
> -scott
>
>
> On Fri, Aug 6, 2010 at 11:11 AM, Richard Hipp  wrote:
> > If "ch" is an unsigned char then how is the following unsafe:
> >
> > ch = (ch<0x80) ? tolower(ch) : ch
> >
> > And why does it need to be changed to
> >
> >ch = (ch>='A' && ch<='Z') ? ch - 'A' + 'a' : ch;
> >
> > There is only one such instance of code remaining in FTS3 (at
> > fts3_tokenizer1.c:196) but I want to understand what the issue is before
> I
> > change it.
> >
> > On Fri, Aug 6, 2010 at 1:30 PM, Paweł Hajdan, Jr.
> > wrote:
> >
> >> On Wed, Aug 4, 2010 at 15:23, Paweł Hajdan, Jr. <
> phajdan...@chromium.org
> >> >wrote:
> >>
> >> > I'm attaching a suggested patch to fix locale-unsafe usage of tolower
> in
> >> > FTS code. The goal is to make Chromium closer to the upstream, so if
> you
> >> > have a better solution, that's great.
> >>
> >>
> >> Oh, I have just noticed that the mailing list removes all attachments.
> What
> >> is the best way to send patches then?
> >>
> >> By the way, any suggestions about the Chromium patch I linked to (
> >>
> >>
> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/safe-tolower.patch?view=markup
> >> )?
> >> It seems that it has somehow been fixed in fts3 code. I'm not yet very
> >> familiar with the SQLite codebase though, so could you point me to the
> >> fixes?
> >> ___
> >> sqlite-users mailing list
> >> sqlite-users@sqlite.org
> >> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
> >>
> >
> >
> >
> > --
> > -
> > D. Richard Hipp
> > d...@sqlite.org
> > ___
> > sqlite-users mailing list
> > sqlite-users@sqlite.org
> > http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
> >
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>



-- 
-
D. Richard Hipp
d...@sqlite.org
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Scott Hess]

This bug comment describes the problem:
  http://code.google.com/p/chromium/issues/detail?id=15261#c20

excerpt:
> Apparently the problem is caused by tolower(), whose behavior is affected by 
> current
> locale. Under locale tr_TR.UTF-8, tolower('I') returns 'I' rather than 'i', 
> because
> lower case of 'I' defined in tr_TR is 'ı' (U+0131).

I think at the time the bug was being diagnosed, sqlite3_strnicmp()
wasn't being exposed.  I think that does the right thing because it
uses the internal UpperToLower table.

-scott


On Fri, Aug 6, 2010 at 11:11 AM, Richard Hipp  wrote:
> If "ch" is an unsigned char then how is the following unsafe:
>
>     ch = (ch<0x80) ? tolower(ch) : ch
>
> And why does it need to be changed to
>
>    ch = (ch>='A' && ch<='Z') ? ch - 'A' + 'a' : ch;
>
> There is only one such instance of code remaining in FTS3 (at
> fts3_tokenizer1.c:196) but I want to understand what the issue is before I
> change it.
>
> On Fri, Aug 6, 2010 at 1:30 PM, Paweł Hajdan, Jr.
> wrote:
>
>> On Wed, Aug 4, 2010 at 15:23, Paweł Hajdan, Jr. > >wrote:
>>
>> > I'm attaching a suggested patch to fix locale-unsafe usage of tolower in
>> > FTS code. The goal is to make Chromium closer to the upstream, so if you
>> > have a better solution, that's great.
>>
>>
>> Oh, I have just noticed that the mailing list removes all attachments. What
>> is the best way to send patches then?
>>
>> By the way, any suggestions about the Chromium patch I linked to (
>>
>> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/safe-tolower.patch?view=markup
>> )?
>> It seems that it has somehow been fixed in fts3 code. I'm not yet very
>> familiar with the SQLite codebase though, so could you point me to the
>> fixes?
>> ___
>> sqlite-users mailing list
>> sqlite-users@sqlite.org
>> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>>
>
>
>
> --
> -
> D. Richard Hipp
> d...@sqlite.org
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Richard Hipp]

If "ch" is an unsigned char then how is the following unsafe:

 ch = (ch<0x80) ? tolower(ch) : ch

And why does it need to be changed to

ch = (ch>='A' && ch<='Z') ? ch - 'A' + 'a' : ch;

There is only one such instance of code remaining in FTS3 (at
fts3_tokenizer1.c:196) but I want to understand what the issue is before I
change it.

On Fri, Aug 6, 2010 at 1:30 PM, Paweł Hajdan, Jr.
wrote:

> On Wed, Aug 4, 2010 at 15:23, Paweł Hajdan, Jr.  >wrote:
>
> > I'm attaching a suggested patch to fix locale-unsafe usage of tolower in
> > FTS code. The goal is to make Chromium closer to the upstream, so if you
> > have a better solution, that's great.
>
>
> Oh, I have just noticed that the mailing list removes all attachments. What
> is the best way to send patches then?
>
> By the way, any suggestions about the Chromium patch I linked to (
>
> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/safe-tolower.patch?view=markup
> )?
> It seems that it has somehow been fixed in fts3 code. I'm not yet very
> familiar with the SQLite codebase though, so could you point me to the
> fixes?
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>



-- 
-
D. Richard Hipp
d...@sqlite.org
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Paweł Hajdan , Jr .]

On Wed, Aug 4, 2010 at 15:23, Paweł Hajdan, Jr. wrote:

> I'm attaching a suggested patch to fix locale-unsafe usage of tolower in
> FTS code. The goal is to make Chromium closer to the upstream, so if you
> have a better solution, that's great.


Oh, I have just noticed that the mailing list removes all attachments. What
is the best way to send patches then?

By the way, any suggestions about the Chromium patch I linked to (
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/safe-tolower.patch?view=markup)?
It seems that it has somehow been fixed in fts3 code. I'm not yet very
familiar with the SQLite codebase though, so could you point me to the
fixes?
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Paweł Hajdan , Jr .]

On Wed, Aug 4, 2010 at 16:30, Scott Hess  wrote:

> You should probably pull the current SQLite code and make sure the
> patch even applies, and if not, check to make sure that the problem
> hasn't already been fixed.  ext/fts3 should no longer have the flaw in
> question, as that code was heavily rewritten.


Yeah, the fts3 parts no longer apply and are not included in the patch sent
here. I'm working on the latest (fossil) SQLite codebase.


> The fts1/2 changes would probably be better recast in the mode of the
> fts3 changes.  The relevant comment where things are coming clear was:
>   http://code.google.com/p/chromium/issues/detail?id=15261#c20


Yes, that would be a good direction. However, I'm not yet very familiar with
the SQLite codebase, so I sent something that is in our codebase, doesn't
break tests, and asked for suggestions.

We could then see how SQLite fixed the problem in fts3, and backport that to
Chromium's copy.
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Scott Hess]

Pawel,

You should probably pull the current SQLite code and make sure the
patch even applies, and if not, check to make sure that the problem
hasn't already been fixed.  ext/fts3 should no longer have the flaw in
question, as that code was heavily rewritten.  Chromium's SQLite was
last synced from SQLite's version last September, and there has
continued to be SQLite development in the meanwhile.

The fts1/2 changes would probably be better recast in the mode of the
fts3 changes.  The relevant comment where things are coming clear was:
   http://code.google.com/p/chromium/issues/detail?id=15261#c20

-scott


On Wed, Aug 4, 2010 at 3:23 PM, Paweł Hajdan, Jr.
 wrote:
> I'm attaching a suggested patch to fix locale-unsafe usage of tolower in FTS
> code. The goal is to make Chromium closer to the upstream, so if you have a
> better solution, that's great.
>
> This is upstreaming a Chromium patch
> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/safe-tolower.patch?view=markup
>
> The issue has been reported, see
> http://www.sqlite.org/src/tktview/991789d9f3136a0460dc83a33e815c1aa9757c26
>
> What do you think?
>
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>
>
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

[sqlite] [PATCH] Fix locale-unsafe usage of tolower (upstreaming Chromium change)

[Paweł Hajdan , Jr .]

I'm attaching a suggested patch to fix locale-unsafe usage of tolower in FTS
code. The goal is to make Chromium closer to the upstream, so if you have a
better solution, that's great.

This is upstreaming a Chromium patch
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/safe-tolower.patch?view=markup

The issue has been reported, see
http://www.sqlite.org/src/tktview/991789d9f3136a0460dc83a33e815c1aa9757c26

What do you think?
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users