Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-13 Thread PasTim

erland wrote: 
> I’m sure most of them would come here and ask for help anyway and then
> someone can help them troubleshoot. A list of unsupported plugins that
> have been verified to work in the LMS plugins tab isn’t going to help
> them anyway because the probable cause is one of the plugins that don’t
> work and that will not even be in the unsupported list. Looking at
> maxVersion in install.xml won’t help them since it at least for my
> plugins will look like they are going to work forever since I’ve set
> maxVersion to *. Looking at maxTarget in repository files might work but
> that’s a significant change in LMS source code and I’d personally prefer
> if that time instead was spent on implementing music related
> functionality or fixing bugs in broken plugins.
> 
> 
> It would be something separate, not a part of LMS, so it would of course
> be available before, during and after an upgrade. You can look at it as
> a table on a web page with a row for each available plugin and a column
> for each LMS release and an x in each table cell combination that works.
> Someone would still have to create such matrix (maybe you if you see a
> need for it?) but what I’m saying is that it’s unnecessary that Michael
> spend time on it since it’s totally separate from LMS source code.
> 
> 
> That’s good :-)

OK - sounds fine to me.



LMS 7.9.3 on PC, Xubuntu 18.04, FLACs 16->24 bit, 44.1->192kbps.  2
Touchs & EDO.
LMS plugin UPnP/DLNA Bridge to MF M1 CLiC (A308CR amp & ESLs) & Marantz
CR603 UPnP renderers.  
Also Minimserver & Upplay to same & to upmpdcli/mpd PC renderers.  
Squeezelite to Meridian USB Explorer DAC to PC speakers/headphones.  
Wireless Xubuntu 18.04 laptop firefox/upplay or Android 'phone with
Squeeze-Commander/BubbleUPnP controls LMS/Minimserver.

PasTim's Profile: http://forums.slimdevices.com/member.php?userid=41642
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread Michael Herger

Do you want to keep the plugin zips for unsupported plugins hosted at
the original developer site or would it make sense to store the zips on
github or similar to also handle the case when the original developer
shutdown his/her hosting server ?


KISS: why move if it's still around? :-)

--

Michael
___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread erland

PasTim wrote: 
> Given the sheer number of plugins, I wonder how many will look at this. 
> Upgrading has, in the past, usually been easy and of little concern, to
> me at least.  There might be quite a few people out there unaware that
> such issues can exist at all until they hit them.
> 
I’m sure most of them would come here and ask for help anyway and then
someone can help them troubleshoot. A list of unsupported plugins that
have been verified to work in the LMS plugins tab isn’t going to help
them anyway because the probable cause is one of the plugins that don’t
work and that will not even be in the unsupported list. Looking at
maxVersion in install.xml won’t help them since it at least for my
plugins will look like they are going to work forever since I’ve set
maxVersion to *. Looking at maxTarget in repository files might work but
that’s a significant change in LMS source code and I’d personally prefer
if that time instead was spent on implementing music related
functionality or fixing bugs in broken plugins.

PasTim wrote: 
> 
> Would the matrix be available even after upgrading, to see if some
> problem could be related to versions?
> 
It would be something separate, not a part of LMS, so it would of course
be available before, during and after an upgrade. You can look at it as
a table on a web page with a row for each available plugin and a column
for each LMS release and an x in each table cell combination that works.
Someone would still have to create such matrix (maybe you if you see a
need for it?) but what I’m saying is that it’s unnecessary that Michael
spend time on it since it’s totally separate from LMS source code.

PasTim wrote: 
> 
> Personally I always keep a back version or two of LMS anyway, and
> detailed notes on what I've done, so downgrading isn't that hard for me.
That’s good :-)



Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)

erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread PasTim

erland wrote: 
> The problem is that neither maxVersion in install.xml nor maxTarget in
> repository.xml can be reliably used for this since different plugin
> developers uses them differently. It’s also too late to get the
> information after LMS have been upgraded because there isn’t any easy
> way to go back without restoring backups and it wouldn’t solve the
> scenario when a plugin is incompatible with the new LMS version and
> doesn’t even load properly.
> 
> What you really want is a compatibility matrix which you can check
> before upgrading LMS to use as a base for the decision to upgrade LMS or
> not. A compatibility matrix could be generated based on repository files
> but as mentioned above it really has to be manually updated to be 100%
> correct since maxVersion in repository files are used differently by
> different developers. However, maybe a generated based on repository
> files are better than an outdated manually updated version. A
> compatibility matrix doesn’t have to be integrated with LMS and doesn’t
> have to be written in Perl so there is no reason for Michael to spend
> time on it, anyone in the community with development skills should be
> able to implement one. 
> 
> I think it’s time for Michael to get back to implement supported
> functionality rather than spend more time to improve stuff related to
> unsupported plugins.
Given the sheer number of plugins, I wonder how many will look at this. 
Upgrading has, in the past, usually been easy and of little concern, to
me at least.  There might be quite a few people out there unaware that
such issues can exist at all until they hit them.

Would the matrix be available even after upgrading, to see if some
problem could be related to versions?

Personally I always keep a back version or two of LMS anyway, and
detailed notes on what I've done, so downgrading isn't that hard for me.



LMS 7.9.3 on PC, Xubuntu 18.04, FLACs 16->24 bit, 44.1->192kbps.  2
Touchs & EDO.
LMS plugin UPnP/DLNA Bridge to MF M1 CLiC (A308CR amp & ESLs) & Marantz
CR603 UPnP renderers.  
Also Minimserver & Upplay to same & to upmpdcli/mpd PC renderers.  
Squeezelite to Meridian USB Explorer DAC to PC speakers/headphones.  
Wireless Xubuntu 18.04 laptop firefox/upplay or Android 'phone with
Squeeze-Commander/BubbleUPnP controls LMS/Minimserver.

PasTim's Profile: http://forums.slimdevices.com/member.php?userid=41642
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread erland


reinholdk wrote: 
> Fair point. Thought about credits only not blames. :)

Original author is also available in install.xml (unless original
developer has removed it) and will be displayed after the plugin has
been installed.



Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)

erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread erland

mherger wrote: 
> 
> I've only added TrackStat so far as a prove of concept.
> 

You should probably set minTarget to 8.0.0 to make it correct. 

I guess it doesn’t matter as long as this functionality isn’t back
ported to 7.9 but if someone tries to generate a compatibility matrix
based on the repository files it’s probably a good idea that it’s
correct.

Do you want to keep the plugin zips for unsupported plugins hosted at
the original developer site or would it make sense to store the zips on
github or similar to also handle the case when the original developer
shutdown his/her hosting server ?



Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)

erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread erland

PasTim wrote: 
> I think some form of warning/information needs to be given somewhow,
> even if just a max version recommendation on the active plugin list.

The problem is that neither maxVersion in install.xml nor maxTarget in
repository.xml can be reliably used for this since different plugin
developers uses them differently. It’s also too late to get the
information after LMS have been upgraded because there isn’t any easy
way to go back without restoring backups and it wouldn’t solve the
scenario when a plugin is incompatible with the new LMS version and
doesn’t even load properly.

What you really want is a compatibility matrix which you can check
before upgrading LMS to use as a base for the decision to upgrade LMS or
not. A compatibility matrix could be generated based on repository files
but as mentioned above it really has to be manually updated to be 100%
correct since maxVersion in repository files are used differently by
different developers. However, maybe a generated based on repository
files are better than an outdated manually updated version. A
compatibility matrix doesn’t have to be integrated with LMS and doesn’t
have to be written in Perl so there is no reason for Michael to spend
time on it, anyone in the community with development skills should be
able to implement one. 

I think it’s time for Michael to get back to implement supported
functionality rather than spend more time to improve stuff related to
unsupported plugins.



Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)

erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread reinholdk


mherger wrote: 
> > Maybe the original author(s) should still be mentioned in addition to
> > the 'Unsupported' entry.
> 
> To give credit? Erland correctly said that he wouldn't want to have to 
> answer questions from users using his plugin this way. Which is 
> perfectly reasonable. So why would he want to tell people who to get in
> 
> touch with for... ahm... nothing?
> 
> -- 
> 
> Michael

Fair point. Thought about credits only not blames. :)



reinholdk's Profile: http://forums.slimdevices.com/member.php?userid=36070
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread Michael Herger

I think this has potential. I would be happy to try it - I would like to
install it again with LMS 8.0.1.


I've pushed it to 8.1. Please give it a try.

And then let's start the discussion what to include in that list. I've 
only added TrackStat so far as a prove of concept.


--

Michael
___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread Michael Herger

Maybe the original author(s) should still be mentioned in addition to
the 'Unsupported' entry.


To give credit? Erland correctly said that he wouldn't want to have to 
answer questions from users using his plugin this way. Which is 
perfectly reasonable. So why would he want to tell people who to get in 
touch with for... ahm... nothing?


--

Michael
___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread Michael Herger

I think some form of warning/information needs to be given somewhow,
even if just a max version recommendation on the active plugin list.


The problem is what Erland outlined: he uses the maxTarget in the 
repository file, but no maxVersion in the install.xml manifest. Which 
means that once it's installed, it won't be removed, because we don't 
have any version information at that point. The plugin would become 
disabled if it had a maxVersion defined.


--

Michael
___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread PasTim


mherger wrote: 
> > With this method would a user upgrading 7.x to 8 see that an
> installed
> > plugin might not be well tested under 8?
> 
> No, this wouldn't have any impact on existing installations.
> 
> -- 
> 
> Michael
I think some form of warning/information needs to be given somewhow,
even if just a max version recommendation on the active plugin list.



LMS 7.9.3 on PC, Xubuntu 18.04, FLACs 16->24 bit, 44.1->192kbps.  2
Touchs & EDO.
LMS plugin UPnP/DLNA Bridge to MF M1 CLiC (A308CR amp & ESLs) & Marantz
CR603 UPnP renderers.  
Also Minimserver & Upplay to same & to upmpdcli/mpd PC renderers.  
Squeezelite to Meridian USB Explorer DAC to PC speakers/headphones.  
Wireless Xubuntu 18.04 laptop firefox/upplay or Android 'phone with
Squeeze-Commander/BubbleUPnP controls LMS/Minimserver.

PasTim's Profile: http://forums.slimdevices.com/member.php?userid=41642
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread reinholdk


mherger wrote: 
> Here's something I've cobbled together:
> 

Maybe the original author(s) should still be mentioned in addition to
the 'Unsupported' entry.



reinholdk's Profile: http://forums.slimdevices.com/member.php?userid=36070
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread Michael Herger

With this method would a user upgrading 7.x to 8 see that an installed
plugin might not be well tested under 8?


No, this wouldn't have any impact on existing installations.

--

Michael
___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread Shozzer


mherger wrote: 
> Here's something I've cobbled together:
> 
> 32501
> 
> The code changes are really simple: the flag would add/remove an
> "unsupported" repository file link. This file can be managed by the
> community, very much like the regular repository file.

I think this has potential. I would be happy to try it - I would like to
install it again with LMS 8.0.1.



Shozzer's Profile: http://forums.slimdevices.com/member.php?userid=58726
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread PasTim


mherger wrote: 
> 
> .So what I suggest:
> 
> - we create a repository file in the LMS-Community github org. 
> Contributors who've somewhat tested a plugin can add what they know to 
> be working to that file.
> 
> - this repository file would have a community (not author) provided 
> maxVersion. Again this is to have a minimum guaranteed compatibility.
> 
> - LMS would have a flag to include that repository or not which would 
> also be used to ignore the install.xml's maxVersion.
> 
> This would give us a minimum quality check before the uninformed user 
> can install a breaking/broken plugin easily. And it should make sure a 
> plugin does not break LMS accidentally.
> 
> At the same time this should keep LMS side changes minimal.
> 
> Thoughts?
> 
> Michael
With this method would a user upgrading 7.x to 8 see that an installed
plugin might not be well tested under 8?



LMS 7.9.3 on PC, Xubuntu 18.04, FLACs 16->24 bit, 44.1->192kbps.  2
Touchs & EDO.
LMS plugin UPnP/DLNA Bridge to MF M1 CLiC (A308CR amp & ESLs) & Marantz
CR603 UPnP renderers.  
Also Minimserver & Upplay to same & to upmpdcli/mpd PC renderers.  
Squeezelite to Meridian USB Explorer DAC to PC speakers/headphones.  
Wireless Xubuntu 18.04 laptop firefox/upplay or Android 'phone with
Squeeze-Commander/BubbleUPnP controls LMS/Minimserver.

PasTim's Profile: http://forums.slimdevices.com/member.php?userid=41642
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-12 Thread mherger


Here's something I've cobbled together:

32501

The code changes are really simple: the flag would add/remove an
"unsupported" repository file link. This file can be managed by the
community, very much like the regular repository file.


+---+
|Filename: Screenshot 2020-12-12 at 08.47.02.png|
|Download: http://forums.slimdevices.com/attachment.php?attachmentid=32501|
+---+


Michael

"It doesn't work - what shall I do?" - "Please check your server.log
and/or scanner.log file!"
(LMS: Settings/Information)

mherger's Profile: http://forums.slimdevices.com/member.php?userid=50
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread erland


mherger wrote: 
> So... what I suggest:
> 
> - we create a repository file in the LMS-Community github org. 
> Contributors who've somewhat tested a plugin can add what they know to 
> be working to that file.
> 
> - this repository file would have a community (not author) provided 
> maxVersion. Again this is to have a minimum guaranteed compatibility.
> 
> - LMS would have a flag to include that repository or not which would 
> also be used to ignore the install.xml's maxVersion.
> 
> This would give us a minimum quality check before the uninformed user 
> can install a breaking/broken plugin easily. And it should make sure a 
> plugin does not break LMS accidentally.
> 
> At the same time this should keep LMS side changes minimal.
> 
> Thoughts?
> 

Sounds good to me.

Plugins that come from this repository should probably be marked somehow
in the list of available plugins that can be installed to make it clear
to the users that they install and rely on unsupported stuff that might
stop working in future LMS releases. Basically we should make it
possible to see if a plugin is maintained/supported or only have been
tested and currently seems to work.



Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)

erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread erland


mherger wrote: 
> 
> 
> > We should encourage the community to take over
> > maintenance responsibility rather than encourage users to install
> > unsupported stuff.
> 
> That would be great indeed! It has happened with some plugins. But yours
> 
> probably are just a bit too complex for the casual contributor...
> 
My hope is that my plugins will be replaced with new smaller plugins
with the most important functionality. People using them could probably
live without some of the functionality/flexibility.

As you indicate, they probably have too large code base and complexity
to expect someone to take over maintenance of existing plugins. Possibly
someone might test them and provide them with a higher maxTarget in the
community repository file you suggested, at least on short terms until
someone has developed something new.



Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)

erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread Michael Herger

Thanks Erland! There's some excellent input in your posting!


Please note that there are two “max version” settings.


You're right, of course. I didn't think of that.


In addition to this there is the maxVersion parameter in install.xml
which is used by LMS to decide if it should load a plugin or not. In my
plugins this is set to * since I use the repository files to distribute
the right versions.


Not all plugin authors do so - which actually could become the bigger 
hurdle than the one in the repository file.



Instead of adding some complex logic to LMS my suggestion would be:
- For installed plugins: look at install.xml and if maxVersion isn’t
compatible don’t load the plugin but show it as inactive plugin or
something similar. I think this might be how LMS already is working.
- For plugins not installed: if someone in the community decides that a
plugin works and should be available on a new LMS version even if it
isn’t maintained, it’s easy for someone to provide a new repository file
with minTarget=8.0.0 and maxTarget=8.0.* with a disclaimer in the plugin
description that it isn’t supported and might break at any time. You can
also use the creator and email fields to indicate that it’s not provided
by the original developer.


We'd also have to re-package the plugins in order to fix the install.xml 
(in some cases). Which is something I'd prefer not to have to do.


But I like your idea of keeping things simple. So... what I suggest:

- we create a repository file in the LMS-Community github org. 
Contributors who've somewhat tested a plugin can add what they know to 
be working to that file.


- this repository file would have a community (not author) provided 
maxVersion. Again this is to have a minimum guaranteed compatibility.


- LMS would have a flag to include that repository or not which would 
also be used to ignore the install.xml's maxVersion.


This would give us a minimum quality check before the uninformed user 
can install a breaking/broken plugin easily. And it should make sure a 
plugin does not break LMS accidentally.


At the same time this should keep LMS side changes minimal.

Thoughts?


We should encourage the community to take over
maintenance responsibility rather than encourage users to install
unsupported stuff.


That would be great indeed! It has happened with some plugins. But yours 
probably are just a bit too complex for the casual contributor...


--

Michael
___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread Michael Herger

A more general implementation would be a LMS start up option for a
"safe" with non-LMS plugins installed.


There's the --failsafe startup parameter which should help.

--

Michael
___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread erland

Please note that there are two “max version” settings. 

There is maxTarget in the repository files which are used by LMS to show
not yet installed plugins that can be installed, I’m for example using
this to distribute multiple TrackStat versions depending which version
of LMS that’s used. Any solution in line with this thread needs to make
sure to only ignore maxTarget on the entry with highest maxTarget value,
else you are going to see three different TrackStat versions in the list
and it will be a mess.

In addition to this there is the maxVersion parameter in install.xml
which is used by LMS to decide if it should load a plugin or not. In my
plugins this is set to * since I use the repository files to distribute
the right versions.

All this means that if you want a satisfying solution for my plugins
(which is no longer maintained) the logic needs to rely on the maxTarget
flag in the repository files and not on install.xml, this might
complicate things since I’m not really sure the repository files are
used for already installed plugins today.

Instead of adding some complex logic to LMS my suggestion would be:
- For installed plugins: look at install.xml and if maxVersion isn’t
compatible don’t load the plugin but show it as inactive plugin or
something similar. I think this might be how LMS already is working.
- For plugins not installed: if someone in the community decides that a
plugin works and should be available on a new LMS version even if it
isn’t maintained, it’s easy for someone to provide a new repository file
with minTarget=8.0.0 and maxTarget=8.0.* with a disclaimer in the plugin
description that it isn’t supported and might break at any time. You can
also use the creator and email fields to indicate that it’s not provided
by the original developer.

I don’t think it makes sense to spend time to make it easier to install
and use unsupported stuff in LMS when all plugins are open source and
it’s easy for someone in the community that feels a plugin functionality
is important to take over distribution responsibility by providing a new
repository file. We should encourage the community to take over
maintenance responsibility rather than encourage users to install
unsupported stuff.

Yes, I know I’ve had similar ideas as this thread myself and posted
about it in the developers section earlier but I’ve changed my mind now
when I’ve thought a bit more about it.



Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)

erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread bpa


w3wilkes wrote: 
> but I didn't think the ICKStream trouble was LMS version dependent, I
> thought it was the plugin being installed after the service was shut
> down.
You're right but it illustrates a  plugin can mess up LMS
functionality.
It is not safe to assume a plugin installed in a version of LMS with
which it wasn't tested, will just not work. 
Users need to be made aware an unsupported plugin may crash a working
LMS system or cause it to behave badly.



bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread w3wilkes


Paul Webster wrote: 
> How about ...
> 
> Version 7.x plugins
> Completely unsupported on LMS 8.x but might work
> 

I think a plugin section like this would be fine for most users.

A little OT and maybe I misunderstood, but I didn't think the ICKStream
trouble was LMS version dependent, I thought it was the plugin being
installed after the service was shut down.



Main system - Rock Solid with LMS 7.9.4 Official on WHS 2011 - 2 Duets
and Squeeseslave
Cabin system - Rock solid with LMS 7.9.4 Official on Win10 Pro - 1 RPi 3
Model B/Hifiberry DAC+ Pro/PiCorePlayer and Squeezeslave
Test system - LMS 8.0 nightly on Win10Pro - Squeezeplay
Squeezebox Boom - "At Large" player around both home and cabin
Headphones and car - Android phone/Bluetooth w/full library on MicroSD
card - PowerAmp music player app (similar to Material Skin)

w3wilkes's Profile: http://forums.slimdevices.com/member.php?userid=22973
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread bpa


PasTim wrote: 
> It depends on the individual's attitude to such things I guess.
> 
> A bigger issue, for me at least, is that if you upgrade from 7.x to 8,
> with one or more such plugins already installed, you won't see any
> warning at all.  In such cases maybe the 'Active' Plugins list needs to
> be split into two as well (and Material Skin might need amending to show
> both 'active' lists).

Plugin Tabs currently shows the plugin version,  it could also show the
LMS version - perhaps in red if not compliant.



bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread bpa


Shozzer wrote: 
> Perhaps it would be good to add that in the event of the installation
> becoming unstable, these plugins may need to be installed as part of
> troubleshooting.
I presume you mean "uninstalled".  

Worst case scenario - the plugin prevent LMS operation so plugin cannot
be uninstalled except by editing files.

A more general implementation would be a LMS start up option for a
"safe" with non-LMS plugins installed.



bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread PasTim


bpa wrote: 
> I have a concern that these warning are a bit weak.
> 
> There have been old plugins (ickStream?) which cause problems with LMS
> operations.  
> 
> A user may not realise a plugin is old/ no longer viable but after
> installation LMS becomes unstable.
> 
> The warning should not just be "unsupported" - it need a bit more
> conviction such as "and may break LMS operations"
It depends on the individual's attitude to such things I guess.

A bigger issue, for me at least, is that if you upgrade from 7.x to 8,
with one or more such plugins already installed, you won't see any
warning at all.  In such cases maybe the 'Active' Plugins list needs to
be split into two as well (and Material Skin might need amending to show
both 'active' lists).



LMS 7.9.3 on PC, Xubuntu 18.04, FLACs 16->24 bit, 44.1->192kbps.  2
Touchs & EDO.
LMS plugin UPnP/DLNA Bridge to MF M1 CLiC (A308CR amp & ESLs) & Marantz
CR603 UPnP renderers.  
Also Minimserver & Upplay to same & to upmpdcli/mpd PC renderers.  
Squeezelite to Meridian USB Explorer DAC to PC speakers/headphones.  
Wireless Xubuntu 18.04 laptop firefox/upplay or Android 'phone with
Squeeze-Commander/BubbleUPnP controls LMS/Minimserver.

PasTim's Profile: http://forums.slimdevices.com/member.php?userid=41642
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread Shozzer


Perhaps it would be good to add that in the event of the installation
becoming unstable, these plugins may need to be installed as part of
troubleshooting.



Shozzer's Profile: http://forums.slimdevices.com/member.php?userid=58726
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread bpa


I have a concern that these warning are a bit weak.

There have been old plugins (ickStream?) which cause problems with LMS
operations.  

A user may not realise a plugin is old/ no longer viable but after
installation LMS becomes unstable.

The warning should not just be "unsupported" - it need a bit more
conviction such as "and may break LMS operations"



bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread PasTim


Something like:

Include a new list of plugins below the standard 3rd party plugins list,
entitled "WARNING - 3rd Party Plugins not guaranteed to work under LMS
8"



LMS 7.9.3 on PC, Xubuntu 18.04, FLACs 16->24 bit, 44.1->192kbps.  2
Touchs & EDO.
LMS plugin UPnP/DLNA Bridge to MF M1 CLiC (A308CR amp & ESLs) & Marantz
CR603 UPnP renderers.  
Also Minimserver & Upplay to same & to upmpdcli/mpd PC renderers.  
Squeezelite to Meridian USB Explorer DAC to PC speakers/headphones.  
Wireless Xubuntu 18.04 laptop firefox/upplay or Android 'phone with
Squeeze-Commander/BubbleUPnP controls LMS/Minimserver.

PasTim's Profile: http://forums.slimdevices.com/member.php?userid=41642
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread Paul Webster


How about ...

Version 7.x plugins
Completely unsupported on LMS 8.x but might work

Then maybe in the future we will have a 
Version 8.x plugins
Completely unsupported on LMS 9.x but might work



Paul Webster
http://dabdig.blogspot.com
author of \"now playing\" plugins covering radio france (fip etc), kcrw,
supla finland, abc australia, cbc/radio-canada and rte ireland

Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread Michael Herger

+1 to add this solution. With proper information next to switch a user
can make his own decision. Perhaps we could even maintain a list of
known LMS8.x working 7.x plugins.


Could people here please come up with a good description in good 
English? I'll take care of the German translation (oh, and the code, I 
guess...).


--

Michael
___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-11 Thread edwin2006


+1 to add this solution. With proper information next to switch a user
can make his own decision. Perhaps we could even maintain a list of
known LMS8.x working 7.x plugins.



*SqueezeBoxes:* 1x Transporter (Living room) 1x SB2 (shed), 1x Radio
(Kitchen), 1x Boom (Dining room), 1x piCorePlayer (jacuzzi), 1x
piCorePlayer (Garden) 1x OSMC + Squeezelite (Movie room), 1x Touch
(Study 2), few spare unit's
*Server:* LMS on Pi3 7.9.1. on PcP 3.21
*Network:* AVM Fritzbox, Netgear Smart Switch 24p, 3x Ubiquity

edwin2006's Profile: http://forums.slimdevices.com/member.php?userid=66926
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-10 Thread bluetdi


All my old plugins (23) are already installed and even Erlands seem to
work with 8.0.1 (Custom Scan and Trackstat for example, Auto Dim Display
also) I think with most people who are upgrading to LMS 8 its the same.
New plugins will have the correct version number anyway. And manual
install with editing the version number is known to experienced users. 

But for new installs it might be helpful, so yes, I support this
proposition.



3xPi3B-7"+pCP 6.0 | LMS 8.0.1 | Transporter | 2xTouch | 2xClassic |
2xBoom | 2xRadio | iPeng
[Discarded: 2xOdroid U3+m2p+LMS]

bluetdi's Profile: http://forums.slimdevices.com/member.php?userid=20633
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


Re: [SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-10 Thread coyrls


BosseJ wrote: 
> 
> I am sure there are many concerns with this proposal, not the least that
> it would risk exposing maintainers to support requests they have no time
> for. 
> Still, it would be interesting to hear what your thoughts are on this.
Perhaps the section heading warning could include a note that as the
plugins have not been updated, you should assume that they are
unsupported.



coyrls's Profile: http://forums.slimdevices.com/member.php?userid=44253
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter


[SlimDevices: SqueezeCenter] Installing plugins without regard to max version

2020-12-10 Thread BosseJ


(M Herger suggested I post this proposal in a separate thread. Here goes
...)
There is a parameter setting in the plugins stating the "max version"
such as "7.*" which LMS honors and refuse to install or even display in
the "3rd party plugins" list. However, they are retained when upgrading
LMS if they are already installed. It is also possible to install them
manually after editing the parameter, if they can be found and
downloaded. So far this has mostly been a matter of alerting the plugin
maintainer who after some initial testing (usually) updates the
parameter to "8.*" or similar. But some plugins are unmaintained or the
maintainer lacks the time and resources to do testing (and consequent
maintenance).

With regard to the issue of older plugins not maintained and the "max
version" parameter in these, can we not simply delegate the decision to
install these old plugins by means of a new preference setting that
controls whether the "max version" parameter is honored or not? It is
already possible to force an installation manually (after editing some
file in the module). If the default preference is "honor the module
setting" it would require a conscious (I hope) decision by the user to
override it.

Furthermore, bpa's suggestion is excellent:
> As the plugin with 7.* are not presented to an LMS 8.* installation -
> the non compliant plugins could be placed in a repository list separate
> from "3rd Party Plugins" such as - "3rd party plugins - at your peril"
Likewise mherger's caution:
> With a big red warning, well hidden at the
> bottom of the plugins page...

I am sure there are many concerns with this proposal, not the least that
it would risk exposing maintainers to support requests they have no time
for. 
Still, it would be interesting to hear what your thoughts are on this.



2 Touch, 2 Picoreplayer  v6.1.0 on RaspBerry 3B
LMS 8.0.1 on Ubuntu 20.04.1 on Intel Core2 Duo E4500 @ 2.20GHz, 2GB. All
wired
Main audio system: Magnepan 3.6, amp "Gdis 400", DAC & pre: NAD M51,
streamers: SB Touch // NAD M50

BosseJ's Profile: http://forums.slimdevices.com/member.php?userid=67378
View this thread: http://forums.slimdevices.com/showthread.php?t=113403

___
Squeezecenter mailing list
Squeezecenter@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/squeezecenter