Re: Download time issue: Squid 2.6
On Mon, 2007-03-26 at 22:35 +0200, Thomas-Martin Seck wrote: > * Alex Rousskov ([EMAIL PROTECTED]): > > > On Tue, 2007-03-20 at 21:19 +0100, Henrik Nordstrom wrote: > > > > The PRE releases is meant to serve this purpose. Just that we don't make > > > new PRE releases unless there has been significant improvements since > > > the last and that there is no known major blockers.. > > > > > > Squid-3 was known majorly broken for years, so no PRE releases was > > > made.. and currently there is at least one blocker for PRE4 but with a > > > patch pending. > > > > > > I don't think packaging PRE4 in ports when released is such a bad idea. > > > But clearly labeled as a pre-release and not a stable "supported" > > > release. > > > > I agree that it is a good idea to start tracking Squid3 PRE releases for > > FreeBSD ports (and such). Hopefully, the releases will correspond to > > major updates and will morph into a stable release in the foreseeable > > future. > > > > Also, for "hot fixes" of a PRE release, a FreeBSD port can contain > > patches. Many ports do that, of course. > > OK, my plan is to start tracking Squid 3 with PRE6. Are you OK if I > keep it up to date by pulling in all changesets up to a certain > date/changeset number (this would be roughly similar to what the FreeBSD > vim port does) if needed? "Needed" would mean as indicated by developers > on squid-users or -dev because critical issues had been fixed. Sounds like a good plan to me. I would not try to automate or even define any specific pull policy right now. Let's discuss what and how to pull when the time comes for such updates, after PRE6 is released. Thank you, Alex.
isspace etc and (int) typecast
Reviewing Squid-2.HEAD changes and sorting/grouping them a bit I stumbled over your change to add casts in various isspace() calls which looks a bit odd. http://www.squid-cache.org/Versions/v2/HEAD/changesets/11290.patch -for (; i < hmsg->req_end && (isspace(hmsg->buf[i])); i++); +for (; i < hmsg->req_end && (isspace((int) hmsg->buf[i])); i++); Generally this is not a safe cast. The ctype family of functions want the same kind of "C character" as returned by getchar etc. That's an integer carrying an unsigned char or -1. As it's a very common coding error most C libraries accept char input to these functions and might even produce correct results on high octets, but not all (some may even segfault). What was the warnings you fixed with these casts? I suspect you only silenced a valid warning here without fixing the cause.. Regards Henrik signature.asc Description: Detta är en digitalt signerad meddelandedel
Re: how i can close tcp session with client?
mån 2007-03-26 klockan 08:27 +0900 skrev [EMAIL PROTECTED]: > hello! > sorry for my english :) > I want close tcp session from access_log.c. > How? Why from access_log.c of all places? > I try do this use comm_reset_close(fd), but i get error > assert filed on commc.c:740. Yes, you can't do that there. It would be pulling the rug under the feets of the caller (client_side.c). Regards Henrik signature.asc Description: Detta är en digitalt signerad meddelandedel
Re: Download time issue: Squid 2.6
mån 2007-03-26 klockan 22:35 +0200 skrev Thomas-Martin Seck: > OK, my plan is to start tracking Squid 3 with PRE6. Are you OK if I > keep it up to date by pulling in all changesets up to a certain > date/changeset number (this would be roughly similar to what the FreeBSD > vim port does) if needed? "Needed" would mean as indicated by developers > on squid-users or -dev because critical issues had been fixed. Probably good to apply a bit of wisdom on what changesets you pull in, but generally yes it's fine. If you do please update the version number in configure.in as well to reflect the date you are at. Regards Henrik signature.asc Description: Detta är en digitalt signerad meddelandedel
Re: Download time issue: Squid 2.6
* Henrik Nordstrom ([EMAIL PROTECTED]): > tis 2007-03-20 klockan 19:40 +0100 skrev Thomas-Martin Seck: > > > Ack! Please address this, either by fixing the bugs or if this is not > > possible for whatever reason by telling users about them. I'll stick a > > big red warning sign to the port, too if needed. > > The main problem in fixing these is that there is no developers actively > working on the Squid-2 ICAP patch, just barely enough to maintain it. > Additionally the approach taken by the patch in how to hook in the data > flows is considered a bit of a dead end not encouraging it to be > actively developed much further.. Hm, sorry to hear that. I'll see whether I can integrate prominent warnings into the port. It's a pity that I cannot fix even obvious issues myself because I am not at all familiar with the Squid codebase and besides you are probably not really inclined to fix any bugs I add all by myself... > We would all love to see a stable and fully ICAP capable Squid. And at > the moment Squid-3 is the most promising for this I think. Since I received some requests for a Squid 3 port from users, I'll guess I start tracking Squid 3 with PRE6. PRE5 plus a bunch of changesets would be doable but I would rather wait for PRE6 if it's due to be put out soon.
Re: Download time issue: Squid 2.6
* Alex Rousskov ([EMAIL PROTECTED]): > On Tue, 2007-03-20 at 21:19 +0100, Henrik Nordstrom wrote: > > The PRE releases is meant to serve this purpose. Just that we don't make > > new PRE releases unless there has been significant improvements since > > the last and that there is no known major blockers.. > > > > Squid-3 was known majorly broken for years, so no PRE releases was > > made.. and currently there is at least one blocker for PRE4 but with a > > patch pending. > > > > I don't think packaging PRE4 in ports when released is such a bad idea. > > But clearly labeled as a pre-release and not a stable "supported" > > release. > > I agree that it is a good idea to start tracking Squid3 PRE releases for > FreeBSD ports (and such). Hopefully, the releases will correspond to > major updates and will morph into a stable release in the foreseeable > future. > > Also, for "hot fixes" of a PRE release, a FreeBSD port can contain > patches. Many ports do that, of course. OK, my plan is to start tracking Squid 3 with PRE6. Are you OK if I keep it up to date by pulling in all changesets up to a certain date/changeset number (this would be roughly similar to what the FreeBSD vim port does) if needed? "Needed" would mean as indicated by developers on squid-users or -dev because critical issues had been fixed.
DEBUG Section for IPAddress
I have so far not placed any permanent debug statements in the IPAddress object. It's come about time I should be making some more permanent ones and so need a section number. Is there some method I don't know yet for assigning a unique level or do I just pick an unused number and write it in? Amos
how i can close tcp session with client?
hello! sorry for my english :) I want close tcp session from access_log.c. How? I try do this use comm_reset_close(fd), but i get error assert filed on commc.c:740. squid 2.6 STABLE-4 Thanks.
