Build failed in Hudson: 3.HEAD-i386-opensolaris #398
See http://build.squid-cache.org/job/3.HEAD-i386-opensolaris/398/changes Changes: [Amos Jeffries amosjeffr...@squid-cache.org] helepr: ext_edirectory_userip_acl: add autotools code to bundle. [Amos Jeffries squ...@treenet.co.nz] Author: Stephen Thorne step...@thorne.id.au Bug 2936: NTLM-Authenticate 407 and Proxy-Connection: Close in same response. Squid default from the days of HTTP/1.0 was to close connections unless keep-alive was explicitly known. This changes the default to send keep-alive unless we have a good reason to close. -- [...truncated 3399 lines...] /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:176: error: `::wcrtomb' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:187: error: `::wcsrtombs' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:197: error: `::wctob' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:198: error: `::wmemcmp' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:199: error: `::wmemcpy' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:200: error: `::wmemmove' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:201: error: `::wmemset' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:202: error: `::wprintf' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:203: error: `::wscanf' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:223: error: `::wcsstr' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar: In function `wchar_t* std::wcsstr(wchar_t*, const wchar_t*)': /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:227: error: invalid conversion from `const wchar_t*' to `wchar_t*' /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:227: error: initializing argument 1 of `wchar_t* std::wcsstr(wchar_t*, const wchar_t*)' /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar: At global scope: /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:229: error: `::wmemchr' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar: In function `wchar_t* std::wmemchr(wchar_t*, wchar_t, size_t)': /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:233: error: invalid conversion from `const wchar_t*' to `wchar_t*' /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:233: error: initializing argument 1 of `wchar_t* std::wmemchr(wchar_t*, wchar_t, size_t)' In file included from /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/ios:46, from /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/ostream:45, from ../../../src/ip/Address.h:61, from ../../../src/squid.h:171, from ../../../src/base/AsyncCall.cc:5: /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h: In static member function `static int std::char_traitswchar_t::compare(const wchar_t*, const wchar_t*, size_t)': /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h:324: error: `wmemcmp' undeclared (first use this function) /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h:324: error: (Each undeclared identifier is reported only once for each function it appears in.) /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h: In static member function `static const wchar_t* std::char_traitswchar_t::find(const wchar_t*, size_t, const wchar_t)': /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h:332: error: invalid conversion from `const wchar_t*' to `wchar_t*' /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h:332: error: initializing argument 1 of `wchar_t* std::wmemchr(wchar_t*, wchar_t, size_t)' /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h: In static member function `static wchar_t* std::char_traitswchar_t::move(wchar_t*, const wchar_t*, size_t)': /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h:336: error: `wmemmove' undeclared (first use this function) /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h: In static member
Build failed in Hudson: 3.HEAD-i386-opensolaris #399
See http://build.squid-cache.org/job/3.HEAD-i386-opensolaris/399/changes Changes: [Amos Jeffries amosjeffr...@squid-cache.org] HTTP/1.1 compliance: Stop using Proxy-Connection header The Proxy-Connection header is not part of any HTTP standard. It was added by Netscape to differentiate persistent connections to intermediary proxies but that duty has been formally superceded by the Connection: header. This compliance update makes Squid stop sending Proxy-Connection on outbound requests. Starts consistently using Connection: header instead. The Proxy-Connection header is also ignored on HTTP-strict builds. For compatibility we must do a small violation and drop it as a hop-by-hop header despite strct-mode technically being required to pass it through. For origin server connections the non-strict builds will retain the status-quo: interpret it, but treat it as an HTTP/0.9 thing to be upgraded to HTTP/1.1 Connection:. squidclient is also fixed not to send it. [Amos Jeffries amosjeffr...@squid-cache.org] helepr: ext_edirectory_userip_acl: add autotools code to bundle. -- [...truncated 3392 lines...] /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:176: error: `::wcrtomb' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:187: error: `::wcsrtombs' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:197: error: `::wctob' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:198: error: `::wmemcmp' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:199: error: `::wmemcpy' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:200: error: `::wmemmove' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:201: error: `::wmemset' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:202: error: `::wprintf' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:203: error: `::wscanf' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:223: error: `::wcsstr' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar: In function `wchar_t* std::wcsstr(wchar_t*, const wchar_t*)': /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:227: error: invalid conversion from `const wchar_t*' to `wchar_t*' /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:227: error: initializing argument 1 of `wchar_t* std::wcsstr(wchar_t*, const wchar_t*)' /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar: At global scope: /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:229: error: `::wmemchr' has not been declared /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar: In function `wchar_t* std::wmemchr(wchar_t*, wchar_t, size_t)': /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:233: error: invalid conversion from `const wchar_t*' to `wchar_t*' /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/cwchar:233: error: initializing argument 1 of `wchar_t* std::wmemchr(wchar_t*, wchar_t, size_t)' In file included from /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/ios:46, from /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/ostream:45, from ../../../src/ip/Address.h:61, from ../../../src/squid.h:171, from ../../../src/base/AsyncCall.cc:5: /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h: In static member function `static int std::char_traitswchar_t::compare(const wchar_t*, const wchar_t*, size_t)': /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h:324: error: `wmemcmp' undeclared (first use this function) /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h:324: error: (Each undeclared identifier is reported only once for each function it appears in.) /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h: In static member function `static const wchar_t* std::char_traitswchar_t::find(const wchar_t*, size_t, const wchar_t)': /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h:332: error: invalid conversion from `const wchar_t*' to `wchar_t*' /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/../../../../include/c++/3.4.3/bits/char_traits.h:332: error:
Re: New external_acl helper squid_kerb_ldap
Markus Moeller wrote: Amos Jeffries squ...@treenet.co.nz wrote in message news:4c5187d2.5010...@treenet.co.nz... Markus Moeller wrote: Hi Amos, Hi Amos How does your time look like now ? Regards Markus Looks passable. I have not had time for a detailed view of the logics. I'll commit this tomorrow with a name tweak, the naming scheme has been through the external acl helpers too now. I'll just tack ext_ on the front and _acl on the back of the existing binary name and update the docs to match. One thing that worries me still is the RUN_IFELSE autoconf macros still being added to configure.in. I'm sure there is a macro that checked for defined values of things inside headers without running stuff. If you can try and find that it would be great not to have to run anything on build. I have 4 RUN_IFELSE. The first is to check to check that ldap works with the provided libraries. Is that unusual ? Any other suggestion how to check ? Um, okay. Thats reasonable on build. Duplicating at run-time may also be useful since the particular run-time libraries are not always the ones built against. The other three are to determine the LDAP vendor, which is a define statement in one of the ldap header files and as it is a string in a define I can not use any header grep nor proprocessor checks ( at least I do not know of any). Nasty. Oh well. Okay. Have applied to Squid-3.HEAD with the extra ext_*_acl bits on the binary name and docs for the current naming style. Amos -- Please be using Current Stable Squid 2.7.STABLE9 or 3.1.6 Beta testers wanted for 3.2.0.1
Build failed in Hudson: 3.HEAD-i386-opensolaris #400
See http://build.squid-cache.org/job/3.HEAD-i386-opensolaris/400/changes Changes: [Amos Jeffries squ...@treenet.co.nz] Author: Markus Moeller hua...@moeller.plus.com Helper: ext_kerberos_ldap_group_acl: Lookup Kerberos/NTLM group via LDAP [Amos Jeffries amosjeffr...@squid-cache.org] Fix 32-bit wrap in refresh_pattern min/max values. Attached patch limits the values to 1 year (arbitrary based on rumours about good caching times). Checking for 32-bit wrap and setting the max 1 year limit instead of cutting them to zero. The expected outcome of this is correct cache storage time extension according to refresh_pattern documentation when people desperately set min/max to a million minutes. Instead of a silent always-stale verdict. [Amos Jeffries amosjeffr...@squid-cache.org] HTTP/1.1 compliance: Stop using Proxy-Connection header The Proxy-Connection header is not part of any HTTP standard. It was added by Netscape to differentiate persistent connections to intermediary proxies but that duty has been formally superceded by the Connection: header. This compliance update makes Squid stop sending Proxy-Connection on outbound requests. Starts consistently using Connection: header instead. The Proxy-Connection header is also ignored on HTTP-strict builds. For compatibility we must do a small violation and drop it as a hop-by-hop header despite strct-mode technically being required to pass it through. For origin server connections the non-strict builds will retain the status-quo: interpret it, but treat it as an HTTP/0.9 thing to be upgraded to HTTP/1.1 Connection:. squidclient is also fixed not to send it. -- [...truncated 2612 lines...] checking for netinet/ip_fil.h... no checking for netinet/ip_icmp.h... yes checking for netinet/ipl.h... no checking for netinet/ip_nat.h... no checking for net/pf/pfvar.h... no checking for net/pfvar.h... no checking for sys/mount.h... yes checking for resolv.h... yes checking for an ANSI C-conforming const... yes checking whether byte ordering is bigendian... no checking whether struct tm is in sys/time.h or time.h... time.h checking for struct tm.tm_gmtoff... no checking for struct mallinfo... yes checking for struct mallinfo.mxfast... no checking for struct rusage... yes checking for struct iphdr.ip_hl... yes checking size of void *... 4 checking for int8_t... yes checking for uint8_t... yes checking for int16_t... yes checking for uint16_t... yes checking for int32_t... yes checking for uint32_t... yes checking for int64_t... yes checking for uint64_t... yes checking for pid_t... yes checking for size_t... yes checking for ssize_t... yes checking for off_t... yes checking for uid_t in sys/types.h... yes checking size of int64_t... 8 checking size of long... 4 checking for pad128_t... yes checking for upad128_t... yes checking for mode_t... yes checking for fd_mask... yes checking for socklen_t... yes checking for mtyp_t... no checking for working alloca.h... yes checking for alloca... yes checking sys/capability.h usability... no checking sys/capability.h presence... no checking for sys/capability.h... no checking for cap_clear_flag in -lcap... no checking for operational libcap2 headers... no configure: libcap support enabled: no configure: libcap2 headers are ok: no checking for library containing gethostbyname... -lnsl checking for library containing res_init... -lresolv checking for library containing bind... -lsocket checking for library containing opcom_stack_trace... no checking for library containing strlcpy... none required checking for library containing yp_match... none required checking for unix domain sockets... yes checking for malloc in -lgnumalloc... no checking for main in -lmalloc... yes checking for library containing rint... -lm checking for library containing log... none required checking Default FD_SETSIZE value... 1024 checking Maximum number of filedescriptors we can open... 32768 checking whether to enable IPv6... yes checking for sin6_len field in struct sockaddr_in6... no checking for ss_len field in struct sockaddr_storage... no checking for sin_len field in struct sockaddr_in... no checking for crypt in -lcrypt... yes checking for MD5Init in -lmd5... yes checking for crypt... yes checking for ldap_init in -lldap... yes checking for ber_init in -llber... no checking for ldap.h... (cached) yes checking for lber.h... (cached) yes checking mozldap/ldap.h usability... no checking mozldap/ldap.h presence... no checking for mozldap/ldap.h... no checking for LDAP_OPT_DEBUG_LEVEL... no checking for working ldap... yes checking for OpenLDAP... no checking for Sun LDAP SDK... yes checking for Mozilla LDAP SDK... no checking for LDAP_REBINDPROC_CALLBACK... yes checking for LDAP_REBIND_PROC... no checking for LDAP_REBIND_FUNCTION... no checking for LDAP_SCOPE_DEFAULT... no checking for struct ldap_url_desc.lud_scheme... no checking for ldapssl_client_init in -lldap... yes checking for ldap_url_desc2str in
Build failed in Hudson: 3.HEAD-amd64-FreeBSD-7.2 #521
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-7.2/521/changes Changes: [Amos Jeffries squ...@treenet.co.nz] Author: Markus Moeller hua...@moeller.plus.com Helper: ext_kerberos_ldap_group_acl: Lookup Kerberos/NTLM group via LDAP [Amos Jeffries amosjeffr...@squid-cache.org] Fix 32-bit wrap in refresh_pattern min/max values. Attached patch limits the values to 1 year (arbitrary based on rumours about good caching times). Checking for 32-bit wrap and setting the max 1 year limit instead of cutting them to zero. The expected outcome of this is correct cache storage time extension according to refresh_pattern documentation when people desperately set min/max to a million minutes. Instead of a silent always-stale verdict. [Amos Jeffries amosjeffr...@squid-cache.org] HTTP/1.1 compliance: Stop using Proxy-Connection header The Proxy-Connection header is not part of any HTTP standard. It was added by Netscape to differentiate persistent connections to intermediary proxies but that duty has been formally superceded by the Connection: header. This compliance update makes Squid stop sending Proxy-Connection on outbound requests. Starts consistently using Connection: header instead. The Proxy-Connection header is also ignored on HTTP-strict builds. For compatibility we must do a small violation and drop it as a hop-by-hop header despite strct-mode technically being required to pass it through. For origin server connections the non-strict builds will retain the status-quo: interpret it, but treat it as an HTTP/0.9 thing to be upgraded to HTTP/1.1 Connection:. squidclient is also fixed not to send it. -- [...truncated 1848 lines...] checking for net/pf/pfvar.h... no checking for net/pfvar.h... yes checking for sys/mount.h... yes checking for resolv.h... yes checking for an ANSI C-conforming const... yes checking whether byte ordering is bigendian... no checking whether struct tm is in sys/time.h or time.h... time.h checking for struct tm.tm_gmtoff... yes checking for struct mallinfo... no checking for struct mallinfo.mxfast... no checking for struct rusage... yes checking for struct iphdr.ip_hl... yes checking size of void *... 8 checking for int8_t... yes checking for uint8_t... yes checking for int16_t... yes checking for uint16_t... yes checking for int32_t... yes checking for uint32_t... yes checking for int64_t... yes checking for uint64_t... yes checking for pid_t... yes checking for size_t... yes checking for ssize_t... yes checking for off_t... yes checking for uid_t in sys/types.h... yes checking size of int64_t... 8 checking size of long... 8 checking for pad128_t... no checking for upad128_t... no checking for mode_t... yes checking for fd_mask... yes checking for socklen_t... yes checking for mtyp_t... no checking for working alloca.h... no checking for alloca... yes checking sys/capability.h usability... no checking sys/capability.h presence... no checking for sys/capability.h... no checking for cap_clear_flag in -lcap... no checking for operational libcap2 headers... no configure: libcap support enabled: no configure: libcap2 headers are ok: no checking for library containing gethostbyname... none required checking for library containing res_init... none required checking for library containing bind... none required checking for library containing opcom_stack_trace... no checking for library containing strlcpy... none required checking for library containing yp_match... none required checking for unix domain sockets... yes checking for malloc in -lgnumalloc... no checking for main in -lmalloc... no checking for library containing rint... -lm checking for library containing log... none required checking Default FD_SETSIZE value... 1024 checking Maximum number of filedescriptors we can open... 3520 checking whether to enable IPv6... yes checking for sin6_len field in struct sockaddr_in6... yes checking for ss_len field in struct sockaddr_storage... yes checking for sin_len field in struct sockaddr_in... yes checking for crypt in -lcrypt... yes checking for MD5Init in -lmd5... no checking for crypt... yes checking for ldap_init in -lldap... no checking for ber_init in -llber... no checking for ldap_init in -lldap60... no checking for prldap_init in -lprldap60... no checking for ldapssl_init in -lssldap60... no checking for ldap.h... (cached) no checking for lber.h... (cached) no checking mozldap/ldap.h usability... no checking mozldap/ldap.h presence... no checking for mozldap/ldap.h... no checking for LDAP_OPT_DEBUG_LEVEL... no checking for working ldap... no checking for OpenLDAP... no checking for Sun LDAP SDK... no checking for Mozilla LDAP SDK... no checking for LDAP_REBINDPROC_CALLBACK... no checking for LDAP_REBIND_PROC... no checking for LDAP_REBIND_FUNCTION... no checking for LDAP_SCOPE_DEFAULT... no checking for struct ldap_url_desc.lud_scheme... no checking for ldapssl_client_init in -lldap... no checking for ldap_url_desc2str in
Build failed in Hudson: 3.HEAD-amd64-CentOS-5.3 #735
See http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/735/changes Changes: [Amos Jeffries squ...@treenet.co.nz] Author: Markus Moeller hua...@moeller.plus.com Helper: ext_kerberos_ldap_group_acl: Lookup Kerberos/NTLM group via LDAP [Amos Jeffries amosjeffr...@squid-cache.org] Fix 32-bit wrap in refresh_pattern min/max values. Attached patch limits the values to 1 year (arbitrary based on rumours about good caching times). Checking for 32-bit wrap and setting the max 1 year limit instead of cutting them to zero. The expected outcome of this is correct cache storage time extension according to refresh_pattern documentation when people desperately set min/max to a million minutes. Instead of a silent always-stale verdict. -- [...truncated 2729 lines...] checking for net/pfvar.h... no checking for sys/mount.h... yes checking for resolv.h... yes checking for an ANSI C-conforming const... yes checking whether byte ordering is bigendian... no checking whether struct tm is in sys/time.h or time.h... time.h checking for struct tm.tm_gmtoff... yes checking for struct mallinfo... yes checking for struct mallinfo.mxfast... no checking for struct rusage... yes checking for struct iphdr.ip_hl... yes checking for void *... yes checking size of void *... 8 checking for int8_t... yes checking for uint8_t... yes checking for int16_t... yes checking for uint16_t... yes checking for int32_t... yes checking for uint32_t... yes checking for int64_t... yes checking for uint64_t... yes checking for pid_t... yes checking for size_t... yes checking for ssize_t... yes checking for off_t... yes checking for uid_t in sys/types.h... yes checking for int64_t... yes checking size of int64_t... 8 checking for long... yes checking size of long... 8 checking for pad128_t... no checking for upad128_t... no checking for mode_t... yes checking for fd_mask... yes checking for socklen_t... yes checking for mtyp_t... no checking for working alloca.h... yes checking for alloca... yes checking sys/capability.h usability... yes checking sys/capability.h presence... yes checking for sys/capability.h... yes checking for cap_clear_flag in -lcap... no checking for operational libcap2 headers... no configure: libcap support enabled: no configure: libcap2 headers are ok: no checking for library containing gethostbyname... none required checking for library containing res_init... no checking for library containing bind... none required checking for library containing opcom_stack_trace... no checking for library containing strlcpy... no checking for library containing yp_match... -lnsl checking for unix domain sockets... yes checking for malloc in -lgnumalloc... no checking for main in -lmalloc... no checking for library containing rint... -lm checking for library containing log... none required checking Default FD_SETSIZE value... 1024 checking Maximum number of filedescriptors we can open... 1024 checking whether to enable IPv6... yes checking for sin6_len field in struct sockaddr_in6... no checking for ss_len field in struct sockaddr_storage... no checking for sin_len field in struct sockaddr_in... no checking for crypt in -lcrypt... yes checking for MD5Init in -lmd5... no checking for crypt... yes checking for ldap_init in -lldap... yes checking for ber_init in -llber... yes checking for ldap.h... (cached) yes checking for lber.h... (cached) yes checking mozldap/ldap.h usability... no checking mozldap/ldap.h presence... no checking for mozldap/ldap.h... no checking for LDAP_OPT_DEBUG_LEVEL... yes checking for working ldap... yes checking for OpenLDAP... yes checking for Sun LDAP SDK... no checking for Mozilla LDAP SDK... no checking for LDAP_REBINDPROC_CALLBACK... no checking for LDAP_REBIND_PROC... yes checking for LDAP_REBIND_FUNCTION... no checking for LDAP_SCOPE_DEFAULT... yes checking for struct ldap_url_desc.lud_scheme... yes checking for ldapssl_client_init in -lldap... no checking for ldap_url_desc2str in -lldap... yes checking for ldap_url_parse in -lldap... yes checking whether dbopen is declared... yes checking if dbopen needs -ldb... yes checking for backtrace_symbols_fd... yes checking for bcopy... yes checking for bswap_16... no checking for bswap_32... no checking for bswap16... no checking for bswap32... no checking for fchmod... yes checking for getdtablesize... yes checking for getpagesize... yes checking for getpass... yes checking for getrlimit... yes checking for getrusage... yes checking for getspnam... yes checking for gettimeofday... yes checking for glob... yes checking for htobe16... no checking for htole16... no checking for kqueue... no checking for lrand48... yes checking for mallinfo... yes checking for mallocblksize... no checking for mallopt... yes checking for memcpy... yes checking for memmove... yes checking for memset... yes checking for mkstemp... yes checking for mktime... yes checking for mstats... no checking for poll... yes checking for prctl... yes
Build failed in Hudson: 3.HEAD-i386-FreeBSD-6.4 #436
See http://build.squid-cache.org/job/3.HEAD-i386-FreeBSD-6.4/436/changes
Changes:
[Amos Jeffries squ...@treenet.co.nz] Author: Markus Moeller
hua...@moeller.plus.com
Helper: ext_kerberos_ldap_group_acl: Lookup Kerberos/NTLM group via LDAP
[Amos Jeffries amosjeffr...@squid-cache.org] Fix 32-bit wrap in
refresh_pattern min/max values.
Attached patch limits the values to 1 year (arbitrary based on rumours
about good caching times). Checking for 32-bit wrap and setting the max
1 year limit instead of cutting them to zero.
The expected outcome of this is correct cache storage time extension
according to refresh_pattern documentation when people desperately set
min/max to a million minutes. Instead of a silent always-stale verdict.
[Amos Jeffries amosjeffr...@squid-cache.org] HTTP/1.1 compliance: Stop using
Proxy-Connection header
The Proxy-Connection header is not part of any HTTP standard. It was added
by Netscape to differentiate persistent connections to intermediary proxies
but that duty has been formally superceded by the Connection: header.
This compliance update makes Squid stop sending Proxy-Connection on outbound
requests. Starts consistently using Connection: header instead.
The Proxy-Connection header is also ignored on HTTP-strict builds.
For compatibility we must do a small violation and drop it as a hop-by-hop
header despite strct-mode technically being required to pass it through.
For origin server connections the non-strict builds will retain the
status-quo: interpret it, but treat it as an HTTP/0.9 thing to be
upgraded to HTTP/1.1 Connection:.
squidclient is also fixed not to send it.
--
[...truncated 134 lines...]
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for ar... /usr/bin/ar
checking for strip... strip
checking for ranlib... (cached) ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for dlfcn.h... yes
checking whether we are using the GNU C++ compiler... (cached) yes
checking whether g++ accepts -g... (cached) yes
checking dependency style of g++... (cached) gcc3
checking how to run the C++ preprocessor... g++ -E
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld) supports shared libraries... yes
checking whether -lc should be explicitly linked in... yes
checking dynamic linker characteristics... freebsd6.4 ld.so
checking how to hardcode library paths into programs... immediate
checking for shl_load... no
checking for shl_load in -ldld... no
checking for dlopen... yes
checking whether a program can dlopen itself... yes
checking whether a statically linked program can dlopen itself... no
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for ld used by g++... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld) supports shared libraries... yes
checking dynamic linker characteristics... freebsd6.4 ld.so
checking how to hardcode library paths into programs... immediate
checking which extension is used for runtime loadable modules... .so
checking which variable specifies run-time module search path... LD_LIBRARY_PATH
checking for the default library search path... /lib /usr/lib
checking for library containing dlopen... none required
checking for dlerror... yes
checking for shl_load... (cached) no
checking for shl_load in -ldld... (cached) no
checking for dld_link in -ldld... no
checking for _ prefix in compiled symbols... no
checking whether deplibs are loaded by dlopen... yes
checking for argz.h... no
checking for error_t... no
checking for argz_add... no
checking for argz_append... no
checking for argz_count... no
checking for argz_create_sep... no
checking for argz_insert... no
checking for argz_next... no
checking for argz_stringify... no
checking whether libtool supports -dlopen/-dlpreopen... yes
checking for ltdl.h... no
checking where to find libltdl headers... -I${top_srcdir}/libltdl
checking where to find libltdl library... ${top_build_prefix}libltdl/libltdlc.la
checking for unistd.h... (cached) yes
checking
Build failed in Hudson: 3.HEAD-amd64-CentOS-5.3 #736
See http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/736/changes Changes: [Amos Jeffries squ...@treenet.co.nz] Permit rotate logs from cachemgr Given that reconfigure, shutdown and offline already have password-protected remote actions available it makes sense to permit the less critical rotate as well. [Amos Jeffries squ...@treenet.co.nz] Author: Markus Moeller hua...@moeller.plus.com Helper: ext_kerberos_ldap_group_acl: Lookup Kerberos/NTLM group via LDAP -- [...truncated 2707 lines...] checking for net/pfvar.h... no checking for sys/mount.h... yes checking for resolv.h... yes checking for an ANSI C-conforming const... yes checking whether byte ordering is bigendian... no checking whether struct tm is in sys/time.h or time.h... time.h checking for struct tm.tm_gmtoff... yes checking for struct mallinfo... yes checking for struct mallinfo.mxfast... no checking for struct rusage... yes checking for struct iphdr.ip_hl... yes checking for void *... yes checking size of void *... 8 checking for int8_t... yes checking for uint8_t... yes checking for int16_t... yes checking for uint16_t... yes checking for int32_t... yes checking for uint32_t... yes checking for int64_t... yes checking for uint64_t... yes checking for pid_t... yes checking for size_t... yes checking for ssize_t... yes checking for off_t... yes checking for uid_t in sys/types.h... yes checking for int64_t... yes checking size of int64_t... 8 checking for long... yes checking size of long... 8 checking for pad128_t... no checking for upad128_t... no checking for mode_t... yes checking for fd_mask... yes checking for socklen_t... yes checking for mtyp_t... no checking for working alloca.h... yes checking for alloca... yes checking sys/capability.h usability... yes checking sys/capability.h presence... yes checking for sys/capability.h... yes checking for cap_clear_flag in -lcap... no checking for operational libcap2 headers... no configure: libcap support enabled: no configure: libcap2 headers are ok: no checking for library containing gethostbyname... none required checking for library containing res_init... no checking for library containing bind... none required checking for library containing opcom_stack_trace... no checking for library containing strlcpy... no checking for library containing yp_match... -lnsl checking for unix domain sockets... yes checking for malloc in -lgnumalloc... no checking for main in -lmalloc... no checking for library containing rint... -lm checking for library containing log... none required checking Default FD_SETSIZE value... 1024 checking Maximum number of filedescriptors we can open... 1024 checking whether to enable IPv6... yes checking for sin6_len field in struct sockaddr_in6... no checking for ss_len field in struct sockaddr_storage... no checking for sin_len field in struct sockaddr_in... no checking for crypt in -lcrypt... yes checking for MD5Init in -lmd5... no checking for crypt... yes checking for ldap_init in -lldap... yes checking for ber_init in -llber... yes checking for ldap.h... (cached) yes checking for lber.h... (cached) yes checking mozldap/ldap.h usability... no checking mozldap/ldap.h presence... no checking for mozldap/ldap.h... no checking for LDAP_OPT_DEBUG_LEVEL... yes checking for working ldap... yes checking for OpenLDAP... yes checking for Sun LDAP SDK... no checking for Mozilla LDAP SDK... no checking for LDAP_REBINDPROC_CALLBACK... no checking for LDAP_REBIND_PROC... yes checking for LDAP_REBIND_FUNCTION... no checking for LDAP_SCOPE_DEFAULT... yes checking for struct ldap_url_desc.lud_scheme... yes checking for ldapssl_client_init in -lldap... no checking for ldap_url_desc2str in -lldap... yes checking for ldap_url_parse in -lldap... yes checking whether dbopen is declared... yes checking if dbopen needs -ldb... yes checking for backtrace_symbols_fd... yes checking for bcopy... yes checking for bswap_16... no checking for bswap_32... no checking for bswap16... no checking for bswap32... no checking for fchmod... yes checking for getdtablesize... yes checking for getpagesize... yes checking for getpass... yes checking for getrlimit... yes checking for getrusage... yes checking for getspnam... yes checking for gettimeofday... yes checking for glob... yes checking for htobe16... no checking for htole16... no checking for kqueue... no checking for lrand48... yes checking for mallinfo... yes checking for mallocblksize... no checking for mallopt... yes checking for memcpy... yes checking for memmove... yes checking for memset... yes checking for mkstemp... yes checking for mktime... yes checking for mstats... no checking for poll... yes checking for prctl... yes checking for pthread_attr_setschedparam... yes checking for pthread_attr_setscope... yes checking for pthread_setschedparam... yes checking for pthread_sigmask... no checking for putenv... yes checking for random... yes checking for regcomp... yes checking for regexec... yes
Build failed in Hudson: 3.HEAD-amd64-CentOS-5.3 #737
See http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/737/changes Changes: [Amos Jeffries squ...@treenet.co.nz] dist ext_kerberos_ldap_group_acl helper [Amos Jeffries squ...@treenet.co.nz] Manual page for negotiate_kerberos_auth [Amos Jeffries squ...@treenet.co.nz] Permit rotate logs from cachemgr Given that reconfigure, shutdown and offline already have password-protected remote actions available it makes sense to permit the less critical rotate as well. -- [...truncated 1686 lines...] mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch sv.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename th.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch th.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename tr.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f
Build failed in Hudson: 3.HEAD-i386-Debian-sid #344
See http://build.squid-cache.org/job/3.HEAD-i386-Debian-sid/344/changes Changes: [Amos Jeffries squ...@treenet.co.nz] Author: Markus Moeller hua...@moeller.plus.com Helper: ext_kerberos_ldap_group_acl: Lookup Kerberos/NTLM group via LDAP [Amos Jeffries amosjeffr...@squid-cache.org] Fix 32-bit wrap in refresh_pattern min/max values. Attached patch limits the values to 1 year (arbitrary based on rumours about good caching times). Checking for 32-bit wrap and setting the max 1 year limit instead of cutting them to zero. The expected outcome of this is correct cache storage time extension according to refresh_pattern documentation when people desperately set min/max to a million minutes. Instead of a silent always-stale verdict. [Amos Jeffries amosjeffr...@squid-cache.org] HTTP/1.1 compliance: Stop using Proxy-Connection header The Proxy-Connection header is not part of any HTTP standard. It was added by Netscape to differentiate persistent connections to intermediary proxies but that duty has been formally superceded by the Connection: header. This compliance update makes Squid stop sending Proxy-Connection on outbound requests. Starts consistently using Connection: header instead. The Proxy-Connection header is also ignored on HTTP-strict builds. For compatibility we must do a small violation and drop it as a hop-by-hop header despite strct-mode technically being required to pass it through. For origin server connections the non-strict builds will retain the status-quo: interpret it, but treat it as an HTTP/0.9 thing to be upgraded to HTTP/1.1 Connection:. squidclient is also fixed not to send it. -- [...truncated 2408 lines...] checking for netinet/ip_fil_compat.h... (cached) no checking for netinet/ip_fil.h... no checking for netinet/ip_icmp.h... yes checking for netinet/ipl.h... no checking for netinet/ip_nat.h... no checking for net/pf/pfvar.h... no checking for net/pfvar.h... no checking for sys/mount.h... yes checking for resolv.h... yes checking for an ANSI C-conforming const... yes checking whether byte ordering is bigendian... no checking whether struct tm is in sys/time.h or time.h... time.h checking for struct tm.tm_gmtoff... yes checking for struct mallinfo... yes checking for struct mallinfo.mxfast... no checking for struct rusage... yes checking for struct iphdr.ip_hl... yes checking size of void *... 4 checking for int8_t... yes checking for uint8_t... yes checking for int16_t... yes checking for uint16_t... yes checking for int32_t... yes checking for uint32_t... yes checking for int64_t... yes checking for uint64_t... yes checking for pid_t... yes checking for size_t... yes checking for ssize_t... yes checking for off_t... yes checking for uid_t in sys/types.h... yes checking size of int64_t... 8 checking size of long... 4 checking for pad128_t... no checking for upad128_t... no checking for mode_t... yes checking for fd_mask... yes checking for socklen_t... yes checking for mtyp_t... no checking for working alloca.h... yes checking for alloca... yes checking sys/capability.h usability... yes checking sys/capability.h presence... yes checking for sys/capability.h... yes checking for cap_clear_flag in -lcap... yes checking for operational libcap2 headers... yes configure: libcap support enabled: yes configure: libcap2 headers are ok: yes checking for library containing gethostbyname... none required checking for library containing res_init... no checking for library containing bind... none required checking for library containing opcom_stack_trace... no checking for library containing strlcpy... no checking for library containing yp_match... -lnsl checking for unix domain sockets... yes checking for malloc in -lgnumalloc... no checking for main in -lmalloc... no checking for library containing rint... -lm checking for library containing log... none required checking Default FD_SETSIZE value... 1024 checking Maximum number of filedescriptors we can open... 1024 checking whether to enable IPv6... yes checking for sin6_len field in struct sockaddr_in6... no checking for ss_len field in struct sockaddr_storage... no checking for sin_len field in struct sockaddr_in... no checking for crypt in -lcrypt... yes checking for MD5Init in -lmd5... no checking for crypt... yes checking for ldap_init in -lldap... yes checking for ber_init in -llber... yes checking for ldap.h... (cached) yes checking for lber.h... (cached) yes checking mozldap/ldap.h usability... no checking mozldap/ldap.h presence... no checking for mozldap/ldap.h... no checking for LDAP_OPT_DEBUG_LEVEL... yes checking for working ldap... yes checking for OpenLDAP... yes checking for Sun LDAP SDK... no checking for Mozilla LDAP SDK... no checking for LDAP_REBINDPROC_CALLBACK... no checking for LDAP_REBIND_PROC... yes checking for LDAP_REBIND_FUNCTION... no checking for LDAP_SCOPE_DEFAULT... yes checking for struct ldap_url_desc.lud_scheme... yes checking for ldapssl_client_init in
Build failed in Hudson: 3.HEAD-amd64-CentOS-5.3 #738
See http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/738/changes Changes: [Francesco Chemolli kin...@squid-cache.org] autoconf-refactor fix for default hosts file option [Amos Jeffries squ...@treenet.co.nz] dist ext_kerberos_ldap_group_acl helper -- [...truncated 1684 lines...] mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch sv.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename th.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch th.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename tr.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch tr.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \
Build failed in Hudson: 3.HEAD-amd64-CentOS-5.3 #739
See http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/739/ -- [...truncated 1684 lines...] mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch sv.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename th.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch th.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename tr.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch tr.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename uk.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED
Autoconf-refactor bugs?
Hi, Firstly, I'm slightly confused as to whether I am seeing the autoconf-refactor work in my copy of trunk (I have run bzr update). I didn't think I'd seen it go in, but delving into configure.in I think it might be in there... what should I look for to check whether it's definitely what I'm looking at? Secondly, assuming it is in, there appear to be 2 small problems: 1. --disable-inline doesn't work for me. On investigation, this seems to be because enable_inline is set to yes at line 296, which overrides the later AC_ARG_ENABLE(inline), regardless of the setting. Also, I had to add in enable_inline=$enableval after the AC_ARG_ENABLE check (once I'd removed the enable_inline=yes) to get it to work. 2. Line 1344 (if $squid_host_os = solaris ; then) appears to be missing a 'test'. Sorry if I've jumped the gun and am actually looking at old code. Regards, Andy
comm_set_tos: setsockopt(IP_TOS) errors in Mac OSX 10.6.4
G'day I have compile squid for the Mac OSX 10.6.4 and is working with no issue with reguards too squid.conf setting , I run Privoxy -- Squid -- tor=internet but when I look at the cache.log it is filling up with errors. This seem too have happened on on the openbsd some time ago and never found a solution. Is there a solution to this error ? Here is some of the sample errors 2010/08/13 12:05:26| Reconfiguring Squid Cache (version 3.1.6)... 2010/08/13 12:05:26| FD 11 Closing HTTP connection 2010/08/13 12:05:26| Processing Configuration File: /usr/local/squid/etc/squid.conf (depth 0) 2010/08/13 12:05:26| WARNING: use of 'reload-into-ims' in 'refresh_pattern' violates HTTP 2010/08/13 12:05:26| Initializing https proxy context 2010/08/13 12:05:26| Squid modules loaded: 0 2010/08/13 12:05:26| Adaptation support is off. 2010/08/13 12:05:26| User-Agent logging is disabled. 2010/08/13 12:05:26| Referer logging is disabled. 2010/08/13 12:05:26| DNS Socket created at [::], FD 8 2010/08/13 12:05:26| DNS Socket created at 0.0.0.0, FD 9 2010/08/13 12:05:26| Adding domain workgroup from /etc/resolv.conf 2010/08/13 12:05:26| Adding nameserver 192.168.0.1 from /etc/resolv.conf 2010/08/13 12:05:26| Accepting HTTP connections at [::]:3128, FD 11. 2010/08/13 12:05:26| HTCP Disabled. 2010/08/13 12:05:26| Configuring Parent 127.0.0.1/8118/7 2010/08/13 12:05:26| Loaded Icons. 2010/08/13 12:05:26| Ready to serve requests. 2010/08/13 12:45:42| NETDB state saved; 0 entries, 0 msec 2010/08/13 14:03:27| NETDB state saved; 0 entries, 0 msec 2010/08/13 14:55:28| NETDB state saved; 0 entries, 0 msec 2010/08/13 16:03:00| NETDB state saved; 0 entries, 0 msec 2010/08/13 16:43:04| NETDB state saved; 0 entries, 0 msec 2010/08/13 17:43:11| Preparing for shutdown after 2734 requests 2010/08/13 17:43:11| Waiting 30 seconds for active connections to finish 2010/08/13 17:43:11| FD 11 Closing HTTP connection 2010/08/14 03:24:39| Starting Squid Cache version 3.1.6 for i686-apple-darwin10.4.0... 2010/08/14 03:24:39| Process ID 13383 2010/08/14 03:24:39| With 256 file descriptors available 2010/08/14 03:24:39| Initializing IP Cache... 2010/08/14 03:24:39| DNS Socket created at [::], FD 6 2010/08/14 03:24:39| DNS Socket created at 0.0.0.0, FD 7 2010/08/14 03:24:39| Adding domain workgroup from /etc/resolv.conf 2010/08/14 03:24:39| Adding nameserver 192.168.0.1 from /etc/resolv.conf 2010/08/14 03:24:39| User-Agent logging is disabled. 2010/08/14 03:24:39| Referer logging is disabled. 2010/08/14 03:24:39| Unlinkd pipe opened on FD 12 2010/08/14 03:24:39| Local cache digest enabled; rebuild/rewrite every 3600/3600 sec 2010/08/14 03:24:39| Swap maxSize 10264576 + 102400 KB, estimated 797459 objects 2010/08/14 03:24:39| Target number of buckets: 39872 2010/08/14 03:24:39| Using 65536 Store buckets 2010/08/14 03:24:39| Max Mem size: 102400 KB 2010/08/14 03:24:39| Max Swap size: 10264576 KB 2010/08/14 03:24:39| Version 1 of swap file without LFS support detected... 2010/08/14 03:24:39| Rebuilding storage in /usr/local/squid/var/cache (DIRTY) 2010/08/14 03:24:39| Using Least Load store dir selection 2010/08/14 03:24:39| Set Current Directory to /usr/local/squid/var/cache 2010/08/14 03:24:40| Loaded Icons. 2010/08/14 03:24:40| Accepting HTTP connections at [::]:3128, FD 19. 2010/08/14 03:24:40| HTCP Disabled. 2010/08/14 03:24:40| Configuring Parent 127.0.0.1/8118/7 2010/08/14 03:24:40| Squid modules loaded: 0 2010/08/14 03:24:40| Adaptation support is off. 2010/08/14 03:24:40| Ready to serve requests. 2010/08/14 03:24:40| Done reading /usr/local/squid/var/cache swaplog (2091 entries) 2010/08/14 03:24:40| Finished rebuilding storage from disk. 2010/08/14 03:24:40| 2054 Entries scanned 2010/08/14 03:24:40| 0 Invalid entries. 2010/08/14 03:24:40| 0 With invalid flags. 2010/08/14 03:24:40| 2022 Objects loaded. 2010/08/14 03:24:40| 0 Objects expired. 2010/08/14 03:24:40|32 Objects cancelled. 2010/08/14 03:24:40| 0 Duplicate URLs purged. 2010/08/14 03:24:40| 0 Swapfile clashes avoided. 2010/08/14 03:24:40| Took 0.10 seconds (20585.60 objects/sec). 2010/08/14 03:24:40| Beginning Validation Procedure 2010/08/14 03:24:40| Completed Validation Procedure 2010/08/14 03:24:40| Validated 4069 Entries 2010/08/14 03:24:40| store_swap_size = 32392 2010/08/14 03:24:40| storeLateRelease: released 0 objects 2010/08/14 03:25:09| Reconfiguring Squid Cache (version 3.1.6)... 2010/08/14 03:25:09| FD 19 Closing HTTP connection 2010/08/14 03:25:09| Processing Configuration File: /usr/local/squid/etc/squid.conf (depth 0) 2010/08/14 03:25:09| WARNING: use of 'reload-into-ims' in 'refresh_pattern' violates HTTP 2010/08/14 03:25:09| Initializing https proxy context 2010/08/14 03:25:09| Squid modules loaded: 0 2010/08/14 03:25:09| Adaptation support is off. 2010/08/14 03:25:09| User-Agent logging is disabled. 2010/08/14 03:25:09| Referer logging is disabled. 2010/08/14 03:25:09| DNS Socket created at [::], FD 8
Re: comm_set_tos: setsockopt(IP_TOS) errors in Mac OSX 10.6.4
Andrew, I have compile squid for the Mac OSX 10.6.4 and is working with no issue with reguards too squid.conf setting , I run Privoxy -- Squid -- tor=internet but when I look at the cache.log it is filling up with errors. This seem too have happened on on the openbsd some time ago and never found a solution. Is there a solution to this error ? Here is some of the sample errors 2010/08/14 03:31:50| comm_set_tos: setsockopt(IP_TOS) on FD 23: (22) Invalid argument 2010/08/14 03:31:50| comm_set_tos: setsockopt(IP_TOS) on FD 22: (22) Invalid argument Are you actually using the QOS functionality? If not, recompile without it (don't add --enable-zph-qos). If you are, then I saw this error when I was doing some recent development work. I think in my case it was caused by passing setsockopt invalid values. Do you have a valid value set for qos_flows in squid.conf? I'm currently rewriting a lot of the QOS functionality. If you are brave and otherwise having no luck, maybe you would like to try my latest patch. There's a recent copy in the squid-dev archives, although you will have to patch against a very recent version of the main code: http://www.squid-cache.org/mail-archive/squid-dev/201008/att-0101/netfilter-qos-20100811.patch Regards, Andy
Re: Autoconf-refactor bugs?
On Fri, Aug 13, 2010 at 11:32 PM, Andrew Beverley a...@andybev.com wrote: Hi, Firstly, I'm slightly confused as to whether I am seeing the autoconf-refactor work in my copy of trunk (I have run bzr update). I didn't think I'd seen it go in, but delving into configure.in I think it might be in there... what should I look for to check whether it's definitely what I'm looking at? It is, it was merged two days ago. And you're right, it does have a few bugs. Sorry about those. Secondly, assuming it is in, there appear to be 2 small problems: 1. --disable-inline doesn't work for me. On investigation, this seems to be because enable_inline is set to yes at line 296, which overrides the later AC_ARG_ENABLE(inline), regardless of the setting. Also, I had to add in enable_inline=$enableval after the AC_ARG_ENABLE check (once I'd removed the enable_inline=yes) to get it to work. Fixed, in a slightly different way. 2. Line 1344 (if $squid_host_os = solaris ; then) appears to be missing a 'test'. Fixed. Sorry if I've jumped the gun and am actually looking at old code. You have not, and thank you for checking things out. There is one more bug, related to the default hosts file and default http and icp ports handling. I've also fixed those. -- /kinkie
Re: Autoconf-refactor bugs?
Firstly, I'm slightly confused as to whether I am seeing the autoconf-refactor work in my copy of trunk (I have run bzr update). I didn't think I'd seen it go in, but delving into configure.in I think it might be in there... what should I look for to check whether it's definitely what I'm looking at? It is, it was merged two days ago. Ah yes, I've just realised that I misread Amos's 2 days ago as 2 days to go... And you're right, it does have a few bugs. Sorry about those. Secondly, assuming it is in, there appear to be 2 small problems: 1. --disable-inline doesn't work for me. On investigation, this seems to be because enable_inline is set to yes at line 296, which overrides the later AC_ARG_ENABLE(inline), regardless of the setting. Also, I had to add in enable_inline=$enableval after the AC_ARG_ENABLE check (once I'd removed the enable_inline=yes) to get it to work. Fixed, in a slightly different way. 2. Line 1344 (if $squid_host_os = solaris ; then) appears to be missing a 'test'. Fixed. Sorry if I've jumped the gun and am actually looking at old code. You have not, and thank you for checking things out. There is one more bug, related to the default hosts file and default http and icp ports handling. I've also fixed those. Great, thanks. I shall work on adding in the --with-netfilter-conntrack stuff :-) Unless you tell me otherwise, I plan on keeping it where I had it previously (around about line 1115 after SSL checks), but changing it as Amos said, so that it adds in the functionality if the libraries are present unless disabled. Andy
Build failed in Hudson: 3.HEAD-amd64-CentOS-5.3 #740
See http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/740/changes Changes: [Francesco Chemolli kin...@squid-cache.org] Fixes for autoconf-refactor bugs. Thanks to Andrew Beverley for spotting some of them. [Amos Jeffries squ...@treenet.co.nz] dist ext_kerberos_ldap_group_acl helper -- [...truncated 1685 lines...] mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch sv.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename th.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch th.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename tr.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch tr.lang if test != test != no test != off test -f
Re: comm_set_tos: setsockopt(IP_TOS) errors in Mac OSX 10.6.4
G'day Andrew Thanks for that , recompiling without the --enable-zph-qos solve my problem and a faster internet connect. Cheers Andrew On 14/08/10 8:10 AM, in article 1281737433.1431.261.ca...@andybev, Andrew Beverley a...@andybev.com wrote: Andrew, I have compile squid for the Mac OSX 10.6.4 and is working with no issue with reguards too squid.conf setting , I run Privoxy -- Squid -- tor=internet but when I look at the cache.log it is filling up with errors. This seem too have happened on on the openbsd some time ago and never found a solution. Is there a solution to this error ? Here is some of the sample errors 2010/08/14 03:31:50| comm_set_tos: setsockopt(IP_TOS) on FD 23: (22) Invalid argument 2010/08/14 03:31:50| comm_set_tos: setsockopt(IP_TOS) on FD 22: (22) Invalid argument Are you actually using the QOS functionality? If not, recompile without it (don't add --enable-zph-qos). If you are, then I saw this error when I was doing some recent development work. I think in my case it was caused by passing setsockopt invalid values. Do you have a valid value set for qos_flows in squid.conf? I'm currently rewriting a lot of the QOS functionality. If you are brave and otherwise having no luck, maybe you would like to try my latest patch. There's a recent copy in the squid-dev archives, although you will have to patch against a very recent version of the main code: http://www.squid-cache.org/mail-archive/squid-dev/201008/att-0101/netfilter-qo s-20100811.patch Regards, Andy
FYI: github
I've noticed a few people creating Squid2 trees using git. The problem with this is that when they do so, they get a snapshot of squid at that time. To make it easier for them to track HEAD, I've created a mirror of the squid2 source on github: http://github.com/squid-cache/squid2 This is semi-automatically updated from HEAD (and will be automatic once I get my cron jobs in order). Now, people can fork that project and more easily integrate updates. Note that it's read-only; i.e., patches won't be accepted there (although it should be easy to take patches from a forked version back to CVS). I asked on IRC if anyone minded this, and no one seemed to, but if it's a big problem I'm happy to delete the repository. Some may be interested in this visualisation (scroll to the right): http://github.com/squid-cache/squid2/graphs/impact Cheers, P.S., if any other squid-dev people are on github, we can add you to the group, FWIW, although like I said, this is read-only... -- Mark Nottingham m...@yahoo-inc.com
Re: [MERGE] Initial netfilter mark patch for comment
On 08/11/2010 03:25 PM, Andrew Beverley wrote:
I've moved these, as well as most of the other QOS functions, into
Ip::Qos. I have also removed the QosConfig namespace, as it didn't seem
to fit with all these additional functions.
* A patch preamble with the proposed commit message would be nice.
* I am not sure what Qos class is. It is not documented. If it is a QOS
configuration class, I understand why we have a global instance of it,
but the original QosConfig name seems better in that case. If it is not
a configuration class, then I am not sure why we have a global instance
of it. And the QosConfig file name does not seem to match the class name
any more.
Perhaps we need two classes, one for configuration and one for
manipulation? Or a Qos namespace with a configuration class and global
manipulation functions? The latter seems more likely.
* My understanding is that class data members and public class methods
should be documented in the header. Others should be documented in the
.cc files. You may want to double check this rule with Amos before
moving comments though.
* Many Qos data members are not documented, including new ones.
* Pass HierarchyLogEntry by const reference, avoid copying. Once that is
done, move #include HierarchyLogEntry.h to the .cc file.
* Do you need #include fde.h in src/ip/QosConfig.h or can you
pre-declare fde and include fde.h in the .cc file?
* s/ 0/ 0/
* This code:
+if (tos_local_hit || tos_sibling_hit || tos_parent_hit ||
preserve_miss_tos) {
+return true;
+} else {
+return false;
+}
can be simply written as
return tos_local_hit || tos_sibling_hit || tos_parent_hit ||
preserve_miss_tos;
Same for Ip::Qos::isMarkActive code.
* Ip::Qos::isTosActive and Ip::Qos::isMarkActive should be const. When
that is fixed, you would be able to return const to
Ip::Qos::dumpConfigLine, I guess.
* Ip::Qos::getNfmarkLocalMiss and many other get*() methods should be const.
* What is the purpose of memsetting Qos members to zero in the
destructor? Please remove the destructor itself if there is no reason to
reset the memory before freeing it.
* Use Doxygen /// comments when documenting members, such as upstreamTOS.
* Do you need an L suffix for large unsigned constants like 0x?
Please investigate. I do not know the answer, but I recall seeing such
suffixes elsewhere:
http://www.google.com/search?q=0x+vs+0xL
Thank you,
Alex.
Build failed in Hudson: 3.HEAD-amd64-CentOS-5.3 #741
See http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/741/changes Changes: [Automatic source maintenance squid...@squid-cache.org] SourceFormat Enforcement [Francesco Chemolli kin...@squid-cache.org] Fixes for autoconf-refactor bugs. Thanks to Andrew Beverley for spotting some of them. -- [...truncated 1698 lines...] mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch sv.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename th.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch th.lang if test != test != no test != off test -f ../.././test-suite/../errors/en.po; then \ lang=`basename tr.lang .lang`; \ mkdir -p ../errors/$lang; \ echo -n Translate '$lang' ...; \ for f in templates/ERR_ACCESS_DENIED templates/ERR_CACHE_ACCESS_DENIED templates/ERR_CACHE_MGR_ACCESS_DENIED templates/ERR_CANNOT_FORWARD templates/ERR_CONNECT_FAIL templates/ERR_DIR_LISTING templates/ERR_DNS_FAIL templates/ERR_ESI templates/ERR_FORWARDING_DENIED templates/ERR_FTP_DISABLED templates/ERR_FTP_FAILURE templates/ERR_FTP_FORBIDDEN templates/ERR_FTP_NOT_FOUND templates/ERR_FTP_PUT_CREATED templates/ERR_FTP_PUT_ERROR templates/ERR_FTP_PUT_MODIFIED templates/ERR_FTP_UNAVAILABLE templates/ERR_ICAP_FAILURE templates/ERR_INVALID_REQ templates/ERR_INVALID_RESP templates/ERR_INVALID_URL templates/ERR_LIFETIME_EXP templates/ERR_NO_RELAY templates/ERR_ONLY_IF_CACHED_MISS templates/ERR_READ_ERROR templates/ERR_READ_TIMEOUT templates/ERR_SECURE_CONNECT_FAIL templates/ERR_SHUTTING_DOWN templates/ERR_SOCKET_FAILURE templates/ERR_TOO_BIG templates/ERR_UNSUP_HTTPVERSION templates/ERR_UNSUP_REQ templates/ERR_URN_RESOLVE templates/ERR_WRITE_ERROR templates/ERR_ZERO_SIZE_OBJECT ; do \ page=`basename $f`; \ ` --help | grep -o \-\-notidy` --progress=none -i ../.././test-suite/../errors/$lang.po -t ../.././test-suite/../errors/$f ../errors/$lang/$page || exit 1; \ done; \ echo done.; \ fi; \ touch tr.lang if test != test != no test != off test -f
Client-side pconns and r10728
On 08/12/2010 03:37 AM, Amos Jeffries wrote:
revno: 10728
committer: Amos Jeffriessqu...@treenet.co.nz
branch nick: trunk
timestamp: Thu 2010-08-12 21:37:14 +1200
message:
Author: Stephen Thornestep...@thorne.id.au
Bug 2936: NTLM-Authenticate 407 and Proxy-Connection: Close in same response.
Squid default from the days of HTTP/1.0 was to close connections unless
keep-alive was explicitly known. This changes the default to send
keep-alive unless we have a good reason to close.
modified:
src/client_side_reply.cc
=== modified file 'src/client_side_reply.cc'
--- a/src/client_side_reply.cc 2010-07-13 14:27:25 +
+++ b/src/client_side_reply.cc 2010-08-12 09:37:14 +
@@ -1383,6 +1383,9 @@
} else if (fdUsageHigh() !request-flags.must_keepalive) {
debugs(88, 3, clientBuildReplyHeader: Not many unused FDs, can't
keep-alive);
request-flags.proxy_keepalive = 0;
+} else if (request-http_ver.major == 1 request-http_ver.minor == 1) {
+debugs(88, 3, clientBuildReplyHeader: Client is HTTP/1.1, send keep-alive,
no overriding reasons not to);
+request-flags.proxy_keepalive = 1;
}
Persistent connections have been semi-broken since 3.0, but was the
above fix discussed somewhere? I think it contradicts the overall flow
of the persistency handling code in general and clientSetKeepaliveFlag
intent/documentation in particular. I do not know whether it introduces
more bugs, but I would not be surprised if it does because the
if-statements above the new code do not enumerate all overriding reasons!
To add insult to the injury, the commit message is also misleading
because, bugs notwithstanding, Squid did send keep-alive unless we had
a good reason to close even before this change.
Can we revert the above change, please?
You may want to test the attached fix instead. I do not know whether it
helps with Bug 2936 specifically, but it does fix a bug that smells
related to those issues because Bug 2936 test script uses HTTP/1.0 messages.
Thank you,
Alex.
Supply httpMsgIsPersistent() with request version it needs to
determine client connection persistency rather than some
irrelevant information.
=== modified file 'src/client_side.cc'
--- src/client_side.cc 2010-08-07 14:22:54 +
+++ src/client_side.cc 2010-08-14 01:43:44 +
@@ -742,10 +742,7 @@
debugs(33, 3, clientSetKeepaliveFlag: method =
RequestMethodStr(request-method));
-/* We are HTTP/1.1 facing clients now*/
-HttpVersion http_ver(1,1);
-
-if (httpMsgIsPersistent(http_ver, req_hdr))
+if (httpMsgIsPersistent(request-http_ver, req_hdr))
request-flags.proxy_keepalive = 1;
}
Build failed in Hudson: 3.HEAD-amd64-CentOS-5.3 #742
See http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/742/changes Changes: [Amos Jeffries squ...@treenet.co.nz] Remove COPYING file from kerberos_ldap_group dist. [Automatic source maintenance squid...@squid-cache.org] SourceFormat Enforcement -- [...truncated 5102 lines...] ../../../../helpers/external_acl/kerberos_ldap_group/support_group.cc:55: error: invalid use of undefined type ‘struct main_args’ ../../../../helpers/external_acl/kerberos_ldap_group/support_group.cc:45: error: forward declaration of ‘struct main_args’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:77: error: invalid use of undefined type ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:63: error: forward declaration of ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/support_group.cc:58: error: ‘strlen’ was not declared in this scope ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:79: error: invalid use of undefined type ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:63: error: forward declaration of ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:80: error: invalid use of undefined type ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/support_group.cc:62: error: ‘strlen’ was not declared in this scope ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:63: error: forward declaration of ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:81: error: invalid use of undefined type ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:63: error: forward declaration of ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:83: error: invalid use of undefined type ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:63: error: forward declaration of ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:84: error: invalid use of undefined type ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:63: error: forward declaration of ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:85: error: invalid use of undefined type ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:63: error: forward declaration of ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:87: error: invalid use of undefined type ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:63: error: forward declaration of ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:88: error: invalid use of undefined type ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:63: error: forward declaration of ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:89: error: invalid use of undefined type ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:63: error: forward declaration of ‘struct gdstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/support_group.cc:79: error: ‘LogTime’ was not declared in this scope ../../../../helpers/external_acl/kerberos_ldap_group/support_group.cc:79: error: ‘PROGRAM’ was not declared in this scope ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:107: error: invalid use of undefined type ‘struct ndstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:64: error: forward declaration of ‘struct ndstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:109: error: invalid use of undefined type ‘struct ndstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:64: error: forward declaration of ‘struct ndstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:111: error: invalid use of undefined type ‘struct ndstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:64: error: forward declaration of ‘struct ndstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:112: error: invalid use of undefined type ‘struct ndstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:64: error: forward declaration of ‘struct ndstruct’ ../../../../helpers/external_acl/kerberos_ldap_group/kerberos_ldap_group.cc:113: error: invalid use of undefined type ‘struct ndstruct’
Re: Client-side pconns and r10728
Alex Rousskov wrote:
On 08/12/2010 03:37 AM, Amos Jeffries wrote:
revno: 10728
committer: Amos Jeffriessqu...@treenet.co.nz
branch nick: trunk
timestamp: Thu 2010-08-12 21:37:14 +1200
message:
Author: Stephen Thornestep...@thorne.id.au
Bug 2936: NTLM-Authenticate 407 and Proxy-Connection: Close in same
response.
Squid default from the days of HTTP/1.0 was to close connections
unless
keep-alive was explicitly known. This changes the default to send
keep-alive unless we have a good reason to close.
modified:
src/client_side_reply.cc
=== modified file 'src/client_side_reply.cc'
--- a/src/client_side_reply.cc2010-07-13 14:27:25 +
+++ b/src/client_side_reply.cc2010-08-12 09:37:14 +
@@ -1383,6 +1383,9 @@
} else if (fdUsageHigh() !request-flags.must_keepalive) {
debugs(88, 3, clientBuildReplyHeader: Not many unused FDs,
can't keep-alive);
request-flags.proxy_keepalive = 0;
+} else if (request-http_ver.major == 1
request-http_ver.minor == 1) {
+debugs(88, 3, clientBuildReplyHeader: Client is HTTP/1.1,
send keep-alive, no overriding reasons not to);
+request-flags.proxy_keepalive = 1;
}
Persistent connections have been semi-broken since 3.0, but was the
above fix discussed somewhere? I think it contradicts the overall flow
On IRC, with detailed run testing by Stephen.
of the persistency handling code in general and clientSetKeepaliveFlag
intent/documentation in particular. I do not know whether it introduces
more bugs, but I would not be surprised if it does because the
if-statements above the new code do not enumerate all overriding reasons!
To add insult to the injury, the commit message is also misleading
because, bugs notwithstanding, Squid did send keep-alive unless we had
a good reason to close even before this change.
Not true. The bug is a clear case of 407 being required, but Connection
headers not being sent *at all*.
Can we revert the above change, please?
Okay. Done for now until this is sorted out.
You may want to test the attached fix instead. I do not know whether it
helps with Bug 2936 specifically, but it does fix a bug that smells
related to those issues because Bug 2936 test script uses HTTP/1.0
messages.
The extended tests on IRC used 1.1 as well. I think via the
force_http1p1 patch you provided.
Bug 2936 results from the *client* closing the connection in the absence
of keep-alive. It hits worst in 3.1 where we send HTTP/1.0 to the client
and don't specify keep-alive explicitly.
The new patch looks logically right. This is a clean section 8.1.3
clause 3 violation fix by the looks of it.
* Please add a reference to RFC 2616 section 8.1.3 clause 3 for the if
statement. ie MAY keep-alive to 1.1 clients, MUST NOT keep-alive
default to 1.0 clients..
The particular point being that it's based on the client version. Not
Squid like we currently have.
- Its not relevant on httpMsgIsPersistent() documentation due to that
function applying to both server and client conn.
NP: 3.2 and 3.HEAD still contain the 1.1 advertisement to clients. It's
only gone from the stable release while pending the non-buffered client
request de-chunking you scheduled for 3.2. Is the timeline still at the
end-August on that?
Amos
--
Please be using
Current Stable Squid 2.7.STABLE9 or 3.1.6
Beta testers wanted for 3.2.0.1
Re: [MERGE] Initial netfilter mark patch for comment
Alex Rousskov wrote:
On 08/11/2010 03:25 PM, Andrew Beverley wrote:
I've moved these, as well as most of the other QOS functions, into
Ip::Qos. I have also removed the QosConfig namespace, as it didn't seem
to fit with all these additional functions.
* A patch preamble with the proposed commit message would be nice.
* I am not sure what Qos class is. It is not documented. If it is a QOS
configuration class, I understand why we have a global instance of it,
but the original QosConfig name seems better in that case. If it is not
a configuration class, then I am not sure why we have a global instance
of it. And the QosConfig file name does not seem to match the class name
any more.
Perhaps we need two classes, one for configuration and one for
manipulation? Or a Qos namespace with a configuration class and global
manipulation functions? The latter seems more likely.
* My understanding is that class data members and public class methods
should be documented in the header. Others should be documented in the
.cc files. You may want to double check this rule with Amos before
moving comments though.
true.
* Many Qos data members are not documented, including new ones.
* Pass HierarchyLogEntry by const reference, avoid copying. Once that is
done, move #include HierarchyLogEntry.h to the .cc file.
* Do you need #include fde.h in src/ip/QosConfig.h or can you
pre-declare fde and include fde.h in the .cc file?
* s/ 0/ 0/
* This code:
+if (tos_local_hit || tos_sibling_hit || tos_parent_hit ||
preserve_miss_tos) {
+return true;
+} else {
+return false;
+}
can be simply written as
return tos_local_hit || tos_sibling_hit || tos_parent_hit ||
preserve_miss_tos;
Same for Ip::Qos::isMarkActive code.
NP: with () brackets for easier reading of the compound statement please.
* Ip::Qos::isTosActive and Ip::Qos::isMarkActive should be const. When
that is fixed, you would be able to return const to
Ip::Qos::dumpConfigLine, I guess.
* Ip::Qos::getNfmarkLocalMiss and many other get*() methods should be
const.
* What is the purpose of memsetting Qos members to zero in the
destructor? Please remove the destructor itself if there is no reason to
reset the memory before freeing it.
* Use Doxygen /// comments when documenting members, such as upstreamTOS.
* Do you need an L suffix for large unsigned constants like 0x?
Please investigate. I do not know the answer, but I recall seeing such
suffixes elsewhere:
http://www.google.com/search?q=0x+vs+0xL
I thought that indicated long type to be used. When stored as 64-bit
values.
Which brings up a question of whether it really is an architecture
dependent int field or uint32_t for mark.
Amos
--
Please be using
Current Stable Squid 2.7.STABLE9 or 3.1.6
Beta testers wanted for 3.2.0.1
Re: Autoconf-refactor bugs?
Hi! Unless you tell me otherwise, I plan on keeping it where I had it previously (around about line 1115 after SSL checks), but changing it as Amos said, so that it adds in the functionality if the libraries are present unless disabled. Unless there is a reason, I'd suggest to leave it close to the other netfilter stuff (option handling @1250, if there's dependencies to manage those can be handled @3030.. The general behaviour of configure options should be default auto (which means enable if all pieces are available), can be force-enabled or force-disabled. If it is force-enabled and some library is missing, fail the build Thanks! -- /kinkie
