[SSSD] [sssd PR#904][comment] KCM: Set kdc_offset to zero initially
URL: https://github.com/SSSD/sssd/pull/904 Title: #904: KCM: Set kdc_offset to zero initially mzidek-rh commented: """ I was one of the reviewers of the original patch, so I got another look at it and I think that setting the kdc_offset to INT32_MAX was a mistake that we did not catch. FWIW this patch LGTM. But I would also like to hear what @frozencemetery thinks. """ See the full comment at https://github.com/SSSD/sssd/pull/904#issuecomment-542897369 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][comment] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902 Title: #902: Added ERROR and PRINT macros to the tools alexal commented: """ @mzidek-rh I've made that change. """ See the full comment at https://github.com/SSSD/sssd/pull/902#issuecomment-542892288 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][synchronized] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902
Author: alexal
Title: #902: Added ERROR and PRINT macros to the tools
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/902/head:pr902
git checkout pr902
From beb86337fc681730e9c0ff5479e60f4dbe1095f8 Mon Sep 17 00:00:00 2001
From: Alex Rodin
Date: Wed, 16 Oct 2019 17:03:03 -0400
Subject: [PATCH] Added ERROR and PRINT macros to the tools
Tools: Added ERROR and PRINT macros to the tools
Replaced functions printf and fprintf with corresponding PRINT and ERROR macro in the tools.
Resolves: https://pagure.io/SSSD/sssd/issue/3078
---
src/tools/common/sss_tools.c| 20 +++
src/tools/sss_groupshow.c | 14 ++---
src/tools/sss_override.c| 44
src/tools/sss_seed.c| 8 +--
src/tools/sssctl/sssctl.c | 10 ++--
src/tools/sssctl/sssctl_access_report.c | 4 +-
src/tools/sssctl/sssctl_cache.c | 10 ++--
src/tools/sssctl/sssctl_cert.c | 2 +-
src/tools/sssctl/sssctl_config.c| 12 ++---
src/tools/sssctl/sssctl_data.c | 24 -
src/tools/sssctl/sssctl_domains.c | 18 +++
src/tools/sssctl/sssctl_logs.c | 14 ++---
src/tools/sssctl/sssctl_systemd.c | 2 +-
src/tools/sssctl/sssctl_user_checks.c | 70 -
14 files changed, 122 insertions(+), 130 deletions(-)
diff --git a/src/tools/common/sss_tools.c b/src/tools/common/sss_tools.c
index 0d918f164e..bcbbafe4c2 100644
--- a/src/tools/common/sss_tools.c
+++ b/src/tools/common/sss_tools.c
@@ -32,7 +32,7 @@
static void sss_tool_print_common_opts(int min_len)
{
-fprintf(stderr, _("Help options:\n"));
+ERROR("Help options:\n");
fprintf(stderr, " %-*s\t %s\n", min_len, "-?, --help",
_("Show this for a command"));
fprintf(stderr, " %-*s\t %s\n", min_len, "--usage",
@@ -241,8 +241,8 @@ void sss_tool_usage(const char *tool_name, struct sss_route_cmd *commands)
int min_len;
int i;
-fprintf(stderr, _("Usage:\n%s COMMAND COMMAND-ARGS\n\n"), tool_name);
-fprintf(stderr, _("Available commands:\n"));
+ERROR("Usage:\n%s COMMAND COMMAND-ARGS\n\n", tool_name);
+ERROR("Available commands:\n");
min_len = sss_tool_max_length(commands);
@@ -260,7 +260,7 @@ void sss_tool_usage(const char *tool_name, struct sss_route_cmd *commands)
}
}
-fprintf(stderr, _("\n"));
+ERROR("\n");
sss_tool_print_common_opts(min_len);
}
@@ -433,8 +433,8 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
goto done;
}
} else {
-fprintf(stderr, _("Invalid option %s: %s\n\n"),
-poptBadOption(pc, 0), poptStrerror(ret));
+ERROR("Invalid option %s: %s\n\n",
+ poptBadOption(pc, 0), poptStrerror(ret));
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -445,7 +445,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
fopt = poptGetArg(pc);
if (_fopt != NULL) {
if (fopt == NULL) {
-fprintf(stderr, _("Missing option: %s\n\n"), fopt_help);
+ERROR("Missing option: %s\n\n", fopt_help);
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -453,7 +453,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
/* No more arguments expected. If something follows it is an error. */
if (poptGetArg(pc)) {
-fprintf(stderr, _("Only one free argument is expected!\n\n"));
+ERROR("Only one free argument is expected!\n\n");
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -462,7 +462,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
*_fopt = fopt;
} else if (_fopt == NULL && fopt != NULL) {
/* Unexpected free argument. */
-fprintf(stderr, _("Unexpected parameter: %s\n\n"), fopt);
+ERROR("Unexpected parameter: %s\n\n", fopt);
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -474,7 +474,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
/* If at least one option is required and not provided, print error. */
if (require_option == SSS_TOOL_OPT_REQUIRED) {
-fprintf(stderr, _("At least one option is required!\n\n"));
+ERROR("At least one option is required!\n\n");
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
diff --git a/src/tools/sss_groupshow.c b/src/tools/sss_groupshow.c
index ac4c3dc912..7b0fbe1177 100644
--- a/src/tools/sss_groupshow.c
+++ b/src/tools/sss_groupshow.c
@@ -612,26 +612,26 @@ static void print_group_info(struct group_info *g, unsigned level)
snprintf(fmt, 8, "%%%ds", level*PADDING_SPACES);
snprintf(p
[SSSD] [sssd PR#902][comment] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902
Title: #902: Added ERROR and PRINT macros to the tools
mzidek-rh commented:
"""
@alexal I found one more indentation nitpick, I did not notice this the first
time. The string below should be aligned with the string above:
```
diff --git a/src/tools/sssctl/sssctl_config.c b/src/tools/sssctl/sssctl_config.c
index 7b324db21..4852e2216 100644
--- a/src/tools/sssctl/sssctl_config.c
+++ b/src/tools/sssctl/sssctl_config.c
@@ -79,7 +79,7 @@ errno_t sssctl_config_check(struct sss_cmdline *cmdline,
ret = sss_ini_config_access_check(init_data);
if (ret != EOK) {
PRINT("File ownership and permissions check failed. "
- "Expected root:root and 0600.\n");
+ "Expected root:root and 0600.\n");
ret = EPERM;
goto done;
}
```
Other than that it looks good.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/902#issuecomment-542884702
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#904][comment] KCM: Set kdc_offset to zero initially
URL: https://github.com/SSSD/sssd/pull/904 Title: #904: KCM: Set kdc_offset to zero initially jhrozek commented: """ @frozencemetery Do you have an opinion about this one way or the other? This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1757224 """ See the full comment at https://github.com/SSSD/sssd/pull/904#issuecomment-542875335 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#904][opened] KCM: Set kdc_offset to zero initially
URL: https://github.com/SSSD/sssd/pull/904 Author: jhrozek Title: #904: KCM: Set kdc_offset to zero initially Action: opened PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/4100 KCM assumed that the client library would always set the KDC offset, but that's not always the case, especially when using multiple krb contexts from the client application: https://bugzilla.redhat.com/show_bug.cgi?id=1757224#c64 Heimdal also creates ccaches with zero kdc_offset: https://github.com/heimdal/heimdal/commit/9f58896af958ae5e6e3ebde8c48dad4eda841986 so we should do the same.. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/904/head:pr904 git checkout pr904 From 8b20ea96054165167e4cf53b5a838b11f590bc32 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 11 Oct 2019 09:20:20 +0200 Subject: [PATCH] KCM: Set kdc_offset to zero initially Resolves: https://pagure.io/SSSD/sssd/issue/4100 KCM assumed that the client library would always set the KDC offset, but that's not always the case, especially when using multiple krb contexts from the client application: https://bugzilla.redhat.com/show_bug.cgi?id=1757224#c64 Heimdal also creates ccaches with zero kdc_offset: https://github.com/heimdal/heimdal/commit/9f58896af958ae5e6e3ebde8c48dad4eda841986 so we should do the same.. --- src/responder/kcm/kcmsrv_ccache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/responder/kcm/kcmsrv_ccache.c b/src/responder/kcm/kcmsrv_ccache.c index e24da9aa25..66e2752ba7 100644 --- a/src/responder/kcm/kcmsrv_ccache.c +++ b/src/responder/kcm/kcmsrv_ccache.c @@ -82,7 +82,7 @@ errno_t kcm_cc_new(TALLOC_CTX *mem_ctx, cc->owner.uid = cli_creds_get_uid(owner); cc->owner.gid = cli_creds_get_gid(owner); -cc->kdc_offset = INT32_MAX; +cc->kdc_offset = 0; talloc_set_destructor(cc, kcm_cc_destructor); *_cc = cc; ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#903][comment] Gpo man page updates
URL: https://github.com/SSSD/sssd/pull/903 Title: #903: Gpo man page updates mzidek-rh commented: """ @sumit-bose Could you please review the second patch? I am asking you because we already had a brief discussion about the issue. """ See the full comment at https://github.com/SSSD/sssd/pull/903#issuecomment-542833282 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#903][opened] Gpo man page updates
URL: https://github.com/SSSD/sssd/pull/903 Author: mzidek-rh Title: #903: Gpo man page updates Action: opened PR body: """ Hi, this PR contains two patches. One is from another PR (already acked by me and does not need a review, I just have it here to avoid conflicts and want to finally push it. It is from our probably oldest PR, that is still not merged https://pagure.io/SSSD/sssd/pull-request/3320). I will try to merge the patches from that PR together with some other GPO patches, but this PR is just about the man page changes. The second patch adds a note to the man page that current version of GPO does not support built-in groups in AD. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/903/head:pr903 git checkout pr903 From c6c8b9fd637196461e2e2191b0d30cd22ae84c82 Mon Sep 17 00:00:00 2001 From: REIM THOMAS Date: Sun, 5 Mar 2017 13:04:41 +0100 Subject: [PATCH 1/2] MAN: Provide minimum information on GPO access control MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update sssd-ad man page to give administrators the minimum required information how SSSD performs GPO based access control. Also added a hint how to configure logging to get sufficient GPO troubleshooting information by examining the logs. Resolves: https://pagure.io/SSSD/sssd/issue/3324 Signed-off-by: REIM THOMAS Reviewed-by: Michal Židek --- src/man/sssd-ad.5.xml | 109 -- 1 file changed, 106 insertions(+), 3 deletions(-) diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml index 5c51e80509..0b1dc12273 100644 --- a/src/man/sssd-ad.5.xml +++ b/src/man/sssd-ad.5.xml @@ -358,8 +358,44 @@ DOM:dom1:(memberOf:1.2.840.113556.1.4.1941:=cn=nestedgroup,ou=groups,dc=example, GPO-based access control functionality uses GPO policy settings to determine whether or not a -particular user is allowed to logon to a particular -host. +particular user is allowed to logon to the host. +For more information on the supported policy +settings please refer to the +ad_gpo_map options. + + +Before performing access control SSSD applies group +policy security filtering on the GPOs. For every +single user login, the applicability of the GPOs +that are linked to the host is checked. In order for +a GPO to apply to a user, the user or at least one +of the groups to which it belongs must have +following permissions on the GPO: + + + +Read: The user or one of its groups must +have read access to the properties of the +GPO (RIGHT_DS_READ_PROPERTY) + + + + +Apply Group Policy: The user or at least +one of its groups must be allowed to +apply the GPO (RIGHT_DS_CONTROL_ACCESS). + + + + + +By default, the Authenticated Users group is present +on a GPO and this group has both Read and Apply Group +Policy access rights. Since authentication of a user +must have been completed successfully before GPO +security filtering and access control are started, +the Authenticated Users group permissions on the GPO +always apply also to the user. NOTE: The current version of SSSD does not support @@ -379,7 +415,13 @@ DOM:dom1:(memberOf:1.2.840.113556.1.4.1941:=cn=nestedgroup,ou=groups,dc=example, will output a syslog message if access would have been denied. By examining the logs, administrators can then make the necessary changes before setting -the mode to enforcing. +the mode to enforcing. For logging GPO-based access +
[SSSD] [sssd PR#899][comment] sss_ptr_hash: pass new hash_entry_t to custom delete callback
URL: https://github.com/SSSD/sssd/pull/899 Title: #899: sss_ptr_hash: pass new hash_entry_t to custom delete callback mzidek-rh commented: """ @pbrezina Should the reproducer be deterministic? I can not see the messages in debug logs after calling "id Administrator". Am I missing something? """ See the full comment at https://github.com/SSSD/sssd/pull/899#issuecomment-542809403 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][comment] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902 Title: #902: Added ERROR and PRINT macros to the tools alexal commented: """ @mzidek-rh , thanks. Looks better now? """ See the full comment at https://github.com/SSSD/sssd/pull/902#issuecomment-542795164 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][synchronized] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902
Author: alexal
Title: #902: Added ERROR and PRINT macros to the tools
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/902/head:pr902
git checkout pr902
From c5026f1793bcd32087ea88270dfd3a82629ec8a8 Mon Sep 17 00:00:00 2001
From: Alex Rodin
Date: Wed, 16 Oct 2019 12:54:24 -0400
Subject: [PATCH] Added ERROR and PRINT macros to the tools
Tools: Added ERROR and PRINT macros to the tools
Replaced functions printf and fprintf with corresponding PRINT and ERROR macro in the tools.
Resolves: https://pagure.io/SSSD/sssd/issue/3078
---
src/tools/common/sss_tools.c| 20 +++
src/tools/sss_groupshow.c | 14 ++---
src/tools/sss_override.c| 44
src/tools/sss_seed.c| 8 +--
src/tools/sssctl/sssctl.c | 10 ++--
src/tools/sssctl/sssctl_access_report.c | 4 +-
src/tools/sssctl/sssctl_cache.c | 10 ++--
src/tools/sssctl/sssctl_cert.c | 2 +-
src/tools/sssctl/sssctl_config.c| 12 ++---
src/tools/sssctl/sssctl_data.c | 24 -
src/tools/sssctl/sssctl_domains.c | 18 +++
src/tools/sssctl/sssctl_logs.c | 14 ++---
src/tools/sssctl/sssctl_systemd.c | 2 +-
src/tools/sssctl/sssctl_user_checks.c | 70 -
14 files changed, 122 insertions(+), 130 deletions(-)
diff --git a/src/tools/common/sss_tools.c b/src/tools/common/sss_tools.c
index 0d918f164e..bcbbafe4c2 100644
--- a/src/tools/common/sss_tools.c
+++ b/src/tools/common/sss_tools.c
@@ -32,7 +32,7 @@
static void sss_tool_print_common_opts(int min_len)
{
-fprintf(stderr, _("Help options:\n"));
+ERROR("Help options:\n");
fprintf(stderr, " %-*s\t %s\n", min_len, "-?, --help",
_("Show this for a command"));
fprintf(stderr, " %-*s\t %s\n", min_len, "--usage",
@@ -241,8 +241,8 @@ void sss_tool_usage(const char *tool_name, struct sss_route_cmd *commands)
int min_len;
int i;
-fprintf(stderr, _("Usage:\n%s COMMAND COMMAND-ARGS\n\n"), tool_name);
-fprintf(stderr, _("Available commands:\n"));
+ERROR("Usage:\n%s COMMAND COMMAND-ARGS\n\n", tool_name);
+ERROR("Available commands:\n");
min_len = sss_tool_max_length(commands);
@@ -260,7 +260,7 @@ void sss_tool_usage(const char *tool_name, struct sss_route_cmd *commands)
}
}
-fprintf(stderr, _("\n"));
+ERROR("\n");
sss_tool_print_common_opts(min_len);
}
@@ -433,8 +433,8 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
goto done;
}
} else {
-fprintf(stderr, _("Invalid option %s: %s\n\n"),
-poptBadOption(pc, 0), poptStrerror(ret));
+ERROR("Invalid option %s: %s\n\n",
+ poptBadOption(pc, 0), poptStrerror(ret));
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -445,7 +445,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
fopt = poptGetArg(pc);
if (_fopt != NULL) {
if (fopt == NULL) {
-fprintf(stderr, _("Missing option: %s\n\n"), fopt_help);
+ERROR("Missing option: %s\n\n", fopt_help);
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -453,7 +453,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
/* No more arguments expected. If something follows it is an error. */
if (poptGetArg(pc)) {
-fprintf(stderr, _("Only one free argument is expected!\n\n"));
+ERROR("Only one free argument is expected!\n\n");
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -462,7 +462,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
*_fopt = fopt;
} else if (_fopt == NULL && fopt != NULL) {
/* Unexpected free argument. */
-fprintf(stderr, _("Unexpected parameter: %s\n\n"), fopt);
+ERROR("Unexpected parameter: %s\n\n", fopt);
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -474,7 +474,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
/* If at least one option is required and not provided, print error. */
if (require_option == SSS_TOOL_OPT_REQUIRED) {
-fprintf(stderr, _("At least one option is required!\n\n"));
+ERROR("At least one option is required!\n\n");
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
diff --git a/src/tools/sss_groupshow.c b/src/tools/sss_groupshow.c
index ac4c3dc912..7b0fbe1177 100644
--- a/src/tools/sss_groupshow.c
+++ b/src/tools/sss_groupshow.c
@@ -612,26 +612,26 @@ static void print_group_info(struct group_info *g, unsigned level)
snprintf(fmt, 8, "%%%ds", level*PADDING_SPACES);
snprintf(p
[SSSD] [sssd PR#902][comment] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902
Title: #902: Added ERROR and PRINT macros to the tools
mzidek-rh commented:
"""
@alexal There are some coding style issues, see the following patch (you can
merge this patch with your patch):
```
From 754ca3888070b63cad5d79fab021c652ac57ff2c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C5=BDidek?=
Date: Wed, 16 Oct 2019 17:28:32 +0200
Subject: [PATCH] Coding style issues
Merge this patch with the main patch
---
src/tools/sss_groupshow.c | 4 ++--
src/tools/sss_override.c| 8
src/tools/sss_seed.c| 2 +-
src/tools/sssctl/sssctl_cache.c | 4 ++--
src/tools/sssctl/sssctl_data.c | 2 +-
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/tools/sss_groupshow.c b/src/tools/sss_groupshow.c
index c932b5958..7b0fbe117 100644
--- a/src/tools/sss_groupshow.c
+++ b/src/tools/sss_groupshow.c
@@ -613,8 +613,8 @@ static void print_group_info(struct group_info *g, unsigned
level)
snprintf(padding, 512, fmt, "");
PRINT("%1$s%2$sGroup: %3$s\n", padding,
- g->mpg ? _("Magic Private ") : "",
- g->name);
+ g->mpg ? _("Magic Private ") : "",
+ g->name);
PRINT("%1$sGID number: %2$d\n", padding, g->gid);
PRINT("%1$sMember users: ", padding);
diff --git a/src/tools/sss_override.c b/src/tools/sss_override.c
index 866ad7f77..9b408a353 100644
--- a/src/tools/sss_override.c
+++ b/src/tools/sss_override.c
@@ -268,10 +268,10 @@ errno_t prepare_view_msg(struct sss_domain_info *domain)
ret = prepare_view(domain);
if (ret == EEXIST) {
ERROR("Other than " LOCALVIEW " view already exists "
- "in domain %s.\n", domain->name);
+ "in domain %s.\n", domain->name);
} else if (ret != EOK) {
ERROR("Unable to prepare " LOCALVIEW
-" view in domain %s.\n", domain->name);
+ " view in domain %s.\n", domain->name);
}
return ret;
@@ -1292,7 +1292,7 @@ static errno_t user_export(const char *filename,
db = sss_colondb_open(tmp_ctx, SSS_COLONDB_WRITE, filename);
if (db == NULL) {
ERROR("Unable to open %s.\n",
-filename == NULL ? "stdout" : filename);
+ filename == NULL ? "stdout" : filename);
ret = EIO;
goto done;
}
@@ -1362,7 +1362,7 @@ static errno_t group_export(const char *filename,
db = sss_colondb_open(tmp_ctx, SSS_COLONDB_WRITE, filename);
if (db == NULL) {
ERROR("Unable to open %s.\n",
-filename == NULL ? "stdout" : filename);
+ filename == NULL ? "stdout" : filename);
ret = EIO;
goto done;
}
diff --git a/src/tools/sss_seed.c b/src/tools/sss_seed.c
index 8693d86a3..91bfb4cf8 100644
--- a/src/tools/sss_seed.c
+++ b/src/tools/sss_seed.c
@@ -874,7 +874,7 @@ int main(int argc, const char **argv)
PRINT("User cache entry created for %1$s\n", sctx->uctx->name);
}
PRINT("Temporary password added to cache entry for %1$s\n",
-sctx->uctx->name);
+ sctx->uctx->name);
}
done:
diff --git a/src/tools/sssctl/sssctl_cache.c b/src/tools/sssctl/sssctl_cache.c
index 3932dc758..421e817b1 100644
--- a/src/tools/sssctl/sssctl_cache.c
+++ b/src/tools/sssctl/sssctl_cache.c
@@ -520,7 +520,7 @@ static errno_t sssctl_print_object(struct
sssctl_object_info *info,
goto done;
} else if (ret != EOK) {
ERROR("Error: Unable to get object [%d]: %s\n",
-ret, sss_strerror(ret));
+ ret, sss_strerror(ret));
goto done;
}
@@ -536,7 +536,7 @@ static errno_t sssctl_print_object(struct
sssctl_object_info *info,
continue;
} else if (ret != EOK) {
ERROR("%s: Unable to read value [%d]: %s\n",
-info[i].msg, ret, sss_strerror(ret));
+ info[i].msg, ret, sss_strerror(ret));
continue;
}
diff --git a/src/tools/sssctl/sssctl_data.c b/src/tools/sssctl/sssctl_data.c
index 733037fbb..8d79b977f 100644
--- a/src/tools/sssctl/sssctl_data.c
+++ b/src/tools/sssctl/sssctl_data.c
@@ -87,7 +87,7 @@ static errno_t sssctl_backup(bool force)
ret = sssctl_create_backup_dir(SSS_BACKUP_DIR);
if (ret != EOK) {
ERROR("Unable to create backup directory [%d]: %s",
-ret, sss_strerror(ret));
+ ret, sss_strerror(ret));
return ret;
}
--
2.20.1
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/902#issuecomment-542761421
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidel
[SSSD] [sssd PR#901][+Accepted] Update sss_ssh.c
URL: https://github.com/SSSD/sssd/pull/901 Title: #901: Update sss_ssh.c Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#901][comment] Update sss_ssh.c
URL: https://github.com/SSSD/sssd/pull/901 Title: #901: Update sss_ssh.c mzidek-rh commented: """ ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/901#issuecomment-542743625 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][comment] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902 Title: #902: Added ERROR and PRINT macros to the tools alexal commented: """ @mzidek-rh done. Please check the code and let me know if something needs to be changed. """ See the full comment at https://github.com/SSSD/sssd/pull/902#issuecomment-542703875 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][synchronized] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902
Author: alexal
Title: #902: Added ERROR and PRINT macros to the tools
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/902/head:pr902
git checkout pr902
From 6ca19d5c1b38975004c4fdf5b569b2e096d7dc9a Mon Sep 17 00:00:00 2001
From: Alex Rodin
Date: Wed, 16 Oct 2019 09:29:35 -0400
Subject: [PATCH] Added ERROR and PRINT macros to the tools
Tools: Added ERROR and PRINT macros to the tools
Replaced functions printf and fprintf with corresponding PRINT and ERROR macro in the tools.
Resolves: https://pagure.io/SSSD/sssd/issue/3078
---
src/tools/common/sss_tools.c| 20 +++
src/tools/sss_groupshow.c | 10 ++--
src/tools/sss_override.c| 42 +++
src/tools/sss_seed.c| 8 +--
src/tools/sssctl/sssctl.c | 10 ++--
src/tools/sssctl/sssctl_access_report.c | 4 +-
src/tools/sssctl/sssctl_cache.c | 6 +--
src/tools/sssctl/sssctl_cert.c | 2 +-
src/tools/sssctl/sssctl_config.c| 12 ++---
src/tools/sssctl/sssctl_data.c | 22
src/tools/sssctl/sssctl_domains.c | 18 +++
src/tools/sssctl/sssctl_logs.c | 14 ++---
src/tools/sssctl/sssctl_systemd.c | 2 +-
src/tools/sssctl/sssctl_user_checks.c | 70 -
14 files changed, 116 insertions(+), 124 deletions(-)
diff --git a/src/tools/common/sss_tools.c b/src/tools/common/sss_tools.c
index 0d918f164e..bcbbafe4c2 100644
--- a/src/tools/common/sss_tools.c
+++ b/src/tools/common/sss_tools.c
@@ -32,7 +32,7 @@
static void sss_tool_print_common_opts(int min_len)
{
-fprintf(stderr, _("Help options:\n"));
+ERROR("Help options:\n");
fprintf(stderr, " %-*s\t %s\n", min_len, "-?, --help",
_("Show this for a command"));
fprintf(stderr, " %-*s\t %s\n", min_len, "--usage",
@@ -241,8 +241,8 @@ void sss_tool_usage(const char *tool_name, struct sss_route_cmd *commands)
int min_len;
int i;
-fprintf(stderr, _("Usage:\n%s COMMAND COMMAND-ARGS\n\n"), tool_name);
-fprintf(stderr, _("Available commands:\n"));
+ERROR("Usage:\n%s COMMAND COMMAND-ARGS\n\n", tool_name);
+ERROR("Available commands:\n");
min_len = sss_tool_max_length(commands);
@@ -260,7 +260,7 @@ void sss_tool_usage(const char *tool_name, struct sss_route_cmd *commands)
}
}
-fprintf(stderr, _("\n"));
+ERROR("\n");
sss_tool_print_common_opts(min_len);
}
@@ -433,8 +433,8 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
goto done;
}
} else {
-fprintf(stderr, _("Invalid option %s: %s\n\n"),
-poptBadOption(pc, 0), poptStrerror(ret));
+ERROR("Invalid option %s: %s\n\n",
+ poptBadOption(pc, 0), poptStrerror(ret));
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -445,7 +445,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
fopt = poptGetArg(pc);
if (_fopt != NULL) {
if (fopt == NULL) {
-fprintf(stderr, _("Missing option: %s\n\n"), fopt_help);
+ERROR("Missing option: %s\n\n", fopt_help);
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -453,7 +453,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
/* No more arguments expected. If something follows it is an error. */
if (poptGetArg(pc)) {
-fprintf(stderr, _("Only one free argument is expected!\n\n"));
+ERROR("Only one free argument is expected!\n\n");
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -462,7 +462,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
*_fopt = fopt;
} else if (_fopt == NULL && fopt != NULL) {
/* Unexpected free argument. */
-fprintf(stderr, _("Unexpected parameter: %s\n\n"), fopt);
+ERROR("Unexpected parameter: %s\n\n", fopt);
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
@@ -474,7 +474,7 @@ errno_t sss_tool_popt_ex(struct sss_cmdline *cmdline,
/* If at least one option is required and not provided, print error. */
if (require_option == SSS_TOOL_OPT_REQUIRED) {
-fprintf(stderr, _("At least one option is required!\n\n"));
+ERROR("At least one option is required!\n\n");
poptPrintHelp(pc, stderr, 0);
ret = EINVAL;
goto done;
diff --git a/src/tools/sss_groupshow.c b/src/tools/sss_groupshow.c
index ac4c3dc912..c932b5958f 100644
--- a/src/tools/sss_groupshow.c
+++ b/src/tools/sss_groupshow.c
@@ -612,26 +612,26 @@ static void print_group_info(struct group_info *g, unsigned level)
snprintf(fmt, 8, "%%%ds", level*PADDING_SPACES);
snprintf(paddi
[SSSD] [sssd PR#902][comment] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902 Title: #902: Added ERROR and PRINT macros to the tools alexal commented: """ @mzidek-rh , please ignore my previous comment. I will change the code exactly as you requested. """ See the full comment at https://github.com/SSSD/sssd/pull/902#issuecomment-542678704 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][comment] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902
Title: #902: Added ERROR and PRINT macros to the tools
alexal commented:
"""
@mzidek-rh ,
Thanks for your response. I will remove _() right away, but I have a question
about format stings. I see for example in src/tools/sss_seed.c file that ERROR
macro is already used with non-formatted string:
`ERROR("Empty passwords are not allowed.\n");`
That is in the code already. What should I do? Continue using ERROR and PRINT
with non-formatted strings?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/902#issuecomment-542671987
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][comment] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902
Title: #902: Added ERROR and PRINT macros to the tools
alexal commented:
"""
@mzidek-rh ,
Thanks for your response. I will remove _() right away, but I have a question
about format stings. I see for example in src/tools/sss_seed.c file that ERROR
macro is already used with non-formatted string:
`ERROR("Empty passwords are not allowed.\n");`
That is in the code already. What should I do? Continue using ERROR and PRINT
with non-formatted strings?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/902#issuecomment-542671987
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#858][comment] ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true mzidek-rh commented: """ I will review this today or tomorrow. """ See the full comment at https://github.com/SSSD/sssd/pull/858#issuecomment-542644337 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#898][-Waiting for review] util/server: amended close_low_fds()
URL: https://github.com/SSSD/sssd/pull/898 Title: #898: util/server: amended close_low_fds() Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#898][comment] util/server: amended close_low_fds()
URL: https://github.com/SSSD/sssd/pull/898 Title: #898: util/server: amended close_low_fds() mzidek-rh commented: """ I agree that this patch makes the code much more readable. ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/898#issuecomment-542637560 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#898][+Accepted] util/server: amended close_low_fds()
URL: https://github.com/SSSD/sssd/pull/898 Title: #898: util/server: amended close_low_fds() Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#899][comment] sss_ptr_hash: pass new hash_entry_t to custom delete callback
URL: https://github.com/SSSD/sssd/pull/899 Title: #899: sss_ptr_hash: pass new hash_entry_t to custom delete callback mzidek-rh commented: """ Will review this together with some other patches today. At first glance, the code LGTM. """ See the full comment at https://github.com/SSSD/sssd/pull/899#issuecomment-542632797 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][comment] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902
Title: #902: Added ERROR and PRINT macros to the tools
mzidek-rh commented:
"""
Hi @alexal!
I have found these issues:
1. do not nest "ERROR()" and "PRINT()" macros with the macro "_()".
2. It does not make sense to wrap text that can not be translated into any if
these macros. So the messages that were not wrapped by _() macro should also
not be wrapped by ERROR() or PRINT() macros. For example here:
```
if (commands[i].description == NULL) {
-fprintf(stderr, "* %40s\n", commands[i].command);
+ERROR("* %40s\n", commands[i].command);
} else {
-fprintf(stderr, "* %-*s\t %s\n",
+ERROR("* %-*s\t %s\n",
min_len, commands[i].command, commands[i].description);
}
}
}
```
There is no reason to wrap those strings in gettext.
For the reference here are definitions of the PRINT(), ERROR() and _() macros:
```
src/util/util.h:54:#define _(STRING) gettext (STRING)
src/util/debug.h:#define ERROR(fmt, ...) fprintf(stderr, gettext(fmt),
##__VA_ARGS__)
src/util/debug.h:#define PRINT(fmt, ...) fprintf(stdout, gettext(fmt),
##__VA_ARGS__)
```
So you can use format string with ERROR and PRINT.
In general I agree that converting "fprintf + _()" into ERROR or PRINT results
in nicer looking code, so I am not against the patches if the above issues are
addressed.
Michal
"""
See the full comment at
https://github.com/SSSD/sssd/pull/902#issuecomment-542631510
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][+Changes requested] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902 Title: #902: Added ERROR and PRINT macros to the tools Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#844][comment] sssd-ad and gpo_child: GPO apply fixes during reading fails
URL: https://github.com/SSSD/sssd/pull/844 Title: #844: sssd-ad and gpo_child: GPO apply fixes during reading fails mastersin commented: """ Hello, @mzidek-rh. If you could update patches, I will ready test them asap. Thank you. """ See the full comment at https://github.com/SSSD/sssd/pull/844#issuecomment-542630052 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#901][comment] Update sss_ssh.c
URL: https://github.com/SSSD/sssd/pull/901 Title: #901: Update sss_ssh.c mzidek-rh commented: """ This patch looks OK. I will test it and ack if it will work (do not see why it should not, but you never know :) ). I plan to resolve this today. """ See the full comment at https://github.com/SSSD/sssd/pull/901#issuecomment-542613213 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#844][comment] sssd-ad and gpo_child: GPO apply fixes during reading fails
URL: https://github.com/SSSD/sssd/pull/844 Title: #844: sssd-ad and gpo_child: GPO apply fixes during reading fails mzidek-rh commented: """ Hello @mastersin . Do you plan to update the patches? If you do not have time, I can update the patches myself, but I would still want you to test it in your Samba setup otherwise I will not be 100% sure if it works for you. An important question for me is, what does not work for you without the second patch. There were problems in the patch and the patch was not doing what it advertised (because of the bad dereference), but maybe it was still enough to work around some issue. I would like to know what the issue was. Thanks, Michal """ See the full comment at https://github.com/SSSD/sssd/pull/844#issuecomment-542610716 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#902][comment] Added ERROR and PRINT macros to the tools
URL: https://github.com/SSSD/sssd/pull/902 Title: #902: Added ERROR and PRINT macros to the tools sumit-bose commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/902#issuecomment-542566827 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#851][comment] Update __init__.py.in
URL: https://github.com/SSSD/sssd/pull/851 Title: #851: Update __init__.py.in pbrezina commented: """ Thank you. One more thing - then I will ack it. Can you add a test case for the use case in ticket description? Perhaps as part of sssd-valid.conf tests. """ See the full comment at https://github.com/SSSD/sssd/pull/851#issuecomment-542562994 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
