[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-12 Thread Jakub Hrozek 
On Mon, Sep 12, 2016 at 10:40:21AM +0200, Jakub Hrozek wrote:
> On Mon, Sep 12, 2016 at 10:31:24AM +0200, Jakub Hrozek wrote:
> > On Mon, Sep 12, 2016 at 12:21:26AM +0200, Jakub Hrozek wrote:
> > > On Thu, Sep 08, 2016 at 01:57:29PM -0400, Justin Stephenson wrote:
> > > > On 09/07/2016 02:24 PM, Jakub Hrozek wrote:
> > > > > Hi,
> > > > > 
> > > > > sorry to come late, but I have one more request (last one, I 
> > > > > promise..)
> > > > > 
> > > > > On Thu, Sep 01, 2016 at 09:36:32AM -0400, Justin Stephenson wrote:
> > > > > > From f647e732c2a5b8727376dded962766fb03bb5ea8 Mon Sep 17 00:00:00 
> > > > > > 2001
> > > > > > From: Justin Stephenson 
> > > > > > Date: Fri, 26 Aug 2016 15:15:32 -0400
> > > > > > Subject: [PATCH 1/3] MONITOR: Remove --disable-netlink 
> > > > > > command-line option
> > > > > > 
> > > > > > Removing monitor command-line option, to be superceded by
> > > > > > sssd.conf option
> > > > > 
> > > > > [...]
> > > > > 
> > > > > > +if (opt_netlinkoff) {
> > > > > > +fprintf(stderr, "Option --disable-netlink has been removed 
> > > > > > and "
> > > > > > +"replaced as a Monitor option in sssd.conf\n");
> > > > > > +poptPrintUsage(pc, stderr, 0);
> > > > > > +return 1;
> > > > > 
> > > > > I would prefer if we were a little more graceful here and only called
> > > > > DEBUG and sss_log() but did not abort the startup. I think it's better
> > > > > to start SSSD in a degraded mode than not at all..
> > > > 
> > > > Hi Jakub,
> > > > 
> > > > No problem, patch updated.
> > > 
> > > ACK
> > 
> > CI: http://sssd-ci.duckdns.org/logs/job/53/18/summary.html
> > 
> > * master:
> > * 632fc5d8991d167eea20769c823163551c3f1d8c
> > * 081c6d8c7c8e75487d1c4e42862964be1e85b575
> 
> Oh, fsck..I pushed wrong patch files..

Actually no, they were correct, sorry. The alarm is off :)
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-12 Thread Jakub Hrozek 
On Mon, Sep 12, 2016 at 10:31:24AM +0200, Jakub Hrozek wrote:
> On Mon, Sep 12, 2016 at 12:21:26AM +0200, Jakub Hrozek wrote:
> > On Thu, Sep 08, 2016 at 01:57:29PM -0400, Justin Stephenson wrote:
> > > On 09/07/2016 02:24 PM, Jakub Hrozek wrote:
> > > > Hi,
> > > > 
> > > > sorry to come late, but I have one more request (last one, I promise..)
> > > > 
> > > > On Thu, Sep 01, 2016 at 09:36:32AM -0400, Justin Stephenson wrote:
> > > > > From f647e732c2a5b8727376dded962766fb03bb5ea8 Mon Sep 17 00:00:00 2001
> > > > > From: Justin Stephenson 
> > > > > Date: Fri, 26 Aug 2016 15:15:32 -0400
> > > > > Subject: [PATCH 1/3] MONITOR: Remove --disable-netlink 
> > > > > command-line option
> > > > > 
> > > > > Removing monitor command-line option, to be superceded by
> > > > > sssd.conf option
> > > > 
> > > > [...]
> > > > 
> > > > > +if (opt_netlinkoff) {
> > > > > +fprintf(stderr, "Option --disable-netlink has been removed 
> > > > > and "
> > > > > +"replaced as a Monitor option in sssd.conf\n");
> > > > > +poptPrintUsage(pc, stderr, 0);
> > > > > +return 1;
> > > > 
> > > > I would prefer if we were a little more graceful here and only called
> > > > DEBUG and sss_log() but did not abort the startup. I think it's better
> > > > to start SSSD in a degraded mode than not at all..
> > > 
> > > Hi Jakub,
> > > 
> > > No problem, patch updated.
> > 
> > ACK
> 
> CI: http://sssd-ci.duckdns.org/logs/job/53/18/summary.html
> 
> * master:
> * 632fc5d8991d167eea20769c823163551c3f1d8c
> * 081c6d8c7c8e75487d1c4e42862964be1e85b575

Oh, fsck..I pushed wrong patch files..

I guess it's cleaner to revert and push the correct ones than to push
interdiff right?

This is exactly why I prefer pull requests over patches to mailing
lists..
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-12 Thread Jakub Hrozek 
On Mon, Sep 12, 2016 at 12:21:26AM +0200, Jakub Hrozek wrote:
> On Thu, Sep 08, 2016 at 01:57:29PM -0400, Justin Stephenson wrote:
> > On 09/07/2016 02:24 PM, Jakub Hrozek wrote:
> > > Hi,
> > > 
> > > sorry to come late, but I have one more request (last one, I promise..)
> > > 
> > > On Thu, Sep 01, 2016 at 09:36:32AM -0400, Justin Stephenson wrote:
> > > > From f647e732c2a5b8727376dded962766fb03bb5ea8 Mon Sep 17 00:00:00 2001
> > > > From: Justin Stephenson 
> > > > Date: Fri, 26 Aug 2016 15:15:32 -0400
> > > > Subject: [PATCH 1/3] MONITOR: Remove --disable-netlink command-line 
> > > > option
> > > > 
> > > > Removing monitor command-line option, to be superceded by
> > > > sssd.conf option
> > > 
> > > [...]
> > > 
> > > > +if (opt_netlinkoff) {
> > > > +fprintf(stderr, "Option --disable-netlink has been removed and 
> > > > "
> > > > +"replaced as a Monitor option in sssd.conf\n");
> > > > +poptPrintUsage(pc, stderr, 0);
> > > > +return 1;
> > > 
> > > I would prefer if we were a little more graceful here and only called
> > > DEBUG and sss_log() but did not abort the startup. I think it's better
> > > to start SSSD in a degraded mode than not at all..
> > 
> > Hi Jakub,
> > 
> > No problem, patch updated.
> 
> ACK

CI: http://sssd-ci.duckdns.org/logs/job/53/18/summary.html

* master:
* 632fc5d8991d167eea20769c823163551c3f1d8c
* 081c6d8c7c8e75487d1c4e42862964be1e85b575
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-11 Thread Jakub Hrozek 
On Thu, Sep 08, 2016 at 01:57:29PM -0400, Justin Stephenson wrote:
> On 09/07/2016 02:24 PM, Jakub Hrozek wrote:
> > Hi,
> > 
> > sorry to come late, but I have one more request (last one, I promise..)
> > 
> > On Thu, Sep 01, 2016 at 09:36:32AM -0400, Justin Stephenson wrote:
> > > From f647e732c2a5b8727376dded962766fb03bb5ea8 Mon Sep 17 00:00:00 2001
> > > From: Justin Stephenson 
> > > Date: Fri, 26 Aug 2016 15:15:32 -0400
> > > Subject: [PATCH 1/3] MONITOR: Remove --disable-netlink command-line 
> > > option
> > > 
> > > Removing monitor command-line option, to be superceded by
> > > sssd.conf option
> > 
> > [...]
> > 
> > > +if (opt_netlinkoff) {
> > > +fprintf(stderr, "Option --disable-netlink has been removed and "
> > > +"replaced as a Monitor option in sssd.conf\n");
> > > +poptPrintUsage(pc, stderr, 0);
> > > +return 1;
> > 
> > I would prefer if we were a little more graceful here and only called
> > DEBUG and sss_log() but did not abort the startup. I think it's better
> > to start SSSD in a degraded mode than not at all..
> 
> Hi Jakub,
> 
> No problem, patch updated.

ACK
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-07 Thread Jakub Hrozek 
Hi,

sorry to come late, but I have one more request (last one, I promise..)

On Thu, Sep 01, 2016 at 09:36:32AM -0400, Justin Stephenson wrote:
> From f647e732c2a5b8727376dded962766fb03bb5ea8 Mon Sep 17 00:00:00 2001
> From: Justin Stephenson 
> Date: Fri, 26 Aug 2016 15:15:32 -0400
> Subject: [PATCH 1/3] MONITOR: Remove --disable-netlink command-line option
> 
> Removing monitor command-line option, to be superceded by
> sssd.conf option

[...]

> +if (opt_netlinkoff) {
> +fprintf(stderr, "Option --disable-netlink has been removed and "
> +"replaced as a Monitor option in sssd.conf\n");
> +poptPrintUsage(pc, stderr, 0);
> +return 1;

I would prefer if we were a little more graceful here and only called
DEBUG and sss_log() but did not abort the startup. I think it's better
to start SSSD in a degraded mode than not at all..

> +}
> +
>  if (!opt_daemon && !opt_interactive && !opt_genconf) {
>  opt_daemon = 1;
>  }
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-05 Thread Lukas Slebodnik 
On (05/09/16 15:54), Petr Cech wrote:
>
>
>On 09/05/2016 09:45 AM, Lukas Slebodnik wrote:
>> On (02/09/16 15:34), Petr Cech wrote:
>> > 
>> > 
>> > On 09/02/2016 03:31 PM, Justin Stephenson wrote:
>> > > On 09/02/2016 05:23 AM, Petr Cech wrote:
>> > > > On 09/01/2016 03:36 PM, Justin Stephenson wrote:
>> > > > > On 08/30/2016 03:54 AM, Jakub Hrozek wrote:
>> > > > > > On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:
>> > > > > > > Hello,
>> > > > > > > 
>> > > > > > > The attached patches resolve 
>> > > > > > > https://fedorahosted.org/sssd/ticket/3142
>> > > > > > > 
>> > > > > > > However, I am having difficult with the man page addition to
>> > > > > > > 'src/man/sssd.conf.5.xml' for this new option. I have stared at 
>> > > > > > > the
>> > > > > > > open and
>> > > > > > > close xml tags(for far too long) and it looks correct but when I
>> > > > > > > build sssd
>> > > > > > > I never see the sssd.conf man page inclusion. Could anyone tell 
>> > > > > > > me
>> > > > > > > what I am
>> > > > > > > missing here?
>> > > > > > > 
>> > > > > > > If you feel there is better wording for the description please 
>> > > > > > > let me
>> > > > > > > know.
>> > > > > > > 
>> > > > > > > Kind regards,
>> > > > > > > Justin Stephenson
>> > > > > > 
>> > > > > > > From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 
>> > > > > > > 00:00:00 2001
>> > > > > > > From: Justin Stephenson 
>> > > > > > > Date: Fri, 26 Aug 2016 15:15:32 -0400
>> > > > > > > Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink
>> > > > > > > command-line option
>> > > > > > 
>> > > > > > I'm not sure I like removing the netlink option w/o letting admins 
>> > > > > > who
>> > > > > > use it at least know what happened. Could we keep the option in the
>> > > > > > popt
>> > > > > > option list, but use the HIDDEN argument so that it doesn't show 
>> > > > > > up in
>> > > > > > --help output and print a loud warning that the option was removed 
>> > > > > > in
>> > > > > > favor of a sssd.conf option?
>> > > > > > 
>> > > > > > I already know of two people from sssd-users list who might be 
>> > > > > > using
>> > > > > > this feature. On the other hand, it was just introduced in the last
>> > > > > > version and not in any enterprise distro, so just printing a 
>> > > > > > warning
>> > > > > > and
>> > > > > > removing even that warning in the next version would be fine for 
>> > > > > > me..
>> > > > > 
>> > > > > Agreed, please see updated patches also with Petr's corrections. Once
>> > > > > this fix is pushed I can respond to the email and at least let these
>> > > > > users know.
>> > > > > 
>> > > > > I am still having trouble with the man page addition to sssd.conf not
>> > > > > showing, any ideas why?
>> > > > > 
>> > > > > diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
>> > > > > index
>> > > > > ae291e0fc8f2f9afabcdf32f18a5ec12252f..6f231b8ab8fc078d83331bb7ef5b980528a30bd6
>> > > > > 
>> > > > > 
>> > > > > 100644
>> > > > > --- a/src/man/sssd.conf.5.xml
>> > > > > +++ b/src/man/sssd.conf.5.xml
>> > > > > @@ -482,6 +482,24 @@
>> > > > >  
>> > > > >  
>> > > > >  
>> > > > > +
>> > > > > +disable_netlink (boolean)
>> > > > > +
>> > > > > +
>> > > > > +SSSD hooks into the netlink
>> > > > > interface to
>> > > > > +monitor changes to routes, 
>> > > > > addresses,
>> > > > > links
>> > > > > +and trigger certain actions.
>> > > > > +
>> > > > > +
>> > > > > +The SSSD state changes caused by
>> > > > > netlink
>> > > > > +events may be undesirable and can be
>> > > > > disabled
>> > > > > +by setting this option to 'true'
>> > > > > +
>> > > > > +
>> > > > > +Default: false (netlink changes are
>> > > > > detected)
>> > > > > +
>> > > > > +
>> > > > > +
>> > > > >  
>> > > > >  
>> > > > >  
>> > > > > 
>> > > > > Kind regards,
>> > > > > Justin Stephenson
>> > > > > 
>> > > > > > 
>> > > > > > > From c52c0c1a520cdf8509bac00fa3c7bec0dd73 Mon Sep 17 
>> > > > > > > 00:00:00 2001
>> > > > > > > From: Justin Stephenson 
>> > > > > > > Date: Fri, 26 Aug 2016 17:43:25 -0400
>> > > > > > > Subject: [PATCH 2/2] MONITOR: Add disable_netlink option
>> > > > > > 
>> > > > > > LGTM, untested, though.
>> > > > 
>> > > > Hello Justin and Jakub,
>> > > > 
>> > > > I tested it:
>> > > > sssd --help ... option is gone
>> > > > 
>> > > >

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-05 Thread Petr Cech 



On 09/05/2016 09:45 AM, Lukas Slebodnik wrote:

On (02/09/16 15:34), Petr Cech wrote:



On 09/02/2016 03:31 PM, Justin Stephenson wrote:

On 09/02/2016 05:23 AM, Petr Cech wrote:

On 09/01/2016 03:36 PM, Justin Stephenson wrote:

On 08/30/2016 03:54 AM, Jakub Hrozek wrote:

On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:

Hello,

The attached patches resolve https://fedorahosted.org/sssd/ticket/3142

However, I am having difficult with the man page addition to
'src/man/sssd.conf.5.xml' for this new option. I have stared at the
open and
close xml tags(for far too long) and it looks correct but when I
build sssd
I never see the sssd.conf man page inclusion. Could anyone tell me
what I am
missing here?

If you feel there is better wording for the description please let me
know.

Kind regards,
Justin Stephenson



From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 15:15:32 -0400
Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink
command-line option


I'm not sure I like removing the netlink option w/o letting admins who
use it at least know what happened. Could we keep the option in the
popt
option list, but use the HIDDEN argument so that it doesn't show up in
--help output and print a loud warning that the option was removed in
favor of a sssd.conf option?

I already know of two people from sssd-users list who might be using
this feature. On the other hand, it was just introduced in the last
version and not in any enterprise distro, so just printing a warning
and
removing even that warning in the next version would be fine for me..


Agreed, please see updated patches also with Petr's corrections. Once
this fix is pushed I can respond to the email and at least let these
users know.

I am still having trouble with the man page addition to sssd.conf not
showing, any ideas why?

diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index
ae291e0fc8f2f9afabcdf32f18a5ec12252f..6f231b8ab8fc078d83331bb7ef5b980528a30bd6


100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -482,6 +482,24 @@
 
 
 
+
+disable_netlink (boolean)
+
+
+SSSD hooks into the netlink
interface to
+monitor changes to routes, addresses,
links
+and trigger certain actions.
+
+
+The SSSD state changes caused by
netlink
+events may be undesirable and can be
disabled
+by setting this option to 'true'
+
+
+Default: false (netlink changes are
detected)
+
+
+
 
 
 

Kind regards,
Justin Stephenson




From c52c0c1a520cdf8509bac00fa3c7bec0dd73 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 17:43:25 -0400
Subject: [PATCH 2/2] MONITOR: Add disable_netlink option


LGTM, untested, though.


Hello Justin and Jakub,

I tested it:
sssd --help ... option is gone

/sbin/sssd --disable-netlink
Option --disable-netlink has been removed and replaced as a Monitor
option in sssd.conf

I see disable-netlink in man sssd.conf.
Justin, I run 'make rpms' and reinstall all,
so man pages were reinstall too.


Thanks Petr, I was using the steps in the Contribute wiki 'reconfig &&
chmake' then 'sssinstall' but I guess that did not update the man pages
from my commit as expected.


So far as I know, 'sssinstall' isn't good for man pages. But 'make rpms'
build whole all necessary things.


Could you elaborate?
Why 'sssinstall is not good for man pages?

LS


Hi Lukas,

if I understand correctly, command 'reconfig'
prepare build environment to no producing man pages.
See contrib/fedora/bashrc_sssd:53:
${SSSD_NO_MANPAGES-} \
So if someone run reconfig before sssinstall it will
not install recent man pages.

Or did I understand it wrong way?

Regards

--
Petr^4 Čech
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-05 Thread Lukas Slebodnik 
On (02/09/16 15:34), Petr Cech wrote:
>
>
>On 09/02/2016 03:31 PM, Justin Stephenson wrote:
>> On 09/02/2016 05:23 AM, Petr Cech wrote:
>> > On 09/01/2016 03:36 PM, Justin Stephenson wrote:
>> > > On 08/30/2016 03:54 AM, Jakub Hrozek wrote:
>> > > > On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:
>> > > > > Hello,
>> > > > > 
>> > > > > The attached patches resolve 
>> > > > > https://fedorahosted.org/sssd/ticket/3142
>> > > > > 
>> > > > > However, I am having difficult with the man page addition to
>> > > > > 'src/man/sssd.conf.5.xml' for this new option. I have stared at the
>> > > > > open and
>> > > > > close xml tags(for far too long) and it looks correct but when I
>> > > > > build sssd
>> > > > > I never see the sssd.conf man page inclusion. Could anyone tell me
>> > > > > what I am
>> > > > > missing here?
>> > > > > 
>> > > > > If you feel there is better wording for the description please let me
>> > > > > know.
>> > > > > 
>> > > > > Kind regards,
>> > > > > Justin Stephenson
>> > > > 
>> > > > > From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 
>> > > > > 2001
>> > > > > From: Justin Stephenson 
>> > > > > Date: Fri, 26 Aug 2016 15:15:32 -0400
>> > > > > Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink
>> > > > > command-line option
>> > > > 
>> > > > I'm not sure I like removing the netlink option w/o letting admins who
>> > > > use it at least know what happened. Could we keep the option in the
>> > > > popt
>> > > > option list, but use the HIDDEN argument so that it doesn't show up in
>> > > > --help output and print a loud warning that the option was removed in
>> > > > favor of a sssd.conf option?
>> > > > 
>> > > > I already know of two people from sssd-users list who might be using
>> > > > this feature. On the other hand, it was just introduced in the last
>> > > > version and not in any enterprise distro, so just printing a warning
>> > > > and
>> > > > removing even that warning in the next version would be fine for me..
>> > > 
>> > > Agreed, please see updated patches also with Petr's corrections. Once
>> > > this fix is pushed I can respond to the email and at least let these
>> > > users know.
>> > > 
>> > > I am still having trouble with the man page addition to sssd.conf not
>> > > showing, any ideas why?
>> > > 
>> > > diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
>> > > index
>> > > ae291e0fc8f2f9afabcdf32f18a5ec12252f..6f231b8ab8fc078d83331bb7ef5b980528a30bd6
>> > > 
>> > > 
>> > > 100644
>> > > --- a/src/man/sssd.conf.5.xml
>> > > +++ b/src/man/sssd.conf.5.xml
>> > > @@ -482,6 +482,24 @@
>> > >  
>> > >  
>> > >  
>> > > +
>> > > +disable_netlink (boolean)
>> > > +
>> > > +
>> > > +SSSD hooks into the netlink
>> > > interface to
>> > > +monitor changes to routes, addresses,
>> > > links
>> > > +and trigger certain actions.
>> > > +
>> > > +
>> > > +The SSSD state changes caused by
>> > > netlink
>> > > +events may be undesirable and can be
>> > > disabled
>> > > +by setting this option to 'true'
>> > > +
>> > > +
>> > > +Default: false (netlink changes are
>> > > detected)
>> > > +
>> > > +
>> > > +
>> > >  
>> > >  
>> > >  
>> > > 
>> > > Kind regards,
>> > > Justin Stephenson
>> > > 
>> > > > 
>> > > > > From c52c0c1a520cdf8509bac00fa3c7bec0dd73 Mon Sep 17 00:00:00 
>> > > > > 2001
>> > > > > From: Justin Stephenson 
>> > > > > Date: Fri, 26 Aug 2016 17:43:25 -0400
>> > > > > Subject: [PATCH 2/2] MONITOR: Add disable_netlink option
>> > > > 
>> > > > LGTM, untested, though.
>> > 
>> > Hello Justin and Jakub,
>> > 
>> > I tested it:
>> > sssd --help ... option is gone
>> > 
>> > /sbin/sssd --disable-netlink
>> > Option --disable-netlink has been removed and replaced as a Monitor
>> > option in sssd.conf
>> > 
>> > I see disable-netlink in man sssd.conf.
>> > Justin, I run 'make rpms' and reinstall all,
>> > so man pages were reinstall too.
>> 
>> Thanks Petr, I was using the steps in the Contribute wiki 'reconfig &&
>> chmake' then 'sssinstall' but I guess that did not update the man pages
>> from my commit as expected.
>
>So far as I know, 'sssinstall' isn't good for man pages. But 'make rpms'
>build whole all necessary things.
>
Could you elaborate?
Why 'sssinstall is not good for man pages?

LS
___
sssd-devel

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-02 Thread Petr Cech 



On 09/02/2016 03:31 PM, Justin Stephenson wrote:

On 09/02/2016 05:23 AM, Petr Cech wrote:

On 09/01/2016 03:36 PM, Justin Stephenson wrote:

On 08/30/2016 03:54 AM, Jakub Hrozek wrote:

On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:

Hello,

The attached patches resolve https://fedorahosted.org/sssd/ticket/3142

However, I am having difficult with the man page addition to
'src/man/sssd.conf.5.xml' for this new option. I have stared at the
open and
close xml tags(for far too long) and it looks correct but when I
build sssd
I never see the sssd.conf man page inclusion. Could anyone tell me
what I am
missing here?

If you feel there is better wording for the description please let me
know.

Kind regards,
Justin Stephenson



From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 15:15:32 -0400
Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink
command-line option


I'm not sure I like removing the netlink option w/o letting admins who
use it at least know what happened. Could we keep the option in the
popt
option list, but use the HIDDEN argument so that it doesn't show up in
--help output and print a loud warning that the option was removed in
favor of a sssd.conf option?

I already know of two people from sssd-users list who might be using
this feature. On the other hand, it was just introduced in the last
version and not in any enterprise distro, so just printing a warning
and
removing even that warning in the next version would be fine for me..


Agreed, please see updated patches also with Petr's corrections. Once
this fix is pushed I can respond to the email and at least let these
users know.

I am still having trouble with the man page addition to sssd.conf not
showing, any ideas why?

diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index
ae291e0fc8f2f9afabcdf32f18a5ec12252f..6f231b8ab8fc078d83331bb7ef5b980528a30bd6


100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -482,6 +482,24 @@
 
 
 
+
+disable_netlink (boolean)
+
+
+SSSD hooks into the netlink
interface to
+monitor changes to routes, addresses,
links
+and trigger certain actions.
+
+
+The SSSD state changes caused by
netlink
+events may be undesirable and can be
disabled
+by setting this option to 'true'
+
+
+Default: false (netlink changes are
detected)
+
+
+
 
 
 

Kind regards,
Justin Stephenson




From c52c0c1a520cdf8509bac00fa3c7bec0dd73 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 17:43:25 -0400
Subject: [PATCH 2/2] MONITOR: Add disable_netlink option


LGTM, untested, though.


Hello Justin and Jakub,

I tested it:
sssd --help ... option is gone

/sbin/sssd --disable-netlink
Option --disable-netlink has been removed and replaced as a Monitor
option in sssd.conf

I see disable-netlink in man sssd.conf.
Justin, I run 'make rpms' and reinstall all,
so man pages were reinstall too.


Thanks Petr, I was using the steps in the Contribute wiki 'reconfig &&
chmake' then 'sssinstall' but I guess that did not update the man pages
from my commit as expected.


So far as I know, 'sssinstall' isn't good for man pages. But 'make rpms' 
build whole all necessary things.


'sssinstall' is good for common developing process.




-Justin



LGTM

I just wait for CI :-)

Regards


___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org



--
Petr^4 Čech
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-02 Thread Justin Stephenson 

On 09/02/2016 05:23 AM, Petr Cech wrote:

On 09/01/2016 03:36 PM, Justin Stephenson wrote:

On 08/30/2016 03:54 AM, Jakub Hrozek wrote:

On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:

Hello,

The attached patches resolve https://fedorahosted.org/sssd/ticket/3142

However, I am having difficult with the man page addition to
'src/man/sssd.conf.5.xml' for this new option. I have stared at the
open and
close xml tags(for far too long) and it looks correct but when I
build sssd
I never see the sssd.conf man page inclusion. Could anyone tell me
what I am
missing here?

If you feel there is better wording for the description please let me
know.

Kind regards,
Justin Stephenson



From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 15:15:32 -0400
Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink
command-line option


I'm not sure I like removing the netlink option w/o letting admins who
use it at least know what happened. Could we keep the option in the popt
option list, but use the HIDDEN argument so that it doesn't show up in
--help output and print a loud warning that the option was removed in
favor of a sssd.conf option?

I already know of two people from sssd-users list who might be using
this feature. On the other hand, it was just introduced in the last
version and not in any enterprise distro, so just printing a warning and
removing even that warning in the next version would be fine for me..


Agreed, please see updated patches also with Petr's corrections. Once
this fix is pushed I can respond to the email and at least let these
users know.

I am still having trouble with the man page addition to sssd.conf not
showing, any ideas why?

diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index
ae291e0fc8f2f9afabcdf32f18a5ec12252f..6f231b8ab8fc078d83331bb7ef5b980528a30bd6

100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -482,6 +482,24 @@
 
 
 
+
+disable_netlink (boolean)
+
+
+SSSD hooks into the netlink interface to
+monitor changes to routes, addresses,
links
+and trigger certain actions.
+
+
+The SSSD state changes caused by netlink
+events may be undesirable and can be
disabled
+by setting this option to 'true'
+
+
+Default: false (netlink changes are
detected)
+
+
+
 
 
 

Kind regards,
Justin Stephenson




From c52c0c1a520cdf8509bac00fa3c7bec0dd73 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 17:43:25 -0400
Subject: [PATCH 2/2] MONITOR: Add disable_netlink option


LGTM, untested, though.


Hello Justin and Jakub,

I tested it:
sssd --help ... option is gone

/sbin/sssd --disable-netlink
Option --disable-netlink has been removed and replaced as a Monitor
option in sssd.conf

I see disable-netlink in man sssd.conf.
Justin, I run 'make rpms' and reinstall all,
so man pages were reinstall too.


Thanks Petr, I was using the steps in the Contribute wiki 'reconfig && 
chmake' then 'sssinstall' but I guess that did not update the man pages 
from my commit as expected.


-Justin



LGTM

I just wait for CI :-)

Regards


___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-02 Thread Petr Cech 

On 09/02/2016 11:23 AM, Petr Cech wrote:

On 09/01/2016 03:36 PM, Justin Stephenson wrote:

On 08/30/2016 03:54 AM, Jakub Hrozek wrote:

On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:

Hello,

The attached patches resolve https://fedorahosted.org/sssd/ticket/3142

However, I am having difficult with the man page addition to
'src/man/sssd.conf.5.xml' for this new option. I have stared at the
open and
close xml tags(for far too long) and it looks correct but when I
build sssd
I never see the sssd.conf man page inclusion. Could anyone tell me
what I am
missing here?

If you feel there is better wording for the description please let me
know.

Kind regards,
Justin Stephenson



From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 15:15:32 -0400
Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink
command-line option


I'm not sure I like removing the netlink option w/o letting admins who
use it at least know what happened. Could we keep the option in the popt
option list, but use the HIDDEN argument so that it doesn't show up in
--help output and print a loud warning that the option was removed in
favor of a sssd.conf option?

I already know of two people from sssd-users list who might be using
this feature. On the other hand, it was just introduced in the last
version and not in any enterprise distro, so just printing a warning and
removing even that warning in the next version would be fine for me..


Agreed, please see updated patches also with Petr's corrections. Once
this fix is pushed I can respond to the email and at least let these
users know.

I am still having trouble with the man page addition to sssd.conf not
showing, any ideas why?

diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index
ae291e0fc8f2f9afabcdf32f18a5ec12252f..6f231b8ab8fc078d83331bb7ef5b980528a30bd6

100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -482,6 +482,24 @@
 
 
 
+
+disable_netlink (boolean)
+
+
+SSSD hooks into the netlink interface to
+monitor changes to routes, addresses,
links
+and trigger certain actions.
+
+
+The SSSD state changes caused by netlink
+events may be undesirable and can be
disabled
+by setting this option to 'true'
+
+
+Default: false (netlink changes are
detected)
+
+
+
 
 
 

Kind regards,
Justin Stephenson




From c52c0c1a520cdf8509bac00fa3c7bec0dd73 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 17:43:25 -0400
Subject: [PATCH 2/2] MONITOR: Add disable_netlink option


LGTM, untested, though.


Hello Justin and Jakub,

I tested it:
sssd --help ... option is gone

/sbin/sssd --disable-netlink
Option --disable-netlink has been removed and replaced as a Monitor
option in sssd.conf

I see disable-netlink in man sssd.conf.
Justin, I run 'make rpms' and reinstall all,
so man pages were reinstall too.

LGTM

I just wait for CI :-)


CI passed:
http://sssd-ci.duckdns.org/logs/job/52/96/summary.html

=> ACK

Regards
--
Petr^4 Čech
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-02 Thread Petr Cech 

On 09/01/2016 03:36 PM, Justin Stephenson wrote:

On 08/30/2016 03:54 AM, Jakub Hrozek wrote:

On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:

Hello,

The attached patches resolve https://fedorahosted.org/sssd/ticket/3142

However, I am having difficult with the man page addition to
'src/man/sssd.conf.5.xml' for this new option. I have stared at the
open and
close xml tags(for far too long) and it looks correct but when I
build sssd
I never see the sssd.conf man page inclusion. Could anyone tell me
what I am
missing here?

If you feel there is better wording for the description please let me
know.

Kind regards,
Justin Stephenson



From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 15:15:32 -0400
Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink
command-line option


I'm not sure I like removing the netlink option w/o letting admins who
use it at least know what happened. Could we keep the option in the popt
option list, but use the HIDDEN argument so that it doesn't show up in
--help output and print a loud warning that the option was removed in
favor of a sssd.conf option?

I already know of two people from sssd-users list who might be using
this feature. On the other hand, it was just introduced in the last
version and not in any enterprise distro, so just printing a warning and
removing even that warning in the next version would be fine for me..


Agreed, please see updated patches also with Petr's corrections. Once
this fix is pushed I can respond to the email and at least let these
users know.

I am still having trouble with the man page addition to sssd.conf not
showing, any ideas why?

diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index
ae291e0fc8f2f9afabcdf32f18a5ec12252f..6f231b8ab8fc078d83331bb7ef5b980528a30bd6
100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -482,6 +482,24 @@
 
 
 
+
+disable_netlink (boolean)
+
+
+SSSD hooks into the netlink interface to
+monitor changes to routes, addresses,
links
+and trigger certain actions.
+
+
+The SSSD state changes caused by netlink
+events may be undesirable and can be
disabled
+by setting this option to 'true'
+
+
+Default: false (netlink changes are
detected)
+
+
+
 
 
 

Kind regards,
Justin Stephenson




From c52c0c1a520cdf8509bac00fa3c7bec0dd73 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 17:43:25 -0400
Subject: [PATCH 2/2] MONITOR: Add disable_netlink option


LGTM, untested, though.


Hello Justin and Jakub,

I tested it:
sssd --help ... option is gone

/sbin/sssd --disable-netlink
Option --disable-netlink has been removed and replaced as a Monitor 
option in sssd.conf


I see disable-netlink in man sssd.conf.
Justin, I run 'make rpms' and reinstall all,
so man pages were reinstall too.

LGTM

I just wait for CI :-)

Regards

--
Petr^4 Čech
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-01 Thread Justin Stephenson 

On 08/30/2016 03:54 AM, Jakub Hrozek wrote:

On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:

Hello,

The attached patches resolve https://fedorahosted.org/sssd/ticket/3142

However, I am having difficult with the man page addition to
'src/man/sssd.conf.5.xml' for this new option. I have stared at the open and
close xml tags(for far too long) and it looks correct but when I build sssd
I never see the sssd.conf man page inclusion. Could anyone tell me what I am
missing here?

If you feel there is better wording for the description please let me know.

Kind regards,
Justin Stephenson



From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 15:15:32 -0400
Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink command-line option


I'm not sure I like removing the netlink option w/o letting admins who
use it at least know what happened. Could we keep the option in the popt
option list, but use the HIDDEN argument so that it doesn't show up in
--help output and print a loud warning that the option was removed in
favor of a sssd.conf option?

I already know of two people from sssd-users list who might be using
this feature. On the other hand, it was just introduced in the last
version and not in any enterprise distro, so just printing a warning and
removing even that warning in the next version would be fine for me..


Agreed, please see updated patches also with Petr's corrections. Once 
this fix is pushed I can respond to the email and at least let these 
users know.


I am still having trouble with the man page addition to sssd.conf not 
showing, any ideas why?


diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index 
ae291e0fc8f2f9afabcdf32f18a5ec12252f..6f231b8ab8fc078d83331bb7ef5b980528a30bd6 
100644

--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -482,6 +482,24 @@
 
 
 
+
+disable_netlink (boolean)
+
+
+SSSD hooks into the netlink interface to
+monitor changes to routes, addresses, links
+and trigger certain actions.
+
+
+The SSSD state changes caused by netlink
+events may be undesirable and can be 
disabled

+by setting this option to 'true'
+
+
+Default: false (netlink changes are 
detected)

+
+
+
 
 
 

Kind regards,
Justin Stephenson




From c52c0c1a520cdf8509bac00fa3c7bec0dd73 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 17:43:25 -0400
Subject: [PATCH 2/2] MONITOR: Add disable_netlink option


LGTM, untested, though.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

>From 9282b9dc9f935bd632ace452dd6e07b31ea25ede Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 17:43:25 -0400
Subject: [PATCH 2/3] MONITOR: Add disable_netlink option

Adding a new monitor boolean option to disable netlink support.
This will give users more control over sssd state changes without
having to modify systemd unit files.

Resolves:
https://fedorahosted.org/sssd/ticket/3142
---
 src/confdb/confdb.h  |  1 +
 src/config/SSSDConfig/__init__.py.in |  1 +
 src/config/SSSDConfigTest.py |  3 ++-
 src/config/cfg_rules.ini |  1 +
 src/config/etc/sssd.api.conf |  1 +
 src/man/sssd.conf.5.xml  | 18 ++
 src/monitor/monitor.c| 21 ++---
 7 files changed, 42 insertions(+), 4 deletions(-)

diff --git a/src/confdb/confdb.h b/src/confdb/confdb.h
index 401e5fbf7ed6bb9e8d7158dfab378c8159aa03db..2d650900170d5f2214aa56f00fc749980e53f516 100644
--- a/src/confdb/confdb.h
+++ b/src/confdb/confdb.h
@@ -73,6 +73,7 @@
 #define CONFDB_MONITOR_OVERRIDE_SPACE "override_space"
 #define CONFDB_MONITOR_USER_RUNAS "user"
 #define CONFDB_MONITOR_CERT_VERIFICATION "certificate_verification"
+#define CONFDB_MONITOR_DISABLE_NETLINK "disable_netlink"
 
 /* Both monitor and domains */
 #define CONFDB_NAME_REGEX   "re_expression"
diff --git a/src/config/SSSDConfig/__init__.py.in b/src/config/SSSDConfig/__init__.py.in
index 0191920f93ab9016508e08785c25dd043c180c0b..2027028f7b4e972c7bc0dd5156fd85157ae192f4 100644
--- a/src/config/SSSDConfig/__init__.py.in
+++

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-08-30 Thread Jakub Hrozek 
On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:
> Hello,
> 
> The attached patches resolve https://fedorahosted.org/sssd/ticket/3142
> 
> However, I am having difficult with the man page addition to
> 'src/man/sssd.conf.5.xml' for this new option. I have stared at the open and
> close xml tags(for far too long) and it looks correct but when I build sssd
> I never see the sssd.conf man page inclusion. Could anyone tell me what I am
> missing here?
> 
> If you feel there is better wording for the description please let me know.
> 
> Kind regards,
> Justin Stephenson

> From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 2001
> From: Justin Stephenson 
> Date: Fri, 26 Aug 2016 15:15:32 -0400
> Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink command-line option

I'm not sure I like removing the netlink option w/o letting admins who
use it at least know what happened. Could we keep the option in the popt
option list, but use the HIDDEN argument so that it doesn't show up in
--help output and print a loud warning that the option was removed in
favor of a sssd.conf option?

I already know of two people from sssd-users list who might be using
this feature. On the other hand, it was just introduced in the last
version and not in any enterprise distro, so just printing a warning and
removing even that warning in the next version would be fine for me..

> From c52c0c1a520cdf8509bac00fa3c7bec0dd73 Mon Sep 17 00:00:00 2001
> From: Justin Stephenson 
> Date: Fri, 26 Aug 2016 17:43:25 -0400
> Subject: [PATCH 2/2] MONITOR: Add disable_netlink option

LGTM, untested, though.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-08-30 Thread Petr Cech 

On 08/27/2016 06:54 PM, Justin Stephenson wrote:

Hello,

The attached patches resolve https://fedorahosted.org/sssd/ticket/3142

However, I am having difficult with the man page addition to
'src/man/sssd.conf.5.xml' for this new option. I have stared at the open
and close xml tags(for far too long) and it looks correct but when I
build sssd I never see the sssd.conf man page inclusion. Could anyone
tell me what I am missing here?

If you feel there is better wording for the description please let me know.

Kind regards,
Justin Stephenson


Hello Justin,

CI passed:
http://sssd-ci.duckdns.org/logs/job/52/72/summary.html

I have one little comment about coding style. See below.



0001-MONITOR-Remove-disable-netlink-command-line-option.patch


From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 15:15:32 -0400
Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink command-line option

Removing monitor command-line option, to be superceded by
sssd.conf option
---


ACK



0002-MONITOR-Add-disable_netlink-option.patch


From c52c0c1a520cdf8509bac00fa3c7bec0dd73 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 26 Aug 2016 17:43:25 -0400
Subject: [PATCH 2/2] MONITOR: Add disable_netlink option

Adding a new monitor boolean option to disable netlink support.
This will give users more control over sssd state changes without
having to modify systemd unit files.

Resolves:
https://fedorahosted.org/sssd/ticket/3142
---

[...]


 /* Set up the environment variable for the Kerberos Replay Cache */
@@ -2471,14 +2472,28 @@ static int monitor_process_init(struct mt_ctx *ctx,
 return ret;
 }

-ret = setup_netlink(ctx, ctx->ev, network_status_change_cb,
-ctx, >nlctx);
+ret = confdb_get_bool(ctx->cdb,
+  CONFDB_MONITOR_CONF_ENTRY,
+  CONFDB_MONITOR_DISABLE_NETLINK,
+  false, _netlink);
+
 if (ret != EOK) {
 DEBUG(SSSDBG_OP_FAILURE,
-  "Cannot set up listening for network notifications\n");
+"Failed to read disable_netlink from confdb: [%d] %s\n",

 ^ --- this is right indentation

+ret, sss_strerror(ret));

 ^ --- this is right indentation

Please, fix this little nitpicking.

I am not native speaker, I am not able check
text in man page. (I guess you are.)

The first patch ACKed, the second needs
little work.

Regards

--
Petr^4 Čech
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org