On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:
> Hello,
> 
> The attached patches resolve https://fedorahosted.org/sssd/ticket/3142
> 
> However, I am having difficult with the man page addition to
> 'src/man/sssd.conf.5.xml' for this new option. I have stared at the open and
> close xml tags(for far too long) and it looks correct but when I build sssd
> I never see the sssd.conf man page inclusion. Could anyone tell me what I am
> missing here?
> 
> If you feel there is better wording for the description please let me know.
> 
> Kind regards,
> Justin Stephenson

> From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 2001
> From: Justin Stephenson <jstep...@redhat.com>
> Date: Fri, 26 Aug 2016 15:15:32 -0400
> Subject: [PATCH 1/2]     MONITOR: Remove --disable-netlink command-line option

I'm not sure I like removing the netlink option w/o letting admins who
use it at least know what happened. Could we keep the option in the popt
option list, but use the HIDDEN argument so that it doesn't show up in
--help output and print a loud warning that the option was removed in
favor of a sssd.conf option?

I already know of two people from sssd-users list who might be using
this feature. On the other hand, it was just introduced in the last
version and not in any enterprise distro, so just printing a warning and
removing even that warning in the next version would be fine for me..

> From c52c0c1a520cdf8509baaaaac00fa3c7bec0dd73 Mon Sep 17 00:00:00 2001
> From: Justin Stephenson <jstep...@redhat.com>
> Date: Fri, 26 Aug 2016 17:43:25 -0400
> Subject: [PATCH 2/2]     MONITOR: Add disable_netlink option

LGTM, untested, though.
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

Reply via email to