DO NOT REPLY [Bug 17760] - [PATCH] unused imports in test folder

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17760

[PATCH] unused imports in test folder





--- Additional Comments From [EMAIL PROTECTED]  2003-03-07 06:08 ---
Okay... quite a few new unused imports were added tonight beyond what I 
initially found.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17760] - [PATCH] unused imports in test folder

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17760

[PATCH] unused imports in test folder





--- Additional Comments From [EMAIL PROTECTED]  2003-03-07 06:04 ---
Created an attachment (id=5198)
found another one

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [ANNOUNCE] Struts-JavaServer Faces [installation error]

[Matt Raible]

I installed struts-faces as recommended and found that I had to remove
commons-logging.jar from WEB-INF/lib when running on the following platform:

Tomcat 4.1.18
JDK 1.4.1_01
Windows 2000 SP3

Here's the stack trace from the startup:

2003-03-06 22:35:27 StandardContext[/struts-faces]: Error configuring
application listener of class org.apache.struts.faces.taglib.LifecycleListener
java.lang.ExceptionInInitializerError
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance(Constructor.java:274)
at java.lang.Class.newInstance0(Class.java:306)
at java.lang.Class.newInstance(Class.java:259)
at
org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:3237)
at org.apache.catalina.core.StandardContext.start(StandardContext.java:3598)
at
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:821)
at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:807)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:579)
at
org.apache.catalina.core.StandardHostDeployer.install(StandardHostDeployer.java:257)
at org.apache.catalina.core.StandardHost.install(StandardHost.java:772)
at 
org.apache.catalina.startup.HostConfig.deployDirectories(HostConfig.java:569)
at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:411)
at org.apache.catalina.startup.HostConfig.start(HostConfig.java:879)
at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:368)
at
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:166)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1196)
at org.apache.catalina.core.StandardHost.start(StandardHost.java:738)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188)
at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:347)
at org.apache.catalina.core.StandardService.start(StandardService.java:497)
at org.apache.catalina.core.StandardServer.start(StandardServer.java:2189)
at org.apache.catalina.startup.Catalina.start(Catalina.java:512)
at org.apache.catalina.startup.Catalina.execute(Catalina.java:400)
at org.apache.catalina.startup.Catalina.process(Catalina.java:180)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:203)
Caused by: org.apache.commons.logging.LogConfigurationException:
org.apache.commons.logging.LogConfigurationException:
org.apache.commons.logging.LogConfigurationException: Class
org.apache.commons.logging.impl.Jdk14Logger does not implement Log
at
org.apache.commons.logging.impl.LogFactoryImpl.newInstance(LogFactoryImpl.java:568)
at
org.apache.commons.logging.impl.LogFactoryImpl.getInstance(LogFactoryImpl.java:292)
at
org.apache.commons.logging.impl.LogFactoryImpl.getInstance(LogFactoryImpl.java:265)
at org.apache.commons.logging.LogFactory.getLog(LogFactory.java:395)
at
org.apache.struts.faces.taglib.LifecycleListener.(LifecycleListener.java:117)
... 32 more
Caused by: org.apache.commons.logging.LogConfigurationException:
org.apache.commons.logging.LogConfigurationException: Class
org.apache.commons.logging.impl.Jdk14Logger does not implement Log
at
org.apache.commons.logging.impl.LogFactoryImpl.getLogConstructor(LogFactoryImpl.java:434)
at
org.apache.commons.logging.impl.LogFactoryImpl.newInstance(LogFactoryImpl.java:561)
... 36 more
Caused by: org.apache.commons.logging.LogConfigurationException: Class
org.apache.commons.logging.impl.Jdk14Logger does not implement Log
at
org.apache.commons.logging.impl.LogFactoryImpl.getLogConstructor(LogFactoryImpl.java:430)
... 37 more

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17761] - TestErrorsTag1 & TestErrorsTag2 do not use formatAndTest() method

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17761

TestErrorsTag1 & TestErrorsTag2 do not use formatAndTest() method





--- Additional Comments From [EMAIL PROTECTED]  2003-03-07 05:44 ---
Fixed in the 20030307 nightly build

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/html TestImageTag1.jsp TestImageTag2.jsp TestImageTag3.jsp TestImageTag4.jsp

[jmitchell]

jmitchell2003/03/06 21:41:28

  Added:   src/test/org/apache/struts/taglib/html TestImageTag1.java
TestImageTag2.java TestImageTag3.java
TestImageTag4.java
   web/test/test/org/apache/struts/taglib/html
TestImageTag1.jsp TestImageTag2.jsp
TestImageTag3.jsp TestImageTag4.jsp
  Log:
  Adding more tests
  
  Revision  ChangesPath
  1.1  
jakarta-struts/src/test/org/apache/struts/taglib/html/TestImageTag1.java
  
  Index: TestImageTag1.java
  ===
  /*
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999-2003 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Struts", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   */
  package org.apache.struts.taglib.html;
  
  import java.util.ArrayList;
  import java.util.HashMap;
  import java.util.Locale;
  import java.util.StringTokenizer;
  
  import javax.servlet.jsp.PageContext;
  import junit.framework.Test;
  import junit.framework.TestSuite;
  
  import org.apache.cactus.JspTestCase;
  import org.apache.struts.Globals;
  import org.apache.struts.taglib.SimpleBeanForTesting;
  
  /**
   * Suite of unit tests for the
   * org.apache.struts.taglib.bean.ImageTag class.
   *
   * @author James Mitchell
   */
  public class TestImageTag1 extends JspTestCase {
  
  /**
   * Defines the testcase name for JUnit.
   *
   * @param theName the testcase's name.
   */
  public TestImageTag1(String theName) {
  super(theName);
  }
  
  /**
   * Start the tests.
   *
   * @param theArgs the arguments. Not used
   */
  public static void main(String[] theArgs) {
  junit.awtui.TestRunner.main(new String[] {TestImageTag1.class.getName()});
  }
  
  /**
   * @return a test suite (TestSuite) that includes all methods
   * starting with "test"
   */
  public static Test suite() {
  // All methods starting with "test" will be executed in the test suite.
  return new TestSuite(TestImageTag1.class);
  }
  
  private void runMyTest(String whichTest, String locale){
pageContext.setAttribute(Globals.LOCALE_KEY, new Locale(locale, locale), 
PageContext.SESSION_SCOPE);
pageContext.setAttribute(Constants.BEAN_KEY, new SimpleBeanForTesting("Test 
Value"), PageContext.REQUEST_SCOPE);
   

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/html TestHtmlTag.jsp

[jmitchell]

jmitchell2003/03/06 21:40:59

  Added:   src/test/org/apache/struts/taglib/html TestHtmlTag.java
   web/test/test/org/apache/struts/taglib/html TestHtmlTag.jsp
  Log:
  Adding more tests
  
  Revision  ChangesPath
  1.1  
jakarta-struts/src/test/org/apache/struts/taglib/html/TestHtmlTag.java
  
  Index: TestHtmlTag.java
  ===
  /*
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999-2003 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Struts", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   */
  package org.apache.struts.taglib.html;
  
  import java.util.Locale;
  
  import javax.servlet.jsp.PageContext;
  import junit.framework.Test;
  import junit.framework.TestSuite;
  
  import org.apache.cactus.JspTestCase;
  import org.apache.struts.Globals;
  import org.apache.struts.taglib.SimpleBeanForTesting;
  
  /**
   * Suite of unit tests for the
   * org.apache.struts.taglib.bean.HtmlTag class.
   *
   * @author James Mitchell
   */
  public class TestHtmlTag extends JspTestCase {
  
  /**
   * Defines the testcase name for JUnit.
   *
   * @param theName the testcase's name.
   */
  public TestHtmlTag(String theName) {
  super(theName);
  }
  
  /**
   * Start the tests.
   *
   * @param theArgs the arguments. Not used
   */
  public static void main(String[] theArgs) {
  junit.awtui.TestRunner.main(new String[] {TestHtmlTag.class.getName()});
  }
  
  /**
   * @return a test suite (TestSuite) that includes all methods
   * starting with "test"
   */
  public static Test suite() {
  // All methods starting with "test" will be executed in the test suite.
  return new TestSuite(TestHtmlTag.class);
  }
  
  private void runMyTest(String whichTest, String locale){
pageContext.setAttribute(Globals.LOCALE_KEY, new Locale(locale, locale), 
PageContext.SESSION_SCOPE);
pageContext.setAttribute(Constants.BEAN_KEY, new SimpleBeanForTesting("Test 
Value"), PageContext.REQUEST_SCOPE);
request.setAttribute("runTest", whichTest);
  try {

pageContext.forward("/test/org/apache/struts/taglib/html/TestHtmlTag.jsp");
}
catch (Exception e) {
e.printStackTrace();
fail("There is a problem that i

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/html TestHiddenTag1.jsp TestHiddenTag2.jsp

[jmitchell]

jmitchell2003/03/06 21:40:38

  Added:   src/test/org/apache/struts/taglib/html TestHiddenTag1.java
TestHiddenTag2.java
   web/test/test/org/apache/struts/taglib/html
TestHiddenTag1.jsp TestHiddenTag2.jsp
  Log:
  Adding more tests
  
  Revision  ChangesPath
  1.1  
jakarta-struts/src/test/org/apache/struts/taglib/html/TestHiddenTag1.java
  
  Index: TestHiddenTag1.java
  ===
  /*
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999-2003 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Struts", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   */
  package org.apache.struts.taglib.html;
  
  import java.util.Locale;
  
  import javax.servlet.jsp.PageContext;
  import junit.framework.Test;
  import junit.framework.TestSuite;
  
  import org.apache.cactus.JspTestCase;
  import org.apache.struts.Globals;
  import org.apache.struts.taglib.SimpleBeanForTesting;
  
  /**
   * Suite of unit tests for the
   * org.apache.struts.taglib.bean.HiddenTag class.
   *
   * @author James Mitchell
   */
  public class TestHiddenTag1 extends JspTestCase {
  
  /**
   * Defines the testcase name for JUnit.
   *
   * @param theName the testcase's name.
   */
  public TestHiddenTag1(String theName) {
  super(theName);
  }
  
  /**
   * Start the tests.
   *
   * @param theArgs the arguments. Not used
   */
  public static void main(String[] theArgs) {
  junit.awtui.TestRunner.main(new String[] {TestHiddenTag1.class.getName()});
  }
  
  /**
   * @return a test suite (TestSuite) that includes all methods
   * starting with "test"
   */
  public static Test suite() {
  // All methods starting with "test" will be executed in the test suite.
  return new TestSuite(TestHiddenTag1.class);
  }
  
  private void runMyTest(String whichTest, String locale){
pageContext.setAttribute(Globals.LOCALE_KEY, new Locale(locale, locale), 
PageContext.SESSION_SCOPE);
pageContext.setAttribute(Constants.BEAN_KEY, new SimpleBeanForTesting("Test 
Value"), PageContext.REQUEST_SCOPE);
request.setAttribute("runTest", whichTest);
  try {

pageContext.forward("/test/org/apache/struts/taglib/html/TestHiddenTag1.jsp");
}
catch 

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/html TestFormTag1.jsp

[jmitchell]

jmitchell2003/03/06 21:38:24

  Added:   src/test/org/apache/struts/taglib/html TestFormTag1.java
   web/test/test/org/apache/struts/taglib/html TestFormTag1.jsp
  Log:
  Adding more tests
  
  Revision  ChangesPath
  1.1  
jakarta-struts/src/test/org/apache/struts/taglib/html/TestFormTag1.java
  
  Index: TestFormTag1.java
  ===
  /*
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999-2003 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Struts", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   */
  package org.apache.struts.taglib.html;
  
  import java.util.Locale;
  
  import javax.servlet.jsp.JspException;
  import javax.servlet.jsp.PageContext;
  import junit.framework.Test;
  import junit.framework.TestSuite;
  
  import org.apache.cactus.JspTestCase;
  import org.apache.struts.Globals;
  import org.apache.struts.taglib.SimpleBeanForTesting;
  
  /**
   * Suite of unit tests for the
   * org.apache.struts.taglib.bean.FormTag class.
   *
   * @author James Mitchell
   */
  public class TestFormTag1 extends JspTestCase {
  
  /**
   * Defines the testcase name for JUnit.
   *
   * @param theName the testcase's name.
   */
  public TestFormTag1(String theName) {
  super(theName);
  }
  
  /**
   * Start the tests.
   *
   * @param theArgs the arguments. Not used
   */
  public static void main(String[] theArgs) {
  junit.awtui.TestRunner.main(new String[] {TestFormTag1.class.getName()});
  }
  
  /**
   * @return a test suite (TestSuite) that includes all methods
   * starting with "test"
   */
  public static Test suite() {
  // All methods starting with "test" will be executed in the test suite.
  return new TestSuite(TestFormTag1.class);
  }
  
  private void runMyTest(String whichTest, String locale){
pageContext.setAttribute(Globals.LOCALE_KEY, new Locale(locale, locale), 
PageContext.SESSION_SCOPE);
pageContext.setAttribute(Constants.BEAN_KEY, new SimpleBeanForTesting("Test 
Value"), PageContext.REQUEST_SCOPE);
request.setAttribute("runTest", whichTest);
  try {

pageContext.forward("/test/org/apache/struts/taglib/html/TestFormTag1.jsp");
}
catch (Exception e) {
e.printStackTrace();
 

cvs commit: jakarta-struts/conf/test struts-config.xml

[jmitchell]

jmitchell2003/03/06 21:35:02

  Modified:conf/test struts-config.xml
  Log:
  changes to support more tests
  
  Revision  ChangesPath
  1.8   +13 -2 jakarta-struts/conf/test/struts-config.xml
  
  Index: struts-config.xml
  ===
  RCS file: /home/cvs/jakarta-struts/conf/test/struts-config.xml,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- struts-config.xml 28 Feb 2003 01:11:32 -  1.7
  +++ struts-config.xml 7 Mar 2003 05:35:02 -   1.8
  @@ -22,7 +22,7 @@
   
   
   
  +type="org.apache.struts.taglib.SimpleBeanForTesting"/>
   
   
 
  @@ -34,6 +34,9 @@
   
  + 
  + 

   
  @@ -45,7 +48,15 @@
   
 
  +
path="/test/org/apache/struts/taglib/bean/resources/IncludeTagTest.jsp"/>
  +
  +
  +
  +  
   
   
 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/bean TestParameterTag.jsp

[jmitchell]

jmitchell2003/03/06 21:31:30

  Modified:src/test/org/apache/struts/taglib SimpleBeanForTesting.java
   src/test/org/apache/struts/taglib/bean TestParameterTag.java
   src/test/org/apache/struts/taglib/html TestErrorsTag1.java
TestErrorsTag2.java
   src/test/org/apache/struts/taglib/logic
TestGreaterEqualTag.java TestGreaterThanTag.java
TestLessEqualTag.java TestLessThanTag.java
TestPresentTag.java
   web/test/test/org/apache/struts/taglib/bean
TestParameterTag.jsp
  Log:
  copyright and other needed additions for tests
  
  Revision  ChangesPath
  1.4   +52 -16
jakarta-struts/src/test/org/apache/struts/taglib/SimpleBeanForTesting.java
  
  Index: SimpleBeanForTesting.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/SimpleBeanForTesting.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- SimpleBeanForTesting.java 28 Feb 2003 01:11:32 -  1.3
  +++ SimpleBeanForTesting.java 7 Mar 2003 05:31:30 -   1.4
  @@ -60,39 +60,43 @@
   import java.util.List;
   import java.util.Map;
   
  +import org.apache.struts.action.ActionForm;
  +
   /**
* Simple bean for unit tests. 
*
* @author James Mitchell
*/
  -public class SimpleBeanForTesting {
  - public SimpleBeanForTesting(){
  +public class SimpleBeanForTesting extends ActionForm {
  + public SimpleBeanForTesting() {
super();
}
  - public SimpleBeanForTesting(List lst){
  + public SimpleBeanForTesting(List lst) {
this.lst = lst;
}
  - public SimpleBeanForTesting(boolean checked){
  + public SimpleBeanForTesting(boolean checked) {
this.checked = checked;
}
  - public SimpleBeanForTesting(Boolean checked){
  + public SimpleBeanForTesting(Boolean checked) {
this.checkedWrapper = checkedWrapper;
}
  - public SimpleBeanForTesting(Map map){
  + public SimpleBeanForTesting(Map map) {
this.map = map;
}
  - public SimpleBeanForTesting(String string){
  + public SimpleBeanForTesting(String string) {
this.string = string;
}
  - public SimpleBeanForTesting(Integer integerValue){
  + public SimpleBeanForTesting(Integer integerValue) {
this.integerValue = integerValue;
}
   
  - private String string;  
  + private String string;
private Integer integerValue;
private Double doubleValue;
private List lst;
private Map map;
  + private String x;
  + private String y;
private Object nestedObject;
private Object[] array;
private Enumeration enumeration;
  @@ -102,14 +106,14 @@
   
//Copied right from the FAQ
private String strAry[] =
  - { "String 0", "String 1", "String 2", "String 3", "String 4" };
  + { "String 0", "String 1", "String 2", "String 3", "String 4" };
   
  -public String getStringIndexed(int index) { 
  - return (strAry[index]); 
  -}
  -public void setStringIndexed(int index, String value){ 
  - strAry[index] = value; 
  -}
  + public String getStringIndexed(int index) {
  + return (strAry[index]);
  + }
  + public void setStringIndexed(int index, String value) {
  + strAry[index] = value;
  + }
   
/**
 * Returns the lst.
  @@ -301,6 +305,38 @@
 */
public void setCheckedWrapper(Boolean checkedWrapper) {
this.checkedWrapper = checkedWrapper;
  + }
  +
  + /**
  +  * Returns the x.
  +  * @return String
  +  */
  + public String getX() {
  + return x;
  + }
  +
  + /**
  +  * Returns the y.
  +  * @return String
  +  */
  + public String getY() {
  + return y;
  + }
  +
  + /**
  +  * Sets the x.
  +  * @param x The x to set
  +  */
  + public void setX(String x) {
  + this.x = x;
  + }
  +
  + /**
  +  * Sets the y.
  +  * @param y The y to set
  +  */
  + public void setY(String y) {
  + this.y = y;
}
   
   }
  
  
  
  1.4   +5 -1  
jakarta-struts/src/test/org/apache/struts/taglib/bean/TestParameterTag.java
  
  Index: TestParameterTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/TestParameterTag.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- TestParameterTag.java 6 Mar 2003 02:42:17 -   1.3
  +++ TestParameterTag.java 7 Mar 2003 05:31:30 -   1.4
  @@ -61,6 +61,7

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/html TestFileTag1.jsp TestFileTag2.jsp

[jmitchell]

jmitchell2003/03/06 21:28:51

  Modified:web/test/test/org/apache/struts/taglib/html TestFileTag1.jsp
TestFileTag2.jsp
  Log:
  fix to help better determine what errors are when tests fail...but
  we all know that's not going to happen ;D
  
  Revision  ChangesPath
  1.2   +13 -8 
jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestFileTag1.jsp
  
  Index: TestFileTag1.jsp
  ===
  RCS file: 
/home/cvs/jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestFileTag1.jsp,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TestFileTag1.jsp  1 Mar 2003 06:00:13 -   1.1
  +++ TestFileTag1.jsp  7 Mar 2003 05:28:51 -   1.2
  @@ -13,9 +13,6 @@

   

  - enctype="multipart/form-data" 
  - accept="image/jpeg, image/gif"
  - 
   


  @@ -242,10 +239,18 @@
   
   
   
  -
   <% 
  -Assert.assertEquals(
  - pageContext.getAttribute("TEST_RESULTS").toString(), 
  - pageContext.getAttribute("EXPECTED_RESULTS").toString()
  - );
  +String expected = "";
  +String compareTo = "";
  +
  +if (pageContext.getAttribute("EXPECTED_RESULTS") == null){
  +throw new JspException("No tests on this page were called.  Please verify that 
you've setup the tests correctly.");
  +}else{
  + expected=pageContext.getAttribute("TEST_RESULTS").toString();
  +}
  +if (pageContext.getAttribute("TEST_RESULTS") != null){
  + compareTo=pageContext.getAttribute("EXPECTED_RESULTS").toString();
  +}
  +
  +Assert.assertEquals(compareTo, expected);
   %>
  
  
  
  1.2   +12 -5 
jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestFileTag2.jsp
  
  Index: TestFileTag2.jsp
  ===
  RCS file: 
/home/cvs/jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestFileTag2.jsp,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TestFileTag2.jsp  1 Mar 2003 06:00:13 -   1.1
  +++ TestFileTag2.jsp  7 Mar 2003 05:28:51 -   1.2
  @@ -195,11 +195,18 @@
   
   
   
  +<% 
  +String expected = "";
  +String compareTo = "";
   
  +if (pageContext.getAttribute("EXPECTED_RESULTS") == null){
  +throw new JspException("No tests on this page were called.  Please verify that 
you've setup the tests correctly.");
  +}else{
  + expected=pageContext.getAttribute("TEST_RESULTS").toString();
  +}
  +if (pageContext.getAttribute("TEST_RESULTS") != null){
  + compareTo=pageContext.getAttribute("EXPECTED_RESULTS").toString();
  +}
   
  -<% 
  -Assert.assertEquals(
  - pageContext.getAttribute("TEST_RESULTS").toString(), 
  - pageContext.getAttribute("EXPECTED_RESULTS").toString()
  - );
  +Assert.assertEquals(compareTo, expected);
   %>
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/html TestBaseTag.jsp TestButtonTag1.jsp TestButtonTag2.jsp TestCancelTag1.jsp TestCancelTag2.jsp TestCheckboxTag1.jsp TestCheckboxTag2.jsp TestCheckboxTag3.jsp TestCheckboxTag4.jsp TestErrorsTag1.jsp TestErrorsTag2.jsp

[jmitchell]

jmitchell2003/03/06 21:27:20

  Modified:web/test/test/org/apache/struts/taglib/html TestBaseTag.jsp
TestButtonTag1.jsp TestButtonTag2.jsp
TestCancelTag1.jsp TestCancelTag2.jsp
TestCheckboxTag1.jsp TestCheckboxTag2.jsp
TestCheckboxTag3.jsp TestCheckboxTag4.jsp
TestErrorsTag1.jsp TestErrorsTag2.jsp
  Log:
  fix to help better determine what errors are when tests fail...but
  we all know that's not going to happen ;D
  
  Revision  ChangesPath
  1.2   +13 -4 
jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestBaseTag.jsp
  
  Index: TestBaseTag.jsp
  ===
  RCS file: 
/home/cvs/jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestBaseTag.jsp,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TestBaseTag.jsp   27 Feb 2003 02:18:44 -  1.1
  +++ TestBaseTag.jsp   7 Mar 2003 05:27:19 -   1.2
  @@ -48,8 +48,17 @@
   
   
   <% 
  -Assert.assertEquals(
  - pageContext.getAttribute("TEST_RESULTS").toString(), 
  - pageContext.getAttribute("EXPECTED_RESULTS").toString()
  - );
  +String expected = "";
  +String compareTo = "";
  +
  +if (pageContext.getAttribute("EXPECTED_RESULTS") == null){
  +throw new JspException("No tests on this page were called.  Please verify that 
you've setup the tests correctly.");
  +}else{
  + expected=pageContext.getAttribute("TEST_RESULTS").toString();
  +}
  +if (pageContext.getAttribute("TEST_RESULTS") != null){
  + compareTo=pageContext.getAttribute("EXPECTED_RESULTS").toString();
  +}
  +
  +Assert.assertEquals(compareTo, expected);
   %>
  
  
  
  1.2   +13 -5 
jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestButtonTag1.jsp
  
  Index: TestButtonTag1.jsp
  ===
  RCS file: 
/home/cvs/jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestButtonTag1.jsp,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TestButtonTag1.jsp28 Feb 2003 01:11:38 -  1.1
  +++ TestButtonTag1.jsp7 Mar 2003 05:27:19 -   1.2
  @@ -230,10 +230,18 @@
   
   
   
  -
   <% 
  -Assert.assertEquals(
  - pageContext.getAttribute("TEST_RESULTS").toString(), 
  - pageContext.getAttribute("EXPECTED_RESULTS").toString()
  - );
  +String expected = "";
  +String compareTo = "";
  +
  +if (pageContext.getAttribute("EXPECTED_RESULTS") == null){
  +throw new JspException("No tests on this page were called.  Please verify that 
you've setup the tests correctly.");
  +}else{
  + expected=pageContext.getAttribute("TEST_RESULTS").toString();
  +}
  +if (pageContext.getAttribute("TEST_RESULTS") != null){
  + compareTo=pageContext.getAttribute("EXPECTED_RESULTS").toString();
  +}
  +
  +Assert.assertEquals(compareTo, expected);
   %>
  
  
  
  1.3   +13 -5 
jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestButtonTag2.jsp
  
  Index: TestButtonTag2.jsp
  ===
  RCS file: 
/home/cvs/jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestButtonTag2.jsp,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- TestButtonTag2.jsp27 Feb 2003 04:39:43 -  1.2
  +++ TestButtonTag2.jsp7 Mar 2003 05:27:19 -   1.3
  @@ -196,10 +196,18 @@
   
   
   
  -
   <% 
  -Assert.assertEquals(
  - pageContext.getAttribute("TEST_RESULTS").toString(), 
  - pageContext.getAttribute("EXPECTED_RESULTS").toString()
  - );
  +String expected = "";
  +String compareTo = "";
  +
  +if (pageContext.getAttribute("EXPECTED_RESULTS") == null){
  +throw new JspException("No tests on this page were called.  Please verify that 
you've setup the tests correctly.");
  +}else{
  + expected=pageContext.getAttribute("TEST_RESULTS").toString();
  +}
  +if (pageContext.getAttribute("TEST_RESULTS") != null){
  + compareTo=pageContext.getAttribute("EXPECTED_RESULTS").toString();
  +}
  +
  +Assert.assertEquals(compareTo, expected);
   %>
  
  
  
  1.2   +13 -5 
jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestCancelTag1.jsp
  
  Index: TestCancelTag1.jsp
  ===
  RCS file: 
/home/cvs/jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestCancelTag1.jsp,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TestCancelTag1.jsp28 Feb 2003 01:11:38 -  1.1
  +++ TestCancelTag1.jsp7 Mar 2003 05:27:19 -   1.2
  @@ -230,10 +230,18 @@
   
   
   
  -
   <% 
  -Assert.assertEquals(
  - pageContext.getAttribute("TEST_RESULTS").toString(), 
  - pageContext.getAttribute("EXPECTED_RESUL

cvs commit: jakarta-struts/src/test/org/apache/struts/taglib/bean/resources AlternateApplicationResources.properties AlternateApplicationResources_fr.properties ApplicationResources.properties ApplicationResources_fr.properties

[jmitchell]

jmitchell2003/03/06 21:14:34

  Modified:src/test/org/apache/struts/taglib/bean/resources
AlternateApplicationResources.properties
AlternateApplicationResources_fr.properties
ApplicationResources.properties
ApplicationResources_fr.properties
  Log:
  adding new values for new tests
  
  Revision  ChangesPath
  1.3   +3 -1  
jakarta-struts/src/test/org/apache/struts/taglib/bean/resources/AlternateApplicationResources.properties
  
  Index: AlternateApplicationResources.properties
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/resources/AlternateApplicationResources.properties,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- AlternateApplicationResources.properties  28 Feb 2003 01:11:33 -  1.2
  +++ AlternateApplicationResources.properties  7 Mar 2003 05:14:33 -   1.3
  @@ -12,4 +12,6 @@
   errors.prefix=
   errors.suffix=
   alternate.testing.errors.tag=My Alternate Errors Text
  -alternate.testing.errors.tag2=My Alternate Errors Text 2
  \ No newline at end of file
  +alternate.testing.errors.tag2=My Alternate Errors Text 2
  +
  +alternate.testing.image=/images/default/alternate/myimage.gif
  
  
  
  1.3   +3 -1  
jakarta-struts/src/test/org/apache/struts/taglib/bean/resources/AlternateApplicationResources_fr.properties
  
  Index: AlternateApplicationResources_fr.properties
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/resources/AlternateApplicationResources_fr.properties,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- AlternateApplicationResources_fr.properties   28 Feb 2003 01:11:33 - 
 1.2
  +++ AlternateApplicationResources_fr.properties   7 Mar 2003 05:14:34 -  
 1.3
  @@ -12,4 +12,6 @@
   errors.prefix=
   errors.suffix=
   alternate.testing.errors.tag=My Alternate Errors Text (fr)
  -alternate.testing.errors.tag2=My Alternate Errors Text 2 (fr)
  \ No newline at end of file
  +alternate.testing.errors.tag2=My Alternate Errors Text 2 (fr)
  +
  +alternate.testing.image=/images/fr/alternate/myimage.gif
  
  
  
  1.3   +3 -1  
jakarta-struts/src/test/org/apache/struts/taglib/bean/resources/ApplicationResources.properties
  
  Index: ApplicationResources.properties
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/resources/ApplicationResources.properties,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ApplicationResources.properties   28 Feb 2003 01:11:33 -  1.2
  +++ ApplicationResources.properties   7 Mar 2003 05:14:34 -   1.3
  @@ -12,4 +12,6 @@
   errors.prefix=
   errors.suffix=
   default.testing.errors.tag=My Errors Text
  -default.testing.errors.tag2=My Errors Text 2
  \ No newline at end of file
  +default.testing.errors.tag2=My Errors Text 2
  +
  +default.testing.image=/images/default/default/myimage.gif
  
  
  
  1.3   +3 -1  
jakarta-struts/src/test/org/apache/struts/taglib/bean/resources/ApplicationResources_fr.properties
  
  Index: ApplicationResources_fr.properties
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/resources/ApplicationResources_fr.properties,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ApplicationResources_fr.properties28 Feb 2003 01:11:33 -  1.2
  +++ ApplicationResources_fr.properties7 Mar 2003 05:14:34 -   1.3
  @@ -12,4 +12,6 @@
   errors.prefix=
   errors.suffix=
   default.testing.errors.tag=My Errors Text (fr)
  -default.testing.errors.tag2=My Errors Text 2 (fr)
  \ No newline at end of file
  +default.testing.errors.tag2=My Errors Text 2 (fr)
  +
  +default.testing.image=/images/fr/default/myimage.gif
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Missing message for key index.title

[srikanth madduri]

 hi I am new to Struts
 
 I got stuck when I have added index.title in the
 applicationresources.properties file and after
 compiling i got the following error.I am trying to
 find the solution in the internet from where got
 landed up here at last.I have all the jar files in
 the
 lib directory of my application.

Thanks in advance

Regards
-Sri
 
 
 org.apache.jasper.JasperException: Missing message
 for
 key index.title
at

org.apache.jasper.servlet.JspServletWrapper.serviceJspServletWrapper.java:248)>
at

org.apache.jasper.servet.JspServlet.serviceJspFile(JspServlet.java:295)
at

org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241)
> 
> 
> 
> __
> Do you Yahoo!?
> Yahoo! Tax Center - forms, calculators, tips, more
> http://taxes.yahoo.com/
> 
>
-
> To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> For additional commands, e-mail:
> [EMAIL PROTECTED]
> 


__
Do you Yahoo!?
Yahoo! Tax Center - forms, calculators, tips, more
http://taxes.yahoo.com/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Correct procedure for reporting bugs?

[srikanth madduri]

hi I am new to Struts

I got stuck when I have added index.title in the
applicationresources.properties file and after
compiling i got the following error.I am trying to
find the solution in the internet from where got
landed up here at last.I have all the jar files in the
lib directory of my application.


org.apache.jasper.JasperException: Missing message for
key index.title
at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:248)
at
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:295)
at
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241)



__
Do you Yahoo!?
Yahoo! Tax Center - forms, calculators, tips, more
http://taxes.yahoo.com/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17761] - TestErrorsTag1 & TestErrorsTag2 do not use formatAndTest() method

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17761

TestErrorsTag1 & TestErrorsTag2 do not use formatAndTest() method





--- Additional Comments From [EMAIL PROTECTED]  2003-03-07 05:02 ---
This method seems to be unused in the TestBaseTag class from the same package.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/src/share/org/apache/struts/actions ForwardAction.java

[jmitchell]

jmitchell2003/03/06 21:00:21

  Modified:src/share/org/apache/struts/actions ForwardAction.java
  Log:
  fix javadoc
  
  Revision  ChangesPath
  1.7   +5 -5  
jakarta-struts/src/share/org/apache/struts/actions/ForwardAction.java
  
  Index: ForwardAction.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/actions/ForwardAction.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ForwardAction.java8 Dec 2002 07:12:16 -   1.6
  +++ ForwardAction.java7 Mar 2003 05:00:20 -   1.7
  @@ -89,7 +89,7 @@
*   name="subscriptionForm"
*  scope="request"
*  input="/subscription.jsp"
  - *  parameter="/path/to/processing/servlet">
  + *  parameter="/path/to/processing/servlet"/>
* 
*
* which will forward control to the context-relative URI specified by the
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17761] New: - TestErrorsTag1 & TestErrorsTag2 do not use formatAndTest() method

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17761

TestErrorsTag1 & TestErrorsTag2 do not use formatAndTest() method

   Summary: TestErrorsTag1 & TestErrorsTag2 do not use
formatAndTest() method
   Product: Struts
   Version: Nightly Build
  Platform: All
OS/Version: All
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Test
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The org.apache.struts.taglib.html.TestErrorsTag1 & 
org.apache.struts.taglib.html.TestErrorsTag2 classes each have a method called 
formatAndTest that they do not use.  Here is the code from each class:

private void formatAndTest(String compare, String output) {
//fix for introduced carriage return / line feeds
output = output.replaceAll("\r","");
output = output.replaceAll("\n","");
output = output.trim();
assertEquals(compare, output);
}

Are there plans to use these methods still?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/doc/userGuide configuration.xml

[jmitchell]

jmitchell2003/03/06 20:50:42

  Modified:doc/userGuide configuration.xml
  Log:
  Fix bad link
  
  Revision  ChangesPath
  1.18  +1 -1  jakarta-struts/doc/userGuide/configuration.xml
  
  Index: configuration.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/userGuide/configuration.xml,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- configuration.xml 2 Feb 2003 00:50:04 -   1.17
  +++ configuration.xml 7 Mar 2003 04:50:41 -   1.18
  @@ -450,7 +450,7 @@
   
   
   In Struts 1.1, you have two options: you can list 
  -multiple struts-config files as a 
  +multiple struts-config files as a 
   comma-delimited list, or you can subdivide a larger application into 
   modules.
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/doc/news news_2002_q4.xml

[jmitchell]

jmitchell2003/03/06 20:49:52

  Modified:doc/news news_2002_q4.xml
  Log:
  Update email
  
  Revision  ChangesPath
  1.4   +1 -1  jakarta-struts/doc/news/news_2002_q4.xml
  
  Index: news_2002_q4.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/news/news_2002_q4.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- news_2002_q4.xml  19 Feb 2003 00:26:49 -  1.3
  +++ news_2002_q4.xml  7 Mar 2003 04:49:52 -   1.4
  @@ -899,7 +899,7 @@
   
   
   If anyone is REALLY itching to get their hands on it sooner, send me a
  -mailto:[EMAIL PROTECTED]">email.
  +mailto:[EMAIL PROTECTED]">email.
   
   
   For those who were waiting, thanks for your patience.
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17760] - [PATCH] unused imports in test folder

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17760

[PATCH] unused imports in test folder





--- Additional Comments From [EMAIL PROTECTED]  2003-03-07 04:46 ---
Created an attachment (id=5197)
patch addresses bug report

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17760] New: - [PATCH] unused imports in test folder

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17760

[PATCH] unused imports in test folder

   Summary: [PATCH] unused imports in test folder
   Product: Struts
   Version: Nightly Build
  Platform: All
OS/Version: All
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Test
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Still a couple unused imports left.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [ANNOUNCE] Struts-JavaServer Faces Integration Library -- EarlyAccess Version Now Available

[Craig R. McClanahan]

On Thu, 6 Mar 2003, Matt Raible wrote:

> Date: Thu, 6 Mar 2003 21:28:38 -0700
> From: Matt Raible <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: Struts Developers List <[EMAIL PROTECTED]>
> Subject: Re: [ANNOUNCE] Struts-JavaServer Faces Integration Library --
> Early Access Version Now Available
>
> Very Cool!  But...
>
> You don't have permission to access
> /builds/jakarta-struts/nightly/struts-faces/jakarta-struts-faces-20030306.zip
> on this server.
> Apache/2.1.0-dev (Unix) SVN/0.16.1 (dev build) DAV/2 Server at cvs.apache.org
> Port 80
>

Grumble grumble ... scp ignored my umask and set 600 permissions ;-(.

Fixed now.

Craig

>
> > I'm happy to announce the immediate availability of an integration library
> > that allows you to use the recently published EA3 release of JavaServer
> > Faces <http://java.sun.com/j2ee/javaserverfaces/> with a recent
> > Struts build (nightly build 20030216 or later, or the upcoming 1.1-
> > rc2 or final release).  Nightly builds of this package are available
> > at:
> >
> >   http://jakarta.apache.org/builds/jakarta-struts/nightly/struts-faces/
> >
> > The sources for this package are in the "contrib/struts-faces"
> > subdirectory of the "jakarta-struts" CVS repository.
> >
> > You should take note of the following important points:
> >
> > * The design goal of this library was to allow Struts application
> >   developers to migrate the view tier of their applications from the
> >   existing Struts tags, to pages that use corresponding JavaServer Faces
> >   component tags, with no changes to the corresponding business
> > logic.  This goal has been substantially achieved for simple applications
> >   so far; additional work will be necessary for more advanced apps.
> >   As a proof of concept, the JavaServer Faces based version of the
> >   canonical "struts-example" web application is included in the
> >   distribution, so that you can see for yourself how little had to be
> >   changed.
> >
> > * The integration library has been tested under Tomcat 4.1.18 and
> >   the Java Web Services Developer Pack (version 1.0_01), although in
> >   principle it should run on any Servlet 2.3/JSP 1.2 container.
> >   (It will not run on Servlet 2.2/JSP 1.1 containers).
> >
> > * There is a known issue when trying to run JavaServer Faces EA3
> >   under the recently released Java Web Services Developer Pack
> >   (version 1.1).  Watch the JavaServer Faces web page (at the URL
> >   listed above) for up-to-date information on workarounds.
> >
> > * The JavaServer Faces distribution is an EA release, not suitable
> > for  use in production environments.  In addition, the license terms
> >  under which it can be downloaded prohibit redistribution.
> >  Therefore,  you will need to download your own copy of JavaServer
> > Faces EA3 and  integrate it with the example application before it
> > can be deployed.
> >
> > * The integration library should also be considered to be of alpha
> >   quality, not suitable for production use.  There are a set of known
> >   issues and limitations at the bottom of the README.txt file.
> >  Please  file bugs against this package in the usual Bugzilla location:
> >
> > http://nagoya.apache.org/bugzilla/
> >
> > * For generic questions about JavaServer Faces (i.e. not related to this
> >   integration library), your best resource is the JavaServer Faces forum
> >   (free registration required) at:
> >
> > http://forum.java.sun.com/forum.jsp?forum=427
> >
> > See the README.txt file in the top-level subdirectory for more information
> > about installing and using this release.
> >
> > Craig McClanahan
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
>
>
> -- Matt Raible, Raible Designs, Morrison CO US
> -- Tel: +1 303 979-5340
> -- Mob: +1 720 560-8460
> -- Fax: +1 508 256-6471
> -- Web: http://www.raibledesigns.com
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-struts build.properties.sample build.xml

[Craig R. McClanahan]

On Thu, 6 Mar 2003, Martin Cooper wrote:

> Date: Thu, 6 Mar 2003 20:21:28 -0800 (PST)
> From: Martin Cooper <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Cc: Struts Developers List <[EMAIL PROTECTED]>
> Subject: Re: cvs commit: jakarta-struts build.properties.sample build.xml
>
>
>
> On Wed, 6 Mar 2003 [EMAIL PROTECTED] wrote:
>
> > craigmcc2003/03/05 20:20:49
> >
> >   Modified:.build.properties.sample build.xml
> >   Log:
> >   Make it possible to build Struts against the Servlet 2.4 and JSP 2.0 APIs,
> >   where the JSP classes have been pulled out into their own JAR file (jsp.jar).
> >   On an earlier platform, you can leave the "jsp.jar" property unset and things
> >   will continue to operate as they have before.
>
> Is this split into two jar files a Tomcat 5 thing?

More precisely, it's a JSR 152 (JSP 2.0) and JSR 154 (Servlet 2.4) thing,
and Tomcat 5 follows along that path.

> I haven't found a
> jakarta-servletapi download for 2.4/2.0, so I'm guessing it is.

I don't think there are any nightly builds of this yet, but the sources
are in the "jakarta-servletapi-5" CVS repository.

> It's worth
> noting that (unless the spec dictates it somewhere) other containers may
> not do the same thing. For example, Resin 3.0 still has both in a single
> jar file.
>
> --
> Martin Cooper
>


As it runs out (see my later message) we've got more serious problems that
prevent compiling against Servlet 2.4 anyway :-(.

Craig


>
> >
> >   Revision  ChangesPath
> >   1.32  +6 -1  jakarta-struts/build.properties.sample
> >
> >   Index: build.properties.sample
> >   ===
> >   RCS file: /home/cvs/jakarta-struts/build.properties.sample,v
> >   retrieving revision 1.31
> >   retrieving revision 1.32
> >   diff -u -r1.31 -r1.32
> >   --- build.properties.sample   28 Feb 2003 06:42:20 -  1.31
> >   +++ build.properties.sample   6 Mar 2003 04:20:49 -   1.32
> >   @@ -78,6 +78,11 @@
> ># http://java.sun.com/products/jdbc/download.html
> >jdbc20ext.jar=../../../Java/Programs/sun/jdbc2_0-stdext.jar
> >
> >   +# The JAR file containing the JSP API classes to compile against if you are
> >   +# using JSP 2.0 or later (where these classes are separated from servlet.jar).
> >   +# If you are using JSP 1.1 or 1.2, leave this property unset
> >   +#jsp.jar=${apache.home}/jakarta-servletapi/lib/jsp.jar
> >   +
> ># The JAR file containing the Servlet API classes to compile against (either
> ># version 2.2 or 2.3)
> >servlet.jar=${apache.home}/jakarta-servletapi/lib/servlet.jar
> >
> >
> >
> >   1.102 +9 -1  jakarta-struts/build.xml
> >
> >   Index: build.xml
> >   ===
> >   RCS file: /home/cvs/jakarta-struts/build.xml,v
> >   retrieving revision 1.101
> >   retrieving revision 1.102
> >   diff -u -r1.101 -r1.102
> >   --- build.xml 28 Feb 2003 06:42:20 -  1.101
> >   +++ build.xml 6 Mar 2003 04:20:49 -   1.102
> >   @@ -75,6 +75,13 @@
> >jdbc20ext.jar (required).  The path to the JAR file
> >  for the JDBC 2.0 Optional Package APIs.
> >
> >   +jsp.jar   (optional).  the path to the JSP API
> >   +  classes to compile against, if you are
> >   +  using JSP 2.0 where these classes have
> >   +  been separated from servlet.jar.  If you
> >   +  are using JSP 1.1 or 1.2, leave this
> >   +  property unset.
> >   +
> >servlet.jar   (required).  The path to the Servlet API
> >  classes to compile against (currently,
> >  either version 2.2 or 2.3 supported).
> >   @@ -195,6 +202,7 @@
> >  
> >  
> >  
> >   +  
> >  
> >  
> >
> >   @@ -319,7 +327,7 @@
> >
> > >destdir="${build.home}/documentation/api"
> >   -classpath="${servlet.jar}:${jdbc20ext.jar}"
> >   +classpath="${servlet.jar}:${jsp.jar}:${jdbc20ext.jar}"
> >packagenames="org.apache.struts.*"
> >author="true"
> >private="true"
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [ANNOUNCE] Struts-JavaServer Faces Integration Library -- Early Access Version Now Available

[Matt Raible]

Very Cool!  But...

You don't have permission to access
/builds/jakarta-struts/nightly/struts-faces/jakarta-struts-faces-20030306.zip
on this server.
Apache/2.1.0-dev (Unix) SVN/0.16.1 (dev build) DAV/2 Server at cvs.apache.org
Port 80


> I'm happy to announce the immediate availability of an integration library
> that allows you to use the recently published EA3 release of JavaServer
> Faces <http://java.sun.com/j2ee/javaserverfaces/> with a recent 
> Struts build (nightly build 20030216 or later, or the upcoming 1.1-
> rc2 or final release).  Nightly builds of this package are available 
> at:
> 
>   http://jakarta.apache.org/builds/jakarta-struts/nightly/struts-faces/
> 
> The sources for this package are in the "contrib/struts-faces"
> subdirectory of the "jakarta-struts" CVS repository.
> 
> You should take note of the following important points:
> 
> * The design goal of this library was to allow Struts application
>   developers to migrate the view tier of their applications from the
>   existing Struts tags, to pages that use corresponding JavaServer Faces
>   component tags, with no changes to the corresponding business 
> logic.  This goal has been substantially achieved for simple applications
>   so far; additional work will be necessary for more advanced apps.
>   As a proof of concept, the JavaServer Faces based version of the
>   canonical "struts-example" web application is included in the
>   distribution, so that you can see for yourself how little had to be
>   changed.
> 
> * The integration library has been tested under Tomcat 4.1.18 and
>   the Java Web Services Developer Pack (version 1.0_01), although in
>   principle it should run on any Servlet 2.3/JSP 1.2 container.
>   (It will not run on Servlet 2.2/JSP 1.1 containers).
> 
> * There is a known issue when trying to run JavaServer Faces EA3
>   under the recently released Java Web Services Developer Pack
>   (version 1.1).  Watch the JavaServer Faces web page (at the URL
>   listed above) for up-to-date information on workarounds.
> 
> * The JavaServer Faces distribution is an EA release, not suitable 
> for  use in production environments.  In addition, the license terms 
>  under which it can be downloaded prohibit redistribution. 
>  Therefore,  you will need to download your own copy of JavaServer 
> Faces EA3 and  integrate it with the example application before it 
> can be deployed.
> 
> * The integration library should also be considered to be of alpha
>   quality, not suitable for production use.  There are a set of known
>   issues and limitations at the bottom of the README.txt file. 
>  Please  file bugs against this package in the usual Bugzilla location:
> 
> http://nagoya.apache.org/bugzilla/
> 
> * For generic questions about JavaServer Faces (i.e. not related to this
>   integration library), your best resource is the JavaServer Faces forum
>   (free registration required) at:
> 
> http://forum.java.sun.com/forum.jsp?forum=427
> 
> See the README.txt file in the top-level subdirectory for more information
> about installing and using this release.
> 
> Craig McClanahan
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


-- Matt Raible, Raible Designs, Morrison CO US
-- Tel: +1 303 979-5340
-- Mob: +1 720 560-8460
-- Fax: +1 508 256-6471
-- Web: http://www.raibledesigns.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-struts build.properties.sample build.xml

[Martin Cooper]

On Wed, 6 Mar 2003 [EMAIL PROTECTED] wrote:

> craigmcc2003/03/05 20:20:49
>
>   Modified:.build.properties.sample build.xml
>   Log:
>   Make it possible to build Struts against the Servlet 2.4 and JSP 2.0 APIs,
>   where the JSP classes have been pulled out into their own JAR file (jsp.jar).
>   On an earlier platform, you can leave the "jsp.jar" property unset and things
>   will continue to operate as they have before.

Is this split into two jar files a Tomcat 5 thing? I haven't found a
jakarta-servletapi download for 2.4/2.0, so I'm guessing it is. It's worth
noting that (unless the spec dictates it somewhere) other containers may
not do the same thing. For example, Resin 3.0 still has both in a single
jar file.

--
Martin Cooper


>
>   Revision  ChangesPath
>   1.32  +6 -1  jakarta-struts/build.properties.sample
>
>   Index: build.properties.sample
>   ===
>   RCS file: /home/cvs/jakarta-struts/build.properties.sample,v
>   retrieving revision 1.31
>   retrieving revision 1.32
>   diff -u -r1.31 -r1.32
>   --- build.properties.sample 28 Feb 2003 06:42:20 -  1.31
>   +++ build.properties.sample 6 Mar 2003 04:20:49 -   1.32
>   @@ -78,6 +78,11 @@
># http://java.sun.com/products/jdbc/download.html
>jdbc20ext.jar=../../../Java/Programs/sun/jdbc2_0-stdext.jar
>
>   +# The JAR file containing the JSP API classes to compile against if you are
>   +# using JSP 2.0 or later (where these classes are separated from servlet.jar).
>   +# If you are using JSP 1.1 or 1.2, leave this property unset
>   +#jsp.jar=${apache.home}/jakarta-servletapi/lib/jsp.jar
>   +
># The JAR file containing the Servlet API classes to compile against (either
># version 2.2 or 2.3)
>servlet.jar=${apache.home}/jakarta-servletapi/lib/servlet.jar
>
>
>
>   1.102 +9 -1  jakarta-struts/build.xml
>
>   Index: build.xml
>   ===
>   RCS file: /home/cvs/jakarta-struts/build.xml,v
>   retrieving revision 1.101
>   retrieving revision 1.102
>   diff -u -r1.101 -r1.102
>   --- build.xml   28 Feb 2003 06:42:20 -  1.101
>   +++ build.xml   6 Mar 2003 04:20:49 -   1.102
>   @@ -75,6 +75,13 @@
>jdbc20ext.jar (required).  The path to the JAR file
>  for the JDBC 2.0 Optional Package APIs.
>
>   +jsp.jar   (optional).  the path to the JSP API
>   +  classes to compile against, if you are
>   +  using JSP 2.0 where these classes have
>   +  been separated from servlet.jar.  If you
>   +  are using JSP 1.1 or 1.2, leave this
>   +  property unset.
>   +
>servlet.jar   (required).  The path to the Servlet API
>  classes to compile against (currently,
>  either version 2.2 or 2.3 supported).
>   @@ -195,6 +202,7 @@
>  
>  
>  
>   +  
>  
>  
>
>   @@ -319,7 +327,7 @@
>
>destdir="${build.home}/documentation/api"
>   -classpath="${servlet.jar}:${jdbc20ext.jar}"
>   +classpath="${servlet.jar}:${jsp.jar}:${jdbc20ext.jar}"
>packagenames="org.apache.struts.*"
>author="true"
>private="true"
>
>
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[ANNOUNCE] Struts-JavaServer Faces Integration Library -- EarlyAccess Version Now Available

[Craig R. McClanahan]

I'm happy to announce the immediate availability of an integration library
that allows you to use the recently published EA3 release of JavaServer
Faces  with a recent Struts
build (nightly build 20030216 or later, or the upcoming 1.1-rc2 or final
release).  Nightly builds of this package are available at:

  http://jakarta.apache.org/builds/jakarta-struts/nightly/struts-faces/

The sources for this package are in the "contrib/struts-faces"
subdirectory of the "jakarta-struts" CVS repository.

You should take note of the following important points:

* The design goal of this library was to allow Struts application
  developers to migrate the view tier of their applications from the
  existing Struts tags, to pages that use corresponding JavaServer Faces
  component tags, with no changes to the corresponding business logic.
  This goal has been substantially achieved for simple applications
  so far; additional work will be necessary for more advanced apps.
  As a proof of concept, the JavaServer Faces based version of the
  canonical "struts-example" web application is included in the
  distribution, so that you can see for yourself how little had to be
  changed.

* The integration library has been tested under Tomcat 4.1.18 and
  the Java Web Services Developer Pack (version 1.0_01), although in
  principle it should run on any Servlet 2.3/JSP 1.2 container.
  (It will not run on Servlet 2.2/JSP 1.1 containers).

* There is a known issue when trying to run JavaServer Faces EA3
  under the recently released Java Web Services Developer Pack
  (version 1.1).  Watch the JavaServer Faces web page (at the URL
  listed above) for up-to-date information on workarounds.

* The JavaServer Faces distribution is an EA release, not suitable for
  use in production environments.  In addition, the license terms
  under which it can be downloaded prohibit redistribution.  Therefore,
  you will need to download your own copy of JavaServer Faces EA3 and
  integrate it with the example application before it can be deployed.

* The integration library should also be considered to be of alpha
  quality, not suitable for production use.  There are a set of known
  issues and limitations at the bottom of the README.txt file.  Please
  file bugs against this package in the usual Bugzilla location:

http://nagoya.apache.org/bugzilla/

* For generic questions about JavaServer Faces (i.e. not related to this
  integration library), your best resource is the JavaServer Faces forum
  (free registration required) at:

http://forum.java.sun.com/forum.jsp?forum=427

See the README.txt file in the top-level subdirectory for more information
about installing and using this release.

Craig McClanahan


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17758] - [PATCH] invalid assignment in SimpleBeanForTesting

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17758

[PATCH] invalid assignment in SimpleBeanForTesting

[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Standard Actions|Test
 OS/Version|Other   |All

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17758] - [PATCH] invalid assignment in SimpleBeanForTesting

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17758

[PATCH] invalid assignment in SimpleBeanForTesting





--- Additional Comments From [EMAIL PROTECTED]  2003-03-07 03:43 ---
Created an attachment (id=5195)
patch addresses bug report

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17758] New: - [PATCH] invalid assignment in SimpleBeanForTesting

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17758

[PATCH] invalid assignment in SimpleBeanForTesting

   Summary: [PATCH] invalid assignment in SimpleBeanForTesting
   Product: Struts
   Version: Nightly Build
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Standard Actions
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The following patch fix fixes the following code:

public SimpleBeanForTesting(Boolean checked){
this.checkedWrapper = checkedWrapper;
}

so that it assigns the correct variable and updates the copyright date.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

The "struts-faces" directory creates ...

[Craig R. McClanahan]

Yep ... it's here ... the promised integration library that lets you use
the recently published EA3 release of JavaServer Faces
 with a recent Struts 1.1 build
(see the README.txt for details).  Unfortunately, the CVS commit for the
actual code was too big for the mailing list -- essentially, it's all the
files in the "contrib/struts-faces" subdirectory.

My plan is to publish nightly builds of this code (it's EA quality) but
*not* to incorporate it into any formal 1.1 release.  More info in an
announcement message to come shortly.

Craig


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17757] - [PATCH] static fields should not be accessed via instance variables

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17757

[PATCH] static fields should not be accessed via instance variables





--- Additional Comments From [EMAIL PROTECTED]  2003-03-07 03:28 ---
Created an attachment (id=5194)
patch addresses bug report

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17757] New: - [PATCH] static fields should not be accessed via instance variables

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17757

[PATCH] static fields should not be accessed via instance variables

   Summary: [PATCH] static fields should not be accessed via
instance variables
   Product: Struts
   Version: Nightly Build
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Standard Actions
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


There are several classes throughout the share folder that reference static 
fields via instance variables.  This patch changes those references to use the 
class itself versus an instance of the class.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/util - New directory

[craigmcc]

craigmcc2003/03/06 19:21:25

  jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/util - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/taglib - New directory

[craigmcc]

craigmcc2003/03/06 19:21:06

  jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/taglib - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/renderer - New directory

[craigmcc]

craigmcc2003/03/06 19:20:48

  jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/renderer - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/component - New directory

[craigmcc]

craigmcc2003/03/06 19:20:34

  jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/component - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/application - New directory

[craigmcc]

craigmcc2003/03/06 19:20:22

  jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/application - 
New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces - New directory

[craigmcc]

craigmcc2003/03/06 19:20:09

  jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/java/org/apache/struts - New directory

[craigmcc]

craigmcc2003/03/06 19:20:04

  jakarta-struts/contrib/struts-faces/src/java/org/apache/struts - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/java/org/apache - New directory

[craigmcc]

craigmcc2003/03/06 19:19:57

  jakarta-struts/contrib/struts-faces/src/java/org/apache - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/java/org - New directory

[craigmcc]

craigmcc2003/03/06 19:19:50

  jakarta-struts/contrib/struts-faces/src/java/org - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/java - New directory

[craigmcc]

craigmcc2003/03/06 19:19:43

  jakarta-struts/contrib/struts-faces/src/java - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/example/org/apache/struts/webapp/example/memory - New directory

[craigmcc]

craigmcc2003/03/06 19:19:19

  
jakarta-struts/contrib/struts-faces/src/example/org/apache/struts/webapp/example/memory
 - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/example/org/apache/struts/webapp/example - New directory

[craigmcc]

craigmcc2003/03/06 19:18:59

  jakarta-struts/contrib/struts-faces/src/example/org/apache/struts/webapp/example - 
New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/example/org/apache/struts/webapp - New directory

[craigmcc]

craigmcc2003/03/06 19:18:53

  jakarta-struts/contrib/struts-faces/src/example/org/apache/struts/webapp - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/example/org/apache/struts - New directory

[craigmcc]

craigmcc2003/03/06 19:18:47

  jakarta-struts/contrib/struts-faces/src/example/org/apache/struts - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/example/org/apache - New directory

[craigmcc]

craigmcc2003/03/06 19:18:41

  jakarta-struts/contrib/struts-faces/src/example/org/apache - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/example/org - New directory

[craigmcc]

craigmcc2003/03/06 19:18:36

  jakarta-struts/contrib/struts-faces/src/example/org - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/example - New directory

[craigmcc]

craigmcc2003/03/06 19:18:29

  jakarta-struts/contrib/struts-faces/src/example - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src/conf - New directory

[craigmcc]

craigmcc2003/03/06 19:18:11

  jakarta-struts/contrib/struts-faces/src/conf - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/src - New directory

[craigmcc]

craigmcc2003/03/06 19:18:05

  jakarta-struts/contrib/struts-faces/src - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/web/example/WEB-INF - New directory

[craigmcc]

craigmcc2003/03/06 19:17:47

  jakarta-struts/contrib/struts-faces/web/example/WEB-INF - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/web/example - New directory

[craigmcc]

craigmcc2003/03/06 19:17:04

  jakarta-struts/contrib/struts-faces/web/example - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces/web - New directory

[craigmcc]

craigmcc2003/03/06 19:16:57

  jakarta-struts/contrib/struts-faces/web - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/contrib/struts-faces - New directory

[craigmcc]

craigmcc2003/03/06 19:16:27

  jakarta-struts/contrib/struts-faces - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17751] - Dynamic de-coupled mapping of DynaForm properties to Model properties

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17751

Dynamic de-coupled mapping of DynaForm properties to Model properties

[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|0.5 Final   |1.1 RC1



--- Additional Comments From [EMAIL PROTECTED]  2003-03-07 01:49 ---
Also, if I can map the model object.method in the  tag may be, I can get
rid of my other action-model mapping xml.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17751] New: - Dynamic de-coupled mapping of DynaForm properties to Model properties

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17751

Dynamic de-coupled mapping of DynaForm properties to Model properties

   Summary: Dynamic de-coupled mapping of DynaForm properties to
Model properties
   Product: Struts
   Version: 0.5 Final
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Controller
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


BACKGROUND:
===
All my Action classes are basically doing the same thing which is:

1. authintication
2. copy the form properties to a model object
3. call the appropriate model object.method
4. handle exceptions

This being a pattern, I extracted this functionality to a super Action class
that is extended by all my Action classes. This super action class does the
following:

1. authenticate
2. copies the form properties to a map, using BeanUtils.describe
3. reads a mapping xml and calls the appropriate model object.method using the
created map, using MethodUtils.invoke
4. handle exceptions

REQUIREMENT:

The above strategy works fine as long as the form property names and the model
property names are in sync. Any change in the form property name requires a
change in the model which couples the two together. If I have a way of mapping
the form properties to the model properties in the  tag may be, I can
now describe the form bean into a model map and not worry about the form changes.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17750] New: - bean:message could be more power with little effort

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17750

bean:message could be more power with little effort

   Summary: bean:message could be more power with little effort
   Product: Struts
   Version: 1.1 RC1
  Platform: All
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


A lot of power in the bean:message taglib is lost because the setters/getters
for the arg0 though arg4 take java.lang.String arguments instead of
java.lang.Object. This is because it makes it impossible to pass a subclass of
java.lang.Number as one of the arguments.

For example if in my app's Message.properties I have the property:

how.many.messages={0,choice,0#No messages|1#One message|1"/>

The java.text.ChoiceFormat fails in the method
java.text.NumberFormat.format(Object,StringBuffer,FieldPosition) with a
"java.lang.IllegalArgumentException: Cannot format given Object as a Number"
because "12" is a string and not a subclass of Number.

If I use the bean:message taglib in the following way:



The JSP fails to compile because there is no way to cast an Integer to a String.

I really wish it wasn't so but I understand it's probably too late in the game
to get this change made by Struts 1.1. It would be nice that if in the
documentation a note is added mentioning that the bean:message taglib only
allows only very simplistic parametric replacement so people like myself don't
assume we have access to the full power of java.text.MessageFormat and waste a
few hours trying to figure out why things are breaking.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17728] - EvalHelper should not throw NullAttributeException, it's too slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17728

EvalHelper should not throw NullAttributeException, it's too slow





--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 21:53 ---
Created an attachment (id=5187)
Altered EvalHelper to return null or default values when desired, updated all tags

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [PATCH] Patch to remove NullAttributeException

[David Graham]

Attach patches to the corresponding bugzilla ticket.

David



From: Nick Coleman <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: "'[EMAIL PROTECTED]'" <[EMAIL PROTECTED]>
Subject: [PATCH] Patch to remove NullAttributeException
Date: Thu, 6 Mar 2003 16:40:16 -0500
Patch is 331K cvs diff.

It can be downloaded from http://www.leanlogistics.com/patchfile.txt



_
Add photos to your e-mail with MSN 8. Get 2 months FREE*.  
http://join.msn.com/?page=features/featuredemail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[PATCH] Patch to remove NullAttributeException

[Nick Coleman]

Patch is 331K cvs diff.

It can be downloaded from http://www.leanlogistics.com/patchfile.txt
 

DO NOT REPLY [Bug 17562] - Sub-Tiles not rendered correctly in 1.1b2 and 1.1RC1

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17562

Sub-Tiles not rendered correctly in 1.1b2 and 1.1RC1





--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 21:16 ---
The patch I just submitted works for both of the examples given in the bug 
report.  I'm not convinced it's the correct approach, but it works for these 
cases.

It basically uses PageContext.include if flush == true and uses 
RequestDispatcher.include otherwise.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17562] - Sub-Tiles not rendered correctly in 1.1b2 and 1.1RC1

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17562

Sub-Tiles not rendered correctly in 1.1b2 and 1.1RC1





--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 21:14 ---
Created an attachment (id=5186)
Uses pageContext.include if flush == true

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Correct procedure for reporting bugs?

[Hajratwala, Nayan (N.)]

Take a look at this link...

http://jakarta.apache.org/struts/faqs/helping.html

---
- Nayan Hajratwala
- Chikli Consulting LLC
- http://www.chikli.com


-Original Message-
From: Mark [mailto:[EMAIL PROTECTED] 
Sent: Thursday, March 06, 2003 12:02 PM
To: [EMAIL PROTECTED]
Subject: Correct procedure for reporting bugs?



I was looking for a "Get involved" or "Report bugs" link on the struts
website, and could not find any.

I would like to participate in the "Improvement Process" but would like to
know what is the best avenue for doing so?

Regards,
Mark Williamson


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Building Struts and Servlet/JSP Versions

[David Graham]

Sounds good to me.

David

FYI, it turns out we have one additional servlet/JSP versioning issue.  I
put in a patch last night to add "jsp.jar" to the classpath (if it is
set), because the servlet and JSP jars were separated for Servlet 2.4 /
JSP 2.0.  But it turns out this is not sufficient to support building
Struts against these JAR files.
In Servlet 2.4, some additional methods got added to HttpServletRequest,
which causes compile errors on
org.apache.struts.upload.MultipartRequestWrapper.  However, if we were to
add the new methods and try to delegate them to the underlying request
object, we'd break compiling against Servlet 2.2 or 2.3.  (This wouldn't
happen if we were 2.3-minimum, because we could just use the provided
wrapper base class).
To avoid breaking backwards compatibility, I propose that we just add some
comments to the release notes that say:
* You must compile Struts 1.1 source against a 2.2 or 2.3 servlet.jar file

* If you use Struts 1.1 in a Servlet 2.4 environment (like Tomcat 5),
  the MultipartRequestWrapper object will not expose the new request
  methods.
Craig

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


_
Add photos to your e-mail with MSN 8. Get 2 months FREE*.  
http://join.msn.com/?page=features/featuredemail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17733] - Map based forms and indexed fields do not work correctly

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17733

Map based forms and indexed fields do not work correctly





--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 17:36 ---
Oops.  i actually have a bug in my bug fix:

if (name != null)
{
   handlers.append(name);
   handlers.append("_");
}
handlers.append("_");


should be:

if (name != null)
{
   handlers.append(name);
}
handlers.append("_");

I had erroneously appeneded the _ twice.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17733] New: - Map based forms and indexed fields do not work correctly

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17733

Map based forms and indexed fields do not work correctly

   Summary: Map based forms and indexed fields do not work correctly
   Product: Struts
   Version: 1.1 Beta 3
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


This problem occurs when you use an index html: field with a map based form.

In my application, I have to show a series of "forms" on one screen that 
essentially enable the user to configure more than one similar items at a 
time.  So, if they add 7 "cars" to their order form, they can configure each 
car on one screen (color, make, model, etc).  This is hypotethical of course, 
but the analogy is good.  So instead of going through 7 screens, they can do it 
all on one.  For this, I use indexed fields and a Hashmap/MapActionForm which I 
borrowed from the Struts user guides.

In the documentation/examples, we are told to use this style of property 
fetching for MapActionForms:



Adding to the mix Indexed fields, 



Our desirable html output should be something like:



note:  cannot use these styles due to BeanUtils
   
   

However, using the combination above, our actual html field is currently 
rendered like so:



... and so on, incrementing the BEAN[x] for each iteration

Thus, this is incorrect.  The MapActionForm gets no values when posted. Unless 
there is an array of mapactionforms that im not seeing... 

I have remedied this problem with a hack, and submit it to you guys for review 
and possibly "doing it better" since my way probably isnt optimal.  

The problem we need to solve is, the property="value(firstname)" needs to have 
a counter appended to whats inside the () rather than prepending something on 
the left.

Since whats inside the parens is our "fieldname" and to accomplish an indexed 
field, we need to append the index value, what we really want is

value(color_0)
value(color_1)

etc
etc

I've had to fix several files to remedy this:

BaseFieldTag.java
BaseHandlerTag.java
CheckboxTag.java
RadioTag.java
SelectTag.java
TextareaTag.java


However, I think all the html tags are affected, and should be fixed if the dev 
team determines this is indeed a bug.
I had to fix BaseHandlerTag like so:

previous:
  // this code builds the name org.apache.struts.taglib.html.BEAN[0].
if (name != null)
handlers.append(name);
handlers.append("[");
handlers.append(iterateTag.getIndex());
handlers.append("]");
if (name != null)
handlers.append(".");


new:


if (name != null)
{
   handlers.append(name);
   handlers.append("_");
}
handlers.append("_");
handlers.append(iterateTag.getIndex());




A diff from BaseFieldTag should give you the fix:

E:\jakarta-struts-1.1-b3-src\src\share\org\apache\struts\taglib\html>diff 
BaseFieldTag.java ../html-prev/BaseFieldTag.java
142,160c142,145
<   // if we are using an indexed field, we need to do something
<   // special for map based properties
<   if( indexed )
<   {
< // are we using a map based property?
< if(this.property.indexOf("(")>0)
<   {
< // figure out our prefix and suffix based on where the first 
( is found.
< // the goal here is to render our field like value
(firstname_0) .. value(firstname_1) etc
< // rather than the original struts way of 
org.apache.struts.taglib.html.BEAN[0].value(firstname)
<   String prefix=this.property.substring(0,this.property.indexOf
(")"));
<   results.append(prefix);
<   prepareIndex(results,null);
<   results.append(")");
< } else // otherwise just proceed as normal
< prepareIndex( results, name );
<   } else
<   results.append(this.property);
<
---
> // * @since Struts 1.1
> if (indexed)
> prepareIndex(results, name);
> results.append(property);

Regards,
Mark Williamson

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Correct procedure for reporting bugs?

[Mark]

Yup, missed that one.

Thanks

*** REPLY SEPARATOR  ***

On 03/06/2003 at 9:14 AM Martin Cooper wrote:

>On Thu, 6 Mar 2003, Mark wrote:
>
>>
>> I was looking for a "Get involved" or "Report bugs" link on the struts website, and 
>> could not find any.
>
>I guess you missed this page:
>
>http://jakarta.apache.org/struts/using.html
>
>--
>Martin Cooper
>
>
>>
>> I would like to participate in the "Improvement Process" but would like to know 
>> what is the best avenue for doing so?
>>
>> Regards,
>> Mark Williamson
>>
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
>-
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Correct procedure for reporting bugs?

[Martin Cooper]

On Thu, 6 Mar 2003, Mark wrote:

>
> I was looking for a "Get involved" or "Report bugs" link on the struts website, and 
> could not find any.

I guess you missed this page:

http://jakarta.apache.org/struts/using.html

--
Martin Cooper


>
> I would like to participate in the "Improvement Process" but would like to know what 
> is the best avenue for doing so?
>
> Regards,
> Mark Williamson
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Correct procedure for reporting bugs?

[Mark]

I was looking for a "Get involved" or "Report bugs" link on the struts website, and 
could not find any.

I would like to participate in the "Improvement Process" but would like to know what 
is the best avenue for doing so?

Regards,
Mark Williamson


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Building Struts and Servlet/JSP Versions

[Craig R. McClanahan]

FYI, it turns out we have one additional servlet/JSP versioning issue.  I
put in a patch last night to add "jsp.jar" to the classpath (if it is
set), because the servlet and JSP jars were separated for Servlet 2.4 /
JSP 2.0.  But it turns out this is not sufficient to support building
Struts against these JAR files.

In Servlet 2.4, some additional methods got added to HttpServletRequest,
which causes compile errors on
org.apache.struts.upload.MultipartRequestWrapper.  However, if we were to
add the new methods and try to delegate them to the underlying request
object, we'd break compiling against Servlet 2.2 or 2.3.  (This wouldn't
happen if we were 2.3-minimum, because we could just use the provided
wrapper base class).

To avoid breaking backwards compatibility, I propose that we just add some
comments to the release notes that say:

* You must compile Struts 1.1 source against a 2.2 or 2.3 servlet.jar file

* If you use Struts 1.1 in a Servlet 2.4 environment (like Tomcat 5),
  the MultipartRequestWrapper object will not expose the new request
  methods.

Craig


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17728] - EvalHelper should not throw NullAttributeException, it's too slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17728

EvalHelper should not throw NullAttributeException, it's too slow

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Major   |Normal
 Status|REOPENED|RESOLVED
 Resolution||LATER
   Target Milestone|--- |1.2 Family

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-struts/src/test/org/apache/struts/taglib/logicTestIterateTag.java

[Craig R. McClanahan]

On Thu, 6 Mar 2003, David Graham wrote:

> Date: Thu, 06 Mar 2003 09:10:45 -0700
> From: David Graham <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: Re: cvs commit:
> jakarta-struts/src/test/org/apache/struts/taglib/logic TestIterateTag.java
>
> Thanks for fixing this Martin.  It concerns me that the nightly builds were
> unaffected by this, indicating that they're built against the servlet 2.3
> jar.  Craig, is that the case?  Can we change it to build against 2.2 since
> that's our baseline?
>

The nightly builds are indeed built against Servlet 2.3 / JSP 1.2.

I can modify this over the weekend (on a business trip now, and don't have
good remote access to my home network that is running the builds).

> David

Craig


>
>
>
> >From: [EMAIL PROTECTED]
> >Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
> >To: [EMAIL PROTECTED]
> >Subject: cvs commit: jakarta-struts/src/test/org/apache/struts/taglib/logic
> >TestIterateTag.java
> >Date: 6 Mar 2003 16:07:13 -
> >
> >martinc 2003/03/06 08:07:13
> >
> >   Modified:src/share/org/apache/struts/taglib/nested
> > NestedPropertyTag.java NestedRootTag.java
> >src/test/org/apache/struts/taglib/logic TestIterateTag.java
> >   Log:
> >   Replace EVAL_BODY_AGAIN with EVAL_BODY_TAG so that the code compiles
> >   against the JSP 1.1 API.
> >
> >   Revision  ChangesPath
> >   1.8   +5 -5
> >jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedPropertyTag.java
> >
> >   Index: NestedPropertyTag.java
> >   ===
> >   RCS file:
> >/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedPropertyTag.java,v
> >   retrieving revision 1.7
> >   retrieving revision 1.8
> >   diff -u -r1.7 -r1.8
> >   --- NestedPropertyTag.java28 Feb 2003 05:14:01 -  1.7
> >   +++ NestedPropertyTag.java6 Mar 2003 16:07:13 -   1.8
> >   @@ -118,7 +118,7 @@
> >NestedPropertyHelper.setName(request, originalName);
> >
> >// run the body part
> >   -return (EVAL_BODY_AGAIN);
> >   +return (EVAL_BODY_TAG);
> >  }
> >
> >
> >
> >
> >
> >   1.8   +5 -5
> >jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedRootTag.java
> >
> >   Index: NestedRootTag.java
> >   ===
> >   RCS file:
> >/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedRootTag.java,v
> >   retrieving revision 1.7
> >   retrieving revision 1.8
> >   diff -u -r1.7 -r1.8
> >   --- NestedRootTag.java28 Feb 2003 05:14:01 -  1.7
> >   +++ NestedRootTag.java6 Mar 2003 16:07:13 -   1.8
> >   @@ -132,7 +132,7 @@
> >}
> >
> >// do the JSP thing
> >   -return (EVAL_BODY_AGAIN);
> >   +return (EVAL_BODY_TAG);
> >  }
> >
> >  /**
> >
> >
> >
> >   1.3   +24 -24
> >jakarta-struts/src/test/org/apache/struts/taglib/logic/TestIterateTag.java
> >
> >   Index: TestIterateTag.java
> >   ===
> >   RCS file:
> >/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/logic/TestIterateTag.java,v
> >   retrieving revision 1.2
> >   retrieving revision 1.3
> >   diff -u -r1.2 -r1.3
> >   --- TestIterateTag.java   28 Feb 2003 02:42:11 -  1.2
> >   +++ TestIterateTag.java   6 Mar 2003 16:07:13 -   1.3
> >   @@ -146,7 +146,7 @@
> > out.print((String)pageContext.getAttribute("theId"));
> > iteration++;
> >
> >   - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
> >   + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
> > tag.doEndTag();
> > assertEquals(iterations, iteration);
> > }
> >   @@ -193,7 +193,7 @@
> > out.print((String)pageContext.getAttribute("theId"));
> > iteration++;
> >
> >   - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
> >   + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
> > tag.doEndTag();
> > assertEquals(iterations, iteration);
> > }
> >   @@ -240,7 +240,7 @@
> > out.print((String)pageContext.getAttribute("theId"));
> > iteration++;
> >
> >   - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
> >   + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
> > tag.doEndTag();
> > assertEquals(iterations, iteration);
> > }
> >   @@ -308,7 +308,7 @@
> > out.print((String)pageContext.getAttribute("theId"));
> > iteration++;
> >
> >   - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
> >   + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
> > tag.doEndTag();
> > assertEquals(iterations, iteration);
> >

DO NOT REPLY [Bug 17728] - EvalHelper should not throw NullAttributeException, it's too slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17728

EvalHelper should not throw NullAttributeException, it's too slow





--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 16:37 ---
Created an attachment (id=5183)
updated EvalHelper with methods to return defaults, null exception removed.  Would 
need to update all EL tags to use this.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17728] - EvalHelper should not throw NullAttributeException, it's too slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17728

EvalHelper should not throw NullAttributeException, it's too slow





--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 16:31 ---
I'm well aware of this.  It's already on my list of changes after the 1.1 release.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Build broken?

[David Graham]

I'll try it out tonight.

Thanks!
David


From: Martin Cooper <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: Struts Developers List <[EMAIL PROTECTED]>
Subject: Re: Build broken?
Date: Thu, 6 Mar 2003 08:08:47 -0800 (PST)
I've made the change, but I don't have a handy JSP 1.1 to build against,
so could you try it, please, and make sure it's OK? It still builds fine
against JSP 1.2.
--
Martin Cooper
On Wed, 5 Mar 2003, David Graham wrote:

> When I try to build Struts I get this error:
> [javac]
> 
C:\eclipse\workspace\jakarta-struts\src\share\org\apache\struts\taglib\nested\NestedPropertyTag.java:121:
> cannot resolve symbol
> [javac] symbol  : variable EVAL_BODY_AGAIN
> [javac] location: class
> org.apache.struts.taglib.nested.NestedPropertyTag
> [javac] return (EVAL_BODY_AGAIN);
>
> I think EVAL_BODY_AGAIN is a JSP 1.2 feature and I'm building with the
> Servlet 2.2 jar.  Is anyone else having this problem?
>
> David
>
>
>
>
>
> _
> The new MSN 8: smart spam protection and 2 months FREE*
> http://join.msn.com/?page=features/junkmail
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


_
STOP MORE SPAM with the new MSN 8 and get 2 months FREE*  
http://join.msn.com/?page=features/junkmail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-struts/src/test/org/apache/struts/taglib/logicTestIterateTag.java

[David Graham]

Thanks for fixing this Martin.  It concerns me that the nightly builds were 
unaffected by this, indicating that they're built against the servlet 2.3 
jar.  Craig, is that the case?  Can we change it to build against 2.2 since 
that's our baseline?

David



From: [EMAIL PROTECTED]
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: cvs commit: jakarta-struts/src/test/org/apache/struts/taglib/logic 
TestIterateTag.java
Date: 6 Mar 2003 16:07:13 -

martinc 2003/03/06 08:07:13

  Modified:src/share/org/apache/struts/taglib/nested
NestedPropertyTag.java NestedRootTag.java
   src/test/org/apache/struts/taglib/logic TestIterateTag.java
  Log:
  Replace EVAL_BODY_AGAIN with EVAL_BODY_TAG so that the code compiles
  against the JSP 1.1 API.
  Revision  ChangesPath
  1.8   +5 -5  
jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedPropertyTag.java

  Index: NestedPropertyTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedPropertyTag.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- NestedPropertyTag.java	28 Feb 2003 05:14:01 -	1.7
  +++ NestedPropertyTag.java	6 Mar 2003 16:07:13 -	1.8
  @@ -118,7 +118,7 @@
   NestedPropertyHelper.setName(request, originalName);

   // run the body part
  -return (EVAL_BODY_AGAIN);
  +return (EVAL_BODY_TAG);
 }




  1.8   +5 -5  
jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedRootTag.java

  Index: NestedRootTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedRootTag.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- NestedRootTag.java	28 Feb 2003 05:14:01 -	1.7
  +++ NestedRootTag.java	6 Mar 2003 16:07:13 -	1.8
  @@ -132,7 +132,7 @@
   }

   // do the JSP thing
  -return (EVAL_BODY_AGAIN);
  +return (EVAL_BODY_TAG);
 }
 /**



  1.3   +24 -24
jakarta-struts/src/test/org/apache/struts/taglib/logic/TestIterateTag.java

  Index: TestIterateTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/logic/TestIterateTag.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- TestIterateTag.java	28 Feb 2003 02:42:11 -	1.2
  +++ TestIterateTag.java	6 Mar 2003 16:07:13 -	1.3
  @@ -146,7 +146,7 @@
   			out.print((String)pageContext.getAttribute("theId"));
   		iteration++;

  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -193,7 +193,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;
  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -240,7 +240,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;
  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -308,7 +308,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;
  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -366,7 +366,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;
  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -424,7 +424,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;
  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -478,7 +478,7 @@
{
out.print((String)pageContext.getAttribute("theId"));
  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  +   

Re: Build broken?

[Martin Cooper]

I've made the change, but I don't have a handy JSP 1.1 to build against,
so could you try it, please, and make sure it's OK? It still builds fine
against JSP 1.2.

--
Martin Cooper


On Wed, 5 Mar 2003, David Graham wrote:

> When I try to build Struts I get this error:
> [javac]
> C:\eclipse\workspace\jakarta-struts\src\share\org\apache\struts\taglib\nested\NestedPropertyTag.java:121:
> cannot resolve symbol
> [javac] symbol  : variable EVAL_BODY_AGAIN
> [javac] location: class
> org.apache.struts.taglib.nested.NestedPropertyTag
> [javac] return (EVAL_BODY_AGAIN);
>
> I think EVAL_BODY_AGAIN is a JSP 1.2 feature and I'm building with the
> Servlet 2.2 jar.  Is anyone else having this problem?
>
> David
>
>
>
>
>
> _
> The new MSN 8: smart spam protection and 2 months FREE*
> http://join.msn.com/?page=features/junkmail
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/src/test/org/apache/struts/taglib/logic TestIterateTag.java

[martinc]

martinc 2003/03/06 08:07:13

  Modified:src/share/org/apache/struts/taglib/nested
NestedPropertyTag.java NestedRootTag.java
   src/test/org/apache/struts/taglib/logic TestIterateTag.java
  Log:
  Replace EVAL_BODY_AGAIN with EVAL_BODY_TAG so that the code compiles
  against the JSP 1.1 API.
  
  Revision  ChangesPath
  1.8   +5 -5  
jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedPropertyTag.java
  
  Index: NestedPropertyTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedPropertyTag.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- NestedPropertyTag.java28 Feb 2003 05:14:01 -  1.7
  +++ NestedPropertyTag.java6 Mar 2003 16:07:13 -   1.8
  @@ -118,7 +118,7 @@
   NestedPropertyHelper.setName(request, originalName);
   
   // run the body part
  -return (EVAL_BODY_AGAIN);
  +return (EVAL_BODY_TAG);
 }
   
   
  
  
  
  1.8   +5 -5  
jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedRootTag.java
  
  Index: NestedRootTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/nested/NestedRootTag.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- NestedRootTag.java28 Feb 2003 05:14:01 -  1.7
  +++ NestedRootTag.java6 Mar 2003 16:07:13 -   1.8
  @@ -132,7 +132,7 @@
   }
   
   // do the JSP thing
  -return (EVAL_BODY_AGAIN);
  +return (EVAL_BODY_TAG);
 }
   
 /**
  
  
  
  1.3   +24 -24
jakarta-struts/src/test/org/apache/struts/taglib/logic/TestIterateTag.java
  
  Index: TestIterateTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/logic/TestIterateTag.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- TestIterateTag.java   28 Feb 2003 02:42:11 -  1.2
  +++ TestIterateTag.java   6 Mar 2003 16:07:13 -   1.3
  @@ -146,7 +146,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;

  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -193,7 +193,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;

  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -240,7 +240,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;

  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -308,7 +308,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;

  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -366,7 +366,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;

  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -424,7 +424,7 @@
out.print((String)pageContext.getAttribute("theId"));
iteration++;

  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
assertEquals(iterations, iteration);
}
  @@ -478,7 +478,7 @@
{
out.print((String)pageContext.getAttribute("theId"));

  - } while (tag.doAfterBody() == tag.EVAL_BODY_AGAIN);
  + } while (tag.doAfterBody() == tag.EVAL_BODY_TAG);
tag.doEndTag();
   
}
  @@ -522,7 +522,7 @@
{
out.print((String)pageContext.getAttribute("theId"));

  - 

Re: compiling and building struts

[Steve Peterson]

It's pretty straightforward.

1.  Check out Struts into a new project via the Eclipse CVS integration.

2.  Download .jar dependencies

3.  Edit Eclipse project classpath settings to refer to .jar files from #2, 
and set source paths properly.  After this step, Struts should be compiling 
with no errors in Eclipse.

4.  Create build.properties to reflect your local configuration.  Once this 
is done, you can use ant to build the distribution.

At 10:29 PM 3/5/2003 -0800, asatrasala wrote:
Sorry to grab  into the 'Build Broken' thread.  I think this is a 
developer question.
I am looking to compile/build struts in the eclipse environment, including 
checkingout all the sources and jars needed
from CVS etc needed to compile/build struts.  I tried, but could not 
understand some of the details of the build.xml file.
I also would like to know how to run the struts test cases in eclipse(my 
2nd step)

Thanks
-Aswath
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17728] - EvalHelper should not throw NullAttributeException, it's too slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17728

EvalHelper should not throw NullAttributeException, it's too slow





--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 15:54 ---
No problem Mark, I was just about to add that I looked at more of the tags and 
some do call ExpressionUtil directly while others call EvalHelper.  That may be 
why some of the tags work a little faster...

I guess the main reason I noticed this is the Link tag is really slow and it 
calls the EvalHelper...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17728] - EvalHelper should not throw NullAttributeException, it's too slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17728

EvalHelper should not throw NullAttributeException, it's too slow





--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 15:51 ---
Ah, sorry. You're right, Nick. The last time I looked at the code, it was 
calling evalNotNull() directly, rather than EvalHelper.eval(). The former does 
not throw an exception if no value is specified.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17728] - EvalHelper should not throw NullAttributeException, it's too slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17728

EvalHelper should not throw NullAttributeException, it's too slow





--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 15:46 ---
I don't know enough about the EL tags to make a judgement but I can say that 
exceptions shouldn't be used as a common execution path.  There is 0 overhead 
for executing in a try/catch block until you throw an exception.  If it's 
reasonable for the eval() method to return null then we should do that instead 
of throwing an exception.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17728] - EvalHelper should not throw NullAttributeException, it's too slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17728

EvalHelper should not throw NullAttributeException, it's too slow

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 15:37 ---
You're wrong,

Look at the code, I even ran it through a profiler and this identifies the 
bottleneck.

public final class EvalHelper
{
private EvalHelper() {}

public static Object eval(String  tagName,
  String  attrName,
  String  attrValue,
  Class   attrType,
  Tag tagObject,
  PageContext pageContext)
throws JspException, NullAttributeException
{
Object result   =
ExpressionUtil.evalNotNull(tagName, attrName, attrValue,
   attrType, tagObject, pageContext);
if (result == null)
throw new NullAttributeException(attrName, tagName);
return (result);
}
}


When ExpressionUtil returns null, a NullAttributeException is thrown.  The EL 
Tags call this for every attribute, catch the NullAttributeException and enter 
a default.  For example, here is a snippet from the ELSizeTag.java

try {
setName((String) evalAttr("name", getName(), String.class));
} catch (NullAttributeException ex) {
setName(null);
}


Name is an optional attribute since you can specify collection.  If you use the 
collection object on this tag it will always throw at least 2 
NullAttributeException  exceptions since name and property aren't filled in.  
The overhead of the exception in both creating an I18N string and and also 
additional garbage collection is uneeded.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17728] - EvalHelper should not throw NullAttributeException, it's too slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17728

EvalHelper should not throw NullAttributeException, it's too slow

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-03-06 15:31 ---
You are misundersanding what evalNotNull() does. A NullAttributeException is 
thrown only if a value *is* specified for the attribute, and that value is an 
expression that evaluates to null. If no value is specified for the attribute, 
evalNotNull() does *not* throw an exception, it simply returns null.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17728] New: - EvalHelper should not throw NullAttributeException, it's too slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17728

EvalHelper should not throw NullAttributeException, it's too slow

   Summary: EvalHelper should not throw NullAttributeException, it's
too slow
   Product: Struts
   Version: 1.1 RC1
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Major
  Priority: Other
 Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


NullAttributeException invokes the standard taglibs Resource.getMessage routine 
for the exception message.  This is uneeded overhead since the message is never 
displayed to an end-user and only used to fill in default values on the 
extended el tags.

Since many tags have optional attributes, the EvalUtil will throw many 
NullAttributeExceptions.  Inserting tags in a loop will generate hundreds of 
these exceptions in a single page creating lag for 1 page easily between 5-20 
sec.

You could throw a different exception that had a simple string that did not 
have to be calculated which would be faster, but this would also generate a lot 
of objects to be garbage collected also slowing the system.

Consider either returning null and letting the calling function take 
appropriate action, or convienience functions that return a default value that 
can be passed into the function when the expression evaluates to null.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: My dilema: Much improved version of requiredif ready, 1.1 or 1.2?

[James Turner]

> James,
> I haven't even been able to figure out requiredif!  I think 
> your feature is 
> great but we need to show some discipline and maintain the 
> 1.1 freeze.  IMO, 
> this should be a definite addition for 1.2.

I can live with that, I can stick it in the nightly build after we
finally ship this puppy.

> I have no idea about the issues with JavaCC.  Does it mean 
> that there's no 
> source file, just a generated class file?

It generates Java files from a .jtt grammer description file (much like
yacc/bison works).  I can check in both the .jtt file and the generated
java files.

James



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: New PMD and Checkstyle tasks

[David Graham]

At the bottom of every email sent to the list is a link to unsubscribe.  It 
can't get any easier/clearer than that.

David



From: "Dasgupta, Diptiman (Cognizant)" <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: "Struts Developers List" <[EMAIL PROTECTED]>
Subject: RE: New PMD and Checkstyle tasks
Date: Thu, 6 Mar 2003 15:21:36 +0530
Hi,

  Pls unsubscribe me

-Original Message-
From: Bill Chmura [mailto:[EMAIL PROTECTED]
Sent: Monday, January 06, 2003 9:25 AM
To: 'Struts Developers List'
Subject: RE: New PMD and Checkstyle tasks


I have not contributed any code directly to the Struts project, so I
feel a little squimish about saying it - but I would put forth, humbly,
that maybe just following the Jakarta (hence Sun) standards would be the
best thing to aim for.
I am sure that everyone would agree that having unused imports removed
would be good, also dead code removal would also be a nice thing I am
sure everyone would agree...  But starting a discussion on where the {}
should be, etc, could be a little like igniting a holy war...
Obviously you all can decide it, but I would almost approach it from
"discuss why not to use the existing standards" point of view...
Just my thoughts

-Original Message-
From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]
Sent: Sunday, January 05, 2003 6:35 PM
To: Struts Developers List
Subject: RE: New PMD and Checkstyle tasks


On Sun, 5 Jan 2003, Martin Cooper wrote:

> Date: Sun, 5 Jan 2003 12:32:25 -0800 (PST)
> From: Martin Cooper <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: Struts Developers List <[EMAIL PROTECTED]>
> Subject: RE: New PMD and Checkstyle tasks
>
>
>
> On Sun, 5 Jan 2003, Bill Chmura wrote:
>
> >
> > Sounds great... I've used checkstyle for a while now and it has done
> > a good job for the most part.
> >
> > About the 9,000 errors it produced (maybe errors is not the right
> > word)
>
> Yah - perhaps I should have said 'violations'.
>
> > - a good many of them are probably due to the difference between the
> > Sun Coding standards and the Apache coding standards.  I have mostly
>
> Well, the default coding conventions in Jakarta *are* the Sun coding
> conventions, so I'd say we have a problem... ;-)
>
That's something we can change if we want to define our own (Struts
project wide) standards.  I'm game if people want to spend some time
doing this (although I've got some emotional attachment to certain
stylistic patterns, it's not the most important thing in the world).
The existing code base, as many have observed, does *not* conform to a
single specific style standard, because it (and my personal adaptation
of the Sun coding standards) evolved over time and/or I finally started
doing some things ({ ... } around single-statement conditionals) that I
should have been doing from the very beginning.
It would help the readability of the code (and therefore
understandability for all developers) to have a single commonly used
style.  However, I've got two requests:
* Let's have a *very* brief discussion and agreement on
  a single style, if we can.  I've seen marriages break
  up over the color of a carpet -- developers fighting
  over this issue would be equaly stupid.
* Once we decide on a style, the task of adadpting the
  existing code starts.  Please ensure that, if you're
  doing the checkins for that, you ***only*** do the
  formatting changes on a single commit -- no sneaking
  functionality changes in :-).
> --
> Martin Cooper
>
Craig

--
To unsubscribe, e-mail:

For additional commands, e-mail:

--
To unsubscribe, e-mail:   

For additional commands, e-mail: 


<< InterScan_SafeStamp.txt >>
<< InterScan_Disclaimer.txt >>
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


_
STOP MORE SPAM with the new MSN 8 and get 2 months FREE*  
http://join.msn.com/?page=features/junkmail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: My dilema: Much improved version of requiredif ready, 1.1 or 1.2?

[David Graham]

James,
I haven't even been able to figure out requiredif!  I think your feature is 
great but we need to show some discipline and maintain the 1.1 freeze.  IMO, 
this should be a definite addition for 1.2.

I have no idea about the issues with JavaCC.  Does it mean that there's no 
source file, just a generated class file?

Dave



From: "James Turner" <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: "'Struts Developers List'" <[EMAIL PROTECTED]>
Subject: RE: My dilema: Much improved version of requiredif ready, 1.1 or 
1.2?
Date: Thu, 6 Mar 2003 01:42:25 -0500

Actually, I realized just after I sent this that if I took the required
part out and called it validwhen instead, you end up with a true general
purpose validation tool!  So that's the one I'm proposing.  Basically,
if you had a field lastName that was required if firstName was filled
in, you say:
((lastName != null) or (firstName == null))

I.e., the field is valid if it isn't null, or the firstName field is
null.
This means you can generate an error on a field based solely on the
values of other fields.
James



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


_
The new MSN 8: smart spam protection and 2 months FREE*  
http://join.msn.com/?page=features/junkmail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: New PMD and Checkstyle tasks

[Asif Qamar]

To unsubscribe, e-mail:   
For additional commands, e-mail: 


On Thursday 06 March 2003 01:51, Dasgupta, Diptiman (Cognizant) wrote:
> Hi,
>
>   Pls unsubscribe me
>
> -Original Message-
> From: Bill Chmura [mailto:[EMAIL PROTECTED]
> Sent: Monday, January 06, 2003 9:25 AM
> To: 'Struts Developers List'
> Subject: RE: New PMD and Checkstyle tasks
>
>
>
> I have not contributed any code directly to the Struts project, so I
> feel a little squimish about saying it - but I would put forth, humbly,
> that maybe just following the Jakarta (hence Sun) standards would be the
> best thing to aim for.
>
> I am sure that everyone would agree that having unused imports removed
> would be good, also dead code removal would also be a nice thing I am
> sure everyone would agree...  But starting a discussion on where the {}
> should be, etc, could be a little like igniting a holy war...
>
> Obviously you all can decide it, but I would almost approach it from
> "discuss why not to use the existing standards" point of view...
>
> Just my thoughts
>
>
> -Original Message-
> From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]
> Sent: Sunday, January 05, 2003 6:35 PM
> To: Struts Developers List
> Subject: RE: New PMD and Checkstyle tasks
>
> On Sun, 5 Jan 2003, Martin Cooper wrote:
> > Date: Sun, 5 Jan 2003 12:32:25 -0800 (PST)
> > From: Martin Cooper <[EMAIL PROTECTED]>
> > Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> > To: Struts Developers List <[EMAIL PROTECTED]>
> > Subject: RE: New PMD and Checkstyle tasks
> >
> > On Sun, 5 Jan 2003, Bill Chmura wrote:
> > > Sounds great... I've used checkstyle for a while now and it has done
> > >
> > > a good job for the most part.
> > >
> > > About the 9,000 errors it produced (maybe errors is not the right
> > > word)
> >
> > Yah - perhaps I should have said 'violations'.
> >
> > > - a good many of them are probably due to the difference between the
> > >
> > > Sun Coding standards and the Apache coding standards.  I have mostly
> >
> > Well, the default coding conventions in Jakarta *are* the Sun coding
> > conventions, so I'd say we have a problem... ;-)
>
> That's something we can change if we want to define our own (Struts
> project wide) standards.  I'm game if people want to spend some time
> doing this (although I've got some emotional attachment to certain
> stylistic patterns, it's not the most important thing in the world).
>
> The existing code base, as many have observed, does *not* conform to a
> single specific style standard, because it (and my personal adaptation
> of the Sun coding standards) evolved over time and/or I finally started
> doing some things ({ ... } around single-statement conditionals) that I
> should have been doing from the very beginning.
>
> It would help the readability of the code (and therefore
> understandability for all developers) to have a single commonly used
> style.  However, I've got two requests:
>
> * Let's have a *very* brief discussion and agreement on
>   a single style, if we can.  I've seen marriages break
>   up over the color of a carpet -- developers fighting
>   over this issue would be equaly stupid.
>
> * Once we decide on a style, the task of adadpting the
>   existing code starts.  Please ensure that, if you're
>   doing the checkins for that, you ***only*** do the
>   formatting changes on a single commit -- no sneaking
>   functionality changes in :-).
>
> > --
> > Martin Cooper
>
> Craig


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: New PMD and Checkstyle tasks

[Dasgupta, Diptiman (Cognizant)]

Hi,

  Pls unsubscribe me 

-Original Message-
From: Bill Chmura [mailto:[EMAIL PROTECTED]
Sent: Monday, January 06, 2003 9:25 AM
To: 'Struts Developers List'
Subject: RE: New PMD and Checkstyle tasks



I have not contributed any code directly to the Struts project, so I
feel a little squimish about saying it - but I would put forth, humbly,
that maybe just following the Jakarta (hence Sun) standards would be the
best thing to aim for.  

I am sure that everyone would agree that having unused imports removed
would be good, also dead code removal would also be a nice thing I am
sure everyone would agree...  But starting a discussion on where the {}
should be, etc, could be a little like igniting a holy war...

Obviously you all can decide it, but I would almost approach it from
"discuss why not to use the existing standards" point of view...

Just my thoughts


-Original Message-
From: Craig R. McClanahan [mailto:[EMAIL PROTECTED] 
Sent: Sunday, January 05, 2003 6:35 PM
To: Struts Developers List
Subject: RE: New PMD and Checkstyle tasks




On Sun, 5 Jan 2003, Martin Cooper wrote:

> Date: Sun, 5 Jan 2003 12:32:25 -0800 (PST)
> From: Martin Cooper <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: Struts Developers List <[EMAIL PROTECTED]>
> Subject: RE: New PMD and Checkstyle tasks
>
>
>
> On Sun, 5 Jan 2003, Bill Chmura wrote:
>
> >
> > Sounds great... I've used checkstyle for a while now and it has done

> > a good job for the most part.
> >
> > About the 9,000 errors it produced (maybe errors is not the right 
> > word)
>
> Yah - perhaps I should have said 'violations'.
>
> > - a good many of them are probably due to the difference between the

> > Sun Coding standards and the Apache coding standards.  I have mostly
>
> Well, the default coding conventions in Jakarta *are* the Sun coding 
> conventions, so I'd say we have a problem... ;-)
>

That's something we can change if we want to define our own (Struts
project wide) standards.  I'm game if people want to spend some time
doing this (although I've got some emotional attachment to certain
stylistic patterns, it's not the most important thing in the world).

The existing code base, as many have observed, does *not* conform to a
single specific style standard, because it (and my personal adaptation
of the Sun coding standards) evolved over time and/or I finally started
doing some things ({ ... } around single-statement conditionals) that I
should have been doing from the very beginning.

It would help the readability of the code (and therefore
understandability for all developers) to have a single commonly used
style.  However, I've got two requests:

* Let's have a *very* brief discussion and agreement on
  a single style, if we can.  I've seen marriages break
  up over the color of a carpet -- developers fighting
  over this issue would be equaly stupid.

* Once we decide on a style, the task of adadpting the
  existing code starts.  Please ensure that, if you're
  doing the checkins for that, you ***only*** do the
  formatting changes on a single commit -- no sneaking
  functionality changes in :-).

> --
> Martin Cooper
>

Craig


--
To unsubscribe, e-mail:

For additional commands, e-mail:



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

** Message from InterScan E-Mail VirusWall NT **

** No virus found in attached file noname.htm

No Virus detected in the attached file(s).
* End of message ***


This e-mail and any files transmitted with it are for the sole use of the intended 
recipient(s) and may contain confidential and privileged information. If you are not 
the 
intended recipient, please contact the sender by reply e-mail and destroy all copies 
of 
the original message. 
Any unauthorised review, use, disclosure, dissemination, forwarding, printing or 
copying 
of this email or any action taken in reliance on this e-mail is strictly prohibited 
and 
may be unlawful.

  Visit us at http://www.cognizant.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: My dilema: Much improved version of requiredif ready, 1.1 or 1.2?

[Erik Hatcher]

Just food for thought:

How about using the OGNL expression language (www.ognl.org) rather than 
writing your own parser?  WebWork, Tapestry, and certainly others, are 
using OGNL.  (and the creator of it is a good friend of mine!)

	Erik

On Thursday, March 6, 2003, at 12:56  AM, James Turner wrote:
As I'm sure we've all noticed, the "requiredif" validation, although
seeming to be very popular, is a bear for first time users to
comprehend.  With that in mind, I've just finished a new validation
(which I'm calling "requiredwhen" to avoid confusion), which is much
simpler.  Here's a sample rule:

  
  
test
(dependents[].lastName != null)
  

As you can see, you can now put any arbitrary booolean expression as 
the
test for required.  For example:

((dependents[].lastName == "James") and (options[1] == "true"))

If the parser sees "[]", it replaces it with the indexed property value
of the target field.
Here's the dilema.  I think it's a lot better than "requiredif", will
generate a lot less questions on struts-users, and let people do the
general types of checking they seem to want to do.  Also, since it's
just another rule being added to the Validation set, it shouldn't be
able to destabilize anything else in the release.  However, since it is
a new feature, I hesitate to add it to 1.1 because we're in freeze.
What do other people think?  Also, I used JavaCC to generate the 
parser,
there's should never be a need to regenerate the java files from the 
jtt
source, but should someone want to do it, they'd need to download
JavaCC.  Will this be a problem?

James

  New Gig!
 |   |   |   |   |   |   |   |
\|/ \|/ \|/ \|/ \|/ \|/ \|/ \|/
 V   V   V   V   V   V   V   V
Director of Software Development
Benefit Systems, Inc.
[EMAIL PROTECTED]
Voice: 603-216-1620
Fax: 317-573-2016


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]