Re: Is the struts example itself is multi-thread safe?
Thank you, Craig for clear "picture". One Q. to be sure that all OK. What about servlet.log file? Several action threads will need to have an access to it.,... Maya "Craig R. McClanahan" wrote: Maya Muchnik wrote: Hi, In "A Walking Tour of the Struts App", the author has mentioned that "There is only one object for each action (URI), so your action objects must be multi-thread safe". Is the example itself is multi-thread safe? I am asking this, because are several actions here, but not one of them use "synchronized" statement. Maybe I am missing something... Possibly. Thread-safety is a general term meaning "even if two or more users are calling methods in my class *simultaneously*, nothing will get messed up. In the case of Action classes in the example application, they are indeed thread safe. Why? Primarily because they use no instance variables -- only local variables within the perform() method. If the example used instance variables, then there would be only one copy of those variables (because Struts creates only one instance of your Action). However, local variables appear on the stack for each request thread that is happening simultaneously. Any single thread can only see its own copy of these variables, so there is no possibility for contention. One place you will see synchronization in the example app is when adding to the pseudo-database. Consider what would happen if two users logged on with the same id, and both proceeded to add a new subscription at exactly the same moment. You would have two attempts to modify the database (which, because it is a servlet context attribute, is visible to all request processing threads), so you need to synchronize here. The other place that you commonly need to synchronize is when you are modifying session attributes (read-only access is generally safe without locking). It is surprisingly easy to have multiple requests active at the same time for the same session -- for example: * In a framed presentation, the browser will often issue requests for more than one frame at the same time, all with the same session id. * Users might open multiple browser windows, which (in many circumstances) causes each window to be part of the same session. * The user can submit a long running transaction, press STOP (which the server does not know about), and then start something else. THANKS in advance. Maya Craig
Re: Is the struts example itself is multi-thread safe?
Maya Muchnik wrote: Thank you, Craig for clear "picture". One Q. to be sure that all OK. What about servlet.log file? Several action threads will need to have an access to it.,... True, but that is the servlet container's problem to worry about. If you look inside Tomcat's implementation of ServletContext.log(), for example, you will indeed see synchronization. But your application need not worry. Maya Craig
Re: Is the struts example itself is multi-thread safe?
Maya Muchnik wrote: Hi, In "A Walking Tour of the Struts App", the author has mentioned that "There is only one object for each action (URI), so your action objects must be multi-thread safe". Is the example itself is multi-thread safe? I am asking this, because are several actions here, but not one of them use "synchronized" statement. Maybe I am missing something... Possibly. Thread-safety is a general term meaning "even if two or more users are calling methods in my class *simultaneously*, nothing will get messed up. In the case of Action classes in the example application, they are indeed thread safe. Why? Primarily because they use no instance variables -- only local variables within the perform() method. If the example used instance variables, then there would be only one copy of those variables (because Struts creates only one instance of your Action). However, local variables appear on the stack for each request thread that is happening simultaneously. Any single thread can only see its own copy of these variables, so there is no possibility for contention. One place you will see synchronization in the example app is when adding to the pseudo-database. Consider what would happen if two users logged on with the same id, and both proceeded to add a new subscription at exactly the same moment. You would have two attempts to modify the database (which, because it is a servlet context attribute, is visible to all request processing threads), so you need to synchronize here. The other place that you commonly need to synchronize is when you are modifying session attributes (read-only access is generally safe without locking). It is surprisingly easy to have multiple requests active at the same time for the same session -- for example: * In a framed presentation, the browser will often issue requests for more than one frame at the same time, all with the same session id. * Users might open multiple browser windows, which (in many circumstances) causes each window to be part of the same session. * The user can submit a long running transaction, press STOP (which the server does not know about), and then start something else. THANKS in advance. Maya Craig
RE: Is the struts example itself is multi-thread safe?
The example is thread safe. Methods don't need to be synchronized if they aren't manipulating a shared object such as an instance variable. If your action class doesn't have any instance variables and it only deals with local variables and parameters then there is a good bet that it is thread safe. Hal -Original Message- From: Maya Muchnik [mailto:[EMAIL PROTECTED]] Sent: Tuesday, February 27, 2001 5:09 PM To: [EMAIL PROTECTED] Subject: Is the struts example itself is multi-thread safe? Hi, In "A Walking Tour of the Struts App", the author has mentioned that "There is only one object for each action (URI), so your action objects must be multi-thread safe". Is the example itself is multi-thread safe? I am asking this, because are several actions here, but not one of them use "synchronized" statement. Maybe I am missing something... THANKS in advance. Maya
