Re: WebKit -> WebEngine
On Sun, 31 Oct 2021 at 21:20, Dirk Hohndel wrote: > > > On Oct 31, 2021, at 11:58 AM, Robert Helling wrote: > > thanks for the responses Dirk and Robert. i read the other threads to got more familiar with the rest of the problems with the Qt6 transition. > > For the time being, it shouldn’t be too much of a problem. I just have to > > reintroduce a number of #ifdefs to make the choice between WebEngine and > > WebKit optional depending on what is available for the system at hand. I > > just removed those as I was under the impression that the transition is a > > clear step forward. The transition does not add any functionality. I would > > only argue that it simplifies the printing logic quite a bit. > While I think that having the cleaner code would be a huge win - if we > completely lose Windows support (still our largest user group - but Android > is catching up), that would suck. And of course, eventually we'll have to transition to Qt 6 everywhere, including Windows, but we'll burn that bridge when we get there :/ having the #ifdefs and continuing to build for Windows using Qt5 + WebKit seems like an OK temporary solution here. as mentioned earlier, i can help with reviews. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: WebKit -> WebEngine
> On Oct 31, 2021, at 11:58 AM, Robert Helling wrote: > > My understanding was that from Qt, the announced direction was clear: Abandon > WebKit and move to WebEngine! For example, for a while Qt5 stopped shipping > WebKit at all with its binaries and you had to build it yourself for every > new version. And this seems to be even stronger with Qt6, it was my > understanding that WebKit is dropped for good. Correct > I made this new attempt because a) I was tired of building WebKit myself and > even more as a step towards moving to Qt6 (which seems to be the only hope to > have support for Apple Silicone at all in any kind of near future). But as > mentioned in the other thread, it is by far the only obstacle of moving to > Qt6. Yes, there are a hand full. I addressed one recently with the removal of QRegExp. And I think most of the others will be similarly easy to address. This is all one of those issues of "TIME". It's a weird concept. And there never seems to be enough. I'd love to see someone else take the lead on that - but as we all know, there aren't a lot of people left who are actively working on Subsurface, and even fewer who are comfortable working on Qt things... > For the time being, it shouldn’t be too much of a problem. I just have to > reintroduce a number of #ifdefs to make the choice between WebEngine and > WebKit optional depending on what is available for the system at hand. I just > removed those as I was under the impression that the transition is a clear > step forward. The transition does not add any functionality. I would only > argue that it simplifies the printing logic quite a bit. While I think that having the cleaner code would be a huge win - if we completely lose Windows support (still our largest user group - but Android is catching up), that would suck. And of course, eventually we'll have to transition to Qt 6 everywhere, including Windows, but we'll burn that bridge when we get there :/ Thanks for your work on this. It is TRULY appreciated. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: WebKit -> WebEngine
> On Oct 31, 2021, at 10:23 AM, Lubomir I. Ivanov wrote: > > i think the major blocker here was that building QWebEngine on Windows > does not work with MINGW. required MSVC. > https://doc.qt.io/qt-5/qtwebengine-platform-notes.html#all-platforms > >>> Visual Studio 2017 version 15.8 or later, or clang-cl version 8 or later > > they seem to support clang now as well. > > the framework we are using to cross-build Subsurface from Linux to > Windows (MXE) did not provide QWebEngine binaries. > has this changed? > > porting from WebKit to WebEngine is fine, but if we can't build it and > deploy it with the current set of tools, that's a problem. > cc Dirk, as he might remember these details better. > > one question i would have is - what is the motivation for this port > and what do we gain from it? QtWebKit isn't supporting Qt 6 and the maintainers seem have all disappeared with not activity in the repo for over a year. A couple of questions here and there all resulted in "this is EOL, move to something else". I had forgotten about the QWebEngine and MXE issue. MXE of course doesn't have Qt 6 at all, yet. And it has QtWebKit and QtWebView, but not QtWebEngine. So that's something I will need to also look into. This is the largest pain in all this. The support matrix for the various technology choices that we have :( /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile
Could you send me a more complete log? Which OS are you on? Which app (exact version) are you using? Thanks /D > On Oct 31, 2021, at 3:10 AM, Enzo Falchetti wrote: > > Salve non riesco più a sincronizzare le immersioni con divelogs.de mi dice: > "Errore di rete 6" > > Inviato dal mio tablet Huawei ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Fwd: WebKit -> WebEngine
Good stuff Robert. Thank you. Kind regards, willem. On Sun, 31 Oct 2021, 19:01 Lubomir I. Ivanov via subsurface, < subsurface@subsurface-divelog.org> wrote: > On Sun, 31 Oct 2021 at 17:12, Robert Helling wrote: > > > > HI everybody, > > > > I wanted to report on my progress in replacing Subsurface’s use of > WebKit by WebEngine. I had already done this in the part of the user > manual, but as this transition was only fragmentary at the time the > corresponding code was removed at a later point. > > > > So I reinserted it and also made quite some progress on the printing > part. So much that I want to share it with you at this point. You can find > it at > > > > https://github.com/atdotde/subsurface/tree/webengineagain > > > > I removed a lot of code originally contributed by Gehad ElRobey as a > GSoC student in 2015 but what I have now appears to be a lot simpler to me. > > > > It still requires some cleaning up and there are a few things to fix. > Specifically, at the moment, the print preview is broken and there is a > mysterious empty page at the end of the print out. But I think the bulk of > the work is done and it is time more eyes should have a look. I particular > I would like to hear from Lubomir as he was the project’s mentor at the > time IIRC. > > > > hi Robert. > > thank you for working on this. > it was discussed in the past that the WebEngine change has to happen > eventually, but i think i recall blockers outside of the usage in > printing and user manual - e.g. build process, distribution? > could be wrong, not remembering correctly. if that is not longer the > case, great... > > overall, if the printing "stack" port is one-to-one with the old code > and we are not introducing user visible regressions this seems fine. > if you send a PR broken into relevant commits i can try to find time > for review, but likely only code review, without building and testing > locally. > > lubomir > -- > ___ > subsurface mailing list > subsurface@subsurface-divelog.org > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface > ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: WebKit -> WebEngine
On Sun, 31 Oct 2021 at 17:12, Robert Helling wrote: > > HI everybody, > > I wanted to report on my progress in replacing Subsurface’s use of WebKit by > WebEngine. I had already done this in the part of the user manual, but as > this transition was only fragmentary at the time the corresponding code was > removed at a later point. > > So I reinserted it and also made quite some progress on the printing part. So > much that I want to share it with you at this point. You can find it at > > https://github.com/atdotde/subsurface/tree/webengineagain > > I removed a lot of code originally contributed by Gehad ElRobey as a GSoC > student in 2015 but what I have now appears to be a lot simpler to me. > > It still requires some cleaning up and there are a few things to fix. > Specifically, at the moment, the print preview is broken and there is a > mysterious empty page at the end of the print out. But I think the bulk of > the work is done and it is time more eyes should have a look. I particular I > would like to hear from Lubomir as he was the project’s mentor at the time > IIRC. > hi Robert. thank you for working on this. it was discussed in the past that the WebEngine change has to happen eventually, but i think i recall blockers outside of the usage in printing and user manual - e.g. build process, distribution? could be wrong, not remembering correctly. if that is not longer the case, great... overall, if the printing "stack" port is one-to-one with the old code and we are not introducing user visible regressions this seems fine. if you send a PR broken into relevant commits i can try to find time for review, but likely only code review, without building and testing locally. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
WebKit -> WebEngine
HI everybody, I wanted to report on my progress in replacing Subsurface’s use of WebKit by WebEngine. I had already done this in the part of the user manual, but as this transition was only fragmentary at the time the corresponding code was removed at a later point. So I reinserted it and also made quite some progress on the printing part. So much that I want to share it with you at this point. You can find it at https://github.com/atdotde/subsurface/tree/webengineagain I removed a lot of code originally contributed by Gehad ElRobey as a GSoC student in 2015 but what I have now appears to be a lot simpler to me. It still requires some cleaning up and there are a few things to fix. Specifically, at the moment, the print preview is broken and there is a mysterious empty page at the end of the print out. But I think the bulk of the work is done and it is time more eyes should have a look. I particular I would like to hear from Lubomir as he was the project’s mentor at the time IIRC. Best Robert signature.asc Description: Message signed with OpenPGP ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
