Re: [Sugar-devel] [Dextrose] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.
Steven, can we apply this patch to dextrose? It's a big usability fix.
Reviewed-by: Bernie Innocenti
On Sat, 2010-11-13 at 08:15 -0500, Gonzalo Odiard wrote:
> Reviewed-By: gonz...@laptop.org
>
> On Sat, Nov 13, 2010 at 7:08 AM, wrote:
> From: Shanjit Singh Jajmann
>
> Muting by clicking on the icon is killed.
> ---
> extensions/deviceicon/speaker.py | 10 --
> 1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/extensions/deviceicon/speaker.py
> b/extensions/deviceicon/speaker.py
> index 3a54464..4242105 100644
> --- a/extensions/deviceicon/speaker.py
> +++ b/extensions/deviceicon/speaker.py
> @@ -50,9 +50,6 @@ class DeviceView(TrayIcon):
>
> self.connect('expose-event', self.__expose_event_cb)
>
> -self._icon_widget.connect('button-release-event',
> -
> self.__button_release_event_cb)
> -
> self._update_info()
>
> def create_palette(self):
> @@ -73,13 +70,6 @@ class DeviceView(TrayIcon):
> self.icon.props.icon_name = get_icon_state(name,
> current_level, step=-1)
> self.icon.props.xo_color = xo_color
>
> -def __button_release_event_cb(self, widget, event):
> -if event.button == 1:
> -self._model.props.muted = not
> self._model.props.muted
> -return True
> -else:
> -return False
> -
> def __expose_event_cb(self, *args):
> self._update_info()
>
> --
> 1.7.2.2
>
> ___
> Sugar-devel mailing list
> Sugar-devel@lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
> ___
> Dextrose mailing list
> dextr...@lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/dextrose
--
// Bernie Innocenti - http://codewiz.org/
\X/ Sugar Labs - http://sugarlabs.org/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH V3] Copying files multiple times results in bogus names. (SL#2060)
On 13 November 2010 11:41, wrote: > From: Shanjit Singh Jajmann > > For every existing file copied to the location, the names are explicitly > changed to filename_copynumber.extension e.g. games_1.png, games_2.png, > games_3.jpg and so on. > > --- > v1 -> v2. Parenthesis idea removed, i initialised from 1. > Recommendations by Gonzalo Odiard, James Cameron and Martin Dengler added. You still missed my point. And anything after "---" gets removed in the commit message. My point is that this patch is written by Gonzalo Odiard. You can see it clearly in this email thread on November 10th. Therefore the first line of your patch should be: From: Gonzalo Odiard It's still OK for you to submit the patch even though you didn't write it, and Gonzalo would probably even appreciate you taking on the role of submission, but its important that you put the correct authorship. Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.
Reviewed-By: gonz...@laptop.org
On Sat, Nov 13, 2010 at 7:08 AM, wrote:
> From: Shanjit Singh Jajmann
>
> Muting by clicking on the icon is killed.
> ---
> extensions/deviceicon/speaker.py | 10 --
> 1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/extensions/deviceicon/speaker.py
> b/extensions/deviceicon/speaker.py
> index 3a54464..4242105 100644
> --- a/extensions/deviceicon/speaker.py
> +++ b/extensions/deviceicon/speaker.py
> @@ -50,9 +50,6 @@ class DeviceView(TrayIcon):
>
> self.connect('expose-event', self.__expose_event_cb)
>
> -self._icon_widget.connect('button-release-event',
> - self.__button_release_event_cb)
> -
> self._update_info()
>
> def create_palette(self):
> @@ -73,13 +70,6 @@ class DeviceView(TrayIcon):
> self.icon.props.icon_name = get_icon_state(name, current_level,
> step=-1)
> self.icon.props.xo_color = xo_color
>
> -def __button_release_event_cb(self, widget, event):
> -if event.button == 1:
> -self._model.props.muted = not self._model.props.muted
> -return True
> -else:
> -return False
> -
> def __expose_event_cb(self, *args):
> self._update_info()
>
> --
> 1.7.2.2
>
> ___
> Sugar-devel mailing list
> Sugar-devel@lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Feature Request "Kill the "Mute" function on the volume icon in the frame"
On 11/13/2010 01:03 PM, Shanjit Singh Jajmann wrote: Team, I am working on the Dextrose TODO list[1], I am doing the "Kill the "Mute" function on the volume icon in the frame" one, under the UI changes heading. I have created a Wiki page regarding my progress on the feature request[2], i would request you to have a look at it. Feedback would be appreciated. Shan [1] : http://wiki.sugarlabs.org/go/Dextrose/TODO [2] : http://wiki.sugarlabs.org/go/Kill_the_mute_function_in_the_volume_icon_of_the_frame Can you explain, why you want to remove that functionality? What issue does it try to solve? Thanks, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.
From: Shanjit Singh Jajmann
Muting by clicking on the icon is killed.
---
extensions/deviceicon/speaker.py | 10 --
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/extensions/deviceicon/speaker.py b/extensions/deviceicon/speaker.py
index 3a54464..4242105 100644
--- a/extensions/deviceicon/speaker.py
+++ b/extensions/deviceicon/speaker.py
@@ -50,9 +50,6 @@ class DeviceView(TrayIcon):
self.connect('expose-event', self.__expose_event_cb)
-self._icon_widget.connect('button-release-event',
- self.__button_release_event_cb)
-
self._update_info()
def create_palette(self):
@@ -73,13 +70,6 @@ class DeviceView(TrayIcon):
self.icon.props.icon_name = get_icon_state(name, current_level,
step=-1)
self.icon.props.xo_color = xo_color
-def __button_release_event_cb(self, widget, event):
-if event.button == 1:
-self._model.props.muted = not self._model.props.muted
-return True
-else:
-return False
-
def __expose_event_cb(self, *args):
self._update_info()
--
1.7.2.2
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] Feature Request "Kill the "Mute" function on the volume icon in the frame"
Team, I am working on the Dextrose TODO list[1], I am doing the "Kill the "Mute" function on the volume icon in the frame" one, under the UI changes heading. I have created a Wiki page regarding my progress on the feature request[2], i would request you to have a look at it. Feedback would be appreciated. Shan [1] : http://wiki.sugarlabs.org/go/Dextrose/TODO [2] : http://wiki.sugarlabs.org/go/Kill_the_mute_function_in_the_volume_icon_of_the_frame ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH V3] Copying files multiple times results in bogus names. (SL#2060)
From: Shanjit Singh Jajmann For every existing file copied to the location, the names are explicitly changed to filename_copynumber.extension e.g. games_1.png, games_2.png, games_3.jpg and so on. --- v1 -> v2. Parenthesis idea removed, i initialised from 1. Recommendations by Gonzalo Odiard, James Cameron and Martin Dengler added. v2 -> v3. Line wrapping and .extension added. --- src/jarabe/journal/model.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/jarabe/journal/model.py b/src/jarabe/journal/model.py index 81ca7d4..81d1663 100644 --- a/src/jarabe/journal/model.py +++ b/src/jarabe/journal/model.py @@ -529,8 +529,8 @@ def _get_file_name(title, mime_type): def _get_unique_file_name(mount_point, file_name): if os.path.exists(os.path.join(mount_point, file_name)): i = 1 +name, extension = os.path.splitext(file_name) while len(file_name) <= 255: -name, extension = os.path.splitext(file_name) file_name = name + '_' + str(i) + extension if not os.path.exists(os.path.join(mount_point, file_name)): break -- 1.7.2.2 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH V3] Copying files multiple times results in bogus names. (SL#2060)
Daniel I thank you for your suggestion and feedback. I would be adding the names of the people, whose recommendations have been taken into consideration while submitting the patch. Shan On Sat, Nov 13, 2010 at 6:32 AM, Daniel Drake wrote: > On 12 November 2010 19:01, wrote: > > From: Shanjit Singh Jajmann > > This is not your own work. You shouldn't put your name on it like this. > > Daniel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
