Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-12-06 Thread Shanjit Singh Jajmann 
Team,

I thank you all for having a look at the patch and for recommending
necessary changes.

I am sending a revised patch for the same.

Feedback and Response appreciated.


Shan

On Sat, Nov 13, 2010 at 6:45 PM, Gonzalo Odiard gonz...@laptop.org wrote:

 Reviewed-By: gonz...@laptop.org


 On Sat, Nov 13, 2010 at 7:08 AM, shan...@seeta.in wrote:

 From: Shanjit Singh Jajmann shan...@seeta.in

 Muting by clicking on the icon is killed.
 ---
  extensions/deviceicon/speaker.py |   10 --
  1 files changed, 0 insertions(+), 10 deletions(-)

 diff --git a/extensions/deviceicon/speaker.py
 b/extensions/deviceicon/speaker.py
 index 3a54464..4242105 100644
 --- a/extensions/deviceicon/speaker.py
 +++ b/extensions/deviceicon/speaker.py
 @@ -50,9 +50,6 @@ class DeviceView(TrayIcon):

 self.connect('expose-event', self.__expose_event_cb)

 -self._icon_widget.connect('button-release-event',
 -  self.__button_release_event_cb)
 -
 self._update_info()

 def create_palette(self):
 @@ -73,13 +70,6 @@ class DeviceView(TrayIcon):
 self.icon.props.icon_name = get_icon_state(name, current_level,
 step=-1)
 self.icon.props.xo_color = xo_color

 -def __button_release_event_cb(self, widget, event):
 -if event.button == 1:
 -self._model.props.muted = not self._model.props.muted
 -return True
 -else:
 -return False
 -
 def __expose_event_cb(self, *args):
 self._update_info()

 --
 1.7.2.2

 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel



___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-12-06 Thread Shanjit Singh Jajmann 
Team,

I tried sending a patch to this thread by following the standard procedure
of copying and pasting the message id to the in-reply-to : . However, for
some reason the patch goes on to the different thread.

Please find the link to the patch, http://patchwork.sugarlabs.org/patch/519/


Shan

On Mon, Dec 6, 2010 at 4:36 PM, Shanjit Singh Jajmann shan...@seeta.inwrote:

 Team,

 I thank you all for having a look at the patch and for recommending
 necessary changes.

 I am sending a revised patch for the same.

 Feedback and Response appreciated.


 Shan


 On Sat, Nov 13, 2010 at 6:45 PM, Gonzalo Odiard gonz...@laptop.orgwrote:

 Reviewed-By: gonz...@laptop.org


 On Sat, Nov 13, 2010 at 7:08 AM, shan...@seeta.in wrote:

 From: Shanjit Singh Jajmann shan...@seeta.in

 Muting by clicking on the icon is killed.
 ---
  extensions/deviceicon/speaker.py |   10 --
  1 files changed, 0 insertions(+), 10 deletions(-)

 diff --git a/extensions/deviceicon/speaker.py
 b/extensions/deviceicon/speaker.py
 index 3a54464..4242105 100644
 --- a/extensions/deviceicon/speaker.py
 +++ b/extensions/deviceicon/speaker.py
 @@ -50,9 +50,6 @@ class DeviceView(TrayIcon):

 self.connect('expose-event', self.__expose_event_cb)

 -self._icon_widget.connect('button-release-event',
 -  self.__button_release_event_cb)
 -
 self._update_info()

 def create_palette(self):
 @@ -73,13 +70,6 @@ class DeviceView(TrayIcon):
 self.icon.props.icon_name = get_icon_state(name, current_level,
 step=-1)
 self.icon.props.xo_color = xo_color

 -def __button_release_event_cb(self, widget, event):
 -if event.button == 1:
 -self._model.props.muted = not self._model.props.muted
 -return True
 -else:
 -return False
 -
 def __expose_event_cb(self, *args):
 self._update_info()

 --
 1.7.2.2

 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel




___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH V3] Copying files multiple times results in bogus names. (SL#2060)

2010-11-13 Thread Shanjit Singh Jajmann 
Daniel

I thank you for your suggestion and feedback.

I would be adding the names of the people, whose recommendations have been
taken into consideration while submitting the patch.

Shan

On Sat, Nov 13, 2010 at 6:32 AM, Daniel Drake d...@laptop.org wrote:

 On 12 November 2010 19:01,  shan...@seeta.in wrote:
  From: Shanjit Singh Jajmann shan...@seeta.in

 This is not your own work. You shouldn't put your name on it like this.


 Daniel

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] Feature Request Kill the Mute function on the volume icon in the frame

2010-11-13 Thread Shanjit Singh Jajmann 
Team,

I am working on the Dextrose TODO list[1], I am doing the Kill the Mute
function on the volume icon in the frame one, under the UI changes heading.

I have created a Wiki page regarding my progress on the feature request[2],
i would request you to have a look at it.

Feedback would be appreciated.


Shan

[1] : http://wiki.sugarlabs.org/go/Dextrose/TODO
[2] :
http://wiki.sugarlabs.org/go/Kill_the_mute_function_in_the_volume_icon_of_the_frame
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [Dextrose] [PATCH] Copying files multiple times results in bogus names. (SL#2060)

2010-11-12 Thread Shanjit Singh Jajmann 
Hi all,

Firstly, I thank you all for having a look at the patch.

What i was trying to do was change the file names to
file_name(copy_number_of_the_file, starting with 2).
i had done so because of an earlier conversation with Aleksay and Sascha.

My most recent conversation with Aleksay has made me aware of the impact of
my changes and thus i would be incorporating the changes suggested above.


Thanks again.

Regards
Shan



On Thu, Nov 11, 2010 at 3:46 PM, Martin Dengler mar...@martindengler.comwrote:

 On Wed, Nov 10, 2010 at 05:57:18PM -0300, Gonzalo Odiard wrote:
  Mhh, is sufficient with doing the split out of the while

 looks good

  Gonzalo

 Martin


 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel


___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] SL. #2060 : Copying files multiple times results in bogus names.

2010-11-10 Thread Shanjit Singh Jajmann 
On Wed, Nov 10, 2010 at 5:20 PM, Shanjit Singh Jajmann shan...@seeta.inwrote:

 Hello Team,

 I am working on the Issue SL# 2060. It proposes to change the naming
 feature of files having the same name.


It changes the naming feature of the files (existing with the same name)
when copied to the volume.
Sorry for the error.
-Shan


 I invite everyone to look at the approach used, and provide feedback on
 both the approach and the implementation.

 A separate patch will also be put up shortly.

 Regards
 Shanjit Singh Jajmann

 1.
 http://wiki.sugarlabs.org/go/Copying_files_multiple_times_results_in_bogus_names
 2. http://bugs.sugarlabs.org/ticket/2060


___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] SL. #2060 : Copying files multiple times results in bogus names.

2010-11-10 Thread Shanjit Singh Jajmann 
Hello Team,

I am working on the Issue SL# 2060. It proposes to change the naming feature
of files having the same name.

I invite everyone to look at the approach used, and provide feedback on both
the approach and the implementation.

A separate patch will also be put up shortly.

Regards
Shanjit Singh Jajmann

1.
http://wiki.sugarlabs.org/go/Copying_files_multiple_times_results_in_bogus_names
2. http://bugs.sugarlabs.org/ticket/2060
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [Dextrose] [PATCH] Reduction in the time taken for loading of the menu (SL#1169)

2010-10-21 Thread Shanjit Singh Jajmann 
Bernie,

Thanks for your time to review the patch.

Glad you could provide pointers.

Thanks.

Regards
Shanjit Singh Jajmann
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH v2] Reduction in the time taken for loading of the menu (SL#1169)

2010-10-21 Thread Shanjit Singh Jajmann 
Sascha,


Thanks for your time and the review of the patch.

I will keep the the pointers in mind next time onwards.

The revised patch has been put up.


Regards
Shanjit Singh Jajmann
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH v3] Reduction in the time taken for loading of the menu (SL#1169)

2010-10-21 Thread Shanjit Singh Jajmann 
Sascha,


By mistake, i may have added a new thread.

Request you to kindly ignore that. Do consider the patch in this thread
only.


Thanks

Warm Regards
Shanjit Singh Jajmann
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [Design]: Issue SL 2164 (Downgrading activities not allowed)

2010-10-11 Thread Shanjit Singh Jajmann 
Team,

I am currently working on issue #2164 (
http://bugs.sugarlabs.org/ticket/2164 ) . Send my revised patch for review a
few minutes ago. Wish to thank Aleksey for his feedback and reviews.

In reference to Aleksey's comment on my patch yesterday -

What about less invasive implementation, ie, instead of changing three
files, it could be only popping up an alert in AlreadyInstalledException
try..except block, misc.py is a part of Journal and raising an alert
from it, sounds reasonable.

We have arrived at two approaches towards enabling this feature -

1. Instead of calling misc.resume in Listview  and then emitting the signal
to JournalActivity. Creating JournalActivty.resume , having the exact same
functionality as misc.resume. and calling it from listview.py and
implementing alertbox from there. We would then not be calling
misc.resume in Listview  and emitting the signal to JournalActivity, which
happens at this juncture in the code.

2. Replacing misc.resume to JournalActivity.resume everywhere, where ever
called.( in all files). Appropriate importing of methods and files will be
required to do this.

Wish if you could share your recommendations on the above two approaches -

Appreciate your support and feedback.

Thanks

Regards
Shan
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] Unwanted characters in mail to sugar-devel list serv when sending patch.

2010-10-02 Thread Shanjit Singh Jajmann 
Hi,

I just made patch for Issue 2324, and forwarded it to the list. A lot of
unwanted characters seem to have crept in, however when i send it to my
inbox, or any other, no such thing happens.

Could some pointers be provided to resolve this problem?


Regards

Shanjit
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] #1169 NORM: Drop down menus give no indication of their existence, also are too slow to load.

2010-10-02 Thread Shanjit Singh Jajmann 
Hi,

Appropriate changes have now been made to the issue and the patches have
also been uploaded. Changes have been made as suggested by FGrose in his
comment.

Wish if the patch could be reviewed.


Suggestions are welcome.


regards
Shan
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] Issue No. 2324. Implementing Copy/Paste using Clipboard in Abacus.

2010-10-01 Thread Shanjit Singh Jajmann 
Hi,


I am working on issue #2324, implementing Copy/Paste in Abacus Activity. I
had some doubts on the functionality of copy and paste.

According to what i have done,

1. The copy button when clicked copies any  expression/number present in the
output(bar) to the clipboard.

2. The paste button can however only  paste single numbers and not
expressions, on the output(bar).



Would this functionality be sufficient?


Regards

Shan
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] Bug No. #398

2010-09-29 Thread Shanjit Singh Jajmann 
-hilite', start, end)
+   # buffer.remove_tag_by_name('search-select', start, end)
+
+iter = buffer.get_start_iter()
+while True:
+next = iter.forward_search(text, 0)
+if next is None: break
+start, end = next
+buffer.apply_tag_by_name('search-hilite', start, end)
+iter = end
+
+if self.get_next_result('current'):
+self.search_next('current')
+elif self.get_next_result('backward'):
+self.search_next('backward')
+
+def get_next_result(self, dir):
+buffer = self._textview.get_buffer()
+
+if dir == 'forward':
+iter = buffer.get_iter_at_mark(buffer.get_insert())
+iter.forward_char()
+else:
+iter = buffer.get_iter_at_mark(buffer.get_insert())
+
+if dir == 'backward':
+return iter.backward_search(self.search_text, 0)
+else:
+return iter.forward_search(self.search_text, 0)
+
+def search_next(self, dir):
+next = self.get_next_result(dir)
+if next:
+buffer = self._textview.get_buffer()
+
+start, end = buffer.get_bounds()
+buffer.remove_tag_by_name('search-select', start, end)
+
+start, end = next
+buffer.apply_tag_by_name('search-select', start, end)
+
+buffer.place_cursor(start)
+
+self._textview.scroll_to_iter(start, 0.1)
+self._textview.scroll_to_iter(end, 0.1)
+




--

Regards

Shan




On Mon, Sep 27, 2010 at 8:25 PM, Tomeu Vizoso to...@sugarlabs.org wrote:

 On Mon, Sep 27, 2010 at 16:36, Shanjit Singh Jajmann
 shan...@dev.seeta.in wrote:
  Team,
 
  I am working on http://bugs.sugarlabs.org/ticket/398  : Regarding the
 search
  box, i have tried to introduce the same functionality as in the 'Log'
  activity, in the toolbar of viewsource (jarabe/view/viewscreen.py),
 however
  i have run into some searching and highlighting issues regarding working

 Without knowing which are the issues is a bit hard to know how to
 help. Can you be more explicit and also post the patch?

 Regards,

 Tomeu

  with gtksourceview used in the sourceview function of the same file.
 Could
  you please provide some pointers on how to achieve the searching and
  highlighting ? (i could not get the bounds of the buffer created,
 start,end
  . The highlight function has me confused as it isn't working) or any
 other
  approach if possible.
 
  Regards
  Shan
 
  ___
  Sugar-devel mailing list
  Sugar-devel@lists.sugarlabs.org
  http://lists.sugarlabs.org/listinfo/sugar-devel
 
 

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] Bug No. #398

2010-09-27 Thread Shanjit Singh Jajmann 
Team,

I am working on http://bugs.sugarlabs.org/ticket/398  : Regarding the search
box, i have tried to introduce the same functionality as in the 'Log'
activity, in the toolbar of viewsource (jarabe/view/viewscreen.py), however
i have run into some searching and highlighting issues regarding working
with gtksourceview used in the sourceview function of the same file. Could
you please provide some pointers on how to achieve the searching and
highlighting ? (i could not get the bounds of the buffer created, start,end
. The highlight function has me confused as it isn't working) or any other
approach if possible.

Regards
Shan
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] Bug No. #1442

2010-09-20 Thread Shanjit Singh Jajmann 
Sir/Ma'am,

I am actually facing problem with this particular bug(
http://bugs.sugarlabs.org/ticket/1442 ), it would be helpful if a few
pointers be provided. Also if someone could elaborate on how to check
between sugar / activity Compatibility it would be helpful.

Regards
Shan
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel