Re: [Sugar-devel] [PATCH sugar 0/7] Remove last hippo occurrences from the shell
On 08/13/2012 11:23 PM, Simon Schampijer wrote: On 08/06/2012 12:04 PM, Simon Schampijer wrote: This is a patch series to make the Sugar shell hippo free. Based on the work that has been done in [1] and [2]. It incorporates the patch from Sascha to move the EventIcon into the shell temporary. I merged those patches now with the suggestions made in the review. The work has been gone through several eyes, never less if you find any issues please report them so we can fix them. Regards, Simon If you find issues regarding the 'nohippo' changes please add the 'nohippo' keyword. I created an rpm (from current master) to test on the XO [1] with the latest 12.1.0 build [2]. Just found one regression, only visible on the XO, regarding displaying of thumbnails in the Journal [3]. So please test and keep the bug reports coming. If we are stable in regards to the hippo changes next Monday I will make an official no-hippo release. Regards, Simon [1] http://dev.laptop.org/~erikos/nohippo/sugar-0.97.1-1.fc17.olpc.noarch.rpm [2] http://wiki.laptop.org/go/Release_notes/12.1.0 [3] http://bugs.sugarlabs.org/ticket/3804 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar 0/7] Remove last hippo occurrences from the shell
On 08/06/2012 12:04 PM, Simon Schampijer wrote: This is a patch series to make the Sugar shell hippo free. Based on the work that has been done in [1] and [2]. It incorporates the patch from Sascha to move the EventIcon into the shell temporary. I merged those patches now with the suggestions made in the review. The work has been gone through several eyes, never less if you find any issues please report them so we can fix them. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH sugar 0/7] Remove last hippo occurrences from the shell (v2)
This is a patch series to make the Sugar shell hippo free. Based on the work that has been done in [1] and [2]. It incorporates the patch from Sascha to move the EventIcon into the shell temporary. [1] http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port [2] http://git.sugarlabs.org/~erikos/sugar-toolkit/erikos-shell-port Daniel Narvaez (3): Move SpreadLayout logic to favoriteslayout.py Remove hippo mentions Drop unused intro.py Simon Schampijer (4): SugarEventIcon: Add a hippo-free implementation of the CanvasIcon ControlPanel AboutMe section: use the EventIcon from the shell Views: Replace the hippo based layout with one using GTK+ containers Journal: set white background in the ExpandedEntry of the Detail View docs/controls.txt | 3 +- extensions/cpsection/aboutme/view.py | 27 +-- src/intro/intro.py| 271 --- src/jarabe/desktop/Makefile.am| 4 +- src/jarabe/desktop/favoriteslayout.py | 390 + src/jarabe/desktop/favoritesview.py | 398 -- src/jarabe/desktop/friendview.py | 31 +-- src/jarabe/desktop/grid.py| 3 + src/jarabe/desktop/groupbox.py| 51 ++--- src/jarabe/desktop/homebox.py | 22 +- src/jarabe/desktop/homewindow.py | 2 + src/jarabe/desktop/meshbox.py | 119 +- src/jarabe/desktop/networkviews.py| 28 +-- src/jarabe/desktop/snowflakelayout.py | 103 + src/jarabe/desktop/spreadlayout.py| 89 src/jarabe/desktop/transitionbox.py | 50 + src/jarabe/journal/detailview.py | 73 +++ src/jarabe/journal/expandedentry.py | 342 + src/jarabe/journal/keepicon.py| 61 +++--- src/jarabe/journal/listview.py| 50 ++--- src/jarabe/view/Makefile.am | 1 + src/jarabe/view/buddyicon.py | 10 +- src/jarabe/view/eventicon.py | 277 +++ src/jarabe/view/pulsingicon.py| 11 +- 24 files changed, 1115 insertions(+), 1301 deletions(-) delete mode 100644 src/intro/intro.py delete mode 100644 src/jarabe/desktop/spreadlayout.py create mode 100644 src/jarabe/view/eventicon.py -- 1.7.11.2 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar 0/7] Remove last hippo occurrences from the shell
On 08/06/2012 02:18 PM, Sascha Silbe wrote: Simon Schampijer writes: This is a patch series to make the Sugar shell hippo free. Based on the work that has been done in [1] and [2]. It incorporates the patch from Sascha to move the EventIcon into the shell temporary. [...] Thanks for the patch series and especially for the detailed descriptions, they are rather helpful! One thing I noticed while working on the UI tests (or rather the prerequisite, making Sugar "accessible"): The Owner Icon is the _last_ entry in the list, at least for the Home View. Can we make it the first one instead (without going to great lengths)? With the version I tested, there was also some issue with positioning; IIRC the Owner Icon was off-center. Has this been fixed? Are there any (other) known bugs? I've discussed the approach for both the hippo removal series and the GTK3 port with a couple of community members over the past few weeks and we agreed that we should focus on the architecture (i.e. external API, internal API, interactions with other components / APIs) and work towards merging the patches sooner rather than later. We fully expect there to be major bugs, but by merging early we enable a) widespread manual testing and b) development of automated UI tests that can verify the GTK3 port against the current behaviour of the GTK2 version. Unless we can't solve a number of technical issues [1] with accessibility support, my plan would be to do things in this order: 1. Merge hippo removal patch series. 2. Finish and merge accessibility patch series. It should be complete enough to test all major parts of the UI. Accessibility support for humans (e.g. using screen readers) is only a side effect at this stage, not a goal. Help with this effort (especially fixing the current blockers [1]) would be quite appreciated. Is there a branch to look at the scope of this work? What is the timeframe for this? Do you have some more background info on the subject, e.g. a Feature page. Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar 0/7] Remove last hippo occurrences from the shell
Simon Schampijer writes: > This is a patch series to make the Sugar shell hippo free. Based on the > work that has been done in [1] and [2]. It incorporates the patch from > Sascha to move the EventIcon into the shell temporary. [...] Thanks for the patch series and especially for the detailed descriptions, they are rather helpful! One thing I noticed while working on the UI tests (or rather the prerequisite, making Sugar "accessible"): The Owner Icon is the _last_ entry in the list, at least for the Home View. Can we make it the first one instead (without going to great lengths)? With the version I tested, there was also some issue with positioning; IIRC the Owner Icon was off-center. Has this been fixed? Are there any (other) known bugs? I've discussed the approach for both the hippo removal series and the GTK3 port with a couple of community members over the past few weeks and we agreed that we should focus on the architecture (i.e. external API, internal API, interactions with other components / APIs) and work towards merging the patches sooner rather than later. We fully expect there to be major bugs, but by merging early we enable a) widespread manual testing and b) development of automated UI tests that can verify the GTK3 port against the current behaviour of the GTK2 version. Unless we can't solve a number of technical issues [1] with accessibility support, my plan would be to do things in this order: 1. Merge hippo removal patch series. 2. Finish and merge accessibility patch series. It should be complete enough to test all major parts of the UI. Accessibility support for humans (e.g. using screen readers) is only a side effect at this stage, not a goal. Help with this effort (especially fixing the current blockers [1]) would be quite appreciated. 3a. Develop a UI test suite based on the latest GTK2 version of Sugar. 3b. Finish and merge GTK3 port. 3a. and 3b. can happen in parallel. Caspar and me would still review the patches and make a couple of suggestions where the patches can be _easily_ improved, but in general we'd focus on the interfaces rather than the implementation. Would that work for you? Sascha [1] message-id:toeehnrlhad@twin.sascha.silbe.org https://mail.gnome.org/archives/gnome-accessibility-list/2012-July/msg00029.html -- http://sascha.silbe.org/ http://www.infra-silbe.de/ pgpU3QHJvpLsY.pgp Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH sugar 0/7] Remove last hippo occurrences from the shell
This is a patch series to make the Sugar shell hippo free. Based on the work that has been done in [1] and [2]. It incorporates the patch from Sascha to move the EventIcon into the shell temporary. [1] http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port [2] http://git.sugarlabs.org/~erikos/sugar-toolkit/erikos-shell-port Daniel Narvaez (3): Move SpreadLayout logic to favoriteslayout.py Remove hippo mentions Drop unused intro.py Simon Schampijer (4): SugarEventIcon: Add a hippo-free implementation of the CanvasIcon ControlPanel AboutMe section: use the EventIcon from the shell Views: Replace the hippo based layout with one using GTK+ containers Journal: set white background in the ExpandedEntry of the Detail View docs/controls.txt | 3 +- extensions/cpsection/aboutme/view.py | 27 +-- src/intro/intro.py| 271 --- src/jarabe/desktop/Makefile.am| 4 +- src/jarabe/desktop/favoriteslayout.py | 390 + src/jarabe/desktop/favoritesview.py | 398 -- src/jarabe/desktop/friendview.py | 31 +-- src/jarabe/desktop/grid.py| 3 + src/jarabe/desktop/groupbox.py| 51 ++--- src/jarabe/desktop/homebox.py | 22 +- src/jarabe/desktop/homewindow.py | 2 + src/jarabe/desktop/meshbox.py | 119 +- src/jarabe/desktop/networkviews.py| 28 +-- src/jarabe/desktop/snowflakelayout.py | 103 + src/jarabe/desktop/spreadlayout.py| 89 src/jarabe/desktop/transitionbox.py | 50 + src/jarabe/journal/detailview.py | 73 +++ src/jarabe/journal/expandedentry.py | 342 + src/jarabe/journal/keepicon.py| 61 +++--- src/jarabe/journal/listview.py| 50 ++--- src/jarabe/view/Makefile.am | 1 + src/jarabe/view/buddyicon.py | 10 +- src/jarabe/view/eventicon.py | 277 +++ src/jarabe/view/pulsingicon.py| 11 +- 24 files changed, 1115 insertions(+), 1301 deletions(-) delete mode 100644 src/intro/intro.py delete mode 100644 src/jarabe/desktop/spreadlayout.py create mode 100644 src/jarabe/view/eventicon.py -- 1.7.11.2 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel